[Koha-bugs] [Bug 12056] Untranslatable strings in calendar

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12056

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 26920
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26920
Bug 12056 - Untranslatable strings in calendar

Review of attachment 26920:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12056&attachment=26920)
-----------------------------------------------------------------

Okay. Eyeballed. Now to test.

::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt
@@ +4,4 @@
>  [% INCLUDE 'calendar.inc' %]
>  <link rel="stylesheet" type="text/css" href="[% themelang %]/css/datatables.css" />
>  [% INCLUDE 'datatables.inc' %]
> +<script type="text/javascript">

Simplified. Removed deprecated language tag
(http://www.w3.org/TR/html401/interact/scripts.html section 18.2).

@@ +8,4 @@
>  //<![CDATA[
>      var weekdays = new Array(_("Sundays"),_("Mondays"),_("Tuesdays"),_("Wednesdays"),_("Thursdays"),_("Fridays"),_("Saturdays"));
>  
> +    /* Creates all the structures to deal with all different kinds of holidays */

Corrected spelling of different on comment.

@@ +120,2 @@
>          } else if ( week_days[weekDay] != null ){
> +            return [true, "repeatableweekly", _("Weekly holiday") + ": "+week_days[weekDay].title];

Corrected spelling of holiday.

@@ +122,2 @@
>          } else if ( day_month_holidays[dayMonth] != null ) {
> +            return [true, "repeatableyearly", _("Yearly holiday") + ": "+day_month_holidays[dayMonth].title];

Corrected spelling of holiday.

@@ +126,2 @@
>          } else {
> +            return [true, "normalday", _("Normal day")];

The _() around the string makes it able to be translated, hence these changes.

@@ +274,2 @@
>                  <label for="showDescription">Description:</label>
> +                <textarea rows="2" cols="40" id="showDescription" name="showDescription"></textarea>

White space clean up.

@@ +280,4 @@
>                  <div class="hint">You can make an exception for this holiday rule. This means that you will be able to say that for a repeatable holiday there is one day which is going to be an exception.</div>
>              </div></li>
>              <li class="radio"><input type="radio" name="showOperation" id="showOperationExcRange" value="exceptionrange" />
> +                <label for="showOperationExcRange">Generate exceptions on a range of dates.</label>

Corrected the for attribute value.

@@ +305,4 @@
>              </ol>
>              <fieldset class="action">
>                  <input type="submit" name="submit" value="Save" />
> +                <a href="#" class="cancel" onclick=" hidePanel('showHoliday');">Cancel</a>

Removed name attribute and value. Not in HTML 5.

@@ -359,5 @@
>                              </li>
>              <li class="radio"><input type="radio" name="newOperation" id="newOperationField" value="holidayrange" />
>                              <label for="newOperationField">Holidays on a range</label>.
>                              <a href="#" class="helptext">[?]</a>
> -                            <div class="hint">Make a single holiday on a range. For example, selecting August 1st, 2012  and August 10st, 2012 will make all days between 1st and 10st holiday, but will not affect August 1-10 in other years.</div>

10st?! Glad this is getting fixed.

@@ +365,5 @@
>                              </li>
>              <li class="radio"><input type="radio" name="newOperation" id="newOperationFieldyear" value="holidayrangerepeat" />
>                              <label for="newOperationFieldyear">Holidays repeated yearly on a range</label>.
>                              <a href="#" class="helptext">[?]</a>
> +                            <div class="hint">Make a single holiday on a range repeated yearly. For example, selecting August 1, 2012  and August 10, 2012 will make all days between August 1 and 10 a holiday, and will affect August 1-10 in other years.</div>

Whole bunch of 'st' removals and cleanups.

@@ +376,4 @@
>                  </li></ol>
>                  <fieldset class="action">
>                      <input type="submit" name="submit" value="Save" />
> +                    <a href="#" class="cancel" onclick=" hidePanel('newHoliday');">Cancel</a>

Removed name attribute and value. Name attribute does not exist in HTML 5.

@@ +413,4 @@
>      <ul>
>          <li>Search in the calendar the day you want to set as holiday.</li>
>          <li>Click the date to add or edit a holiday.</li>
> +        <li>Enter a title and description for the holiday.</li>

Corrected spelling of holiday.

-- 
You are receiving this mail because:
You are watching all bug changes.