[Koha-bugs] [Bug 11995] Followup for Bug 7688 - FIX GetNextDate in serialsUpdate.pl

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11995

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26559|0                           |1
        is obsolete|                            |

--- Comment #4 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 26940
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26940&action=edit
[SIGNED OFF] Bug 11995: Followup for Bug 7688 - FIX GetNextDate in
serialsUpdate.pl

Bug 7688 changes the prototype for GetNextDate. The serialsUpdate.pl
cronjob script has not been updated.

Test plan:
Before applying the patch:
1/ Check that the following SQL query returns something:
SELECT serial.*
FROM serial
LEFT JOIN subscription ON (subscription.subscriptionid = serial.subscriptionid)
WHERE serial.status = 1
AND DATE_ADD(planneddate, INTERVAL CAST(graceperiod AS SIGNED) DAY) < NOW()
AND subscription.closed = 0;
2/ Run misc/cronjobs/serialsUpdate.pl -v
   It should die with an error message like this:
   Can't use string ("2011-03-05") as a HASH ref while "strict refs" in use
3/ Apply the patch
4/ Run misc/cronjobs/serialsUpdate.pl -v
   It should exit normally and print messages like this:
   Serial issue with id=XX updated
5/ Run the Koha QA test tools.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

NOTE: The only file modified is misc/cronjobs/serialsUpdate.pl
      The error is caused by switching the order of a hash and
      parameter. This also corrects the date used to be
      publisheddate instead of planneddate, because the latter
      does not logically predict the next one. See comment #3.
      The id=XX's listed in step 4 match the ids displayed by
      the SQL query in step 1.

-- 
You are receiving this mail because:
You are watching all bug changes.