[Koha-bugs] [Bug 11508] Untranslatable pull-down in auth_subfields_structure.pl

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Apr 11 20:42:04 CEST 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11508

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
The change to the template includes improperly nested [% IF %]s inside HTML
tags:

<option value= "0" [%- IF ( loo.ohidden.default ==  0 )
-%]selected="selected"[%- END -%]>Show all</option>

This should be written:

[%- IF ( loo.ohidden.default ==  0 ) -%]
    <option value= "0" selected="selected">Show all</option>
[%- ELSE -%
    <option value= "0">Show all</option>
[%- END -%]

This is because of problems the translation script has with parsing template
directives nested inside tags:

http://wiki.koha-community.org/wiki/Coding_Guidelines#HTML1:_Template_Toolkit_markup_inside_HTML

This should have been caught by the QA tool, but it looks like the "-" in "[%-
IF" isn't an expected pattern. It would be nice if the QA test tool were
updated to be aware of that construction.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list