[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010

--- Comment #28 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 27049
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27049
Bug 5010: Fix incomplete links in carts and lists sent from the staff client

Review of attachment 27049:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=5010&attachment=27049)
-----------------------------------------------------------------

::: basket/sendbasket.pl
@@ +102,5 @@
>  
> +    if (C4::Context->preference('OPACBaseURL')){
> +        my $protocol = C4::Context->preference('OpacProtocol') // 'http://';
> +        $template2->param( OPACBaseURL => $protocol . C4::Context->preference('OPACBaseURL') );
> +    }

koha-tmpl/intranet-tmpl/prog/en/modules/basket/sendbasketform.tt does not have
OPACBaseURL in it. However, doc-head-close.inc does. This is a short-term fix,
as the problem in doc-head-close.inc affects much more than just carts and
lists.

::: koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/sendshelf.tt
@@ +35,4 @@
>  LCCN: [% BIBLIO_RESULT.lccn %][% END %][% IF ( BIBLIO_RESULT.url ) %]
>  URL : [% BIBLIO_RESULT.url %][% END %][% IF ( OPACBaseURL ) %]
>  In the online catalog:
> +    [% Koha.Preference( 'OPACProtocol' ) %][% OPACBaseURL %]/cgi-bin/koha/opac-detail.pl?biblionumber=[% BIBLIO_RESULT.biblionumber |url %][% END %]

Took Kyle's second suggestion from comment #21.

::: opac/opac-sendshelf.pl
@@ +109,5 @@
>  
> +    if (C4::Context->preference('OPACBaseURL')){
> +          $template2->param( OPACBaseURL => C4::Context->preference('OPACBaseURL') );
> +    }
> +

Oops. I think I let a bad piece in.

::: virtualshelves/sendshelf.pl
@@ +103,2 @@
>    if (C4::Context->preference('OPACBaseURL')){
> +        $template2->param( OPACBaseURL => C4::Context->preference('OPACBaseURL') );

This represents changing it back to what it was initially.

@@ -104,2 @@
>    if (C4::Context->preference('OPACBaseURL')){
> -        $template2->param( OPACBaseURL => $protocol . C4::Context->preference('OPACBaseURL') );

The protocol logic is moved to the template now. Only need the OPACBaseURL,
which is not available by default for staff client pages.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.