[Koha-bugs] [Bug 11846] Correct database update for debarments with 9999-12-31

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11846

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27079|0                           |1
        is obsolete|                            |

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 27093
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27093&action=edit
Bug 11846 - Correct database update for debarments with 9999-12-31

The borrowers with infinite debarments have borrowers.debarred with
'9999-12-31'.
Database update for this bug contained :
  INSERT INTO borrower_debarments ( borrowernumber, expiration, comment )
SELECT borrowernumber, debarred, debarredcomment FROM borrowers WHERE debarred
IS NOT NULL
For borrowers where borrowers.debarred is '9999-12-31', this value is copied
into borrower_debarments.expiration.
This is not correct because borrower_debarments.expiration must be NULL for
infinite debarments.

This patch corrects update 3.13.00.035 and also adds an update for databases
already updated.

Test plan :
- Use a database with version 3.13.00.000
- Set a borrower as restricted for ever (leave until empty)
- Use sources to master + patch
- Perform updatedatabase
- Look at borrower details, tab "Restrictions"
=> Without patch, you see Expiration 31/12/9999
=> With patch, you see Expiration Infinite

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
I tested both db revisions by resetting Version of my database (and
adding a SetVersion after the revised older dbrev). This was possible since
the debarred field still exists in borrowers. (I have my doubts about that,
but that goes outside the scope of this report.)
Also note that routine _UpdateBorrowerDebarmentFlags puts back 9999-12-31
into borrowers for indefinite debarments (which looks not very consistent).

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.