[Koha-bugs] [Bug 7180] Order from staged file improvements

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

--- Comment #207 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
** Automated tests and QA script **

Passes all tests in t, xt, and
  t/db_dependent/Budgets.t
  t/db_dependent/Acquisition.t
  t/db_dependent/Acquisition/
Passes QA script.


New GetBudgetByCode() covered by tests in t/db_dependent/Budgets.t.

** Code review **

+ <span class="checkall"><a id="checkAll" href="#">Check All</a></span>
+ <span class="uncheckall"><a id="unCheckAll" href="#">Uncheck All</a></span>
BUG (trivial) Capitalization, please fix in a follow up.

+ <label for="sort1_record_[% biblio.import_record_id %]">Planning value 1:
</label>
+ <label for="sort2_record_[% biblio.import_record_id %]">Planning value 2:
</label>
+ <label for="sort2">Planning value 2: </label>
BUG (trivial) Should be "Statistic 1" "Statistic 2" to match neworderempty.pl, 
              please fix in a follow up.


** Database update

Adds a new system preference MarcFieldsToOrder, inludes changes to 
sysprefs.sql, database update and .pref file. 
syspref.sql and database update are identical.

acquisitions.pref
+  - "For example:<br/>price: 947$a|947$c<br/>quantity: 969$h<br/>budget_code:
922$a<rb/>"
BUG (minor) Fix </rb>.


** Regression testing **

* Current functionality (some notes for comparision)

File list / addorderiso2709.pl
- List of files that include 'staged' records is shown, details include
  file name, comments, status, and staged date
- Bug: # Bibs is not shown (bug 9063)

List of staged records / addorderiso2709.pl
- Information in the list only includes title, isbn/issn, there is
  no way to preview a record
- Clicking on 'Add order' will import the record into the catalog
  and set the status to 'imported'.
- You can choose to import all records at once, using the Accounting
  details section. Options are: currency, budget (should be fund),
  notes, planning value1, planning value2
- Bug: Fund list shows all funds, including inactive funds (bug 10302)
- Bug: Statistic values don't reload on selecting a fund, only when
  refreshing the page

New order form / neworderempty.pl
- Replacing ajax-getauthvaluedropbox.pl with fetch_sort_dropbox.pl
  Used on neworderempty to show the correct values for Statistic 1 + 2
  on selecting a fund.

* Retested with patches applied

File list / addorderiso2709.pl
- List of files that include 'staged' records is shown, details include
  file name, comments, status, and staged date
  -> Still ok.
- Bug: # Bibs is not shown (bug 9063)
  -> Still broken.

List of staged records / addorderiso2709.pl
- Information in the list only includes title, isbn/issn, there is
  no way to preview a record
  -> MARC preview and Card preview are added
     BUG (normal): clicking on the 'Card' view, results in a 404 error page.
- Clicking on 'Add order' will import the record into the catalog
  and set the status to 'imported'.
  -> Still works the same.
- You can choose to import all records at once, using the Accounting
  details section. Options are: currency, budget (should be fund),
  notes, planning value1, planning value2
  -> Options are on a new tab: 
- Bug: Fund list shows all funds, including inactive funds (bug 10302)
  -> Still broken.
- Bug: Statistic values don't reload on selecting a fund, only when
  refreshing the page
  -> BUG (normal): Switching funds 
     works now, but when one of the Statistic values is a free text 
     (no linked authorized value) an 'undefined' text appears in the
     input field. Only happens on the Default accounting details tab,
     neworderempty and the details for single orders are ok.
  -> BUG (normal): Importing and leaving the statistic value free
     text field empty, will write an 'undefined' into aqorders.sort*

New order form / neworderempty.pl
- Replacing ajax-getauthvaluedropbox.pl with fetch_sort_dropbox.pl
  Used on neworderempty to show the correct values for Statistic 1 + 2
  on selecting a fund.   
  -> Works.

** New functionality **

* GUI
- BUG (trivial): The border of the order details section shows without
    having the details open (see screenshot). Please take a look.
- SUGGESTION: Remove some of the 'bold', maybe only keep the titles
    bold, but not the links?
- SUGGESTION: Change links to read: ( MARC | Card | Add order ) instead
    of ( Show MARC | Card ; Add order )
- BUG (trivial): Change formatting of the discount field to match 
    formatting on neworderempty.pl, bit shorter and adding %
- BUG (minor): Pull discount value from the vendor. I was not sure 
    if the vendor discount would be used now or not, this way it would
    be clear.
- BUG/SUGGESTION Add a note on the Default accounting details tab
    to clarify when these settings will be taken into account - only
    for all/selected titles? Similar to the Item information tab.
- BUG (major): In my tests I added 12.00 as the price for one record, 
    and 10 as percentage for the discount. When looking at the record 
    in the basket, the list price shows as: -1.21

* MarcFieldsToOrder

- Still needs to be tested!
  QUESTION Are there other fields available not listed in the example?
         Could we improve the description to give a complete list?
         price: 947$a|947$c
         quantity: 969$h
         budget_code: 922$a

-- 
You are receiving this mail because:
You are watching all bug changes.