[Koha-bugs] [Bug 7180] Order from staged file improvements

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

--- Comment #209 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Katrin Fischer from comment #207)

> + <span class="checkall"><a id="checkAll" href="#">Check All</a></span>
> + <span class="uncheckall"><a id="unCheckAll" href="#">Uncheck All</a></span>
> BUG (trivial) Capitalization, please fix in a follow up.

Fixed.


> BUG (trivial) Should be "Statistic 1" "Statistic 2" to match
> neworderempty.pl, 
>               please fix in a follow up.

Fixed.

> acquisitions.pref
> +  - "For example:<br/>price: 947$a|947$c<br/>quantity:
> 969$h<br/>budget_code: 922$a<rb/>"
> BUG (minor) Fix </rb>.

Fixed.

> - Bug: # Bibs is not shown (bug 9063)
>   -> Still broken.

I am going to provide a patch for bug 9063.

> List of staged records / addorderiso2709.pl
> - Information in the list only includes title, isbn/issn, there is
>   no way to preview a record
>   -> MARC preview and Card preview are added
>      BUG (normal): clicking on the 'Card' view, results in a 404 error page.

I cannot reproduce, the link is catalogue/showmarc.pl?viewas=card&id=230 and
the preview works.

> - Bug: Fund list shows all funds, including inactive funds (bug 10302)
>   -> Still broken.

See bug 10875 for a patch.

>   -> BUG (normal): Switching funds 
>      works now, but when one of the Statistic values is a free text 
>      (no linked authorized value) an 'undefined' text appears in the
>      input field. Only happens on the Default accounting details tab,
>      neworderempty and the details for single orders are ok.

Fixed.

>   -> BUG (normal): Importing and leaving the statistic value free
>      text field empty, will write an 'undefined' into aqorders.sort*

I cannot reproduce. Maybe it is fixed with previous fix.

> ** New functionality **
> 
> * GUI
> - BUG (trivial): The border of the order details section shows without
>     having the details open (see screenshot). Please take a look.

See comment 36: "- I think instead of having the full form on each entry it
would save a lot of space if we could only display it for selected records and
keep the smaller layout for when now records are selected."

> - SUGGESTION: Remove some of the 'bold', maybe only keep the titles
>     bold, but not the links?

Done.

> - SUGGESTION: Change links to read: ( MARC | Card | Add order ) instead
>     of ( Show MARC | Card ; Add order )

Done.

> - BUG (trivial): Change formatting of the discount field to match 
>     formatting on neworderempty.pl, bit shorter and adding %

Done.

> - BUG (minor): Pull discount value from the vendor. I was not sure 
>     if the vendor discount would be used now or not, this way it would
>     be clear.

I am not sure to understand, could you detail?

> - BUG/SUGGESTION Add a note on the Default accounting details tab
>     to clarify when these settings will be taken into account - only
>     for all/selected titles? Similar to the Item information tab.

I tried to fix that...

> - BUG (major): In my tests I added 12.00 as the price for one record, 
>     and 10 as percentage for the discount. When looking at the record 
>     in the basket, the list price shows as: -1.21

Fixed! The discount was divided by 100 if > 100. Which is wrong! It should be
divided by 100 if > 1.

>   QUESTION Are there other fields available not listed in the example?
>          Could we improve the description to give a complete list?

Done.

-- 
You are receiving this mail because:
You are watching all bug changes.