[Koha-bugs] [Bug 7180] Order from staged file improvements

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

--- Comment #213 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Katrin Fischer from comment #210)
> Hi Jonathan, 
> 
> the card views are all broken for me, tried several, my link is:
> http://localhost:8080/cgi-bin/koha/catalogue/showmarc.pl?viewas=card&id=644
> 
> Could it be MARC flavour specific? I remember we had problems with the card
> view in the past where this seemed to be part of the problem.

Looking at the code (catalogue/showmarc.pl), the redirect to 404 is done if
new_from_usmarc or GetMarcBiblio returns something undefined. It should not
append.

  if ($importid) {
      my ($marc) = GetImportRecordMarc($importid);
      $record = MARC::Record->new_from_usmarc($marc);
  }
  else {
      $record =GetMarcBiblio($biblionumber);
  }
  if(!ref $record) {
      print $input->redirect("/cgi-bin/koha/errors/404.pl");
      exit;
  }

Could you attach the imported record to this report?

> > - BUG (minor): Pull discount value from the vendor. I was not sure 
> >     if the vendor discount would be used now or not, this way it would
> >     be clear.
> 
> I am not sure to understand, could you detail?
> 
> The discount fields are all empty - so I was not sure what to do - put 0 in
> it to disable the vendor discount? Do I have to enter my normal discount? It
> would be a bit more clear when the dicount fields were prefilled with the
> standard dicsount from the vendor.

Hum, it could be a good idea. But if a user wants to import a batch with a
specific discount, (s)he will have to remove values manually and add the
default one in the accounting defails tab.

> > * GUI
> > - BUG (trivial): The border of the order details section shows without
> >     having the details open (see screenshot). Please take a look.
> 
> See comment 36: "- I think instead of having the full form on each entry it
> would save a lot of space if we could only display it for selected records
> and keep the smaller layout for when now records are selected."
> 
> I still think that :) It's just cosmetig, I think the doubled up border for
> collapsed entries looks a bit strange, it's all ok, once you open the entry.
> But this can totally be fixed later - trivial :)

Ho yes sorry, I read that too quickly.
Fixed (as I can).

-- 
You are receiving this mail because:
You are watching all bug changes.