[Koha-bugs] [Bug 12080] Superserials permission appears to be broken

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12080

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> ---
>From C4::Serials::can_edit_subscription:

        or C4::Auth::haspermission( $userid, {serials => 'superserials'}),
        or C4::Auth::haspermission( $userid, {serials => 'edit_subscription'}),

If a user has edit_subscription he cans edit a subscription (without having
superserials).

But
        or $subscription->{branchcode} eq C4::Context->userenv->{'branch'}

Means: if the user is on the same branch, he cans edit it too.
So a user can edit a subscription without having the edit_subscription
permission... hum...

Who wrote this code??
(...)

-- 
You are receiving this mail because:
You are watching all bug changes.