[Koha-bugs] [Bug 9551] OPACMobileUserCSS being overriden by OPACUserCSS

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9551

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #6 from M. Tompsett <mtompset at hotmail.com> ---
I noticed this patch doesn't apply still. However, the idea of the patch is
pretty obvious: put the OPACMobileUserCSS before OPACUserCSS.

I noticed that the reason it doesn't apply is because of the bidi logic. I also
noticed that the prog and ccsr themes handle the ordering of the bidi logic
differently.

Karam Qubsi in bug 10017 fixed right-to-left in the ccsr theme.
Jared Camins-Esakov in bug 10405 added ids for the ccsr theme.
D Ruth Bavousett in bug 8061 applies a patch similar to 10017's to the prog
theme.
Jared Camins-Esakov in bug 10405 added ids for the prog theme too.

mtompset at ubuntu:~/kohaclone$ git blame -L25,35
koha-tmpl/opac-tmpl/ccsr/en/includes/doc-head-close.inc
3229d8b1 (Frédérick Capovilla 2012-08-12 18:32:45 -0400 25) <meta
3229d8b1 (Frédérick Capovilla 2012-08-12 18:32:45 -0400 26) <link
2beeedaf (Karam Qubsi         2013-04-08 15:17:30 +0300 27) [% IF ( bidi ) %]
2beeedaf (Karam Qubsi         2013-04-08 15:17:30 +0300 28)     <link
2beeedaf (Karam Qubsi         2013-04-08 15:17:30 +0300 29) [% END %]
6b5960cc (Jared Camins-Esakov 2013-06-08 16:16:07 -0400 30) ...[% OPAC
6b5960cc (Jared Camins-Esakov 2013-06-08 16:16:07 -0400 31) ...[% OPACUserCSS
47ca7f8f (Chris Cormack       2013-02-25 15:39:02 +1300 32) [% IF persona %]
47ca7f8f (Chris Cormack       2013-02-25 15:39:02 +1300 33)  <link
47ca7f8f (Chris Cormack       2013-02-25 15:39:02 +1300 34) [% END %]
47ca7f8f (Chris Cormack       2013-02-25 15:39:02 +1300 35)

mtompset at ubuntu:~/kohaclone$ git blame -L25,35
koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc
493dcede (Chris Cormack       2013-02-11 22:34:20 +1300 25) [% END %]
6b5960cc (Jared Camins-Esakov 2013-06-08 16:16:07 -0400 26) ...[% OPAC
2880e76e (D Ruth Bavousett    2013-04-05 17:58:33 +0300 27) [% IF ( bidi ) %]
2880e76e (D Ruth Bavousett    2013-04-05 17:58:33 +0300 28)     <link
2880e76e (D Ruth Bavousett    2013-04-05 17:58:33 +0300 29) [% END %]
6b5960cc (Jared Camins-Esakov 2013-06-08 16:16:07 -0400 30) ...[% OPACUserCSS
c2fca223 (Owen Leonard        2008-04-15 13:49:48 -0500 31) <!-- yui js -->
5884fb10 (Chris Cormack       2011-04-10 20:38:30 +1200 32) <script
5884fb10 (Chris Cormack       2011-04-10 20:38:30 +1200 33) <script
5884fb10 (Chris Cormack       2011-04-10 20:38:30 +1200 34) <script
5884fb10 (Chris Cormack       2011-04-10 20:38:30 +1200 35) <script

As you can see, ccsr has bidi, OPACMobileUserCSS, and then OPACUserCSS.
The prog theme has OPACMobileUserCSS, bidi, and then OPACUserCSS.
Sorry the OPACMobileUserCSS is chopped off, but formatting nicely is a pain.

This bug as reported may no longer exist. However, there is most definitely
something wrong. PROBLEM 1: What is the correct order of bidi and
OPACMobileUserCSS?

PROBLEM 2: Bootstrap no longer has OPACMobileUserCSS. Is this correct?

-- 
You are receiving this mail because:
You are watching all bug changes.