[Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375

--- Comment #59 from Chris Nighswonger <cnighswonger at foundations.edu> ---
(In reply to Bernardo Gonzalez Kriegel from comment #53)
> Created attachment 26928 [details] [review]
> Bug 8375 - Followup - Fix font code and alignment
> 
> This follow up fixes font code taking it from layout,
> and alignment.

I see no obvious problem with the using prText for alignment (thought I have a
nagging feeling there were some issues with it), however, this fix is applied
in the wrong location in the code. The text justification mechanism is housed
at the module level in C4::Labels::Label[1] and fixes should probably be
applied there or else things will turn to spaghetti pretty fast.

Also, its not apparent how this fix interacts with the existing justification
code, if at all, which makes it further desirable to rewrite/replace it.
Although this patch may fix the immediately apparent problem, there may be
unexpected hidden side effects because of this.

[1]http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Labels/Label.pm;h=cb6a631d9ffbbeca1f96254352575503ec93f861;hb=ffd90a1564328add63ce376a15b097707d5d66be#l443

-- 
You are receiving this mail because:
You are watching all bug changes.