[Koha-bugs] [Bug 12071] javascript broken for a search with double quotes

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12071

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 27272
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27272&action=edit
[PASSED QA] Bug 12071 - Javascript broken for a search with double quotes

In staff interface, when performing a simple search with
a double quote (ie "histoire algerie"), the javascript
is broken in results page because of :

function GetZ3950Terms(){
  var strQuery="&frameworkcode=";
  strQuery += "&" + "title" + "=" + ""histoire%20algerie"";

This patch moves URI escaping from perl to template with uri TT filter.

Test plan :
- In staff interface, perform a search with double quotes
  that will return no result, ie "aaa xxx"
=> Without patch, javascript is broken
=> With patch, javascript is not broken
- Click on Z3950 button on results page
=> Without patch, the Title input is empty
=> With patch, the Title input contains the search terms

Additional test:
Do a search with something like äöü and then click Z3950
button on results page.
Without patch, encoding is broken in Z3950 form
With patch, encoding is correct.

Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Fixed a few tabs. Passes tests and QA script.
I can't reproduce the Javascript problem, but I can reproduce
the Z39.50 encoding problem and can detect no regression.

-- 
You are receiving this mail because:
You are watching all bug changes.