[Koha-bugs] [Bug 7673] New patron permissions

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #42 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---

Hi Julian,

I did some initial testing and code review:

1) I wonder about the names of the new permissions.
   I think a limited edition would be something different - maybe we
   can get a native speaker's opinion on this?
   My suggestion would be:
   - limited_item_edition = restricted_edit_items
   - items_limited_batchmod = restricted_item_batchmod

2) Please include all .sql permission files, so new installations won't 
   miss them. You can check with xt/permissions.t

3) Fix sequence of system preferences
 FAIL   installer/data/mysql/sysprefs.sql
   FAIL   sysprefs_order
        Not blocker: Sysprefs SubfieldsToAllowForLimitedBatchmod 
        is bad placed (see bug 10610)

4) If we are going to rewrite this bit of code, it would be good to 
   remove the use of CGI::scrolling_list (bug 766):
+                $subfield_data{marc_value} =CGI::scrolling_list(@scrparam);

5) System preference description could be more clear. It should note that
   the FA framework is excluded from the permission. Also it could include
   a hint that the example is for UNIMARC and also include a MARC21 example
   to avoid confusion. For us developers it's clear that we use different
   item fields for both flavours, but not so much for librarians I guess.

6) I have my doubts about the superlibrarian checks you used:
&& $limitededition->{'superlibrarian'} eq 1);
+$limitededition = 0 if ($limitededition != 0 &&
$limitededition->{'superlibrarian'} eq 1);
   We now have a specific method to check those:
C4::Context::IsSuperLibrarian()

-- 
You are receiving this mail because:
You are watching all bug changes.