[Koha-bugs] [Bug 12098] User can edit some subcriptions he should be prevented to

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12098

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 27291
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27291&action=edit
[PASSED QA] Bug 12098: Refactor can_*_subscription in C4::Serials

http://bugs.koha-community.org/show_bug.cgi?id=12098

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Tested on top of patches for 12048 and 12080.

Subscription search
- superlibrarian, IndyBranches on/off - always sees all subscriptions
- superserials, IndyBranches on/off - always sees all subscriptions
- no superserials, IndyBranches on - only sees own subscriptions
Note: Subscriptions without branches will only show, when all subscriptions
      are visible. In a future enh it might be good to enforce setting a
      branch, when IndyBranches is used.
- no superserials, IndyBranches off - always sees all subscriptions

Subscription editing
- superlibrarian, IndyBranches on/off - can edit all subscriptions
- superserials, IndyBranches on/off - can edit all subscriptions
- no superserials, IndyBranches on - can only edit own subscriptons and
  subscriptions without branch
  NOTE: it would make sense to also allow Edit > Edit as new (duplicate)
  here, so one can copy the subscription from another branch to modify
  it for the own branch.

Passes tests in t, xt and QA script, also newly provided unit tests.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.