[Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Some notes from a code review, looking at all 5 patches together:

1) opac/opac-idref.pl is missing the license information on top of the file.

2) Should this be a FIXME or even be removed? It seems the code as currently
implements, is UNIMARC + Sudoc only.
+                else {
+                    # unimarcCode and marc21Code

3) Patch only changes the the non-XSLT default view. Please add it to the XSLT
as well or update the pref description so that this won't cause confusion.

4) Changes to the bootstrap theme doesn't seem to include the opac-detail.tt
page? Maybe it got lost in rebase?

4) Why not do a more specific search using Identifier-standard? It seems the
index is updated, but then never used in the new code?
<a href="/cgi-bin/koha/opac-search.pl?q=kw,phr=[% doc.ppn %]"
target="_blank">Koha</a></td>

5) Please add some explanatory note or link to the system preference
description, so people will know what this feature is about and that it is only
useful for UNIMARC SUDOC libraries.

+                yes: Enable
+                no: Disable
+            - the IdRef webservice from the opac detail page

6) Note: The datatables code seems duplicated in various files - should this be
an include? I feel like it is in staff, but maybe not available for the OPAC
yet?

-- 
You are receiving this mail because:
You are watching all bug changes.