[Koha-bugs] [Bug 7180] Order from staged file improvements

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #219 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jonathan, we are almost there, only 2 problems found + testing the internal
note/vendor note after rebase. If you can also rebase bug 10875 I will include
it in my next test.

** Automated tests and QA script **

Passes all tests in t, xt, and
  t/db_dependent/Budgets.t
  t/db_dependent/Acquisition.t
  t/db_dependent/Acquisition/
Passes QA script.

New GetBudgetByCode() covered by tests in t/db_dependent/Budgets.t.


** Code review **

No Capitalization problems found.
No translation problems found.

Terminology: Planning value 1 and 2 should be Statistic 1 and 2.
BUG (trivial) Fixed for picking individual records, but still appears on
  the default accounting details tab.


** Database update

Adds a new system preference MarcFieldsToOrder, inludes changes to 
sysprefs.sql, database update and .pref file. 
syspref.sql and database update are identical.


** Regression testing **

Comparing current functionality with functionality after applying the
patches.

File list - addorderiso2709.pl
- List of files that include 'staged' records is shown, details include
  file name, comments, status, and staged date
- Bug: # Bibs is not shown (bug 9063)
* No regresion, still works like it should. 
  New patch for bug 9063 also fixes the # Bibs problem.

List of staged records - addorderiso2709.pl
- Information in the list only includes title, isbn/issn, there is
  no way to preview a record
* Improved: MARC preview and card preview 
- Clicking on 'Add order' will import the record into the catalog
  and set the status to 'imported'.
* No regression, status is correctly set.
- You can choose to import all records at once, using the Accounting
  details section. Options are: currency, budget (should be fund),
  notes, planning value1, planning value2
* Fund now correctly labelled. Options are now available for batch
  operation and for individual orders. Options include:
  - Individual order: quantity, price, discount, fund, statistic 1 + 2
  - Batch: currency, fund, notes, planning value 1 + 2
  No regression found.
- Bug: Fund list shows all funds, including inactive funds (bug 10302)
* No regression. Patches for bug 10302 currently don't apply.
- Bug: Statistic values don't reload on selecting a fund, only when
  refreshing the page
* BUG (normal): On the default accounting details page the refreshing
  doesn't work.
  For individual records it works alright, also on the neworderempty.pl
  page.


New order form / neworderempty.pl
- Replacing ajax-getauthvaluedropbox.pl with fetch_sort_dropbox.pl
  Used on neworderempty to show the correct values for Statistic 1 + 2
  on selecting a fund.   
* No regression, works like it should.


** MarcFieldsToOrder

New system preference allows to include acq data in the uploaded
MARC file.

System preference settings used for testing:
price: 933$a|933$c
quantity: 933$q
sort1: 933$1
sort2: 933$2
discount: 933$d
budget_code: 933$b

Lines included in my records:
933    $a 12.00 $q 12 $b BOOKS1310 $d 5 $1 sort1 $2 sort2
933    $c 12.99 $a 9.00 $q 12 $b BOOKS1310 $d 0.05 $1 sort1 $2 sort2

Looking at the individual details for the first 2 records revealed:
all settings have been imported correctly. Discount should be given as
$, so 0.05 is way too low, 5 is better.

-- 
You are receiving this mail because:
You are watching all bug changes.