[Koha-bugs] [Bug 9915] Allow opac/svc/report to be passed sql parameters

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9915

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27328|0                           |1
        is obsolete|                            |

--- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 27330
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27330&action=edit
[PASSED QA] Bug 9915: (follow-up) use SQL placeholders

This patch teaches C4::Reports::Guided::execute_query()
how to accept a list of query parameter values.  It then
follows-up on the main patch by simplifying how it converts
report parameters to a complete SQL query, and removes the
use of DBI->quote() and complicated regexes.

To test:

[1] Verify that using the OPAC svc/report service with
    sql_params continues to work.
[2] Verify that there are no regressions with running
    reports from the staff interface, both via the web
    service and the reports interface.
[3] Verify that prove -v /db_dependent/Reports_Guided.t passes.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes all tests and QA script.
No regressions found.

-- 
You are receiving this mail because:
You are watching all bug changes.