[Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #63 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Chris Nighswonger from comment #62)
> 
> I think you may be misunderstanding me.
> 
> Using your proposed fix will result in justification code in multiple
> places. This is bad a practice otherwise known as spaghetti code[1]. It also
> makes the "fix" inaccessible via the C4::Labels module by placing it at the
> script level. This is bad practice as no other scripts (existing or future)
> will have access to this "fix."
> 
> Unless this is corrected, I will (as the module maintainer) be forced to
> hold this bug in "failed-QA" status.
> 
> Just to clarify: I have no issue with the proposed fix in principle. We just
> need to put it into the correct place in the code.
>

Chris,
I changed completely the solution. Please, take a look (second patch)
The fix IS in Label.pm, that was the meaning of 'using current code.'

Your were right, I was bypassing current justification code, and that was
wrong.

I found the real problem (non-existent font code and bad parameter to StrWidth)
and fixed that.

-- 
You are receiving this mail because:
You are watching all bug changes.