[Koha-bugs] [Bug 11051] Performance of opac-search

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #29 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to M. de Rooy from comment #28)
> (In reply to Jonathan Druart from comment #27)
> > There are 2 reasons.
> > 1/ I don't see the load difference following the test plan.
> > 2/ There are some calls to
> >   memoize_memcached('subroutine_name', memcached => C4::Context->memcached);
> > in the code.
> > If the call is wrong, we should fix it everywhere. If I am wrong, I am not
> > able to pass qa on it :)
> 
> I installed memcached (and ..) and ran the memoize_memcached call for
> GetMarcStructure and called it in a for loop so many times.
> My findings are:
> 
> 1) As Jonathan pointed out, the call seems to be wrong. If I pass memcached
> =>1 as parameter, I also have: Invalid memcached argument (expected a hash).
> If I pass memcached => {}, it seems to be okay.
> I do not understand why we still find this error. Are other people using
> another version for memcached, Cache::Memcached or Memoize::Memcached?

Memoize::Memcached v0.04 changed the use of isa() in favour of ref() to prevent
deprecation messages in Perl 5.12+. I think Debian's 0.03 package at some point
introduced a similar patch (the package was abandoned, I own it now because of
that).

The problem is (i think, have just arrived from a month without any Perl) that
isa('HASH') was true because it would match all inherited classes (not only the
latest blessed one).

I'll try to fix it (help is welcome), but I don't think i will be available in
Debian soon.

-- 
You are receiving this mail because:
You are watching all bug changes.