[Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375

--- Comment #68 from Chris Nighswonger <cnighswonger at foundations.edu> ---
Created attachment 27482
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27482&action=edit
[SIGNED-OFF] Bug 8375 - Followup - Fix font code and alignment

This patch fixes two problems:
a) Bad PDF when using Helvetica font.
Current label code assigns 'italic' or 'oblique' variants
to title. Helvetica-Oblique was not defined, but is present

b) Bad alignment using center/right justification
Problem was bad font parameter passed to StrWidth
routine

To test:
1. Try making a batch using Helvetica, downloaded PDF do not open.
2. Try a batch of mixed scripts with layout alignment center or right, only
latin scripts align almost correctly.
3. Apply the patch and update your koha-conf.xml to add Oblique variant
4. Try again 1, now PDF opens
5. Try 2, now alignment is correct

New problem (for another bug): DejaVuSans has a good
support for arabic, but not Oblique variant. As selection
of italic/oblique is hardcoded, now Arabic titles are
not displayed. I'll try to add a checkbox to select
or not this feature.

Added a FIXME for the hardcoded forced oblique -chris_n

Signed-off-by: Chris Nighswonger <cnighswonger at foundations.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.