[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #38 from David Cook <dcook at prosentient.com.au> ---
(In reply to Jonathan Druart from comment #35)
> Could it be possible to get some feedback on my proposed patches? The idea
> was not to block the enh but to improve it!

_One_

It appears that one of your patches includes the smart match operator, which is
something we're avoiding due to its deprecated/experimental status in Perl
5.18, I believe.

_Two_

Do you have a test plan to accompany your patches, Jonathan? It seems that the
concept behind your patch and the original are at odds in that the original
allows  finer control of when the options appear. In yours, it appears that the
options always show when viewing "more options" and only show when viewing
"fewer options" if that option is included in the system preference.

I think the idea was to choose between 3 scenarios:

1) Never show the option in advanced search
2) Show it when viewing "more" and "fewer"
3) Show it only when viewing "more"

I think your patch only covers scenarios #2 and #3. Is that correct?

I'm not a huge fan of governing this behaviour using system preferences, but I
think I prefer the 3 choices rather than 2.

_Three_

I think Owen has been making an effort to move the Javascript libraries out of
the /en/ directory and put it higher up so that it isn't needlessly duplicated
in the translations, so it would probably make sense to move the JS higher up
the directory tree.

_Four_

I think there might be another bug out there that seeks to add multiple options
for system preferences...but I might be mistaken.

_Five_

It looks like this patch will need to rebase due to the updatedatabase.pl being
too old now.

---

I hope that helps!

-- 
You are receiving this mail because:
You are watching all bug changes.