[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #39 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to David Cook from comment #38)

Thanks David to revive this bug!

> It appears that one of your patches includes the smart match operator, which
> is something we're avoiding due to its deprecated/experimental status in
> Perl 5.18, I believe.

Will be fixed.

> Do you have a test plan to accompany your patches, Jonathan?

Will be added.

> In yours, it
> appears that the options always show when viewing "more options" and only
> show when viewing "fewer options" if that option is included in the system
> preference.

> I think your patch only covers scenarios #2 and #3. Is that correct?

Yes, good catch. I will add a new pref for that.

> I'm not a huge fan of governing this behaviour using system preferences, but
> I think I prefer the 3 choices rather than 2.

I don't see another way to do that.

> I think Owen has been making an effort to move the Javascript libraries out
> of the /en/ directory and put it higher up so that it isn't needlessly
> duplicated in the translations, so it would probably make sense to move the
> JS higher up the directory tree.

At the OPAC, not at the staff interface.

> I think there might be another bug out there that seeks to add multiple
> options for system preferences...but I might be mistaken.

Not sure. If someone agree with my patches, I think the first patch should be
abandoned. Otherwise, We are going to create 6 prefs and remove them just
after.

> It looks like this patch will need to rebase due to the updatedatabase.pl
> being too old now.

Will be rebased.

> I hope that helps!

Of course!

-- 
You are receiving this mail because:
You are watching all bug changes.