[Koha-bugs] [Bug 12138] Use placeholders in translatable javascript strings
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Fri Apr 25 16:58:35 CEST 2014
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12138
Owen Leonard <oleonard at myacpl.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27580|0 |1
is obsolete| |
--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 27639
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27639&action=edit
Bug 12138 - Use placeholders in translatable javascript strings
Currently translating javascript strings with variables in them is hard,
because the strings are created from separate parts. For example:
_("Are you sure you want to delete the") + " " + count + " " +
_("attached items?")
This is translated in two different parts, and the translator cannot
affect the place where the count-variable is.
Now, if the javascript strings allowed placeholders, similar to how the
template strings do, the above could be written as:
_("Are you sure you want to delete the %s attached
items?").format(count)
This would make translation much easier.
Attached patch adds a javascript string formatter, and changes all the
concatenated translatable js strings used in intranet to use that.
To test:
1) cd misc/translator
2) perl translate update xx-YY
3) grep ^msgid po/xx-YY-i-staff-t-prog-v-3006000.po | sort | uniq >
xx-YY-pre
4) apply patch
5) perl translate update xx-YY
6) grep ^msgid po/xx-YY-i-staff-t-prog-v-3006000.po | sort | uniq >
xx-YY-post
7) compare the files: diff -Nurd xx-YY-pre xx-yy-post | less
should show the javascript strings that changed.
8) Test the UIs where the formatted js strings are used.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
I tested *most* of the changed files. There were some instances where it
wasn't clear to me how to trigger the warnings which were modified,
especially tags/review.tt, admin/manage-marc-import.tt, and holidays.tt.
Everything I was able to test worked correctly.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list