[Koha-bugs] [Bug 10823] add class info to enumchron data in detail.tt, for better styling

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10823

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27536|0                           |1
        is obsolete|                            |

--- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 27650
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27650&action=edit
[PASSED QA] Bug 10823 - add class info to enumchron data in detail.tt, for
better styling

Bug 10825 removes a duplicate (enumchron==serialseq).
This patch was developed on top of it. It properly styles
the elements.  These include:
- items.enumchron
- the separator used
- serial.serialseq
- items.publisheddate

As per Katrin's and Owen's suggestion, <span> was used instead
of <div>. (See comment #7 and
http://irc.koha-community.org/koha/2014-04-03#i_1491135)

TEST PLAN
---------
1) Apply patch 10825
2) Find a biblio where the enumchron and serialseq are different.
   -- in MySQL:
      SELECT items.biblionumber,items.enumchron,serial.serialseq
      FROM items,serial,serialitems
      WHERE items.itemnumber=serilaitems.itemnumber
        AND serialitems.serialid=serial.serialid;
3) In the staff client, view the source for that item.
   -- It should be one class for the entire <td> cell.
4) Apply patch 10823
5) Refresh the page
6) Look at the source for that item again.
   -- It should have <span> tags around the 4 things listed
      above.
7) Run the koha qa test tools.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

NOTE: Since there was lots of squashing and rebasing, could you
      please test and sign this off as well, Mason?

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Template change only, no regression found.
Using [%- -%] could improve readability of HTML source code.

-- 
You are receiving this mail because:
You are watching all bug changes.