[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sat Apr 26 17:36:47 CEST 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27391|0                           |1
        is obsolete|                            |
  Attachment #27392|0                           |1
        is obsolete|                            |

--- Comment #72 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 27657
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27657&action=edit
[PASSED QA] Bug 9593 Prices not imported correctly from a staged file

Initial bug :
When there's a round price with no decimals after it,
or when the symbol is after the digits, the price is not captured
by regular expression in MungeMarcPrice routine and the variable
is not initialized.

Enhancement :
The MungeMarcPrice routine had been widely modified.
It 's still possible to priority pick the active currency but
unlike the previous mechanism that worked only for prices preceded
by the currency sign, it's now valid wherever the symbol is situated.
As symbol you may enter a pure currency sign as well as a string
including it like '$US'. Moreover, an 'isocode' column had been
added in currency table (editable in the pro interface from
Administration/Currencies and exchange rates). So the active
currency can be picked either through its symbol or through its iso
code.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes all tests, especially t/db_dependent/MungeMarcPrice.t
Checked currencies can be added, edited and deleted.
Notes: new ISO code field is mandatory.
       Sample sql files need to be updated (bug 12146)

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list