[Koha-bugs] [Bug 11665] An ability to place orders directly from hold ratios list

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11665

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27434|1                           |0
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 27434
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27434
[SIGNED-OFF] Bug 11665: An ability to place orders directly from hold ratios
list

Review of attachment 27434:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11665&attachment=27434)
-----------------------------------------------------------------

I am a bit torn about this patch. It seems to work nicely, no problems found.

::: circ/reserveratios.pl
@@ +185,5 @@
>  );
>  
>  output_html_with_http_headers $input, $cookie, $template->output;
> +
> +sub CountPendingOrdersByBiblionumber {

But I wonder if this should not be in the .pl file, but in Acquisitions.pm with
unit tests. 
Maybe also orders should be OrderedItems?

Waiting for another opinion, leaving this a signed off for now.

-- 
You are receiving this mail because:
You are watching all bug changes.