[Koha-bugs] [Bug 12091] Ugly HTML for editing authority MARC subfields

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12091

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Mark, no problem to test but...

1. Test plan is missing
2. I think that we must try (fervently) not to put HTML in scripts
So, this kind of construct

$row_data{repeatable} = "<input id=\"repeatable$i\" type=\"checkbox\" " .
      ( $data->{'repeatable'} ? 'checked="checked" ' : '') .
      "name=\"repeatable$i\">

it's calling for a FaliedQA :(

Perhaps can be replaced by

(in script)
$row_data{repeatable} = {
 id => repeatable$i,
 name => repeatable$i,
 repeatable => $data->{'repeatable'},
}

(in tt)
[% IF ( ...row.repeatable ) %]
[% IF ( ...row.repeatable.repeatable ) %]
<input id="[%- ...row.repeatable.id -%]" type="checkbox" name="[%-
...row.repeatable.name -%]" checked="checked">
[% ELSE %]
<input id="[%- ...row.repeatable.id -%]" type="checkbox" name="[%-
...row.repeatable.name -%]">
[% END %]
[% END %]

or something similar
3. Bug status, it's ready to be signed? Then change that :)

-- 
You are receiving this mail because:
You are watching all bug changes.