[Koha-bugs] [Bug 12151] New: remove remaining uses of the Perl smartmatch operator

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Apr 28 17:21:42 CEST 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12151

            Bug ID: 12151
           Summary: remove remaining uses of the Perl smartmatch operator
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: gmcharlt at gmail.com
        QA Contact: testopia at bugs.koha-community.org

The Perl smartmatch operator has been marked as experimental as of Perl 5.18. 
As the syntax and interpretation of it is therefore subject to change, current
uses of it should be removed.  This is especially the case when running under
Perl 5.18, as by default use of experimental constructs generates warning
messages.

The following source files contain the ~~ operator:

C4/Search.pm:                                    unless ( $data ~~ @used_datas
) {
misc/translator/translate:    if ( $cmd !~ /create/ && $lang && not $lang ~~
$installer->{langs} ) {
opac/opac-search.pl:    if ( $sort ~~ @allowed_sortby ) {
tools/batchMod.pl:                unless (
$field_to_update->subfield($subfield->[0]) ~~ $subfield->[1] ) {

The following source files contain the given construct, which also uses
smartmatch:

C4/Serials.pm:    given ($num_type) {
reports/acquisitions_stats.pl:        given ($_) {
reports/acquisitions_stats.pl:                given ($podsp) {
reports/acquisitions_stats.pl:                given ($rodsp) {
reports/acquisitions_stats.pl:    given ($process) {
reports/borrowers_stats.pl:    given ($line) {
reports/borrowers_stats.pl:    given ($column) {
reports/borrowers_stats.pl:            given ($i)

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list