[Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #31 from Julian Maurice <julian.maurice at biblibre.com> ---
Squashed all patches into one.

about CancelReserve changes
> - it adds a return that no callers actually check
It is used in tests

> more importantly, it removes the code to insert the old hold into
> old_reserves, which is a pretty clear regression.
Are you sure ? git show -b shows me that the patch only adds an if (and the
return, of course)

-- 
You are receiving this mail because:
You are watching all bug changes.