---
(In reply to M. Tompsett from comment #28)
> Actually, if you look at
> ...net-tmpl/prog/en/modules/tools/scheduler.tt
> you will see:
> [% IF ( job_add_failed ) %]
> Failed to add scheduled task
> [% END %]
>
> I think something could be added into tools/scheduler that displays a
> configuration required type message when the defaulting $base directory
> doesn't exist. This would then cause people to look at the koha-conf.xml
> which now has that useful message in it based on your latest patch.
>
> Leaving status untouched, because I'm not sure if Marcel would consider the
> new patch alone sufficient, or if implementing this idea I just gave would
> be required too.
If you come up with ideas like that, you really should send a patch too, or you
scope creep the bug to a point it never gets signed off IMHO
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 02:38:44 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 00:38:44 +0000
Subject: [Koha-bugs] [Bug 12688] Better IntranetNav
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12688
--- Comment #1 from Owen Leonard ---
> Plus the added links
> don't look good, and don't line up well.
I'm not seeing a problem with the way the links look when I test it. Does it
depend on the browser? What is the markup you're testing which looks wrong?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 03:03:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 01:03:08 +0000
Subject: [Koha-bugs] [Bug 12477] We need better ways to manage MARC
Frameworks
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12477
--- Comment #14 from David Cook ---
I'm thinking more about how to keep frameworks current...
In theory, all MARC Bibliographic Frameworks should include all MARC
Bibliographic fields and subfields.
I can only think of two scenarios where this theory would be false:
1) You've bent the MARC Bibliographic Framework in an attempt to support a
different sort of metadata format.
[Note: I don't think this is an overly valid reason not to auto-update
frameworks.]
2) You want a framework that will discard certain fields when importing
records. For instance, you might never ever want to keep the 035 for incoming
records (although it's a nice bit of data to keep). So you delete the 035 from
the framework.
[Note: This scenario is more interesting. By deleting certain fields, you could
potentially increase the efficiency of your cataloguing workflow. That is, you
would reduce the amount of time spent deleting unwanted data when importing
records.
Yet... I can't help but feel that the "xkcd: Workflow" comic
(http://xkcd.com/1172/) is relevant here.
I suppose a way to mitigate this might be to add an "auto-update" flag to the
frameworks. You could turn it off for frameworks whose structure you don't want
to change.
Yet...that doesn't make sense either...because there will come a time where you
need to add fields/subfields (such as the RDA fields/subfields).
I suppose that leads us back to doing manual updates... but that can be painful
for a number of reasons. One of those being that the full list of missing
fields/subfields will show up each time, so you need to hand-pick which
fields/subfields you want to add.
Plus, if you're doing manual updates, you need a prompt to do the updates. I
suppose this could be done with a staff client news item...but then when to do
framework update checks...]
---
I've been thinking more about visibility. Regardless of what metadata format we
use, we'll run into this problem again and again.
Instead of using one column ("hidden"), it might make sense to use three
columns ("internal","external","editor").
"internal" and "external" would control visibility in the staff client and the
OPAC (maybe OAI as well...hence my use of "external" as a label).
"editor" would have more options: "used","used - collapsed", "hidden",
"unused". In this case, "used" shows up uncollapsed, "used - collapsed" shows
up as a collapsed field, "hidden" doesn't show up unless you're importing
records with a value in that subfield, "unused" means that there can never be a
value in this field.
Alternatively... we keep the current "hidden" column and add a "used" column
which defaults to "on". If someone wants a framework that will ignore certain
fields when importing, they can turn "used" to "off".
In support of this mechanism, it might make sense to remove the ability for
people to delete fields/subfields from frameworks (unless they're local
fields/subfields that they've added). Of course, that's easy to circumvent by
just importing a framework that doesn't have certain fields/subfields (until
the next auto-update comes around which re-populates those missing
fields/subfields).
---
I don't know... I've looked at this a bit in DSpace as well, and I don't really
like the way they do it either. In DSpace, there is a metadata registry, then
you define input forms (which would be analogous to our frameworks in a way).
It gets incredibly unwieldy after the first form or two, especially if you have
a lot of fields per form.
In the past, I've mostly done original cataloguing, so I'm not 100% sure what
other ILSes/LMSes do for templates with copy cataloguing. I recall cataloguers
using Horizon would have to delete unwanted data when importing records. I
think the function of the templates were more so to provide a minimal set of
fields/subfields that you should fill out. (You then had the option to add more
fields/subfields manually as necessary.)
---
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 03:13:45 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 01:13:45 +0000
Subject: [Koha-bugs] [Bug 12477] We need better ways to manage MARC
Frameworks
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12477
--- Comment #15 from David Cook ---
tl;dr
The top priority should be making sure that no unwanted data loss occurs.
One solution might be to make sure that incoming fields/subfields are saved,
even if they don't appear in a framework.
(I suppose this solution has flaws in terms of determining labels and
repeatability... I suppose you could say "unknown field/subfield" and default
to being repeatable in the editor.)
(For cataloguers who count on the workflow of fields/subfields not being saved
if they're not in the framework, we could have a "strict" flag at the framework
level which could control whether or not "unknown subfields/fields" are saved.)
This solution would actually negate some of the need to update frameworks.
Updates to labels and whether it's "repeatable" would be the only thing needed
really, as the frameworks would be acting more as templates than as strict
frameworks.
Thoughts?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 03:53:13 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 01:53:13 +0000
Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031
--- Comment #30 from M. Tompsett ---
(In reply to Chris Cormack from comment #29)
[SNIP]
> If you come up with ideas like that, you really should send a patch too, or
> you scope creep the bug to a point it never gets signed off IMHO
To be honest, I had hoped Marcel, who Failed QA the bug, would have followed up
with a comment about it being sufficient or insufficient. If the later, I would
have provided a patch then. I suppose I shall in the next day or two.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 06:28:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 04:28:16 +0000
Subject: [Koha-bugs] [Bug 12407] phone label or data switched
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--- Comment #12 from David Cook ---
(In reply to M. de Rooy from comment #9)
> Created attachment 30394 [details] [review]
> Bug 12407: [QA Follow-up] Rename Other Phone to Mobile in staff
>
> Touches three member templates.
> Changes label Other into Mobile.
> This is consistent with database field name and OPAC.
>
> Signed-off-by: Marcel de Rooy
Yay! I sent a patch for this ages ago ( bug 9383 ), but it was tangled up in a
few too many other changes, so I'm happy to see this pass QA finally!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 08:30:13 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 06:30:13 +0000
Subject: [Koha-bugs] [Bug 12690] New: opacuserjs gets loaded twice in self
checkout
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12690
Bug ID: 12690
Summary: opacuserjs gets loaded twice in self checkout
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Self checkout
Assignee: koha-bugs at lists.koha-community.org
Reporter: dcook at prosentient.com.au
QA Contact: testopia at bugs.koha-community.org
Currently, we're loading "opacuserjs" in sco-main.tt twice. Once at the very
bottom at the template, and once via opac-bottom.inc.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 08:30:23 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 06:30:23 +0000
Subject: [Koha-bugs] [Bug 12690] opacuserjs gets loaded twice in self
checkout
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12690
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au
|ity.org |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 08:40:42 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 06:40:42 +0000
Subject: [Koha-bugs] [Bug 12690] opacuserjs gets loaded twice in self
checkout && change syspref calls
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12690
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|opacuserjs gets loaded |opacuserjs gets loaded
|twice in self checkout |twice in self checkout &&
| |change syspref calls
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 08:54:31 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 06:54:31 +0000
Subject: [Koha-bugs] [Bug 12690] opacuserjs gets loaded twice in self
checkout
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12690
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|opacuserjs gets loaded |opacuserjs gets loaded
|twice in self checkout && |twice in self checkout
|change syspref calls |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 08:55:11 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 06:55:11 +0000
Subject: [Koha-bugs] [Bug 12690] opacuserjs gets loaded twice in self
checkout
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12690
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
Patch complexity|--- |Trivial patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 08:55:13 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 06:55:13 +0000
Subject: [Koha-bugs] [Bug 12690] opacuserjs gets loaded twice in self
checkout
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12690
--- Comment #1 from David Cook ---
Created attachment 30441
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30441&action=edit
Bug 12690 - opacuserjs gets loaded twice in self checkout
This patch removes a second instance of "opacuserjs" in the opac
self-checkout.
_TEST PLAN_
1) Enable OPAC Self-checkout in the system preferences
2) Type the following code into your "opacuserjs" system preference:
alert("This is a test");
2) Visit /cgi-bin/koha/sco/sco-main.pl
3) Note that you get a pop-up saying "This is a test" twice.
4) Apply the patch
5) Refresh /cgi-bin/koha/sco/sco-main.pl
6) Note that you now only get a pop-up saying "This is a test" once.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 09:02:17 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 07:02:17 +0000
Subject: [Koha-bugs] [Bug 12691] New: Use Koha.Preference for calls to
SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691
Bug ID: 12691
Summary: Use Koha.Preference for calls to SCOUserJS,
SCOUserCSS, OPACUserCSS, opacuserjs, etc in
Self-Checkout
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Templates
Assignee: oleonard at myacpl.org
Reporter: dcook at prosentient.com.au
QA Contact: testopia at bugs.koha-community.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 09:53:36 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 07:53:36 +0000
Subject: [Koha-bugs] [Bug 12398] CAS authentication not working
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 09:53:38 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 07:53:38 +0000
Subject: [Koha-bugs] [Bug 12398] CAS authentication not working
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #30048|0 |1
is obsolete| |
Attachment #30332|0 |1
is obsolete| |
Attachment #30378|0 |1
is obsolete| |
--- Comment #23 from Katrin Fischer ---
Created attachment 30442
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30442&action=edit
[PASSED QA] Bug 12398: Fix CAS authentication validation
CGI::url_param() also returns deleted parameters so we have to check
with CGI::param() too.
Signed-off-by: Matthias Meusburger
Signed-off-by: Katrin Fischer
Took a while to get it working, but I can confirm CAS login is not
working without this patch, but does with it.
Some notes:
In order for this to work you have to add http:// in front of your
OpacBaseURL.
You will also need a CAS test server and install the certificate
on your system.
Tested with CAS test server provided by Biblibre.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 09:53:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 07:53:56 +0000
Subject: [Koha-bugs] [Bug 12398] CAS authentication not working
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398
--- Comment #24 from Katrin Fischer ---
Created attachment 30443
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30443&action=edit
[PASSED QA] Bug 12398: Add test for C4::Auth_with_cas::_url_with_get_params
Run `prove t/db_dependent/Auth_with_cas.t` to run the test
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 09:54:52 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 07:54:52 +0000
Subject: [Koha-bugs] [Bug 12398] CAS authentication not working
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398
--- Comment #25 from Katrin Fischer ---
I took the liberty to squash the last 2 patches for the test - both from
Julian. As one added a file and the second moved it, this is nicer to read now
:)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 10:10:00 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 08:10:00 +0000
Subject: [Koha-bugs] [Bug 12690] opacuserjs gets loaded twice in self
checkout
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12690
--- Comment #2 from Marc V?ron ---
Created attachment 30444
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30444&action=edit
[Signed-off] Bug 12690 - opacuserjs gets loaded twice in self checkout
This patch removes a second instance of "opacuserjs" in the opac
self-checkout.
_TEST PLAN_
1) Enable OPAC Self-checkout in the system preferences
2) Type the following code into your "opacuserjs" system preference:
alert("This is a test");
2) Visit /cgi-bin/koha/sco/sco-main.pl
3) Note that you get a pop-up saying "This is a test" twice.
4) Apply the patch
5) Refresh /cgi-bin/koha/sco/sco-main.pl
6) Note that you now only get a pop-up saying "This is a test" once.
Followed test plan, patch behaves as expected.
Signed-off-by: Marc V?ron
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 10:10:28 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 08:10:28 +0000
Subject: [Koha-bugs] [Bug 12690] opacuserjs gets loaded twice in self
checkout
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12690
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #30441|0 |1
is obsolete| |
CC| |veron at veron.ch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 10:10:46 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 08:10:46 +0000
Subject: [Koha-bugs] [Bug 12690] opacuserjs gets loaded twice in self
checkout
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12690
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 10:16:07 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 08:16:07 +0000
Subject: [Koha-bugs] [Bug 4045] No check for maximum number of allowed holds
from OPAC.
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 10:24:28 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 08:24:28 +0000
Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |veron at veron.ch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 10:29:37 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 08:29:37 +0000
Subject: [Koha-bugs] [Bug 4045] No check for maximum number of allowed holds
from OPAC.
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|mtj at kohaaloha.com |m.de.rooy at rijksmuseum.nl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 10:41:58 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 08:41:58 +0000
Subject: [Koha-bugs] [Bug 11847] Display basketgroup closed date at OPAC
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11847
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #25639|0 |1
is obsolete| |
--- Comment #8 from Julian Maurice ---
Created attachment 30445
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30445&action=edit
Bug 11847: Display basketgroup closed date at OPAC
in Holdings table, on detail page.
Test plan:
1/ Enable OPACAcquisitionDetails syspref
2/ Set AcqCreateItem syspref to "ordering"
3/ Create a basket with 1 order, close this basket then create a
basketgroup with this basket and close the basketgroup
4/ Create another basket with 1 order on the same biblio record as
previous order. Close the basket then create a basketgroup with this
basket but do not close it.
5/ Go to the OPAC detail page of the biblio record.
6/ In holdings table, under "Status" column, you should see:
- for the first item ordered: "On order since DATE"
- for the second item ordered: "On order"
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 10:42:10 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 08:42:10 +0000
Subject: [Koha-bugs] [Bug 11847] Display basketgroup closed date at OPAC
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11847
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 10:47:25 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 08:47:25 +0000
Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031
--- Comment #31 from M. de Rooy ---
(In reply to M. Tompsett from comment #30)
> To be honest, I had hoped Marcel, who Failed QA the bug, would have followed
> up with a comment about it being sufficient or insufficient. If the later, I
> would have provided a patch then. I suppose I shall in the next day or two.
Oops. I just waited for a signoff before re-QAing it..
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 10:54:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 08:54:16 +0000
Subject: [Koha-bugs] [Bug 12669] "Template process failed: undef error -
Invalid local time for date in time zone"
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |chris at bigballofwax.co.nz
--- Comment #4 from Chris Cormack ---
Hi Rolando
We don't actually use github, its just a mirror/backup
Can you please attach a patch (using git format-patch) against
git.koha-community.org/koha.git master branch.
Then set the status to needs sign off. It will then get code reviewed, and will
shift to signed off if it passes. Then its on to QA, then the release manager
finally.
This is the workflow we use
http://wiki.koha-community.org/wiki/Bug-enhancement-patch_Workflow
If you cant create the patch let me know, and i'll do it from your github
commit
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 11:09:38 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 09:09:38 +0000
Subject: [Koha-bugs] [Bug 12669] "Template process failed: undef error -
Invalid local time for date in time zone"
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669
--- Comment #5 from Rolando Isidoro ---
Created attachment 30446
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30446&action=edit
Use floating timezone when handling dates without hours, minutes and seconds.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 11:12:14 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 09:12:14 +0000
Subject: [Koha-bugs] [Bug 12683] Use NoLoginInstructions to customize text
for OPAC user/pass information
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12683
--- Comment #2 from Marc V?ron ---
Created attachment 30447
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30447&action=edit
[Signed-off] Bug 12683 - Use NoLoginInstructions to customize text for OPAC
user/pass information
Enable staff to setting a text for OPAC user/pass information
Modified:
C4/Auth.pm
koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc -add a text to the
popup login page
koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-main.tt -add a text to the
main login page
Testing:
I Apply the patch
0) Search NoLoginInstructions preference
1) Add/modify a text
2) Open OPAC main page
3) Validate the text added under Login button
4) Click in "Log in to your account" link
5) Validate the text added under input password (popup)
Sponsored-by: CCSR ( http://www.ccsr.qc.ca )
Patch behaves as expected.
Signed-off-by: Marc V?ron
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 11:12:36 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 09:12:36 +0000
Subject: [Koha-bugs] [Bug 12683] Use NoLoginInstructions to customize text
for OPAC user/pass information
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12683
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #30415|0 |1
is obsolete| |
CC| |veron at veron.ch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 11:12:44 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 09:12:44 +0000
Subject: [Koha-bugs] [Bug 12683] Use NoLoginInstructions to customize text
for OPAC user/pass information
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12683
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 11:13:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 09:13:05 +0000
Subject: [Koha-bugs] [Bug 12683] Use NoLoginInstructions to customize text
for OPAC user/pass information
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12683
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 12:29:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 10:29:56 +0000
Subject: [Koha-bugs] [Bug 4045] No check for maximum number of allowed holds
from OPAC.
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045
--- Comment #70 from M. de Rooy ---
Test results:
Hopefully understandable enough (bl=bib level; il=item level; numbers are bibs)
Will refer to this in my QA comment.
First test (biblevel maxreserves=3 issuingrules=10 on all itypes)
bl 668 OK
bl 1178 OK
req on two biblios: get warning when submitting: ERROR: Internal error:
incomplete hold request.
So both holds are blocked. But the error message is kind of vague. Result of
bad_data flag in opac-reserve.pl
No blocker, but this could still be improved.
bl 1234 on third OK
try no 4 (1235) message fine OK
try 4 via staff warning, but hold is placed [staff overrules: design??] Note
that I had AllowHoldPolicyOverride=Do not allow override!
try 5 via opac: You cannot place more than 4 holds. (Oops: actually more than 3
should not be allowed..)
Second test (itemlevel maxres=3 issu=2 on all itypes)
il 668
il 1178
req on two: Funny: Four warnings: None can be placed on hold (Fine). Sorry, you
can only place 1 more holds (Small spelling issue too! But it is not true! I
have gone above the number of 2 in issuingrules. Please uncheck boxes
(Impossible: there are no boxes to uncheck..)
Per biblio a warning: No available items.
il 1234 None can be placed on hold (OK)
Changing issu=2 to issu=3: repeat il 1234 (OK)
try no 4 (1235): You cannot place more than 3 holds (OK)
try 4 via staff Cannot place hold on some items (No items are available) So,
this time I cannot overrule it.
Third test (item level maxres=3 issu=2 on BK only)
il 668 BK
il 1178 BK
try il 1234 BK None can be placed (OK)
try il 1331 CF Sorry none can be placed (Not true: I just have 2 holds; For
itype CF I should have one to go?)
try il 1331 CF on staff: Cannot place a hold. No items av. (Not true?)
delete two reserves, try il 1331 CF: Still impossible.
Fourth test (item level issu BK=2 issu CF=4)
il 668 BK
il 1178 BK
try il 1234 BK None placed: OK
try il 1331 CF Can be done: OK
retry il 1331 CF No more than 3: OK (maxreserves overrules the CF=4 rule here..
Debatable?)
try il 1235 BK You cannot place more than 3: OK
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 12:43:38 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 10:43:38 +0000
Subject: [Koha-bugs] [Bug 4045] No check for maximum number of allowed holds
from OPAC.
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045
--- Comment #71 from M. de Rooy ---
Still another test after deleting the reserves from the fourth run: I select
four biblios and place hold. I get a warning to uncheck.
I uncheck one biblio and select three items (BK) with a hold limit on BK=2.
Without a warning I had two holds placed.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 12:51:28 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 10:51:28 +0000
Subject: [Koha-bugs] [Bug 4045] No check for maximum number of allowed holds
from OPAC.
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--- Comment #72 from M. de Rooy ---
QA Comment
If maxreserves would have been a new development and Holds was a perfect
module, this should have failed QA :)
But we are in another situation. The missing maxreserves for long time already
is really bad.
My test results show me that there are still some discrepancies and points to
resolve.
We could see this patch as the starting point for that.
Since this report already has quite a history, I am passing QA on it in the
perspective noted. Leaving final judgement to RM or perhaps a second QA
opinion?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 12:52:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 10:52:16 +0000
Subject: [Koha-bugs] [Bug 4045] No check for maximum number of allowed holds
from OPAC.
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #30051|0 |1
is obsolete| |
--- Comment #73 from M. de Rooy ---
Created attachment 30448
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30448&action=edit
Bug 4045 - No check for maximum number of allowed holds.
Re-add the system preference maxreserves.
All the code using maxreserves is still in place. Though it
is not used in the Reserves module, it is used in all the
scripts where holds are placed.
Also adds a check so that a borrower cannot exceed the maximum
number of allowed holds by using the multi-hold feature via
the opac.
Test Plan:
1) Apply this patch
2) Run updatedatabase
3) Set maxreserves to 3, set opactheme to bootstrap
4) Log into the opac as a patron
5) Place 3 holds
6) Attempt to place a 4th hold
7) Note you get an error message and cannot place a forth hold
8) Delete two of those holds
9) Attempt to place 3 or more holds as a multi-hold
10) You should see a warning that you cannot place this many holds
11) Try to anyway
12) You should see an alert to tell you to reduce the number of holds
you are placing.
13) Reduce the number for holds you are placing to 2
14) Your holds should now be placed
Signed-off-by: Chris Cormack
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 13:10:00 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 11:10:00 +0000
Subject: [Koha-bugs] [Bug 12529] Overdue notices do not respect holidays
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 13:10:02 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 11:10:02 +0000
Subject: [Koha-bugs] [Bug 12529] Overdue notices do not respect holidays
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #30226|0 |1
is obsolete| |
Attachment #30227|0 |1
is obsolete| |
--- Comment #9 from Kyle M Hall ---
Created attachment 30449
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30449&action=edit
Bug 12529: Add a syspref to make overdue notices respect holidays
Test Plan
Set up some overdue triggers, for example 5,10,15
Set up some holidays
Create some items that are past due (one due 5 days, 10 days ago etc)
Run the overdue notices script (misc/cronjobs/overdue_notices.pl)
Notice holidays are ignored
Apply the patch,
Switch the OverdueNoticeCalendar syspref to Use calendar
Run the overdue notices again
Notice holidays are now taken into account
Sponsored-by: BSZ
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 13:10:13 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 11:10:13 +0000
Subject: [Koha-bugs] [Bug 12529] Overdue notices do not respect holidays
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529
--- Comment #10 from Kyle M Hall ---
Created attachment 30450
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30450&action=edit
Bug 12529 [QA Followup] - Remove trailing whitespace
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 13:22:51 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 11:22:51 +0000
Subject: [Koha-bugs] [Bug 8687] Improvements in overdue_notices.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #30403|0 |1
is obsolete| |
--- Comment #24 from Kyle M Hall ---
Created attachment 30451
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30451&action=edit
[SIGNED-OFF] Bug 8687 - Improvements in overdue_notices.pl
Improvements in the overdue_notices.pl script
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 13:22:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 11:22:48 +0000
Subject: [Koha-bugs] [Bug 8687] Improvements in overdue_notices.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 13:29:44 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 11:29:44 +0000
Subject: [Koha-bugs] [Bug 8687] Improvements in overdue_notices.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687
--- Comment #25 from Katrin Fischer ---
Hi Simith, I see that Kyle passed QA on this, but could you maybe reattach a
patch with a commit message? A short description of what this patch
changes/adds to the script? I think this has gone quite a long way since the
beginning so most of the comments here do no longer apply.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 13:44:00 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 11:44:00 +0000
Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #28783|0 |1
is obsolete| |
--- Comment #32 from M. Tompsett ---
Created attachment 30452
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30452&action=edit
[SIGNED OFF] Bug 12031 - Task Scheduler not sending mail
At some stage the runreport.pl cronjob was changed to accept longopts, but the
scheduler script wasn't changed along with it. This patch fixes the mismatch.
To test:
1. make sure that your user is not in at.deny, and (if applicable/necessary) is
in at.allow
1.5 test this on a package install, sending mails will still not work for git
installs, even with this patch.
Useful, but not required step: make sure email can be sent from your server,
also helpful is access to the Koha user's mail box (to see the bounce messages)
2. create a saved sql report to run
3. Go to Tools -> Task Scheduler and schedule a job to be run, and results
emailed to you
4. note that you do not (without the patch) get an email. Make a note of the
command it reports it is going to run.
5. apply the patch
6. schedule another job, you will notice that the command to run the scheduled
job is slightly changed compared to the one in step 4.
7. Receiving an email when your job runs means the patch worked. Seeing
--format= and --to= in the command also means the patch worked, as this is the
command that runreport.pl is expecting.
8. Run the koha QA test tool.
Signed-off-by: Mark Tompsett
NOTE: The line that changes is visible in the bottom section,
"Jobs already entered", with the corrected parameters and
path used. If you do not have the config
parameter set up in koha-conf.xml, it defaults to the
typical package path. If you have the parameter set up,
the path given matches what you tell it. Only tested in
git.
Signed-off-by: Paola Rossi
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 13:44:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 11:44:15 +0000
Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #29593|0 |1
is obsolete| |
--- Comment #33 from M. Tompsett ---
Created attachment 30453
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30453&action=edit
[SIGNED OFF] QA followup 12031 - adding supportdir to koha-conf.xml
By adding a supportdir, this allows for configuring use in a
non-package install environment, such as git.
Seeing as I only tested git, I clearly had this defined.
Further testing should include packaging up an installation, and
installing a package version without setting the supportdir
configuration value.
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 13:45:45 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 11:45:45 +0000
Subject: [Koha-bugs] [Bug 12031] Task Scheduler not sending mail
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--- Comment #34 from M. Tompsett ---
I think I'll leave my idea in comment #28 for another bug report. Here's the
sign off, Marcel. :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 14:49:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 12:49:05 +0000
Subject: [Koha-bugs] [Bug 12669] "Template process failed: undef error -
Invalid local time for date in time zone"
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669
Rolando Isidoro changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--- Comment #6 from Rolando Isidoro ---
Test plan:
1. Create a new serial record or pick an existing one;
2. Add a "New subscription" and set the "First issue publication date" and
"Frequency" values so that the "Planned date" for a given issue hits a day
where a transition to Daylight Saving Time (DST) occurs
ex:. 1979-04-01 in Europe/Lisbon
(http://www.timeanddate.com/time/change/portugal/lisbon?year=1979) ... use this
website page as a source http://www.timeanddate.com/time/dst/2014.html to find
a suitable transition to DST in your timezone in the current year.
3. From the "Subscription detail" page in Koha for the given record click the
"Serial collection" link on the left side context menu.
Expected result:
Prior to applying the patch the error described in this bug report should
occur. After the patch is applied the "Serial collection" page should load
correctly.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 15:12:44 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 13:12:44 +0000
Subject: [Koha-bugs] [Bug 12398] CAS authentication not working
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398
--- Comment #26 from Tom?s Cohen Arazi ---
Created attachment 30454
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30454&action=edit
Bug 12398: (followup) tidy unit tests
This followup removes unnecesary warnings generated by the test,
and also prints a proper message for the tests.
Added a can_ok test for all the exported functions btw.
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 15:14:19 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 13:14:19 +0000
Subject: [Koha-bugs] [Bug 12669] "Template process failed: undef error -
Invalid local time for date in time zone"
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669
Rolando Isidoro changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 15:15:03 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 13:15:03 +0000
Subject: [Koha-bugs] [Bug 12398] CAS authentication not working
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #27 from Tom?s Cohen Arazi ---
Patches pushed to master.
Thanks Julian!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 15:23:24 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 13:23:24 +0000
Subject: [Koha-bugs] [Bug 12071] javascript broken for a search with double
quotes
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12071
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
--- Comment #8 from Fridolin SOMERS ---
Pushed to 3.14.x, will be in 3.14.10
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 15:26:08 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 13:26:08 +0000
Subject: [Koha-bugs] [Bug 11947] Hold priorities not re-calculated when hold
is confirmed on checkin.
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11947
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |fridolyn.somers at biblibre.co
| |m
--- Comment #31 from Fridolin SOMERS ---
Pushed to 3.14.x, will be in 3.14.10
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 15:30:26 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 13:30:26 +0000
Subject: [Koha-bugs] [Bug 11219] CAS authentication fails with URL parameters
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11219
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
--- Comment #16 from Fridolin SOMERS ---
Pushed to 3.14.x, will be in 3.14.10
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 15:41:53 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 13:41:53 +0000
Subject: [Koha-bugs] [Bug 11711] Use new DataTables include in circ templates
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11711
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |fridolyn.somers at biblibre.co
| |m
--- Comment #10 from Fridolin SOMERS ---
Pushed to 3.14.x, will be in 3.14.10
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 15:43:49 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 13:43:49 +0000
Subject: [Koha-bugs] [Bug 11734] Use new DataTables include in batch
modification templates
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11734
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |fridolyn.somers at biblibre.co
| |m
--- Comment #7 from Fridolin SOMERS ---
Pushed to 3.14.x, will be in 3.14.10
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 15:44:47 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 13:44:47 +0000
Subject: [Koha-bugs] [Bug 12637] UTF-8 problems when creating a patron list
from the patron search results page
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #30013|0 |1
is obsolete| |
--- Comment #4 from Owen Leonard ---
Created attachment 30455
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30455&action=edit
[SIGNED-OFF] Bug 12637: UTF-8 problems when creating a patron list
[SIGNED-OFF] Bug 12637: UTF-8 problems when creating a patron list
Encoding problems appear when creating a patron list from the patron search
results page.
Test plan:
1. Perform a patron search in the patrons module
2. Select one or more patrons
3. Choose "Add selected patrons to: [ New list ]"
4. Enter a patron list title with UTF-8 characters, ex: "P?tron list
five "
5. The list will be created with bad encoding:
"P%C3%A0tron%20list%20five%20"
6. Apply the patch and verify there is no bad encoding anymore.
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 15:44:57 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 13:44:57 +0000
Subject: [Koha-bugs] [Bug 12637] UTF-8 problems when creating a patron list
from the patron search results page
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 15:46:17 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 13:46:17 +0000
Subject: [Koha-bugs] [Bug 9075] Rename type to material type
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |fridolyn.somers at biblibre.co
| |m
--- Comment #25 from Fridolin SOMERS ---
Pushed to 3.14.x, will be in 3.14.10
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 15:55:24 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 13:55:24 +0000
Subject: [Koha-bugs] [Bug 8643] Add important constraint to marc subfields
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643
Eric B?gin changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |eric.begin at inLibro.com
Assignee|pelletiermaxime at gmail.com |simith.doliveira at inlibro.co
| |m
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 15:56:17 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 13:56:17 +0000
Subject: [Koha-bugs] [Bug 8044] Localization for Perl scripts and modules
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |fridolyn.somers at biblibre.co
| |m
--- Comment #61 from Fridolin SOMERS ---
Pushed to 3.14.x, will be in 3.14.10
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 15:58:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 13:58:32 +0000
Subject: [Koha-bugs] [Bug 9865] Make SIP2 message encoding configurable via
SIPconfig.xml
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9865
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |fridolyn.somers at biblibre.co
| |m
--- Comment #19 from Fridolin SOMERS ---
Pushed to 3.14.x, will be in 3.14.10
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 16:08:51 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 14:08:51 +0000
Subject: [Koha-bugs] [Bug 12056] Untranslatable strings in calendar
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12056
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |fridolyn.somers at biblibre.co
| |m
--- Comment #7 from Fridolin SOMERS ---
Pushed to 3.14.x, will be in 3.14.10
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 16:46:41 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 14:46:41 +0000
Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #29105|0 |1
is obsolete| |
--- Comment #2 from Kyle M Hall ---
Created attachment 30456
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30456&action=edit
Bug 12461 - Add patron clubs feature
This features would add the ability to create clubs which patrons may be
enrolled in. It would be particularly useful for tracking summer reading
programs, book clubs and other such clubs.
Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Ensure your staff user has the new 'Patron clubs' permissions
4) Under the tools menu, click the "Patron clubs" link
5) Create a new club template
* Here you can add fields that can be filled out at the time
a new club is created based on the template, or a new enrollment
is created for a given club based on the template.
6) Create a new club based on that template
7) Attempt to enroll a patron in that club
8) Create a club with email required set
9) Attempt to enroll a patron without an email address in that club
10) Create a club that is enrollable from the OPAC
11) Attempt to enroll a patron in that club
12) Attempt to cancel a club enrollment from the OPAC
13) Attempt to cancel a club enrollment from the staff interface
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 16:47:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 14:47:32 +0000
Subject: [Koha-bugs] [Bug 12672] GetMarcISBN should return the corresponding
subfield
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12672
--- Comment #6 from Jared Camins-Esakov ---
(In reply to Katrin Fischer from comment #5)
> Hm, I am not sure about removing $z - invalid/cancelled ISBN.
>
> Adding Jared and Galen in cc, looking for opinions.
My inclination is that $z shouldn't appear, because it doesn't provide useful
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 16:48:49 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 14:48:49 +0000
Subject: [Koha-bugs] [Bug 12424] ddc sorting of call numbers truncates long
Cutter parts
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12424
Eric B?gin changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |eric.begin at inLibro.com
--- Comment #3 from Eric B?gin ---
Do you foresee problem if we were increasing the length of cn_sort to 255 chars
?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 16:48:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 14:48:56 +0000
Subject: [Koha-bugs] [Bug 12672] GetMarcISBN should return the corresponding
subfield
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12672
--- Comment #7 from Jared Camins-Esakov ---
(In reply to Jared Camins-Esakov from comment #6)
> My inclination is that $z shouldn't appear, because it doesn't provide useful
[whoops, somehow submitted before I finished]
... doesn't provide useful information in the majority of situations, but could
easily confuse someone looking for the ISBN.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 17:21:17 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 15:21:17 +0000
Subject: [Koha-bugs] [Bug 12688] Better IntranetNav
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12688
--- Comment #2 from Christopher Brannon ---
(In reply to Owen Leonard from comment #1)
> > Plus the added links
> > don't look good, and don't line up well.
>
> I'm not seeing a problem with the way the links look when I test it. Does it
> depend on the browser? What is the markup you're testing which looks wrong?
Well, if you only throw links in there, the font doesn't match, the links are
run together, and they are offset from the rest of the menu. It just doesn't
look clean. Plus, as I said, you are limited on space. (See attachments)
I just thought I'd throw this out there. Seems like mimicking the existing
menu is more attractive and practical.
Christopher
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 17:22:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 15:22:05 +0000
Subject: [Koha-bugs] [Bug 12688] Better IntranetNav
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12688
--- Comment #3 from Christopher Brannon ---
Created attachment 30457
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30457&action=edit
Basic links in IntranetNav
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 17:22:46 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 15:22:46 +0000
Subject: [Koha-bugs] [Bug 12688] Better IntranetNav
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12688
--- Comment #4 from Christopher Brannon ---
Created attachment 30458
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30458&action=edit
Not so attractive layout of links in IntranetNav
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 17:25:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 15:25:56 +0000
Subject: [Koha-bugs] [Bug 12688] Better IntranetNav
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12688
--- Comment #5 from Christopher Brannon ---
(In reply to Owen Leonard from comment #1)
> > Plus the added links
> > don't look good, and don't line up well.
>
> I'm not seeing a problem with the way the links look when I test it. Does it
> depend on the browser? What is the markup you're testing which looks wrong?
I am using FireFox, by the way. IE11 looks exactly the same.
Christopher
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 17:31:44 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 15:31:44 +0000
Subject: [Koha-bugs] [Bug 12688] Better IntranetNav
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12688
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|unspecified |master
--- Comment #6 from Owen Leonard ---
(In reply to Christopher Brannon from comment #2)
> Well, if you only throw links in there, the font doesn't match, the links
> are run together, and they are offset from the rest of the menu.
Yeah it's not exactly clear from the system preference description, but for it
to look consistent you have to enter them as list items:
Link one
Link two
Link three
That said, you're right that you'll run out of space quickly. I'm glad you were
able to put together a menu that worked. Perhaps a good next step would be to
fully document both the plain and menu markup options.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 17:43:26 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 15:43:26 +0000
Subject: [Koha-bugs] [Bug 12687] Remove CGI::scrolling_list from
circulation.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12687
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 17:43:28 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 15:43:28 +0000
Subject: [Koha-bugs] [Bug 12687] Remove CGI::scrolling_list from
circulation.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12687
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #30438|0 |1
is obsolete| |
--- Comment #2 from Owen Leonard ---
Created attachment 30459
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30459&action=edit
[SIGNED-OFF] Bug 12687 - Remove CGI::scrolling_list from circulation.pl
This patch removes the only instance in this file
To test:
1. Apply the patch
2. Search for patrons on staff CheckOut,
use a string that gives multiple results
3. Results are displayed on a select,
that was replaced.
4. Check for regressions: select a patron and press 'Select',
or do double click on a patron name, verify you go
to patron's checkout tab.
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 17:45:40 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 15:45:40 +0000
Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402
Paola Rossi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--- Comment #85 from Paola Rossi ---
Thanks, Jared.
I've applied against 3.17.00.011.
Everything's ok.
So I pass the patches to "Signed Off" status.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 17:48:37 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 15:48:37 +0000
Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402
Paola Rossi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #30209|0 |1
is obsolete| |
--- Comment #86 from Paola Rossi ---
Created attachment 30460
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30460&action=edit
Bug 10402: Use an object for contacts
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 17:49:45 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 15:49:45 +0000
Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402
Paola Rossi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #30210|0 |1
is obsolete| |
--- Comment #87 from Paola Rossi ---
Created attachment 30461
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30461&action=edit
Bug 10402: Move contacts to separate table
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 17:50:23 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 15:50:23 +0000
Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402
Paola Rossi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #30211|0 |1
is obsolete| |
--- Comment #88 from Paola Rossi ---
Created attachment 30462
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30462&action=edit
Bug 10402: Add ability to enter multiple contacts
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 17:50:30 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 15:50:30 +0000
Subject: [Koha-bugs] [Bug 12666] Offline Circulation has poor HTML
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12666
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com
|ity.org |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 17:50:57 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 15:50:57 +0000
Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402
Paola Rossi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #30212|0 |1
is obsolete| |
--- Comment #89 from Paola Rossi ---
Created attachment 30463
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30463&action=edit
Bug 10402 [Template follow-up] Add multiple contacts for vendors
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 17:51:39 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 15:51:39 +0000
Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402
Paola Rossi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #30213|0 |1
is obsolete| |
--- Comment #90 from Paola Rossi ---
Created attachment 30464
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30464&action=edit
Bug 10402 follow-up: choose contacts for claims
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 18:01:30 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 16:01:30 +0000
Subject: [Koha-bugs] [Bug 12666] Offline Circulation has poor HTML
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12666
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 18:01:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 16:01:33 +0000
Subject: [Koha-bugs] [Bug 12666] Offline Circulation has poor HTML
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12666
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #30238|0 |1
is obsolete| |
--- Comment #2 from Owen Leonard ---
Created attachment 30465
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30465&action=edit
[SIGNED-OFF] Bug 12666 - Fix poor HTML from circ/offline.tt
In koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt
- Cleaned up the HTML's missing 's
- Corrected the autobuffer attribute to the newer preload one
- Added into empty title, since it will get replaced
TEST PLAN
---------
1) Run the circ/offline.pl page source through an HTML validator
-- should get a few warnings
2) Apply patch
3) Recheck page source (confirm your page isn't cached!)
-- should be clean
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 18:32:02 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 16:32:02 +0000
Subject: [Koha-bugs] [Bug 11331] CSV export for viewlog.pl is missing
newlines
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11331
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #30264|0 |1
is obsolete| |
--- Comment #8 from Owen Leonard ---
Created attachment 30466
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30466&action=edit
[SIGNED-OFF] Bug 11331 - CSV export for viewlog.pl is missing newlines
When you try to export the result of tools/viewlog.pl in csv, file
cannot be correctly loaded :
- newline is missing after each record,
- strings should be enclosed in ""
- columns are not the same as for screen output
This patch corrects this by using like other export Text::CSV.
Adds a header line made with the keys of first data. For that, all data
values are initialiszed with empty string.
Test plan :
- Use a database with some logs, see sysprefs
/cgi-bin/koha/admin/preferences.pl?tab=logs
- Go to export page /cgi-bin/koha/tools/viewlog.pl
- Select a module
- Click on "To a file" and choose a file name
- Click on "Submit"
- Open file
=> Without this patch : newline is missing, multi-lines cells are not
enclosed in "", there are no column headings
=> Without this patch : each line is a data line, complexe cells are
enclosed in "", there are column headings
- Test the export of all modules to see that all headings are necessary
- Check the output to screen in the browser
Signed-off-by: Owen Leonard
The CSV export is significantly improved. I question the usefulness of
including biblioitemnumber in the output. A better inclusion would be
itemnumber.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 18:34:19 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 16:34:19 +0000
Subject: [Koha-bugs] [Bug 11331] CSV export for viewlog.pl is missing
newlines
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11331
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 18:34:21 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 16:34:21 +0000
Subject: [Koha-bugs] [Bug 11331] CSV export for viewlog.pl is missing
newlines
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11331
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #30265|0 |1
is obsolete| |
--- Comment #9 from Owen Leonard ---
Created attachment 30467
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30467&action=edit
[SIGNED-OFF] Bug 11331 - CSV export for viewlog.pl is missing newlines -
followup
Perl formatting and cleaning.
Also corrects the HTML of restults table in viewlog.tt.
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 18:35:17 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 16:35:17 +0000
Subject: [Koha-bugs] [Bug 12523] Add patron email in Holds awaiting pickup
circulation report
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12523
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Add patron email in Holds |Add patron email in Holds
|awaiting pickup circulation |awaiting pickup circulation
|rapport. |report
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 18:35:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 16:35:48 +0000
Subject: [Koha-bugs] [Bug 12523] Add patron email in Holds awaiting pickup
circulation report
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12523
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |simith.doliveira at inlibro.co
|ity.org |m
Severity|new feature |enhancement
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 18:51:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 16:51:56 +0000
Subject: [Koha-bugs] [Bug 12523] Add patron email in Holds awaiting pickup
circulation report
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12523
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 18:51:58 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 16:51:58 +0000
Subject: [Koha-bugs] [Bug 12523] Add patron email in Holds awaiting pickup
circulation report
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12523
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #29469|0 |1
is obsolete| |
--- Comment #2 from Owen Leonard ---
Created attachment 30468
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30468&action=edit
[SIGNED-OFF] Bug 12523 - Add patron email in Holds awaiting pickup circulation
rapport
Modified:
circ/waitingreservers.pl - added GetFirstValidEmailAddress
Testing:
I Apply the patch
0) Put an item in hold for pickup;
1) In Circulation -> Holds awaiting pickup, validate email (column Patron);
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 18:52:11 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 16:52:11 +0000
Subject: [Koha-bugs] [Bug 12523] Add patron email in Holds awaiting pickup
circulation report
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12523
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 20:04:32 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 18:04:32 +0000
Subject: [Koha-bugs] [Bug 12692] New: Markup improvements to holds awaiting
pickup report
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12692
Bug ID: 12692
Summary: Markup improvements to holds awaiting pickup report
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
URL: /cgi-bin/koha/circ/waitingreserves.pl
OS: All
Status: ASSIGNED
Severity: enhancement
Priority: P5 - low
Component: Templates
Assignee: oleonard at myacpl.org
Reporter: oleonard at myacpl.org
QA Contact: testopia at bugs.koha-community.org
Proposed changes:
- add output of subtitle
- correct output of email address
- fix some formatting issues
- output library name instead of code
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 20:22:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 18:22:05 +0000
Subject: [Koha-bugs] [Bug 12692] Markup improvements to holds awaiting
pickup report
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12692
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |12523
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 20:22:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 18:22:05 +0000
Subject: [Koha-bugs] [Bug 12523] Add patron email in Holds awaiting pickup
circulation report
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12523
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |12692
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 20:24:22 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 18:24:22 +0000
Subject: [Koha-bugs] [Bug 12692] Markup improvements to holds awaiting
pickup report
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12692
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 20:24:24 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 18:24:24 +0000
Subject: [Koha-bugs] [Bug 12692] Markup improvements to holds awaiting
pickup report
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12692
--- Comment #1 from Owen Leonard ---
Created attachment 30469
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30469&action=edit
Bug 12692 - Markup improvements to holds awaiting pickup report
This patch makes some minor updates to the output of the holds awaiting
pickup report. To test you should have several holds which are marked as
"waiting," including some which have been waiting longer than the number
of days specified in the ReservesMaxPickUpDelay system preference.
- Go to Circulation -> Holds awaiting pickup
- In both the "waiting" and "over" tabs, confirm that titles display any
associated subtitle
- Confirm that library name is shown instead of library code
- Confirm that the patron name mailto: link works correctly
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 20:30:46 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 18:30:46 +0000
Subject: [Koha-bugs] [Bug 10433] colspan calculation done by
opac/opac-reserve.pl should be moved to template
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10433
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 20:41:36 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 18:41:36 +0000
Subject: [Koha-bugs] [Bug 12233] remove prog and CCSR OPAC themes
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12233
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |10433
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 20:41:36 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 18:41:36 +0000
Subject: [Koha-bugs] [Bug 10433] colspan calculation done by
opac/opac-reserve.pl should be moved to template
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10433
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
Patch complexity|--- |Trivial patch
Depends on| |12233
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 20:41:39 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 18:41:39 +0000
Subject: [Koha-bugs] [Bug 10433] colspan calculation done by
opac/opac-reserve.pl should be moved to template
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10433
--- Comment #2 from Owen Leonard ---
Created attachment 30470
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30470&action=edit
Bug 10433 - colspan calculation done by opac/opac-reserve.pl should be moved to
template
Since the bootstrap OPAC's place hold interface doesn't use tables
there is no use for the colspan calculation being done in the script.
This patch removes it.
To test, place one or more holds in the OPAC and confirm that there are
no display problems. The OPAC error logs should show no associated
error.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 20:56:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 18:56:16 +0000
Subject: [Koha-bugs] [Bug 12693] New: colspan calculation done by
members/statistics.pl should be moved to template
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12693
Bug ID: 12693
Summary: colspan calculation done by members/statistics.pl
should be moved to template
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: ASSIGNED
Severity: minor
Priority: P5 - low
Component: Patrons
Assignee: oleonard at myacpl.org
Reporter: oleonard at myacpl.org
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
members/statistics.pl contains some code to calculate how many columns of the
main table the footer's total column should span.
As the colspan value is purely a display consideration, the logic should be
moved to the template.
members/statistics.pl: length_keys => scalar( @statistic_column_names),
koha-tmpl/intranet-tmpl/prog/en/modules/members/statistics.tt:
TOTAL |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 20:56:44 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 18:56:44 +0000
Subject: [Koha-bugs] [Bug 10433] colspan calculation done by
opac/opac-reserve.pl should be moved to template
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10433
--- Comment #3 from Owen Leonard ---
> members/statistics.pl: length_keys => scalar( @statistic_column_names),
I have moved this issue to Bug 12693
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 21:11:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 19:11:59 +0000
Subject: [Koha-bugs] [Bug 12693] colspan calculation done by
members/statistics.pl should be moved to template
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12693
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
Patch complexity|--- |Trivial patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 21:12:01 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 19:12:01 +0000
Subject: [Koha-bugs] [Bug 12693] colspan calculation done by
members/statistics.pl should be moved to template
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12693
--- Comment #1 from Owen Leonard ---
Created attachment 30471
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30471&action=edit
Bug 12693 - colspan calculation done by members/statistics.pl should be moved
to template
It is not necessary for the patron statistics script to pass a colspan
value to the template. The number can be output using Template::Toolkit
syntax.
To test, view the statistics page for a patron. Confirm that the "Total"
cell in the footer spans the correct number of columns. Test with
various numbers of fields in the StatisticsFields system preference.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 21:23:10 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 19:23:10 +0000
Subject: [Koha-bugs] [Bug 12677] Use Bootstrap "label" style for inline OPAC
renewal messages
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12677
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 21:23:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 19:23:15 +0000
Subject: [Koha-bugs] [Bug 12677] Use Bootstrap "label" style for inline OPAC
renewal messages
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12677
--- Comment #1 from Owen Leonard ---
Created attachment 30472
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30472&action=edit
Bug 12677 - Use Bootstrap "label" style for inline OPAC renewal messages
This patch revises the styling of the renewal success message to use a
default Bootstrap style more suited to inline messages. I think this is
preferable to using the alert style because the alert is designed to be
a block-level element.
http://getbootstrap.com/2.3.2/components.html#labels-badges
Because Koha's CSS already uses a "label" class for something else I
duplicate the Bootstrap "label" class in opac.css as "blabel." The
Bootstrap color definitions are included.
To test, follow the test plan already provided:
1) Apply this patch
2) From the OPAC, renew some items
3) Note the "Renewed!" message in the "Renew" column of the checkouts
table
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 21:29:16 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 19:29:16 +0000
Subject: [Koha-bugs] [Bug 8148] ldap authentication should FAIL if ldap
contains NEW password, and user types the PREVIOUS password
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8148
--- Comment #31 from Tom?s Cohen Arazi ---
Created attachment 30473
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30473&action=edit
Bug 8148: (regression tests) C4::Auth_with_ldap needs unit tests
This followup provides some unit tests for C4::Auth_with_ldap. It implements
regression tests for this bug's changes too.
The aim was to cover all use cases for checkpw_ldap from the first line up to
those touched by this bug's patches. It should serve as a start for having
unit tests for the LDAP thing.
Having said that: no excuses for not providing regression tests for LDAP from
now on :-/
Regards
To+
Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Aug 1 23:33:45 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 21:33:45 +0000
Subject: [Koha-bugs] [Bug 12037] MARC21 authority editor: can't edit/add
'Koha field' to auth subfield
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12037
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #1 from Bernardo Gonzalez Kriegel ---
This was fixed on Bug 12614
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 00:43:19 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Aug 2014 22:43:19 +0000
Subject: [Koha-bugs] [Bug 12669] "Template process failed: undef error -
Invalid local time for date in time zone"
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #30446|0 |1
is obsolete| |
--- Comment #7 from Chris Cormack ---
Created attachment 30474
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30474&action=edit
Bug 12669: Use floating timezone when handling dates without hours, minutes and
seconds.
Test plan:
1. Create a new serial record or pick an existing one;
2. Add a "New subscription" and set the "First issue publication date"
and "Frequency" values so that the "Planned date" for a given issue
hits a day where a transition to Daylight Saving Time (DST) occurs
ex:. 1979-04-01 in Europe/Lisbon
(http://www.timeanddate.com/time/change/portugal/lisbon?year=1979)
... use this website page as a source
http://www.timeanddate.com/time/dst/2014.html
to find a suitable transition to DST in your timezone in the current year.
3. From the "Subscription detail" page in Koha for the given record click
the "Serial collection" link on the left side context menu.
Expected result:
Prior to applying the patch the error described in this bug report should
occur.
After the patch is applied the "Serial collection" page should load correctly.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 03:16:18 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 01:16:18 +0000
Subject: [Koha-bugs] [Bug 12694] New: Remove CGI::scrolling_list from
unimarc_field_4XX.pl
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12694
Bug ID: 12694
Summary: Remove CGI::scrolling_list from unimarc_field_4XX.pl
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Templates
Assignee: oleonard at myacpl.org
Reporter: bgkriegel at gmail.com
QA Contact: testopia at bugs.koha-community.org
Two on this file
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 03:27:41 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 01:27:41 +0000
Subject: [Koha-bugs] [Bug 12694] Remove CGI::scrolling_list from
unimarc_field_4XX.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12694
--- Comment #1 from Bernardo Gonzalez Kriegel ---
Created attachment 30475
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30475&action=edit
Bug 12694: Remove CGI::scrolling_list from unimarc_field_4XX.pl
There are two instances on this file, but they are not used.
I suppose is old code that was left dangling.
Both scrolling_list, CGIPublisher and CGIitemtype, are not
used on unimarc_field_4XX.tt nor any other file.
Just removed from file two useless db queries.
To test:
1. Apply the patch
2. If you have unimarc config, just go to one of the
fields that use this plugin.
If you don't, can edit you framework and change the plugin
for a tag, e.g. 007. Then save fw, search and edit a record,
clic to open plugin on 007 tag, check that works but don't
save the original record, finally revert your changes.
There must be no functional changes, is unused code.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 03:28:58 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 01:28:58 +0000
Subject: [Koha-bugs] [Bug 12694] Remove CGI::scrolling_list from
unimarc_field_4XX.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12694
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
Patch complexity|--- |Small patch
Blocks| |766
Assignee|oleonard at myacpl.org |bgkriegel at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 03:28:58 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 01:28:58 +0000
Subject: [Koha-bugs] [Bug 766] Omnibus: Use of CGI::scrolling_list prevents
customization in template
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |12694
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 03:48:24 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 01:48:24 +0000
Subject: [Koha-bugs] [Bug 12695] New: Remove CGI::scrolling_list from
marc21_linking_section.pl
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12695
Bug ID: 12695
Summary: Remove CGI::scrolling_list from
marc21_linking_section.pl
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Templates
Assignee: oleonard at myacpl.org
Reporter: bgkriegel at gmail.com
QA Contact: testopia at bugs.koha-community.org
Two in this file
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 03:55:40 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 01:55:40 +0000
Subject: [Koha-bugs] [Bug 12695] Remove CGI::scrolling_list from
marc21_linking_section.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12695
--- Comment #1 from Bernardo Gonzalez Kriegel ---
Created attachment 30476
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30476&action=edit
Bug 12695: Remove CGI::scrolling_list from marc21_linking_section.pl
Same situation as Bug 12694.
There are two instances on this file, but they are not used.
I suppose is old code that was left dangling.
Both scrolling_list, CGIPublisher and CGIitemtype, are not
used on marc21_linking_section.tt nor any other file.
Just removed from file two useless db queries.
To test:
1. Apply the patch
2. Can't remember how to trigger this plugin.
You can edit you framework and change the plugin
for a tag, e.g. 007. Then save fw, search and edit a record,
clic to open plugin on 007 tag, check that works but don't
save the original record, finally revert your changes.
There must be no functional changes, is unused code.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 03:56:46 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 01:56:46 +0000
Subject: [Koha-bugs] [Bug 766] Omnibus: Use of CGI::scrolling_list prevents
customization in template
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |12695
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 03:56:46 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 01:56:46 +0000
Subject: [Koha-bugs] [Bug 12695] Remove CGI::scrolling_list from
marc21_linking_section.pl
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12695
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
Patch complexity|--- |Small patch
Blocks| |766
Assignee|oleonard at myacpl.org |bgkriegel at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 04:06:19 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 02:06:19 +0000
Subject: [Koha-bugs] [Bug 12696] New: Remove CGI::scrolling_list from
C4/Reports.pm
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12696
Bug ID: 12696
Summary: Remove CGI::scrolling_list from C4/Reports.pm
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Templates
Assignee: oleonard at myacpl.org
Reporter: bgkriegel at gmail.com
QA Contact: testopia at bugs.koha-community.org
One in this file
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 05:37:30 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 03:37:30 +0000
Subject: [Koha-bugs] [Bug 12696] Remove CGI::scrolling_list from
C4/Reports.pm
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12696
--- Comment #1 from Bernardo Gonzalez Kriegel ---
Created attachment 30477
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30477&action=edit
Bug 12696: Remove CGI::scrolling_list from C4/Reports.pm
This patch removes only instance in this file.
Problem is that there are many template files
involved. Most of them have other instances of
scrolling_lists but is a problem for other bugs,
they will depend on this.
What is replaced is a pulldown for delimiter choices.
In all but one case the code is the same (variable name change),
and I did a little tidy of the TT code
To test:
1. Apply the patch
In all the following cases, check delimiters pulldown (Output box, bottom
right)
2. Go to Reports > Statistics wizard > Acquisitions
3. Go to Reports > Statistics wizard > Patrons
4. Go to Reports > Statistics wizard > Catalog
5. Go to Reports > Statistics wizard > Circulation
6. Go to Reports > Statistics wizard > Serials
7. Go to Reports > Statistics wizard > Holds
there is a bug here, pulldown next to this must show 'CSV' option,
but shows nothing. Will be fixed
8. Go to Reports > Other > Average loan time
9. Go to Reports > Top lists > Patron checking out the most
Here there is a 'Delimiter' label before delimiters, only case
10. Go to Reports > Top lists > Most-circulated items
11. Go to Reports > Inactive > Patrons who haven't checked out
There is and inconsistency here, name of option on reports page,
and name on this report, 'Patrons with no checkouts'
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 05:39:29 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 03:39:29 +0000
Subject: [Koha-bugs] [Bug 766] Omnibus: Use of CGI::scrolling_list prevents
customization in template
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |12696
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 05:39:29 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 03:39:29 +0000
Subject: [Koha-bugs] [Bug 12696] Remove CGI::scrolling_list from
C4/Reports.pm
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12696
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
Patch complexity|--- |Small patch
Blocks| |766
Assignee|oleonard at myacpl.org |bgkriegel at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 05:56:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 03:56:15 +0000
Subject: [Koha-bugs] [Bug 12424] ddc sorting of call numbers truncates long
Cutter parts
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12424
--- Comment #4 from giuseppe.angilella at ct.infn.it ---
I wouldn't foresee any problem. Thanks for looking into that!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 06:24:38 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 04:24:38 +0000
Subject: [Koha-bugs] [Bug 10542] QueryParser + OpacSuppression doesn't allow
search in 'all libraries'
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10542
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #29942|0 |1
is obsolete| |
--- Comment #27 from Bernardo Gonzalez Kriegel ---
Created attachment 30478
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30478&action=edit
[SIGNED-OFF] Bug 10542: Fix QueryParser with OpacSupression
OpacSupressions manipulates the query string after the buildQuery
call and so breaks with queryParser enabled. This patch adds
checks for queryParser and manipulates the query before passing it
to buildQuery if it is enabled, but leaves the post buildQuery
manipultation when queryParser is disabled
Signed-off-by: Chris Cormack
Signed-off-by: Bernardo Gonzalez Kriegel
Adding a sing after test
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 06:24:47 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 04:24:47 +0000
Subject: [Koha-bugs] [Bug 10542] QueryParser + OpacSuppression doesn't allow
search in 'all libraries'
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10542
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #29944|0 |1
is obsolete| |
--- Comment #28 from Bernardo Gonzalez Kriegel ---
Created attachment 30479
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30479&action=edit
[SIGNED-OFF] Bug 10542: QueryParser + OpacSuppression doesn't allow search in
'all libraries'
Since we're using the $query_type variable to detect if this pre-built
query is PQF, we need to use PQF syntax (rather than QueryParser
syntax) when adding to the query. I've made a lot of notes of somewhat
incoherent notes on Bugzilla talking about PQF, CCL, and QP syntaxes,
but I'm hoping to refine these notes on a wiki page for future
reference.
_TEST PLAN_
1) Set 'Suppress in Opac' (ie 942$n) to 1 for one record
2) Re-index Zebra
3) Set 'OpacSuppression' to 'Hide'
4) Set 'UseQueryParser' to 'Do not try'
5) In the staff client, do a search that will return that suppressed
record as well as a few records that are NOT suppressed
6) Note that you can return that suppressed record in the staff client
7) Do the same search in the OPAC
8) Note that the suppressed record doesn't appear
9) Set 'UseQueryParser' to 'Try' && re-run the OPAC search
10) Note that no results appear (the logs will probably mention a
ZOOM error)
11) Apply patch
12) Re-run the OPAC search
13) Note that the suppressed record doesn't appear, and that the
not suppressed records are showing (it's important that you are
getting some results...as ZOOM errors are silent in the UI).
14) Set 'UseQueryParser' to 'Do not try'
15) Re-run the search
16) Note that the suppressed record doesn't appear, and that the
not suppressed records are showing
Signed-off-by: Bernardo Gonzalez Kriegel
Work as described following test plan.
No koha-qa errors.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 06:25:15 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 04:25:15 +0000
Subject: [Koha-bugs] [Bug 10542] QueryParser + OpacSuppression doesn't allow
search in 'all libraries'
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10542
Bernardo Gonzalez Kriegel changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |bgkriegel at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 09:29:31 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 07:29:31 +0000
Subject: [Koha-bugs] [Bug 12162] Add class="branchcode" to body tag to make
OPAC CSS-styleable per branch
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12162
M. de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
--- Comment #14 from M. de Rooy ---
I like the idea, but it seems to be a problem with translation.
See coding guidelines: HTML1: Template Toolkit markup inside HTML.
When can we override this rule?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 09:40:06 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 07:40:06 +0000
Subject: [Koha-bugs] [Bug 12669] "Template process failed: undef error -
Invalid local time for date in time zone"
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|Small patch |Trivial patch
Version|3.14 |master
Severity|blocker |normal
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 09:52:21 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 07:52:21 +0000
Subject: [Koha-bugs] [Bug 12424] ddc sorting of call numbers truncates long
Cutter parts
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12424
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |ASSIGNED
CC| |chris at bigballofwax.co.nz
--- Comment #5 from Chris Cormack ---
I think this accidentally got switch to needs signoff, without having a patched
attached to sign off on.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 10:00:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 08:00:56 +0000
Subject: [Koha-bugs] [Bug 11847] Display basketgroup closed date at OPAC
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11847
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 10:00:59 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 08:00:59 +0000
Subject: [Koha-bugs] [Bug 11847] Display basketgroup closed date at OPAC
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11847
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #30445|0 |1
is obsolete| |
--- Comment #9 from Chris Cormack ---
Created attachment 30480
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30480&action=edit
Bug 11847: Display basketgroup closed date at OPAC
in Holdings table, on detail page.
Test plan:
1/ Enable OPACAcquisitionDetails syspref
2/ Set AcqCreateItem syspref to "ordering"
3/ Create a basket with 1 order, close this basket then create a
basketgroup with this basket and close the basketgroup
4/ Create another basket with 1 order on the same biblio record as
previous order. Close the basket then create a basketgroup with this
basket but do not close it.
5/ Go to the OPAC detail page of the biblio record.
6/ In holdings table, under "Status" column, you should see:
- for the first item ordered: "On order since DATE"
- for the second item ordered: "On order"
Signed-off-by: Chris Cormack
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 10:03:14 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 08:03:14 +0000
Subject: [Koha-bugs] [Bug 12162] Add class="branchcode" to body tag to make
OPAC CSS-styleable per branch
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12162
--- Comment #15 from Marc V?ron ---
Hi Marcel,
Thanks for the comment. I was not aware of the translation restriction.
What do you think about the following:
[% IF ( LoginBranchcode ) %]
[% ELSE %]
[% END %]
Marc
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 10:08:01 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 08:08:01 +0000
Subject: [Koha-bugs] [Bug 12539] PROG/CCSR deprecation: Remove hardcoded
theme from C4/Templates.pm
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12539
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 10:08:05 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 08:08:05 +0000
Subject: [Koha-bugs] [Bug 12539] PROG/CCSR deprecation: Remove hardcoded
theme from C4/Templates.pm
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12539
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #30439|0 |1
is obsolete| |
--- Comment #5 from Chris Cormack ---
Created attachment 30481
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30481&action=edit
Bug 12539: PROG/CCSR deprecation: Remove hardcoded theme from C4/Templates.pm
This patch removes hardcoded 'prog' from themelanguage on C4/Templates.pm
It adds a new syspref OPACFallback to hold the prefferred fallback
theme for new themes with minimal changes.
This does not brake CCSR if new syspref value is 'prog',
using 'bootstrap' works somehow, but with strange results.
To test:
1) Apply the patch
2) Run updatedatbase.pl
3) CCSR, prog & bootstrap must work as usual
4) Need to test theme/language fallback
a) translate for your preferred language (xx-YY)
b) enable language on opac
c) go to opac, select that language
d) login on opac, go to personal details
e) remove koha-tmpl/opac-tmpl/bootstrap/xx-YY/modules/opac-memberentry.tt
d) reload page, must load in English
f) click other member options, must load on translated language
(can use other pages, ccsr, prog or bootstrap)
5) Do a similar test but for a staff page, enable lang, switch to it,
rm koha-tmpl/intranet-tmpl/prog/xx-YY/modules/admin/admin-home.tt,
any page must be translated except for admin home.
Signed-off-by: Chris Cormack
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 10:12:01 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 08:12:01 +0000
Subject: [Koha-bugs] [Bug 12677] Use Bootstrap "label" style for inline OPAC
renewal messages
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12677
--- Comment #2 from Marc V?ron ---
Created attachment 30482
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30482&action=edit
[Signed-off] Bug 12677 - Use Bootstrap "label" style for inline OPAC renewal
messages
This patch revises the styling of the renewal success message to use a
default Bootstrap style more suited to inline messages. I think this is
preferable to using the alert style because the alert is designed to be
a block-level element.
http://getbootstrap.com/2.3.2/components.html#labels-badges
Because Koha's CSS already uses a "label" class for something else I
duplicate the Bootstrap "label" class in opac.css as "blabel." The
Bootstrap color definitions are included.
To test, follow the test plan already provided:
1) Apply this patch
2) From the OPAC, renew some items
3) Note the "Renewed!" message in the "Renew" column of the checkouts
table
Patch works as expected.
Signed-off-by: Marc V?ron
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 10:12:44 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 08:12:44 +0000
Subject: [Koha-bugs] [Bug 12677] Use Bootstrap "label" style for inline OPAC
renewal messages
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12677
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #30472|0 |1
is obsolete| |
CC| |veron at veron.ch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 10:12:47 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 08:12:47 +0000
Subject: [Koha-bugs] [Bug 12697] New: Surplus closing in OPAC
advanced search (bootstrap)
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12697
Bug ID: 12697
Summary: Surplus closing in OPAC advanced search
(bootstrap)
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: OPAC
Assignee: oleonard at myacpl.org
Reporter: abl at biblos.pk.edu.pl
QA Contact: testopia at bugs.koha-community.org
In koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt template, there
is a surplus closing in line 336 (= line 332, in case Bug 12521 is
applied first):
336:
which causes some minor layout problems for this page - i.e.: page footer
("Powered by Koha" + custom footer set up in system prefrences - if any) is
"glued" to the bottom (to the language selection bar); unless Bug 12521 is
applied first, this affects the placement of the 2nd search bar as well.
To reproduce:
1/ go to the OPAC advanced search page
2/ zoom out (e.g., use Ctrl- several times) and obeserve the result
3/ no need for step 2/ (zooming out) when using a display with (relatively)
high vertical resolution; also, this particullar problem gets more
apparent/more noticeable with MARC21/USMASRC "subtype" options being hidden in
the OPAC advanced search (Bug 9043).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 10:13:00 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 08:13:00 +0000
Subject: [Koha-bugs] [Bug 12677] Use Bootstrap "label" style for inline OPAC
renewal messages
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12677
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 10:17:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 08:17:56 +0000
Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field
for serials
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 10:18:02 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 08:18:02 +0000
Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field
for serials
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #30381|0 |1
is obsolete| |
--- Comment #69 from Chris Cormack ---
Created attachment 30483
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30483&action=edit
Bug 8296: Follow up for QA
1 redefined variable removed
Signed-off-by: Julian Maurice
Signed-off-by: Cedric Vita
Signed-off-by: Chris Cormack
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 10:18:52 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 08:18:52 +0000
Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field
for serials
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #30383|0 |1
is obsolete| |
--- Comment #70 from Chris Cormack ---
Created attachment 30484
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30484&action=edit
Bug 8296: Display publisheddatetext in OPAC bootstrap theme
and remove modifications for OPAC prog theme
Signed-off-by: Chris Cormack
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 10:20:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 08:20:56 +0000
Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field
for serials
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #30382|0 |1
is obsolete| |
--- Comment #71 from Chris Cormack ---
Created attachment 30485
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30485&action=edit
Bug 8296: Don't fill text field automatically
+ minor fixes:
* Add bug number to updatedatabase
* Fix colspan in serials-edit.tt
Signed-off-by: Chris Cormack
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 10:22:29 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 08:22:29 +0000
Subject: [Koha-bugs] [Bug 12697] Surplus closing in OPAC advanced
search (bootstrap)
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12697
Jacek Ablewicz changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
Patch complexity|--- |Trivial patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 10:22:31 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 08:22:31 +0000
Subject: [Koha-bugs] [Bug 12697] Surplus closing in OPAC advanced
search (bootstrap)
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12697
--- Comment #1 from Jacek Ablewicz ---
Created attachment 30486
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30486&action=edit
Bug 12697 - Surplus closing in OPAC advanced search (bootstrap)
In koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt template,
there is a surplus closing in line 336 (= line 332, in case
Bug 12521 is applied first):
336:
which causes some minor layout problems for this page - i.e.: page
footer ("Powered by Koha" + custom footer set up in system prefrences -
if any) is "glued" to the bottom (to the language selection bar);
unless Bug 12521 is applied first, this affects the placement of the
2nd search bar as well.
To reproduce:
1/ go to the OPAC advanced search page
2/ zoom out (e.g., use Ctrl- several times) and obeserve the
result
3/ no need for step 2/ (zooming out) when using a display with
(relatively) high vertical resolution; also, this particullar problem
gets more apparent/more noticeable with MARC21/USMASRC "subtype"
options being hidden in the OPAC advanced search (Bug 9043).
To test:
1/ ensure that Bug 12521 is applied first/already applied
2/ apply patch
3/ confirm that this issue is no longer reroductible
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 10:23:07 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 08:23:07 +0000
Subject: [Koha-bugs] [Bug 12697] Surplus closing in OPAC advanced
search (bootstrap)
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12697
Jacek Ablewicz changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |abl at biblos.pk.edu.pl
Assignee|oleonard at myacpl.org |abl at biblos.pk.edu.pl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 10:24:25 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 08:24:25 +0000
Subject: [Koha-bugs] [Bug 12521] Arrangement of divs on opac-advsearch.tt
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12521
Jacek Ablewicz changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |12697
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 10:24:25 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 08:24:25 +0000
Subject: [Koha-bugs] [Bug 12697] Surplus closing in OPAC advanced
search (bootstrap)
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12697
Jacek Ablewicz changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |12521
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 10:30:40 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 08:30:40 +0000
Subject: [Koha-bugs] [Bug 12521] Arrangement of divs on opac-advsearch.tt
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12521
Jacek Ablewicz changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |abl at biblos.pk.edu.pl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 10:38:57 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 08:38:57 +0000
Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access
to patrons on the OPAC
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 10:39:01 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 08:39:01 +0000
Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access
to patrons on the OPAC
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #30349|0 |1
is obsolete| |
--- Comment #8 from Chris Cormack ---
Created attachment 30487
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30487&action=edit
Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC
QA Follow up
This patch will stop a person without access hitting the url directly and
being able to change their messaging preferences.
Signed-off-by: Chris Cormack
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 10:39:56 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 08:39:56 +0000
Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access
to patrons on the OPAC
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |chris at bigballofwax.co.nz
--- Comment #9 from Chris Cormack ---
Hi Simith
As your first patch was already signed off, I reformatted your second to only
include the new changes and signed off on that.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 10:48:24 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 08:48:24 +0000
Subject: [Koha-bugs] [Bug 4013] road type missing on search results
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4013
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 10:48:26 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 08:48:26 +0000
Subject: [Koha-bugs] [Bug 4013] road type missing on search results
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4013
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #30336|0 |1
is obsolete| |
--- Comment #6 from Chris Cormack ---
Created attachment 30488
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30488&action=edit
Bug 4013 [Revised] road type missing on search results
On the patron search results page there are several patron fields which
do not show: street number, road type, and state. This patch adds them.
To test, go to Patrons -> Search patrons and perform a search. In the
table of patron search results each patron record should display the
correct information including street number, road type, and state.
Signed-off-by: Chris Cormack
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 17:31:33 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 15:31:33 +0000
Subject: [Koha-bugs] [Bug 11126] Make the holds system optionally give
precedence to local holds
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nick at quecheelibrary.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 18:31:42 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 16:31:42 +0000
Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Patch doesn't apply
--- Comment #43 from Nick Clemens ---
Applying: Bug 8836 - Resurrect Rotating Collections
Applying: Bug 8836 - Resurrect Rotating Collections - QA Followup
Applying: Bug 8836 - Resurrect Rotating Collections - Followup 2 - Perltidy
rotating collections scripts
Using index info to reconstruct a base tree...
:59: trailing whitespace.
"INSERT INTO collections ( colId, colTitle, colDesc )
:211: trailing whitespace.
"SELECT
:373: trailing whitespace.
"DELETE FROM collections_tracking
:424: trailing whitespace.
"SELECT barcode FROM items, collections_tracking
:471: trailing whitespace.
"SELECT holdingbranch, colBranchcode FROM items, collections,
collections_tracking
warning: 5 lines add whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging rotating_collections/transferCollection.pl
CONFLICT (content): Merge conflict in
rotating_collections/transferCollection.pl
Auto-merging rotating_collections/rotatingCollections.pl
CONFLICT (content): Merge conflict in
rotating_collections/rotatingCollections.pl
Auto-merging rotating_collections/editCollections.pl
CONFLICT (content): Merge conflict in rotating_collections/editCollections.pl
Auto-merging rotating_collections/addItems.pl
CONFLICT (content): Merge conflict in rotating_collections/addItems.pl
Failed to merge in the changes.
Patch failed at 0001 Bug 8836 - Resurrect Rotating Collections - Followup 2 -
Perltidy rotating collections scripts
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-8836---Resurrect-Rotating-Collections---Follow-DX51L_.patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 19:03:48 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 17:03:48 +0000
Subject: [Koha-bugs] [Bug 12576] search links need style id
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12576
--- Comment #2 from Nick Clemens ---
Created attachment 30489
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30489&action=edit
Attachment to Bug 12576 - search links need style id
[SIGNED OFF] Bug 12576: Make the more/fewer options and "new search" links on
the advanced search page look better.
How to test:
1/ Visit /cgi-bin/koha/opac-search.pl
2/ Assert the "More/Fewer options" buttons look like bootstrap default buttons
3/ Assert the "New search" button looks like a bootstrap default button
4/ Assert the visited colour of the buttons remains #333 (light grey)
5/ Assert the buttons still function as expected
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 19:06:01 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 17:06:01 +0000
Subject: [Koha-bugs] [Bug 12576] search links need style id
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12576
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #30065|0 |1
is obsolete| |
CC| |nick at quecheelibrary.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 19:06:27 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 17:06:27 +0000
Subject: [Koha-bugs] [Bug 12576] search links need style id
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12576
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--- Comment #3 from Nick Clemens ---
All worked as expected and looks great
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 19:38:06 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 17:38:06 +0000
Subject: [Koha-bugs] [Bug 12576] search links need style id
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12576
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de,
| |oleonard at myacpl.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Aug 2 19:40:58 2014
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Aug 2014 17:40:58 +0000
Subject: [Koha-bugs] [Bug 12670] Show materials label instead of code
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12670
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
CC| |nick at quecheelibrary.org
--- Comment #2 from Nick Clemens