[Koha-bugs] [Bug 4045] No check for maximum number of allowed holds from OPAC.

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045

--- Comment #70 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Test results:
Hopefully understandable enough (bl=bib level; il=item level; numbers are bibs)
Will refer to this in my QA comment.

First test (biblevel maxreserves=3 issuingrules=10 on all itypes)
bl 668 OK
bl 1178 OK
req on two biblios: get warning when submitting: ERROR: Internal error:
incomplete hold request.
So both holds are blocked. But the error message is kind of vague. Result of
bad_data flag in opac-reserve.pl
No blocker, but this could still be improved.
bl 1234 on third OK
try no 4 (1235) message fine OK
try 4 via staff warning, but hold is placed [staff overrules: design??] Note
that I had AllowHoldPolicyOverride=Do not allow override! 
try 5 via opac: You cannot place more than 4 holds. (Oops: actually more than 3
should not be allowed..)

Second test (itemlevel maxres=3 issu=2 on all itypes)
il 668
il 1178
req on two: Funny: Four warnings: None can be placed on hold (Fine). Sorry, you
can only place 1 more holds (Small spelling issue too! But it is not true! I
have gone above the number of 2 in issuingrules. Please uncheck boxes
(Impossible: there are no boxes to uncheck..)
Per biblio a warning: No available items.
il 1234 None can be placed on hold (OK)
Changing issu=2 to issu=3: repeat il 1234 (OK)
try no 4 (1235): You cannot place more than 3 holds (OK)
try 4 via staff Cannot place hold on some items (No items are available) So,
this time I cannot overrule it.

Third test (item level maxres=3 issu=2 on BK only)
il 668 BK
il 1178 BK
try il 1234 BK None can be placed (OK)
try il 1331 CF Sorry none can be placed (Not true: I just have 2 holds; For
itype CF I should have one to go?)
try il 1331 CF on staff: Cannot place a hold. No items av. (Not true?)
delete two reserves, try il 1331 CF: Still impossible.

Fourth test (item level issu BK=2 issu CF=4) 
il 668 BK
il 1178 BK
try il 1234 BK None placed: OK
try il 1331 CF Can be done: OK
retry il 1331 CF No more than 3: OK (maxreserves overrules the CF=4 rule here..
Debatable?)
try il 1235 BK You cannot place more than 3: OK

-- 
You are receiving this mail because:
You are watching all bug changes.