[Koha-bugs] [Bug 12448] Ask for confirmation when checking out an item with rental fees

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12448

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

--- Comment #37 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Maxime, we try to avoid squashing patches, when it would mean to lose
sign-off lines or a mix up of authorship of the code. The code in your squashed
patch looks perfectly fine, but now we are missing the sign-off lines from
Christopher and Marc. A follow-up would have worked better in this case.

I am switching back to Needs Signoff for now - if Marc or Christopher are ok
with it, I can also add back their lines, but didn't want to add them to
changed code without their permission.

-- 
You are receiving this mail because:
You are watching all bug changes.