[Koha-bugs] [Bug 12708] New: Unexpected behaviour in IE 9 and lower when using openWindow

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12708

            Bug ID: 12708
           Summary: Unexpected behaviour in IE 9 and lower when using
                    openWindow
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org

Currently, we use a Javascript function called "openWindow" in staff-global.js
as a bit of a helper function for executing "window.open".

Well, there is a problem with the "name" argument when using IE 9 and lower. If
the "name" has a space or certain punctuation (NOT including underscores),
it'll throw an error which causes unexpected behaviours.

For instance, if you open "Help" in the staff client using IE 9 or lower, it'll
open the help page into the current window rather than a pop-up, which is far
from desirable.

I've noticed after a few greps that we usually use an alphabetic string with no
spaces or punctuation when using the "name" parameter for window.open.
According to Mozilla
(https://developer.mozilla.org/en-US/docs/Web/API/Window.open), this is the
recommended way of writing a "name".

There are only a few instances where "openWindow" seems to use a string
containing spaces for "name". 

The best thing to do is probably fix those instances as well as add a try/catch
in openWindow for times where someone makes a mistake.

-- 
You are receiving this mail because:
You are watching all bug changes.