[Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30176|0                           |1
        is obsolete|                            |

--- Comment #16 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 30601
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30601&action=edit
[SIGNED-OFF] Bug 12167: Clean up GetNewsToDisplay

This bug started out as a result of busting while in transitions
of MySQL were happening in Ubuntu. However, I figured this fix
should remove backtick MySQLisms as per
http://wiki.koha-community.org/wiki/Coding_Guidelines#SQL6:_Backticks
And clean up GetNewsToDisplay a bit.

TEST PLAN
---------
1) News should function fine before applying any patches.
2) Apply all patches.
3) prove -v t/db_dependent/NewsChannels.t
   -- expecting all happy results.
   -- note the removal of backticks and the assumed typecasting
      of a timestamp to date.
   -- specified opac_news.timestamp to make sure that it would
      more likely parse as a fieldname and not as a keyword.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

All patches applied, test pass, cleaner code, no regressions found,
no koha-qa errors

-- 
You are receiving this mail because:
You are watching all bug changes.