[Koha-bugs] [Bug 7162] Factorize code for order cancellation

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathsabypro at gmail.com

--- Comment #90 from mathieu saby <mathsabypro at gmail.com> ---
Hello
I know it has passed QA, but I would like to make some remarks, especially
regarding bug 10869.
Currently, the 1st parameter passed to DelOrder is the biblionumber of the
record. This make the cancelation of an order impossible if the record linked
with the order is deleted (and yes, it happens in real life ;-) ).
So bug 10869 tries to fix that by inversing the 2 parameters of DelOrder :
ordernumber (mandatory), then biblionumber (optional).
When bug 7162 is pushed, the logic of bug 10869 should be changed, because we
will have 4 parameters : $bibnum, $ordernumber, $delete_biblio, $reason
I suppose the best way to make $bibnum optional, as well as $delete_biblio and
$reason would be to pass a hashref to DelOrder instead of the 4 separate
values?

Could you give me your opinion about that?

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.