[Koha-bugs] [Bug 12754] Add XSLT action to MARC modification templates

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Aug 14 15:30:38 CEST 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12754

--- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to M. de Rooy from comment #12)
> (In reply to Kyle M Hall from comment #10)
> > Very promising! I have a few suggestions before I would sign it off though:
> > 1) Change the database column name from "run_xslt" to just "xslt". To me
> > "run_xslt" sounds like a boolean, and could cause confusion for future
> > developers.
> > 2) Change the phrase "Run XSLT" to "Apply XSLT", which is a more proper way
> > to describe this in English.
> > 3) The form input for the XSLT code should be a textarea, rather than a
> > single line text input.
> > 4) Please add a formal step by step test plan
> > 
> > With those changes, I think this will make an excellent addition for the
> > modification templates!
> 
> Will do that.
> About point 3: The single line of text refers to a filename instead of the
> actual xslt code.

Is this a reference to a file on the server? Would it not be easier to store
the code in the database so it can be viewed and edited from the template
editor?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list