[Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906

--- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 30681
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30681
[Signded-off] Bug 6906 - show 'Borrower has previously...

Review of attachment 30681:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6906&attachment=30681)
-----------------------------------------------------------------

::: Koha/Borrower/CheckPrevIssue.pm
@@ +29,5 @@
> +);
> +
> +=head1 Koha::Borrower::CheckPrevIssue
> +
> +Koha::Borrower::Debarments - Manage Previous Issue preferences & searches.

(trivial) Should be Koha::Borrower::CheckPrevIssue :)

@@ +65,5 @@
> +sub _WantsCheckPrevIssueByCat {
> +    my ( $borrowernumber ) = @_;
> +    my $dbh = C4::Context->dbh;
> +    my $query = '
> +SELECT categories.checkprevissue

(not a blocker) Could be rewritten in a follow-up to use DBIC.

::: installer/data/mysql/kohastructure.sql
@@ +265,4 @@
>    `altcontactphone` varchar(50) default NULL, -- the phone number for the alternate contact for the patron/borrower
>    `smsalertnumber` varchar(50) default NULL, -- the mobile phone number where the patron/borrower would like to receive notices (if SNS turned on)
>    `privacy` integer(11) DEFAULT '1' NOT NULL, -- patron/borrower's privacy settings related to their reading history
> +  `checkprevissue` varchar(7) NOT NULL default 'inherit', -- produce a warning for this borrower if this item has previously been issued to this borrower if 'yes', not if 'no', defer to category setting if 'inherit'.

(normal) This needs to be added to deletedborrowers as well as both tables need
to be kept in sync.

::: installer/data/mysql/updatedatabase.pl
@@ +8606,5 @@
> +$DBversion = "3.17.00.XXX";
> +if ( CheckVersion($DBversion) ) {
> +    $dbh->do("INSERT INTO systempreferences (variable,value,options,explanation,type) VALUES('CheckPrevIssue','0','','By default, for every item issued, should we warn if the patron has borrowed that item in the past?','YesNo')");
> +    $dbh->do("ALTER TABLE categories ADD (`checkprevissue` varchar(7) NOT NULL default 'inherit')");
> +    $dbh->do("ALTER TABLE borrowers ADD (`checkprevissue` varchar(7) NOT NULL default 'inherit')");

(normal) deletedborrowers need to be added here as well.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.