[Koha-bugs] [Bug 12371] Links in every patron self-registration email points to a single borrower

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12371

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Thanks dmin! Your comments were incredibly helpful for writing this patch!

Kyle

(In reply to dmin from comment #3)
> (In reply to dmin from comment #2)
> > The problem comes from the borrowernumber for new registrants (who haven't been added to the borrowers table yet) being 0 and the query on line 591 of Letters.pm:
> 
> ($table eq 'borrower_modifications') ? "SELECT * FROM $table WHERE
> borrowernumber = ? OR verification_token = ?
> 
> Since all new, unverified borrowers have the same borrower number, the
> Boolean expression to match on always matches on the borrower # and doesn't
> look at the token.  Since, in the detault notice, the only field used in the
> letter OPAC_REG_VERIFY is the token, it's not immediately obvious that it
> grabbed the wrong record from the table.  
> 
> A workaround, which does not appear to impact any other is to alter the
> query to ensure the token is checked if the borrower number is 0.  There is
> probably a better way than this, but it as worked for me:
> 
> ($table eq 'borrower_modifications') ? "SELECT * FROM $table WHERE
> (borrowernumber = 0 OR borrowernumber = ?) AND verification_token =?"
> 
> I'm not familiar with how to propose a patch properly, but this is a small
> change in a single line of a module, so I thought I should share.  If this
> should have gone in the comments, sorry, I'm new to all this.

-- 
You are receiving this mail because:
You are watching all bug changes.