[Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sun Aug 17 01:21:17 CEST 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868

--- Comment #37 from Chris Cormack <chris at bigballofwax.co.nz> ---
Comment on attachment 27947
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27947
Bug 8868: ILS-DI: CancelHold needs to take a reserve_id

Review of attachment 27947:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8868&attachment=27947)
-----------------------------------------------------------------

::: C4/ILSDI/Services.pm
@@ +26,4 @@
>  use C4::Branch;
>  use C4::Accounts;
>  use C4::Biblio;
> +use C4::Reserves qw(AddReserve GetReservesFromBiblionumber GetReservesFromBorrowernumber CanBookBeReserved CanItemBeReserved);

Why do we not add CancelReserve here

@@ +744,2 @@
>  
> +    C4::Reserves::CancelReserve({reserve_id => $reserve_id});

And instead do this?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list