[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |kyle at bywatersolutions.com

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Starting with a code review:

1) (trivial) The QA script has some complaints about those patches:
 FAIL    installer/data/mysql/sysprefs.sql
   FAIL      sysprefs_order
        Not blocker: Sysprefs defaultlongoverduechargevalue is bad placed (see
bug 10610)

 FAIL    installer/data/mysql/updatedatabase.pl
   OK      critic
   FAIL      pod
        *** WARNING: =head2 without preceding higher level  in file
installer/data/mysql/updatedatabase.pl
   OK      valid
   OK      forbidden patterns

2) (trivial) Database update should include the bug number for later reference.

3) (normal) The database update and sysprefs.sql use all lowercaps system
preference names, but the pref file and the longoerdue.pl use camel case. 

4) (just a question) I took a look at our crontab example file and the cronjob
is commented out with parameters and in debian/koha-common.cron.daily the
cronjob is missing. Should we adapt those?

Please provide a follow-up and switch back to Signed-off.

-- 
You are receiving this mail because:
You are watching all bug changes.