[Koha-bugs] [Bug 8587] Add a serial lifespan to serial subscriptions

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Some notes and suggestions:

1) (blocker) There is a merge marker left in and the patch seems to add a bit
too much code in serials/subscription-detail.tt - please remove and check.

2) (trivial) Please add the bug number to the database update.

3) Suggestion: Why limit to 10 years? I think translation would work with a
variable: <span>[% serial_lifespan %] years</span>. That should give the
translators something like: %s years where the sequence can be changed.

4) Suggestion: It think it would be nice to include a change to the help file
or a patch to the manual (separately) where it's explained that this field is
not tied to any functionality, but for use in reports. We already have a
subscription end date and a subscription length, so this could cause a bit of
confusion.

-- 
You are receiving this mail because:
You are watching all bug changes.