[Koha-bugs] [Bug 8836] Resurrect Rotating Collections

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836

--- Comment #50 from Juhani Seppälä <jseppal at student.uef.fi> ---
(In reply to Kyle M Hall from comment #49)
> The squashing was fine, except you removed my authorship from the patches!
> I've uploaded a fixed version. In addition, your patch makes large changes,
> so I've moved it to a separate bug and made this one a blocker for it.
> 
> The biggest problems with your patch are
> 1) There is no test plan
> 2) The unit tests for rotating collections fail with it applied
> 
> (In reply to Juhani Seppälä from comment #46)
> > Did you mean to test the squashed patch? I didn't set anything obsolete
> > because I'm unsure as to whether squashing these old patches like this is
> > actually welcome at all - I was hoping for comments and reactions. I guess I
> > shouldn't have a set "needs signoff" - sorry. I can fix the old separate
> > patches if that's how they should be kept.

The patch authorship thing was, probably among other stuff, something I
completely missed at the time - sorry about that. I agree with the separate bug
and am aware of the missing test stuff.

-- 
You are receiving this mail because:
You are watching all bug changes.