[Koha-bugs] [Bug 12811] Patron 'Details' and 'Check out' pages not working properly for staff users which don't have renewal override permissions

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12811

--- Comment #1 from Jacek Ablewicz <ablewicz at gmail.com> ---
Created attachment 31123
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31123&action=edit
Bug 12811 - Patron 'Details' and 'Check out' pages not working properly for
staff users which don't have renewal override permissions

In case when the staff user doesn't have (circulate) -> (override_renewals)
permission granted, this code part

   var AllowRenewalLimitOverride = [% CAN_user_circulate_override_renewals &&
AllowRenewalLimitOverride %];

in circ/circulation.tt and members/moremember.tt leads to javascript error,
because TT statement evaluates to empty string.

To reproduce:

- set AllowRenewalLimitOverride syspref to "Don't allow" (this step is possibly
redundant / not quite relevant),
- for testing purposes, log in as some (sample) staff user whitch does not have
permission granted for "(override_renewals) Override blocked renewals",
- have a look at some patron accounts (preferably, ones with 1+ check-out),
observe that page layout is incorrect in "Check Out" and "Details" tab.

To test:

- apply patch,
- retest and ensure that this issue is no longer reproductible,
- make sure that there are no regressions of any kinds regarding renewal
override permission for staff users (i.e, that it still works like intended).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.