[Koha-bugs] [Bug 12815] Adding browser based multi-lingual jquery.ime input method support to Koha

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12815

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
This appears to be working correctly for me, but I have a couple of comments:

1. There should not be comments added to the markup referencing the bug number.
We have git for tracking changes.

2. Instead of adding two new include files, why not add that template logic to
doc-head-close.inc? I think the creation of new include files is only useful if
they will be included by multiple templates.

The functionality of the plugin itself seems to be good, but I think it should
be tested again by someone whose native language is represented in the list of
options.

-- 
You are receiving this mail because:
You are watching all bug changes.