[Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA
                 CC|                            |tomascohen at gmail.com

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Tests don't pass, presumably related to bug 12781 patches. Once I changed
status for STATUS in several places, more tests pass [1], but it is still
failing.

[1]
diff --git a/C4/Suggestions.pm b/C4/Suggestions.pm                              
index ddfa1b6..9461fb2 100644
--- a/C4/Suggestions.pm
+++ b/C4/Suggestions.pm
@@ -428,7 +428,7 @@ sub NewSuggestion {

     my $new_suggestion = { %$suggestion };
     $suggestion->{STATUS} = "ASKED" unless $suggestion->{STATUS};
-    $new_suggestion->{status} = $suggestion->{STATUS};
+    $new_suggestion->{STATUS} = $suggestion->{STATUS};
     delete $new_suggestion->{STATUS};

     my $rs = Koha::Database->new->schema->resultset('Suggestion');
@@ -455,7 +455,7 @@ sub ModSuggestion {
     my $mod_suggestion = { %$suggestion };
     my $status = $suggestion->{STATUS};
     delete $mod_suggestion->{STATUS};
-    $mod_suggestion->{status} = $status;
+    $mod_suggestion->{STATUS} = $status;

-- 
You are receiving this mail because:
You are watching all bug changes.