[Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #97 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Thanks so much again for persevering with this Holger!

I've done a minor QA Followup for you to correct that tiny copy/paste error in
the unit tests patch, but I'm happy everything else passes and we're covered in
the unit tests reasonably comprehensively.

I've marked the opac prog theme patch as NOT REQUIRED as we're deprecating that
theme, but as it's a completely independent patch, I'm happy it does not fail
QA.

To the RM: Holger has followed the general practices already present with
Circulation.t regarding adding data for testing against.  I'm not 100% sure how
the roll-back stuff works when using C4 subs to add data within the test so may
be sensible to take a glance over that to check I've not missed something
obvious.  As there's plenty already in that test that will make anything but
the most basic of sample database fail, then I didn't see this as something I
could reasonably fail QA on.  I would like to re-factor this test script to use
TestBuilder should that go in and I will happily do that as a follow-up in a
separate bug when time permits.

-- 
You are receiving this mail because:
You are watching all bug changes.