From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 02:20:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 01:20:10 +0000 Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 02:24:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 01:24:53 +0000 Subject: [Koha-bugs] [Bug 13363] New: 3.19 master updates Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13363 Bug ID: 13363 Summary: 3.19 master updates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: robin at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 02:28:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 01:28:31 +0000 Subject: [Koha-bugs] [Bug 13363] 3.19 master updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13363 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 02:28:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 01:28:34 +0000 Subject: [Koha-bugs] [Bug 13363] 3.19 master updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13363 --- Comment #1 from Robin Sheat --- Created attachment 34030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34030&action=edit Bug 13363: update build script for 3.19 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 02:29:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 01:29:10 +0000 Subject: [Koha-bugs] [Bug 13363] 3.19 master updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13363 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 02:29:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 01:29:33 +0000 Subject: [Koha-bugs] [Bug 13363] 3.19 master updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13363 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 02:46:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 01:46:31 +0000 Subject: [Koha-bugs] [Bug 4283] Merge bibliographic records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4283 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 03:09:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 02:09:37 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #49 from David Cook --- Actually, I'm going to put this one to "in discussion", as I don't think it's ready to be pushed to master. I think we really should spend some more time thinking through how we want the next generation of Koha::* to progress. Perhaps this should find its way to the listserv as well, as I think it's a conversation that is applicable to more than just the 5 or 6 of us. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 03:21:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 02:21:13 +0000 Subject: [Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #31 from David Cook --- Comment on attachment 27345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27345 [PASSED QA] Bug 11518 - Add new method to Koha::Schema::Result::Item that will always return the correct itemtype Review of attachment 27345: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11518&attachment=27345) ----------------------------------------------------------------- ::: Koha/Schema/Result/Biblio.pm @@ +331,4 @@ > # Created by DBIx::Class::Schema::Loader v0.07025 @ 2013-10-14 20:56:21 > # DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:0//8OGf7OteNnwT03g4QsA > > +__PACKAGE__->belongs_to( I think this already exists in master... ...and that it's not a good idea. biblio.biblionumber is a primary key. If anything, biblioitems.biblio should have a belongs_to() relationship to biblio.biblionumber rather than the other way around. Of course, I think this is here so that we can grab the associated BiblioItems object using the 'biblioitem' accessor... but it seems like a hack to me. ::: Koha/Schema/Result/Item.pm @@ +618,4 @@ > { "foreign.biblionumber" => "self.biblionumber" } > ); > > +__PACKAGE__->belongs_to( I think this relationship makes sense, but if we're adding a relationship in DBIC, we should probably be adding it in the database as well. @@ +624,5 @@ > + { biblioitemnumber => "biblioitemnumber" }, > +); > + > +use C4::Context; > +sub itemtype { I think this makes sense (insofar as it makes sense to have an item type stored at the biblio level that is). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 06:29:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 05:29:24 +0000 Subject: [Koha-bugs] [Bug 11369] Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 --- Comment #26 from David Cook --- (In reply to Katrin Fischer from comment #22) > This works as described, at least if I haven't missed something. > > Like some of the other commenters I would feel a bit better about this if we > were not losing history here at some point by limiting the number of > cookies, but stored the data in another place - sessions or using the HTML5 > feature. I think using sessions is really the way to go. I'm going to backport this patch to our local Koha, but I still think it's less than ideal. I think the best way to do this is to keep using unique IDs for the search, and to store them and the relevant data in the active session in the database. In this way, we can still have multiple tabs open with unique searches and still use the record browser without the limits imposed by using cookies. At the moment, we store the OPAC record browser info in the active session in the database, but the limitation is that the key isn't unique (ie the key is "busc"). That means if you have multiple tabs open, the browser for all of them will return the results for the latest search... definitely not a good thing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 06:29:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 05:29:56 +0000 Subject: [Koha-bugs] [Bug 11369] Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13265 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 06:29:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 05:29:56 +0000 Subject: [Koha-bugs] [Bug 13265] Still too many search cursor cookies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13265 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11369 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 06:31:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 05:31:44 +0000 Subject: [Koha-bugs] [Bug 13265] Still too many search cursor cookies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13265 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- I have an idea to fix this that would use the sessions table (like the OPAC browser but without its current limitations). The fix I have in mind will allow the result browser to work in multiple tabs without bloating the request header which leads to the fatal error. It's more work, but I think it'll be a more robust fix. That said, I wouldn't be opposed to this patch getting pushed in the mean-time... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 09:14:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 08:14:33 +0000 Subject: [Koha-bugs] [Bug 13204] Plugin housekeeping: Remove labs_theses.pl plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13204 --- Comment #5 from Fr?d?ric Demians --- I haven't any customer using this plugin, and I'm not aware of any library using it. For me, this patch could be signed-off without trouble. I can dot it if necessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 09:23:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 08:23:14 +0000 Subject: [Koha-bugs] [Bug 4283] Merge bibliographic records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4283 --- Comment #2 from Jonathan Druart --- Olli, Do you plan to worj on this? If yes, please have a look at bug 8064 :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 09:24:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 08:24:51 +0000 Subject: [Koha-bugs] [Bug 13204] Plugin housekeeping: Remove labs_theses.pl plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13204 --- Comment #6 from M. de Rooy --- (In reply to Fr?d?ric Demians from comment #5) > I haven't any customer using this plugin, and I'm not aware of any library > using it. For me, this patch could be signed-off without trouble. I can dot > it if necessary. If you can, thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 09:47:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 08:47:18 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 --- Comment #50 from Jonathan Druart --- (In reply to David Cook from comment #49) > Actually, I'm going to put this one to "in discussion", as I don't think > it's ready to be pushed to master. I think we really should spend some more > time thinking through how we want the next generation of Koha::* to progress. > > Perhaps this should find its way to the listserv as well, as I think it's a > conversation that is applicable to more than just the 5 or 6 of us. I personally don't want to discuss this implementation for the following reasons: 1/ We already have discussed (or at least tried) for years. 2/ We already have different proposals (At least from Kyle, Yohann and me). 3/ This code is functional and we will able to improve it according to our further needs. 4/ Everybody knows that putting a bug report to the 'in discussion' status without any other actions (mail on mailing list, discussion on #koha, etc) don't permit to move it forward. I strongly believe that the next step is to get the RM point of view. You can provide a patch on another report to improve the code and show us what could be better, that would be great :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 09:51:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 08:51:35 +0000 Subject: [Koha-bugs] [Bug 13204] Plugin housekeeping: Remove labs_theses.pl plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13204 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 09:51:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 08:51:38 +0000 Subject: [Koha-bugs] [Bug 13204] Plugin housekeeping: Remove labs_theses.pl plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13204 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33246|0 |1 is obsolete| | --- Comment #7 from Fr?d?ric Demians --- Created attachment 34031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34031&action=edit Bug 13204: Plugin housekeeping: Remove labs_theses.pl plugin As it seems, this plugin has been created for UNIMARC field 328 (Dissertation note). It refers to authval category LABTHE. The plugin seems however not to be used: it contains several critical errors. I tried a quick fix but it was not good enough. Since the code can be recovered from git (if needed), a real fix can always follow this patch. What are some problems: [1] The path to the template is wrong. Should be cataloguing/value_builder [2] The plugin parameter $input is not used. A new CGI object is created. [3] Resolving errors 1 and 2 still results in premature end of script headers. [4] Not sure whether the plugin can effectively handle missing LABTHE values. Instead of keeping this in Koha, I opt for removing it for now. As additional argument I would mention that labs_theses does not have Focus or Blur actions, only the Click action that does not work. Test plan: Git grep on labs_theses. Signed-off-by: Frederic Demians This antique plugin deserves to live forever in Git Historical Museum. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 09:54:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 08:54:49 +0000 Subject: [Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #32 from Jonathan Druart --- (In reply to David Cook from comment #31) > Comment on attachment 27345 [details] [review] Hello David, Did you see that the belongs_to relations are removed in another patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 10:09:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 09:09:07 +0000 Subject: [Koha-bugs] [Bug 8530] New Data Types for Holidays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8530 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no --- Comment #1 from Magnus Enger --- Any plans for working on this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 10:11:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 09:11:57 +0000 Subject: [Koha-bugs] [Bug 13204] Plugin housekeeping: Remove labs_theses.pl plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13204 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m --- Comment #8 from Jonathan Druart --- I have just contacted a library who use this plugin (or at least contain the LABTHE VA). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 10:29:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 09:29:37 +0000 Subject: [Koha-bugs] [Bug 13204] Plugin housekeeping: Remove labs_theses.pl plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13204 --- Comment #9 from M. de Rooy --- (In reply to Jonathan Druart from comment #8) > I have just contacted a library who use this plugin (or at least contain the > LABTHE VA). Could you please provide more details on how we can proceed now? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 10:59:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 09:59:44 +0000 Subject: [Koha-bugs] [Bug 13204] Plugin housekeeping: Remove labs_theses.pl plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13204 --- Comment #10 from Jonathan Druart --- As soon as I get an answer from the customer I will let you know :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 13:19:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 12:19:38 +0000 Subject: [Koha-bugs] [Bug 4283] Merge bibliographic records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4283 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34018|0 |1 is obsolete| | --- Comment #3 from Olli-Antti Kivilahti --- Created attachment 34032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34032&action=edit Bug 4283 - Merge bibliographic records Adds a GUI for deduplicating regions of the biblionumber space in Koha. Deduplication happens using the given C4::Matcher. Deduplicated biblionumber slice is limited with LIMIT- and OFFSET-clauses as well as a starting biblionumber by C4::Biblio::GetBiblionumberSlice(). Deduplication search has the following defaults: Limit = 500, Offset = 0, Matcher = the lowest matcher_id in DB. The speed of the deduplication process is mostly influenced by the complexity of the Matcher, but the GUI can handle a limit of ~1000 relatively well with a Matcher using ~7 match points taking a couple of minutes. >From the deduplication GUI, merging is done with the lists-based cataloguing/merge.pl -tool. -!-!-!-!-!-!-!-!-!- -TEST PREPARATION:- -!-!-!-!-!-!-!-!-!- -2. Define/choose a Matcher from the admin/matching-rules.pl. For tutorial purposes use the default ISBN-based Matcher. -1. Add two or more Bibliographic records, each having the same ISBN. Note the biblionumbers. 0. Reindex the search index. -!-!-!-!-!-!- -TEST PLAN:- -!-!-!-!-!-!- 1. Go to cataloguing home (cataloguing/addbooks.pl) and observe a new toolbar item, "Deduplicator"! Go there! 2. In the deduplicator.pl, choose your Matcher and "Deduplicate!". This uses the default values. 2.a. If you don't get any results, enter the smaller biblionumber of the recently added duplicate ISBN Biblios' to the input field. Then retry submission. Use Limit of 2 for convenience. 3. Click the checkbox of a matched result to set it as the "merge target/reference", then click one or more matches to merge with the "merge target/reference", then click the "Merge!"-button on the boldfaced "match source"-row. 4. Merge using the merge.pl-tool as you normally would. As of writing that merge-feature supports only two Biblios, but Buug 8064 will bring support for merging multiple Biblios at once. UNIT TESTS included for the C4::Biblio::GetBiblionumberSlice() -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 13:20:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 12:20:06 +0000 Subject: [Koha-bugs] [Bug 4283] Merge bibliographic records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4283 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 13:55:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 12:55:56 +0000 Subject: [Koha-bugs] [Bug 13353] Package updates for for 3.18 release In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13353 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 14:00:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 13:00:04 +0000 Subject: [Koha-bugs] [Bug 13363] 3.19 master updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13363 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #2 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Robin! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 14:00:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 13:00:37 +0000 Subject: [Koha-bugs] [Bug 13359] provide virtual-mysql-server Depends On to facilitate alternate mysql implementations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13359 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Robin! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 14:02:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 13:02:30 +0000 Subject: [Koha-bugs] [Bug 13214] Improve performance of acqui/addorderiso2709.pl, stop fetching all import_records needlessly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13214 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Olli! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 14:19:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 13:19:28 +0000 Subject: [Koha-bugs] [Bug 13320] Some prices calculation are done in template side In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13320 --- Comment #2 from Jonathan Druart --- Created attachment 34033 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34033&action=edit Bug 13320: Fix "Tax inc." vs "Tax exc." The parcel page always displayes "Tax exc." even when values don't include taxes. Test plan: On the parcel page, verify that the string "Tax *" is correct. This appears in the already received order table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 14:24:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 13:24:19 +0000 Subject: [Koha-bugs] [Bug 13364] New: Add a call number browser in item edition page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Bug ID: 13364 Summary: Add a call number browser in item edition page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: simith.doliveira at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When editing an item, the call number browser search for existing call number. If it shows a line is green between two call numbers, the call numbers searched is available. If the call number is highlighted in red, it means that it already exists. This can be used to avoid repeated call numbers in your collection. The call number browser also shows its position relative to the rest of the collection. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 14:24:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 13:24:27 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |simith.doliveira at inlibro.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 14:26:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 13:26:34 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored --- Comment #1 from simith.doliveira at inlibro.com --- Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 14:29:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 13:29:10 +0000 Subject: [Koha-bugs] [Bug 12567] Catalog Statistitics wizard's publication year doesn't work for MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12567 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #14 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 14:30:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 13:30:28 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30531|0 |1 is obsolete| | Attachment #30532|0 |1 is obsolete| | Attachment #30533|0 |1 is obsolete| | Attachment #30534|0 |1 is obsolete| | Attachment #30535|0 |1 is obsolete| | Attachment #31007|0 |1 is obsolete| | --- Comment #57 from Jonathan Druart --- Created attachment 34034 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34034&action=edit Bug 8007: Discharge - DB changes This patch adds: - syspref useDischarge - the new table discharges - the discharge notice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 14:30:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 13:30:33 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #58 from Jonathan Druart --- Created attachment 34035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34035&action=edit Bug 8007: Discharge - DBIx changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 14:30:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 13:30:38 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #59 from Jonathan Druart --- Created attachment 34036 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34036&action=edit Bug 8007: Discharge - Glue This patch adds: - links to the new pages. - syspref description - links on the main page (intranet) - the DISCHARGE type for debarment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 14:30:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 13:30:43 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #60 from Jonathan Druart --- Created attachment 34037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34037&action=edit Bug 8007: Discharge management This patch is the main patch. It adds new package and files for the new pages (opac-discharge, members/discharge and members/discharges). At the intranet, it is now possible to generate a discharge for a patron. At the opac, a patron can request a discharge and a discharge if it has been validated by a librarian. Requirements: The perl module HTML::HTMLDoc New sysprefs: - useDischarge: Allows librarians to discharge borrowers and borrowers to request a discharge New letter with a letter_code DISCHARGE. Test plan: - Switch on the syspref useDischarge. - Verify a new tab appears in the patron page (intranet and opac). - Verify the discharge cannot be generated if the patron has issues. - Verify the patron can request a discharge from it's opac area. - The request appears on the main page (intranet). - Generate the discharge from the intranet. - Try to download it (from the opac and the intranet). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 14:30:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 13:30:47 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #61 from Jonathan Druart --- Created attachment 34038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34038&action=edit Bug 8007: Discharge - Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 14:30:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 13:30:52 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #62 from Jonathan Druart --- Created attachment 34039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34039&action=edit Bug 8007 : Discharge - Adding Perl dependencie HTML::HTMLDoc is required in order to generate the discharges in PDF format. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 14:33:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 13:33:32 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 14:33:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 13:33:20 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #63 from Jonathan Druart --- Patch rebased against master. This new feature does not need any other patch to be tested. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 14:34:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 13:34:27 +0000 Subject: [Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 14:34:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 13:34:30 +0000 Subject: [Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211 --- Comment #45 from Magnus Enger --- Created attachment 34040 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34040&action=edit Bug 11211 - Followups for calendar.tt - Make sure dates are sorted correctly in the table of unique/single events (This is the same fix that was done on bug 13289.) - Make sure weekdays are sorted correctly in the table of "Events repeating weekly", including taking the CalendarFirstDayOfWeek syspref into account - Some minor changes in the "Hints" text - Replace "Unique event" with "Single event" in the colour coded legend, since that is what is used on the rest of the page - Make headers above tables and tooltips in the main calendar more in line with the language used in the colour coded legend To test: - Apply this patch on top of the other patches on this bug - Add single events that span a month boundary - Check that dates are sorted chronologically in the "Single events" table - Add several weekly events and check that sorting is by the order of days in the week, not alphabetical - Toggle CalendarFirstDayOfWeek and check that the sorting in the "Events repeating weekly" table behaves as it should - Check that the other changes described above makes sense -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 14:40:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 13:40:08 +0000 Subject: [Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211 --- Comment #46 from Magnus Enger --- I have provided a followup in attachment 34040 that should take care of most of the problems I have found. This probably needs a signoff. If this followup meets with approval, I think there is still one question that needs to be addressed: Jonatahan, comment 5: "Could you explain why you changed "holiday" with "event" and you removed "Holiday exception" please?" Me, comment 32: "4. With this patch applied you now get to choose if the library is open or closed when you add an event. As far as I can tell, the special_holidays.isexception field is used to record open/closed. But the description for this field is "is this a holiday exception to a repeatable holiday (1 for yes, 0 for no)". Is open/closed a sensible use/interpretation of this field? I am not sure of the usage, so I am only raising this as a question." To rephrase: Does the repurposing of special_holidays.isexception to store open/closed make sense, and does it mean we loose some functionality connected to making exceptions from repeating holidays? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 14:42:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 13:42:36 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi --- Comment #66 from Olli-Antti Kivilahti --- Sorry, couldn't apply this feature and the reject files didn't make much sense to me. I worked on Bug 4283 and tried to sign this one off as a target of opportunity. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 15:02:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 14:02:36 +0000 Subject: [Koha-bugs] [Bug 13330] All overdue items with fines returned via checkouts table will have fines forgiven! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13330 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #6 from Kyle M Hall --- *** Bug 13312 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 15:02:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 14:02:36 +0000 Subject: [Koha-bugs] [Bug 13312] Fines forgiven automatically: accountlines.accounttype FFOR is set without user input. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13312 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |kyle at bywatersolutions.com Resolution|--- |DUPLICATE --- Comment #3 from Kyle M Hall --- Yes, it's a duplicate. *** This bug has been marked as a duplicate of bug 13330 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 15:19:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 14:19:15 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #2 from simith.doliveira at inlibro.com --- Created attachment 34041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34041&action=edit Add a call number browser in item edition page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 15:19:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 14:19:55 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #3 from simith.doliveira at inlibro.com --- To test?: 1) Go to MARC bibliographic framework Home ? Administration ? MARC frameworks 2) Click in MARC structure (Default framework) 3) Search field 952 and click in subfields 4) Edit subfield o (Full call number) 5) Click Display more constraints 6) In Others Options, Plugin, Choose callnumber.pl and save changes 7) Search a record and edit its items Validate?: three points (?) beside Full call number input 8) Click in ? Validate?: if it can not find the given call number, a green line is shown. Otherwise, the given call number is highlighted in red. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 15:23:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 14:23:22 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #64 from Bernardo Gonzalez Kriegel --- Hi, patch applies and works. One question: From it's documentation, HTML::HTMLDoc does no support UTF8 :) >From http://search.cpan.org/~mfrankl/HTML-HTMLDoc-0.07/lib/HTML/HTMLDoc.pm " set_charset($charset) defines the charset for the output document. The following charsets are currenty supported: cp-874 cp-1250 cp-1251 cp-1252 cp-1253 cp-1254 cp-1255 cp-1256 cp-1257 cp-1258 iso-8859-1 iso-8859-2 iso-8859-3 iso-8859-4 iso-8859-5 iso-8859-6 iso-8859-7 iso-8859-8 iso-8859-9 iso-8859-14 iso-8859-15 koi8-r " Tested editing DISCHARGE letter and adding some diacritics, For ??????? ?? I got ????????????? ??? on PDF We need 11944... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 15:23:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 14:23:55 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Status|NEW |Needs Signoff CC| |eric.begin at inLibro.com, | |marjorie.barry-vila at ccsr.qc | |.ca, | |philippe.blouin at inlibro.com Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 15:36:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 14:36:38 +0000 Subject: [Koha-bugs] [Bug 8687] Improvements in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Comment #36 is|1 |0 private| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 16:49:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 15:49:25 +0000 Subject: [Koha-bugs] [Bug 10051] surname and first name should have comma in overdues report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10051 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at ptfs-europe.com --- Comment #4 from PTFS Europe Sandboxes --- Patch tested with a sandbox, by David Roberts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 16:49:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 15:49:34 +0000 Subject: [Koha-bugs] [Bug 10051] surname and first name should have comma in overdues report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10051 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34021|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 16:49:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 15:49:40 +0000 Subject: [Koha-bugs] [Bug 10051] surname and first name should have comma in overdues report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10051 --- Comment #5 from PTFS Europe Sandboxes --- Created attachment 34042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34042&action=edit Bug 10051: Separate first name and surname with comma in overdues report The name of the patron who has overdues is displayed as "surname first name" instead of "surname, first name". To test: - Go to circulation > overdues - Verify that first name and surname are not separated by comma - Apply patch - Verify the display is improved with a comma - Delete the first name from one of the patrons - Verify display is still ok Signed-off-by: David Roberts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 17:04:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 16:04:59 +0000 Subject: [Koha-bugs] [Bug 10051] surname and first name should have comma in overdues report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10051 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34042|0 |1 is obsolete| | --- Comment #6 from Christopher Brannon --- Created attachment 34043 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34043&action=edit [SIGNED OFF] Bug 10051: Separate first name and surname with comma in overdues report The name of the patron who has overdues is displayed as "surname first name" instead of "surname, first name". To test: - Go to circulation > overdues - Verify that first name and surname are not separated by comma - Apply patch - Verify the display is improved with a comma - Delete the first name from one of the patrons - Verify display is still ok Signed-off-by: David Roberts Signed-off-by: Christopher Brannon Current status: Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 17:08:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 16:08:25 +0000 Subject: [Koha-bugs] [Bug 13336] Add time to date column for patron circulation history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13336 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at ptfs-europe.com --- Comment #2 from PTFS Europe Sandboxes --- Patch tested with a sandbox, by David Roberts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 17:08:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 16:08:35 +0000 Subject: [Koha-bugs] [Bug 13336] Add time to date column for patron circulation history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13336 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33923|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 17:08:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 16:08:42 +0000 Subject: [Koha-bugs] [Bug 13336] Add time to date column for patron circulation history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13336 --- Comment #3 from PTFS Europe Sandboxes --- Created attachment 34044 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34044&action=edit Bug 13336 - Add time to date column for patron circulation history Some librarians have expressed that it would be very helpful to have the hours displayed in the date column for a patron's circulation history. The time an action took place can be vital to tracking down which librarians were working at the time a given circulation action took place. Test Plan: 1) View a patron's circulation history 2) Note the Date column has no hour/minute 3) Apply this patch 4) Reload the page 5) Note the hour and minutes now display Signed-off-by: David Roberts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 17:11:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 16:11:22 +0000 Subject: [Koha-bugs] [Bug 13336] Add time to date column for patron circulation history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13336 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.roberts at ptfs-europe.c | |om --- Comment #4 from David Roberts --- I've signed this off because it works as is but I do wonder whether it may be more use having the time in the "checked out on" or "return date" column. In fact, do we really need to have a date column in addition to these two columns? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 17:21:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 16:21:57 +0000 Subject: [Koha-bugs] [Bug 13017] Login page image replacement technique fails when browser width exceeds 2000 pixels In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13017 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #3 from Christopher Brannon --- (In reply to Owen Leonard from comment #2) > Note: This patch has not been tested in any Internet Explorer version! Works in IE 11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 17:23:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 16:23:55 +0000 Subject: [Koha-bugs] [Bug 13017] Login page image replacement technique fails when browser width exceeds 2000 pixels In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13017 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 17:23:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 16:23:57 +0000 Subject: [Koha-bugs] [Bug 13017] Login page image replacement technique fails when browser width exceeds 2000 pixels In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13017 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33462|0 |1 is obsolete| | --- Comment #4 from Christopher Brannon --- Created attachment 34045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34045&action=edit [SIGNED OFF] Bug 13017 - Login page image replacement technique fails when browser width exceeds 2000 pixels This patch updates the image replacement technique used for Koha's login page. The old technique used a negative text-indent value to move the text offscreen, but that begins to fail more and more often as screens get larger. The new technqiue is described here: http://www.zeldman.com/2012/03/01/replacing-the-9999px-hack-new-image-replacement/ Note: This patch has not been tested in any Internet Explorer version! To test you must have a screen which is wider than 2000 pixels. Apply the patch, clear your browser cache and view the staff client login page. The logo on the login form should look correct with no corresponding text appearing anywhere on the screen. Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 17:46:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 16:46:52 +0000 Subject: [Koha-bugs] [Bug 12084] Published date for serial items not formatted according to dateformat system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12084 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paola.rossi at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 17:50:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 16:50:20 +0000 Subject: [Koha-bugs] [Bug 12084] Published date for serial items not formatted according to dateformat system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12084 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34029|0 |1 is obsolete| | --- Comment #2 from Paola Rossi --- Created attachment 34046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34046&action=edit Bug 12084: Format planned date in publication details on detail page Everything is OK imo. So I pass the patch to the "Sign Off" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 17:56:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 16:56:12 +0000 Subject: [Koha-bugs] [Bug 13365] New: Koha layout is completely off in Internet Explorer Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13365 Bug ID: 13365 Summary: Koha layout is completely off in Internet Explorer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Browser compatibility Assignee: oleonard at myacpl.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org Created attachment 34047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34047&action=edit Main Staff Screen in IE11 Koha staff screens are complete off in Internet Explorer. We are using IE11. This is not happening with 3.16, so I believe this is something new. It looks as if some or none of the CSS is being applied. Looks fine in FireFox and Chrome. See attachments for examples. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 17:57:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 16:57:34 +0000 Subject: [Koha-bugs] [Bug 13365] Koha layout is completely off in Internet Explorer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13365 --- Comment #1 from Christopher Brannon --- Created attachment 34048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34048&action=edit Tools Screen in IE11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 18:01:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 17:01:14 +0000 Subject: [Koha-bugs] [Bug 13365] Koha layout is completely off in Internet Explorer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13365 --- Comment #2 from Christopher Brannon --- I'm suspecting CSS, as fonts are larger and colors are off, such as on the top menu. You'll see colors are different AND the fonts are different. See 3rd attachment for comparison. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 18:01:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 17:01:50 +0000 Subject: [Koha-bugs] [Bug 13365] Koha layout is completely off in Internet Explorer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13365 --- Comment #3 from Christopher Brannon --- Created attachment 34049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34049&action=edit Top menu in FireFox for comparison. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 18:14:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 17:14:35 +0000 Subject: [Koha-bugs] [Bug 13307] Create a link to the last advanced search in search result page (OPAC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |cbrannon at cdalibrary.org --- Comment #6 from Christopher Brannon --- After clicking "Return to the last advanced search" link, the top portion of the advanced search page, with all search boxes, disappears. Can't edit the original search terms! I will include a screen shot. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 18:15:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 17:15:43 +0000 Subject: [Koha-bugs] [Bug 13307] Create a link to the last advanced search in search result page (OPAC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 --- Comment #7 from Christopher Brannon --- Created attachment 34050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34050&action=edit Search boxes disappear when returning to advanced search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 18:59:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 17:59:52 +0000 Subject: [Koha-bugs] [Bug 13290] Add better feedback for returns to the checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13290 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |cbrannon at cdalibrary.org --- Comment #6 from Christopher Brannon --- While this patch applies the highlighting to all items returned at the same time, it only changes the due date in the due date column on the last item in the list. The due date of all other items returned at the same time are left as due dates. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 20:08:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 19:08:27 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #65 from Bernardo Gonzalez Kriegel --- Would it be possible to use PDF::fromHTML? (http://search.cpan.org/~autrijus/PDF-FromHTML-0.12/lib/PDF/FromHTML.pm) With that we can set correct encoding and font, for example DejaVuSans, and have a decent international support -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 20:21:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 19:21:18 +0000 Subject: [Koha-bugs] [Bug 13359] provide virtual-mysql-server Depends On to facilitate alternate mysql implementations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13359 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.01 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 20:23:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 19:23:32 +0000 Subject: [Koha-bugs] [Bug 12567] Catalog Statistitics wizard's publication year doesn't work for MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12567 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #15 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 20:36:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 19:36:28 +0000 Subject: [Koha-bugs] [Bug 13366] New: Required fields not indicated on patron form Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13366 Bug ID: 13366 Summary: Required fields not indicated on patron form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com I'm noticing that if you make any of the patron_attr_# fields required in the patron form (memberentry.pl), they don't show as required unless you interact with the field. The label should be red, as other required fields are, and include the label added in http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11812. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 1 21:11:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Dec 2014 20:11:53 +0000 Subject: [Koha-bugs] [Bug 3642] Modify Overdue.pl export to include other borrower information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 02:15:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 01:15:52 +0000 Subject: [Koha-bugs] [Bug 13368] New: Checking out an item not on loan, but with a hold, busts the holds priority Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13368 Bug ID: 13368 Summary: Checking out an item not on loan, but with a hold, busts the holds priority Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: chris at bigballofwax.co.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If you place 3 holds on an item that is not on loan. Then check that item out to the person who is second in the queue, the holds are not reordered. They will be 1 and 3. This is because ModReserveFill deletes the hold from the reserves table, after putting it in the oldreserves table. It then passes the reserve id to _FixPriority. _FixPriority then queries the reserves table, and suprise suprise can't find the hold, and nothing is reordered. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 02:18:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 01:18:57 +0000 Subject: [Koha-bugs] [Bug 13368] Checking out an item not on loan, but with a hold, busts the holds priority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13368 --- Comment #1 from Chris Cormack --- Created attachment 34051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34051&action=edit Bug 13368 Holds priority messed up on checkout To Test 1/ Create 3 (or more holds) on one biblionumber, make sure at least one item is not on loan 2/ Check out the not on loan item to a borrower (maybe number 2 in the queue) 3/ Look in the database (or on the holds tab on the moredetail.pl) notice the priorities have not been reordered 4/ Apply patch and try again, notice now they have -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 02:18:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 01:18:55 +0000 Subject: [Koha-bugs] [Bug 13368] Checking out an item not on loan, but with a hold, busts the holds priority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13368 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 10:47:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 09:47:08 +0000 Subject: [Koha-bugs] [Bug 13369] New: [Datatables] tr and td are not correctly highlighted Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13369 Bug ID: 13369 Summary: [Datatables] tr and td are not correctly highlighted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org On the fund list, the color line highlighting is not done correctly, see the screenshot. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 10:47:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 09:47:18 +0000 Subject: [Koha-bugs] [Bug 13369] [Datatables] tr and td are not correctly highlighted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13369 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard at myacpl.org |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 10:50:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 09:50:32 +0000 Subject: [Koha-bugs] [Bug 13369] [Datatables] tr and td are not correctly highlighted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13369 --- Comment #1 from Jonathan Druart --- Created attachment 34052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34052&action=edit without the patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 10:50:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 09:50:56 +0000 Subject: [Koha-bugs] [Bug 13369] [Datatables] tr and td are not correctly highlighted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13369 --- Comment #2 from Jonathan Druart --- Created attachment 34053 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34053&action=edit with the patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 10:53:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 09:53:30 +0000 Subject: [Koha-bugs] [Bug 13369] [Datatables] tr and td are not correctly highlighted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13369 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 10:53:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 09:53:32 +0000 Subject: [Koha-bugs] [Bug 13369] [Datatables] tr and td are not correctly highlighted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13369 --- Comment #3 from Jonathan Druart --- Created attachment 34054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34054&action=edit Bug 13369: table should been highlighted correctly when row are grouped The css used to highlight the rows comes from staff-global.css We need a more specific rule to be used. Test plan: Go on the fund list view and confirm that the rows are correctly highlighted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 11:07:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 10:07:38 +0000 Subject: [Koha-bugs] [Bug 12565] Acq: Link to basket in breadcrumbs broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12565 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paola.rossi at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 11:08:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 10:08:58 +0000 Subject: [Koha-bugs] [Bug 12565] Acq: Link to basket in breadcrumbs broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12565 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34027|0 |1 is obsolete| | --- Comment #3 from Paola Rossi --- Created attachment 34055 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34055&action=edit Bug 12565: Acq: Fix broken link in breadcrumbs I've applied the patch. Everything is OK as required. I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 11:27:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 10:27:46 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #19 from Katrin Fischer --- Hi there, trying to see what the situation here is - are the QA tools still failing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 11:28:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 10:28:24 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 --- Comment #20 from Katrin Fischer --- ... to explain, can't test right now as I am away from my dev environment. Maybe someone can clarify before I can. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 11:36:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 10:36:27 +0000 Subject: [Koha-bugs] [Bug 13370] New: Inputs overflow in filters Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13370 Bug ID: 13370 Summary: Inputs overflow in filters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 11:36:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 10:36:36 +0000 Subject: [Koha-bugs] [Bug 13370] Inputs overflow in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13370 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard at myacpl.org |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 11:36:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 10:36:50 +0000 Subject: [Koha-bugs] [Bug 13370] Inputs overflow in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13370 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12376 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 11:36:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 10:36:50 +0000 Subject: [Koha-bugs] [Bug 12376] blinking cursor not clear in larger resolutions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12376 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13370 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 11:38:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 10:38:38 +0000 Subject: [Koha-bugs] [Bug 13370] Inputs overflow in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13370 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 11:38:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 10:38:40 +0000 Subject: [Koha-bugs] [Bug 13370] Inputs overflow in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13370 --- Comment #1 from Jonathan Druart --- Created attachment 34056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34056&action=edit Bug 13370: Inputs overflow in filter Bug 12376 adds some padding to inputs. This cause an overflow on the record detail page. Test plan: 1/ Go on a record detail page with items 2/ Enable filters Without the patch, the inputs overflow, with the patch it should be corrected (as before bug 12376). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 11:38:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 10:38:55 +0000 Subject: [Koha-bugs] [Bug 13370] Inputs overflow in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13370 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 11:39:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 10:39:10 +0000 Subject: [Koha-bugs] [Bug 13369] [Datatables] tr and td are not correctly highlighted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13369 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 12:05:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 11:05:55 +0000 Subject: [Koha-bugs] [Bug 13371] New: Add filters to the supplier list view Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Bug ID: 13371 Summary: Add filters to the supplier list view Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org The supplier list view does not permit to filter on opened/closed baskets, creator name, basketgroup name or dates. That can be added easily using the DataTables filters. This new enhancement will allow a librarian to filter the supplier/basket list view. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 12:06:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 11:06:21 +0000 Subject: [Koha-bugs] [Bug 13369] [Datatables] tr and td are not correctly highlighted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13369 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13371 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 12:06:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 11:06:21 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |13369, 13370 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 12:06:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 11:06:21 +0000 Subject: [Koha-bugs] [Bug 13370] Inputs overflow in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13370 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13371 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 12:10:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 11:10:36 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 12:10:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 11:10:40 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #1 from Jonathan Druart --- Created attachment 34057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34057&action=edit Bug 13371: Add filters on the supplier list view This patch adds the ability to filter the basket list depending on its creator name, basketgroup name, dates (creation, close), etc. Test plan: Go on the supplier list view (acqui/booksellers.pl) and confirm that the view is more ergonomic and the filters permit to the librarians to find a basket more easily than before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 12:10:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 11:10:44 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #2 from Jonathan Druart --- Created attachment 34058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34058&action=edit Bug 13371: Reintroduce the action buttons Confirm the the "New basket" and "Receive shipment" buttons work as before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 12:12:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 11:12:03 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |paola.rossi at cineca.it --- Comment #4 from Paola Rossi --- I've applied the patch. Everything is OK until the 7-th step [included]. At 8) step, nothing happened. When my mouse is over the three points, I saw "Tag editor". I was on editing an already existent Y item for the X biblio: koha/cataloguing/additem.pl?op=edititem&biblionumber=X&itemnumber=Y#edititem&searchid=scs_1417518371030 So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 12:14:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 11:14:38 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #3 from Jonathan Druart --- Note that this enhancement can be tested without patches from bug 13369 and bug 13370. They are only 2 small ergonomic improvements. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 12:17:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 11:17:04 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 --- Comment #21 from Fr?d?ric Demians --- (In reply to Katrin Fischer from comment #20) > ... to explain, can't test right now as I am away from my dev environment. > Maybe someone can clarify before I can. I can see QA errors. I will fix them and resubmit the patch with the status "Signed-off'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 12:37:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 11:37:31 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #4 from Jonathan Druart --- Created attachment 34059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34059&action=edit Bug 13371: Add a filter for opened baskets This patch adds a new link to filter on opened baskets only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 12:40:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 11:40:32 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 12:40:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 11:40:35 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 --- Comment #22 from Fr?d?ric Demians --- Created attachment 34060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34060&action=edit Bug 11190 sitemap.pl -- Generate a Catalog sitemap Add a script sitemap.pl to process all biblio records from a Koha instance and generate Sitemap files complying with this protocol as described on http://sitemaps.org. The goal of this script is to be able to provide to search engines direct access to biblio records. It avoid leaving search engine browsing Koha OPAC and so generating a lot of traffic, and workload, for a bad result. Thanks Magnus for testing, and helping to improve the script design. Signed-off-by: Magnus Enger All options to the script work as expected and the output looks good. Nice enhancement! Signed-off-by: Frederic Demians I signed-of my own patch after fixing various QA errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 12:41:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 11:41:05 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23980|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 12:41:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 11:41:21 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26153|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 13:12:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 12:12:15 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34060|0 |1 is obsolete| | --- Comment #23 from Fr?d?ric Demians --- Created attachment 34061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34061&action=edit Bug 11190 sitemap.pl -- Generate a Catalog sitemap Add a script sitemap.pl to process all biblio records from a Koha instance and generate Sitemap files complying with this protocol as described on http://sitemaps.org. The goal of this script is to be able to provide to search engines direct access to biblio records. It avoid leaving search engine browsing Koha OPAC and so generating a lot of traffic, and workload, for a bad result. Thanks Magnus for testing, and helping to improve the script design. Signed-off-by: Magnus Enger All options to the script work as expected and the output looks good. Nice enhancement! Signed-off-by: Frederic Demians I signed-of my own patch after fixing various QA errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 13:33:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 12:33:11 +0000 Subject: [Koha-bugs] [Bug 13372] New: Items lost report improvements Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13372 Bug ID: 13372 Summary: Items lost report improvements Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org Add a new column to display the call number on the items lost report. On the way, DataTables and ColVis will be added on the table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 13:33:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 12:33:31 +0000 Subject: [Koha-bugs] [Bug 13372] Items lost report improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13372 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 13:36:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 12:36:28 +0000 Subject: [Koha-bugs] [Bug 13372] Items lost report improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13372 --- Comment #1 from Jonathan Druart --- Created attachment 34062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34062&action=edit Bug 13372: Items lost report improvements This enhancement adds new column to display the call number on the items lost report. On the way, DataTables and ColVis are added on the table. Test plan: 1/ Go on the items lost report (reports/itemslost.pl) and verify that the call number column is correctly filled. 2/ On the way, verify that the 'Library' and 'Current location' now contain the name instead of the code. 3/ Go on the columns configuration in the admin module (admin/columns_settings.pl), play with the ColVis plugin and confirm that all works correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 13:36:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 12:36:25 +0000 Subject: [Koha-bugs] [Bug 13372] Items lost report improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13372 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 14:12:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 13:12:04 +0000 Subject: [Koha-bugs] [Bug 13373] New: Update Polish web installer sample data files Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 Bug ID: 13373 Summary: Update Polish web installer sample data files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: rkopaczka at afm.edu.pl Reporter: rkopaczka at afm.edu.pl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com There's polish web installer files, but it seems that they are very outdated, and this may cause problems after install. I'll try to update it, and translate some of it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 14:48:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 13:48:57 +0000 Subject: [Koha-bugs] [Bug 13369] [Datatables] tr and td are not correctly highlighted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13369 --- Comment #4 from Owen Leonard --- Created attachment 34063 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34063&action=edit [SIGNED-OFF] Bug 13369: table should been highlighted correctly when row are grouped The css used to highlight the rows comes from staff-global.css We need a more specific rule to be used. Test plan: Go on the fund list view and confirm that the rows are correctly highlighted. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 14:49:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 13:49:18 +0000 Subject: [Koha-bugs] [Bug 13369] [Datatables] tr and td are not correctly highlighted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13369 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34054|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 14:49:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 13:49:25 +0000 Subject: [Koha-bugs] [Bug 13369] [Datatables] tr and td are not correctly highlighted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13369 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 15:02:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 14:02:22 +0000 Subject: [Koha-bugs] [Bug 13370] Inputs overflow in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13370 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Owen Leonard --- This doesn't apply, but I'm not sure why. The patch refers to this supposedly existing line: span.filter_column > input.date_range_filter { ..which in master is span.filter_column > input.text_filter { I can't tell if this is intended to be dependent on another patch or if the difference is unintentional. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 15:28:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 14:28:31 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 --- Comment #1 from Rafal Kopaczka --- Created attachment 34065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34065&action=edit Bug 13373 - Update Polish web installer sample data files. Part 1/2 - mandatory files. Changes: - Translated user permission and user flags. - Changed untranslated different files from en version - Deleted unnecessary files To test: - Aplly patch - Run webinstaller on empty database (drop database if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 15:28:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 14:28:30 +0000 Subject: [Koha-bugs] [Bug 13368] Checking out an item not on loan, but with a hold, busts the holds priority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13368 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34051|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 34064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34064&action=edit [SIGNED-OFF] Bug 13368 Holds priority messed up on checkout To Test 1/ Create 3 (or more holds) on one biblionumber, make sure at least one item is not on loan 2/ Check out the not on loan item to a borrower (maybe number 2 in the queue) 3/ Look in the database (or on the holds tab on the moredetail.pl) notice the priorities have not been reordered 4/ Apply patch and try again, notice now they have Signed-off-by: Owen Leonard Confirmed the problem without the patch, and confirmed that the patch corrects it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 15:28:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 14:28:28 +0000 Subject: [Koha-bugs] [Bug 13368] Checking out an item not on loan, but with a hold, busts the holds priority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13368 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 15:28:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 14:28:50 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 Rafal Kopaczka changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34065|0 |1 is obsolete| | --- Comment #2 from Rafal Kopaczka --- Created attachment 34066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34066&action=edit Bug 13373 - Update Polish web installer sample data files. Part 2/2 - optional files. Changes: - Deleted unnecessary files - Translated description files and some values in sql files To test: - Aplly patch - Run webinstaller on empty database (drop database and create new if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 15:28:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 14:28:48 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 Rafal Kopaczka changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 15:29:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 14:29:19 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 Rafal Kopaczka changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34065|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 15:30:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 14:30:50 +0000 Subject: [Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |MOVED --- Comment #41 from Paola Rossi --- I pass this bug to a "Resolved - Moved" status because this solution is a dead end. See bug 11909. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 15:32:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 14:32:18 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 --- Comment #3 from Rafal Kopaczka --- I'm not sure if splitting this patch is necessary, but squashing should be easy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 15:37:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 14:37:59 +0000 Subject: [Koha-bugs] [Bug 13370] Inputs overflow in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13370 --- Comment #3 from Jonathan Druart --- Looks good here... Bug 13370 - Inputs overflow in filters 34056 - Bug 13370: Inputs overflow in filter Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 13370: Inputs overflow in filter Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/css/datatables.css Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/css/datatables.css -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 15:38:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 14:38:12 +0000 Subject: [Koha-bugs] [Bug 13370] Inputs overflow in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13370 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34056|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 34067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34067&action=edit Bug 13370: Inputs overflow in filter Bug 12376 adds some padding to inputs. This cause an overflow on the record detail page. Test plan: 1/ Go on a record detail page with items 2/ Enable filters Without the patch, the inputs overflow, with the patch it should be corrected (as before bug 12376). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 15:39:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 14:39:37 +0000 Subject: [Koha-bugs] [Bug 13370] Inputs overflow in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13370 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #5 from Jonathan Druart --- Ok, should be better now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 15:42:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 14:42:23 +0000 Subject: [Koha-bugs] [Bug 13370] Inputs overflow in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13370 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34067|0 |1 is obsolete| | --- Comment #6 from Owen Leonard --- Created attachment 34068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34068&action=edit [SIGNED-OFF] Bug 13370: Inputs overflow in filter Bug 12376 adds some padding to inputs. This cause an overflow on the record detail page. Test plan: 1/ Go on a record detail page with items 2/ Enable filters Without the patch, the inputs overflow, with the patch it should be corrected (as before bug 12376). Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 15:42:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 14:42:21 +0000 Subject: [Koha-bugs] [Bug 13370] Inputs overflow in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13370 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 15:45:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 14:45:05 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12042=5D__Change_text_=E2=80=98Add_t?= =?utf-8?b?byBiYXNrZXTigJkgaW50byDigJhBZGQgb3JkZXIgdG8gYmFza2V04oCZ?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12042 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED CC| |paola.rossi at cineca.it Resolution|--- |WONTFIX --- Comment #6 from Paola Rossi --- There was no discussion about this topic after comment 5, so I pass this bug to "Resolved - Wontfix" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 15:52:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 14:52:31 +0000 Subject: [Koha-bugs] [Bug 13356] AN UNRESOLVABLE PROBLEM OCCURED WHILE INTIALISING THE PACKAGE INFORMATION In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13356 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Owen Leonard --- This sounds like a support request rather than a bug report. Please consult your options for getting Koha support: http://koha-community.org/support/ ...particularly the Koha mailing list. Keep in mind that any requests for help should include the version of Koha you are using, your method of installation, and detailed description of what led to the error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 15:54:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 14:54:11 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12054=5D__It=E2=80=99s_possible_to_m?= =?utf-8?q?ake_order_from_an_inactive_vendor?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12054 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paola.rossi at cineca.it --- Comment #1 from Paola Rossi --- This bug is still present in master 3.19. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 16:01:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 15:01:22 +0000 Subject: [Koha-bugs] [Bug 7422] Prevent creation of vendors with the same name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED CC| |paola.rossi at cineca.it Resolution|--- |WONTFIX --- Comment #15 from Paola Rossi --- There was no discussion about the topic after comment 14. So I pass this bug from "In discussion" to "Resolved - Wontfix" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 16:07:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 15:07:46 +0000 Subject: [Koha-bugs] [Bug 11438] Add creation date and closing date to basketgroups In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11438 --- Comment #9 from Paola Rossi --- (In reply to mathieu saby from comment #8) > Hello Paola > Thank you for testing > As bug 11708 has been signed (but in failed QA), I prefer not to rewrite > this one for the moment, as they are doing mostly the same thing. > For the moment, I will comment bug 11708 to stress the common points and > differences between the 2 patches, and let this one in "does not apply". > > Mathieu Kind Mathieu, we'd agree with you and pass this bug from "Patch doesn't apply" status to the "Resoved - Moved" one towards bug 11708, which is in the "Signed Off" status today. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 16:08:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 15:08:57 +0000 Subject: [Koha-bugs] [Bug 11438] Add creation date and closing date to basketgroups In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11438 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |MOVED --- Comment #10 from Paola Rossi --- We pass this bug to "Resolved- Moved" status. See bug 11708. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 16:19:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 15:19:51 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 --- Comment #59 from Paola Rossi --- (In reply to mathieu saby from comment #58) > Bug 7162 (passed QA) will have consequencies for this one, as it is > refactoring DelOrder. I will have to make some adjusments. So do not test > before 7162 is passed, it will be a waste of time... > I change the status to "in discussion". > > Matheiu Hi Mathieu, bug 7162 has been pushed to master. What about this bug now? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 16:21:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 15:21:15 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 --- Comment #79 from Paola Rossi --- (In reply to mathieu saby from comment #78) > In fact bug 12853 has nothing to do with this one, BUT bug 7162 (passed QA) > will have aftereffects, as it rewrites DelOrder. > So, I'll take a look again when bug 7162 is pushed > > M. Saby Hi Mathieu, the bug 7162 has been pushed to master. What about this bug now? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 16:51:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 15:51:35 +0000 Subject: [Koha-bugs] [Bug 13374] New: AllowHoldsOnPatronsPossessions not working Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13374 Bug ID: 13374 Summary: AllowHoldsOnPatronsPossessions not working Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: jdeca at smfpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com We are trying to used AllowHoldsOnPatronsPossessions preference set to "Don't Allow" and it works only some times. opac-reserve.pl calls CheckIfIssuedToPatron($borrowernumber, $biblionumber) in Circulation.pm that calls GetItemsByBiblioitemnumber($biblionumber) in Items.pm that is using a query "SELECT * FROM items WHERE items.biblioitemnumber = ?" The problem is the query is searching for biblioitemnumber but we are passing biblionumber. I don't know if this is not a problem for other libraries but most of our biblioitemnumber DO NOT EQUAL biblionumber. It seems that we should not be using biblioitemnumbers for anything. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 17:01:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 16:01:26 +0000 Subject: [Koha-bugs] [Bug 13374] AllowHoldsOnPatronsPossessions not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13374 --- Comment #1 from Jorge de Cardenas --- I only found 4 places using GetItemsByBiblioitemnumber() C4/Items.pm - function defined C4/Circulations.pm - called using biblionumber C4/ILSDI/Services.pm - called using biblioitemnumber intranet/cgi-bin/cataloguing/additem.pl - called using biblioitemnumber I propose: 1) renaming function to GetItemsByBiblionumber 2) changing all call to use biblionumber -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 17:03:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 16:03:46 +0000 Subject: [Koha-bugs] [Bug 13349] Allow library code to display against users pending changes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13349 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #2 from Christopher Brannon --- Traceback (most recent call last): File "/usr/local/bin/git-bz", line 2630, in do_apply(*args) File "/usr/local/bin/git-bz", line 1755, in do_apply users = bug.server.get_xmlrpc_proxy().User.get({ 'names': [patch.attacher] })['users'] File "/usr/lib/python2.6/xmlrpclib.py", line 1199, in __call__ return self.__send(self.__name, args) File "/usr/lib/python2.6/xmlrpclib.py", line 1489, in __request verbose=self.__verbose File "/usr/lib/python2.6/xmlrpclib.py", line 1243, in request headers xmlrpclib.ProtocolError: Not sure if this is a problem on my end or what. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 17:21:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 16:21:11 +0000 Subject: [Koha-bugs] [Bug 13333] Basket group is not displayed for already received orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13333 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paola.rossi at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 17:22:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 16:22:25 +0000 Subject: [Koha-bugs] [Bug 13365] Koha layout is completely off in Internet Explorer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13365 --- Comment #4 from Owen Leonard --- I do not see this problem in Internet Explorer 11 on Windows 7. From the screenshots it looks as if some CSS is not being loaded. I recommend checking your CSS-related system preferences for errors and verifying IE is loading all the right CSS files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 17:23:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 16:23:57 +0000 Subject: [Koha-bugs] [Bug 13333] Basket group is not displayed for already received orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13333 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33894|0 |1 is obsolete| | --- Comment #3 from Paola Rossi --- Created attachment 34069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34069&action=edit Bug 13333: Fix Display basket group for already received orders I've applied the patch. Everything is OK on parcel.pl, as required. So I pass the patch to "Signed Off" status. NB. For an already received order, the basket group is generally closed [it can be reopened after]. The current link now available from the BG's name is: ./koha/acqui/basketgroup.pl?booksellerid=10 which shows the list of the vendor's BGs, whose default tag is the "Open" BGs. On the contrary, if the link now available from the BG's name would be set to: ./koha/acqui/basketgroup.pl?op=add&booksellerid=10&basketgroupid=5 ./koha/acqui/basketgroup.pl?op=add&booksellerid=10&basketgroupid=5 the user could look at the BG at once, closed or open. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 17:52:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 16:52:02 +0000 Subject: [Koha-bugs] [Bug 13365] Koha layout is completely off in Internet Explorer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13365 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #5 from Christopher Brannon --- Issue disappeared after further testing. Not sure why this was happening, but seems to be resolved for the time being. I will reopen this bug if it returns and persists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 18:40:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 17:40:30 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32841|0 |1 is obsolete| | --- Comment #50 from Paul Poulain --- Created attachment 34070 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34070&action=edit Bug 13068: Follow-up for cleaning up atomicupdate folder The folder atomicupdate can be cleaned up. It mainly contains old files that are not used any more. I found two files that are still referenced: [1] Bug-4246-Talking-Tech-itiva-phone-notifications.pl A readme file refers to it. The code in this file slightly differs from the TalkingTech db revision. It can probably be deleted too, but I will first check. [2] oai_sets.sql This file should remain. It is used in dbrev 3.07.00.029. Signed-off-by: Marcel de Rooy Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 18:40:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 17:40:39 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32842|0 |1 is obsolete| | --- Comment #51 from Paul Poulain --- Created attachment 34071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34071&action=edit Bug 13068: Counterpatch using atomicupdate directory This patch makes a distinction between atomicupdates belonging to an official db revision and development updates. It also keeps track of the dev updates since the last official db rev. (This is done via a local pref; so easily accessible if needed.) The db revs can be txt files, perl scripts or sql files. Sql files are run via the installer. A new db revision is now only a matter of dropping a file in atomicupdates for the developer. The RM only adds one line to updatedatabase like: ExecDBRev( $aupd, '13068', 'Refined dbrev', '13068.pl', '3.17.00.028'); This line should follow the last dbrev and preceed the call to RunRemainingAtomicUpdates. Test plan: [1] Add a few lines calling ExecDBRev to updatedatabase with corresponding files in atomicupdate like (insert the correct version!!): ExecDBRev( $aupd, '13068', 'My test', '13068.pl', '3.17.00.028'); Do not forget to update kohaversion.pl accordingly. Add some other files in atomicupdate as dev updates. [2] Run updatestructure and check if all db revs and dev updates are run. Run updatestructure again. Nothing should be run now. Clear/delete the _LocalAtomicUpdates pref. Run updatestructure again. Only dev updates should be run. Reset the database version. You could edit Version in local preferences. Run updatestructure and check if all db revs and dev updates are run. Edit _LocalAtomicUpdates and remove one filename. Run updatestructure again. Only one dev update should be run. Signed-off-by: Marcel de Rooy Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 18:40:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 17:40:48 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33859|0 |1 is obsolete| | --- Comment #52 from Paul Poulain --- Created attachment 34072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34072&action=edit Bug 13068: Counterpatch follow-up for controlling workflow The workflow for dev updates can be altered with devupdatecontrol: [1] devupdatecontrol= PROD for production machines: Do not execute RunRemainingDevUpdates, so only official db revs. This is the default. [2] devupdatecontrol= RESET: Reinstall dev updates after an official db rev. [3] devupdatecontrol= ALWAYS: Run the dev updates at each upgrade. [4] devupdatecontrol=TRACK: Only install new dev updates. It does not reset the local pref listing all recently applied dev updates. ONLY use this if you know what you are doing! Note: devupdatecontrol is a configuration variable from koha-conf.xml. If it does not exist or is empty, we fall back to PROD (safest). If it differs from PROD, ALWAYS or TRACK, it falls back to RESET. Note2: Initially, devupdatecontrol was a preference. It has been moved to koha-conf.xml as requested by several developers (Nov 24). Test plan: [1] Add a few lines calling ExecDBRev to updatedatabase with corresponding files in atomicupdate like (insert the correct version!!): ExecDBRev( $aupd, '13068', 'My test', '13068.pl', '3.17.00.028'); Do not forget to update kohaversion.pl accordingly. Add some other files in atomicupdate as dev updates. [2] Repeat for the various modes of devupdatecontrol (see above): Reset the database version. You could edit Version in local preferences. Optionally clear/delete the _LocalAtomicUpdates pref. Run updatestructure and check which db revs and dev updates are run or skipped. Run it again and check which dev updates are run or skipped. Signed-off-by: Marcel de Rooy Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 18:41:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 17:41:30 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #53 from Paul Poulain --- made many tests using TRACK mode, as well as PROD mode, and could not find any problem. signed-off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 19:13:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 18:13:20 +0000 Subject: [Koha-bugs] [Bug 13235] Revise layout of patron search form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33502|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 34073 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34073&action=edit Bug 13235 - Revise layout of patron search form Bug 9811 (Patron search improvements) reversed the layout changes made by Bug 10153. This patch returns to the form to its "stacked" layout. To test, apply the patch and navigate to the Patrons home page. Expand the hidden search fields in the search header and confirm that the layout looks correct. Perform some searches and check that the results are correct and that the modified search fields retain their state. Note: This patch contains indentation changes, so please diff accordingly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 19:13:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 18:13:17 +0000 Subject: [Koha-bugs] [Bug 13235] Revise layout of patron search form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 20:51:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 19:51:56 +0000 Subject: [Koha-bugs] [Bug 13349] Allow library code to display against users pending changes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13349 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply Version|3.16 |master --- Comment #3 from Owen Leonard --- I get the same problem. It looks like the patch isn't formatted correctly? Please resubmit the patch, and while you're at it, add a description of the bug and a test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 23:44:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 22:44:45 +0000 Subject: [Koha-bugs] [Bug 13349] Allow library code to display against users pending changes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13349 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33958|0 |1 is obsolete| | --- Comment #4 from David Roberts --- Created attachment 34074 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34074&action=edit Version 2 of the patch Sorry, I don't know why the patch wouldn't apply - I've tried to regenerate it so hopefully it will work OK this time. To test: 1) Ensure OPACPatronDetails is set to enabled 2) Log into the OPAC and update your patron details (address, phone number etc) 3) Log into the staff client and view pending patron changes. The branchcode of the library to which the patron belongs will not display. 4) Apply the patch 5) Log into the staff client again and view pending patron changes. The branchcode of the library to which the patron belongs should now display next to the user's name. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 23:45:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 22:45:01 +0000 Subject: [Koha-bugs] [Bug 13349] Allow library code to display against users pending changes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13349 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 23:45:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 22:45:19 +0000 Subject: [Koha-bugs] [Bug 10891] Make facets customisable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10891 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #30 from Tom?s Cohen Arazi --- (In reply to mathieu saby from comment #29) > Hi > I stopped working on that when bug 11232 was created, because I feared a big > conflict. But nothing is still to test on that bug :( > We could also wait to see the work on Elasticsearch. > Anyway, I'm not working actively on Koha anymore, so I won't propose a patch > for bug 10891, but we can keep the bug open, because I still think it would > be a nice enhancement. > > Mathieu Mathieu, don't you want to come back? :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 23:52:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 22:52:09 +0000 Subject: [Koha-bugs] [Bug 13375] New: Syspref search highlight styling broken in Chrome Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13375 Bug ID: 13375 Summary: Syspref search highlight styling broken in Chrome Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org To reproduce: - Do a syspref search, for example 'facet'. => FAIL: Some highlighted occurences of 'facet' have styling problems, check the attached screenshots. Note: Firefox seems to render it properly, this is just in Chrome. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 23:57:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 22:57:24 +0000 Subject: [Koha-bugs] [Bug 13375] Syspref search highlight styling broken in Chrome In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13375 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 34075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34075&action=edit Before the patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 23:57:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 22:57:29 +0000 Subject: [Koha-bugs] [Bug 13349] Allow library code to display against users pending changes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13349 --- Comment #5 from David Roberts --- I've tested this patch against a sandbox and it compiles OK. There is already a description of the enhancement in comment 1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 23:57:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 22:57:43 +0000 Subject: [Koha-bugs] [Bug 13375] Syspref search highlight styling broken in Chrome In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13375 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 34076 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34076&action=edit After the patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 23:59:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 22:59:32 +0000 Subject: [Koha-bugs] [Bug 13375] Syspref search highlight styling broken in Chrome In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13375 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 2 23:59:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 22:59:35 +0000 Subject: [Koha-bugs] [Bug 13375] Syspref search highlight styling broken in Chrome In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13375 --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 34077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34077&action=edit Bug 13375: Syspref search highlight styling broken in Chrome This patch encloses the the syspref description/values mix into a . It doesn't introduce any regression on other browsers (like Firefox) and has the side effect to make Chrome render the highlighted words on syspref searches well. To test: - Search for 'facet' on the sysprefs => FAIL: verify it has styling problems in Chrome - Apply the patch, reload => SUCCESS: styling is correct - Sign off :-D Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 00:25:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 23:25:35 +0000 Subject: [Koha-bugs] [Bug 13369] [Datatables] tr and td are not correctly highlighted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13369 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34063|0 |1 is obsolete| | --- Comment #5 from Tom?s Cohen Arazi --- Created attachment 34078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34078&action=edit [SIGNED OFF] Bug 13369: table should been highlighted correctly when row are grouped The css used to highlight the rows comes from staff-global.css We need a more specific rule to be used. Test plan: Go on the fund list view and confirm that the rows are correctly highlighted. Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 00:32:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Dec 2014 23:32:43 +0000 Subject: [Koha-bugs] [Bug 13349] Allow library code to display against users pending changes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13349 --- Comment #6 from Owen Leonard --- Your second patch applied successfully using git-bz. Thanks for resubmitting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 02:14:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 01:14:02 +0000 Subject: [Koha-bugs] [Bug 13376] New: Include a user-editable area/page for terms and conditions of use in the opac Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13376 Bug ID: 13376 Summary: Include a user-editable area/page for terms and conditions of use in the opac Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Since Koha collects user data, we should have a place for libraries to include their website terms and conditions (and/or cookie policy information). I am thinking a link that appears in the footer area of every page if there is text in a system preference (along the lines of OpacMainUserBlock - free text area that accepts html). The contents of the syspref would be displayed in a page that has the same layout as the home page. I realise that libraries can use a page on their website to do that, but as Koha sometimes stands in for a website for libraries, I think it's important to at least offer a place to put the terms and conditions of use. We could also offer a standardised set of terms and conditions for the syspref (default value) - but a problem here is that people might not edit it, and getting one general enough might be problematic. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 02:19:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 01:19:31 +0000 Subject: [Koha-bugs] [Bug 7741] Clear search terms in Z3950 search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7741 Tom M changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu --- Comment #3 from Tom M --- Created attachment 34079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34079&action=edit Clear z39.50 Search Fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 02:19:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 01:19:59 +0000 Subject: [Koha-bugs] [Bug 7741] Clear search terms in Z3950 search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7741 --- Comment #4 from Tom M --- I don't have a running instance of Koha yet, but I did test this in Firebug and it worked there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 03:11:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 02:11:17 +0000 Subject: [Koha-bugs] [Bug 7741] Clear search terms in Z3950 search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7741 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 03:59:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 02:59:50 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 03:59:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 02:59:56 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15648|0 |1 is obsolete| | --- Comment #79 from Srdjan Jankovic --- Created attachment 34080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34080&action=edit bug_5786, bug_5787: Holds rewrite bug_5786: moved AllowOnShelfHolds to issuingrules bug_5787: moved OPACItemHolds to issuingrules C4::Reserves: * Added OnShelfHoldsAllowed() to check issuingrules * Added OPACItemHoldsAllowed() to check issuingrules * IsAvailableForItemLevelRequest() changed interface, now takes $item_record,$borrower_record; calls OnShelfHoldsAllowed() opac/opac-reserve.pl and opac/opac-search.pl: * rewrote hold allowed rule to use OPACItemHoldsAllowed() * also use OnShelfHoldsAllowed() through * IsAvailableForItemLevelRequest() templates: * Removed AllowOnShelfHolds and OPACItemHolds global flags, they now only have meaning per item type Signed-off-by: Nicole C. Engard I have tested this patch left, right and upside down for the last several months. All tests have passed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 04:03:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 03:03:45 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 --- Comment #80 from Srdjan Jankovic --- (In reply to M. de Rooy from comment #76) > Hard to say. The solution in bug 8367 for MaxPickupDelay seems interesting. > In the meantime a lot of patches have been pushed (especially this week), > leaving this patch at Does not apply.. Removed maxpickupdelay issuingrule, it was a rule only without any implementation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 04:20:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 03:20:02 +0000 Subject: [Koha-bugs] [Bug 13377] New: automatic_renewals.pl not marked executable Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13377 Bug ID: 13377 Summary: automatic_renewals.pl not marked executable Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: swarren at wwwdotorg.org QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz root at leibniz:/etc/cron.daily# ./koha-common library: env: /usr/share/koha/bin/cronjobs/automatic_renewals.pl: Permission denied root at leibniz:/etc/cron.daily# ls -l /usr/share/koha/bin/cronjobs/automatic_renewals.pl -rw-r--r-- 1 root root 1747 Nov 30 15:54 /usr/share/koha/bin/cronjobs/automatic_renewals.pl The file is 644 but should presumably be 755 since /etc/cron.daily/koha-common attempts to execute it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 04:26:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 03:26:56 +0000 Subject: [Koha-bugs] [Bug 13377] automatic_renewals.pl not marked executable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13377 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |robin at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 04:27:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 03:27:38 +0000 Subject: [Koha-bugs] [Bug 13377] automatic_renewals.pl not marked executable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13377 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 Patch complexity|--- |Trivial patch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11577 Depends on| |11577 Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 04:27:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 03:27:38 +0000 Subject: [Koha-bugs] [Bug 11577] Automatic renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13377 See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13377 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 04:30:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 03:30:42 +0000 Subject: [Koha-bugs] [Bug 13377] automatic_renewals.pl not marked executable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13377 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 04:30:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 03:30:46 +0000 Subject: [Koha-bugs] [Bug 13377] automatic_renewals.pl not marked executable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13377 --- Comment #1 from Robin Sheat --- Created attachment 34081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34081&action=edit Bug 13377: mark automatic_renewals.pl as executable This script is called by a cron job, but was never marked as executable, so will error every time it's called, which is no good. To test: * apply the patch * make a package * ensure that the installed /usr/share/koha/bin/cronjobs/automatic_renewals.pl is mode 755 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 05:04:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 04:04:25 +0000 Subject: [Koha-bugs] [Bug 13377] automatic_renewals.pl not marked executable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13377 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #2 from Robin Sheat --- This is important enough for the packages to work correctly that I'm going to push it through QA. I've build squeeze-dev packages with it in, and it looks like it did the trick. It should be in the next 3.18 release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 05:04:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 04:04:44 +0000 Subject: [Koha-bugs] [Bug 13377] automatic_renewals.pl not marked executable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13377 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 05:07:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 04:07:38 +0000 Subject: [Koha-bugs] [Bug 13377] automatic_renewals.pl not marked executable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13377 --- Comment #3 from Robin Sheat --- Workaround until the next version is released (so I can point people here if it comes up on lists etc): sudo chmod +x /usr/share/koha/bin/cronjobs/automatic_renewals.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 05:27:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 04:27:46 +0000 Subject: [Koha-bugs] [Bug 13377] automatic_renewals.pl not marked executable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13377 --- Comment #4 from Stephen Warren --- One the script is marked executable, it still has problems; there's no #! line at the top. Once that's added, the script seems to run without obvious problems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 05:37:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 04:37:58 +0000 Subject: [Koha-bugs] [Bug 13377] automatic_renewals.pl not marked executable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13377 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34081|0 |1 is obsolete| | --- Comment #5 from Robin Sheat --- Created attachment 34082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34082&action=edit Bug 13377: mark automatic_renewals.pl as executable This script is called by a cron job, but was never marked as executable, so will error every time it's called, which is no good. This also adds an appropriate #! line to the top of the file. To test: * apply the patch * make a package * ensure that the installed /usr/share/koha/bin/cronjobs/automatic_renewals.pl is mode 755 and does something when run. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 05:43:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 04:43:44 +0000 Subject: [Koha-bugs] [Bug 13377] automatic_renewals.pl not marked executable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13377 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34082|0 |1 is obsolete| | --- Comment #6 from Robin Sheat --- Created attachment 34083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34083&action=edit Bug 13377: mark automatic_renewals.pl as executable This script is called by a cron job, but was never marked as executable, so will error every time it's called, which is no good. This also adds an appropriate #! line to the top of the file. To test: * apply the patch * make a package * ensure that the installed /usr/share/koha/bin/cronjobs/automatic_renewals.pl is mode 755 and does something when run. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 05:44:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 04:44:52 +0000 Subject: [Koha-bugs] [Bug 13377] automatic_renewals.pl not marked executable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13377 --- Comment #7 from Robin Sheat --- Third time lucky, can you have a look and double check that this patch is sensible to you (it's still pretty simple, so I can't imagine much would go wrong.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 05:56:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 04:56:20 +0000 Subject: [Koha-bugs] [Bug 13377] automatic_renewals.pl not marked executable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13377 --- Comment #8 from Stephen Warren --- The patch in comment 6 looks reasonable; my sysadmin tested out the same changes and saw no obvious issues after making those same changes manually. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 07:30:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 06:30:06 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P1 - high |P3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 07:34:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 06:34:41 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #199 from Mason James --- hmm, this bug has gotten a bit crazy long... we should start breaking new perl-critic type patches into smaller manageable bugs, else things can get a little confusing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 07:47:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 06:47:27 +0000 Subject: [Koha-bugs] [Bug 6986] Update perltidyrc file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6986 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WORKSFORME --- Comment #11 from Mason James --- (In reply to Katrin Fischer from comment #10) > Hi Mason, > if I understood right from the discussion in IRC this file just sets the > defaults that perltidy uses - wouldn't it be less confusing to just remove > the file? yeah, i agree... this bug can be closed, i think :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 07:49:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 06:49:16 +0000 Subject: [Koha-bugs] [Bug 7186] add new 'Koha Stats' tab to 'About' page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7186 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |INVALID --- Comment #13 from Mason James --- (In reply to Jared Camins-Esakov from comment #12) > Resetting to ASSIGNED since there are serious privacy concerns with this > patch. A better option for this functionality would be to provide a script > with which the RM can generate the required statistics at release time. this feature is not really needed i think this bug can be closed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 07:51:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 06:51:17 +0000 Subject: [Koha-bugs] [Bug 7219] remove problematic 'trailing whitespace' characters from files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7219 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Mason James --- (In reply to Mason James from comment #0) > some files in Koha have 'trailing whitespace' characters > > 'trailing whitespace' in files can often cause patches to not apply cleanly, > thats bad :( > > this bug is a general 'omnibus' bug, where many whitespace-fixing patches > are to be attached (perhaps one patch per modified file?) Koha's qa-tool.pl script now detects patches that have 'trailing whitespace' problems so, this bug can be closed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 07:57:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 06:57:46 +0000 Subject: [Koha-bugs] [Bug 7713] display local license files in about.pl, rather than via external urls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7713 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #1 from Mason James --- (In reply to Mason James from comment #0) > some Koha installs cant access the web, therefore cant access the various > license info from the about.pl page > > storing the license files locally, would fix this problem hmm, I'm not sure if its better to have locally available copies of all of the licenses. or to have a link to the canonical/offical license url... I might leave this bug open for someone else to comment, or close -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 08:02:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 07:02:39 +0000 Subject: [Koha-bugs] [Bug 7822] bibitems.publicationyear is not mapped to 260$c for MARC21 frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7822 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #3 from Mason James --- (In reply to Katrin Fischer from comment #2) > Hi Mason, > I am not sure, but maybe this is a WONTFIX. At least I am not sure how we > can resolve this inconsistency correctly for new and existing installations. Hmm, yes i agree even if we were to fix this issue, i'm not sure which mapping of the two is the 'correct' one marking as WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 08:06:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 07:06:27 +0000 Subject: [Koha-bugs] [Bug 7945] rename DB columns in Koha, that are 'reserved words' in SQL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7945 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #2 from Mason James --- (In reply to Mason James from comment #1) > (In reply to comment #0) > > some database columns in Koha match SQL reserved-words > > > > this bug will attempt to locate these columns, and rename them > > afaik, there are 2 offending columns in Koha... > - old_issues.return > - issues.return > > i'll attempt to use a script to find more :) hmm, this has got to be a WONTFIX, i think.. :p -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 09:10:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 08:10:22 +0000 Subject: [Koha-bugs] [Bug 13235] Revise layout of patron search form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 09:10:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 08:10:24 +0000 Subject: [Koha-bugs] [Bug 13235] Revise layout of patron search form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34073|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 34084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34084&action=edit Bug 13235 - Revise layout of patron search form Bug 9811 (Patron search improvements) reversed the layout changes made by Bug 10153. This patch returns to the form to its "stacked" layout. To test, apply the patch and navigate to the Patrons home page. Expand the hidden search fields in the search header and confirm that the layout looks correct. Perform some searches and check that the results are correct and that the modified search fields retain their state. Note: This patch contains indentation changes, so please diff accordingly. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 09:10:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 08:10:30 +0000 Subject: [Koha-bugs] [Bug 13235] Revise layout of patron search form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 --- Comment #7 from Jonathan Druart --- Created attachment 34085 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34085&action=edit Bug 13235: Move onclick attr to javacsript code Refactor 1 line of code and add a preventDefault. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 11:40:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 10:40:30 +0000 Subject: [Koha-bugs] [Bug 13378] New: There is no way to search suggestions not linked to a fund Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13378 Bug ID: 13378 Summary: There is no way to search suggestions not linked to a fund Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org On the suggestion search page, the fund filter does not provide a way to search suggestions not linked to a fund. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 11:40:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 10:40:40 +0000 Subject: [Koha-bugs] [Bug 13378] There is no way to search suggestions not linked to a fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13378 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 11:43:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 10:43:11 +0000 Subject: [Koha-bugs] [Bug 13378] There is no way to search suggestions not linked to a fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13378 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 11:43:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 10:43:13 +0000 Subject: [Koha-bugs] [Bug 13378] There is no way to search suggestions not linked to a fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13378 --- Comment #1 from Jonathan Druart --- Created attachment 34086 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34086&action=edit Bug 13378: Add a filter to search suggestions not linked to a fund This patch adds a "None" option for the fund filter. Test plan: 1/ Go on the suggestion search page 2/ Search suggestions not linked to a fund using the "None" option. 3/ Search all suggestions (linked or not to a fund) using the "Any" option. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 12:02:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 11:02:48 +0000 Subject: [Koha-bugs] [Bug 12059] Publisher code always empty on invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12059 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paola.rossi at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 12:02:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 11:02:50 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 12:02:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 11:02:53 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34061|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize --- Created attachment 34087 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34087&action=edit [Passed QA] Bug 11190 sitemap.pl -- Generate a Catalog sitemap Add a script sitemap.pl to process all biblio records from a Koha instance and generate Sitemap files complying with this protocol as described on http://sitemaps.org. The goal of this script is to be able to provide to search engines direct access to biblio records. It avoid leaving search engine browsing Koha OPAC and so generating a lot of traffic, and workload, for a bad result. Thanks Magnus for testing, and helping to improve the script design. Signed-off-by: Magnus Enger All options to the script work as expected and the output looks good. Nice enhancement! Signed-off-by: Frederic Demians I signed-of my own patch after fixing various QA errors. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 12:03:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 11:03:56 +0000 Subject: [Koha-bugs] [Bug 12059] Publisher code always empty on invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12059 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33411|0 |1 is obsolete| | --- Comment #3 from Paola Rossi --- Created attachment 34088 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34088&action=edit Bug 12059: Publisher column on invoice page always empty Everything is ok as required. So I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 12:04:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 11:04:16 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #25 from Martin Renvoize --- This now passes the QA scripts for me, and appears to be generally ok code for a worthwhile feature. I'll leave the Moose debate to release manager as I'm a little confused on this front. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 12:26:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 11:26:32 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 --- Comment #26 from Paul Poulain --- a small question related to the sitemap size limit. There are 2 limits : 50000 urls + 10MB maximum (unzipped). Has anyone tested with 50000+ url and a "realistic" url site name. I fear that 50k urls would result in more than 10MB file as our urls can be pretty long. For example : http://koha.mediathequeouestprovence.fr/cgi-bin/koha/opac-detail.pl?biblionumber=135438 only for the URL, add headers, timestamps, wouldn't that make a >10MB file ? About the Moose thing: I'm really annoyed. On one hand, this script is very useful and worth being pushed, no doubt. But on the other hand, it add the Moose requirement (although not mandatory), that we removed some months ago. My opinion would be: "OK, let's push this patch, but add a FIXME and a coding guideline to prevent any script like this to be pushed/submitted". (and the "CLI script" argument seems an invalid one to me: otherwise, we could add many depenencies, and that would not be good) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 12:36:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 11:36:15 +0000 Subject: [Koha-bugs] [Bug 13379] New: authorised_values.category is varchar(16) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13379 Bug ID: 13379 Summary: authorised_values.category is varchar(16) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org But borrower_attribute_types is varchar(10). So if you try to link a patron attribute type with an AV category with a length > 10, the link won't be done. Also, I propose to extend this field to varchar(32). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 12:36:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 11:36:23 +0000 Subject: [Koha-bugs] [Bug 13379] authorised_values.category is varchar(16) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13379 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 12:36:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 11:36:46 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 --- Comment #27 from Paul Poulain --- suggestion for a future improvement : be able to add a WHERE clause to the biblio that are sitemap generated. This where could rely on biblio/biblioitems/items parameters. For example, a library could not publish records related to libraryX, or exclude serials, or sitemap only items published before YYYY -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 12:41:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 11:41:10 +0000 Subject: [Koha-bugs] [Bug 3578] different_IP auth is too strict for many services In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3578 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |DUPLICATE --- Comment #1 from Martin Renvoize --- *** This bug has been marked as a duplicate of bug 5511 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 12:41:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 11:41:11 +0000 Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 --- Comment #18 from Martin Renvoize --- *** Bug 3578 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 12:41:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 11:41:24 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 --- Comment #28 from Paul Poulain --- Additional (final ?) comment: there is no changefreq definition. I can't find the default value if you don't specify it, but I think that a monthly or even yearly changefreq is better for a search engine (and be careful, for large catalogue, if we put a too frequent period, the server will be crashed by multiple requests. We had to disallow search engines using robots.txt on many libraries ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 12:43:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 11:43:17 +0000 Subject: [Koha-bugs] [Bug 13379] authorised_values.category is varchar(16) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13379 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 12:43:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 11:43:19 +0000 Subject: [Koha-bugs] [Bug 13379] authorised_values.category is varchar(16) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13379 --- Comment #1 from Jonathan Druart --- Created attachment 34089 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34089&action=edit Bug 13379: Extends authorised_values.category to varchar(32) This patch does 2 things: 1/ It fixes a bug caused by the different data fields used for authorised_values.category and borrower_attribute_types.authorised_value_category (varchar(16) vs varchar(10)). To reproduce: - Create a AV category with a length > 10 - Try to link a patron attribute type with this AV, it won't work. 2/ Extends this field to varchar(32): sometime 16 is not enough to describe something -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 12:53:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 11:53:00 +0000 Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #19 from Martin Renvoize --- Any further movement on this Amit? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 12:59:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 11:59:32 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 --- Comment #29 from Fr?d?ric Demians --- (In reply to Martin Renvoize from comment #25) > This now passes the QA scripts for me, and appears to be generally ok code > for a worthwhile feature. I'll leave the Moose debate to release manager as > I'm a little confused on this front. When you shut the door, Moose is the kind of thing that enter by the back door... Moo could be used instead. I don't see the advantage, nor the problem with Moose which is such a common dependency in the Perl ecosystem, and which is properly packaged in Debian (and others) now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 13:06:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 12:06:50 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 --- Comment #30 from Fr?d?ric Demians --- (In reply to Paul Poulain from comment #26) > a small question related to the sitemap size limit. > There are 2 limits : 50000 urls + 10MB maximum (unzipped). > Has anyone tested with 50000+ url and a "realistic" url site name. > > I fear that 50k urls would result in more than 10MB file as our urls can be > pretty long. For example : > http://koha.mediathequeouestprovence.fr/cgi-bin/koha/opac-detail. > pl?biblionumber=135438 only for the URL, add headers, timestamps, wouldn't > that make a >10MB file ? I've just tested, for this Koha site URL. A 50000 URL file: - short version = 5.6M - long versoin = 7.3M > (and the "CLI script" argument seems an invalid one to me: otherwise, we > could add many depenencies, and that would not be good) It's not like Moose was a exotic, unmaintained module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 13:10:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 12:10:13 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #54 from M. de Rooy --- (In reply to Paul Poulain from comment #53) > made many tests using TRACK mode, as well as PROD mode, and could not find > any problem. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 13:10:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 12:10:19 +0000 Subject: [Koha-bugs] [Bug 13380] New: Auto fill order cancellation reasons from authorised values Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Bug ID: 13380 Summary: Auto fill order cancellation reasons from authorised values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org Since bug 7162, it's possible to give a cancellation reason on deleting an order. This would be better to fill an authorised values category with the different possible values. Like that we will avoid to have duplicate or similar reasons. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 13:10:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 12:10:33 +0000 Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |7162 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 13:10:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 12:10:33 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation and add field for giving a reason In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13380 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 13:10:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 12:10:41 +0000 Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13369 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 13:10:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 12:10:41 +0000 Subject: [Koha-bugs] [Bug 13369] [Datatables] tr and td are not correctly highlighted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13369 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13380 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 13:14:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 12:14:04 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 --- Comment #31 from Fr?d?ric Demians --- (In reply to Paul Poulain from comment #28) > Additional (final ?) comment: there is no changefreq definition. I can't > find the default value if you don't specify it, but I think that a monthly > or even yearly changefreq is better for a search engine The web crawlers download the sitemap files at an unknown frequency, and then compare the recent URL with the previous one, based on url's timestamp. Even if the sitemap is updated on the Koha server daily, the crawlers won't download it daily. > (and be careful, for > large catalogue, if we put a too frequent period, the server will be crashed > by multiple requests. We had to disallow search engines using robots.txt on > many libraries ! A sitemap helps crawlers not to be lost in a Koha catalog. Does it slow down requests sent by crawlers, we can't say or know. Empirically, I would say yes, but there is no way to be sure. Crawlers seem less tempted to follow multiple links at a rapid pace. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 13:25:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 12:25:01 +0000 Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 13:25:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 12:25:04 +0000 Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #1 from Jonathan Druart --- Created attachment 34090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34090&action=edit Bug 13380: Fill order cancellation reasons from AV Since bug 7162, it's possible to give a cancellation reason on deleting an order. This would be better to fill an authorised values category with the different possible values. Like that we will avoid to have duplicate or similar reasons. Also, it will be easier to filter or create reports. Test plan: 0/ Don't apply the patch 1/ Cancel some orders and give a cancelletion reason 2/ Apply the patch and execute the updatedb entry 3/ Cancel an order and verify the you have a list with the reason you previously filled + 3 new ones ('No reason', 'Sold out' and 'Restocking'); 4/ Choose one and verify the value is correctly displayed on the basket page 5/ You can also try to add other values from the admin module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 13:25:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 12:25:08 +0000 Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #2 from Jonathan Druart --- Created attachment 34091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34091&action=edit Bug 13380: Add the AV in the install files (This will completely done when the patch will be QAed) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 14:02:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 13:02:59 +0000 Subject: [Koha-bugs] [Bug 13377] automatic_renewals.pl not marked executable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13377 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #9 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Robin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 14:03:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 13:03:47 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 --- Comment #32 from Paul Poulain --- (In reply to Fr?d?ric Demians from comment #31) > (In reply to Paul Poulain from comment #28) > > Additional (final ?) comment: there is no changefreq definition. I can't > > find the default value if you don't specify it, but I think that a monthly > > or even yearly changefreq is better for a search engine > > The web crawlers download the sitemap files at an unknown frequency, and > then compare the recent URL with the previous one, based on url's timestamp. > Even if the sitemap is updated on the Koha server daily, the crawlers won't > download it daily. I think we're not talking of the same thing. http://www.sitemaps.org/protocol.html says =============================== optional How frequently the page is likely to change. This value provides general information to search engines and may not correlate exactly to how often they crawl the page. Valid values are: always hourly daily weekly monthly yearly never The value "always" should be used to describe documents that change each time they are accessed. The value "never" should be used to describe archived URLs. Please note that the value of this tag is considered a hint and not a command. Even though search engine crawlers may consider this information when making decisions, they may crawl pages marked "hourly" less frequently than that, and they may crawl pages marked "yearly" more frequently than that. Crawlers may periodically crawl pages marked "never" so that they can handle unexpected changes to those pages. ================================= It can be defined for each page. My comment was related to each opac-detail.pl page description: we should say to the search engine that the page does not change often, so once it's indexed, there's no need to come back frequently. HTH -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 14:25:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 13:25:52 +0000 Subject: [Koha-bugs] [Bug 13381] New: RDA: 245 field changes in XSLT Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 Bug ID: 13381 Summary: RDA: 245 field changes in XSLT Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: nengard at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org The following change should be made to the MARC21 details in the staff and OPAC: 245 Display complete title and statement of responsibility at the beginning of the record (brief/full display) Display corresponding subfields a, b, c, k, n, p, s Suppress the display of subfield h [GMD] in the title Examples: Franz Kafka : the office writings / edited by Stanley Corngold, Jack Greenberg, and Benno Wagner ; translations by Eric Patton with Ruth Hein. Kafka on the shore / Haruki Murakami ; translated from the Japanese by Philip Gabriel. The hunger games / directed by Gary Ross ; screenplay by Gary Ross and Suzanne Collins and Billy Ray ; produced by Nina Jacobson, Jon Kilik ; a Lionsgate presentation ; a Color Force/Lionsgate production ; a Gary Ross film. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 14:26:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 13:26:04 +0000 Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10344 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 14:26:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 13:26:04 +0000 Subject: [Koha-bugs] [Bug 10344] Omnibus: add RDA support to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10344 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13381 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 14:28:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 13:28:10 +0000 Subject: [Koha-bugs] [Bug 10344] Omnibus: add RDA support to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10344 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13382 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 14:28:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 13:28:10 +0000 Subject: [Koha-bugs] [Bug 13382] New: RDA: 700/710/711 display in XSLT Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Bug ID: 13382 Summary: RDA: 700/710/711 display in XSLT Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: nengard at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Blocks: 10344 The following change should be made to the MARC21 details in the staff and OPAC: Display 700, 710 and 711?s as Contributor(s) (full display) Display corresponding subfields a, b, c, d, e, f, g, h, i, k, l, m, n, o, p, r, s, t, u, x Display corresponding subfield e with term(s) in brackets; if there is more than one subfield e, list all terms within the brackets Use vertical bar to separate multiple listings Example: Contributor(s): Gabriel, Philip, 1953? Contributor(s): Schindler, S. D. [illustrator] Contributor(s): Nolan, Christopher, 1970? [film producer, screenwriter, director] Contributor(s): Bernstein, Leonard, 1918?1990. | Beethoven, Ludwig van, 1770?1827. Symphonies, no. 3, op. 55, E? major. | Juilliard American Opera Center. Chorus. Contributor(s): Director of photography, Tom Stern ; production designer, Philip Messina ; edited by Stephen Mirrione, Juliette Welfling ; costume designer, Judianna Makovsky ; music by James Newton Howard. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 14:31:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 13:31:59 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #1 from Nicole C. Engard --- Display all 700, 710 and 711?s with a subfield i as Related Works (full display) Related Works: Television adaptation of (work): Kerman, Piper. Orange is the new black. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 14:33:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 13:33:03 +0000 Subject: [Koha-bugs] [Bug 10344] Omnibus: add RDA support to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10344 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13383 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 14:33:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 13:33:03 +0000 Subject: [Koha-bugs] [Bug 13383] New: RDA: 100/110/111 changes to XSLT Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13383 Bug ID: 13383 Summary: RDA: 100/110/111 changes to XSLT Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: nengard at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Blocks: 10344 The following change should be made to the MARC21 details in the staff and OPAC: Display the authorized access point, ie author, after By (brief/full display) Display corresponding subfields a, b, c, d, q, t Display corresponding subfield e with term in brackets; if there is more than one subfield e, list all terms within the brackets By: Murakami, Haruki, 1949? By: Waterman, John T. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 14:33:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 13:33:42 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 --- Comment #33 from Fr?d?ric Demians --- (In reply to Paul Poulain from comment #32) > I think we're not talking of the same thing. > http://www.sitemaps.org/protocol.html says > =============================== > optional Yes. I was referring to the script running frequency. The generated sitemap doesn't contain changefreq at all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 14:34:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 13:34:28 +0000 Subject: [Koha-bugs] [Bug 13384] New: RDA: 655 display in XSLT Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13384 Bug ID: 13384 Summary: RDA: 655 display in XSLT Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: nengard at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Blocks: 10344 The following change should be made to the MARC21 details in the staff and OPAC: 655 Display as Genre/Form (full display) Only display headings with a 7 in the 2nd indicator and gsafd or lcgft in subfield 2 Display corresponding subfields a, v, x, y, z -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 14:34:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 13:34:28 +0000 Subject: [Koha-bugs] [Bug 10344] Omnibus: add RDA support to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10344 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13384 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 14:35:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 13:35:47 +0000 Subject: [Koha-bugs] [Bug 10344] Omnibus: add RDA support to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10344 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13385 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 14:35:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 13:35:47 +0000 Subject: [Koha-bugs] [Bug 13385] New: RDA: 508 display in XSLT Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13385 Bug ID: 13385 Summary: RDA: 508 display in XSLT Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: nengard at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Blocks: 10344 The following change should be made to the MARC21 details in the staff and OPAC: 508 Display as Production Credits (full display) Display corresponding subfield a Example: Production Credits: Director of photography, Wally Pfister ; editor, Lee Smith ; music, Hans Zimmer ; production designer, Guy Hendrix Dyas ; costume designer, Jeffrey Kurland ; special effects supervisor, Chris Corbould ; visual effects supervisor, Paul Franklin ; art direction, Luke Freeborn, Brad Ricker, Dean Wolcott ; set decoration, Larry Dias, Doug Mowat ; costume designer, Jeffrey Kurland ; co?producer, Jordan Goldberg ; executive producers, Chris Brigham, Thomas Tull. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 14:38:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 13:38:02 +0000 Subject: [Koha-bugs] [Bug 10344] Omnibus: add RDA support to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10344 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13386 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 14:38:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 13:38:02 +0000 Subject: [Koha-bugs] [Bug 13386] New: 246 display in XSLT Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13386 Bug ID: 13386 Summary: 246 display in XSLT Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: nengard at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Blocks: 10344 The following change should be made to the MARC21 details in the staff and OPAC: 246 Continue to display as Other Titles (brief/full display) Use vertical bar to separate multiple other titles Other titles: Three hundred international recipes for savoring the planet | 250 international recipes for savoring the planet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 14:39:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 13:39:46 +0000 Subject: [Koha-bugs] [Bug 13387] New: Uniform titles (130 / 240 / 730) Display in XSLT Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13387 Bug ID: 13387 Summary: Uniform titles (130 / 240 / 730) Display in XSLT Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: nengard at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Blocks: 10344 The following change should be made to the MARC21 details in the staff and OPAC: 130/240/730 Display as Uniform Titles (brief/full display) Display corresponding subfields a, b, c, k, n, p, s Use vertical bar to separate multiple other titles Examples: Uniform titles: Orchestra music. Selections. Uniform titles: Hunger games (Motion picture) Uniform titles: Organ music. Selections. | Kleine Pra?ludien und Fugen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 14:39:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 13:39:46 +0000 Subject: [Koha-bugs] [Bug 10344] Omnibus: add RDA support to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10344 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13387 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 14:41:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 13:41:45 +0000 Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 --- Comment #1 from Nicole C. Engard --- [07:36] nengard: not sure about hiding h in 245 [07:37] we use that quite a lot and it helps identifying electronic resources in the result list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 14:45:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 13:45:21 +0000 Subject: [Koha-bugs] [Bug 13375] Syspref search highlight styling broken in Chrome In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13375 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34077|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 34092 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34092&action=edit Bug 13375 [Alternate] Syspref search highlight styling broken in Chrome This patch encloses the the syspref description/values mix in a
. It doesn't introduce any regression on other browsers (like Firefox) and has the side effect to make Chrome render the highlighted words on syspref searches well. This alternate patch uses a
instead of a because it will sometimes contain block-level elements. Follow the same plan: To test: - Search for 'facet' on the sysprefs => FAIL: verify it has styling problems in Chrome - Apply the patch, reload => SUCCESS: styling is correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 15:14:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 14:14:56 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 15:16:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 14:16:41 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from simith.doliveira at inlibro.com --- Sorry Paola my bad, in 6) Choose cn_browser.pl not callnumber.pl as I wrote. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 15:25:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 14:25:39 +0000 Subject: [Koha-bugs] [Bug 13375] Syspref search highlight styling broken in Chrome In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13375 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 15:25:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 14:25:42 +0000 Subject: [Koha-bugs] [Bug 13375] Syspref search highlight styling broken in Chrome In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13375 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34092|0 |1 is obsolete| | --- Comment #5 from Tom?s Cohen Arazi --- Created attachment 34093 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34093&action=edit [SIGNED OFF] Bug 13375: Syspref search highlight styling broken in Chrome This patch encloses the the syspref description/values mix in a
. It doesn't introduce any regression on other browsers (like Firefox) and has the side effect to make Chrome render the highlighted words on syspref searches well. This alternate patch uses a
instead of a because it will sometimes contain block-level elements. Follow the same plan: To test: - Search for 'facet' on the sysprefs => FAIL: verify it has styling problems in Chrome - Apply the patch, reload => SUCCESS: styling is correct Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 15:30:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 14:30:33 +0000 Subject: [Koha-bugs] [Bug 12428] "OPAC info" is not displayed in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29062|0 |1 is obsolete| | Attachment #29179|0 |1 is obsolete| | --- Comment #11 from Owen Leonard --- Created attachment 34094 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34094&action=edit Bug 12428 [3.16.x] "OPAC info" is not displayed in the OPAC This patch changes the footer include, adding an alias for the jQueryUI tooltip function to prevent conflict with Bootstrap's function of the same name. To test, you must have at least two libraries configured with "OPAC info" for display in the OPAC. Modify the holdings of a title so that there is at least one item which has different holding and home branches matching your library configured above. View the detail page for that record. Hovering your cursor over the library name in the "Location" column should display the branch information you configured for that library in a tooltip. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 15:30:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 14:30:52 +0000 Subject: [Koha-bugs] [Bug 12428] "OPAC info" is not displayed in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 15:31:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 14:31:07 +0000 Subject: [Koha-bugs] [Bug 12428] "OPAC info" is not displayed in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 15:31:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 14:31:14 +0000 Subject: [Koha-bugs] [Bug 12428] "OPAC info" is not displayed in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.16 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 15:31:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 14:31:44 +0000 Subject: [Koha-bugs] [Bug 12428] "OPAC info" is not displayed in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|cbrannon at cdalibrary.org, |gmcharlt at gmail.com |ed.veal at bywatersolutions.co | |m, sandboxes at biblibre.com, | |tomascohen at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 15:32:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 14:32:32 +0000 Subject: [Koha-bugs] [Bug 12428] "OPAC info" is not displayed in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gmcharlt at gmail.com |mtj at kohaaloha.com, | |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 15:42:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 14:42:19 +0000 Subject: [Koha-bugs] [Bug 13388] New: Add library pages to the OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13388 Bug ID: 13388 Summary: Add library pages to the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: magnus at enger.priv.no QA Contact: testopia at bugs.koha-community.org we talked also about exposing more information about the library like opening hours, teh library's name and website i have been pondering one page per library and it could be linked from the library name in the items tables i hope i got it right, but i think that was what denials mentioned - that we should link to a separate page link to the library on the name and tooltip with opacinfo cait, magnuse - that (one page per library, linked from the library name in the items tables) is _exactly_ what I was suggesting! yay for convergence -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 15:52:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 14:52:55 +0000 Subject: [Koha-bugs] [Bug 12839] aqbooksellers.gstreg is never used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12839 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 15:53:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 14:53:40 +0000 Subject: [Koha-bugs] [Bug 12841] aqorders fields should not be mapped In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12841 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 15:54:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 14:54:07 +0000 Subject: [Koha-bugs] [Bug 12980] GetHistory does useless processing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12980 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 15:54:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 14:54:41 +0000 Subject: [Koha-bugs] [Bug 12852] The "preview" param is never used in serials/claims.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12852 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 15:55:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 14:55:15 +0000 Subject: [Koha-bugs] [Bug 12123] HTML notices can break the notice viewer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #14 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle and Liz! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 15:55:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 14:55:19 +0000 Subject: [Koha-bugs] [Bug 13307] Create a link to the last advanced search in search result page (OPAC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 --- Comment #8 from simith.doliveira at inlibro.com --- Created attachment 34095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34095&action=edit Fix Patch- Search boxes disappear when returning to advanced search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 15:56:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 14:56:14 +0000 Subject: [Koha-bugs] [Bug 13307] Create a link to the last advanced search in search result page (OPAC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34050|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 16:03:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 15:03:02 +0000 Subject: [Koha-bugs] [Bug 13307] Create a link to the last advanced search in search result page (OPAC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 17:02:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 16:02:48 +0000 Subject: [Koha-bugs] [Bug 8304] composed authorities Rameau management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 --- Comment #25 from Fridolin SOMERS --- The patch adds in merge() : + DelAuthority($mergefrom) if ( $mergefrom != $mergeto ); This is a big difference and I think is not necessary because codes calling merge() call this method when necessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 17:03:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 16:03:13 +0000 Subject: [Koha-bugs] [Bug 8304] composed authorities Rameau management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 17:12:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 16:12:58 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #31 from Jonathan Druart --- Did you get this error? $ export KOHA_OPAC_URL=http://catalogue.koha-qa.vm $ export KOHA_INTRANET_URL=http://pro.koha-qa.vm $ prove t/db_dependent/www/batch.t t/db_dependent/www/batch.t .. Error GETing http://pro.koha-qa.vm/cgi-bin/koha/mainpage.pl: Can't connect to pro.koha-qa.vm:80 at t/db_dependent/www/batch.t line 60. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 17:41:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 16:41:23 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #32 from Zeno Tajoli --- (In reply to Jonathan Druart from comment #31) > Did you get this error? > > $ export KOHA_OPAC_URL=http://catalogue.koha-qa.vm > $ export KOHA_INTRANET_URL=http://pro.koha-qa.vm > $ prove t/db_dependent/www/batch.t > t/db_dependent/www/batch.t .. Error GETing > http://pro.koha-qa.vm/cgi-bin/koha/mainpage.pl: Can't connect to > pro.koha-qa.vm:80 at t/db_dependent/www/batch.t line 60. No, I never see it. Attention that the patch doesn't modify t/db_dependent/www/batch.t. And to use it (and batch.t) you need a working installation. If you go to http://pro.koha-qa.vm you see a intranet login form ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 18:02:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 17:02:19 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Paola Rossi --- I've applied the patch (head 12123). Simith says: >in 6) Choose cn_browser.pl not callnumber.pl as I wrote. Thanks! So the "Call Numbers browser" pop-up has been opened as required. Choosing a full call number < MIN [or choosing a full call number > MAX], I saw no green row at the top of the table [or at the bottom of the table]. I think this is an error. So I pass the patch to "Failed QA" status. NB1. I've searched a value by the "Search call number:" input field, selecting "Search". I saw the error: An error has occurred! Error 404 This error means that the link was broken and that the page doesn't exist To report this error, you can email the Koha administrator. Use top menu bar to navigate to another part of Koha. NB2. In the Call numbers table : 10 has been listed before 2 10 has been listed before 1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 18:59:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 17:59:01 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33251|0 |1 is obsolete| | Attachment #33252|0 |1 is obsolete| | Attachment #33253|0 |1 is obsolete| | Attachment #33254|0 |1 is obsolete| | Attachment #33255|0 |1 is obsolete| | Attachment #33256|0 |1 is obsolete| | Attachment #33257|0 |1 is obsolete| | Attachment #33258|0 |1 is obsolete| | Attachment #33259|0 |1 is obsolete| | Attachment #33260|0 |1 is obsolete| | Attachment #33261|0 |1 is obsolete| | Attachment #33262|0 |1 is obsolete| | --- Comment #571 from Kyle M Hall --- Created attachment 34096 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34096&action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 18:59:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 17:59:17 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #572 from Kyle M Hall --- Created attachment 34097 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34097&action=edit Bug 6427 - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 18:59:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 17:59:24 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #573 from Kyle M Hall --- Created attachment 34098 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34098&action=edit Bug 6427 - Add new Accounts related Koha modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 18:59:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 17:59:32 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #574 from Kyle M Hall --- Created attachment 34099 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34099&action=edit Bug 6427 - Update existing Koha perl modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 18:59:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 17:59:39 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #575 from Kyle M Hall --- Created attachment 34100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34100&action=edit Bug 6427 - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 18:59:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 17:59:49 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #576 from Kyle M Hall --- Created attachment 34101 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34101&action=edit Bug 6427 - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 18:59:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 17:59:56 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #577 from Kyle M Hall --- Created attachment 34102 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34102&action=edit Bug 6427 - Add new staff scripts for managing accounts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 19:00:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 18:00:05 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #578 from Kyle M Hall --- Created attachment 34103 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34103&action=edit Bug 6427 - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 19:00:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 18:00:13 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #579 from Kyle M Hall --- Created attachment 34104 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34104&action=edit Bug 6427 - Update OPAC scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 19:00:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 18:00:21 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #580 from Kyle M Hall --- Created attachment 34105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34105&action=edit Bug 6427 - Add & update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 19:00:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 18:00:29 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #581 from Kyle M Hall --- Created attachment 34106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34106&action=edit Bug 6427 - Delete unused and unnecessary files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 19:00:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 18:00:37 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #582 from Kyle M Hall --- Created attachment 34107 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34107&action=edit Bug 6427 - Unit Tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 19:22:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 18:22:06 +0000 Subject: [Koha-bugs] [Bug 13389] New: Calendar maintenance Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13389 Bug ID: 13389 Summary: Calendar maintenance Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Holidays Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org Would like to see a preference and cron job that regularly cleans up the calendars. A preference should be set as to how long past non-repeating events (holidays) should remain in the calendar (for reference) before cleared. A cron job should look at non-repeating events that are past, and this preference, and daily clean up the calendars. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 20:20:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 19:20:18 +0000 Subject: [Koha-bugs] [Bug 13390] New: authority overlay overwrites bib links Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13390 Bug ID: 13390 Summary: authority overlay overwrites bib links Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl It seems like when you overlay an authority using the batch import tool you're losing the link to the bib records it was previously linked to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 20:31:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 19:31:11 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #7 from simith.doliveira at inlibro.com --- Created attachment 34108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34108&action=edit fix patch - search call number does not work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 20:44:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 19:44:53 +0000 Subject: [Koha-bugs] [Bug 13211] Added: GoogleIndicTransliteration as a System Preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #14 from Nicole C. Engard --- Can someone explain to me what this does in librarian terms for the manual? Does it just make it so you can type in your language in the search box? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 20:50:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 19:50:13 +0000 Subject: [Koha-bugs] [Bug 13377] automatic_renewals.pl not marked executable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13377 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #10 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.01, Robin do you think it's worth rolling a new 3.18.0 with just this patch added to it? (It's only 18 days to 3.18.01 ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 20:56:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 19:56:56 +0000 Subject: [Koha-bugs] [Bug 12839] aqbooksellers.gstreg is never used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12839 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 20:59:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 19:59:21 +0000 Subject: [Koha-bugs] [Bug 12841] aqorders fields should not be mapped In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12841 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 21:03:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 20:03:16 +0000 Subject: [Koha-bugs] [Bug 12980] GetHistory does useless processing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12980 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 21:16:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 20:16:23 +0000 Subject: [Koha-bugs] [Bug 12852] The "preview" param is never used in serials/claims.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12852 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #11 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 21:17:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 20:17:54 +0000 Subject: [Koha-bugs] [Bug 12123] HTML notices can break the notice viewer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #15 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 21:21:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 20:21:18 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 21:25:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 20:25:49 +0000 Subject: [Koha-bugs] [Bug 13388] Add library pages to the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13388 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 21:26:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 20:26:35 +0000 Subject: [Koha-bugs] [Bug 10344] Omnibus: add RDA support to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10344 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 21:43:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 20:43:02 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #8 from simith.doliveira at inlibro.com --- Created attachment 34109 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34109&action=edit fix patch - searching call number < MIN or > MAX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 3 21:48:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Dec 2014 20:48:41 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #9 from simith.doliveira at inlibro.com --- Both problems (comment 6) should be corrected with the patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 08:52:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 07:52:22 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from M. de Rooy --- Preliminary QA comment: function Clic$function_name(i) { q = \$('[id^= \"tag_952_subfield_o\"]').val(); window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=cn_browser.pl&popup&q=\"+q,\"cnbrowser\",\"width=500,height=400,toolbar=false,scrollbars=yes\"); Please do not do it like that. Now you hardcoded the field while it is passed to you in a parameter. Also normally we pass index and value to the plugin in the URL. If you include your parameter i in the URL with something like index=i you can do this: var q=\$('#'+i).val(); window.open(... index="+i+"& ... ) And if you pass index via sub plugin to the template too, you can use it there if needed also. (In a popup you would use it when putting back the value in the field.) Also I am not sure what you are doing with the 'popup' parameter. You put it in the URL without a value. Later you are checking the value of popup. This is actually useless? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 08:57:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 07:57:05 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|String patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 13:18:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 12:18:47 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #252 from Jonathan Druart --- commit bfc167d532788154db64c65c04d80ef603fa56a5 Author: Tomas Cohen Arazi Date: Wed Nov 5 11:59:38 2014 -0300 Bug 11944: revert unneeded IsStringUTF8ish behaviour change Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 13:19:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 12:19:00 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #253 from Jonathan Druart --- commit 8e4f43aee283869dc78991874ea0ac58cdba8ac0 Author: Jonathan Druart Date: Thu Dec 4 13:13:30 2014 +0100 Bug 11944: Fix problems introduced by bug 11515 The game continue... Patch for bug 11515 introduced regression on this patch set. To reproduce: search with utf8 characters at the opac Test plan: Verify that the issue described on bug 11515 is still fixed and that no regression is found at the OPAC. Note that I am pretty sure this patch is not enough. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 13:21:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 12:21:02 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33811|0 |1 is obsolete| | Attachment #33812|0 |1 is obsolete| | Attachment #33813|0 |1 is obsolete| | Attachment #33814|0 |1 is obsolete| | Attachment #33815|0 |1 is obsolete| | Attachment #33816|0 |1 is obsolete| | Attachment #33817|0 |1 is obsolete| | --- Comment #33 from Jonathan Druart --- Created attachment 34110 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34110&action=edit Bug 13264: UNIMARC and MARC21 records to test UTF-8 The records shares enough chars to do the same search ('deuteros') to find them and check the same utf-8 chars. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 13:20:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 12:20:59 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 13:21:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 12:21:09 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #34 from Jonathan Druart --- Created attachment 34111 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34111&action=edit Bug 13264: Test for utf-8 on Opac search This test need to setup zebraserver and background indexing. You need to set also KOHA_INTRANET_URL and KOHA_OPAC_URL in the user enviroment. It imports sample records and retrieves them on hte OPAC through Apache. To run it: prove opac_utf8.t Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 13:21:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 12:21:16 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #35 from Jonathan Druart --- Created attachment 34112 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34112&action=edit Bug 13264: Test for utf-8 on authorised values input/display/delete This test check utf-8 support on web intranet interface for authorized values. It test input, search and delete of utf-8 values. If all OK it destroy values inserted Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 13:21:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 12:21:22 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #36 from Jonathan Druart --- Created attachment 34113 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34113&action=edit Bug 13264: no need to test for MySQL This patch removes the test for a running MySQL process. It is already implied by successfuly loading C4::Context. It also fixes the license text. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 13:21:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 12:21:32 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #37 from Jonathan Druart --- Created attachment 34114 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34114&action=edit Bug 13264: Make opac_utf8.t launch its own helper processes This patch makes opac_utf8.t launch its own: - zebrasrv process - rebuild_zebra.pl (daemon mode) It also takes care of killing them when finished. It sets a frecquency of 5 seconds for the indexer, and waits 10 just in case before looking for the indexed records. To test: - Just launch the tests. Edit: fixes on the license text. Regards Tomas Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 13:21:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 12:21:44 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #38 from Jonathan Druart --- Created attachment 34115 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34115&action=edit Bug 13264: Follow up: in opac_utf8.t insert also delete of biblio In previous version of the test opac_utf8.t clears import from resevoir but it doesn't delete record from biblio table in MySQL. This the standard work of the feature, see: http://manual.koha-community.org/3.18/en/catalogtools.html#managestaged Now the script deletes also record on MySQL level. No necessary on Zebra level because it uses a temporaney Zebra index that it is clenaned at the end of the script. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 13:21:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 12:21:55 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #39 from Jonathan Druart --- Created attachment 34116 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34116&action=edit Bug 13264: Additional test for search in intranet calatogue The utf-8 test do: insert a biblio record with tool, search the record in intranet, delete batch upload and biblio records. To test: prove intranet_search_utf8.t Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 13:22:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 12:22:08 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #40 from Jonathan Druart --- Created attachment 34117 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34117&action=edit Bug 13264: Refactor search utf8 tests and add some more t/db_dependent/www/search_utf8.t and t/db_dependent/www/intranet_search_utf8.t were quite similar, I merged them into a single file (t/db_dependent/www/search_utf8.t). On the way, I added some tests for them. Note that you will need the last patch on branch bug_11944 to see the tests pass. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 13:23:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 12:23:28 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #65 from Jonathan Druart --- I have just updated 2 sandboxes and got: DBD::mysql::db do failed: Can't create table 'test16.items_search_fields' (errno: 150) at installer/data/mysql/updatedatabase.pl line 8991. Upgrade to 3.17.00.046 done (Bug 11425: Add items_search_fields table) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 13:23:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 12:23:59 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #254 from Jonathan Druart --- sandboxes 6 and 16 updated with last patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 13:54:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 12:54:36 +0000 Subject: [Koha-bugs] [Bug 13391] New: MARC 008 builder plugin not compatible with browser autocompletion Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13391 Bug ID: 13391 Summary: MARC 008 builder plugin not compatible with browser autocompletion Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: abl at biblos.pk.edu.pl QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In the koha-tmpl/intranet-tmpl/prog/en/js/xmlControlfield.js (line 317) there are two JS events (onkeyup and onfocus) being handled for 008 MARC plugin fields (for MARC21 008 plugin, is used e.g. for dates, country codes and language codes). But there is a slight problem with onkeyup event handler: apparently this event does not fire when: - user starts to enter some characters using the keyboard, - and then chooses something from the autocompletion list offered by browser. End result is that in such circumstances only the first character[s] entered in the given field are saved in 008 (only the part that was typed on the keyboard), and the remaining characters are effectively lost / being ignored by 008 plugin (unless the user "returns" to this field, i.e. gives it focus once again, before clicking "OK"). Replacing 'onkeyup' with 'oninput' in line 317 looks like the easiest solution for this issue; it works fine in recent (HTML5 compliant) browsers, but OnInput event handler is relatively new thing - it would not work in old, "legacy" WWW browsers. I guess we can also add autocomplete='off' to the fields generated by renderPositions() function in xmlControlfield.js ;). I'm wondering what would happen if we try to put both oninput=.. and onkeyup= event handlers in those fields (probably both of them would fire when user enters something, but maybe that will be not necessarily such a bad thing ?). However, none of those methods are quite sufficient for older browsers. Reparsing all fields on form submit may help a little bit - so changes in the entered values which may have been previously ignored by the plugin would have a chance to be saved in 008 after all - but that's only a partial solution, the 008 contents being displayed on top may still sometimes get "out of sync" with the individual values below.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 14:11:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 13:11:21 +0000 Subject: [Koha-bugs] [Bug 13391] MARC 008 builder plugin not compatible with browser autocompletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13391 --- Comment #1 from M. de Rooy --- Hi Jacek, I am soon submitting code for report 10480. It will address these problems more generally, also allowing key and mouse events handling via jquery code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 14:14:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 13:14:04 +0000 Subject: [Koha-bugs] [Bug 13391] MARC 008 builder plugin not compatible with browser autocompletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13391 --- Comment #2 from M. de Rooy --- (In reply to M. de Rooy from comment #1) > Hi Jacek, > I am soon submitting code for report 10480. > It will address these problems more generally, also allowing key and mouse > events handling via jquery code. Maybe I was reading too fast.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 14:18:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 13:18:42 +0000 Subject: [Koha-bugs] [Bug 11927] Add greek chr lang_def file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26165|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 14:19:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 13:19:26 +0000 Subject: [Koha-bugs] [Bug 11927] Add greek chr lang_def file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927 --- Comment #5 from Fridolin SOMERS --- Created attachment 34118 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34118&action=edit Greek ISO2709 records sample -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 14:53:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 13:53:39 +0000 Subject: [Koha-bugs] [Bug 13391] MARC 008 builder plugin not compatible with browser autocompletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13391 --- Comment #3 from M. de Rooy --- (In reply to Jacek Ablewicz from comment #0) > In the koha-tmpl/intranet-tmpl/prog/en/js/xmlControlfield.js (line 317) The code is used in two templates for marc21 006 and 008. At first glance it looks like overcomplicated design. > End result is that in such circumstances only the first character[s] entered > in the given field are saved in 008 (only the part that was typed on the > keyboard), and the remaining characters are effectively lost / being ignored > by 008 plugin (unless the user "returns" to this field, i.e. gives it focus > once again, before clicking "OK"). Could you automate that workaround? > However, none of those methods are quite sufficient for older browsers. How far should we go? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 14:59:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 13:59:39 +0000 Subject: [Koha-bugs] [Bug 13290] Add better feedback for returns to the checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13290 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 14:59:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 13:59:41 +0000 Subject: [Koha-bugs] [Bug 13290] Add better feedback for returns to the checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13290 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33766|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 34119 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34119&action=edit Bug 13290 - Add better feedback for returns to the checkouts table The feedback given when returning an item is only to update the "Check in" column. It would be nice if the entire column was highlighted in some way so librarians have an easier time spotting which items were checked in and which ones failed to be checked in. Test Plan: 1) Apply this patch 2) Browse to a patron with checkouts 3) Return an item using the checkouts table 4) Note if the return was successful, the row is highlighted in yellow, if the return was not allowed, the row is highlighted in red. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 15:00:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 14:00:08 +0000 Subject: [Koha-bugs] [Bug 13290] Add better feedback for returns to the checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13290 --- Comment #8 from Kyle M Hall --- Fixed! (In reply to Christopher Brannon from comment #6) > While this patch applies the highlighting to all items returned at the same > time, it only changes the due date in the due date column on the last item > in the list. The due date of all other items returned at the same time are > left as due dates. > > Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 15:17:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 14:17:44 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #41 from Jonathan Druart --- (In reply to Zeno Tajoli from comment #32) > No, I never see it. Attention that the patch doesn't modify > t/db_dependent/www/batch.t. And to use it (and batch.t) you need a working > installation. > > If you go to http://pro.koha-qa.vm you see a intranet login form ? Sorry, silly me. /etc/hosts was not set correctly. I added 2 followups and sign yours off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 15:20:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 14:20:15 +0000 Subject: [Koha-bugs] [Bug 11927] Add greek support to CHR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add greek chr lang_def file |Add greek support to CHR -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 15:36:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 14:36:42 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #583 from Jonathan Druart --- Super quick look: 1/ TableTool: Could you explain what is the goal of this plugin (I just have seen a (+) with a 'print receipt' button)? All the files included are needed (html?) 2/ It seems that some tests are missing (AddIssue and AddReturn for instance) 3/ Is this patch set introduced changes compared to master or it's just a rewrite? 4/ What's the interest of splitting pl in 2 files (*_go.pl)? I am really not sure it's useful. (The updatedatabase.pl changes are not at the right place (not at the end)) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 15:39:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 14:39:43 +0000 Subject: [Koha-bugs] [Bug 11927] Add greek support to CHR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26166|0 |1 is obsolete| | --- Comment #6 from Fridolin SOMERS --- Created attachment 34120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34120&action=edit Bug 11927 - Add gr install option Add greek as lang definition in installer. Developped in collaboration with Giannis Kourmoulis Test plan : - Install using "gr" in "Primary language for Zebra indexing" - check gr is used in etc/zebradb/zebra-*.cfg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 15:39:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 14:39:53 +0000 Subject: [Koha-bugs] [Bug 11927] Add greek support to CHR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927 --- Comment #7 from Fridolin SOMERS --- Created attachment 34121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34121&action=edit Bug 11927 - Add greek chr lang_def file Add the sort-string-utf.chr for sorting Greek catalog (it can also contain latin records). Developped in collaboration with Giannis Kourmoulis Test plan : - Install using "gr" in "Primary language for Zebra indexing" - Index a greek catalog - Sort by title and check sorting is correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 15:40:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 14:40:02 +0000 Subject: [Koha-bugs] [Bug 11927] Add greek support to CHR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927 --- Comment #8 from Fridolin SOMERS --- Created attachment 34122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34122&action=edit Bug 11927 - Add greek to word-phrase-utf.chr Add greek support in word-phrase-utf.chr for searching in a Greek catalog (it can also contain latin records). Developped in collaboration with Giannis Kourmoulis Test plan : - Install using CHR zebra indexing - Index a greek catalog - Look for results with mixed uppercase, lowercase and diacritics in title -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 15:40:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 14:40:12 +0000 Subject: [Koha-bugs] [Bug 11927] Add greek support to CHR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927 --- Comment #9 from Fridolin SOMERS --- Created attachment 34123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34123&action=edit Bug 11927 - Small corrections on word-phrase-utf.chr Small fixes : more space characters : ?? uppercase AE missing in equivalent some trailling spaces -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 15:53:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 14:53:13 +0000 Subject: [Koha-bugs] [Bug 13392] New: New statistics wizard for suggestions Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Bug ID: 13392 Summary: New statistics wizard for suggestions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: new feature Priority: P5 - low Component: Reports Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org Statistics wizard for suggestions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 15:55:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 14:55:08 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 --- Comment #1 from Julian Maurice --- Created attachment 34124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34124&action=edit Bug 13392: Add suggestions.ordereddate and suggestions.orderedby Those fields are updated when suggestion status is changed to 'ORDERED' and are displayed on suggestion/suggestion.pl page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 15:55:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 14:55:11 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 --- Comment #2 from Julian Maurice --- Created attachment 34125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34125&action=edit Bug 13392: New statistics assistant for suggestions New sub C4::Budgets::GetBudgetDescendantsIds (with unit tests) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 15:56:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 14:56:49 +0000 Subject: [Koha-bugs] [Bug 11927] Add greek support to CHR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #10 from Fridolin SOMERS --- I've revised patches and add greek support to word-phrase-utf.chr (used in zebra CHR indexing mode). It allows to search using greek characters. In some case, the use of ICU (translitteration) is unwanted because it returns too much results in a mixed greek/latin catalog. I've set in mapping sigma forms '?' and '?' equivalent to '?'. So one may use (even its not correct) '?' instead of '?'. Sort sorting purposes, sort-string-utf.chr defines some prefixes that should be ignored during sorting. For example in English "the, a, an ...". I've defined a few definite articles (from http://en.wikipedia.org/wiki/Ancient_Greek_grammar#Definite_article). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 16:00:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 15:00:27 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #3 from Julian Maurice --- Test plan: 1/ Go to Reports > Statistics wizard > Suggestions 2/ Play with it and check if result is consistent with what you have in your database. All fields used in this wizard correspond to a column in the suggestions table, except for categorycode, sort1 and sort2, which correspond to the borrowers fields of the user who made the suggestion (suggestedby). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 16:06:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 15:06:35 +0000 Subject: [Koha-bugs] [Bug 12059] Publisher code always empty on invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12059 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 16:06:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 15:06:37 +0000 Subject: [Koha-bugs] [Bug 12059] Publisher code always empty on invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12059 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34088|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 34126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34126&action=edit Bug 12059: Publisher column on invoice page always empty This patch moves the publisher information out of its own always empty column into the Summary column below the title, as it is on other acq pages. The information was never displaying, as publishercode is in biblioitems and that table was not selected by GetInvoiceDetails. Also modified the code to take into account that UNIMARC uses biblioitems.publicationyear and MARC21/NORMARC use bibio.copyrightdate for the copyright year. To test: - create an invoice for records that - have a publication year - have no publication year - have a publisher... - 'finish receiving' and check the invoice summary page ...acqui/invoice.pl?invoiceid=? - Make sure all the information displays now but didn't witout the patch. Signed-off-by: Paola Rossi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 16:06:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 15:06:46 +0000 Subject: [Koha-bugs] [Bug 12059] Publisher code always empty on invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12059 --- Comment #5 from Jonathan Druart --- Created attachment 34127 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34127&action=edit Bug 12059: Prefer to list fields in the query To avoir further issue, it's better to explicitely list the fields we want to retrieve. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 16:10:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 15:10:37 +0000 Subject: [Koha-bugs] [Bug 12565] Acq: Link to basket in breadcrumbs broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12565 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 16:10:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 15:10:40 +0000 Subject: [Koha-bugs] [Bug 12565] Acq: Link to basket in breadcrumbs broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12565 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34055|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 34128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34128&action=edit Bug 12565: Acq: Fix broken link in breadcrumbs The link back to the basket when creating an order by searching for an existing record in the catalog is broken. To test: - Start a new basket - Create a new order line by searching for an existing record in your catalog - Try the link back to the basket from the breadcrumbs at the result list page - Verify that the link is broken - Apply patch and retest Signed-off-by: Paola Rossi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 16:21:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 15:21:13 +0000 Subject: [Koha-bugs] [Bug 9864] systematic searching error : can't call method "raw" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9864 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #12 from Koha Team Lyon 3 --- This problem seems to be resolved in koha 3.18.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 16:26:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 15:26:41 +0000 Subject: [Koha-bugs] [Bug 13393] New: The C4::VirtualShelves::Merge package is empty Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13393 Bug ID: 13393 Summary: The C4::VirtualShelves::Merge package is empty Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org ... and should be removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 16:30:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 15:30:35 +0000 Subject: [Koha-bugs] [Bug 13290] Add better feedback for returns to the checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13290 --- Comment #9 from Christopher Brannon --- Would like to see more specific reason for not being able to return, but that is for another ticket. Works as described. Nice work. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 16:31:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 15:31:57 +0000 Subject: [Koha-bugs] [Bug 13393] The C4::VirtualShelves::Merge package is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13393 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 16:32:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 15:32:25 +0000 Subject: [Koha-bugs] [Bug 13393] The C4::VirtualShelves::Merge package is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13393 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 16:32:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 15:32:28 +0000 Subject: [Koha-bugs] [Bug 13393] The C4::VirtualShelves::Merge package is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13393 --- Comment #1 from Jonathan Druart --- Created attachment 34129 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34129&action=edit Bug 13393: Remove C4::VirtualShelves::Merge This is empty (?) Test plan: git grep 'VirtualShelves::Merge' should not return anything. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 16:32:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 15:32:38 +0000 Subject: [Koha-bugs] [Bug 13290] Add better feedback for returns to the checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13290 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 16:32:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 15:32:40 +0000 Subject: [Koha-bugs] [Bug 13290] Add better feedback for returns to the checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13290 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34119|0 |1 is obsolete| | --- Comment #10 from Christopher Brannon --- Created attachment 34130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34130&action=edit [SIGNED OFF] Bug 13290 - Add better feedback for returns to the checkouts table The feedback given when returning an item is only to update the "Check in" column. It would be nice if the entire column was highlighted in some way so librarians have an easier time spotting which items were checked in and which ones failed to be checked in. Test Plan: 1) Apply this patch 2) Browse to a patron with checkouts 3) Return an item using the checkouts table 4) Note if the return was successful, the row is highlighted in yellow, if the return was not allowed, the row is highlighted in red. Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 16:50:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 15:50:06 +0000 Subject: [Koha-bugs] [Bug 13182] When placing an order from a staged file, check for duplicates, display availability information, choose to overlay matched records. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13182 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |koha at univ-lyon3.fr --- Comment #10 from Koha Team Lyon 3 --- Hi, I'll try to test this patch next thursday (testing party) But now, patch doesn't apply on a sandbox : The sandbox you've requested is not ready. Some problems occurred applying patches from bug 13182:

Something went wrong !

Applying: Bug 13182 - When placing an order from a staged file, check for duplicates, display availability information. fatal: sha1 information is lacking or useless (acqui/addorderiso2709.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 13182 - When placing an order from a staged file, check for duplicates, display availability information. When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 13182 - When placing an order from a staged file, check for duplicates, display availability information, choose to overlay matched records. 33376 - Bug 13182 - When placing an order from a staged file, check for duplicates, display availability information. 33378 - Bug 13182 - Overlay an existing Biblio with the acquired import_record 33379 - Bug 13182 - Remove really dead code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 17:04:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 16:04:13 +0000 Subject: [Koha-bugs] [Bug 9528] Add delivery branch to the place hold display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9528 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #2 from Christopher Brannon --- Owen, When I apply patch and place two holds with different pickup locations, and look at the patron holds, I see a new header column, but no new td column. So I end up with one less column in the table than I do in the header, and the headers are offset starting at the pickup location column. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 17:12:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 16:12:13 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #255 from Paola Rossi --- I've made some tests on the two sandboxes 6 and 16. The issue described on bug 11515 is still fixed: everything is OK imo. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 17:30:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 16:30:17 +0000 Subject: [Koha-bugs] [Bug 13231] ISBD/AACR2 punctuation causes double facets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13231 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 17:43:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 16:43:15 +0000 Subject: [Koha-bugs] [Bug 13393] The C4::VirtualShelves::Merge package is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13393 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 17:43:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 16:43:17 +0000 Subject: [Koha-bugs] [Bug 13393] The C4::VirtualShelves::Merge package is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13393 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34129|0 |1 is obsolete| | --- Comment #2 from M. de Rooy --- Created attachment 34131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34131&action=edit Bug 13393: Remove C4::VirtualShelves::Merge This is empty (?) Test plan: git grep 'VirtualShelves::Merge' should not return anything. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 17:45:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 16:45:43 +0000 Subject: [Koha-bugs] [Bug 13379] authorised_values.category is varchar(16) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13379 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34089|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 34132 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34132&action=edit [SIGNED-OFF] Bug 13379: Extends authorised_values.category to varchar(32) This patch does 2 things: 1/ It fixes a bug caused by the different data fields used for authorised_values.category and borrower_attribute_types.authorised_value_category (varchar(16) vs varchar(10)). To reproduce: - Create a AV category with a length > 10 - Try to link a patron attribute type with this AV, it won't work. 2/ Extends this field to varchar(32): sometime 16 is not enough to describe something Signed-off-by: Bernardo Gonzalez Kriegel No koha-qa errors. Error reproduced, fixed by patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 17:46:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 16:46:15 +0000 Subject: [Koha-bugs] [Bug 13379] authorised_values.category is varchar(16) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13379 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 18:29:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 17:29:51 +0000 Subject: [Koha-bugs] [Bug 12905] Deleting parent fund will orphan child funds, leaving them un-editable. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12905 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paola.rossi at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 18:31:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 17:31:35 +0000 Subject: [Koha-bugs] [Bug 12905] Deleting parent fund will orphan child funds, leaving them un-editable. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12905 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33474|0 |1 is obsolete| | --- Comment #8 from Paola Rossi --- Created attachment 34133 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34133&action=edit Bug 12905: funds with children could not be deleted On master (head 12123) the problem was still present at my tests. I deleted the parent fund/aqbudget and I still saw the child fund using the MySQL client. In intranet, the child fund was not listed anymore from "Funds" and it could be seen only by this link [X is the budget_id of the aqbudget]: I've applied the patch (head 12123). The patch needed a trivial rebase (on 3.19?). On a parent fund, the "Delete" action: was present in grey, warned "This fund has children." as mouse moved on it; and prevented me from deleting the fund by the message: "This fund has children. It cannot be deleted." when selected. On upgrading the database I saw the check alerting me about my inconsistent data, just as required. Everything seemed OK to me, I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 19:27:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 18:27:30 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #42 from Tom?s Cohen Arazi --- I'd like to mention something you might know, but it is important to test: Most of our encoding problems are related to Perl thinking stuff is ISO-8859-1. If you have pure UTF-8 characters, Perl notices, and sets the UTF-8 flag. We need to test using only latin characters with diacritics [1] to tests that ISO-fallback is not happening. So I'd (kind of) repeat some of the authorized values tests, using latin characters with diacritics (only), like in 'Tom?s'. [1] As the representation for those is the same in Latin-1 and UTF-8 there's no way for Perl to recognise UTF-8 and fallbacks to its default. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 19:46:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 18:46:51 +0000 Subject: [Koha-bugs] [Bug 13394] New: cancel all holds doesn't generate slips Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13394 Bug ID: 13394 Summary: cancel all holds doesn't generate slips Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When you're on the holds over list and you cancel all if it's set to transfer it doesn't generate slips for the items you're transferring so how do you know where the items need to go? It should generate slips like the other transfer functions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 19:56:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 18:56:55 +0000 Subject: [Koha-bugs] [Bug 11706] Typo "efault" in updatedatabase.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11706 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34026|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 34134 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34134&action=edit [SIGNED-OFF] Bug 11706: Typo fix for "efault" in old database update To test: - Verify the typo has been correct and no other changes have been made Signed-off-by: Bernardo Gonzalez Kriegel Typo fixed, no koha-qa errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 19:57:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 18:57:12 +0000 Subject: [Koha-bugs] [Bug 11706] Typo "efault" in updatedatabase.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11706 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 20:36:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 19:36:53 +0000 Subject: [Koha-bugs] [Bug 13394] cancel all holds doesn't generate slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13394 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #1 from Christopher Brannon --- Not just with the Cancel All, but with individual cancels. Specifically, I found the following: * Transfers without holds do not generate any kind of slip or notice. * Transfers with hold at another location - Show the home library instead of the pickup library on the button. - Displays a notice to check the item in to fill the hold. - After pressing OK on the above message, a transfer is initiated, but there is no way to know. No slip or message. - When you check the item in, you see a transfer in progress for the above action to the patron the item is on hold for to the pickup library. You also get a notice of the hold, and the option to trigger it. So it is pulling double duty and double messages to go to the same place. * The Cancel all button is dangerous, if you don't have the items in hand. This should have a preference or permission. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 20:42:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 19:42:35 +0000 Subject: [Koha-bugs] [Bug 12450] Closing libraries for the summer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12450 --- Comment #4 from Christopher Brannon --- (In reply to Magnus Enger from comment #3) > I'm starting to work on this now. I'll link to some code and a demo in a day > or two. Checking to see whatever came of this. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 20:43:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 19:43:59 +0000 Subject: [Koha-bugs] [Bug 12365] Notes for rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 --- Comment #1 from Christopher Brannon --- Same would go for preference settings. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 21:09:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 20:09:16 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 --- Comment #80 from mathieu saby --- (In reply to Paola Rossi from comment #79) > (In reply to mathieu saby from comment #78) > > In fact bug 12853 has nothing to do with this one, BUT bug 7162 (passed QA) > > will have aftereffects, as it rewrites DelOrder. > > So, I'll take a look again when bug 7162 is pushed > > > > M. Saby > > Hi Mathieu, > > the bug 7162 has been pushed to master. What about this bug now? Hello I probably won't have time before february :( Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 21:10:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 20:10:24 +0000 Subject: [Koha-bugs] [Bug 10891] Make facets customisable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10891 --- Comment #31 from mathieu saby --- (In reply to Tom?s Cohen Arazi from comment #30) > (In reply to mathieu saby from comment #29) > > Hi > > I stopped working on that when bug 11232 was created, because I feared a big > > conflict. But nothing is still to test on that bug :( > > We could also wait to see the work on Elasticsearch. > > Anyway, I'm not working actively on Koha anymore, so I won't propose a patch > > for bug 10891, but we can keep the bug open, because I still think it would > > be a nice enhancement. > > > > Mathieu > > Mathieu, don't you want to come back? :-D Sorry, i won't have time for that. But please keep the bug open if somebody wants to add a patch ;-) I still think it would be a nice improvement Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 21:41:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 20:41:21 +0000 Subject: [Koha-bugs] [Bug 13395] New: Search Patrons on the home page fails on Firefox 34.0 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13395 Bug ID: 13395 Summary: Search Patrons on the home page fails on Firefox 34.0 Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: bob-ewart at bobsown.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com I updated Koha last night on Xubuntu 14.04 LTS using the PPA. . Using the 'Search patrons' tab on the home page fails on Firefox 34.0. On Firefox 33.0, it works. On Firefox 34.0 the web console shows: Empty string passed to getElementById(). jquery.js:2 Use of getPreventDefault() is deprecated.Use defaultPrevented instead jquery:js:3 TypeError: c is undefined query.dataTables.min.js:65 That last line has a pink background. On Firefox 33.0, which works, the web console shows: Use of getPreventDefault() is deprecated.Use defaultPrevented instead.jquery.js:3 window.controllers is deprecated. Do not use it for UA detection nsHeaderInfo.js412 Empty string passed to getElementById() query.js:2 As a work around, you can search using the 'Check out' tab on the home page and then clicking on the "Details" tab. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 21:42:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 20:42:00 +0000 Subject: [Koha-bugs] [Bug 13395] Search Patrons on the home page fails on Firefox 34.0 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13395 Bob Ewart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob-ewart at bobsown.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 21:53:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 20:53:27 +0000 Subject: [Koha-bugs] [Bug 13395] Search Patrons on the home page fails on Firefox 34.0 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13395 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 21:53:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 20:53:37 +0000 Subject: [Koha-bugs] [Bug 13395] Search Patrons on the home page fails on Firefox 34.0 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13395 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.18 |master Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 4 23:50:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Dec 2014 22:50:31 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #2 from Nick Clemens --- Any of these fields marked with second indicator 2 represent works that are contained by the title so maybe: Display all 700, 710 and 711?s with a second indicator 2 as Contained Works (full display) Contained Works: Adams, Douglas. Hitchikers guide to the galaxy | Adams, Douglas. The restaurant at the end of the universe ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 06:20:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 05:20:58 +0000 Subject: [Koha-bugs] [Bug 5517] After removal of koha-common package in Debian Squeeze cron jobs are not deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5517 Stephen Warren changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |swarren at wwwdotorg.org --- Comment #5 from Stephen Warren --- apt-get remove isn't supposed to remove config files, only binary files. /etc/cron.d/koha-common is a config file, so this is expected. Reference: http://linuxprograms.wordpress.com/2010/05/12/dpkg-purge-versus-remove/ (and I'm sure there are other more authoritative sources; that's just the first thing I found via Google) Note that this does mean the content of /etc/cron.d/koha-common has a bug; in 3.18 at least, one of the entries protects against that situation when the command it's going to execute is not executable (which covers when it's missing): */5 * * * * root test -x /usr/sbin/koha-rebuild-zebra && koha-rebuild-zebra -q $(koha-list --enabled) However, the other entry doesn't, so will likely cause permission denied or file not found errors if the package is removed not purged: */15 * * * * root koha-foreach --enabled --email /usr/share/koha/bin/cronjobs/process_message_queue.pl That command should probably have a "test -x XXX &&" prefix. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 06:51:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 05:51:18 +0000 Subject: [Koha-bugs] [Bug 13396] New: koha-rebuild-zebra: Couldn't open collection.abs error after 3.18 package update Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13396 Bug ID: 13396 Summary: koha-rebuild-zebra: Couldn't open collection.abs error after 3.18 package update Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: swarren at wwwdotorg.org QA Contact: testopia at bugs.koha-community.org After the upgrade to 3.18 (auto package update from the repo...), cron spits out errors such as the following every 5 minutes (or perhaps every 5 minutes when there's new data?): Subject: Cron test -x /usr/sbin/koha-rebuild-zebra && koha-rebuild-zebra -q $(koha-list --enabled) 14:10:03-03/12 zebraidx(27193) [warn] Couldn't open collection.abs [No such file or directory] 14:10:03-03/12 zebraidx(27193) [warn] Record didn't contain match fields in (bib1,Local-number) I can reproduce this by running koha-rebuild-zebra directly: root at leibniz:/etc/koha# koha-rebuild-zebra -f -v library ...(elided) ........................ Records exported: 553 ==================== REINDEXING zebra ==================== 22:43:52-04/12 zebraidx(9338) [warn] Couldn't open collection.abs [No such file or directory] 22:43:58-04/12 zebraidx(9338) [warn] Record didn't contain match fields in (bib1,Local-number) ==================== CLEANING ...(continues) After some Google searching, I wonder if this is because I created /etc/koha/sites/library/koha-conf.xml using a previous version of Koha, and now extra parameters are required? I found some previous discussion of similar problems: http://irc.koha-community.org/koha/2013-10-14 (search for zebra_bib_index_mode) ... which triggered me to look at the differences between /etc/koha/sites/library/koha-conf.xml and /etc/koha/sites/library/koha-conf.xml. One thing I found was: + __BIBLIOS_INDEXING_MODE__ + __AUTHORITIES_INDEXING_MODE__ + /var/lock/koha/__KOHASITE__ + 1 Do I need to add those to /etc/koha/sites/library/koha-conf.xml? If so, shouldn't the new Koha version add these values automatically, or act as if they were present but set to a value that's compatible with the previous versions' behaviour? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 07:32:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 06:32:02 +0000 Subject: [Koha-bugs] [Bug 13395] Search Patrons on the home page fails on Firefox 34.0 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13395 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- I could not reproduce the issue on Firefox 34.0 (Windows 8) with current master (3.19.00.000) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 09:39:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 08:39:02 +0000 Subject: [Koha-bugs] [Bug 13397] New: Move HTML out of C4::Items::PrepareItemrecordDisplay Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13397 Bug ID: 13397 Summary: Move HTML out of C4::Items::PrepareItemrecordDisplay Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Proposing to do this as a follow-up for bug 10480. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 09:59:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 08:59:15 +0000 Subject: [Koha-bugs] [Bug 12450] Closing libraries for the summer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12450 --- Comment #5 from Magnus Enger --- (In reply to Christopher Brannon from comment #4) > Checking to see whatever came of this. :) Thanks for checking! :-) I have been working on this, but I started out in the wrong direction so things have taken longer than expected. Another obstacle is that bug 11211 and bug 8133 change a lot of code in relevant areas of Koha, so I have been trying to push those forward before I really start working on the present bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 09:59:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 08:59:21 +0000 Subject: [Koha-bugs] [Bug 13398] New: Perl files for rotating collections are missing in debian package Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13398 Bug ID: 13398 Summary: Perl files for rotating collections are missing in debian package Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz In Koha 3.18 installed from Debian package are missing all 4 perl script for rotating collections. I've extracted the .deb file and these files are missing there too. Template files are OK. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 10:15:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 09:15:10 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34125|0 |1 is obsolete| | --- Comment #4 from Julian Maurice --- Created attachment 34135 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34135&action=edit Bug 13392: New statistics assistant for suggestions New sub C4::Budgets::GetBudgetDescendantsIds (with unit tests) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 10:19:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 09:19:05 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34135|0 |1 is obsolete| | --- Comment #5 from Julian Maurice --- Created attachment 34136 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34136&action=edit Bug 13392: New statistics assistant for suggestions New sub C4::Budgets::GetBudgetDescendantsIds (with unit tests) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 10:21:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 09:21:15 +0000 Subject: [Koha-bugs] [Bug 13307] Create a link to the last advanced search in search result page (OPAC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #9 from Marc V?ron --- I like this feature. However I found the following: 1) Search e.g. for Author = Goethe and Title = Faust 2) The link back to the last advanced search appears as expected. 3) After clicking the link, I get the advanced search page with Keyword = Goethe and Keyword = Faust (instead of Author and Title) Marc PS: Applying patch did a 3-way-merge -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 10:27:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 09:27:58 +0000 Subject: [Koha-bugs] [Bug 13399] New: Select a department: empty field if no description set in authorized value Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 Bug ID: 13399 Summary: Select a department: empty field if no description set in authorized value Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org When you set up an authorized value in the DEPARTMENT category without descriptions, the pull down menu in course creation shows an empty value. It should instead fall back to the name of the authorized value. 1. Set up an authorized value in the DEPARTMENT category. Leave description fields empty. 2. Go to Course reserves, Create course. 3. Open the ?Select a department? pull down menu, observe that there is no description Expected: display the name of the authorized value if no description is given. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 10:43:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 09:43:35 +0000 Subject: [Koha-bugs] [Bug 12895] Dropbox mode doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12895 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #1 from Koha Team Lyon 3 --- Created attachment 34137 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34137&action=edit Bug 12895 repair dropbox mode Dropbox mode as it is will be modified (cf bug 13044) but the problem will have nevertheless to be corrected. This patch can be applied to last version and previous ones. One thing important to be aware of about restriction is that the last restriction day IS NOT included. A patron restricted until such day will be able to borrow again FROM that day. Test plan : 1) choose a borrower and an item and checkout the item selecting the previous opening date in the Specify-due-date box. 2) click on Circulation in the upper manu, then on Checkin and check the Book drop mode. The Book drop date showed should be the previous opening date. 3) Check in the item : you can see that the patron is restricted 4) apply the patch 5) redo 1 to 3 : Now, you can see that the patron is not restricted. 6) If you redo the test with two day late, you will see that the patron is not restricted : that's ok because his restriction of one day is already finished. 7) If you redo the test with more than two day late, you see that the patron restriction is, as expected, one day shorter than it were if the item had been returned without dropbox mode. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 10:48:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 09:48:15 +0000 Subject: [Koha-bugs] [Bug 12895] Dropbox mode doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12895 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Status|NEW |Needs Signoff --- Comment #2 from Koha Team Lyon 3 --- I put the importance level to P1 because I thing this problem may be source of litigation with patrons -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 10:57:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 09:57:53 +0000 Subject: [Koha-bugs] [Bug 13044] Deprecate old book drop mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13044 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12895 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 10:57:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 09:57:53 +0000 Subject: [Koha-bugs] [Bug 12895] Dropbox mode doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12895 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13044 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 11:33:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 10:33:52 +0000 Subject: [Koha-bugs] [Bug 7741] Clear search terms in Z3950 search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7741 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #5 from Marc V?ron --- The patch displays "Clear Search Form" on Authorities search only: /koha/cataloguing/z3950_auth_search.pl (Home:Authorities:New from Z39.50) Is it possible to have it on other Z39.50/SRU pages as well? /koha/cataloguing/z3950_search.pl (Home:Cataloging:New from Z39.50/SRU) and /koha/acqui/z3950_search.pl (Home:Acquisitions:[Bookshop]:[Basket]:Order from external source) Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 12:29:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 11:29:49 +0000 Subject: [Koha-bugs] [Bug 13391] MARC 008 builder plugin not compatible with browser autocompletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13391 --- Comment #4 from Jacek Ablewicz --- Created attachment 34138 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34138&action=edit Bug 13391 - MARC 008 builder plugin not compatible with browser autocompletion In the koha-tmpl/intranet-tmpl/prog/en/js/xmlControlfield.js (currently used by 006 and 008 MARC21 plugins), in line 317 there are two JS events (onkeyup and onfocus) associated with fields. But there is a slight problem with onkeyup event handler, apparently this event does not fire when: - user starts to enter some characters using the keyboard, - and then chooses something from the autocompletion list offered by browser. In such circumstances only the first character[s] entered in the given field are saved in 006 and/or 008 (only the part that was typed on the keyboard), and the remaining characters are effectively being ignored. This patch adds two additional event handlers to the fields generated by the renderPositions() function in xmlControlfield.js: oninput (that should completely solve the problem for recent, HTML5-compliant browsers) and onblur (that, while not being quite satisfactory solution, should at least somehow improve things for old/lagacy WWW browsers as well). To test: - reproduce the aforementioned issue (try to enter some data into e.g. "country code" / 15-17 positions in the 008 MARC21 plugin: first using only the keyboard, and then by the means of the browser autocomplete) - observe that when the value is choosen from the autocompletion list, only the 1st part of it is being stored in the respective 008 field positions on the top - apply patch - clear browser cache - retest (preferably using some modern WWW browser first, and then something much older and inherently broken like IE7 or IE8 etc.) - make sure there are no aparent regresions of any kinds regarding 006 and 008 MARC21 plugins behaviour. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 12:30:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 11:30:05 +0000 Subject: [Koha-bugs] [Bug 13400] New: Untranslatable "Are you sure you want to delete this authority?" Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13400 Bug ID: 13400 Summary: Untranslatable "Are you sure you want to delete this authority?" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Untranslatable javascript text: authorities/searchresultlist.tt: var is_confirmed = confirm('Are you sure you want to delete this authority?'); authorities/detail.tt: var is_confirmed = confirm('Are you sure you want to delete this authority?'); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 12:31:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 11:31:00 +0000 Subject: [Koha-bugs] [Bug 13391] MARC 008 builder plugin not compatible with browser autocompletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13391 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|gmcharlt at gmail.com |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 12:54:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 11:54:05 +0000 Subject: [Koha-bugs] [Bug 13391] MARC 008 builder plugin not compatible with browser autocompletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13391 --- Comment #5 from Jacek Ablewicz --- (In reply to M. de Rooy from comment #3) > > However, none of those methods are quite sufficient for older browsers. > How far should we go? Hopefully not too far ;). I did some googling, and it turns out that making it work 100% reliably for legacy browser wolud be pretty complicated. For example, there is an YUI module for that (event-valuechange), but it resorts to the timers / pooling methods, which is kind of ugly. So in the submitted patch I simply added two event handlers (oninput= and onblur=) - unless I'm very much mistaken, 1st should solve the problem for modern browsers, and the 2nd improve it a little bit for older ones. There is a little drawback though: in the modern browser, the same event handling code will now be executed (up to) 3 times when the user changes something in the given plugin field. It doesn't seem to cause any noticeable issues performance-wise, but sill.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 14:53:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 13:53:13 +0000 Subject: [Koha-bugs] [Bug 7741] Clear search terms in Z3950 search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7741 Tom M changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34079|0 |1 is obsolete| | --- Comment #6 from Tom M --- Created attachment 34139 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34139&action=edit Z39.50 Clear Search Fields Patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 14:56:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 13:56:21 +0000 Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34090|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 34140 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34140&action=edit Bug 13380: Fill order cancellation reasons from AV Since bug 7162, it's possible to give a cancellation reason on deleting an order. This would be better to fill an authorised values category with the different possible values. Like that we will avoid to have duplicate or similar reasons. Also, it will be easier to filter or create reports. Test plan: 0/ Don't apply the patch 1/ Cancel some orders and give a cancelletion reason 2/ Apply the patch and execute the updatedb entry 3/ Cancel an order and verify the you have a list with the reason you previously filled + 3 new ones ('No reason', 'Sold out' and 'Restocking'); 4/ Choose one and verify the value is correctly displayed on the basket page 5/ You can also try to add other values from the admin module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 15:00:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 14:00:29 +0000 Subject: [Koha-bugs] [Bug 13401] New: sort branches alphabetically in admin/authorised_values.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13401 Bug ID: 13401 Summary: sort branches alphabetically in admin/authorised_values.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Sort branches alphabetically by name in authorised values administration, like in many other pages -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 15:13:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 14:13:29 +0000 Subject: [Koha-bugs] [Bug 7741] Clear search terms in Z3950 search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7741 --- Comment #7 from Marc V?ron --- Created attachment 34141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34141&action=edit [Signed-off] Added Clearing Capability to the Z39.50 Search fields http://bugs.koha-community.org/show_bug.cgi?id=7741 Tested in: /koha/cataloguing/z3950_auth_search.pl (Home:Authorities:New from Z39.50) /koha/cataloguing/z3950_search.pl (Home:Cataloging:New from Z39.50/SRU) /koha/acqui/z3950_search.pl (Home:Acquisitions:[Bookshop]:[Basket]:Order from external source) All three forms can now be cleared. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 15:14:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 14:14:40 +0000 Subject: [Koha-bugs] [Bug 13401] sort branches alphabetically in admin/authorised_values.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13401 Koha Team AMU changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.aixmarseille at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 15:15:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 14:15:04 +0000 Subject: [Koha-bugs] [Bug 7741] Clear search terms in Z3950 search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7741 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34139|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 15:16:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 14:16:41 +0000 Subject: [Koha-bugs] [Bug 7741] Clear search terms in Z3950 search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7741 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 15:17:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 14:17:46 +0000 Subject: [Koha-bugs] [Bug 13379] authorised_values.category is varchar(16) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13379 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13380 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 15:17:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 14:17:46 +0000 Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13379 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 15:22:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 14:22:05 +0000 Subject: [Koha-bugs] [Bug 9828] Zebra indexes useless subfields in UNIMARC 6XX In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9828 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #56 from Paul Poulain --- (In reply to Tom?s Cohen Arazi from comment #54) > I'm failing this one so maybe any MARC21/NORMARC dev can do the changes > needed for them. > I'll try to, but not sure i'll have the time. Tomas, I don't understand what you mean here. In my comment 30, I pointed that this patch ALSO fixed some MARC21/NORMAC errors, not that it need some work to fix MARC21/NORMAC errors ! So ? (back to passed QA because this patch is really useful for UNIMARC !) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 15:24:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 14:24:58 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 rgravel at marlboro.edu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rgravel at marlboro.edu --- Comment #3 from rgravel at marlboro.edu --- Please note that the last example in the contributor(s) description does not apply. I support Nick's addition; it would be great to capture those analytical entries, as well as the added entries and relationships documented in these fields: 700/710/711 x_ - Contributor(s) 700/710/711 x_ $i - Related Works 700/710/711 x2 - Contained Works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 15:50:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 14:50:08 +0000 Subject: [Koha-bugs] [Bug 13393] The C4::VirtualShelves::Merge package is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13393 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 15:50:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 14:50:10 +0000 Subject: [Koha-bugs] [Bug 13393] The C4::VirtualShelves::Merge package is empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13393 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34131|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 34142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34142&action=edit [PASSED QA] Bug 13393: Remove C4::VirtualShelves::Merge This is empty (?) Test plan: git grep 'VirtualShelves::Merge' should not return anything. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 15:55:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 14:55:19 +0000 Subject: [Koha-bugs] [Bug 13379] authorised_values.category is varchar(16) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13379 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 15:55:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 14:55:22 +0000 Subject: [Koha-bugs] [Bug 13379] authorised_values.category is varchar(16) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13379 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34132|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 34143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34143&action=edit [PASSED QA] Bug 13379: Extends authorised_values.category to varchar(32) This patch does 2 things: 1/ It fixes a bug caused by the different data fields used for authorised_values.category and borrower_attribute_types.authorised_value_category (varchar(16) vs varchar(10)). To reproduce: - Create a AV category with a length > 10 - Try to link a patron attribute type with this AV, it won't work. 2/ Extends this field to varchar(32): sometime 16 is not enough to describe something Signed-off-by: Bernardo Gonzalez Kriegel No koha-qa errors. Error reproduced, fixed by patch. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 15:58:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 14:58:00 +0000 Subject: [Koha-bugs] [Bug 13375] Syspref search highlight styling broken in Chrome In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13375 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 15:58:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 14:58:02 +0000 Subject: [Koha-bugs] [Bug 13375] Syspref search highlight styling broken in Chrome In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13375 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34093|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 34144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34144&action=edit [PASSED QA] Bug 13375: Syspref search highlight styling broken in Chrome This patch encloses the the syspref description/values mix in a
. It doesn't introduce any regression on other browsers (like Firefox) and has the side effect to make Chrome render the highlighted words on syspref searches well. This alternate patch uses a
instead of a because it will sometimes contain block-level elements. Follow the same plan: To test: - Search for 'facet' on the sysprefs => FAIL: verify it has styling problems in Chrome - Apply the patch, reload => SUCCESS: styling is correct Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:00:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:00:39 +0000 Subject: [Koha-bugs] [Bug 13370] Inputs overflow in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13370 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:00:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:00:41 +0000 Subject: [Koha-bugs] [Bug 13370] Inputs overflow in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13370 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34068|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 34145 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34145&action=edit [PASSED QA] Bug 13370: Inputs overflow in filter Bug 12376 adds some padding to inputs. This cause an overflow on the record detail page. Test plan: 1/ Go on a record detail page with items 2/ Enable filters Without the patch, the inputs overflow, with the patch it should be corrected (as before bug 12376). Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:02:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:02:54 +0000 Subject: [Koha-bugs] [Bug 13369] [Datatables] tr and td are not correctly highlighted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13369 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:02:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:02:50 +0000 Subject: [Koha-bugs] [Bug 13401] sort branches alphabetically in admin/authorised_values.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13401 --- Comment #1 from Fridolin SOMERS --- Created attachment 34146 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34146&action=edit Bug 13401 - sort branches alphabetically in admin/authorised_values.pl This patch adds a sort of branches alphabetically by name in authorised values administration, like in many other pages. Also replaces var $branch (too ambigus) by $branchcode. Test plan : - Create 2 branches : code=AAA,name=Zbranch and code=ZZZ,name=Abranch - Create a new authorized value : admin/authorised_values.pl - Look at "Libraries limitation" : => Without patch branches are sorted by code : Zbranch then Abranch => Without patch branches are sorted by name : Abranch then Zbranch - Select a branch and save - Re-edit => Check the same branch is selected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:02:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:02:57 +0000 Subject: [Koha-bugs] [Bug 13369] [Datatables] tr and td are not correctly highlighted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13369 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34078|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 34147 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34147&action=edit [PASSED QA] Bug 13369: table should been highlighted correctly when row are grouped The css used to highlight the rows comes from staff-global.css We need a more specific rule to be used. Test plan: Go on the fund list view and confirm that the rows are correctly highlighted. Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:05:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:05:16 +0000 Subject: [Koha-bugs] [Bug 13401] sort branches alphabetically in admin/authorised_values.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13401 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:05:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:05:32 +0000 Subject: [Koha-bugs] [Bug 13401] sort branches alphabetically in admin/authorised_values.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13401 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |fridolyn.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:06:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:06:15 +0000 Subject: [Koha-bugs] [Bug 13368] Checking out an item not on loan, but with a hold, busts the holds priority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13368 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:06:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:06:19 +0000 Subject: [Koha-bugs] [Bug 13368] Checking out an item not on loan, but with a hold, busts the holds priority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13368 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34064|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 34148 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34148&action=edit [PASSED QA] Bug 13368 Holds priority messed up on checkout To Test 1/ Create 3 (or more holds) on one biblionumber, make sure at least one item is not on loan 2/ Check out the not on loan item to a borrower (maybe number 2 in the queue) 3/ Look in the database (or on the holds tab on the moredetail.pl) notice the priorities have not been reordered 4/ Apply patch and try again, notice now they have Signed-off-by: Owen Leonard Confirmed the problem without the patch, and confirmed that the patch corrects it. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:08:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:08:29 +0000 Subject: [Koha-bugs] [Bug 13355] System preferences tab value wrong in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13355 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:08:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:08:31 +0000 Subject: [Koha-bugs] [Bug 13355] System preferences tab value wrong in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13355 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34006|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 34149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34149&action=edit [PASSED QA] Bug 13355: System preferences tab value wrong in templates This patch fixes a bug on the system preferences tab templates. To test: To reproduce: (1) - Choose a tab on the sysprefs section (for example 'Enhanced Content') - Right click on 'Enhanced Content preferences' title, and choose to 'inspect' the code => FAIL: you will see below the form tag something like: (2) - Do a syspref search (for example 'facet'). - Right click on one of the category titles (for example 'OPAC preferences') => FAIL: you will see below the form tag something like: - Apply the patch - Repeat (1) and (2) => SUCCESS: you will see below the form tag something like: and respectively. - Sign off :-D Regards Signed-off-by: wajasu Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:09:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:09:03 +0000 Subject: [Koha-bugs] [Bug 13336] Add time to date column for patron circulation history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13336 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:10:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:10:25 +0000 Subject: [Koha-bugs] [Bug 13318] C4::Acq::GetParcel is not used and can be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13318 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:10:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:10:27 +0000 Subject: [Koha-bugs] [Bug 13318] C4::Acq::GetParcel is not used and can be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13318 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34011|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 34150 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34150&action=edit [PASSED QA] Bug 13318: Delete C4::Acq::GetParcel Test plan: git grep GetParcel should not return use of this subroutine. Signed-off-by: wajasu Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:20:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:20:50 +0000 Subject: [Koha-bugs] [Bug 12428] "OPAC info" is not displayed in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Koha Team AMU changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.aixmarseille at gmail.com --- Comment #12 from Koha Team AMU --- I applied and tested this patch on a sandbox. It works like expected. But I was not able to change status in "signed off". When I tried, I had the following message "It seems you don't have applied a patch, so you cannot sign it off. If you applied patches from the right report, check the commit message of the last patch. It should start with "Bug XXXXX", if not, please inform the author of the patch." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:21:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:21:46 +0000 Subject: [Koha-bugs] [Bug 13331] Subfield does not show in cataloging editor - if subfield is disabled in OPAC/enabled in Staff, via frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13331 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:21:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:21:48 +0000 Subject: [Koha-bugs] [Bug 13331] Subfield does not show in cataloging editor - if subfield is disabled in OPAC/enabled in Staff, via frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13331 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34007|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 34151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34151&action=edit [PASSED QA] fix for 13331 [Bug 13331] Subfield does not show in cataloging editor - if subfield is disabled in OPAC/enabled in Staff, via frameworks to test... 1/ attempt to add a new bib in the cataloguing editor, default framewok - observe 245b subfield is visible in the editor, for tab 2 2/ uncheck the OPAC visibility for 245b, within the framework editor - then save 3/ repeat step 1/ - observe that the 245b subfield has disappeared from the cataloguing editor! 4/ apply patch, 5/ repeat step 1/ - observe that the 245b subfield now displays correctly in the cataloguing editor note: this looks looks like a typo bug, that has been in koha for years Signed-off-by: wajasu Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:29:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:29:00 +0000 Subject: [Koha-bugs] [Bug 13333] Basket group is not displayed for already received orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13333 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34069|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 34152 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34152&action=edit [PASSED QA] Bug 13333: Fix Display basket group for already received orders Bug 11111 adds a basket group column on the parcel page. But it seems that the already received orders never contain the value (always 'no basket group'). Test plan: Receive an order which is in a basket group and verify the basket group column is correctly filled. Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:28:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:28:58 +0000 Subject: [Koha-bugs] [Bug 13333] Basket group is not displayed for already received orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13333 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:31:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:31:59 +0000 Subject: [Koha-bugs] [Bug 13235] Revise layout of patron search form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:32:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:32:01 +0000 Subject: [Koha-bugs] [Bug 13235] Revise layout of patron search form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34084|0 |1 is obsolete| | Attachment #34085|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 34153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34153&action=edit [PASSED QA] Bug 13235 - Revise layout of patron search form Bug 9811 (Patron search improvements) reversed the layout changes made by Bug 10153. This patch returns to the form to its "stacked" layout. To test, apply the patch and navigate to the Patrons home page. Expand the hidden search fields in the search header and confirm that the layout looks correct. Perform some searches and check that the results are correct and that the modified search fields retain their state. Note: This patch contains indentation changes, so please diff accordingly. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:32:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:32:07 +0000 Subject: [Koha-bugs] [Bug 13235] Revise layout of patron search form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 --- Comment #9 from Kyle M Hall --- Created attachment 34154 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34154&action=edit [PASSED QA] Bug 13235: Move onclick attr to javacsript code Refactor 1 line of code and add a preventDefault. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:34:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:34:39 +0000 Subject: [Koha-bugs] [Bug 13204] Plugin housekeeping: Remove labs_theses.pl plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13204 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:34:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:34:41 +0000 Subject: [Koha-bugs] [Bug 13204] Plugin housekeeping: Remove labs_theses.pl plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13204 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34031|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 34155 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34155&action=edit [PASSED QA] Bug 13204: Plugin housekeeping: Remove labs_theses.pl plugin Passing QA, pending response from Jonathan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:43:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:43:05 +0000 Subject: [Koha-bugs] [Bug 13204] Plugin housekeeping: Remove labs_theses.pl plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13204 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #12 from Jonathan Druart --- Please don't push this for the moment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:43:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:43:15 +0000 Subject: [Koha-bugs] [Bug 13204] Plugin housekeeping: Remove labs_theses.pl plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13204 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|m.de.rooy at rijksmuseum.nl |jonathan.druart at biblibre.co | |m QA Contact|jonathan.druart at biblibre.co | |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:43:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:43:17 +0000 Subject: [Koha-bugs] [Bug 13017] Login page image replacement technique fails when browser width exceeds 2000 pixels In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13017 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:43:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:43:19 +0000 Subject: [Koha-bugs] [Bug 13017] Login page image replacement technique fails when browser width exceeds 2000 pixels In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13017 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34045|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 34156 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34156&action=edit [PASSED QA] Bug 13017 - Login page image replacement technique fails when browser width exceeds 2000 pixels This patch updates the image replacement technique used for Koha's login page. The old technique used a negative text-indent value to move the text offscreen, but that begins to fail more and more often as screens get larger. The new technqiue is described here: http://www.zeldman.com/2012/03/01/replacing-the-9999px-hack-new-image-replacement/ Note: This patch has not been tested in any Internet Explorer version! To test you must have a screen which is wider than 2000 pixels. Apply the patch, clear your browser cache and view the staff client login page. The logo on the login form should look correct with no corresponding text appearing anywhere on the screen. Signed-off-by: Christopher Brannon Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:46:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:46:49 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.meusburger at biblibr | |e.com --- Comment #5 from Matthias Meusburger --- About the baskets filters: If I click on "Show active baskets only" then on "Show opened baskets only" I end up with two "Show all baskets" links one after the other. This is confusing. Imho, it should work this way: Show active baskets only -> click -> Show active and inactive baskets Show opened baskets only -> click -> Show opened and closed baskets This way the user knows exactly what is filtered. About the datatable filters: 'Item count' and 'Biblio count' didn't work for me: "No matching records found" (some records should have matched my search). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:51:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:51:25 +0000 Subject: [Koha-bugs] [Bug 12555] The DelItem subroutine should be called on canceling a receipt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12555 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:51:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:51:28 +0000 Subject: [Koha-bugs] [Bug 12555] The DelItem subroutine should be called on canceling a receipt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12555 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34016|0 |1 is obsolete| | Attachment #34017|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 34157 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34157&action=edit [PASSED QA] Bug 12555: Call DelItem on cancelling a receipt On cancelling a receipt, the items should be deleted using the C4::Items::DelItem subroutine in order to update zebra and sent the items in the deleteditems table. The entries in aqorders_items will automatically deleted by the DBMS (on delete cascade). Test plan: 0/ Set the AcqCreateItem pref to "on receiving" 1/ Create an order with some items 2/ Receive the items 3/ Note the itemnumber in the items table 4/ Cancel the receipt 5/ Verify the itemnumbers are present in the deleteditems table and the items have been deleted. Signed-off-by: Chris Cormack Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:55:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:55:04 +0000 Subject: [Koha-bugs] [Bug 12555] The DelItem subroutine should be called on canceling a receipt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12555 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34157|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 34158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34158&action=edit [PASSED QA] Bug 12555: Call DelItem on cancelling a receipt On cancelling a receipt, the items should be deleted using the C4::Items::DelItem subroutine in order to update zebra and sent the items in the deleteditems table. The entries in aqorders_items will automatically deleted by the DBMS (on delete cascade). Test plan: 0/ Set the AcqCreateItem pref to "on receiving" 1/ Create an order with some items 2/ Receive the items 3/ Note the itemnumber in the items table 4/ Cancel the receipt 5/ Verify the itemnumbers are present in the deleteditems table and the items have been deleted. Signed-off-by: Chris Cormack Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:55:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:55:10 +0000 Subject: [Koha-bugs] [Bug 12555] The DelItem subroutine should be called on canceling a receipt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12555 --- Comment #15 from Kyle M Hall --- Created attachment 34159 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34159&action=edit [PASSED QA] Bug 12555: Add a FK on aqorders_items.itemnumber The previous patch assumed that deleting an item will delete the entry in aqorders_items. But the FK did not exist. Looking at the code, we never join aqorders_items and deleteditems, so I think we can add this constraint. Before adding this constraint, we need to delete all entries in aqorders_items if the item has already been deleted. Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:55:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:55:53 +0000 Subject: [Koha-bugs] [Bug 11706] Typo "efault" in updatedatabase.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11706 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:55:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:55:56 +0000 Subject: [Koha-bugs] [Bug 11706] Typo "efault" in updatedatabase.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11706 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34134|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 34160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34160&action=edit [PASSED QA] Bug 11706: Typo fix for "efault" in old database update To test: - Verify the typo has been correct and no other changes have been made Signed-off-by: Bernardo Gonzalez Kriegel Typo fixed, no koha-qa errors. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:57:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:57:45 +0000 Subject: [Koha-bugs] [Bug 11008] Useless column supplierreference in aqorders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11008 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 16:57:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 15:57:47 +0000 Subject: [Koha-bugs] [Bug 11008] Useless column supplierreference in aqorders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11008 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33988|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 34161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34161&action=edit [PASSED QA] Bug 11008: Drop column aqorders.supplierreference It seems that this column has never been used. Test plan: 1/ Execute the updatedatabase entry. 2/ git grep supplierreference should not return occurrence in the code (except in Koha/Schema/* 3/ prove t/db_dependent/Acquisition.t should return green. Signed-off-by: Nicolas Legrand Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 17:54:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 16:54:16 +0000 Subject: [Koha-bugs] [Bug 13349] Allow library code to display against users pending changes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13349 --- Comment #7 from Marc V?ron --- Created attachment 34162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34162&action=edit [Signed-off] Bug 13349 - Allow library code to display against users pending changes -update screen http://bugs.koha-community.org/show_bug.cgi?id=13349 To test: Ensure OPACPatronDetails is set to enabled Apply the patch Log into the OPAC and update your patron details (address, phone number etc) Log into the staff client and view pending patron changes. The branchcode of the library to which the patron belongs should display next to the user's name. Followed test plan, works as expected Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 17:54:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 16:54:45 +0000 Subject: [Koha-bugs] [Bug 13349] Allow library code to display against users pending changes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13349 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34074|0 |1 is obsolete| | CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 17:55:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 16:55:10 +0000 Subject: [Koha-bugs] [Bug 13349] Allow library code to display against users pending changes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13349 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 19:12:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 18:12:33 +0000 Subject: [Koha-bugs] [Bug 13372] Items lost report improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13372 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at ptfs-europe.com --- Comment #2 from PTFS Europe Sandboxes --- Patch tested with a sandbox, by David Roberts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 19:12:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 18:12:43 +0000 Subject: [Koha-bugs] [Bug 13372] Items lost report improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13372 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34062|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 19:12:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 18:12:50 +0000 Subject: [Koha-bugs] [Bug 13372] Items lost report improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13372 --- Comment #3 from PTFS Europe Sandboxes --- Created attachment 34163 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34163&action=edit Bug 13372: Items lost report improvements This enhancement adds new column to display the call number on the items lost report. On the way, DataTables and ColVis are added on the table. Test plan: 1/ Go on the items lost report (reports/itemslost.pl) and verify that the call number column is correctly filled. 2/ On the way, verify that the 'Library' and 'Current location' now contain the name instead of the code. 3/ Go on the columns configuration in the admin module (admin/columns_settings.pl), play with the ColVis plugin and confirm that all works correctly. Signed-off-by: David Roberts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 5 21:11:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 20:11:30 +0000 Subject: [Koha-bugs] [Bug 13402] New: Can't tab to barcode field when adding item to serial Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13402 Bug ID: 13402 Summary: Can't tab to barcode field when adding item to serial Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: p.thrasher at dover.nh.gov QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com When receiving a serial we have an item record added. When I fill in the fields of the item record, I tab down the fields. Tabbing doesn't go into the barcode field, so I can't get to that field that way. I have to use the mouse to click in the barcode field to fill it in. We would like to tab to the barcode field. Thanks. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 6 00:58:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Dec 2014 23:58:13 +0000 Subject: [Koha-bugs] [Bug 13231] ISBD/AACR2 punctuation causes double facets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13231 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 6 01:41:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Dec 2014 00:41:53 +0000 Subject: [Koha-bugs] [Bug 13196] "Always show checkouts immediately" cookie should persist across sessions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13196 Suzanne Fayle changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sfayle at roseman.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 6 07:08:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Dec 2014 06:08:54 +0000 Subject: [Koha-bugs] [Bug 13395] Search Patrons on the home page fails on Firefox 34.0 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13395 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #2 from Chris Cormack --- I also can not recreate, v3.18.00 on Firefox 34, Ubuntu. Search works fine for me -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 6 08:58:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Dec 2014 07:58:44 +0000 Subject: [Koha-bugs] [Bug 13403] New: New catalogue records not saving to the database Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13403 Bug ID: 13403 Summary: New catalogue records not saving to the database Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: imingchan at yahoo.com.au QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl New catalogue records not saving to the database. Unable to found those records searching in Staff Client or OPAC using various searching methods including title, author or biblionumber. We have also reindexed the database without any success! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 6 09:06:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Dec 2014 08:06:40 +0000 Subject: [Koha-bugs] [Bug 13403] New catalogue records not saving to the database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13403 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Iming, I have just tested this and can save records correctly on current master. What happens after you save a record? Are you taken to the item edit page? When you click on the 'normal' tab there, can you go back to the record? This would show that the record is saved ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 6 09:12:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Dec 2014 08:12:16 +0000 Subject: [Koha-bugs] [Bug 12555] The DelItem subroutine should be called on canceling a receipt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12555 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #16 from Katrin Fischer --- I am not sure about deleting in aqorders_items when the items are deleted/the order is cancelled. We keep the record, the items and even the cancelled order - so not sure we should delete what ties them together. For library statistics often the items that were deleted/removed from the collection are queried/counted - so the library would want to differentiate between an item that really existed in the library or didn't. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 6 09:25:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Dec 2014 08:25:32 +0000 Subject: [Koha-bugs] [Bug 13398] Perl files for rotating collections are missing in debian package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13398 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|enhancement |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 6 09:59:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Dec 2014 08:59:13 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 --- Comment #34 from Katrin Fischer --- I think we agreed after some benchmarking not so use Moose, while Moo seemed to be ok. A problem is, that both are currently not dependencies in Koha and will have to be dealt with for the packaging. As this is an architecture patch, I think it might be worth getting Tom?s' opinion and/or adding it to the next dev meeting's agenda. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 6 09:59:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Dec 2014 08:59:43 +0000 Subject: [Koha-bugs] [Bug 13402] Can't tab to barcode field when adding item to serial In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13402 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #1 from M. de Rooy --- Will be addressed via bug 10480 or a followup like bug 13305 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 6 10:01:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Dec 2014 09:01:17 +0000 Subject: [Koha-bugs] [Bug 13204] [WAITS_FOR_RESPONSE] Plugin housekeeping: Remove labs_theses.pl plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13204 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Plugin housekeeping: Remove |[WAITS_FOR_RESPONSE] Plugin |labs_theses.pl plugin |housekeeping: Remove | |labs_theses.pl plugin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 6 10:02:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Dec 2014 09:02:03 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 --- Comment #66 from Katrin Fischer --- I ran an update from 3.16.2 on my development installation at work on Friday and had no errors. It looked quite good - could it be the database already had the change somehow? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 6 10:07:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Dec 2014 09:07:52 +0000 Subject: [Koha-bugs] [Bug 12428] "OPAC info" is not displayed in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #13 from Katrin Fischer --- This patch is targetted at 3.16 specifically, so I think it might not be testable on a sandbox successfully. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 6 10:10:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Dec 2014 09:10:31 +0000 Subject: [Koha-bugs] [Bug 12895] Dropbox mode doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12895 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Is the patch intended for 3.12 or is it also intended for master/3.18? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 6 10:15:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Dec 2014 09:15:50 +0000 Subject: [Koha-bugs] [Bug 13231] ISBD/AACR2 punctuation causes double facets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13231 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #1 from Katrin Fischer --- I think the former facet code removed the punctuation at the end and did some other tricks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 6 10:23:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Dec 2014 09:23:48 +0000 Subject: [Koha-bugs] [Bug 13366] Required fields not indicated on patron form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13366 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I think this might be a duplicate to bug 4418 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 6 12:39:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Dec 2014 11:39:27 +0000 Subject: [Koha-bugs] [Bug 13403] New catalogue records not saving to the database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13403 --- Comment #2 from Iming Chan --- (In reply to Katrin Fischer from comment #1) > Hi Iming, > > I have just tested this and can save records correctly on current master. > > What happens after you save a record? Are you taken to the item edit page? > When you click on the 'normal' tab there, can you go back to the record? > This would show that the record is saved ok. Hi Katrin, After I saved a catalogue record, it returns to "Normal" tab with holdings showing (Nothing different here). I have clicked other tabs under "Normal" (i.e. MARC, Labeled MARC, etc.) and they all seem normal. No problem with adding a new item or edit an existing item. Only noticed the difference in search result list (as presented before). As well, unable to find catalogue record or item barcode added after the upgrade. Iming -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 6 13:43:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Dec 2014 12:43:38 +0000 Subject: [Koha-bugs] [Bug 13403] New catalogue records not saving to the database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13403 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #3 from Tom?s Cohen Arazi --- (In reply to Iming Chan from comment #2) > Only noticed the difference in search result list (as presented before). As > well, unable to find catalogue record or item barcode added after the > upgrade. Please make sure you updated your template translations and you fully refreshed your pages ctrl+shift+r / cleaned your cache. There are new JavaScript libraries versions too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 6 15:30:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Dec 2014 14:30:03 +0000 Subject: [Koha-bugs] [Bug 13403] New catalogue records not saving to the database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13403 --- Comment #4 from Iming Chan --- (In reply to Tom?s Cohen Arazi from comment #3) > (In reply to Iming Chan from comment #2) > > Only noticed the difference in search result list (as presented before). As > > well, unable to find catalogue record or item barcode added after the > > upgrade. > > Please make sure you updated your template translations and you fully > refreshed your pages ctrl+shift+r / cleaned your cache. There are new > JavaScript libraries versions too. Hello Tom?s, I have cleaned the Firefox cache (as I initially thought this is the cause of the problem) without much success. Sorry for my ignorance, how do I update "template translations"? I have never done this in the past upgrades. Thanks again for your reply. Iming -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 6 15:50:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Dec 2014 14:50:55 +0000 Subject: [Koha-bugs] [Bug 13401] sort branches alphabetically in admin/authorised_values.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13401 --- Comment #2 from Marc V?ron --- Created attachment 34164 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34164&action=edit [Signed-off] Bug 13401 - sort branches alphabetically in admin/authorised_values.pl This patch adds a sort of branches alphabetically by name in authorised values administration, like in many other pages. Also replaces var $branch (too ambigus) by $branchcode. Test plan : - Create 2 branches : code=AAA,name=Zbranch and code=ZZZ,name=Abranch - Create a new authorized value : admin/authorised_values.pl - Look at "Libraries limitation" : => Without patch branches are sorted by code : Zbranch then Abranch => Without patch branches are sorted by name : Abranch then Zbranch - Select a branch and save - Re-edit => Check the same branch is selected Followed test plan. Patch behaves as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 6 15:51:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Dec 2014 14:51:19 +0000 Subject: [Koha-bugs] [Bug 13401] sort branches alphabetically in admin/authorised_values.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13401 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34146|0 |1 is obsolete| | CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 6 15:51:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Dec 2014 14:51:32 +0000 Subject: [Koha-bugs] [Bug 13401] sort branches alphabetically in admin/authorised_values.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13401 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 7 01:53:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Dec 2014 00:53:21 +0000 Subject: [Koha-bugs] [Bug 9828] Zebra indexes useless subfields in UNIMARC 6XX In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9828 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #57 from mathieu saby --- Hello Paul & Tomas - Paul, since your comment 30 the patch has been changed several times... - Tomas, see my comment 53, i rewrote the patch, so there should not be any problem in unit tests... So, in my opinion this patch has been signed off, but need a NEW look by QA, especially to check if UT are broken, and if everything works well with MARC21 install. So, I think the best status is "Signed off" Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 7 02:11:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Dec 2014 01:11:34 +0000 Subject: [Koha-bugs] [Bug 11927] Add greek support to CHR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com --- Comment #11 from mathieu saby --- Kalimera I studied ancient greek but not modern. It looks good, but I think your article list are Ancient Greek. I think Modern greek are a bit different (no rough breathing for ex.) and there's a new indefinite article (????, ???, ???). For ex, "A big bottle of water" = ena megalo nero (a very useful sentence in summer...) http://en.wikipedia.org/wiki/Modern_Greek_grammar#Articles The rough and soft breathing (esprit rude/doux in french) are no more in use since 1982, but maybe with legacy records it could be interesting to manage them in some way? http://en.wikipedia.org/wiki/Rough_breathing Mathieu Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 7 07:07:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Dec 2014 06:07:54 +0000 Subject: [Koha-bugs] [Bug 12450] Closing libraries for the summer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12450 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Depends on| |11211, 8133 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 7 07:07:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Dec 2014 06:07:54 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12450 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 7 07:07:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Dec 2014 06:07:54 +0000 Subject: [Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12450 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 7 18:03:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Dec 2014 17:03:39 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_13404=5D_New=3A__More_=C2=BBSystem_i?= =?utf-8?q?nformation=C2=AB_about_GRS1_vs_DOM_settings?= Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 Bug ID: 13404 Summary: More ?System information? about GRS1 vs DOM settings Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: nengard at gmail.com Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org System information indicates missing and entries in koha-conf.xml. This patch - adds warnings about a possible mismatch between these settings and the actual setup - adds info about the actual setup/what values to use for and if they are not set. The assumption is that a path including 'zebra-*-dom.cfg' in the respective section indicates a DOM setup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 7 18:04:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Dec 2014 17:04:26 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_13404=5D__More_=C2=BBSystem_informat?= =?utf-8?q?ion=C2=AB_about_GRS1_vs_DOM_settings?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nengard at gmail.com |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 7 18:08:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Dec 2014 17:08:10 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_13404=5D__More_=C2=BBSystem_informat?= =?utf-8?q?ion=C2=AB_about_GRS1_vs_DOM_settings?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 --- Comment #1 from Mirko Tietgen --- Created attachment 34165 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34165&action=edit Bug 13404 - More ?System information? about GRS1 vs DOM settings System information indicates missing and entries in koha-conf.xml. This patch - adds warnings about a possible mismatch between these settings and the actual setup - adds info about the actual setup/what values to use for and if they are not set. The assumption is that a path including 'zebra-*-dom.cfg' in the respective section indicates a DOM setup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 7 18:11:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Dec 2014 17:11:23 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_13404=5D__More_=C2=BBSystem_informat?= =?utf-8?q?ion=C2=AB_about_GRS1_vs_DOM_settings?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34165|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen --- Comment on attachment 34165 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34165 Bug 13404 - More ?System information? about GRS1 vs DOM settings Whoops I added a gazillion translation files. Will resend later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 7 18:40:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Dec 2014 17:40:33 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_13404=5D__More_=C2=BBSystem_informat?= =?utf-8?q?ion=C2=AB_about_GRS1_vs_DOM_settings?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 --- Comment #3 from Mirko Tietgen --- Created attachment 34166 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34166&action=edit Bug 13404 - More ?System information? about GRS1 vs DOM settings System information indicates missing and entries in koha-conf.xml. This patch - adds warnings about a possible mismatch between these settings and the actual setup - adds info about the actual setup/what values to use for and if they are not set. The assumption is that a path including 'zebra-*-dom.cfg' in the respective section indicates a DOM setup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 7 18:59:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Dec 2014 17:59:25 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_13404=5D__More_=C2=BBSystem_informat?= =?utf-8?q?ion=C2=AB_about_GRS1_vs_DOM_settings?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #4 from Mirko Tietgen --- To test: [if you followed the wiki at some point and manually changed your zebra-biblios.cfg and zebra-authorities.cfg to DOM without renaming them, the patch won't work for you.] Simulate the various possible combinations by changing your koha-conf.xml. Make sure to leave with the correct settings in the end ;) - If you have and in your file, delete/comment them and check if there is an additional info when you reload about.pl, indicating which setting seems correct. Verify that it matches your setup. - Simulate the other setting: change the paths to the biblio and auth server config. -- If you use DOM, change '/your/path/zebra-biblios-dom.cfg' and '/your/path/zebra-authorities-dom.cfg' in the settings to /your/path/zebra-biblios.cfg and /your/path/zebra-authorities.cfg -- If you use GRS1, change '/your/path/zebra-biblios.cfg' and '/your/path/zebra-authorities.cfg' in the settings to /your/path/zebra-biblios-dom.cfg and /your/path/zebra-authorities-dom.cfg - Check the about.pl page for additional info about the setting. - Change everything back to normal and (re)add and . Set them to the wrong setting: if you actually use dom, set them to 'grs1' or the other way round. - Check about.pl, you should get an extra warning. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 7 20:06:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Dec 2014 19:06:54 +0000 Subject: [Koha-bugs] [Bug 13405] New: System information has misleading information about indexing mode Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13405 Bug ID: 13405 Summary: System information has misleading information about indexing mode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: About Assignee: nengard at gmail.com Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org At the moment the description in system information sounds like the only thing you have to do to switch from grs1 to dom indexing is to set and to 'dom'. Apparently that is not true and may lead to confusion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 7 20:07:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Dec 2014 19:07:29 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_13404=5D__More_=C2=BBSystem_informat?= =?utf-8?q?ion=C2=AB_about_GRS1_vs_DOM_settings?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.18 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 7 23:11:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Dec 2014 22:11:01 +0000 Subject: [Koha-bugs] [Bug 13395] Search Patrons on the home page fails on Firefox 34.0 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13395 --- Comment #3 from Bob Ewart --- I had it fail that way on two machines both configured with Xubuntu 14.04. Since then there have been a number of updates to the system, but not to Koha. It's now working! I suspect that the failure was in one of Koha's dependencies down the line that got updated. Let's close this one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 7 23:14:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Dec 2014 22:14:42 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 --- Comment #51 from David Cook --- (In reply to Jonathan Druart from comment #50) > I personally don't want to discuss this implementation for the following > reasons: > 1/ We already have discussed (or at least tried) for years. > 2/ We already have different proposals (At least from Kyle, Yohann and me). > 3/ This code is functional and we will able to improve it according to our > further needs. > 4/ Everybody knows that putting a bug report to the 'in discussion' status > without any other actions (mail on mailing list, discussion on #koha, etc) > don't permit to move it forward. > > I strongly believe that the next step is to get the RM point of view. > > You can provide a patch on another report to improve the code and show us > what could be better, that would be great :) Fair enough. Maybe the next step is to get the RM point of view. While I do have ideas for what I think would be better code and a better proposal, I think it would need to be a more concerted team effort (admittedly, that has historically been extraordinarily difficult to achieve). As for individual work, I'm not willing to dedicate the time in my personal life at the moment, and I don't have the time to do it professionally, so I suppose it's not fair for me to be too critical if I can't provide any work myself. Feel free to switch it back to Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 7 23:20:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Dec 2014 22:20:09 +0000 Subject: [Koha-bugs] [Bug 13395] Search Patrons on the home page fails on Firefox 34.0 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13395 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 7 23:52:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Dec 2014 22:52:15 +0000 Subject: [Koha-bugs] [Bug 5517] After removal of koha-common package in Debian Squeeze cron jobs are not deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5517 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW --- Comment #6 from Robin Sheat --- Yep, I just looked in policy: https://www.debian.org/doc/debian-policy/ch-files.html#s10.7.3 and cron files are explicitly conffiles (defined in 10.7.1.) So stay they will. However, Stephen is totally correct, we should be testing for the existence of everything before executing it. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 03:23:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 02:23:19 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_13404=5D__More_=C2=BBSystem_informat?= =?utf-8?q?ion=C2=AB_about_GRS1_vs_DOM_settings?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 08:25:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 07:25:56 +0000 Subject: [Koha-bugs] [Bug 11624] Impossible to style MARC display via CSS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11624 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from paxed --- Fixed in master by bug 11885 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 08:36:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 07:36:14 +0000 Subject: [Koha-bugs] [Bug 13406] New: Authority MARC display impossible to style via CSS Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13406 Bug ID: 13406 Summary: Authority MARC display impossible to style via CSS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com For example, the tag title line is just a single div:
046 ## - SPECIAL CODED DATES
which makes it impossible to style the tag number, the indicators and the tag description separately. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 08:36:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 07:36:40 +0000 Subject: [Koha-bugs] [Bug 13406] Authority MARC display impossible to style via CSS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13406 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11885 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 08:36:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 07:36:40 +0000 Subject: [Koha-bugs] [Bug 11885] Inconsistent HTML in MARC Details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13406 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 09:56:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 08:56:34 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 --- Comment #67 from Jonathan Druart --- No, the table does not exist yet. Actually I got the error on both sandboxes used for bug 11944. It comes from the FK, I am able to create the table if I remove the constraint. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 09:57:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 08:57:45 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 --- Comment #68 from Jonathan Druart --- Ok, got it! It comes from the different charset collate introduced by 11944. Sorry for the noise. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 10:03:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 09:03:47 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #6 from Jonathan Druart --- Created attachment 34167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34167&action=edit Bug 13371: change the filters wording -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 10:06:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 09:06:42 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #7 from Jonathan Druart --- (In reply to Matthias Meusburger from comment #5) > About the baskets filters: > > If I click on "Show active baskets only" then on "Show opened baskets only" > I end up with two "Show all baskets" links one after the other. > > This is confusing. > > Imho, it should work this way: > > Show active baskets only -> click -> Show active and inactive baskets > Show opened baskets only -> click -> Show opened and closed baskets It makes sense, thanks for the suggestion! > About the datatable filters: > > 'Item count' and 'Biblio count' didn't work for me: "No matching records > found" (some records should have matched my search). I don't encounter this issue. But I marked these fields as integer. It means that if a cell contains "2 (1 canceled)", it will only appear if you search for '2'. This is a feature but can be removed if considered as a bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 10:30:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 09:30:10 +0000 Subject: [Koha-bugs] [Bug 13378] There is no way to search suggestions not linked to a fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13378 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34086|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 34168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34168&action=edit Bug 13378: Add a filter to search suggestions not linked to a fund This patch adds a "None" option for the fund filter. Test plan: 1/ Go on the suggestion search page 2/ Search suggestions not linked to a fund using the "None" option. 3/ Search all suggestions (linked or not to a fund) using the "Any" option. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 10:30:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 09:30:42 +0000 Subject: [Koha-bugs] [Bug 13378] There is no way to search suggestions not linked to a fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13378 --- Comment #3 from Jonathan Druart --- The last patch simplifies the test in SearchSuggestion to make it more readable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 10:41:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 09:41:35 +0000 Subject: [Koha-bugs] [Bug 12555] The DelItem subroutine should be called on canceling a receipt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12555 --- Comment #17 from Jonathan Druart --- The aqorders_items entries are already removed on canceling a receipt. Before this patch, the items were deleted too. With the patch, they are moved to deleteditems. I am not sure to understand what is the info you loose, could you please detail? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 10:58:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 09:58:32 +0000 Subject: [Koha-bugs] [Bug 12555] The DelItem subroutine should be called on canceling a receipt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12555 --- Comment #18 from Katrin Fischer --- I am afraid I won't be able to tell which deleted items were non-existant in the library - belonged to a cancelled order - and which items were removed for other reasons (damaged, outdated). Biblionumber might not be enough, as you might have cancelled an order and at a later point in time the existing items get thrown out because the book gets outdated/replaces by a newer edition. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 10:59:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 09:59:23 +0000 Subject: [Koha-bugs] [Bug 12555] The DelItem subroutine should be called on canceling a receipt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12555 --- Comment #19 from Katrin Fischer --- I think for me it would make sense to either delete both - the item and the linking, or keep both. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 12:31:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 11:31:55 +0000 Subject: [Koha-bugs] [Bug 13378] There is no way to search suggestions not linked to a fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13378 --- Comment #4 from Marc V?ron --- Created attachment 34169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34169&action=edit [Signed-off] Bug 13378: Add a filter to search suggestions not linked to a fund This patch adds a "None" option for the fund filter. Test plan: 1/ Go on the suggestion search page 2/ Search suggestions not linked to a fund using the "None" option. 3/ Search all suggestions (linked or not to a fund) using the "Any" option. Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 12:32:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 11:32:27 +0000 Subject: [Koha-bugs] [Bug 13378] There is no way to search suggestions not linked to a fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13378 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34168|0 |1 is obsolete| | CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 12:33:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 11:33:21 +0000 Subject: [Koha-bugs] [Bug 13378] There is no way to search suggestions not linked to a fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13378 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 12:47:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 11:47:03 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #8 from Jonathan Druart --- Created attachment 34170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34170&action=edit New screen/table for booksellers.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 14:27:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 13:27:41 +0000 Subject: [Koha-bugs] [Bug 12432] Saved reports tabs not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12432 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #12 from Fridolin SOMERS --- Pushed to 3.14.x, will be in 3.14.12. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 14:29:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 13:29:06 +0000 Subject: [Koha-bugs] [Bug 10893] Location facet not working in UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10893 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #15 from Fridolin SOMERS --- Pushed to 3.14.x, will be in 3.14.12. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 14:31:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 13:31:43 +0000 Subject: [Koha-bugs] [Bug 12211] Wrong home link in bootstrap opac-auth In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12211 --- Comment #10 from Fridolin SOMERS --- Pushed to 3.14.x, will be in 3.14.12. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 14:33:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 13:33:10 +0000 Subject: [Koha-bugs] [Bug 13189] Patron card creator patron search browse by last name broken by extended attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13189 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 14:33:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 13:33:12 +0000 Subject: [Koha-bugs] [Bug 13189] Patron card creator patron search browse by last name broken by extended attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13189 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33451|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 34171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34171&action=edit Bug 13189 - Patron card creator patron search browse by last name broken by extended attributes The browse by last name letters on the patron search for the patron card creator doesn't work quite right. If extended patron attributes are disabled, it works fine, but if they are enabled, they are searched even when using the browse last name. Thus, if a searchable attribute has a "D" in it, and one clicks the "D" link for the last name browser, that patron will show even if he or she has no "D" in his or her hame! Test Plan: 1) Enable extended patron attributes 2) Add a new searchable patron attribute 3) Create a new patron with the last name "Ace" 4) Add the value "D" to the attribute for this patron 5) Browse to the patron card maker, start a new patron batch 6) Click "Add item(s)" to bring up the patron search 7) Click the letter "D" in the patron search box 8) Note that "Ace" shows in the results list 9) Apply this patch 10) Repeat step 7 11) Note that "Ace" no longer shows in the results list 12) Perform a regular search by putting the letter "D" in the "Name:" field, and hit the "Search" button 13) Note this time the results *do* have Ace in them Signed-off-by: Frederic Demians Well described for a tricky bug. Reproducible. Fixed with this patch. Signed-off-by: Katrin Fischer This works as described, no problems or regressions found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 14:33:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 13:33:19 +0000 Subject: [Koha-bugs] [Bug 13189] Patron card creator patron search browse by last name broken by extended attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13189 --- Comment #7 from Kyle M Hall --- Created attachment 34172 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34172&action=edit Bug 13189 [QA Followup] - Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 14:39:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 13:39:17 +0000 Subject: [Koha-bugs] [Bug 13407] New: Remove methods which are included in the 0.36 release of PDF::Reuse Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407 Bug ID: 13407 Summary: Remove methods which are included in the 0.36 release of PDF::Reuse Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: cnighswonger at foundations.edu QA Contact: testopia at bugs.koha-community.org This patch removes methods which will be included in the 0.36 release of PDF::Reuse. Technically, it should not be necessary to backport this patch since the net result of the current code when executed against 0.36 is redefition of a few subs; however, it would still be good to apply this to the current maintenance releases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 14:40:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 13:40:29 +0000 Subject: [Koha-bugs] [Bug 13407] Remove methods which are included in the 0.36 release of PDF::Reuse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407 --- Comment #1 from Chris Nighswonger --- Created attachment 34173 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34173&action=edit Patch removing duplicate methods This patch should only be applied after the release of PDF::Reuse 0.36. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 14:46:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 13:46:53 +0000 Subject: [Koha-bugs] [Bug 13407] Remove methods which are included in the 0.36 release of PDF::Reuse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407 --- Comment #2 from Chris Nighswonger --- NOTE: This depends on https://rt.cpan.org/Ticket/Display.html?id=100779 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 14:47:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 13:47:17 +0000 Subject: [Koha-bugs] [Bug 13407] Remove methods which are included in the 0.36 release of PDF::Reuse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 14:47:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 13:47:37 +0000 Subject: [Koha-bugs] [Bug 13407] Remove methods which are included in the 0.36 release of PDF::Reuse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 14:49:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 13:49:25 +0000 Subject: [Koha-bugs] [Bug 13407] Remove methods which are included in the 0.36 release of PDF::Reuse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407 --- Comment #3 from Chris Nighswonger --- To test: 1. Upgrade PDF::Reuse to 0.35_04. [1] 2. Run Koha's non-DB dependent test suite. You should notice some non-fatal warnings about the redefinition of one or two subs in PDF::Reuse. This should not affect the functionality of the tools for the end user. 3. Verify the functionality of the related tools. 4. Apply the attached patch. 5. Re-run Koha's non-DB dependent test suite. You should note no warnings related to PDF::Reuse. 6. Re-verify the functionality of the related tools. [1] http://search.cpan.org/CPAN/authors/id/C/CN/CNIGHS/PDF-Reuse-0.35_04.tar.gz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 14:50:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 13:50:27 +0000 Subject: [Koha-bugs] [Bug 13407] Remove methods which are included in the 0.36 release of PDF::Reuse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 14:50:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 13:50:37 +0000 Subject: [Koha-bugs] [Bug 13408] New: Tell librarians they may continue scanning while checkouts table is loading Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13408 Bug ID: 13408 Summary: Tell librarians they may continue scanning while checkouts table is loading Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Some librarians do not realize they can continue scanning items even if the checkouts table has not loaded. We should have Koha tell them explicitly that they may continue scanning barcodes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 14:50:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 13:50:41 +0000 Subject: [Koha-bugs] [Bug 13408] Tell librarians they may continue scanning while checkouts table is loading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13408 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 14:50:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 13:50:48 +0000 Subject: [Koha-bugs] [Bug 13407] Remove methods which are included in the 0.36 release of PDF::Reuse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 14:50:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 13:50:54 +0000 Subject: [Koha-bugs] [Bug 13408] Tell librarians they may continue scanning while checkouts table is loading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13408 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11703 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 14:50:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 13:50:54 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13408 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 14:53:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 13:53:06 +0000 Subject: [Koha-bugs] [Bug 13408] Tell librarians they may continue scanning while checkouts table is loading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13408 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 14:53:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 13:53:08 +0000 Subject: [Koha-bugs] [Bug 13408] Tell librarians they may continue scanning while checkouts table is loading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13408 --- Comment #1 from Kyle M Hall --- Created attachment 34174 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34174&action=edit Bug 13408 - Tell librarians they may continue scanning while checkouts table is loading Some librarians do not realize they can continue scanning items even if the checkouts table has not loaded. We should have Koha tell them explicitly that they may continue scanning barcodes. Test Plan: 1) Apply this patch 2) Load the checkouts table on circulation.pl, note the loading message is now Loading... you may continue scanning. 3) Load the checkouts table on moremember.pl, note the loading message is still Loading... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 15:23:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 14:23:23 +0000 Subject: [Koha-bugs] [Bug 13204] Plugin housekeeping: Remove labs_theses.pl plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13204 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA Summary|[WAITS_FOR_RESPONSE] Plugin |Plugin housekeeping: Remove |housekeeping: Remove |labs_theses.pl plugin |labs_theses.pl plugin | --- Comment #13 from Jonathan Druart --- The plugin did the same thing as when a field is linked to a list of AV. It's useless and can be removed. Switch back to Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 15:32:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 14:32:33 +0000 Subject: [Koha-bugs] [Bug 13204] Plugin housekeeping: Remove labs_theses.pl plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13204 --- Comment #14 from M. de Rooy --- (In reply to Jonathan Druart from comment #13) > The plugin did the same thing as when a field is linked to a list of AV. > It's useless and can be removed. > Switch back to Passed QA. Thanks for your attention. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 15:41:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 14:41:28 +0000 Subject: [Koha-bugs] [Bug 13408] Tell librarians they may continue scanning while checkouts table is loading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13408 --- Comment #2 from Marc V?ron --- Created attachment 34175 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34175&action=edit [Signed-off] Bug 13408 - Tell librarians they may continue scanning while checkouts table is loading Some librarians do not realize they can continue scanning items even if the checkouts table has not loaded. We should have Koha tell them explicitly that they may continue scanning barcodes. Test Plan: 1) Apply this patch 2) Load the checkouts table on circulation.pl, note the loading message is now Loading... you may continue scanning. 3) Load the checkouts table on moremember.pl, note the loading message is still Loading... Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 15:41:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 14:41:47 +0000 Subject: [Koha-bugs] [Bug 13408] Tell librarians they may continue scanning while checkouts table is loading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13408 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34174|0 |1 is obsolete| | CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 15:42:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 14:42:01 +0000 Subject: [Koha-bugs] [Bug 13408] Tell librarians they may continue scanning while checkouts table is loading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13408 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 15:50:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 14:50:34 +0000 Subject: [Koha-bugs] [Bug 13376] Include a user-editable area/page for terms and conditions of use in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13376 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 15:53:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 14:53:13 +0000 Subject: [Koha-bugs] [Bug 13351] Untranslatable javascript in members.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13351 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 16:26:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 15:26:16 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Joel Sasse changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jsasse at plumcreeklibrary.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 16:27:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 15:27:20 +0000 Subject: [Koha-bugs] [Bug 13400] Untranslatable "Are you sure you want to delete this authority?" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13400 --- Comment #1 from Marc V?ron --- Created attachment 34176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34176&action=edit Bug 13400 - Untranslatable "Are you sure you want to delete this authority?" This patch makes the string "Are you sure you want to delete this authority?" translatable using the function _(...) To test, apply patch and check that deleting authorities still works. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 16:28:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 15:28:46 +0000 Subject: [Koha-bugs] [Bug 13400] Untranslatable "Are you sure you want to delete this authority?" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13400 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |veron at veron.ch Patch complexity|--- |String patch Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 16:32:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 15:32:28 +0000 Subject: [Koha-bugs] [Bug 13409] New: Add ability to purge old special holidays using cleanup_database.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409 Bug ID: 13409 Summary: Add ability to purge old special holidays using cleanup_database.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Some libraries have expressed interested in being able to purge old holidays from the database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 16:34:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 15:34:16 +0000 Subject: [Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409 --- Comment #1 from Kyle M Hall --- Created attachment 34177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34177&action=edit Bug 13409 - Add ability to purge old special holidays using cleanup_database.pl Some libraries have expressed interested in being able to purge old holidays from the database. Test Plan: 1) Create some special holidays in the past 2) Use the new --holidays DAYS option to test deleting special holidays 3) Verify only special holidays past the given amount of days were deleted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 16:34:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 15:34:14 +0000 Subject: [Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 16:34:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 15:34:27 +0000 Subject: [Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 16:38:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 15:38:16 +0000 Subject: [Koha-bugs] [Bug 11375] Patron permission names are untranslatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 16:55:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 15:55:48 +0000 Subject: [Koha-bugs] [Bug 12084] Published date for serial items not formatted according to dateformat system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12084 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 16:55:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 15:55:51 +0000 Subject: [Koha-bugs] [Bug 12084] Published date for serial items not formatted according to dateformat system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12084 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34046|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 34178 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34178&action=edit Bug 12084: Format planned date in publication details on detail page If items are created for a serial subscription, the issue information is shown on the details page in staff with the planned date in (). To test: 1) Create a subscription with items added on receive 2) Receive a few issues and create items 3) Check the staff detail page 4) Verify that the published date shows under Publication details in the items table, but that the date is not formatted 5) Apply patch 6) Verify the date is now formatted according to the DateFormat system preference setting Signed-off-by: Paola Rossi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 16:56:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 15:56:49 +0000 Subject: [Koha-bugs] [Bug 10051] surname and first name should have comma in overdues report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10051 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 16:56:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 15:56:52 +0000 Subject: [Koha-bugs] [Bug 10051] surname and first name should have comma in overdues report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10051 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34043|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 34179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34179&action=edit Bug 10051: Separate first name and surname with comma in overdues report The name of the patron who has overdues is displayed as "surname first name" instead of "surname, first name". To test: - Go to circulation > overdues - Verify that first name and surname are not separated by comma - Apply patch - Verify the display is improved with a comma - Delete the first name from one of the patrons - Verify display is still ok Signed-off-by: David Roberts Signed-off-by: Christopher Brannon Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 17:05:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 16:05:59 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32453|0 |1 is obsolete| | --- Comment #32 from Kyle M Hall --- Created attachment 34180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34180&action=edit Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber at provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber at messaging.sprintpcs.com Verizon phonenumber at vtext.com T-Mobile phonenumber at tmomail.net AT&T phonenumber at txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 17:08:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 16:08:39 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34180|0 |1 is obsolete| | --- Comment #33 from Kyle M Hall --- Created attachment 34181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34181&action=edit Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers Nearly all cellular providers allow a person to send an text message to a cellular phone by sending an email to phonenumber at provider. We can leverage this capability to add the ability for Koha to send sms messages to patrons without the need to subscribe to an sms gateway server. Basic plan: 1. Add a table sms_providers to the db to tell Koha what service providers are available, and what domain emails should be sent to. 2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron subscribes to for the number given in smsalertnumber 3. Modify Koha to send an email rather than using SMS::Send if the driver is set to 'Email' Test plan: 0) Get a mobile phone 1) Apply the patch 2) Run updatedatabase.pl 3) Set the value of SMSSendDriver to 'Email' 4) Go to the admin page, the "Additional parameters" area should now have the link "SMS cellular providers" 5) On this page, add some providers. Make sure to add the provider for your own cellular phone service. Here are some examples: Sprint phonenumber at messaging.sprintpcs.com Verizon phonenumber at vtext.com T-Mobile phonenumber at tmomail.net AT&T phonenumber at txt.att.net Only add the domain part in the 'domain' field. So for Verizon, that would be 'vtext.com' 6) Create an account for yourself, add your SMS number, and select your provider from the dropdown box directly below it. 7) Enable SMS messaging for Item check-in and Item checkout 8) Check out an item to yourself 9) Run process_message_queue.pl 10) Wait! You should receive a text message shortly, when I tested it, I received my sms message within the minute. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 17:16:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 16:16:28 +0000 Subject: [Koha-bugs] [Bug 13403] New catalogue records not saving to the database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13403 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #5 from Katrin Fischer --- I think maybe we should move this to the mailing list so all information is in one place? Marking INVALID - meaning it's a problem specific to this installation. Information on updating your translated templates after updating: http://wiki.koha-community.org/wiki/Installation_of_additional_languages_for_OPAC_and_INTRANET_staff_client The files will be updated automatically if you have a package installation, for ohter installation types you have to run the script manually on the server after every update. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 17:20:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 16:20:01 +0000 Subject: [Koha-bugs] [Bug 13299] Add home library column to the holds ratios report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13299 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 17:20:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 16:20:04 +0000 Subject: [Koha-bugs] [Bug 13299] Add home library column to the holds ratios report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13299 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33681|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 34182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34182&action=edit Bug 13299 - Add home library column to the holds ratios report It seems odd that only the holding libraries are listed on the holds ratios report, we should add the home libraries as well. Test Plan: 1) Apply this patch 2) Run the hold ratios report 3) Note the new home libraries column Signed-off-by: Heather Braum Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 17:20:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 16:20:21 +0000 Subject: [Koha-bugs] [Bug 13298] Holds ratios report ignores ordered items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13298 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 17:20:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 16:20:24 +0000 Subject: [Koha-bugs] [Bug 13298] Holds ratios report ignores ordered items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13298 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33679|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 34183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34183&action=edit Bug 13298 - Holds ratios report ignores ordered items The holds ratio report ignores ordered items. This could cause a library to inadvertently order more copies of a title than they actually need. An option should be added to count ordered items ( i.e. any negative notforloan value ). Test Plan: 1) Apply this patch 2) Create a record with two items, one regular, one ordered. 3) Place 3 holds on the item 4) Run the reserve ratios report, by default you should see this record 5) Check the new 'include ordered' checkbox, rerun the report 6) Note that record is no longer displayed Signed-off-by: Heather Braum Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 17:28:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 16:28:26 +0000 Subject: [Koha-bugs] [Bug 13410] New: Untranslatable "Change messaging preferences to default for this category?" Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13410 Bug ID: 13410 Summary: Untranslatable "Change messaging preferences to default for this category?" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr To reproduce: In staff client, go to Home > Patrons Click button "New patron" and choose a category Change Patron messaging preferences Now change Category Message box asks for confirmation ("Change messaging preferences to default for this category?") Do the same in an other language Result: Text appears in English. Reason: JavaScript message is not surrounded by _(...) in memberentrygen.tt line 1343 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 17:31:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 16:31:45 +0000 Subject: [Koha-bugs] [Bug 13290] Add better feedback for returns to the checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13290 --- Comment #11 from Jonathan Druart --- Created attachment 34184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34184&action=edit Bug 13290 - Add better feedback for returns to the checkouts table The feedback given when returning an item is only to update the "Check in" column. It would be nice if the entire column was highlighted in some way so librarians have an easier time spotting which items were checked in and which ones failed to be checked in. Test Plan: 1) Apply this patch 2) Browse to a patron with checkouts 3) Return an item using the checkouts table 4) Note if the return was successful, the row is highlighted in yellow, if the return was not allowed, the row is highlighted in red. Signed-off-by: Christopher Brannon Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 17:31:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 16:31:42 +0000 Subject: [Koha-bugs] [Bug 13290] Add better feedback for returns to the checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13290 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 17:32:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 16:32:04 +0000 Subject: [Koha-bugs] [Bug 13336] Add time to date column for patron circulation history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13336 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 17:32:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 16:32:07 +0000 Subject: [Koha-bugs] [Bug 13336] Add time to date column for patron circulation history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13336 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34044|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 34185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34185&action=edit Bug 13336 - Add time to date column for patron circulation history Some librarians have expressed that it would be very helpful to have the hours displayed in the date column for a patron's circulation history. The time an action took place can be vital to tracking down which librarians were working at the time a given circulation action took place. Test Plan: 1) View a patron's circulation history 2) Note the Date column has no hour/minute 3) Apply this patch 4) Reload the page 5) Note the hour and minutes now display Signed-off-by: David Roberts Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 17:33:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 16:33:55 +0000 Subject: [Koha-bugs] [Bug 13290] Add better feedback for returns to the checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13290 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #12 from Jonathan Druart --- Maybe a more explicit class name could have been chosen :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 17:40:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 16:40:01 +0000 Subject: [Koha-bugs] [Bug 13408] Tell librarians they may continue scanning while checkouts table is loading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13408 --- Comment #3 from Jonathan Druart --- Created attachment 34186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34186&action=edit Bug 13408: Tell librarians they may continue scanning while checkouts table is loading Some librarians do not realize they can continue scanning items even if the checkouts table has not loaded. We should have Koha tell them explicitly that they may continue scanning barcodes. Test Plan: 1) Apply this patch 2) Load the checkouts table on circulation.pl, note the loading message is now Loading... you may continue scanning. 3) Load the checkouts table on moremember.pl, note the loading message is still Loading... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 17:40:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 16:40:40 +0000 Subject: [Koha-bugs] [Bug 13408] Tell librarians they may continue scanning while checkouts table is loading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13408 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34186|Bug 13408: Tell librarians |[ALT] Bug 13408: Tell description|they may continue scanning |librarians they may |while checkouts table is |continue scanning while |loading |checkouts table is loading CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- Comment on attachment 34186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34186 [ALT] Bug 13408: Tell librarians they may continue scanning while checkouts table is loading Kyle, why not just overwrite the existing variable? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 17:46:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 16:46:38 +0000 Subject: [Koha-bugs] [Bug 7741] Clear search terms in Z3950 search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7741 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #8 from Jonathan Druart --- QA comment: Please define css styles in the css file and replace tabulation with 4 spaces. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 19:47:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 18:47:08 +0000 Subject: [Koha-bugs] [Bug 13411] New: Koha's SIP server returns not ok for checking in items that are not checked out Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Bug ID: 13411 Summary: Koha's SIP server returns not ok for checking in items that are not checked out Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com If an item is not checked out when a checkin via SIP2 is attempted, Koha's SIP server sends back an "ok" of 0, and the AF message "Item not checked out". I am not entirely sure this is good and correct behavior by the SIP2 protocol. In particular, this will cause SIP2 book sorting devices to fail on all items that are not checked out, causing them all to be put into the "special handling" been that should be reserved for things like items checked in at the wrong library and items on hold. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 19:47:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 18:47:14 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 19:47:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 18:47:18 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 19:47:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 18:47:21 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13159 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 19:47:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 18:47:21 +0000 Subject: [Koha-bugs] [Bug 13159] Enhancements to the SIP2 command line emulator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13159 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13411 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 19:53:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 18:53:44 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 19:53:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 18:53:46 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 --- Comment #1 from Kyle M Hall --- Created attachment 34187 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34187&action=edit Bug 13411 - Koha's SIP server returns not ok for checking in items that are not checked out If an item is not checked out when a checkin via SIP2 is attempted, Koha's SIP server sends back an "ok" of 0, and the AF message "Item not checked out". I am not entirely sure this is good and correct behavior by the SIP2 protocol. In particular, this will cause SIP2 book sorting devices to fail on all items that are not checked out, causing them all to be put into the "special handling" been that should be reserved for things like items checked in at the wrong library and items on hold. Test Plan: 1) Apply the patch for bug 13159 so you can use the new enhanced SIP2 command line emulator 2) Use a command similar to the following to check in an item: sip_cli_emulator.pl -a localhost -su -sp -l --item -m checkin 3) Note the 3rd character is 0, and there is an AF field saying the item is not checked out 4) Apply this patch 5) Restart the SIP server 6) Repeat steps 2-3, note that nothing has changed 7) In the SIP config file, Add the parameter checked_in_ok="1" to the SIP account you are using. 8) Restart the SIP server 9) Repeat steps 2-3, note that this time the 4rd character is 1, and you do not recieve the item not checked out message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 19:54:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 18:54:42 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 --- Comment #2 from Kyle M Hall --- Note, I believe this is really most likely a bug, but am reticent to change this SIP server's default behavior. Thus, I have made this a configurable option instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 20:30:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 19:30:31 +0000 Subject: [Koha-bugs] [Bug 13408] Tell librarians they may continue scanning while checkouts table is loading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13408 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 21:22:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 20:22:02 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master --- Comment #38 from Katrin Fischer --- I saw this is on the list for the testing day :) It would be good to add a test plan and description. I think the feature evolved a bit over time, as this is one of the older bug reports. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 22:01:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 21:01:14 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 22:10:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 21:10:13 +0000 Subject: [Koha-bugs] [Bug 7741] Clear search terms in Z3950 search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7741 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #9 from Katrin Fischer --- Hi Tom, I think this will be a useful enhancement and welcome! Let us know if you need any help with reworking the patch. You can set the status back to 'needs sign-off' when the 2 things Jonathan noticed have been fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 22:15:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 21:15:21 +0000 Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- I am not sure about enforcing an authorized value here - maybe we treat it similar to the bsort authorized values? The statistic fields are normal inputs until you add values for the authorized value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 22:17:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 21:17:44 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #200 from Katrin Fischer --- Should this be 'needs sign-off' for the last 3 patches? Can the 'signed off' patches be obsoleted? I am not sure if they have been pushed or not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 22:20:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 21:20:58 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Be careful, if there is an $e to display, you will want to ignore $4 in that case. I am not sure about using | as a separator, it looks quite uncommon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 8 22:23:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 21:23:06 +0000 Subject: [Koha-bugs] [Bug 13383] RDA: 100/110/111 changes to XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13383 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Similar comment as for bug 13383: Be careful if both $4 and $e exist. I think if the relator term exists, don't display the relator code. Also not sure about the | as separator. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 00:13:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Dec 2014 23:13:14 +0000 Subject: [Koha-bugs] [Bug 13407] Remove methods which are included in the 0.36 release of PDF::Reuse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407 --- Comment #4 from Chris Nighswonger --- Here is a deb file for the above mentioned PDF::Reuse release which may be easier to use for testing: http://debian.koha-community.org/koha/other_files/libpdf-reuse-perl_0.35-05-1_all.deb Many thanks to Robin for taking the time to help with getting this together. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 07:09:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 06:09:23 +0000 Subject: [Koha-bugs] [Bug 13412] New: Allow configuration of auto-created authorities Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13412 Bug ID: 13412 Summary: Allow configuration of auto-created authorities Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: gmcharlt at gmail.com Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org When AutoCreateAuthorities and BiblioAddsAuthorities sysprefs are on, Koha automagically creates authority records from biblios. Currently there's no way to change what data goes into the auth record. For example, field 667a always contains the text "Machine generated authority record." and 670a contains "Work cat. ($MARCOrgCode)$999c: $bib.author, $bib.title_proper, $bib.publication_date" Perhaps a new syspref where you could enter stuff like " 667a Machine generated authority record. 670a Work cat. ($MARCOrgCode)$999c: $bib.author, $bib.title_proper, $bib.publication_date " (meaning the fields 667a and 670a get the same text as they used to; see LinkBibHeadingsToAuthorities() in C4/Biblio.pm) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 07:46:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 06:46:07 +0000 Subject: [Koha-bugs] [Bug 13379] authorised_values.category is varchar(16) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13379 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Just a note: aqbudgets.sort1_authcat and aqbudgets.sort2_authcat wre both varchar(80) - so there is another mismatch, although it should not cause any trouble. Not sure if we should shrink it to match and if so, we should do it on another bug). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 07:51:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 06:51:02 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer at bsz-bw.de |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 07:51:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 06:51:22 +0000 Subject: [Koha-bugs] [Bug 7292] new permission for claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer at bsz-bw.de |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 07:51:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 06:51:37 +0000 Subject: [Koha-bugs] [Bug 7290] new permission for receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer at bsz-bw.de |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 08:48:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 07:48:28 +0000 Subject: [Koha-bugs] [Bug 13413] New: Koha::Log - an attempt to have sane logging in Koha Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13413 Bug ID: 13413 Summary: Koha::Log - an attempt to have sane logging in Koha Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: srdjan at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Koha is painfully lacking logging infrastructure. This is an attempt to retrofit one. It is based on Log::Contextual rather than Log::Log4Perl for the sake of simplicity and efficiency. This is a discussion bite. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 08:56:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 07:56:00 +0000 Subject: [Koha-bugs] [Bug 13413] Koha::Log - an attempt to have sane logging in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13413 --- Comment #1 from Srdjan Jankovic --- Created attachment 34188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34188&action=edit bug_13413: Koha::Log - logging for Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 08:55:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 07:55:58 +0000 Subject: [Koha-bugs] [Bug 13413] Koha::Log - an attempt to have sane logging in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13413 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 08:57:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 07:57:23 +0000 Subject: [Koha-bugs] [Bug 13413] Koha::Log - an attempt to have sane logging in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13413 --- Comment #2 from Srdjan Jankovic --- Created attachment 34189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34189&action=edit bug_13413: use Koha::Log with syslog sink instead of syslog directly in Sipserver.pm This way we can sift out debugs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 08:57:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 07:57:26 +0000 Subject: [Koha-bugs] [Bug 13413] Koha::Log - an attempt to have sane logging in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13413 --- Comment #3 from Srdjan Jankovic --- Created attachment 34190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34190&action=edit bug_13413: Koha::Log in longoverdue.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 08:58:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 07:58:37 +0000 Subject: [Koha-bugs] [Bug 13413] Koha::Log - an attempt to have sane logging in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13413 --- Comment #4 from Srdjan Jankovic --- There are two patches to give an example how to use Koha::Log -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 09:21:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 08:21:53 +0000 Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #5 from Jonathan Druart --- (In reply to Katrin Fischer from comment #4) > I am not sure about enforcing an authorized value here - maybe we treat it > similar to the bsort authorized values? The statistic fields are normal > inputs until you add values for the authorized value. Yes maybe, we could. But how to deal with existing values? I worked on the assumption that there won't be many and many reasons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 09:30:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 08:30:34 +0000 Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #6 from Katrin Fischer --- I am not sure, but I think as we introduced it as a free text field people might have left unstructured comments and could end up with quite a long list for the authorized value - which might also not very welcome. Maybe put the SQL for the update on the wiki and leave as is? I would make the value show up in the list of authorized values but leave it empty I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 09:52:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 08:52:23 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 09:52:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 08:52:28 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10517|0 |1 is obsolete| | Attachment #10936|0 |1 is obsolete| | Attachment #10938|0 |1 is obsolete| | Attachment #10949|0 |1 is obsolete| | Attachment #10958|0 |1 is obsolete| | Attachment #10965|0 |1 is obsolete| | Attachment #10967|0 |1 is obsolete| | Attachment #10972|0 |1 is obsolete| | Attachment #12224|0 |1 is obsolete| | Attachment #12491|0 |1 is obsolete| | Attachment #12492|0 |1 is obsolete| | --- Comment #201 from Jonathan Druart --- Created attachment 34191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34191&action=edit Bug 6679 - [SIGNED-OFF] fix 11 perlcritic violations in C4/Dates.pm - Subroutine prototypes used at line 82, column 1. See page 194 of PBP. (Severity: 5) - "return" statement with explicit "undef" at line 102, column 28. See page 199 of PBP. (Severity: 5) - Expression form of "eval" at line 108, column 20. See page 161 of PBP. (Severity: 5) - Variable declared in conditional statement at line 126, column 5. Declare variables outside of the condition. (Severity: 5) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 09:52:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 08:52:35 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #202 from Jonathan Druart --- Created attachment 34192 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34192&action=edit Bug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/TmplTokenType.pm - Subroutine prototypes used at line 86, column 1. See page 194 of PBP. (Severity: 5) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 09:52:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 08:52:41 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #203 from Jonathan Druart --- Created attachment 34193 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34193&action=edit Bug 6679 - [SIGNED-OFF] fix 6 perlcritic violations in C4/Reports/Guided.pm - Subroutine prototypes used at line 376, column 1. See page 194 of PBP. (Severity: 5) - Bareword file handle opened at line 757, column 2. See pages 202,204 of PBP. (Severity: 5) - Two-argument "open" used at line 757, column 2. See page 207 of PBP. (Severity: 5) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 09:52:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 08:52:48 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #204 from Jonathan Druart --- Created attachment 34194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34194&action=edit Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Record.pm Expression form of "eval" at line 358, column 5. See page 161 of PBP. (Severity: 5) Expression form of "eval" at line 367, column 5. See page 161 of PBP. (Severity: 5) Expression form of "eval" at line 510, column 3. See page 161 of PBP. (Severity: 5) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 09:52:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 08:52:55 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #205 from Jonathan Druart --- Created attachment 34195 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34195&action=edit Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Installer/PerlModules.pm Expression form of "eval" at line 71, column 9. See page 161 of PBP. (Severity: 5) Expression form of "eval" at line 85, column 13. See page 161 of PBP. (Severity: 5) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 09:53:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 08:53:03 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #206 from Jonathan Druart --- Created attachment 34196 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34196&action=edit Bug 6679 - Fixing code so it passes basic Perl:::Critic tests opac/ilsdi.pl: Stricture disabled at line 217, column 17. See page 429 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 09:53:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 08:53:11 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #207 from Jonathan Druart --- Created attachment 34197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34197&action=edit Bug 6679: (follow-up) fix 9 perlcritic violations in C4/TmplTokenType.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 09:54:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 08:54:46 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #208 from Jonathan Druart --- I rebased these patches. Some have already fixed. I removed 1: Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/ClassSortRoutine.pm It breaks completely Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 10:25:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 09:25:08 +0000 Subject: [Koha-bugs] [Bug 11733] "gist" system preference inconsistently treated as single-value or multi-value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11733 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #7 from sandboxes at biblibre.com --- Patch tested with a sandbox, by sonia.bouis at univ-lyon3.fr <2> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 10:25:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 09:25:20 +0000 Subject: [Koha-bugs] [Bug 11733] "gist" system preference inconsistently treated as single-value or multi-value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11733 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29623|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 10:25:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 09:25:30 +0000 Subject: [Koha-bugs] [Bug 11733] "gist" system preference inconsistently treated as single-value or multi-value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11733 --- Comment #8 from sandboxes at biblibre.com --- Created attachment 34198 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34198&action=edit Bug 12567: Make catalog statistics wizard publication year work for MARC21 Publication year was useless for MARC21, as it was using the biblioitems.publicationyear (UNIMARC) instead of biblio.copyrightdate (MARC21). This patch tries to fix the search options to work for both MARC flavours. To test: In Reports > Statistics wizards > Catalog: - Test the publication year search options on a UNIMARC and a MARC21 installation. - Make sure search results make sense for both. Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy The changes are fine with me, but this script is certainly not bug free. Also note that all its SQL should be moved out according to our coding guidelines. When doing so, a rewrite would be appropriate. Signed-off-by: Tomas Cohen Arazi Signed-off-by: sonia.bouis at univ-lyon3.fr <2> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 10:26:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 09:26:44 +0000 Subject: [Koha-bugs] [Bug 11733] "gist" system preference inconsistently treated as single-value or multi-value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11733 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 10:53:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 09:53:13 +0000 Subject: [Koha-bugs] [Bug 12801] Koha::Calendar is caching holidays for the wrong branch! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12801 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi --- Comment #16 from Olli-Antti Kivilahti --- Thanks for fixing this! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 10:59:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 09:59:49 +0000 Subject: [Koha-bugs] [Bug 13414] New: Enable right truncation with search by relevance Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414 Bug ID: 13414 Summary: Enable right truncation with search by relevance Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: koha at univ-lyon3.fr QA Contact: testopia at bugs.koha-community.org Created attachment 34199 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34199&action=edit Enable right truncation with search by relevance This patch slightly modifies build_weighted_query function (Search.pm) that defines the ranking levels for a search by relevance in order to make right truncation possible when QueryWeightFields syspref is activated (even ranked with little weight) it modifies the type of this syspref from boolean to choice in order to add this possiblity as a third option : Search by relevance with right truncation. Default remains Search by relevance (without truncation). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 12:39:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 11:39:36 +0000 Subject: [Koha-bugs] [Bug 11733] "gist" system preference inconsistently treated as single-value or multi-value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11733 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34198|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 12:39:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 11:39:41 +0000 Subject: [Koha-bugs] [Bug 11733] "gist" system preference inconsistently treated as single-value or multi-value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11733 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29623|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 12:48:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 11:48:32 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32452|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 12:48:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 11:48:35 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32451|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 12:48:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 11:48:37 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32450|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 12:48:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 11:48:40 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32449|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 12:48:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 11:48:43 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32448|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 12:48:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 11:48:45 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32447|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 12:48:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 11:48:49 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32446|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 12:51:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 11:51:05 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 12:51:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 11:51:09 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #140 from Jonathan Druart --- Created attachment 34200 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34200&action=edit Bug 6473: this is a test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 13:08:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 12:08:15 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #141 from sandboxes at biblibre.com --- Patch tested with a sandbox, by sonia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 13:08:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 12:08:34 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34200|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 13:08:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 12:08:44 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #142 from sandboxes at biblibre.com --- Created attachment 34201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34201&action=edit Bug 6473: this is a test Signed-off-by: sonia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 13:12:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 12:12:39 +0000 Subject: [Koha-bugs] [Bug 7741] Clear search terms in Z3950 search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7741 --- Comment #10 from Tom M --- I think I will need help with the CSS, where exactly do you want me to add the CSS styles? All I did was copy existing tags that were already on the page. If I move my stuff to the CSS file, would you want me touching other code on the page not relevant to what I was trying to do in my patch? Just want to make sure. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 13:18:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 12:18:08 +0000 Subject: [Koha-bugs] [Bug 13415] New: Prevent librarians from scanning multiple items into a single barcode field Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13415 Bug ID: 13415 Summary: Prevent librarians from scanning multiple items into a single barcode field Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It appears that some librarians will attempt to scan items as fast as they can without checking to make sure the checkout was submitted and the page reloaded properly. This can cause multiple barcodes to be scanned into the barcode field if the person is fast enough. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 13:26:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 12:26:17 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #28 from Paola Rossi --- I've tried to apply the patches agaist master 3.19.00.000 [The first patch needed a trivial rebase.] At the six-th patch: Applying: Bug 12648: Fix conflict with bug 12833 fatal: sha1 information is lacking or useless (svc/members/search). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 12648: Fix conflict with bug 12833 So I pass the patch to "Patch doesn't apply" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 13:41:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 12:41:35 +0000 Subject: [Koha-bugs] [Bug 13415] Prevent librarians from scanning multiple items into a single barcode field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13415 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 13:45:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 12:45:37 +0000 Subject: [Koha-bugs] [Bug 13415] Prevent librarians from scanning multiple items into a single barcode field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13415 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 13:45:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 12:45:40 +0000 Subject: [Koha-bugs] [Bug 13415] Prevent librarians from scanning multiple items into a single barcode field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13415 --- Comment #1 from Kyle M Hall --- Created attachment 34202 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34202&action=edit Bug 13415 - Prevent librarians from scanning multiple items into a single barcode field It appears that some librarians will attempt to scan items as fast as they can without checking to make sure the checkout was submitted and the page reloaded properly. This can cause multiple barcodes to be scanned into the barcode field if the person is fast enough. This causes the checkout of both ( or more! ) items to fail. Test Plan: 1) Apply this patch 2) Attempt to scan two or more items into the barcode field You can emulate this with a keybaord by hitting a few keys, then enter, then a few more keys, then enter again. The barcodes don't need to be valid for this test. 3) Note the dialog stating the barcode has been submitted and to please wait. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 13:47:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 12:47:24 +0000 Subject: [Koha-bugs] [Bug 13415] Prevent librarians from scanning multiple items into a single barcode field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13415 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34202|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 34203 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34203&action=edit Bug 13415 - Prevent librarians from scanning multiple items into a single barcode field It appears that some librarians will attempt to scan items as fast as they can without checking to make sure the checkout was submitted and the page reloaded properly. This can cause multiple barcodes to be scanned into the barcode field if the person is fast enough. This causes the checkout of both ( or more! ) items to fail. Test Plan: 1) Apply this patch 2) Attempt to scan two or more items into the barcode field You can emulate this with a keybaord by hitting a few keys, then enter, then a few more keys, then enter again. The barcodes don't need to be valid for this test. 3) Note the dialog stating the barcode has been submitted and to please wait. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 14:00:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 13:00:16 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34096|0 |1 is obsolete| | Attachment #34097|0 |1 is obsolete| | Attachment #34098|0 |1 is obsolete| | Attachment #34099|0 |1 is obsolete| | Attachment #34100|0 |1 is obsolete| | Attachment #34101|0 |1 is obsolete| | Attachment #34102|0 |1 is obsolete| | Attachment #34104|0 |1 is obsolete| | Attachment #34105|0 |1 is obsolete| | Attachment #34106|0 |1 is obsolete| | Attachment #34107|0 |1 is obsolete| | --- Comment #584 from Kyle M Hall --- Created attachment 34204 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34204&action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways bsoletes: 34103 - Bug 6427 - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 14:00:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 13:00:42 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #585 from Kyle M Hall --- Created attachment 34205 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34205&action=edit Bug 6427 - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 14:00:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 13:00:50 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #586 from Kyle M Hall --- Created attachment 34206 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34206&action=edit Bug 6427 - Add new Accounts related Koha modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 14:00:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 13:00:59 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #587 from Kyle M Hall --- Created attachment 34207 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34207&action=edit Bug 6427 - Update existing Koha perl modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 14:01:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 13:01:08 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #588 from Kyle M Hall --- Created attachment 34208 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34208&action=edit Bug 6427 - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 14:01:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 13:01:19 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #589 from Kyle M Hall --- Created attachment 34209 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34209&action=edit Bug 6427 - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 14:01:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 13:01:27 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #590 from Kyle M Hall --- Created attachment 34210 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34210&action=edit Bug 6427 - Add new staff scripts for managing accounts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 14:01:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 13:01:35 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34103|0 |1 is obsolete| | --- Comment #591 from Kyle M Hall --- Created attachment 34211 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34211&action=edit Bug 6427 - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 14:01:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 13:01:43 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #592 from Kyle M Hall --- Created attachment 34212 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34212&action=edit Bug 6427 - Update OPAC scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 14:01:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 13:01:51 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #593 from Kyle M Hall --- Created attachment 34213 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34213&action=edit Bug 6427 - Add & update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 14:02:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 13:02:00 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #594 from Kyle M Hall --- Created attachment 34214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34214&action=edit Bug 6427 - Delete unused and unnecessary files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 14:02:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 13:02:09 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #595 from Kyle M Hall --- Created attachment 34215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34215&action=edit Bug 6427 - Unit Tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 14:44:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 13:44:50 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |paola.rossi at cineca.it --- Comment #39 from Paola Rossi --- I've tried to apply the patches against master 3.19.00.000 The second patch needed some [almost trivial] rebasing: Applying: BZ7677: New areas in subscriptions and new functions when receiving. Using index info to reconstruct a base tree... :49: trailing whitespace. ORDER BY serialid DESC LIMIT $nth,1 :97: trailing whitespace. $staffdisplaycount, $opacdisplaycount, $graceperiod, $location, $enddate, :197: trailing whitespace. choices: warning: 3 lines add whitespace errors. Falling back to patching base and 3-way merge... Auto-merging serials/serials-edit.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/kohastructure.sql Auto-merging C4/Serials.pm Failed to merge in the changes. Patch failed at 0001 BZ7677: New areas in subscriptions and new functions when receiving. I pass the patch to "Patch doesn't apply" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 14:50:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 13:50:16 +0000 Subject: [Koha-bugs] [Bug 13416] New: Typo in marc21_leader.pl position 5 (record status) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 Bug ID: 13416 Summary: Typo in marc21_leader.pl position 5 (record status) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Instead of a space in the leader on this position, it should be an a. Trivial fix forthcoming. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 14:52:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 13:52:35 +0000 Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21864|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize --- Created attachment 34216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34216&action=edit [SIGNED OFF] Bug - 5511: Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. To Test: 1) Enable the system preference SessionRestrictionByIP 2) Change your system IP. It will not checkout your system IP or signout. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 14:52:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 13:52:39 +0000 Subject: [Koha-bugs] [Bug 13416] Typo in marc21_leader.pl position 5 (record status) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 --- Comment #1 from M. de Rooy --- Created attachment 34217 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34217&action=edit Bug 13416: Typo in marc21_leader.pl position 5 (record status) Instead of a space in the leader on this position, it should be an a. Test plan: Use the popup to set position 5 to a (increase in encoding level). Check if this patch puts an a in that position of the leader. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 14:52:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 13:52:37 +0000 Subject: [Koha-bugs] [Bug 13416] Typo in marc21_leader.pl position 5 (record status) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 14:52:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 13:52:45 +0000 Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22533|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize --- Created attachment 34218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34218&action=edit [SIGNED OFF] Bug -5511- Added new system preference: SessionRestrictionByIP Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 14:52:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 13:52:51 +0000 Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 --- Comment #22 from Martin Renvoize --- Created attachment 34219 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34219&action=edit Bug - 5511 [Followup]: Switched defults Agree with Chris that the defualt should maintain the higher security and not reduce it. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 14:53:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 13:53:13 +0000 Subject: [Koha-bugs] [Bug 13416] Typo in marc21_leader.pl position 5 (record status) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 14:54:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 13:54:25 +0000 Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 --- Comment #23 from Martin Renvoize --- I gave up on waiting for Amit here. I agree with, and have implemented as a followup, the reversal of defaults that Chris suggests. I've also signed off on the first two patches. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 14:57:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 13:57:46 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 14:57:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 13:57:50 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28950|0 |1 is obsolete| | Attachment #29570|0 |1 is obsolete| | Attachment #29571|0 |1 is obsolete| | Attachment #29572|0 |1 is obsolete| | --- Comment #40 from Jonathan Druart --- Created attachment 34220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34220&action=edit Bug 7677: UT: add unit tests for GetPreviousSerialid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 14:57:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 13:57:57 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 --- Comment #41 from Jonathan Druart --- Created attachment 34221 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34221&action=edit BZ7677: New areas in subscriptions and new functions when receiving. When enabling the makePreviousSerialAvailable syspref, the previously received serial's itemtype is set as defined in the subscription. (Please note that the item-level_itypes syspref must be set to specific item.) It is also made available. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 14:58:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 13:58:01 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 --- Comment #42 from Jonathan Druart --- Created attachment 34222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34222&action=edit Bug 7677: FIX QA issues FAIL C4/Serials.pm FAIL forbidden patterns forbidden pattern: trailing space char (line 1501) forbidden pattern: trailing space char (line 921) FAIL serials/serials-edit.pl FAIL valid "my" variable $dbh masks earlier declaration in same scope -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 14:58:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 13:58:06 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 --- Comment #43 from Jonathan Druart --- Created attachment 34223 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34223&action=edit BZ7677 [Follow-up]: New areas in subscriptions and new functions when receiving. - Make the newly received serial gets its default itemtype from the subscription. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 15:02:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 14:02:45 +0000 Subject: [Koha-bugs] [Bug 13361] EAN 13 Printed Label shows 12 digits barcode after reading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13361 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #1 from Chris Nighswonger --- If you want the leading zeros trimmed, I believe you will need to set your barcode scanner up to handle that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 15:10:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 14:10:49 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33186|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart --- Created attachment 34224 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34224&action=edit Bug 12648: Link patrons to an order - DB changes This patch inserts the new notification template into the letters table. It also add the insert statements into the language specific files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 15:10:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 14:10:52 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33187|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart --- Created attachment 34225 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34225&action=edit Bug 12648: Refactoring to prepare user search for reuse A previous enhancement allows to link basket with patrons. Next patches will use the same way to link order with patrons. In order to avoir c/p of code, this patch refactores this part of code. Test plan: 1/ Verify there is no regression on adding/modifying users to a basket. (acqui/basket.pl?basketno=XXX, "Managed by", "Add user"). 2/ Note that you get a friendly message if the user is already present in the list and when the user has correctly been added to the list. 3/ Note that the list uses the member search service (ie. DataTable + serverside processing). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 15:10:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 14:10:55 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33188|0 |1 is obsolete| | --- Comment #31 from Jonathan Druart --- Created attachment 34226 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34226&action=edit Bug 12648: Link patrons to an order This patch is the main patch. This feature adds the ability to link patrons to an order. On that way, they will be notified when the order is completely received. Test plan: 1/ Execute the updatedb entry and verify you have a new notification template in your table (tools/letter.pl). code: ACQ_NOTIF_ON_RECEIV, module: acquisition 2/ You can edit it if you want 3/ Create a basket and create an order with 1 or more items 4/ Link 1+ patrons to this order 5/ Close the basket and receive the order 6/ When you have received all items for this order, all patrons attached will be notified. Check the message_queue table to check if the letters have correctly been added to the queue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 15:10:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 14:10:58 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33189|0 |1 is obsolete| | --- Comment #32 from Jonathan Druart --- Created attachment 34227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34227&action=edit Bug 12648: Add unit tests for C4::Acquisition::*OrderUsers Test plan: Verify that unit tests pass with prove t/db_dependent/Acquisition/OrderUsers.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 15:11:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 14:11:01 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33190|0 |1 is obsolete| | --- Comment #33 from Jonathan Druart --- Created attachment 34228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34228&action=edit Bug 12648: The users added to basket should have a permission Before this enh, the users to add to a basket should have the acquisition.order_manage permission. This patch reintroduces this behavior. The code in acqui/add_user_search.pl was never used. The filter should be done in the members/search service. But it is not possible easily to filter using a sql query, so the filter is done after. This means that we cannot use the DT pagination (otherwise the results will become inconsistent). Test plan: 1/ On adding patrons to a basket, verify that the search patron results contain patron with the acquisition.order_manage permission. 2/ Verify that all patrons are return on the 'normal' patron search and when adding patrons to an order. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 15:11:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 14:11:04 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33191|0 |1 is obsolete| | --- Comment #34 from Jonathan Druart --- Created attachment 34229 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34229&action=edit Bug 12648: Fix conflict with bug 12833 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 15:11:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 14:11:07 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33192|0 |1 is obsolete| | --- Comment #35 from Jonathan Druart --- Created attachment 34230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34230&action=edit Bug 12648: Hide the result search on load When no search has been done yet, it's not necessary to display the result list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 15:11:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 14:11:11 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33193|0 |1 is obsolete| | --- Comment #36 from Jonathan Druart --- Created attachment 34231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34231&action=edit Bug 12648: The patron's name should be the same as before The displayed patron's name should be surname + firstname -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 15:11:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 14:11:51 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #37 from Jonathan Druart --- Patches rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 15:12:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 14:12:10 +0000 Subject: [Koha-bugs] [Bug 5884] ability to print on label sheet with diff sized labels In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5884 --- Comment #1 from Chris Nighswonger --- You are right, the templating system cannot currently handle this type of lable. Code would need to be written to do this sort of thing. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 15:14:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 14:14:21 +0000 Subject: [Koha-bugs] [Bug 7015] Fixup Template Code to Accommodate More Variety of Label Styles In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7015 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #1 from Chris Nighswonger --- *** Bug 5884 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 15:14:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 14:14:21 +0000 Subject: [Koha-bugs] [Bug 5884] ability to print on label sheet with diff sized labels In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5884 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Chris Nighswonger --- I acutally have an enhancement request opened for this; so I'm marking this a dup of that. *** This bug has been marked as a duplicate of bug 7015 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 15:21:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 14:21:12 +0000 Subject: [Koha-bugs] [Bug 8601] Allow more pictures on Patron Cards In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8601 --- Comment #1 from Chris Nighswonger --- This is an excellent idea and could be easily implemented by modifying the code to allow the user to add more image fields in the interface. The back-end code which process the xml can handle it already as you have discovered. Also note that it is not necessary to include a patron image if you do not want to. In its current form the tool allows for any two images both of which may be other than the patron image. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 15:41:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 14:41:26 +0000 Subject: [Koha-bugs] [Bug 13408] Tell librarians they may continue scanning while checkouts table is loading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13408 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34175|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 34232 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34232&action=edit [SIGNED-OFF] Bug 13408: Tell librarians they may continue scanning while checkouts table is loading Some librarians do not realize they can continue scanning items even if the checkouts table has not loaded. We should have Koha tell them explicitly that they may continue scanning barcodes. Test Plan: 1) Apply this patch 2) Load the checkouts table on circulation.pl, note the loading message is now Loading... you may continue scanning. 3) Load the checkouts table on moremember.pl, note the loading message is still Loading... Signed-off-by: Owen Leonard This one works too! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 15:52:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 14:52:09 +0000 Subject: [Koha-bugs] [Bug 13417] New: New permission to allow staff to remove public lists Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Bug ID: 13417 Summary: New permission to allow staff to remove public lists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Currently a public list can only be deleted by its owner. This means lists can exist infinitely. This will introduce a new permission for list. With this permission, a staff member will be allow to delete any public lists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 15:53:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 14:53:53 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9833, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7310 Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 15:53:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 14:53:53 +0000 Subject: [Koha-bugs] [Bug 9833] New virtual shelves/lists permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13417 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 15:53:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 14:53:53 +0000 Subject: [Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13417 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 15:56:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 14:56:32 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 15:56:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 14:56:35 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #1 from Jonathan Druart --- Created attachment 34233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34233&action=edit Bug 13417: Allow staff members to manage public lists Currently a public list can only be deleted by its owner. This means lists can exist infinitely. This will introduce a new permission for list. With this permission, a staff member will be allow to delete any public lists. Test plan: 1/ Add the manage_shelves permission to a patron. 2/ Login with this patron 3/ Go on the public list view 4/ You should be able to edit all public lists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 15:57:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 14:57:36 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #2 from Jonathan Druart --- Files for other languages will be add later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 16:09:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 15:09:14 +0000 Subject: [Koha-bugs] [Bug 13418] New: The C4::VirtualShelves::Page needs some cleaning Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13418 Bug ID: 13418 Summary: The C4::VirtualShelves::Page needs some cleaning Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 16:16:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 15:16:32 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22280|0 |1 is obsolete| | --- Comment #70 from Koha Team Lyon 3 --- Created attachment 34234 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34234&action=edit Bug 8236 Renewing policy in overdue or restriction case The patch have been remade again in a slight different way : It now introduces 2 sysprefs : RestrictionBlockRenewing to allow/block renewal of items when patron is restricted. OverduesBlockRenewing to allow, block only the late ones or block all checked out items. Default is "allow" in both case. Test Plan : Apply patch. The database must then be updated (so it cannot be tested on sandbox unless you asked the maintainer for doing so). RestrictionBlockRenewing is set by default to allow renewing of late items : 1) choose a borrowernumber (you also need his login and password) and 2 items : item1 and item2. 2) check out item1 3) check out item2 with an already passed due date (using the Specify-due-date box) 4) click on restritions tab and add a manual restriction You can see that renewal is still possible for both items. 5) Now go to set the syspref to block status and go back to patron's account : You can see a "not renewable : patron restricted" warning instead of the previous checkboxes. 6) check the "Override renewal limit" checkbox tand verify that renewing is still possible by this way OverduesBlockRenewing is set by default to allow renewing of late items : 7)Now remove the restriction, set the OverdueBlockRenewing syspref to "Block renewal only for late items" and go back to patron's professionnal page 8) The renewal is possible for item1 and not allowed for item2 (a "Not allowed : overdue" warning is displayed). 9) Set syspref to "Block renewal for all items".. 10) Both items display the "not allowed" warning instead of a checkbox. 11) set the syspref to "allow renewal" 12) Both items can be renewed 13) check the "Override renewal limit" checkbox and verify that renewing is still possible by this way. 14) Connect to the patron's personal file and note that both items are renewable. 15) Redo stages 7 up to 10. Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 16:18:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 15:18:21 +0000 Subject: [Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315 --- Comment #4 from Owen Leonard --- Here's the way it works with Kyle's patch: http://www.screencast.com/t/qNw2U3hwz I'm inclined to do something less obtrusive: http://www.screencast.com/t/1gsa2prF ...on the assumption that the visual aspect of checking out was working fine before AJAX circ, and fixes to AJAX circ should look to returning things to a proven-functional state. However, always assuming that it was better before would prevent us from making improvements, so I want hear opinions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 16:18:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 15:18:37 +0000 Subject: [Koha-bugs] [Bug 12895] Dropbox mode doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12895 --- Comment #4 from Koha Team Lyon 3 --- Yes it's also for 3.18 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 16:18:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 15:18:40 +0000 Subject: [Koha-bugs] [Bug 13415] Prevent librarians from scanning multiple items into a single barcode field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13415 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 16:18:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 15:18:42 +0000 Subject: [Koha-bugs] [Bug 13415] Prevent librarians from scanning multiple items into a single barcode field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13415 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34203|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 34235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34235&action=edit [SIGNED OFF] Bug 13415 - Prevent librarians from scanning multiple items into a single barcode field It appears that some librarians will attempt to scan items as fast as they can without checking to make sure the checkout was submitted and the page reloaded properly. This can cause multiple barcodes to be scanned into the barcode field if the person is fast enough. This causes the checkout of both ( or more! ) items to fail. Test Plan: 1) Apply this patch 2) Attempt to scan two or more items into the barcode field You can emulate this with a keybaord by hitting a few keys, then enter, then a few more keys, then enter again. The barcodes don't need to be valid for this test. 3) Note the dialog stating the barcode has been submitted and to please wait. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 16:19:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 15:19:23 +0000 Subject: [Koha-bugs] [Bug 13415] Prevent librarians from scanning multiple items into a single barcode field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13415 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- Works well for me, and code looks fine. Signing Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 16:19:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 15:19:51 +0000 Subject: [Koha-bugs] [Bug 12895] Dropbox mode doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12895 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.12 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 16:19:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 15:19:55 +0000 Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 16:19:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 15:19:55 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 16:28:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 15:28:06 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |koha at univ-lyon3.fr --- Comment #40 from Koha Team Lyon 3 --- There's a problem when applying this patch on a sandbox : The sandbox you've requested is not ready. Some problems occurred applying patches from bug 10937:

Something went wrong !

Applying: Bug 10947 - Grouped ItemTypes - Patch should apply properly on latest master. Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Koha.pm Auto-merging installer/data/mysql/kohastructure.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt CONFLICT (delete/modify): koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt deleted in HEAD and modified in Bug 10947 - Grouped ItemTypes - Patch should apply properly on latest master.. Version Bug 10947 - Grouped ItemTypes - Patch should apply properly on latest master. of koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt left in tree. Auto-merging opac/opac-search.pl Failed to merge in the changes. Patch failed at 0001 Bug 10947 - Grouped ItemTypes - Patch should apply properly on latest master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 16:30:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 15:30:20 +0000 Subject: [Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #3 from sandboxes at biblibre.com --- Patch tested with a sandbox, by sonia.bouis at univ-lyon3.fr <2> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 16:30:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 15:30:30 +0000 Subject: [Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29976|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 16:30:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 15:30:38 +0000 Subject: [Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 --- Comment #4 from sandboxes at biblibre.com --- Created attachment 34236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34236&action=edit Bug 12567: Make catalog statistics wizard publication year work for MARC21 Publication year was useless for MARC21, as it was using the biblioitems.publicationyear (UNIMARC) instead of biblio.copyrightdate (MARC21). This patch tries to fix the search options to work for both MARC flavours. To test: In Reports > Statistics wizards > Catalog: - Test the publication year search options on a UNIMARC and a MARC21 installation. - Make sure search results make sense for both. Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy The changes are fine with me, but this script is certainly not bug free. Also note that all its SQL should be moved out according to our coding guidelines. When doing so, a rewrite would be appropriate. Signed-off-by: Tomas Cohen Arazi Signed-off-by: sonia.bouis at univ-lyon3.fr <2> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 16:44:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 15:44:23 +0000 Subject: [Koha-bugs] [Bug 13415] Prevent librarians from scanning multiple items into a single barcode field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13415 --- Comment #5 from Owen Leonard --- - [% IF NEEDSCONFIRMATION %] - [% ELSE %] - - [% END %] This change means that all circulation transactions must wait until document.ready() fires. Is this what we want? + $('#mainform').bind('submit',function() { + $('#barcode').on('keypress',function(event) { Is there a reason to use bind() on #mainform instead of on()? "As of jQuery 1.7, the .on() method is the preferred method for attaching event handlers to a document." https://api.jquery.com/bind/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 16:44:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 15:44:54 +0000 Subject: [Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #5 from Christopher Brannon --- (In reply to Owen Leonard from comment #4) > Here's the way it works with Kyle's patch: > > http://www.screencast.com/t/qNw2U3hwz > > I'm inclined to do something less obtrusive: > > http://www.screencast.com/t/1gsa2prF > > ...on the assumption that the visual aspect of checking out was working fine > before AJAX circ, and fixes to AJAX circ should look to returning things to > a proven-functional state. > > However, always assuming that it was better before would prevent us from > making improvements, so I want hear opinions. Owen, I would be more inclined to see the feedback in the same area that I'm scanning in (in the same box). Maybe at the bottom? It is less scanning around the screen. You are already looking there when scanning, why not have it in the same area? The concept is similar to switching between the keyboard and mouse. If I am given the option, I will choose a technique that requires the least amount of reorientation. Just my two cents. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 16:57:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 15:57:15 +0000 Subject: [Koha-bugs] [Bug 13418] The C4::VirtualShelves::Page needs some cleaning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13418 --- Comment #1 from Jonathan Druart --- Created attachment 34237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34237&action=edit Bug 13418: Clean C4::VirtualShelves::Page a bit I tried to reuse this package for a new development, I did not manage. It's a really hard to read and to understand. Here my first try, this patch only remove the call to _shelf_count in the GetShelves subroutine. Someone might want to get this value for another reason and from somewhere else. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 16:57:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 15:57:12 +0000 Subject: [Koha-bugs] [Bug 13418] The C4::VirtualShelves::Page needs some cleaning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13418 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 16:57:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 15:57:20 +0000 Subject: [Koha-bugs] [Bug 13418] The C4::VirtualShelves::Page needs some cleaning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13418 --- Comment #2 from Jonathan Druart --- Created attachment 34238 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34238&action=edit Bug 13418: Clean C4::VirtualShelves::Page - Part 2 I don't understand at all the usefulness of $privshelflist and $privtotshelves in C4::VirtualShelves::Page They look useless. If you deep in the git history, you will find commit 25eb36f21fe952118327d2c84dfef5d38eee31a7 Bug #2531 Cannot delete private shelf I am not able to reproduce this issue after this patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 16:58:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 15:58:09 +0000 Subject: [Koha-bugs] [Bug 13418] The C4::VirtualShelves::Page needs some cleaning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13418 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 16:58:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 15:58:19 +0000 Subject: [Koha-bugs] [Bug 13290] Add better feedback for returns to the checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13290 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #13 from Owen Leonard --- The standard term in the default English templates is "checked in," not "returned." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 17:09:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 16:09:19 +0000 Subject: [Koha-bugs] [Bug 13419] New: Add filters and server-side processing to the shelves list view Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Bug ID: 13419 Summary: Add filters and server-side processing to the shelves list view Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl This will be a new enhancement: Search and filter the lists on the intranet side. The OPAC won't be affected by this patch set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 17:15:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 16:15:13 +0000 Subject: [Koha-bugs] [Bug 13420] New: sorting on volume number is not sorting right Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 Bug ID: 13420 Summary: sorting on volume number is not sorting right Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 34239 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34239&action=edit opac See attached. In the staff client and OPAC when you short on volume things are not sorted the way the user would expect. 19 is coming after 160 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 17:15:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 16:15:21 +0000 Subject: [Koha-bugs] [Bug 13420] sorting on volume number is not sorting right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.16 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 17:15:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 16:15:31 +0000 Subject: [Koha-bugs] [Bug 13420] sorting on volume number is not sorting right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 --- Comment #1 from Nicole C. Engard --- Created attachment 34240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34240&action=edit staff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 17:15:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 16:15:42 +0000 Subject: [Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #1 from Jonathan Druart --- Created attachment 34241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34241&action=edit Bug 13419: Add server-side processing for lists This patch adds DataTables using a server-side processing to display lists (virtual shelves). Test plan: 1/ Go on virtualshelves/shelves.p 2/ Play with the table functions (sort, filter, pagination, etc.) 3/ Go with the Public lists tab and verify the table is correctly filtered. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 17:15:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 16:15:39 +0000 Subject: [Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 17:15:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 16:15:46 +0000 Subject: [Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #2 from Jonathan Druart --- Created attachment 34242 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34242&action=edit Bug 13419: Add filters on the list table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 17:15:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 16:15:51 +0000 Subject: [Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #3 from Jonathan Druart --- Created attachment 34243 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34243&action=edit Bug 13419: Add tests Test plan: prove t/db_dependent/Utils/Datatables_Virtualshelves.t should return green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 17:17:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 16:17:34 +0000 Subject: [Koha-bugs] [Bug 13421] New: Add the creation time for virtual shelves Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13421 Bug ID: 13421 Summary: Add the creation time for virtual shelves Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Currently it's not possible to know when a list has been created. It could be useful to have this data. That will permit to remove old lists, for instance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 17:17:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 16:17:49 +0000 Subject: [Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 17:18:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 16:18:04 +0000 Subject: [Koha-bugs] [Bug 13421] Add the creation time for virtual shelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13421 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |13419 Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 17:18:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 16:18:04 +0000 Subject: [Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13421 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 17:20:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 16:20:10 +0000 Subject: [Koha-bugs] [Bug 13421] Add the creation time for virtual shelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13421 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 17:20:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 16:20:13 +0000 Subject: [Koha-bugs] [Bug 13421] Add the creation time for virtual shelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13421 --- Comment #1 from Jonathan Druart --- Created attachment 34244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34244&action=edit Bug 13421: Add the creation time for virtual shelves Test plan: 1/ Execute the updatedb entry 2/ Create a list 3/ Go on the shelve list and confirm that the creation and last modification time are now displayed. 4/ Confirm that you are able to sort the list by creation/modification time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 17:34:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 16:34:57 +0000 Subject: [Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315 Jason Burds changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jburds at dubuque.lib.ia.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 17:42:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 16:42:43 +0000 Subject: [Koha-bugs] [Bug 13410] Untranslatable "Change messaging preferences to default for this category?" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13410 --- Comment #1 from Marc V?ron --- Created attachment 34245 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34245&action=edit Bug 13410 - Untranslatable "Change messaging preferences to default for this category?" To test: In staff client, go to Home > Patrons Click button "New patron" and choose a category Change Patron messaging preferences Now change Category Make sure that following message box still appears: "Change messaging preferences to default for this category?" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 17:43:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 16:43:39 +0000 Subject: [Koha-bugs] [Bug 13410] Untranslatable "Change messaging preferences to default for this category?" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13410 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 18:01:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 17:01:03 +0000 Subject: [Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315 --- Comment #6 from Owen Leonard --- (In reply to Christopher Brannon from comment #5) > I would be more inclined to see the feedback in the same area that I'm > scanning in (in the same box). Maybe at the bottom? I like this idea too! Here's my take: http://www.screencast.com/t/ZcsPfJabP The advantage to this method is that the feedback is visible even for patrons with lost of information in the messages column: http://www.screencast.com/t/3uEHAaWnUyc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 18:17:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 17:17:35 +0000 Subject: [Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315 --- Comment #7 from Jason Burds --- If I have a vote it's for this one. http://www.screencast.com/t/ZcsPfJabP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 18:19:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 17:19:48 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |paola.rossi at cineca.it --- Comment #9 from Paola Rossi --- I've applied the patches [13369,13370,13371] against 3.19.00.000 'Item count' and 'Biblio count' didn't yet work: "No matching records found" (even if some records matched my search). So I pass the patch to "Failed QA" status. NB1. A patron "Xa" of the library "Yb" had created the basket. In the "Created by" column of that basket I saw: XaYb (without spaces). I think that the value "Xa Yb" would be preferred; otherwise filtering "aY" would find that row (ERROR). NB2. On koha/acqui/acqui-home.pl I wrote nothing in vendor's field. Koha answered the default list of the vendor/baskets. It was: You searched on vendor , 10 results found Show active and inactive baskets | Show opened baskets only Showing 1 to 6 of 6 Was the result 10 or 6? It's not so clear at once that the 4 missing baskets are the inactive ones. [I myself went early in confusion while I was testing, see below NB4.] Remember that on master the default is the complete list of vendors: if a vendor has only one inactive basket, the vendor is not listed at all! So the deault filter chosen in this bug: Show active and inactive baskets | Show opened baskets only didn't correspond to the current default of master. NB3. Same search as NB2, on the empty-vendor list's answer. One vendor of mine was "inactive". But I saw it in the list of vendors. So an "inactive" basket is not the basket of an "inactive" vendor. So, I'm in doubt: what is an "inactive"/"active" basket? Some of the listed baskets had still expected items > 0: they're active, aren't they? But an open basket had 0 biblio, 0 items, 0 expected items: it was listed as active. Is it right? NB4. On ACQ home, I saw for the table of funds: Hide inactive budgets | Show inactive budgets Imho the use of the same kind of filters might perhaps be clearer: Show inactive baskets | Hide inactive baskets | Show closed baskets | Hide closed baskets NB5. In a closed basket, 1 item was ordered, 1 item was partial and 1 item was completely received. When I selected only the active baskets, the item count is 2. When both the active and inactive baskets were selected, the item count is 3. I'm in doubt: is it right? NB6. "Expected items" might be preferred to "Items expected". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 18:25:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 17:25:58 +0000 Subject: [Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315 --- Comment #8 from Christopher Brannon --- (In reply to Owen Leonard from comment #6) > (In reply to Christopher Brannon from comment #5) > > I would be more inclined to see the feedback in the same area that I'm > > scanning in (in the same box). Maybe at the bottom? > > I like this idea too! Here's my take: > > http://www.screencast.com/t/ZcsPfJabP > > The advantage to this method is that the feedback is visible even for > patrons with lost of information in the messages column: > > http://www.screencast.com/t/3uEHAaWnUyc Excellent. My OCD side of me says indent everything past "Checked out:" so it is more visually attractive. Something like this: http://screencast.com/t/EC4qcKNixO But this is just a simulated example. Don't know how the formatting would actually look or work. I'd also suggest a contrasting background color to help bring attention to it. Unlike some of the warning messages that are yellow, I'd maybe use a faint green background? Here's another example, with the header above and slightly larger, with a colored background: http://screencast.com/t/hDNBknJ8e Anyway, I think placement is excellent. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 18:31:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 17:31:03 +0000 Subject: [Koha-bugs] [Bug 13218] usability enhancement for z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13218 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33768|0 |1 is obsolete| | --- Comment #18 from Owen Leonard --- Created attachment 34246 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34246&action=edit [SIGNED-OFF] Bug 13218 - fixing acquisitions z39.50 interface to be consistent with the others. Changes: * Two columns of search fields into one * moves targets from below search fields to the right of them To test: * Create a basket in acquisitions * attempt to add a record to the order from an external source * note the changes to the layout * complete a couple of additions to the basket - functionality should be unchanged. If you like the changes, sign off :) Signed-off-by: Frederic Demians Ok. Consistency welcomed! Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 18:31:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 17:31:00 +0000 Subject: [Koha-bugs] [Bug 13218] usability enhancement for z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13218 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 18:44:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 17:44:30 +0000 Subject: [Koha-bugs] [Bug 13422] New: SCO: "Would you like to rpint a receipt" not translatable Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13422 Bug ID: 13422 Summary: SCO: "Would you like to rpint a receipt" not translatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr To reproduce: Set syspref SelfCheckReceiptPrompt to "Show" Select non English language Go to Self Checkout and check out an item Hit "Finish" Confirm dialog "Would you like to print a receipt" appears in English -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 18:45:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 17:45:11 +0000 Subject: [Koha-bugs] [Bug 13422] SCO: "Would you like to rpint a receipt" not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13422 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 18:54:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 17:54:58 +0000 Subject: [Koha-bugs] [Bug 13422] SCO: "Would you like to rpint a receipt" not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13422 --- Comment #1 from Marc V?ron --- Created attachment 34247 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34247&action=edit Bug 13422 - SCO: "Would you like to rpint a receipt" not translatable To test: Set syspref SelfCheckReceiptPrompt to "Show" Select non English language Go to Self Checkout and check out an item Hit "Finish" Make sure that confirm dialog "Would you like to print a receipt" still appears -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 18:56:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 17:56:15 +0000 Subject: [Koha-bugs] [Bug 13422] SCO: "Would you like to print a receipt" not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13422 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch Summary|SCO: "Would you like to |SCO: "Would you like to |rpint a receipt" not |print a receipt" not |translatable |translatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 19:09:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 18:09:51 +0000 Subject: [Koha-bugs] [Bug 13423] New: Untranslatable strings in serials-edit.tt and serials-recieve.tt Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 Bug ID: 13423 Summary: Untranslatable strings in serials-edit.tt and serials-recieve.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr git grep 'confirm("' Result: 2 untranslatable stings in: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt 2 untranslatable strings in: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 19:11:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 18:11:37 +0000 Subject: [Koha-bugs] [Bug 7741] Clear search terms in Z3950 search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7741 --- Comment #11 from Owen Leonard --- Created attachment 34248 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34248&action=edit Bug 7741 [Follow-up] Clear search terms in Z3950 search page This patch makes a follow-up change and takes as its basis a dependency on Bug 13218 - usability enhancement for z39.50 search. If we have a one-column search form it's possible to put the "Clear search form" link at the bottom of the form rather than in the header, logically associating it with the grouping of form fields which will be affected. Doing so also allows us to eliminate all the custom styling which was an issue for QA. Other changes made by this patch: Fixing the indentation error, correcting the case of the link text ("Clear search form" instead of "Clear Search Form"), and adding "preventDefault()" to the click handler so that clicking the link doesn't scroll the user back to the top of the page. To test, apply the previous patch and this one on top of Bug 13218. Repeat the test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 19:12:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 18:12:20 +0000 Subject: [Koha-bugs] [Bug 7741] Clear search terms in Z3950 search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7741 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED Depends on| |13218 Assignee|savitra.sirohi at osslabs.biz |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 19:12:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 18:12:20 +0000 Subject: [Koha-bugs] [Bug 13218] usability enhancement for z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13218 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7741 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 19:12:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 18:12:35 +0000 Subject: [Koha-bugs] [Bug 7741] Clear search terms in Z3950 search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7741 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 19:13:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 18:13:17 +0000 Subject: [Koha-bugs] [Bug 8601] Allow more pictures on Patron Cards In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8601 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 19:32:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 18:32:24 +0000 Subject: [Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 19:32:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 18:32:44 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #3 from Marc V?ron --- Created attachment 34249 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34249&action=edit [Signed-off] Bug 13417: Allow staff members to manage public lists Currently a public list can only be deleted by its owner. This means lists can exist infinitely. This will introduce a new permission for list. With this permission, a staff member will be allow to delete any public lists. Test plan: 1/ Add the manage_shelves permission to a patron. 2/ Login with this patron 3/ Go on the public list view 4/ You should be able to edit all public lists Followed test plan. Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 19:33:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 18:33:18 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34233|0 |1 is obsolete| | CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 19:33:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 18:33:25 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 19:34:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 18:34:02 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 19:34:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 18:34:26 +0000 Subject: [Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33765|0 |1 is obsolete| | --- Comment #9 from Owen Leonard --- Created attachment 34250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34250&action=edit [SIGNED-OFF] Bug 13315 - Add feedback for last item checked out to circulation.pl It seems that many librarians find it disconcerting to have no feedback with the new checkouts table. It seems that many of them wait for it to fully load, check to verify the item was checked out, and only then check out the next item. To help alleviate this issue, we can have the checkouts page give feedback about the item that was just checked out. Test Plan: 1) Apply this patch 2) Check an item out 3) Note the message "$title ($barcode) due on $date_due" Signed-off-by: Owen Leonard This works well and fixes a very problematic issue with the new AJAX circ. I will be submitting a follow-up which I think is an improvement to the display. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 19:34:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 18:34:55 +0000 Subject: [Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315 --- Comment #10 from Owen Leonard --- Created attachment 34251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34251&action=edit Bug 13315 [Follow-up] Add feedback for last item checked out to circulation.pl This patch changes the position and styling of the information about the last checkout so that it is grouped with the checkout form itself, placing the message in a more visible position, especially for patrons with a lot of information in the right-hand messages column which might push the checkouts table down offscreen. To test, apply the patch and clear your browser cache in order to refresh the main CSS file. Check out an item and confirm that a message is prominently displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 19:42:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 18:42:57 +0000 Subject: [Koha-bugs] [Bug 13421] Add the creation time for virtual shelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13421 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- Wanted to test, got: Applying: Bug 13421: Add the creation time for virtual shelves fatal: sha1 information is lacking or useless (C4/Utils/DataTables/VirtualShelves.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 20:26:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 19:26:23 +0000 Subject: [Koha-bugs] [Bug 13424] New: Only suggestion "managed by" staff member can order the suggestion. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13424 Bug ID: 13424 Summary: Only suggestion "managed by" staff member can order the suggestion. Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: ed.veal at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org If staff member A accepts a suggestion they get tagged as the "Managed by" user account therefor limiting others from ordering that suggestion. If you have staff that are responsible for addressing suggestions and other staff responsible for ordering this is a problem. Ed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 20:27:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 19:27:02 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #5 from rgravel at marlboro.edu --- It should be a rare case that both an $e term and a $4 code are present in one field, since PCC guidelines instruct us not to use both. However, if a similar best practice is not observed internationally, then we should certainly amend the change to specify the $4 should be ignored in favor of the $e. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 20:31:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 19:31:19 +0000 Subject: [Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315 Jason Burds changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #11 from Jason Burds --- Looks good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 20:34:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 19:34:14 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #6 from Katrin Fischer --- I know that currently for records in our union catalog both are used simultanously - so it would be an issue for our libraries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 20:45:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 19:45:56 +0000 Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 20:45:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 19:45:59 +0000 Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34219|0 |1 is obsolete| | --- Comment #24 from Chris Cormack --- Created attachment 34252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34252&action=edit Bug - 5511 [Followup]: Switched defults Agree with Chris that the defualt should maintain the higher security and not reduce it. Signed-off-by: Martin Renvoize Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 20:47:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 19:47:07 +0000 Subject: [Koha-bugs] [Bug 13424] Only suggestion "managed by" staff member can order the suggestion. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13424 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 12775 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 20:47:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 19:47:07 +0000 Subject: [Koha-bugs] [Bug 12775] Only suggestion manager can order from accepted suggestion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12775 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ed.veal at bywatersolutions.co | |m --- Comment #9 from Katrin Fischer --- *** Bug 13424 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 20:57:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 19:57:09 +0000 Subject: [Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34250|0 |1 is obsolete| | Attachment #34251|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 34253 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34253&action=edit [SIGNED-OFF] Bug 13315 - Add feedback for last item checked out to circulation.pl It seems that many librarians find it disconcerting to have no feedback with the new checkouts table. It seems that many of them wait for it to fully load, check to verify the item was checked out, and only then check out the next item. To help alleviate this issue, we can have the checkouts page give feedback about the item that was just checked out. Test Plan: 1) Apply this patch 2) Check an item out 3) Note the message "$title ($barcode) due on $date_due" Signed-off-by: Owen Leonard This works well and fixes a very problematic issue with the new AJAX circ. I will be submitting a follow-up which I think is an improvement to the display. Signed-off-by: Jason Burds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 21:02:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 20:02:14 +0000 Subject: [Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315 --- Comment #13 from Kyle M Hall --- Created attachment 34254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34254&action=edit [SIGNED-OFF] Bug 13315 [Follow-up] Add feedback for last item checked out to circulation.pl This patch changes the position and styling of the information about the last checkout so that it is grouped with the checkout form itself, placing the message in a more visible position, especially for patrons with a lot of information in the right-hand messages column which might push the checkouts table down offscreen. To test, apply the patch and clear your browser cache in order to refresh the main CSS file. Check out an item and confirm that a message is prominently displayed. Signed-off-by: Jason Burds Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 21:10:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 20:10:24 +0000 Subject: [Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315 --- Comment #14 from Kyle M Hall --- I just wanted to add that Owen's followup looks fantastic! Great work! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 21:49:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 20:49:40 +0000 Subject: [Koha-bugs] [Bug 13414] Enable right truncation with search by relevance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34199|0 |1 is patch| | Attachment #34199|application/mbox |text/plain mime type| | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 9 21:51:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Dec 2014 20:51:16 +0000 Subject: [Koha-bugs] [Bug 13414] Enable right truncation with search by relevance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414 --- Comment #1 from Katrin Fischer --- I am a bit worried about the database update - wouldn't that set your syspref to 1 even if the it was 0 before? Maybe just changing the values that need to be changed would work? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 01:08:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 00:08:14 +0000 Subject: [Koha-bugs] [Bug 8483] Borrower reading history should include deleted items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #4 from Heather Braum --- Has there been any further movement on this bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 08:02:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 07:02:26 +0000 Subject: [Koha-bugs] [Bug 13427] New: jQuery Timepicker is not translated on returns page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13427 Bug ID: 13427 Summary: jQuery Timepicker is not translated on returns page Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Created attachment 34266 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34266&action=edit Timepicker on returns page In circulation module on checkin page (/cgi-bin/koha/circ/returns.pl), the timepicker for setting the return date/time is not fully translatable, as I understand (according to bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11618), there is missing line [% INCLUDE 'timepicker.inc' %] in returns.tt template file. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 09:56:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 08:56:09 +0000 Subject: [Koha-bugs] [Bug 7741] Clear search terms in Z3950 search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7741 --- Comment #12 from Jonathan Druart --- Created attachment 34268 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34268&action=edit Bug 7741: Added Clearing Capability to the Z39.50 Search fields Tested in: /koha/cataloguing/z3950_auth_search.pl (Home:Authorities:New from Z39.50) /koha/cataloguing/z3950_search.pl (Home:Cataloging:New from Z39.50/SRU) /koha/acqui/z3950_search.pl (Home:Acquisitions:[Bookshop]:[Basket]:Order from external source) All three forms can now be cleared. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 09:56:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 08:56:12 +0000 Subject: [Koha-bugs] [Bug 7741] Clear search terms in Z3950 search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7741 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34248|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 34269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34269&action=edit Bug 7741 [Follow-up] Clear search terms in Z3950 search page This patch makes a follow-up change and takes as its basis a dependency on Bug 13218 - usability enhancement for z39.50 search. If we have a one-column search form it's possible to put the "Clear search form" link at the bottom of the form rather than in the header, logically associating it with the grouping of form fields which will be affected. Doing so also allows us to eliminate all the custom styling which was an issue for QA. Other changes made by this patch: Fixing the indentation error, correcting the case of the link text ("Clear search form" instead of "Clear Search Form"), and adding "preventDefault()" to the click handler so that clicking the link doesn't scroll the user back to the top of the page. To test, apply the previous patch and this one on top of Bug 13218. Repeat the test plan. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 09:56:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 08:56:49 +0000 Subject: [Koha-bugs] [Bug 13218] usability enhancement for z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13218 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33393|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart --- Created attachment 34270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34270&action=edit Bug 13218 - usability enhancements for z39.50 searches This patch rearranges the layout of the z39.50 search pages in cataloguing and authorities. There should be no functional change to z-target searching, all functions should remain the same. Changes: * 2 columns of search fields condensed into one * zTargets moved from below the search fields to beside them * rearranged search fields into perceived frequency of usage, from most used to least * changed label of Raw (any) to Keyword (any) To test: * click cataloguing -> new from z39.50/SRU * observe how the layout has changed * import a record or two using the search - there has been no change to the function, it should all be working. * Click Authorities -> new from z39.50 * observe how the layout has changed * import an authority or two using the search - there has been no change to the function, it should all be working. * sign off if you think these changes are nice. Comments and suggestions are also welcome regarding this change. Signed-off-by: Frederic Demians Nice evolution of the z3950 search/result pages. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 09:56:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 08:56:53 +0000 Subject: [Koha-bugs] [Bug 13218] usability enhancement for z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13218 --- Comment #20 from Jonathan Druart --- Created attachment 34271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34271&action=edit Bug 13218 - fixing acquisitions z39.50 interface to be consistent with the others. Changes: * Two columns of search fields into one * moves targets from below search fields to the right of them To test: * Create a basket in acquisitions * attempt to add a record to the order from an external source * note the changes to the layout * complete a couple of additions to the basket - functionality should be unchanged. If you like the changes, sign off :) Signed-off-by: Frederic Demians Ok. Consistency welcomed! Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 09:56:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 08:56:56 +0000 Subject: [Koha-bugs] [Bug 13218] usability enhancement for z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13218 --- Comment #21 from Jonathan Druart --- Created attachment 34272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34272&action=edit Bug 13218: (qa-follow-up) replace tab with spaces Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 09:57:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 08:57:18 +0000 Subject: [Koha-bugs] [Bug 13218] usability enhancement for z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13218 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34246|0 |1 is obsolete| | CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 09:57:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 08:57:28 +0000 Subject: [Koha-bugs] [Bug 7741] Clear search terms in Z3950 search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7741 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34141|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 09:57:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 08:57:40 +0000 Subject: [Koha-bugs] [Bug 7741] Clear search terms in Z3950 search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7741 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off QA Contact|koha.sekjal at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 09:57:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 08:57:51 +0000 Subject: [Koha-bugs] [Bug 13218] usability enhancement for z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13218 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #22 from Jonathan Druart --- Qaed with bug 7741. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 09:58:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 08:58:06 +0000 Subject: [Koha-bugs] [Bug 7741] Clear search terms in Z3950 search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7741 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #14 from Jonathan Druart --- Qaed with bug 13218. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 10:00:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 09:00:16 +0000 Subject: [Koha-bugs] [Bug 13428] New: Fix facet deletion Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13428 Bug ID: 13428 Summary: Fix facet deletion Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org Bug 13425 introduced a regression on facets. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 10:00:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 09:00:44 +0000 Subject: [Koha-bugs] [Bug 13428] Fix facet deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13428 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13425 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 10:21:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 09:21:00 +0000 Subject: [Koha-bugs] [Bug 13428] Fix facet deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13428 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 10:21:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 09:21:03 +0000 Subject: [Koha-bugs] [Bug 13428] Fix facet deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13428 --- Comment #1 from Jonathan Druart --- Created attachment 34274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34274&action=edit Bug 13428: Fix regression on deleting facets Test plan: Search for something click on a facet with diacritic click on another facet remove the facet with diacritic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 10:21:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 09:21:09 +0000 Subject: [Koha-bugs] [Bug 13423] Untranslatable strings in serials-edit.tt and serials-recieve.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at pttk.fi --- Comment #1 from paxed --- Should perhaps also grep for "confirm('", which returns different results... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 10:21:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 09:21:45 +0000 Subject: [Koha-bugs] [Bug 13428] Fix facet deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13428 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- Patch for 3.16.x, 3.18.x and master. The intranet does not need this change (already done). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 10:34:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 09:34:08 +0000 Subject: [Koha-bugs] [Bug 13421] Add the creation time for virtual shelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13421 --- Comment #3 from Jonathan Druart --- Marc, did you apply the dependency? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 10:35:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 09:35:22 +0000 Subject: [Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34236|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 10:35:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 09:35:34 +0000 Subject: [Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29976|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 10:35:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 09:35:54 +0000 Subject: [Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #5 from Jonathan Druart --- Sonia, did you want to signoff this patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 10:48:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 09:48:00 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_13404=5D__More_=C2=BBSystem_informat?= =?utf-8?q?ion=C2=AB_about_GRS1_vs_DOM_settings?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13396 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 10:48:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 09:48:00 +0000 Subject: [Koha-bugs] [Bug 13396] koha-rebuild-zebra: Couldn't open collection.abs error after 3.18 package update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13396 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13404 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 10:50:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 09:50:42 +0000 Subject: [Koha-bugs] [Bug 12651] DOM indexing should be the default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12651 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13396 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 10:50:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 09:50:42 +0000 Subject: [Koha-bugs] [Bug 13396] koha-rebuild-zebra: Couldn't open collection.abs error after 3.18 package update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13396 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12651 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 10:51:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 09:51:19 +0000 Subject: [Koha-bugs] [Bug 12641] Formally deprecate the GRS-1 indexing mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12641 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13396 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 10:51:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 09:51:19 +0000 Subject: [Koha-bugs] [Bug 13396] koha-rebuild-zebra: Couldn't open collection.abs error after 3.18 package update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13396 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12641 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 10:59:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 09:59:10 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #10 from Jonathan Druart --- (In reply to Paola Rossi from comment #9) > I've applied the patches [13369,13370,13371] against 3.19.00.000 > > 'Item count' and 'Biblio count' didn't yet work: > "No matching records found" (even if some records matched my search). Weird, I don't have this problem. What is the version of your browser? Could you make a screenshot/screencast? > NB1. A patron "Xa" of the library "Yb" had created the basket. In the > "Created by" column of that basket I saw: > XaYb (without spaces). > I think that the value "Xa Yb" would be preferred; otherwise filtering "aY" > would find that row (ERROR). Hum, the "created by" column should only contain firstname + surname. > NB2. On koha/acqui/acqui-home.pl I wrote nothing in vendor's field. > Koha answered the default list of the vendor/baskets. It was: > > You searched on vendor , 10 results found > Show active and inactive baskets | Show opened baskets only > Showing 1 to 6 of 6 > > Was the result 10 or 6? Actually it's 10 vendors and 6 baskets. > It's not so clear at once that the 4 missing baskets are the inactive ones. > [I myself went early in confusion while I was testing, see below NB4.] > Remember that on master the default is the complete list of vendors: if a > vendor has only one inactive basket, the vendor is not listed at all! > So the deault filter chosen in this bug: > Show active and inactive baskets | Show opened baskets only > didn't correspond to the current default of master. Does my previous answer correct the confusion? > NB3. Same search as NB2, on the empty-vendor list's answer. > One vendor of mine was "inactive". But I saw it in the list of vendors. > So an "inactive" basket is not the basket of an "inactive" vendor. > So, I'm in doubt: what is an "inactive"/"active" basket? > Some of the listed baskets had still expected items > 0: they're active, > aren't they? > But an open basket had 0 biblio, 0 items, 0 expected items: it was listed as > active. Is it right? A basket is considered as inactive if it is closed and no item is expected (should not be different as before this patch set). Before this patch, a "Show all baskets" existed. I have just renamed it, but the behavior should be the same. > NB4. On ACQ home, I saw for the table of funds: > Hide inactive budgets | Show inactive budgets > > Imho the use of the same kind of filters might perhaps be clearer: > Show inactive baskets | Hide inactive baskets | Show closed baskets | Hide > closed baskets I am not sure. IMO it is more confusing. But we could ask Owen what he thinks about it. > NB5. In a closed basket, 1 item was ordered, 1 item was partial and 1 item > was completely received. > When I selected only the active baskets, the item count is 2. > When both the active and inactive baskets were selected, the item count is 3. > I'm in doubt: is it right? It looks like a bug and it's certainly in master too. Could you open a new bug report, describe the problem and assign it to me please? > NB6. "Expected items" might be preferred to "Items expected". It does not come from this patch, it's the same string as before. It could be fix on the QA step if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 10:59:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 09:59:41 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 10:59:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 09:59:44 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #11 from Jonathan Druart --- Created attachment 34275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34275&action=edit Bug 13371: just a test for the biblio|item count filters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 11:00:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 10:00:37 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #12 from Jonathan Druart --- (In reply to Paola Rossi from comment #9) > I've applied the patches [13369,13370,13371] against 3.19.00.000 > > 'Item count' and 'Biblio count' didn't yet work: > "No matching records found" (even if some records matched my search). Could you please test with the last patch I submitted? Since I don't reproduce the issue, it's not easy to fix it :-/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 11:05:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 10:05:57 +0000 Subject: [Koha-bugs] [Bug 12584] koha-conf.xml for package installations get out of sync In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12584 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13396 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 11:05:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 10:05:57 +0000 Subject: [Koha-bugs] [Bug 13396] koha-rebuild-zebra: Couldn't open collection.abs error after 3.18 package update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13396 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12584 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 11:07:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 10:07:20 +0000 Subject: [Koha-bugs] [Bug 13396] koha-rebuild-zebra: Couldn't open collection.abs error after 3.18 package update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13396 --- Comment #1 from Magnus Enger --- Hi Stephen! I think this is an example of bug 12584. Could you try adding the 4 lines you mention to your koha-conf.xml, restart Zebra and try to do a full reindex? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 11:11:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 10:11:46 +0000 Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #7 from Jonathan Druart --- (In reply to Katrin Fischer from comment #6) > I am not sure, but I think as we introduced it as a free text field people > might have left unstructured comments and could end up with quite a long > list for the authorized value - which might also not very welcome. I am not sure a lot of people already used it, it has only been pushed in 3.18. 200 characters is quite long for an order cancellation reason :) > Maybe put the SQL for the update on the wiki and leave as is? > I would make the value show up in the list of authorized values but leave it > empty I think. I don't understand what you meant here, sorry :-/ What about a warning on updating the DB : "the field XXX for order YYY with value ZZZ has been truncated"? Or we could extend authorised_values.lib to a TEXT? But I don't like this solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 11:12:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 10:12:19 +0000 Subject: [Koha-bugs] [Bug 13408] Tell librarians they may continue scanning while checkouts table is loading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13408 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34186|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 11:12:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 10:12:40 +0000 Subject: [Koha-bugs] [Bug 13408] Tell librarians they may continue scanning while checkouts table is loading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13408 --- Comment #6 from Jonathan Druart --- Kyle, is there a chance to get or signoff on this patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 11:17:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 10:17:09 +0000 Subject: [Koha-bugs] [Bug 13408] Tell librarians they may continue scanning while checkouts table is loading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13408 --- Comment #7 from Jonathan Druart --- your* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 11:31:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 10:31:32 +0000 Subject: [Koha-bugs] [Bug 13410] Untranslatable "Change messaging preferences to default for this category?" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13410 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 11:37:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 10:37:55 +0000 Subject: [Koha-bugs] [Bug 13423] Untranslatable strings in serials-edit.tt and serials-recieve.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 --- Comment #2 from Marc V?ron --- Hi paxed, I did, some of the outcome is waiting for Sign-off: Bug 13400 Bug 13410 Bug 13422 Marc -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 12:16:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 11:16:49 +0000 Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 --- Comment #8 from Katrin Fischer --- I think the question is if this is going to be in 3.18.x or as a new enhancement in 3.20. And by then... libraries will have used it. I think currently as a input field it invites for longer unstructured comments. What I meant is that I would not transform the existing reasons into an authorized value for existing installations but leave things as they are and have the auth_value as a non-enforced option. That would also avoid the truncation problem. Maybe we should ask for opinions on the list? Some good feedback there recently. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 13:07:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 12:07:57 +0000 Subject: [Koha-bugs] [Bug 13429] New: Add helper SQL functions for report use Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13429 Bug ID: 13429 Summary: Add helper SQL functions for report use Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org To make creating SQL reports easier, there should be some helper functions in the database. For example, looking at the SQL Reports Library, there are several functions that create URLs to the staff client: CONCAT('',biblio.biblionumber,'') Adding the following function: DROP FUNCTION IF EXISTS StaffUrl; DELIMITER $$ CREATE FUNCTION StaffUrl(url text, linkname text) RETURNS text BEGIN RETURN CONCAT('', linkname, ''); END$$ The example above would turn into StaffUrl(CONCAT('catalogue/detail.pl?biblionumber=',biblio.biblionumber), biblio.biblionumber) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 13:46:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 12:46:34 +0000 Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 14:13:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 13:13:12 +0000 Subject: [Koha-bugs] [Bug 13410] Untranslatable "Change messaging preferences to default for this category?" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13410 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 14:13:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 13:13:15 +0000 Subject: [Koha-bugs] [Bug 13410] Untranslatable "Change messaging preferences to default for this category?" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13410 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34245|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 34276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34276&action=edit [SIGNED-OFF] Bug 13410 - Untranslatable "Change messaging preferences to default for this category?" To test: In staff client, go to Home > Patrons Click button "New patron" and choose a category Change Patron messaging preferences Now change Category Make sure that following message box still appears: "Change messaging preferences to default for this category?" Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 14:16:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 13:16:28 +0000 Subject: [Koha-bugs] [Bug 13422] SCO: "Would you like to print a receipt" not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13422 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|String patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 14:28:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 13:28:22 +0000 Subject: [Koha-bugs] [Bug 13422] SCO: "Would you like to print a receipt" not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13422 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 14:28:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 13:28:25 +0000 Subject: [Koha-bugs] [Bug 13422] SCO: "Would you like to print a receipt" not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13422 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34247|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 34277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34277&action=edit [SIGNED-OFF] Bug 13422 - SCO: "Would you like to rpint a receipt" not translatable To test: Set syspref SelfCheckReceiptPrompt to "Show" Select non English language Go to Self Checkout and check out an item Hit "Finish" Make sure that confirm dialog "Would you like to print a receipt" still appears Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 14:51:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 13:51:51 +0000 Subject: [Koha-bugs] [Bug 13400] Untranslatable "Are you sure you want to delete this authority?" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13400 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- Marc did you test by updating and installing a translation? I'm not sure if I'm testing incorrectly, but it's not working for me. 1. Applied the patch. 2. Ran perl translate update de-DE 3. Edited de-DE-i-staff-t-prog-v-3006000.po to add a "translation" 4. perl translate -v install de-DE 5. Testing deleting an authority from the authority search results page I still got the default English confirmation message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 15:02:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 14:02:08 +0000 Subject: [Koha-bugs] [Bug 13341] Hard-coded "Preview" text in OPAC openlibrary.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 15:20:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 14:20:29 +0000 Subject: [Koha-bugs] [Bug 13400] Untranslatable "Are you sure you want to delete this authority?" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13400 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from Owen Leonard --- Never mind. I needed to add step 3a. Delete the "fuzzy" marker from the entry in the po file. Thanks to cait for pointing out my error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 15:22:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 14:22:54 +0000 Subject: [Koha-bugs] [Bug 13400] Untranslatable "Are you sure you want to delete this authority?" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13400 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 15:22:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 14:22:56 +0000 Subject: [Koha-bugs] [Bug 13400] Untranslatable "Are you sure you want to delete this authority?" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13400 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34176|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 34278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34278&action=edit [SIGNED-OFF] Bug 13400 - Untranslatable "Are you sure you want to delete this authority?" This patch makes the string "Are you sure you want to delete this authority?" translatable using the function _(...) To test, apply patch and check that deleting authorities still works. Signed-off-by: Owen Leonard Tested successfully with the following procedure: 1. Applied the patch. 2. Ran perl translate update de-DE 3. Edited de-DE-i-staff-t-prog-v-3006000.po to add a "translation" 4. Removed "#, fuzzy" marker from po entry. 5. perl translate -v install de-DE 6. Testing deleting an authority from the authority search results page and from the detail page. My translated string appeared correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 15:35:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 14:35:19 +0000 Subject: [Koha-bugs] [Bug 13341] Hard-coded "Preview" text in OPAC openlibrary.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 15:35:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 14:35:21 +0000 Subject: [Koha-bugs] [Bug 13341] Hard-coded "Preview" text in OPAC openlibrary.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 --- Comment #1 from Owen Leonard --- Created attachment 34279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34279&action=edit Bug 13341 - Hard-coded "Preview" text in OPAC openlibrary.js The OpenLibrary JavaScript includes an untranslated string, "Preview." This patch move the string to the template so that it can be translated. To test, apply the patch and test that the translator picks up the string: 1. From misc/translator run 'perl translate update [lang]' (e.g. de-DE) 2. Edit misc/translator/po/[lang]-opac-bootstrap.po and add a translation for the updated "Preview" string 3. Remove the "#, fuzzy" marker from that entry 4. From misc/translator run 'perl translate install [lang]' 5. Enable the [lang] translation for the OPAC in system preferences 6. Enable the OpenLibraryCovers system preference. 7. In the OPAC switch to the [lang] translation. 7. View the detail page for a title for which there is an OpenLibrary cover image. Below it you should see a preview link with the translated string you added in step 2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 15:39:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 14:39:18 +0000 Subject: [Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- Against master: cataloguing/addbooks.pl?q=tintin I got: Les Aventures de Tintin. 15 : Objectif Lune [texte et dessins] par Herg? - 2203001151 - 1981 - Casterman - 61 p. ; 30 cm biblioitems.size is mapped with 215$d and is equal to '30 cm'. So what does this patch fix? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 15:47:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 14:47:50 +0000 Subject: [Koha-bugs] [Bug 13430] New: Serial enumeration not visible when handling Serial Items. Show enumerations for Serial Items in the circ- and member-modules. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13430 Bug ID: 13430 Summary: Serial enumeration not visible when handling Serial Items. Show enumerations for Serial Items in the circ- and member-modules. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Our librarians need to know which enumerations of an Serial Item are on hold for a borrower and which are checked out. It is not enough to know just the title + author. This patch simply shows the koha.items.enumchron-field in the AJAX-driven checkout and holds-views and if no Items with enumchron are present, the column is automatically hidden. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 15:48:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 14:48:42 +0000 Subject: [Koha-bugs] [Bug 13430] Serial enumeration not visible when handling Serial Items. Show enumerations for Serial Items in the circ- and member-modules. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13430 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=3380, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7155, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11818 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 15:48:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 14:48:42 +0000 Subject: [Koha-bugs] [Bug 3380] Serial enumeration / chronology should display in opac holds interface. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3380 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13430 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 15:48:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 14:48:42 +0000 Subject: [Koha-bugs] [Bug 7155] Claims Notice for Serials - No option for Issue Number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7155 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13430 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 15:48:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 14:48:42 +0000 Subject: [Koha-bugs] [Bug 11818] include serial enumeration in the browse shelf function In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11818 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13430 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 15:48:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 14:48:54 +0000 Subject: [Koha-bugs] [Bug 13430] Serial enumeration not visible when handling Serial Items. Show enumerations for Serial Items in the circ- and member-modules. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13430 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |olli-antti.kivilahti at jns.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 16:06:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 15:06:56 +0000 Subject: [Koha-bugs] [Bug 13430] Serial enumeration not visible when handling Serial Items. Show enumerations for Serial Items in the circ- and member-modules. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13430 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 34280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34280&action=edit Bug 13430 - Serial enumeration not visible when handling Serial Items. Circ- and member-modules. Adding enumchron (Vol info) to circ/circulation.pl and members/moremember.pl. Making enumchron (Vol info)-column hide when it is not used. TEST PREPARATIONS: -1. Find a Borrower/parent with a child/guarantee. -0. Make a Subscription (creating Items when receiving serial numbers) to a Biblio and receive atleast 4 numbers. TEST PLAN (HOLDS ENUMERATED): 1. Make a reservation of two of the Serial Items for the Borrower and the Child, totaling 4 reservations. 2. Check-in the reserved books to make sure an Item-level hold is in place and real Items match the reservations. 3. Both the Borrower and Child have a "Vol info"-column with the Item enumchron (enumeration or chronology) in their "Holds"-tab in circ/circulation.pl and members/moremember.pl TEST PLAN (HOLDS UNENUMERATED): 4. Make two arbitrary reserves for both Parent and Child. 5. Observe that in the "Holds"-tab they have now two Items with enumchron and two without. 6. Check-out the reserved Items for the respective Parent/Child. 7. Observe that in the "Holds"-tab there is no "Vol info"-column. TEST PLAN (CHECKOUTS ENUMERATED): 8. Make two arbitrary check-outs for the Parent and the Child. 9. In the "Checkouts"-tab, observe the "Vol info"-column with two Items having an enumchron and two items without. 10. In the "Relatives' checkouts"-tab observe that the Child of the Parent and the Parent of the Child can see the "Vol info"-tab with their relatives' loans proper enumerations. TEST PLAN (CHECKOUTS UNENUMERATED): 11. Check-in the Serial Items for both the Parent and the Child. 12. Observe the missing "Vol info"-tab in the "Checkouts"-tab and in the "Relatives' checkouts"-tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 16:13:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 15:13:31 +0000 Subject: [Koha-bugs] [Bug 737] Map of library in search system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=737 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.legrand at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 16:16:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 15:16:43 +0000 Subject: [Koha-bugs] [Bug 13296] error when using z3950 with UNIMARC authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13296 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33675|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 34281 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34281&action=edit Bug 13296 - error when using z3950 with UNIMARC authorities When using a z3950 connexion with UNIMARC authorities, you get an error : Unsupported UNIMARC character encoding [ ] for XML output for UNIMARCAUTH; 100$a -> 20141119 I've seen thant Bug 2060 when adds authorities import adds a special behavior for UNIMARC : marc flavor must be UNIMARCAUTH instead of just UNIMARC. This patch adds the same behavior when using z3950 connexion and import. Test plan : - Use a UNIMARC install - Define a z3950 connexion for UNIMARC authorities - Go to Authorities module - Click on "New from Z39.50" - Perform a search => Without patch : you get the error => With patch : you get results - Import one result => You get the authoritie creation form with all datas You may check same plan with MARC21 install Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 16:16:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 15:16:41 +0000 Subject: [Koha-bugs] [Bug 13296] error when using z3950 with UNIMARC authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13296 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 16:16:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 15:16:47 +0000 Subject: [Koha-bugs] [Bug 13296] error when using z3950 with UNIMARC authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13296 --- Comment #3 from Jonathan Druart --- Created attachment 34282 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34282&action=edit Bug 13296: (follow-up) permit grep on AUTHUNIMARC I would prefer not to hide this "stuff". Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 16:17:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 15:17:15 +0000 Subject: [Koha-bugs] [Bug 13296] error when using z3950 with UNIMARC authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13296 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Severity|normal |critical --- Comment #4 from Jonathan Druart --- This is critical for UNIMARC users. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 16:20:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 15:20:16 +0000 Subject: [Koha-bugs] [Bug 13296] error when using z3950 with UNIMARC authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13296 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34282|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 34283 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34283&action=edit Bug 13296: (follow-up) permit grep on AUTHUNIMARC I would prefer not to hide this "stuff". Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 16:33:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 15:33:53 +0000 Subject: [Koha-bugs] [Bug 11842] MARC framework editing is broken when memcache is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11842 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13431 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 16:33:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 15:33:53 +0000 Subject: [Koha-bugs] [Bug 13431] New: Can't access MARC bibliographic frameworks and other pages Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 Bug ID: 13431 Summary: Can't access MARC bibliographic frameworks and other pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: abl at biblos.pk.edu.pl, gmcharlt at gmail.com, katrin.fischer at bsz-bw.de, robin at catalyst.net.nz, tomascohen at gmail.com Depends on: 11842, 12800 +++ This bug was initially created as a clone of Bug #12800 +++ This bug has reared it's head again, but this time it's more serious. Upon package upgrade on a multi-tenant server, if your tenants do not already have a MEMCACHED_NAMESPACE environment variable defined then all instance will default back to -koha-koha nameing for the tmp file used for caching. This inevitably results in the errors shown in the original bug for all but the one instance that crates the file in the first place. At the very least, we should set this environment variable on a per instance basis at apache vhost conf creation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 16:33:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 15:33:53 +0000 Subject: [Koha-bugs] [Bug 12800] Can't access MARC bibliographic frameworks and other pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12800 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13431 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 17:41:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 16:41:20 +0000 Subject: [Koha-bugs] [Bug 7155] Claims Notice for Serials - No option for Issue Number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7155 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi flanagan - what did you try in your notices template? Do you know which field in the database stores the information you want to output? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 17:48:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 16:48:36 +0000 Subject: [Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 --- Comment #4 from Fridolin SOMERS --- (In reply to Jonathan Druart from comment #3) You reproduce the bug in opac-shelves.pl and opac-topissues.pl ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 17:59:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 16:59:06 +0000 Subject: [Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 --- Comment #5 from Fridolin SOMERS --- (In reply to Jonathan Druart from comment #3) > Against master: > > cataloguing/addbooks.pl?q=tintin > > I got: > Les Aventures de Tintin. 15 : Objectif Lune > > [texte et dessins] par Herg? - 2203001151 - 1981 - Casterman - 61 p. ; 30 cm > > > biblioitems.size is mapped with 215$d and is equal to '30 cm'. > > So what does this patch fix? In this page, it works because of ugly hack in cataloguing/addbooks.pl : foreach my $line (@newresults) { if ( not exists $line->{'size'} ) { $line->{'size'} = "" } } Looks like resultsloo.size is the size of loop only when biblioitems.size is undefined. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 17:59:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 16:59:29 +0000 Subject: [Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 18:04:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 17:04:03 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #13 from Paola Rossi --- (In reply to Jonathan Druart from comment #10) > (In reply to Paola Rossi from comment #9) [...] > > NB1. A patron "Xa" of the library "Yb" had created the basket. In the > > "Created by" column of that basket I saw: > > XaYb (without spaces). > > I think that the value "Xa Yb" would be preferred; otherwise filtering "aY" > > would find that row (ERROR). > > Hum, the "created by" column should only contain firstname + surname. > NB1. was my fault! I beg your pardon, I'm sorry. > Before this patch, a "Show all baskets" existed. I have just renamed it, but > the behavior should be the same. > I thought there was a difference on master and after fixing. I don't know if it's meaningful or not, so I try to describe this difference with plainness. Before this patch, on master, the function was a selection about vendors, not about baskets. All the vendors were shown. And then their baskets were shown if they were of the right kind. Before this patch, the "Show all baskets" didn't change [didn't increase] the listed vendors, but only increased the shown baskets. At first, some vendors could be listed with no basket at all. After this patch koha doesn't show a vendor when no basket of his is of the right kind. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 19:42:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 18:42:15 +0000 Subject: [Koha-bugs] [Bug 13432] New: SIP Server does not respect timeout setting Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13432 Bug ID: 13432 Summary: SIP Server does not respect timeout setting Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Koha's SIP server accepts timeout parameters, but those parameters are only used for the login portion of a telnet transport session. Other than that, they are ignored, and as long as whatever opened the connection keeps it open, it will stay open indefinitely. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 19:46:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 18:46:41 +0000 Subject: [Koha-bugs] [Bug 13432] SIP Server does not respect timeout setting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13432 --- Comment #1 from Kyle M Hall --- Created attachment 34284 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34284&action=edit Bug 13432 - SIP Server does not respect timeout setting Koha's SIP server accepts timeout parameters, but those parameters are only used for the login portion of a telnet transport session. Other than that, they are ignored, and as long as whatever opened the connection keeps it open, it will stay open indefinitely. Test Plan: 1) Set the timeout setting on your SIP server to 10 seconds 2) Modify misc/sip_cli_emulator.pl, add "sleep 100;" directly after line 91 3) Start your SIP server 4) Run the modified sip script with valid parameters 5) Watch the SIP server stderr 6) Note that even though the script waits far too long before continuing, the SIP server never kills the connection, and the requests the cli script makes come back with valid data. 7) Apply this patch 8) Restart your SIP server 9) Repeat step 4 10) Note that this time you see "SIP Timed Out!" in the SIP server stderr and when the script finally makes it's request, it doesn't come back with valid data. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 19:46:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 18:46:39 +0000 Subject: [Koha-bugs] [Bug 13432] SIP Server does not respect timeout setting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13432 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 19:46:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 18:46:52 +0000 Subject: [Koha-bugs] [Bug 13432] SIP Server does not respect timeout setting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13432 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 19:49:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 18:49:35 +0000 Subject: [Koha-bugs] [Bug 13432] SIP Server does not respect timeout setting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13432 --- Comment #2 from Kyle M Hall --- Note, you really only need to sleep for 20 to 30 seconds, not 100. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 20:58:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 19:58:47 +0000 Subject: [Koha-bugs] [Bug 13414] Enable right truncation with search by relevance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34199|0 |1 is obsolete| | CC| |koha at univ-lyon3.fr --- Comment #2 from Koha Team Lyon 3 --- Created attachment 34285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34285&action=edit Bug 13414 - Enable automatic right truncation while searching by relevance Oups ! I fear you are absolutely right. patch corrected. Moreover some more precisions were missing : By now, relevance don't work when Automatic truncation is activated : the results are sorted by biblionumber ascending. However truncation (left and right) is possible with relevance activated when QueryAutoTruncate is set on manual option ( this means you have to add * character to your keyword). This is the automatic right truncation that this patch brings combined with relevance. These two options cannot get along : the choice is Every where manual truncation versus Automatic right truncation. I just add right truncation as a trial because it seems to match the essential and common needs : getting the plural and very closed terms. I fear going further would be a bit of tuning. TEST PLAN : 1) Apply patch. Set QueryWeightFields syspref on default option (relevance without truncation) and QueryAutoTruncate on automatic position. 2) choose a keysearch not too much common so as to get only a small batch of results : note the number of results. Note that results are sorted by biblionumber ascending and not by relevance. To check, pass the cursor over the titles.That displays the link address in left down corner of active window : biblionumber is visible at the end of the address. 3) redo the search adding an s plural to your keysearch (or anything so as keeping keysearch as radical) : note the number of results. this can be higher than previous ones. 4) Among these last results, try to find a record where only the plural form is present (checking in Marc tab). Call it recordTest. 5) Turn QueryWeightFields syspref on right truncation option, redo 1 and note the results number. It's not any more sorted by biblionumber. Little more by relevance( little more because relevance in koha may be surprising !). There could be results where the plural form of keyword had been found (and the singular one is not present), more possibly at the end of the list. To be sure, look for recordTest record. 6) redo 3 and note the number of results. this one should be smaller (these results must be included in previous one). Of course, you can redo the tests with QueryAutoTruncate in "manual" position adding a right * and compare the results. Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 21:58:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 20:58:08 +0000 Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #34 from Barton Chittenden --- (In reply to Chris Cormack from comment #23) > The only way I could see to hurry this along, would be send a patch to the > Library::CallNumber::LC maintainer to help them implement the feature. > > You could perhaps persuade (by paying, giving cookies, some other means of > reward) a developer to work on that for you. You can increase the priority of this bug by clicking on the 'star' icon next to 'ID 7' in the bug list here: https://code.google.com/p/library-callnumber-lc/issues/list?cursor=library-callnumber-lc%3A7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 22:26:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 21:26:05 +0000 Subject: [Koha-bugs] [Bug 10344] Omnibus: add RDA support to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10344 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13433 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 22:26:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 21:26:05 +0000 Subject: [Koha-bugs] [Bug 13433] New: 655 display in XSLT Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433 Bug ID: 13433 Summary: 655 display in XSLT Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Blocks: 10344 655: Display as Genre/Form (full display): Display corresponding subfields a, v, x, y, z. This change would bring Koha?s display in line with the now codified practice of separating about-ness (subject headings) from is-ness (genre/form headings). If you're interested, for more info on that, see: http://www.loc.gov/catdir/cpso/genre_form_faq.pdf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 22:27:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 21:27:00 +0000 Subject: [Koha-bugs] [Bug 13434] New: 586 XSLT improvements Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13434 Bug ID: 13434 Summary: 586 XSLT improvements Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Blocks: 10344 586: Continue to display as Awards, but also use vertical bar to separate multiple listings if there is more than one 586 in the record Ex: Awards: Man Booker Prize, 2013 | BAILEYS Women's Prize for Fiction, Longlist, 2014 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 22:27:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 21:27:00 +0000 Subject: [Koha-bugs] [Bug 10344] Omnibus: add RDA support to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10344 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13434 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 22:46:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 21:46:16 +0000 Subject: [Koha-bugs] [Bug 13435] New: OPAC self registration can't find OPAC_REG_VERIFY notice if it is assigned to a branch Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13435 Bug ID: 13435 Summary: OPAC self registration can't find OPAC_REG_VERIFY notice if it is assigned to a branch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Email verification can look very broken for multi branch systems - if there is no "all libraries" notice defined for "OPAC_REG_VERIFY," but one defined for a specific branch, the self registration code can't find the notice and thus the verification email is not sent. Additionally, this code will only ever return the "all libraries" version of this notice, as it never passes a branchcode - making this notice useless on a per-branch basis. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 23:32:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 22:32:51 +0000 Subject: [Koha-bugs] [Bug 12371] Links in every patron self-registration email points to a single borrower In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12371 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #13 from Liz Rea --- This bug exists in 3.14 as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 10 23:51:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 22:51:52 +0000 Subject: [Koha-bugs] [Bug 12371] Links in every patron self-registration email points to a single borrower In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12371 --- Comment #14 from Liz Rea --- conveniently, it looks like this patch will go into 3.14 pretty much as is. The follow up (bug 13050) won't go cleanly, however. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 00:20:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Dec 2014 23:20:34 +0000 Subject: [Koha-bugs] [Bug 11927] Add greek support to CHR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927 Manos PETRIDIS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egpetridis at yahoo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 07:03:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 06:03:57 +0000 Subject: [Koha-bugs] [Bug 13436] New: Add more options to UsageStatsLibraryType Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13436 Bug ID: 13436 Summary: Add more options to UsageStatsLibraryType Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Currently UsageStatsLibraryType only offers the options public or university, which doesn't fit for all libraries. Maybe University should be Academic? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 09:00:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 08:00:37 +0000 Subject: [Koha-bugs] [Bug 11927] Add greek support to CHR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it --- Comment #12 from Zeno Tajoli --- Only a possibility. Your problem with ICU are connect with the standard setup of etc/zebradb/etc/words-icu.xml and etc/zebradb/etc/phrases-icu.xml ? Because as know ICU or CHR selected, the file etc/zebradb/lang_defs/gr/sort-string-utf.chr it will be used in any case (for sorting). So I think it is a good develop to have words-icu.xml and phrases-icu.xml specifics for same language. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 09:11:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 08:11:58 +0000 Subject: [Koha-bugs] [Bug 10113] Currency and cost calculation problem in acquisition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10113 Saiful Amin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |saiful at semanticconsulting.c | |om --- Comment #1 from Saiful Amin --- I think this is due to the updateCosts() function in acq.js which cannot handle whitespace in the currency code. The problem exists even in the latest stable. I don't know enough javascript to fix it. But, an easy way to avoid this problem is not having any whitespace in the currency code (e.g., use 'USD' instead of 'US Dollars'). For existing system, since the staff interface does not allow changing the currency code, it can be changed directly in the database table. For example, to change code 'US Dollars' to 'USD' use this query: SQL> update currency set currency = 'USD' where currency = 'US Dollars'; This effectively solves this problem. But I'm not sure if it affects any other areas (say reports or old orders/budgets). Let someone confirm it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 09:16:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 08:16:04 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #14 from Jonathan Druart --- (In reply to Paola Rossi from comment #13) > Before this patch, on master, the function was a selection about vendors, > not about baskets. > All the vendors were shown. And then their baskets were shown if they were > of the right kind. Before this patch, the "Show all baskets" didn't change > [didn't increase] the listed vendors, but only increased the shown baskets. > At first, some vendors could be listed with no basket at all. > > After this patch koha doesn't show a vendor when no basket of his is of the > right kind. Yes, you are right to raise this difference, I should have done it! Actually I was thinking about changing the name of this script, especially because it's more a basket search than a bookseller search. Do you think we should display all suppliers even if they don't have a basket listed? I am not sure it will be easier to display them in the table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 09:23:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 08:23:21 +0000 Subject: [Koha-bugs] [Bug 13436] Add more options to UsageStatsLibraryType In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13436 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- What entries could we add to be more exhaustive? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 09:39:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 08:39:37 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #15 from Katrin Fischer --- > Do you think we should display all suppliers even if they don't have a > basket listed? > I am not sure it will be easier to display them in the table. I think we need to list those without baskets, because otherwise I think you won't be able to start a new order for a newly added vendo While we always displayed the baskets, I am a bit worried that the display will get confusing for the 'create new order' step with it being a table. When you create a new order, the first thing you do is to look up your vendor in Koha - you are not interested in most of the displayed information then, apart from the 'new basket' link - so it is in fact a vendor search too. Maybe there should be a short and a long form of the result list? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 09:41:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 08:41:27 +0000 Subject: [Koha-bugs] [Bug 13436] Add more options to UsageStatsLibraryType In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13436 --- Comment #2 from Katrin Fischer --- Hi Jonathan, I filed this as reaction to a mail on the mailing list. I am not sure if University is just the wrong term and people would be more happy with "academic" and "public" or if we should be more exhaustive, adding things like school, special, ...? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 09:52:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 08:52:44 +0000 Subject: [Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33615|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 34286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34286&action=edit Bug 13268 - biblioitems.size value not correctly displayed (more) Bug partially corrected by Bug 11357. The size column in biblioitems is a bit problematic when used in TT, because instead of the size value from the biblio column it will give you the size of the variable or current loop. It's currently used in the templates like opac-topissues.tt : [% IF results_loo.size %][% results_loo.size %][% END %] This patch corrects by using item() TT method. See http://stackoverflow.com/questions/2311303/how-can-i-handle-hash-keys-containing-illegal-identifier-characters-in-template. Test plan : - Be sure there is a mapping between a MARC field and biblioitems.size - Create a record A with biblioitems.size defined : like "10x12" - Create a record B with no value in biblioitems.size - Check each modified page : => Without this patch : you see a number (loop size) for both records => With this patch : you only see the correct value for A and nothing for B Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 09:52:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 08:52:48 +0000 Subject: [Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 --- Comment #7 from Jonathan Druart --- Created attachment 34287 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34287&action=edit Bug 13268: the size should not be emptied in pl script It duplicates what the first patch does. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 09:53:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 08:53:15 +0000 Subject: [Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 --- Comment #8 from Jonathan Druart --- This is quite annoying because a value is displayed, but not the good one! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:02:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:02:27 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #27 from sandboxes at biblibre.com --- Patch tested with a sandbox, by scourret at gmail.com <2> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:02:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:02:52 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33170|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:02:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:02:56 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33171|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:03:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:03:01 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33172|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:03:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:03:05 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33173|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:03:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:03:09 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33174|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:03:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:03:14 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33263|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:03:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:03:20 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33477|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:03:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:03:38 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 --- Comment #28 from sandboxes at biblibre.com --- Created attachment 34288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34288&action=edit Bug 12841: aqorders fields should not be mapped Bug 5336 introduced some code which should have been introduced by bug 7294. Since the idea behind bug 7294 has been abandoned (map the aqorders fields), the code can be removed. Test plan: Verify that Koha does not allow you to map the aqorders fields with a MARC subfield. Verify there is no regression on adding/updating an order. Signed-off-by: Zeno Tajoli Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: scourret at gmail.com <2> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:03:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:03:41 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 --- Comment #29 from sandboxes at biblibre.com --- Created attachment 34289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34289&action=edit Bug 12980: GetHistory does useless processing GetHistory iterated on the orders to calculate the quantity and price. These values are never used by the called. It can be removed. Test plan: Verify there is no regression on acqui/histsearch.pl and catalogue/detail.pl Actually you just have to check that the total quantity and price are not displayed on these views. QA: note that 'count' and 'toggle' are never used in the template. Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: scourret at gmail.com <2> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:03:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:03:43 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 --- Comment #30 from sandboxes at biblibre.com --- Created attachment 34290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34290&action=edit Bug 12852: The "preview" param can be removed serials/claims.pl This case (preview=1) never appened. This patch remove all occurrences in the pl and the tt files. Test plan: Verify you don't manage to find a place where preview is set to 1 on the claim serials page. Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: scourret at gmail.com <2> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:03:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:03:46 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 --- Comment #31 from sandboxes at biblibre.com --- Created attachment 34291 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34291&action=edit Bug 12852: Some unused stuffs more These parameters are never used. GetBookSeller takes a string (bookseller name) in parameter, not an id! Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: scourret at gmail.com <2> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:03:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:03:49 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 --- Comment #32 from sandboxes at biblibre.com --- Created attachment 34292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34292&action=edit Bug 12852: C4::Bookseller should not be imported anymore This script does not depend on C4::Bookseller anymore. The import can be removed. Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: scourret at gmail.com <2> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:03:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:03:52 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 --- Comment #33 from sandboxes at biblibre.com --- Created attachment 34293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34293&action=edit Bug 12123 - [Alternative patch] HTML notices can break the notice viewer Depending on the content of an html notice, it can cause the notice to either not be collapsible, be uncollapsible, or to be permanently collapsed. Test Plan: 1) Set your CHECKOUT notice to the following ( with HTML Message checked ) :

The following items have been checked out:

----
<>
----

Thank you for visiting the <> of HMCPL.

2) Check out some items to a patron 3) View the patrn's notices 4) Note the notice viewer is broken ( message is not collapsed, and con't be collapsed ). 5) Apply this patch 6) Reload the page 7) Note the notice viewer is no longer broken Signed-off-by: Owen Leonard This patch appears to fix the problem with the minimum required change. Signed-off-by: Katrin Fischer Works nicely, no problems found. Passes tests and QA script. Signed-off-by: Tomas Cohen Arazi Signed-off-by: scourret at gmail.com <2> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:03:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:03:55 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 --- Comment #34 from sandboxes at biblibre.com --- Created attachment 34294 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34294&action=edit DBRev 3.19.00.000: keep moving Signed-off-by: Tomas Cohen Arazi Signed-off-by: scourret at gmail.com <2> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:10:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:10:22 +0000 Subject: [Koha-bugs] [Bug 12584] koha-conf.xml for package installations get out of sync In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12584 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- (In reply to M. Tompsett from comment #2) > The difficulty is knowing if things were added in a new version, pruned from > the current version, or manually added to configure a particular feature. That's an example of why we should use the about page. W need to tell users to check there for info on possible problems. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:17:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:17:03 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34293|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:17:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:17:01 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34294|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:17:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:17:07 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34292|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:17:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:17:09 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34291|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:17:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:17:11 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34290|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:17:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:17:15 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34289|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:17:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:17:17 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34288|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:17:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:17:34 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33170|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:17:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:17:36 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33171|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:17:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:17:38 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33172|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:17:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:17:41 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33173|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:17:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:17:43 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33174|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:17:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:17:45 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33263|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:17:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:17:47 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33477|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:22:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:22:32 +0000 Subject: [Koha-bugs] [Bug 11927] Add greek support to CHR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927 --- Comment #13 from Fridolin SOMERS --- (In reply to Zeno Tajoli from comment #12) > Only a possibility. > Your problem with ICU are connect with the standard setup of > etc/zebradb/etc/words-icu.xml > and > etc/zebradb/etc/phrases-icu.xml > ? > Because as know ICU or CHR selected, the file > etc/zebradb/lang_defs/gr/sort-string-utf.chr it will be used in any case > (for sorting). > > So I think it is a good develop to have words-icu.xml and phrases-icu.xml > specifics for same language. Nop, the greek must not be transliteration for sort AND search. The only other solution would be to disable transliteration for greek into ICU configuration, but I've not found howto. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:35:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:35:50 +0000 Subject: [Koha-bugs] [Bug 13414] Enable right truncation with search by relevance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #3 from Koha Team Lyon 3 --- Well, painfully start for this patch, my assertion about manual truncation was wrong. So consider this comment cancel the previous one (comment 2) : Moreover some more precisions were missing : By now, relevance seems to not work at all when Automatic truncation is activated or manual Truncation is used (* wilcard ) : the results are sorted by biblionumber ascending. It's automatic right truncation combined with relevance that this patch brings. I just add right truncation as a trial because it seems to match the essential and common needs : getting the plural and very closed terms. I fear going further would be a bit of tuning. By caution, I add it as a third option but maybe, it could replace the existing enable one. TEST PLAN : 1) Apply patch. Set QueryWeightFields syspref on default option (relevance without truncation). 2) choose a keysearch not too much common so as to get only a small batch of results : note the number of results. Note that results are sorted by biblionumber ascending and not by relevance. To check, pass the cursor over the titles.That displays the link address in left down corner of active window : biblionumber is visible at the end of the address. 3) redo the search adding an s plural to your keysearch (or anything so as keeping keysearch as radical) : note the number of results. this can be higher than previous ones. 4) Among these last results, try to find a record where only the plural form is present (checking in Marc tab). Call it recordTest. 5) Turn QueryWeightFields syspref on right truncation option, redo 1 and note the results number. It's not any more sorted by biblionumber. Little more by relevance( little more because relevance in koha is far from beeing perfect : for example high ranking on exact title doesn't make effects). There could be results where the plural form of keyword had been found (and the singular one is not present), more possibly at the end of the list. To be sure, look for recordTest record. 6) redo 3 and note the number of results. this one should be smaller (these results must be included in previous one). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:39:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:39:28 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34057|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart --- Created attachment 34295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34295&action=edit Bug 13371: Add filters on the supplier list view This patch adds the ability to filter the basket list depending on its creator name, basketgroup name, dates (creation, close), etc. Test plan: Go on the supplier list view (acqui/booksellers.pl) and confirm that the view is more ergonomic and the filters permit to the librarians to find a basket more easily than before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:39:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:39:32 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34058|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart --- Created attachment 34296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34296&action=edit Bug 13371: Reintroduce the action buttons Confirm the the "New basket" and "Receive shipment" buttons work as before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:39:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:39:35 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34059|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart --- Created attachment 34297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34297&action=edit Bug 13371: Add a filter for opened baskets This patch adds a new link to filter on opened baskets only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:39:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:39:38 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34167|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart --- Created attachment 34298 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34298&action=edit Bug 13371: change the filters wording -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:39:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:39:41 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34275|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart --- Created attachment 34299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34299&action=edit Bug 13371: just a test for the biblio|item count filters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:40:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:40:20 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #35 from Jonathan Druart --- Problem with sandbox, back to needs signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:45:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:45:55 +0000 Subject: [Koha-bugs] [Bug 13431] Can't access MARC bibliographic frameworks and other pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:49:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:49:02 +0000 Subject: [Koha-bugs] [Bug 13431] Can't access MARC bibliographic frameworks and other pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 --- Comment #1 from Martin Renvoize --- I'm seeing this issue more and more on IRC as people upgrade their package installs. The symptom is the appearance of the below error when searching, or looking at MRC Framework pages and a few other places: Open of share file /tmp/sharefile-koha-koha failed: Permission denied at /usr/lib/perl5/Cache/FastMmap.pm line 640. The fastest fix I've found to get your system back up and running whilst I work on a longer term fix, is to: 1) Add/Set 'SetEnv MEMCACHED_NAMESPACE="instancename"' per instance you have running in the apache virtual host configuration 2) Delete the existing temp file /tmp/somthing-koha-koha This will ensure koha creates a seperate temp file for caching pursposes on a epr instance basis, and the deletion will ensure it happens upon the next request per instance. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:51:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:51:14 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Courret changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |scourret at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:51:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:51:32 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Can't access MARC |Shared FastMmap file causes |bibliographic frameworks |issues |and other pages | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:51:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:51:56 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:57:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:57:53 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33173|0 |1 is obsolete| | --- Comment #36 from Jonathan Druart --- Created attachment 34300 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34300&action=edit Bug 12404: tools/export.pl allows CSV export -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:57:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:57:56 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33174|0 |1 is obsolete| | --- Comment #37 from Jonathan Druart --- Created attachment 34301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34301&action=edit Bug 12404: Add some documentation in the help page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:58:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:58:00 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33263|0 |1 is obsolete| | --- Comment #38 from Jonathan Druart --- Created attachment 34302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34302&action=edit Bug 12404: Allow equal sign '=' in the TT directive -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:58:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:58:03 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33477|0 |1 is obsolete| | --- Comment #39 from Jonathan Druart --- Created attachment 34303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34303&action=edit Bug 12404: FIX documentation to join subfield To display all subfields, the join TT method must be used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 10:59:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 09:59:25 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #40 from Jonathan Druart --- patches rebased, conflicts with bug 13308 fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 11:01:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 10:01:27 +0000 Subject: [Koha-bugs] [Bug 13142] Change "mobile phone" label back to "other phone" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13142 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #6 from sandboxes at biblibre.com --- Patch tested with a sandbox, by scourret at gmail.com <2> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 11:01:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 10:01:38 +0000 Subject: [Koha-bugs] [Bug 13142] Change "mobile phone" label back to "other phone" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13142 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33520|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 11:01:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 10:01:46 +0000 Subject: [Koha-bugs] [Bug 13142] Change "mobile phone" label back to "other phone" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13142 --- Comment #7 from sandboxes at biblibre.com --- Created attachment 34304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34304&action=edit DBRev 3.19.00.000: keep moving Signed-off-by: Tomas Cohen Arazi Signed-off-by: scourret at gmail.com <2> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 11:10:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 10:10:29 +0000 Subject: [Koha-bugs] [Bug 12895] Dropbox mode doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12895 Koha Team Rennes 2 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |koha at listes.univ-rennes2.fr --- Comment #5 from Koha Team Rennes 2 --- Test failed. The borrower is never restricted when checking the item with dropbox mode on, whatever the duedate is. We tried with one day late, two days late, 5 days late. It should be useful to precise that the circulation rules must be the same and to check these rules before testing. Kohateam Rennes 2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 11:13:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 10:13:12 +0000 Subject: [Koha-bugs] [Bug 13142] Change "mobile phone" label back to "other phone" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13142 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34304|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 11:13:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 10:13:25 +0000 Subject: [Koha-bugs] [Bug 13142] Change "mobile phone" label back to "other phone" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13142 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33520|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 11:13:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 10:13:34 +0000 Subject: [Koha-bugs] [Bug 13142] Change "mobile phone" label back to "other phone" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13142 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 11:31:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 10:31:06 +0000 Subject: [Koha-bugs] [Bug 13142] Change "mobile phone" label back to "other phone" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13142 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33520|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 34305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34305&action=edit Bug 13142 - Change "mobile phone" label back to "other phone" Labeling a phone number field "mobile phone" eliminates the usefulness of having the labels "primary" and "secondary." Generic labels let the user populate the fields according to their importance rather than their type. To test I recommend editing a patron record so that the values in the patron record contain a label matching the table column: borrowers.phone : 555-555-1234 (primary - phone) borrowers.phonepro : 555-555-5678 (secondary - phonepro) borrowers.mobile : 555-555-9012 (other - mobile) View this patron's information in the various affected templates and verify that the labels correctly match the data: - OPAC "your personal details" (opac-memberentry.pl) - Submit changes to primary, secondary, and other phone via the OPAC. In the staff client, view the confirmation for those changes. - Patron details in the staff client (moremember.pl) - Patron entry/edit in the staff client (memberentrygen.pl) - Patron duplicate confirmation in the staff client (you can navigate directly to /members/moremember.pl?borrowernumber=XXXX&print=brief) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 11:31:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 10:31:24 +0000 Subject: [Koha-bugs] [Bug 12584] koha-conf.xml for package installations get out of sync In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12584 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- Is there not a debconf option we can use here.. I suppose because it's a per instance thing that may be challenging.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 11:31:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 10:31:38 +0000 Subject: [Koha-bugs] [Bug 13142] Change "mobile phone" label back to "other phone" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13142 --- Comment #9 from Jonathan Druart --- patch rebased, conflicts with bug 9177 fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 11:50:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 10:50:55 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #21 from Jonathan Druart --- Created attachment 34306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34306&action=edit Bug 13371: List suppliers even if they don't have basket. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 11:51:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 10:51:32 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #22 from Jonathan Druart --- (In reply to Jonathan Druart from comment #21) > Created attachment 34306 [details] [review] > Bug 13371: List suppliers even if they don't have basket. This patch proposes a solution for suppliers without basket. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 11:57:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 10:57:46 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 --- Comment #28 from Jonathan Druart --- How could we move things forward here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:01:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:01:30 +0000 Subject: [Koha-bugs] [Bug 9528] Add delivery branch to the place hold display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9528 beroud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |isabelle.beroud at univ-lyon3. | |fr --- Comment #3 from beroud --- Four holds are placed on a same patron. Pickup locations are correctly displayed, but the header of the new column ? Pickup library? is not appeared. So, the last three headers of columns are also not correctly placed. (expiration,priority,delete) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:10:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:10:42 +0000 Subject: [Koha-bugs] [Bug 10753] Creating suggestions for 'Any library' uses _ANY as branchcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10753 --- Comment #2 from Jonathan Druart --- Created attachment 34307 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34307&action=edit Bug 10753: Any library is represented by an empty string And not with "__ANY__" Test plan: 0/ Don't apply this patch 1/ Create a suggestion for "any library" 2/ Verify suggestions.branchcode contain "__ANY__" 3/ Apply this patch and execute the updatedb entry 4/ Create a suggestion for "any library" 5/ Verify suggestions.branchcode contain "" (for both suggestions). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:10:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:10:37 +0000 Subject: [Koha-bugs] [Bug 10753] Creating suggestions for 'Any library' uses _ANY as branchcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10753 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:12:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:12:03 +0000 Subject: [Koha-bugs] [Bug 10753] Creating suggestions for 'Any library' uses _ANY as branchcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10753 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m --- Comment #3 from Jonathan Druart --- I am under the impression that this simple patch fixes the problem. Someone to confirm? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:18:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:18:52 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #23 from Paola Rossi --- (In reply to Jonathan Druart from comment #10) > (In reply to Paola Rossi from comment #9) [...] Thanks, Jonathan. NB1), NB2) and NB3) of comment #9 and #10 are allright. NB4) and NB6) have already been taken in care and are being to study at present. About NB5) I'll make some tests on master asap, thanks again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:23:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:23:51 +0000 Subject: [Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #13 from Jonathan Druart --- Can I know how we want to see this number calculated? On master I got all suggestions, with these 2 patches, I got the suggestions from the current branch + from any library. So the number is still different... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:27:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:27:54 +0000 Subject: [Koha-bugs] [Bug 12838] Deleting a borrower orphans that borrower's lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12838 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13417 --- Comment #7 from Jonathan Druart --- I think bug 13417 proposes a good and easy way to fix this problem. Please mark this one as a duplicate if you agree. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:27:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:27:54 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12838 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:30:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:30:23 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 --- Comment #2 from Robin Sheat --- Damn,I thought it was supposed to pick up the username it was running under and include that in the filename. If someone can figure out how to make it do that then I can roll a fixed package. I'm at a conference until Saturday so won't have a chance to look into it, but can make time to do a release. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:35:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:35:06 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cataloging plugins without |Improvements for framework |redefining |plugins in cataloguing/item | |editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:35:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:35:22 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:36:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:36:20 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #24 from Paola Rossi --- (In reply to Jonathan Druart from comment #12) > > > > 'Item count' and 'Biblio count' didn't yet work: > > "No matching records found" (even if some records matched my search). > > Could you please test with the last patch I submitted? > Since I don't reproduce the issue, it's not easy to fix it :-/ I've applied the today's version of the patch against master 3.19.00.000 . The error still occurred, either with or without the 5-th patch "just a test..". It happened using: FF 34.0.5, IE 11, GCh Version 39.0.2171.95 m [The error occurred even yesterday [applying the previuos version of the patches] even applying the 5-th patch "just a test ..." , sorry for my delay.] Applying the patches is ok at my tests. The first 13771 patch required an auto-merging: Applying: Bug 13371: Add filters on the supplier list view Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/css/datatables.css I've made some tests but I unfortunately have not yet got anything helping imo. 2) About searching vendors: I searched vendors without baskets [using "Vendor search"]: If 1 vendor had no baskets in DB, koha answered nothing about results found, showing no vendor and "No data available in table"; but also showing "+New" [basket/contract/vendor] "Edit vendor" "Receive shipments" (all useful and about that vendor) on top of the table [it's partially right: it's wrong because the name is not seen]. If 2 vendor had no baskets in DB, koha answered with "2 results found", showing no vendor "No data available in table", and nothing else. I pass this patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:37:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:37:33 +0000 Subject: [Koha-bugs] [Bug 13305] Fix tab order in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13305 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED Summary|Fix tab order on three item |Fix tab order in |editor forms |cataloguing/item editor --- Comment #4 from M. de Rooy --- Will try to submit the more complete one as a follow-up on work for bug 10480. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:37:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:37:40 +0000 Subject: [Koha-bugs] [Bug 13305] Fix tab order in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13305 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10480 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:37:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:37:40 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13305 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:37:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:37:56 +0000 Subject: [Koha-bugs] [Bug 13305] Fix tab order in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13305 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10480 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:37:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:37:56 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13305 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:38:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:38:09 +0000 Subject: [Koha-bugs] [Bug 13305] Fix tab order in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13305 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33731|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:39:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:39:33 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 --- Comment #13 from M. de Rooy --- (In reply to M. de Rooy from comment #12) > Still want to proceed on this in another direction. This took some more time than I hoped for. But will submit them now, based on the concept of two anynomous subroutines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:40:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:40:22 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 --- Comment #14 from M. de Rooy --- Created attachment 34308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34308&action=edit Bug 10480: New module and unit test for framework plugins This patch introduces the Koha::FrameworkPlugin object to Koha. This object supports the current "old-style" plugins while adding a new style based on the concept of two anynomous subroutines for building and launching. I will summarize the advantages of this new approach, justifying the additional lines of code in this patch: [1] Centralizing the code for building and launching plugins. [2] Extensive unit testing: this was not possible before. [3] Simplicity: Only define what you need in the plugin. A follow-up patch will delete 1500 lines with *empty* routines. [4] Make it possible to restore the warnings pragma for all plugins. New style plugins do no longer depend on redefinition. [5] Event binding moved from HTML attributes moved to jQuery code. This separates behavior and presentation. [6] Much more documentation, including EXAMPLE plugin in follow-up. [7] Improved error handling. [8] Usability: property noclick tells you if plugin's buttonDot is active. [9] More events supported: Change, keyboard/mouse events. See EXAMPLE. NOTE ON EXAMPLE PLUGIN: The example plugin is added in the third patch of this report. Since it is new style, it can be used only after we start using this object. It also contains an example for a keypress and mouseover event. NOTE ON ITEM PLUGINS: Old style plugins for items contain an additional parameter in the js functions for Blur, Focus and Change. This distinction has no actual use and is resolved for new plugins in the object code. When converting item plugins, this minor correction will be addressed. In the meantime old style item plugins behave as expected. TEST PLAN: Run the new test t/db_dependent/FrameworkPlugin.t At this point in time, you do not need to do anything more. Follow-up patches will incorporate the object in real-life Koha and provide additional test plans. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:40:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:40:26 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 --- Comment #15 from M. de Rooy --- Created attachment 34309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34309&action=edit Bug 10480: Use the framework plugin object in cataloguing This patch implements the use of Koha::FrameworkPlugin in Cataloguing, Authorities, Acquisition, Serials and Tools. The main change is architectural: see the commit message of the previous patch. No changes in behavior are expected, but the support of new events may provide additional functionality in the future. Some small bugs are resolved along the way. The change primarily focuses on the MARC and items editor in Cataloguing. But the MARC editor for Authorities and the item editor in Acquisition, Serials and Tools are touched too. This commit message gives some comments per module. NOTE FOR CATALOGUING: A new plugin without popup (or other click event code) now shows the title No popup when hovering over the tag editor image. The image alerts the user on a plugin, the title tells about its status. The noclick property allows for further style modifications in the template. Note that a follow-up patch will clean up the old style plugins too with the same effect. Some additional code in cataloging.js makes it possible to clone subfields with plugins (although only theoretically useful). The clones use the same javascript functions but event.data contains an updated id. This effectively resolves bug 13306. Note that if old plugins do not use the javascript parameter for the id but the perl variable, cloning does still operate on the wrong field (with and without this patch set). In the absence of report 12176 in master, it is not yet necessary to modify additem.tt. When it gets pushed, it should be an easy rebase. New style item plugins will no longer need an extra parameter. (The code in the FrameworkPlugin object actually takes care of that.) NOTE FOR AUTHORITIES: This patch also adds class name tag_editor to the buttonDot anchors. This effectively makes the same tag editor image appear as in Cataloguing. Futhermore it removes the button from the tab sequence if there is no click event (really effective after conversion to the new style, since the old style plugins contain empty onclicks and launchers). Both small adjustments increase consistency between auth and bib edits. NOTE FOR ACQUISITION: In Acquisition two scripts use an item editor, but in a different way. The scripts addorderiso2709 and neworderempty both rely on the routine PrepareItemrecordDisplay in C4::Items, but neworderempty creates item blocks dynamically via an ajax call to services/itemrecorddisplay.pl. In order to make the dynamic item blocks work with plugins, some code changes were needed in additem.js. (Normally the event binding is done at document ready time; now it must be done later.) At this moment the routine in Items.pm contains the html tags, and this makes changes to the following templates not necessary for now: * acqui/addorderiso2709.tt * services/itemrecorddisplay.tt Report 13397 has been opened to address moving the html to the templates. NOTE FOR SERIALS: Script serial-edit relies also on C4::Items (just as in Acquisition). This makes changes to serials/serials-edit.tt not necessary for now. NOTE FOR TOOLS: The current code in tools/batchMod.pl allows the use of plugins for batch modification of items. This patch just converts that code to use the new object. Most item plugins however may not be very useful for operating on multiple items at once. PERFORMANCE: I have benchmarked build_tabs in addbiblio to see how especially the additional processing of the javascript in the FrameworkPlugin object would impact performance. Testing default MARC21 framework with 8 plugins gave the following figures: - Old situation: 851 ms - New situation: 942 ms (+10,7%) - New situation after plugin cleanup: 881 ms (+3,4%) Note also that adding lines for event binding is compensated by removing lines for unused events. Page load should essentially be the same. TEST PLAN: Suggestion: If you also apply the next patch with the EXAMPLE plugin, you can test with a rather harmless plugin (with popup) on various places :) But your test should also include old style plugins, with[out] popups. If you want to test a new plugin without popup, rename/remove Click$id in the javascript code of the $builder definition (temporarily). [1] Test Cataloguing: - Add/Edit biblio. Try plugins with and without popup. - Add/Edit items. (EXAMPLE can be used as an item plugin with popup.) - Clone a subfield with plugin (use EXAMPLE): Verify that the plugin works on both original and clone with the respective field values. Is the value put back in the right field too? [2] Test Authorities: Edit an authority record. Try plugins with an without popup. [3] Test Acquisition: Set system preference AcqCreateItem to "placing an order". Check the item editor in the following two places: a- addorderiso2709: Open a basket, add an order from a staged file. Select a file, click Add orders, and go to tab Item information. b- neworderempty: Open a basket, add an order from a new empty record. [4] Test Serials: Check the item editor on serials-edit. Go to subscription detail. Click Receive. Choose "Click to add item". (Note that this subscription should create an item record when receiving this serial.) [5] Test Tools: Check the item editor for batch item modification. Enter a few valid barcodes and press Continue to reach the item editor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:40:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:40:29 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 --- Comment #16 from M. de Rooy --- Created attachment 34310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34310&action=edit Bug 10480: EXAMPLE plugin with associated template The EXAMPLE plugin helps you to create a new style framework plugin by providing a simple working example and additional documentation for developers. Test plan: [1] Connect the EXAMPLE plugin to one or more fields. [2] Try the following events: a- Focus: If the field is empty, it should put EXAMPLE: into it. b- MouseOver: If the field is empty and you move your mouse over it, it should have the same effect as Focus. c- Change: Edit the field in the editor and tab out of it, the color of the text should toggle (randomly) between red, green and blue. d- KeyPress: If you edit the field and you type @, it should give AT. e- Click: Click on the tag editor. Change the value in the popup. If you press OK, the field should be changed. [3] Would the documentation in the perl script help you to create a plugin? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:40:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:40:37 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 --- Comment #18 from M. de Rooy --- Created attachment 34312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34312&action=edit Bug 10480: Follow-up for unimarc_field_686a/_700-4.pl This patch fixes the pod errors on those two files by removing the pod section that actually does not add anything useful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:40:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:40:33 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 --- Comment #17 from M. de Rooy --- Created attachment 34311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34311&action=edit Bug 10480: Remove useless routines and irrelevant pod lines This patch makes the following cleanup actions for all plugins: 1- Remove sub plugin_parameters. This function is not used. 2- Remove empty plugin or empty plugin_javascript subs. 3- Remove empty Blur, Clic or Focus routines from javascript. 4- Remove pod lines (copy-pasta) only referring to the 3 plugin subs. 5- Remove the last 1; line. It is no longer needed. Test plan: Run the unit test t/db_dependent/FrameworkPlugins.t Test some cataloguing plugins in addbiblio. Test some item plugins in additem and neworderempty. Signed-off-by: Marcel de Rooy I also checked the syntax of all plugins with perl -c. And checked the pod (if any) with podchecker: Two files still produce a warning; the follow-up deals with them: unimarc_field_686a/_700-4.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:44:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:44:21 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #19 from M. de Rooy --- I will add see also-reports to convert old style plugins to new style plugins for marc21, normarc and unimarc. This can be tested and handled separately however. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:45:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:45:08 +0000 Subject: [Koha-bugs] [Bug 13437] New: Convert marc21 framework plugins to new style (see also 10480) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 Bug ID: 13437 Summary: Convert marc21 framework plugins to new style (see also 10480) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:45:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:45:13 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #25 from Paola Rossi --- Sorry, my comment 24 didn't take in care the Jonathan's comment 22. I pass the patch back to "Needs Signoff" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:45:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:45:40 +0000 Subject: [Koha-bugs] [Bug 13438] New: Convert normarc framework plugins to new style (see also 10480) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13438 Bug ID: 13438 Summary: Convert normarc framework plugins to new style (see also 10480) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:46:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:46:03 +0000 Subject: [Koha-bugs] [Bug 13439] New: Convert unimarc framework plugins to new style (see also 10480) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13439 Bug ID: 13439 Summary: Convert unimarc framework plugins to new style (see also 10480) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:47:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:47:00 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13437 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:47:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:47:00 +0000 Subject: [Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style (see also 10480) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10480 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:47:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:47:07 +0000 Subject: [Koha-bugs] [Bug 13438] Convert normarc framework plugins to new style (see also 10480) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13438 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10480 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:47:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:47:07 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13438 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:47:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:47:16 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13439 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 12:47:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 11:47:16 +0000 Subject: [Koha-bugs] [Bug 13439] Convert unimarc framework plugins to new style (see also 10480) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13439 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10480 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 13:37:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 12:37:15 +0000 Subject: [Koha-bugs] [Bug 13428] Fix facet deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13428 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 13:37:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 12:37:17 +0000 Subject: [Koha-bugs] [Bug 13428] Fix facet deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13428 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34274|0 |1 is obsolete| | --- Comment #3 from Mason James --- Created attachment 34313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34313&action=edit Bug 13428: Fix regression on deleting facets Test plan: Search for something click on a facet with diacritic click on another facet remove the facet with diacritic Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 13:38:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 12:38:45 +0000 Subject: [Koha-bugs] [Bug 13428] Fix facet deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13428 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #4 from Mason James --- > Signed-off-by: Mason James this tested OK for me on 3.16, 3.18 and master branches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 13:39:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 12:39:06 +0000 Subject: [Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #6 from Koha Team Lyon 3 --- no, I didn't sign off, it was the "sandbox bug" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 13:39:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 12:39:49 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED CC| |m.de.rooy at rijksmuseum.nl --- Comment #143 from M. de Rooy --- Changing status.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 13:49:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 12:49:11 +0000 Subject: [Koha-bugs] [Bug 12868] GetMemberDetails calls GetMemberAccountRecords incorrectly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12868 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 13:49:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 12:49:14 +0000 Subject: [Koha-bugs] [Bug 12868] GetMemberDetails calls GetMemberAccountRecords incorrectly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12868 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33942|0 |1 is obsolete| | Attachment #33943|0 |1 is obsolete| | --- Comment #12 from M. de Rooy --- Created attachment 34314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34314&action=edit Bug 12868: Improving t/db_dependent/Member.t The mock function of GetMemberAccountRecord did not properly account for the undef case. This was corrected. Then all 4 combinations of borrower number and card number being defined or not were called to GetMemberDetail. The problematic test case is where the borrower number is undefined and the cardnumber is defined. TEST PLAN --------- 1) Apply just this first patch. 2) prove -v t/db_dependent/Member.t -- This should fail! 3) Run koha QA test tools. Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 13:49:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 12:49:44 +0000 Subject: [Koha-bugs] [Bug 12868] GetMemberDetails calls GetMemberAccountRecords incorrectly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12868 --- Comment #13 from M. de Rooy --- Created attachment 34315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34315&action=edit Bug 12868: Wrong variable used for borrower number When only the card number is passed to GetMemberDetail, the value of $borrowernumber is undefined. Even after finding the correct borrower and providing a nice hash ($borrower), the GetMemberAccountRecords is called with the wrong borrower number, even though it is in the hash ($borrower). This was fixed by changing $borrowernumber to $borrower->{borrowernumber}, so that the hash's value will always be used, since it is correct regardless of whether borrowernumber or cardnumber were used to find the borrower. TEST PLAN --------- 1) Apply both patches 2) prove -v t/db_dependent/Member.t -- This time the previously failing test will pass. 3) run koha QA test tools. Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 13:50:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 12:50:39 +0000 Subject: [Koha-bugs] [Bug 13428] Fix facet deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13428 --- Comment #5 from Mason James --- (In reply to Mason James from comment #4) > > Signed-off-by: Mason James > > this tested OK for me on 3.16, 3.18 and master branches tested OK on prog and BS opac themes, for 3.16 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 13:52:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 12:52:37 +0000 Subject: [Koha-bugs] [Bug 12868] GetMemberDetails calls GetMemberAccountRecords incorrectly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12868 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 13:52:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 12:52:53 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 13:54:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 12:54:08 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 --- Comment #29 from Fridolin SOMERS --- (In reply to Jonathan Druart from comment #28) > How could we move things forward here? In my opinion, this bug opened a big discussion but the main purpose was to fix a specific bug on statistics. We should integrate this patch and continue discussion in a new bug or in kohadevel. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 13:56:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 12:56:36 +0000 Subject: [Koha-bugs] [Bug 12838] Deleting a borrower orphans that borrower's lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12838 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #8 from Fridolin SOMERS --- *** This bug has been marked as a duplicate of bug 13417 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 13:56:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 12:56:34 +0000 Subject: [Koha-bugs] [Bug 13414] Enable right truncation with search by relevance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #4 from sandboxes at biblibre.com --- Patch tested with a sandbox, by kohateam rennes 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 13:56:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 12:56:36 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #4 from Fridolin SOMERS --- *** Bug 12838 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 13:56:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 12:56:52 +0000 Subject: [Koha-bugs] [Bug 13414] Enable right truncation with search by relevance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414 --- Comment #5 from sandboxes at biblibre.com --- Created attachment 34316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34316&action=edit Bug 13414 - Enable automatic right truncation while searching by relevance This makes slight modification in build_weighted_query function in order to make automatic right truncation possible when QueryWeightFields syspref activated (even little ranked) Modify this syspref type from boolean to choice in order to add this possiblity as a third option : Search by relevance with automatic right truncation. Signed-off-by: kohateam rennes 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 13:56:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 12:56:45 +0000 Subject: [Koha-bugs] [Bug 13414] Enable right truncation with search by relevance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34285|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 13:57:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 12:57:24 +0000 Subject: [Koha-bugs] [Bug 5763] Add users private list management functionality for administrators In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5763 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13417 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 13:57:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 12:57:24 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5763 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 13:58:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 12:58:15 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 --- Comment #30 from Jonathan Druart --- And what about updating existing DB values (comment 26)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 14:01:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 13:01:19 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 --- Comment #3 from Jacek Ablewicz --- Looks like not only multi-tenant setups are affected by this bug: I just stumbled upon the very same thing when trying to import some biblios into the database using misc/migration_tools/bulkmarcimport.pl script. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 14:01:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 13:01:52 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #5 from Fridolin SOMERS --- I agree with a new permission. What for is this line : + if ( $user > 0 ) { To exclude database user (the one in koha-conf.xml) ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 14:01:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 13:01:53 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 14:04:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 13:04:39 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #6 from Jonathan Druart --- If not user is logged. This code is used for intranet and opac. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 14:05:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 13:05:22 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #7 from Jonathan Druart --- "If no user is logged in" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 14:17:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 13:17:48 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #8 from Fridolin SOMERS --- (In reply to Jonathan Druart from comment #6) > If not user is logged. > This code is used for intranet and opac. Ah, OK. Its because of line 455 in C4/VirtualShelves.pm : $user=0 unless $user; This has an impact : database user as $user=0 so he will not have this permission. Its not a big deal since this database user should be used only to manage staff users. Nice job Jonathan ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 14:24:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 13:24:27 +0000 Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/required fields on the suggestion form in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28792|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 34317 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34317&action=edit Bug 10848 - Allow configuration of mandatory/required fields on the suggestion form in OPAC #2/2 (part #2: new syspref 'OPACSuggestionMandatoryFields' + DB updates) Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 14:24:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 13:24:32 +0000 Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/required fields on the suggestion form in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29091|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 34318 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34318&action=edit Bug 10848 - Allow configuration of mandatory/required fields on the suggestion form in OPAC #1/2 (part #1: changes in opac-suggestions.* script + bootstrap template) This patch: - adds a configuration option which allows to define which fields (apart from the title) should be mandatory for a patron purchase suggestion form in OPAC - impoves the method how required form fields are enforced, by utilising new HTML5 "required" attribute (old method would still be operational in old/legacy browsers which do not support "required" attribute properly). Allowed fields that are configurable as mandatory/not mandatory for suggestions made via OPAC are: author|copyrightdate|collectiontitle| isbn|publishercode|place|note|itemtype|patronreason. Note: this patch only applies to OPAC bootstrap theme. To test: 1/ Apply patch. 2/ Without 'OPACSuggestionMandatoryFields' option set, OPAC suggestion form should only require the title field. 3/ Set 'OPACSuggestionMandatoryFields' syspref to (e.g.) 'author|isbn|itemtype' 4/ Note that suggestion form in OPAC now requires 3 more fields to be entered and/or choosen (they should be labeled in red), and the user instruction changes slightly ("Form fields labeled in red are mandatory" ..). 5/ Try to submit some suggestions: for each field which is configured as mandatory, browser should enforce this field to be filled (in modern, HTML5 compilant browsers), or (as a fallback mechanism for legacy browsers) there should be an alert message displayed stating that some mandatory fields are missing. 6/ In both modern and legacy browsers, unless all mandatory fields are filled with something, form submission should not be possible. 7/ Repeat test 3-6 for all supported field names configurable as mandatory. If possible, "legacy" browser tests should ideally involve IE9 and (some older version of) Safari, which are rumored to have somehow questionable reputation regarding "required" HTML attribute support. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 14:24:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 13:24:36 +0000 Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/required fields on the suggestion form in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29092|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 34319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34319&action=edit Bug 10848 [QA Followup] - Allow configuration of mandatory/required fields on the suggestion form in OPAC #2/2 QA follow-up for part #2: fixed OPACSuggestionMandatoryFields system preference description. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 14:24:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 13:24:52 +0000 Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/required fields on the suggestion form in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 --- Comment #15 from Jonathan Druart --- patch rebased, small conflict on updatedb.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 14:27:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 13:27:29 +0000 Subject: [Koha-bugs] [Bug 12895] Dropbox mode doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12895 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from Koha Team Lyon 3 --- Very sorry. my fault. My test plan was missing some most important thing. Here's the reason why that doesn't work : you must affect suspension days parameter in the circulation rules (Administration/Circulation and fine rules) matching both borrower and document type you choose for the test. Test plan : 1) choose a borrower and an item 2) Set suspension in the suspension days parameter in the circulation rules (Administration/Circulation and fine rules) matching both borrower and document type 3) Checkout the item selecting the previous opening date in the Specify-due-date box. 4) click on Circulation in the upper menu, then on Checkin and check the Book drop mode. The Book drop date showed should be the previous opening date. 5) Check in the item : you can see that the patron is restricted 6) apply the patch 7) redo 1 to 5 : Now, you can see that the patron is not restricted. 8) If you redo the test with two day late, you will see that the patron is not restricted : that's ok because his restriction of one day is already finished. 9) If you redo the test with more than two day late, you see that the patron restriction is, as expected, one day shorter than it were if the item had been returned without dropbox mode. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 14:33:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 13:33:58 +0000 Subject: [Koha-bugs] [Bug 13124] Record titles with parentheses causing label weirdness In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal --- Comment #10 from Kyle M Hall --- Not only is this bug still valid, it's worse than I had believed. It appears that parens in other parts of the label will stop the reset of the labels in a batch from printing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 14:34:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 13:34:09 +0000 Subject: [Koha-bugs] [Bug 7680] Create a PatronDefaultView preference to control whether patron links go to circ or patron details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 --- Comment #17 from Jonathan Druart --- I am still a candidate to SO or QA this patch if rebased :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 14:34:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 13:34:50 +0000 Subject: [Koha-bugs] [Bug 13398] Perl files for rotating collections are missing in debian package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13398 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 14:35:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 13:35:18 +0000 Subject: [Koha-bugs] [Bug 7680] Create a PatronDefaultView preference to control whether patron links go to circ or patron details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins at cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 14:35:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 13:35:30 +0000 Subject: [Koha-bugs] [Bug 13398] Perl files for rotating collections are missing in debian package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13398 --- Comment #1 from Katrin Fischer --- This one is quite bad - rotating collections is one of the main new features... and it's missing from the packages. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 14:40:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 13:40:38 +0000 Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 --- Comment #25 from Martin Renvoize --- Created attachment 34320 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34320&action=edit Bug - 5511 [Followup]: Missed Instance There was an instance of the pragma missed which meant the the original patch set didn't actually solve the problem in a large number of cases This aptch adds in the relevant statement. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 14:43:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 13:43:26 +0000 Subject: [Koha-bugs] [Bug 12895] Dropbox mode doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12895 --- Comment #7 from Koha Team Rennes 2 --- (In reply to Koha Team Rennes 2 from comment #5) > Test failed. The borrower is never restricted when checking the item with > dropbox mode on, whatever the duedate is. We tried with one day late, two > days late, 5 days late. > > It should be useful to specify that the circulation rules must be the same > and to check these rules before testing. > > Kohateam Rennes 2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 14:47:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 13:47:35 +0000 Subject: [Koha-bugs] [Bug 13124] Record titles with parentheses causing label weirdness In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 --- Comment #11 from Chris Nighswonger --- (In reply to Kyle M Hall from comment #10) > Not only is this bug still valid, it's worse than I had believed. It appears > that parens in other parts of the label will stop the reset of the labels in > a batch from printing! I can see how this would be a problem, however. PDF::Reuse::prText presently attempts to escape parentheses. I don't remember why I saw the need to escape them in the label module, but it certainly results in double escapment which could lead to various strange results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 14:48:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 13:48:55 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 --- Comment #41 from Courret --- Patch works for displaying subfields in the same column. Also works for displaying the first subfield for a field if specified indicator for field is present. Can display a subfield if an indicator is set. So most of the features are working without trouble. But it looks like I?m unable to extract a substring from a field (typically, UNIMARC language field from 100$a ? character 22-24). May someone test it ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 14:57:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 13:57:07 +0000 Subject: [Koha-bugs] [Bug 13440] New: 'Check out' tab search for patron gives perl error Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13440 Bug ID: 13440 Summary: 'Check out' tab search for patron gives perl error Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To test: - Log into Koha - Go to the circulation module - search for a patron in the database - perl error is shown :( Bad arg length for Socket::pack_sockaddr_in, length is 0, should be 4 at /usr/lib/perl5/Socket.pm line 809 This is a 3.18.1 package installation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 14:59:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 13:59:31 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 --- Comment #42 from Jonathan Druart --- (In reply to Courret from comment #41) > But it looks like I?m unable to extract a substring from a field (typically, > UNIMARC language field from 100$a ? character 22-24). May someone test it ? Did you try something like [% fields.100.0.a.0.substr( 22, 3 ) %] ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:04:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:04:51 +0000 Subject: [Koha-bugs] [Bug 8306] Patron stats, patron activity : no active doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8306 --- Comment #6 from Jonathan Druart --- I can reproduce on the production server of the customer, maybe because of the high amount of data (17k users, 70k old_issues). I confirm the result of the reports is the same before and after the patch (and I cannot reproduce on a local instance). But it seems logical to me to exclude old_issues where borrowernumber is null (deleted patrons), don't you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:06:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:06:17 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #9 from M. de Rooy --- (In reply to Jonathan Druart from comment #0) > Currently a public list can only be deleted by its owner. > This means lists can exist infinitely. Please look for HandleDelBorrower. When you delete a patron, you delete his lists including the public lists. Please see bug 11889. It was opened to discuss/find a solution where you do not want to delete all his public lists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:09:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:09:04 +0000 Subject: [Koha-bugs] [Bug 13440] 'Check out' tab search for patron gives perl error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13440 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz --- Comment #1 from Katrin Fischer --- Hm, I can see this in 2 different installations done from packages, but not in my dev environment, others can't reproduce so far... all ideas welcome. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:09:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:09:16 +0000 Subject: [Koha-bugs] [Bug 8306] Patron stats, patron activity : no active doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8306 --- Comment #7 from Jonathan Druart --- Note that this could certainly be fixed on this specific installation if the nginx timeout is increased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:09:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:09:15 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 --- Comment #4 from Jacek Ablewicz --- Created attachment 34321 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34321&action=edit Bug 13431 - Shared FastMmap file causes issues Koha::Cache package does not take into account that, when using fastmmap caching variant, mmaped cache file created in /tmp (typically: /tmp/sharefile-koha-koha), would only be further accessible to the one given OS user - the one which created it. In many Koha setups, in the circumstances when various system scripts are executed by 2+ users with diffrent UIDs (like multi-tenant servers, for example) this may cause many kinds of issues. Observable symptom is usually the appearance of the below error when searching, or looking at MARC Framework pages and a few other places: Open of share file /tmp/sharefile-koha-koha failed: Permission denied at /usr/lib/perl5/Cache/FastMmap.pm line 640. This patch adds the ID of the OS user to the mmaped file name created in /tmp, to prevent such kinds of conflicts and/or permission problems from happening. To test: 1) remove the /tmp/sharefile-koha-* file[s] (if any) 2) do something which would lead to its re-creation (e.g., performing any search in OPAC should be sufficient to cause that) 3) observe that /tmp/sharefile-koha-koha got created 4) remove it 5) apply patch 6) redo step 2) 7) observe that file created in /tmp now does have the OS user id included in it's name (e.g. it would be named like that 'sharefile-koha-koha-www-data' - depending on the particular test setup) 8) add some additional user to the /etc/passwd, with the same UID www-data has, but with different name (e.g. 'www-data2'); redo the tests; ensure that it still works fine in such unusual case -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:09:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:09:55 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |abl at biblos.pk.edu.pl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:16:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:16:52 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #10 from M. de Rooy --- I would favor a permission for allowing staff to manage lists that they do not own. It was discussed on older reports already. But the solution of this patch is imo little bit too quick. [1] The change of sub ShelfPossibleAction is not very refined and may have side-effects. [2] You allow deletion of public lists now, but what if you want to manage a private or shared list from another user? Would it not be better to show a third tab in staff for Other lists (or even another form?) that allows you to search lists, delete, edit, change ownership, etc.? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:19:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:19:10 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #11 from M. de Rooy --- Saw a Bug XXXXX: Add permission for shelves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:22:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:22:55 +0000 Subject: [Koha-bugs] [Bug 13124] Record titles with parentheses causing label weirdness In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Severity|normal |major --- Comment #12 from Chris Nighswonger --- Bumping the importance of this fix. I'll try to sign off today or tomorrow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:25:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:25:45 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #12 from Jonathan Druart --- (In reply to M. de Rooy from comment #9) > (In reply to Jonathan Druart from comment #0) > > Currently a public list can only be deleted by its owner. > > This means lists can exist infinitely. > > Please look for HandleDelBorrower. > When you delete a patron, you delete his lists including the public lists. > Please see bug 11889. It was opened to discuss/find a solution where you do > not want to delete all his public lists. Ha yes, I forgot that! But we don't want to remove public lists. So I could submit a patch to remove private lists only, do you agree with that? (In reply to M. de Rooy from comment #10) > I would favor a permission for allowing staff to manage lists that they do > not own. It was discussed on older reports already. Code from VirtualShelves is really not easy to read/modify, I preferred not to change it to much. > But the solution of this patch is imo little bit too quick. > [1] The change of sub ShelfPossibleAction is not very refined and may have > side-effects. I don't think it will introduce side-effects. The change is quite trivial. > [2] You allow deletion of public lists now, but what if you want to manage a > private or shared list from another user? Would it not be better to show a > third tab in staff for Other lists (or even another form?) that allows you > to search lists, delete, edit, change ownership, etc.? Discussion appended on a lot of bug reports, and no patch has been pushed yet. I propose a quick and easy solution to answer a big and real problem for librarians. Even if it is not perfect. I would not like to add a new tab here, I already have submitted a big change for this page (see bug 13419). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:26:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:26:08 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #13 from Jonathan Druart --- (In reply to M. de Rooy from comment #11) > Saw a Bug XXXXX: Add permission for shelves Maybe bug 9833? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:29:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:29:37 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #71 from sandboxes at biblibre.com --- Patch tested with a sandbox, by R?my-Juliette -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:29:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:29:51 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34234|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:30:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:30:01 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #72 from sandboxes at biblibre.com --- Created attachment 34322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34322&action=edit Bug 8236 Renewing policy in overdue or restriction case This patch introduces 2 sysprefs : RestrictionBlockRenewing to allow/block renewal of items when patron is restricted. OverduesBlockRenewing to allow, block only the late ones or block all checked out items Default is "allow" in both case. Signed-off-by: R -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:37:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:37:27 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Levast changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |juliette.levast at iepg.fr --- Comment #73 from Levast --- This patch works perfectly. He answers all our needs and it is essential for our users. Hoping it quickly pushed master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:39:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:39:28 +0000 Subject: [Koha-bugs] [Bug 13440] 'Check out' tab search for patron gives perl error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13440 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Katrin Fischer --- Ok, found the problem, in our koha-conf.xml file, there were some entries causing the problem: __MEMCACHED_SERVERS__ __MEMCACHED_NAMESPACE__ Emptying them out fixed the problem: -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:39:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:39:52 +0000 Subject: [Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279 --- Comment #28 from Jonathan Druart --- (In reply to M. de Rooy from comment #26) > At this point, I would go for refactoring instead of spending more time on > the current code. So I obsolete both patches. It's a major bug and still exists on master. I would like to see this bug fixed quickly. And the quicker way is to push these patches, don't you think? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:40:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:40:55 +0000 Subject: [Koha-bugs] [Bug 13440] 'Check out' tab search for patron gives perl error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13440 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- Maybe should we add a check in the about page? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:43:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:43:30 +0000 Subject: [Koha-bugs] [Bug 13440] 'Check out' tab search for patron gives perl error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13440 --- Comment #4 from Katrin Fischer --- Not sure how common the problem is - I think it happened because we tried to manually complete/change it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:47:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:47:28 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:47:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:47:32 +0000 Subject: [Koha-bugs] [Bug 13440] 'Check out' tab search for patron gives perl error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13440 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|INVALID |--- --- Comment #5 from Jonathan Druart --- It's a bug. It comes from SQLHelper koha at koha-qa:~/src (BZ8306??)% git grep memcache | grep config C4/SQLHelper.pm: my $servers = C4::Context->config('memcached_servers'); C4/SQLHelper.pm: key_prefix => C4::Context->config('memcached_namespace') || 'koha', -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:47:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:47:31 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34321|0 |1 is obsolete| | --- Comment #5 from Tom?s Cohen Arazi --- Created attachment 34323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34323&action=edit [SIGNED OFF] Bug 13431 - Shared FastMmap file causes issues Koha::Cache package does not take into account that, when using fastmmap caching variant, mmaped cache file created in /tmp (typically: /tmp/sharefile-koha-koha), would only be further accessible to the one given OS user - the one which created it. In many Koha setups, in the circumstances when various system scripts are executed by 2+ users with diffrent UIDs (like multi-tenant servers, for example) this may cause many kinds of issues. Observable symptom is usually the appearance of the below error when searching, or looking at MARC Framework pages and a few other places: Open of share file /tmp/sharefile-koha-koha failed: Permission denied at /usr/lib/perl5/Cache/FastMmap.pm line 640. This patch adds the ID of the OS user to the mmaped file name created in /tmp, to prevent such kinds of conflicts and/or permission problems from happening. To test: 1) remove the /tmp/sharefile-koha-* file[s] (if any) 2) do something which would lead to its re-creation (e.g., performing any search in OPAC should be sufficient to cause that) 3) observe that /tmp/sharefile-koha-koha got created 4) remove it 5) apply patch 6) redo step 2) 7) observe that file created in /tmp now does have the OS user id included in it's name (e.g. it would be named like that 'sharefile-koha-koha-www-data' - depending on the particular test setup) 8) add some additional user to the /etc/passwd, with the same UID www-data has, but with different name (e.g. 'www-data2'); redo the tests; ensure that it still works fine in such unusual case Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:48:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:48:16 +0000 Subject: [Koha-bugs] [Bug 11385] C4::SQLHelper should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11385 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13440 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:48:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:48:16 +0000 Subject: [Koha-bugs] [Bug 13440] 'Check out' tab search for patron gives perl error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13440 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11385 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:48:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:48:44 +0000 Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/required fields on the suggestion form in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #16 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Val?rie Bertrand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:49:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:49:00 +0000 Subject: [Koha-bugs] [Bug 13440] 'Check out' tab search for patron gives perl error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13440 --- Comment #6 from Jonathan Druart --- Reopened, but not critical now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:49:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:49:10 +0000 Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/required fields on the suggestion form in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34317|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:49:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:49:13 +0000 Subject: [Koha-bugs] [Bug 13440] 'Check out' tab search for patron gives perl error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13440 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW Severity|critical |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:49:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:49:16 +0000 Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/required fields on the suggestion form in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34318|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:49:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:49:20 +0000 Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/required fields on the suggestion form in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34319|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:49:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:49:28 +0000 Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/required fields on the suggestion form in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 --- Comment #17 from sandboxes at biblibre.com --- Created attachment 34324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34324&action=edit Bug 10848 - Allow configuration of mandatory/required fields on the suggestion form in OPAC #2/2 (part #2: new syspref 'OPACSuggestionMandatoryFields' + DB updates) Signed-off-by: Nick Clemens Signed-off-by: Val -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:49:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:49:32 +0000 Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/required fields on the suggestion form in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 --- Comment #18 from sandboxes at biblibre.com --- Created attachment 34325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34325&action=edit Bug 10848 - Allow configuration of mandatory/required fields on the suggestion form in OPAC #1/2 (part #1: changes in opac-suggestions.* script + bootstrap template) This patch: - adds a configuration option which allows to define which fields (apart from the title) should be mandatory for a patron purchase suggestion form in OPAC - impoves the method how required form fields are enforced, by utilising new HTML5 "required" attribute (old method would still be operational in old/legacy browsers which do not support "required" attribute properly). Allowed fields that are configurable as mandatory/not mandatory for suggestions made via OPAC are: author|copyrightdate|collectiontitle| isbn|publishercode|place|note|itemtype|patronreason. Note: this patch only applies to OPAC bootstrap theme. To test: 1/ Apply patch. 2/ Without 'OPACSuggestionMandatoryFields' option set, OPAC suggestion form should only require the title field. 3/ Set 'OPACSuggestionMandatoryFields' syspref to (e.g.) 'author|isbn|itemtype' 4/ Note that suggestion form in OPAC now requires 3 more fields to be entered and/or choosen (they should be labeled in red), and the user instruction changes slightly ("Form fields labeled in red are mandatory" ..). 5/ Try to submit some suggestions: for each field which is configured as mandatory, browser should enforce this field to be filled (in modern, HTML5 compilant browsers), or (as a fallback mechanism for legacy browsers) there should be an alert message displayed stating that some mandatory fields are missing. 6/ In both modern and legacy browsers, unless all mandatory fields are filled with something, form submission should not be possible. 7/ Repeat test 3-6 for all supported field names configurable as mandatory. If possible, "legacy" browser tests should ideally involve IE9 and (some older version of) Safari, which are rumored to have somehow questionable reputation regarding "required" HTML attribute support. Signed-off-by: Val -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:49:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:49:35 +0000 Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/required fields on the suggestion form in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 --- Comment #19 from sandboxes at biblibre.com --- Created attachment 34326 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34326&action=edit Bug 10848 [QA Followup] - Allow configuration of mandatory/required fields on the suggestion form in OPAC #2/2 QA follow-up for part #2: fixed OPACSuggestionMandatoryFields system preference description. Signed-off-by: Val -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:54:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:54:02 +0000 Subject: [Koha-bugs] [Bug 7728] subscription endddate is copied into subscription history histendate field during renew process In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- Olivier, what do you suggest? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:58:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:58:11 +0000 Subject: [Koha-bugs] [Bug 13398] Perl files for rotating collections are missing in debian package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13398 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 15:58:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 14:58:14 +0000 Subject: [Koha-bugs] [Bug 13398] Perl files for rotating collections are missing in debian package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13398 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 34327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34327&action=edit Bug 13398: rotating collections scripts are skipped on install This patch makes the Makefile.PL script pick the rotating_collections/ directory for install. To test: - Run: $ perl Makefile.PL - Install using either 'standard' or 'single' method. => FAIL: Verify that there is no 'rotating_collections' directory on the intranet CGI direcory. - Apply the patch - Run: $ perl Makefile.PL - Install using either 'standard' or 'single' method. => SUCCESS: Verify that there is a 'rotating_collections' directory on the intranet CGI direcory. - Sign off :-D Regards Tomas PS1: Note that it should be enough to check for the rotating_collections files on the generated Makefile after 'perl Makefile.PL'. PS2: The packages use the 'standard' install method to generate the file tree. So this patch should fix the packages too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 16:04:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 15:04:08 +0000 Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/required fields on the suggestion form in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 Bertrand changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |valerie.bertrand at univ-lyon3 | |.fr --- Comment #20 from Bertrand --- I followed the test plan, and changed the fields configuration as asked, both in IE 11 and Firefox 33.1. It works well. unfortunately I was not able ti test the patch on older browsers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 16:04:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 15:04:43 +0000 Subject: [Koha-bugs] [Bug 13142] Change "mobile phone" label back to "other phone" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13142 Courret changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |scourret at gmail.com --- Comment #10 from Courret --- CSV Export from DB displays phone (for primary phone), phonepro (for secondary phone) and mobile (for other phone) as column names. OPAC displays correctly the different phone number types. The patron can change his details using the OPAC. Unfortunately, these changes can't be validated by the librarians : click on "submit" in the update patron record page makes no changes in the DB (same issue on a 3.14). - OPAC "your personal details" (opac-memberentry.pl) -> OK - Submit changes to primary, secondary, and other phone via the OPAC. -> OK In the staff client, view the confirmation for those changes. -> Fail. Confirmation can be seen but no validation can be made. Tested on differents accounts. - Patron details in the staff client (moremember.pl) -> OK - Patron entry/edit in the staff client (memberentrygen.pl)-> OK - Patron duplicate confirmation in the staff client -> OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 16:12:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 15:12:29 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 JaTara Barnes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jendayi30 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 16:20:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 15:20:43 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #26 from Paola Rossi --- I've applied the patches [13369,13370,13371 6] against master 3.19.00.000 . Now vendors with no basket have been listed, as desired. At first, by default options [=Show active and inactive baskets | Show opened baskets only] : at a vendor without active basket 1 row has been attached: "No active basket" at a vendor without basket at all 1 row has been attached: "No active basket" by these options : Show active baskets only| Show opened baskets only : at a vendor without active basket 1 row has been attached: "No active basket" at a vendor without basket at all 1 row has been attached: "No basket" In "Showing 1 to X of X", X counted the rows [not only the real baskets, but even the "No basket" rows]. 1) 'Item count' and 'Biblio count' didn't yet work: "No matching records found" (even if some records matched my search). It happened using: FF 34.0.5, IE 11, GCh Version 39.0.2171.95 m [The installed version of : jquery.dataTables.columnFilter.js * Version: 1.5.0.] 2) > [...] the "created by" column should contain firstname + surname. So I've filtered by "firstname surname" values: ERROR: No matching records found Consequently, on certain names [i.e. surnames such as "de Roy", or firstnames such as "Maria Luisa"], filtering had the same error as above: ERROR. On the contrary, filtering by only a firstname, or filtering by only a surname, is OK. So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 16:27:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 15:27:18 +0000 Subject: [Koha-bugs] [Bug 9522] Koha returns <, >, etc in the record instead of <, >, etc when fulfilling a Z39.50 request In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9522 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #7 from Jonathan Druart --- (In reply to Fridolin SOMERS from comment #6) > But someone must confirm it works using DOM. I confirm it works. mysql> select title from biblio where biblionumber=42; => Une F?te monstre % yaz-client localhost:9998/biblios Connecting...OK. Sent initrequest. Connection accepted by v3 target. ID : 81 Name : Zebra Information Server/GFS/YAZ Version: 4.2.30 98864b44c654645bc16b2c54f822dc2e45a93031 Options: search present delSet triggerResourceCtrl scan sort extendedServices namedResultSets Elapsed: 0.001121 Z> format unimarc Z> f "Une fete monstre" Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 3, setno 1 SearchResult-1: term=Une cnt=760, term=fete cnt=29, term=monstre cnt=13 records returned: 0 Elapsed: 0.035910 Z> show Sent presentRequest (3+1). Records: 1 [biblios]Record type: Unimarc 00595nam a2200181 4500 001 142 010 $a 9879350061855 090 $a 42 100 $a 19960115 frey50 200 1 $a Une F?te monstre $f St?phanie Laslett $g ill. Nigel MacMullen $b LIVR [SKIP] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 16:28:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 15:28:13 +0000 Subject: [Koha-bugs] [Bug 9522] Koha returns <, >, etc in the record instead of <, >, etc when fulfilling a Z39.50 request In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9522 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #8 from Jonathan Druart --- Please reopen if I am wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 16:35:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 15:35:47 +0000 Subject: [Koha-bugs] [Bug 13053] Do not use template cache when from commandline In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13053 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux at biblibre.co | |m --- Comment #6 from Jonathan Druart --- *** Bug 10739 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 16:35:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 15:35:47 +0000 Subject: [Koha-bugs] [Bug 10739] Template caching produces software errors when using templates in batch mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10739 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart at biblibre.co | |m Resolution|--- |DUPLICATE --- Comment #1 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 13053 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 16:38:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 15:38:34 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 beroud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |isabelle.beroud at univ-lyon3. | |fr --- Comment #6 from beroud --- All fields used in this wizard correspond to a column in the suggestions table : it's ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 16:40:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 15:40:33 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 --- Comment #43 from Courret --- (In reply to Jonathan Druart from comment #42) > (In reply to Courret from comment #41) > > But it looks like I?m unable to extract a substring from a field (typically, > > UNIMARC language field from 100$a ? character 22-24). May someone test it ? > > Did you try something like > > [% fields.100.0.a.0.substr( 22, 3 ) %] > > ? It works ! Seems good. For me, as far as I have tested, every feature is OK and patch can be validated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 16:41:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 15:41:50 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Courret changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 16:43:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 15:43:23 +0000 Subject: [Koha-bugs] [Bug 11165] datecreated and datemodified column in auth_header In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11165 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- datecreated is set in C4::AuthoritiesMarc::AddAuthority: 694 my $sth=$dbh->prepare("insert into auth_header (authid,datecreated,authtypecode,marc,marcxml) values (?,now(),?,?,?)"); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 16:47:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 15:47:38 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #7 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Beroud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 16:47:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 15:47:53 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34124|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 16:47:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 15:47:57 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34136|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 16:48:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 15:48:23 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 --- Comment #8 from sandboxes at biblibre.com --- Created attachment 34328 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34328&action=edit Bug 13392: Add suggestions.ordereddate and suggestions.orderedby Those fields are updated when suggestion status is changed to 'ORDERED' and are displayed on suggestion/suggestion.pl page Signed-off-by: Beroud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 16:48:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 15:48:26 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 --- Comment #9 from sandboxes at biblibre.com --- Created attachment 34329 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34329&action=edit Bug 13392: New statistics assistant for suggestions New sub C4::Budgets::GetBudgetDescendantsIds (with unit tests) Signed-off-by: Beroud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 16:49:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 15:49:09 +0000 Subject: [Koha-bugs] [Bug 13441] New: Branchcodes should not be allowed to have spaces in them Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13441 Bug ID: 13441 Summary: Branchcodes should not be allowed to have spaces in them Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org In multiple cases I've seen issues arise in Koha where a librarian accidentally puts a space at the end of a new branchcode. This of course causes endless confusion because the branchcode looks perfectly fine in every case unless you wrap the code with some characters to reveal the hidden space! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 16:51:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 15:51:04 +0000 Subject: [Koha-bugs] [Bug 13442] New: Facet links broken when collection code limit is used Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 Bug ID: 13442 Summary: Facet links broken when collection code limit is used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Clicking on a collection code facet generates a broken URL. For example on the Bywater demo server http://intranet.bywatersolutions.com (username: bywater, password bywater) Step 1) Keyword search for 'Juggling': http://intranet.bywatersolutions.com/cgi-bin/koha/catalogue/search.pl?idx=kw&q=juggling&op=and&idx=kw&q=&op=and&idx=kw&q=&limit-yr=&limit=&limit=&limit=&limit=&limit=&limit=&multibranchlimit=&sort_by=relevance Step 2) Click on Author 'De Paola, Tomie' in record 5. "The clown of God : an old story" (Popular author, likely to have useful search facets). This takes us to http://intranet.bywatersolutions.com/cgi-bin/koha/catalogue/search.pl?q=au:%22De%20Paola,%20Tomie.%22 Step 3) Click facet for item type "Adult Office" => http://intranet.bywatersolutions.com/cgi-bin/koha/catalogue/search.pl?q=ccl=au%3A This is equivalent to http://intranet.bywatersolutions.com/cgi-bin/koha/catalogue/search.pl?q=ccl=au: Which obviously won't return any results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 16:54:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 15:54:12 +0000 Subject: [Koha-bugs] [Bug 11165] datecreated and datemodified column in auth_header In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11165 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 16:54:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 15:54:15 +0000 Subject: [Koha-bugs] [Bug 11165] datecreated and datemodified column in auth_header In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11165 --- Comment #2 from Jonathan Druart --- Created attachment 34330 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34330&action=edit Bug 11165: Automatically save the authority last modification time This patch rename the column auth_header.datemodified with modification_time. Now this column will be automatically updated when a row will be updated. Test plan: 0/ Verify that la major part of your auth_header.datemodified is set to null 1/ Execute the updatedb entry 2/ Verify that the column is renamed and the values is set to now (something better to suggest?) 3/ Update an authority and verify (using the sql cli) that this value has been updated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 16:55:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 15:55:08 +0000 Subject: [Koha-bugs] [Bug 11165] auth_header.datemodified should be updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11165 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m Summary|datecreated and |auth_header.datemodified |datemodified column in |should be updated |auth_header | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 17:54:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 16:54:35 +0000 Subject: [Koha-bugs] [Bug 13442] Facet links broken when collection code limit is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 --- Comment #1 from Kyle M Hall --- Created attachment 34331 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34331&action=edit Bug 13442 - Facet links broken when collection code limit is used Any search limits including a ccode will break the search facts. Test Plan: 1) Run an advanced search using a ccode limit 2) Try using any of the facet links of the left 3) Note they are broken 4) Apply this patch 5) Refresh the results 6) Note the facet links are no longer broken Note: I have not been able to reproduce this issue on my own test system, but have noted the problem on at least a dozen Koha servers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 17:54:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 16:54:33 +0000 Subject: [Koha-bugs] [Bug 13442] Facet links broken when collection code limit is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 17:54:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 16:54:44 +0000 Subject: [Koha-bugs] [Bug 13442] Facet links broken when collection code limit is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 17:56:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 16:56:34 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33953|0 |1 is obsolete| | --- Comment #96 from Kyle M Hall --- Created attachment 34332 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34332&action=edit Bug 7736 Edifact QUOTE, ORDER and INVOICE handling Handle Electronic Ordering via Edifact Messages This commits adds files to allow interfacing with book suppliers using Edifact Messages Currently this supports transferring files by ftp or sftp There is also an option to read/write to a local directory which may be useful for testing or other scenarios Quote messages are used to create baskets in Koha and will create the associated bib and item records if required If the user chooses to generate an edifact order from a basket an Edifact format message is created for submission If receiving an Invoice Message a corresponding invoice is created in Koha and the order is receipted Suppliers interfaces need to be properly configured to send the correct budget, item type etc info For more info on Edifact Formats see http://www.editeur.org/31/Library-Book-Supply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 18:01:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 17:01:21 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #97 from Brendan Gallagher --- Kyle updated the patch so it applies cleanly on master. I am testing this today and should have a signoff if it follows the plans. Testing going on ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 18:18:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 17:18:39 +0000 Subject: [Koha-bugs] [Bug 13443] New: DBD::mysql::db do failed: Table 'koha_library.roadtype' doesn't exist Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13443 Bug ID: 13443 Summary: DBD::mysql::db do failed: Table 'koha_library.roadtype' doesn't exist Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt at gmail.com Reporter: vimal0212 at gmail.com QA Contact: testopia at bugs.koha-community.org Dear Friends, I just tried to upgrade Koha 3.14 (old stable) to 3.16. I installed Koha from Ubuntu packages. I executed following three commands to upgrade Koha, sudo apt-get update sudo apt-get upgrade sudo apt-get install koha-common I got following error message at the end in terminal, DBD::mysql::db do failed: Table 'koha_library.roadtype' doesn't exist at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 7987. DBD::mysql::db do failed: Table 'koha_library.roadtype' doesn't exist at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 7987. dpkg: error processing koha-common (--configure): subprocess installed post-installation script returned error exit status 255 E: Sub-process /usr/bin/dpkg returned an error code (1) Up gradation process in web interface does not proceed and it repeat it again and again. How can I overcome this problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 18:57:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 17:57:48 +0000 Subject: [Koha-bugs] [Bug 12611] Localisation enchancement in installation procedure In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12611 Manos PETRIDIS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egpetridis at yahoo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 19:10:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 18:10:39 +0000 Subject: [Koha-bugs] [Bug 11460] Correction to default itemcallnumber system preference in UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11460 Manos PETRIDIS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egpetridis at yahoo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 19:11:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 18:11:45 +0000 Subject: [Koha-bugs] [Bug 9536] Make it still easier to add to the the list of possible encodings for Z39.50 servers. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9536 Manos PETRIDIS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egpetridis at yahoo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 19:18:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 18:18:38 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 --- Comment #2 from simith.doliveira at inlibro.com --- To test: Apply patch and update the database. Set up : On the item type administration page, default replacement price and a processing fee should be set up for on or more item types. When set up to 0, no processing fee will be charged to patrons for lost items. The "UseDefaultReplacementCost" system preference can be switched to ? Use ? or ? Don't use ?. If the lost item doesn't have a replacement cost catalogued, Koha will charge the default replacement cost. The "ProcessingFeeNote" system preference can be edited with the value to be used as a note alongside the processing fee when charged to the patron. The value will be displayed in the patron page fines tab. These tests apply when : * an item is manually marked as lost * an item is marked lost by the longoverdue.pl script Test scenario 1 : "UseDefaultReplacementCost" is set to ? Use ? and items.replacementcost = 0 * the item is manually marked lost 1. Set up the default replacement cost for a specific item type. 2. Set up the processing fee for this item type as well. 3. Search for an item of this item type and with no replacement cost. 4. Checkout the item to a patron. 5. Go to the item page. 6. Mark the item as lost. 7. Go to the patron page and open the fines tab. Check that : 8. there is a new entry for the item marked as lost. 9. the value match the default replacement cost for this item type. 10. there is another entry for the processing fee. 11. This entry should display the value from the ? ProcessingFeeNote ? system preference. Note : If you set up a processing fee to ? 0 ?, there should be no entry for the processing fee. * the item is marked lost by the longoverdue.pl script 1. Set up the default replacement cost for a specific item type. 2. Set up the processing fee for this item type as well. 3. Search for an item of this item type and with no replacement cost. 4. Checkout the item to a patron specifying a 30 days late due date. 5. Run the script longoverdue.pl (/misc/cronjobs/) ./longoverdue.pl --lost 30=2 --charge 2 --confirm (for example) 6. Go to the item page. Check that : 7. the item is marked as lost. 8. Go to the patron page and open the fine tab. Check that : 9. there is a new entry for the item marked as lost. 10. the value match the default replacement cost for this item type. 11. there is another entry for the processing fee. 12. This entry should display the value from the ? ProcessingFeeNote ? system preference. Note : If you set up a processing fee to ? 0 ?, there should be no entry for the processing fee. Test scenario 2 "UseDefaultReplacementCost" is set to ? Use ? and items.replacementcost > 0 * the item is manually marked lost 1. Set up the default replacement cost for a specific item type. 2. Set up the processing fee for this item type as well. 3. Search for an item of this item type and with a replacement cost. 4. Checkout the item to a patron. 5. Go to the item page. 6. Mark the item lost. 7. Go to the patron page and open the fine tab. Check that : 8. there is a new entry for the item marked as lost. 9. the value match the item replacement cost (it's Koha's default behaviour). 10. there is another entry for the processing fee.. This entry should display the value from the ? ProcessingFeeNote ? system preference. Note : If you set up a processing fee to ? 0 ?, there should be no entry for the processing fee. * the item is marked lost by the longoverdue.pl script 1. Set up the default replacement cost for a specific item type. 2. Set up the processing fee for this item type as well. 3. Search for an item of this item type and with a replacement cost. 4. Checkout the item to a patron specifying a 30 days late due date. 5. Run the script longoverdue.pl (/misc/cronjobs/) ./longoverdue.pl --lost 30=2 --charge 2 --confirm (for example) 6. Go to the item page Check that : 7. the item is marked as lost. 8. Go to the patron page and open the fine tab. Check that : 9. there is a new entry for the item marked as lost. 10 the value match the item replacement cost (it's Koha's default behaviour). 11. there is another entry for the processing fee. This entry should display the value from the ? ProcessingFeeNote ? system preference. Note : If you set up a processing fee to ? 0 ?, there should be no entry for the processing fee. Test scenario 3 : "UseDefaultReplacementCost" is set to ? Don't use ? Koha's default behaviour apply. It means : If items.replacementcost = 0 : The default replacement cost value for the item type will not be used. The processing fee (if greater than 0) will be charged. If items.replacement >0. The item replacement cost will be used. The processing fee (if greater than 0) will be charged. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 19:19:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 18:19:26 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 --- Comment #3 from simith.doliveira at inlibro.com --- Created attachment 34333 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34333&action=edit Bug 12768 - Replacement cost and processing fee management -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 19:20:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 18:20:34 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 19:31:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 18:31:59 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 --- Comment #6 from Jacek Ablewicz --- Ouch, after testing this on the production server for a little while I realized that fixing it in that way is not such a good idea after all :(, it has some unforseen side effects. Problem is that with Cache::FastMmap we are caching some things (like MARC frameworks) persistently and indefinitely: they never expire from the cache (like e.g. authorized values do, after 5 seconds AFAIRC). Cached MARC frameworks are only explicitly invalidated and updated to the new values after introducing some changes to them via web interface. So if there is separate copy of the cache file being used by command line scripts, MARC frameworks cached there would sadly never get updated. I dont know how to fix it properly.. perhaps setting 'unlink_on_exit' to 1 (and/or setting expire_time to something other then 0), when GATEWAY_INTERFACE environment variable is not defined, would be somehow acceptable solution (?). As a quick & dirty fix, 'chmod 666 /tmp/sharefile-koha-koha' seems to work as well, but that's probably not a very good idea :). Also, regarding multi-tenant servers: apparently setting up different namespaces for different tenants may still be much desired thing to do, regardless of this particular bug manifesting itself or not. This error only has a chance to immediately show itself in such setups where there is different UID being used for each tenant (I guess this is how things are set up by default in the packaged version ?). But in manually configured multi-instance servers, when there is a same UID in use on the WWW server side for different tenants - and they don't have their own separate namespaces defined properly yet - after the upgrade, there would be no error visible, but still more and more important per-instance Koha settings (frameworks, authorized values, ...) may possibly end up being unintentionally shared between 2+ tenants. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 19:32:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 18:32:20 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 19:42:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 18:42:53 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 --- Comment #7 from Martin Renvoize --- I had a horrible feeling something like that may be the case; but like you I'm unsure of a good solution at present. Setting a default MEMCACHED_NAMESPACE per instance at koha-create time I think would be fairly trivial (though I'de prefer that pref to be called CACHED_NAMESPACE as the MEMCACHED bit is misleading). It's running this through the update that I'm really baffled about.. there are similar issues with needing to update koha-conf.xml accross upgrades. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 20:07:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 19:07:24 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34333|0 |1 is obsolete| | --- Comment #4 from simith.doliveira at inlibro.com --- Created attachment 34334 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34334&action=edit Bug 12768 - Replacement cost and processing fee management -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 20:07:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 19:07:47 +0000 Subject: [Koha-bugs] [Bug 13444] New: OPACFallback has option 'Prog' Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13444 Bug ID: 13444 Summary: OPACFallback has option 'Prog' Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com In 3.18 I see 'Prog' as an option for OPACFallback. Prog has been removed, so that option does not make much sense. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 20:08:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 19:08:36 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34334|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 20:09:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 19:09:13 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34333|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 20:12:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 19:12:04 +0000 Subject: [Koha-bugs] [Bug 12769] Notice fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 --- Comment #3 from simith.doliveira at inlibro.com --- Created attachment 34335 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34335&action=edit Bug 12769 - Notice fee management -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 20:12:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 19:12:48 +0000 Subject: [Koha-bugs] [Bug 13444] OPACFallback has option 'Prog' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13444 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Version|3.18 |master Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 20:12:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 19:12:59 +0000 Subject: [Koha-bugs] [Bug 12769] Notice fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 --- Comment #4 from simith.doliveira at inlibro.com --- To Test: Apply patch and update the database. Set up : The "DefaultNoticeFee" system preference allows to set up how much a notice is charged to a patron when sent. The "NoticeFeeNote" systeme preference contains the value which will populate the note in the "accountlines" table when the notice fee is charged. On the "Slips and notices" page (see tools module), a new field allow librarian to set up a specific notice fee for each notice. If nothing is set up, the system preference value will be used. If set up to 0, no fee will be charged to the patron when the the notice is sent. For each test scenario below : 1. Checkout an item with a due date in the past to get the ODUE notice 2. Checkout an item due for today to get the DUE notice 3. Checkout an item due soon to get the PREDUE notice 4. Run overdue_notices.pl 5. Run advance_notices.pl 6. Go to the patron page and open the fine tab. Test scenario 1 : Set up : "Default notice fee" syspref = 0 "NoticeFeeNote" syspref = Notice fee ODUE notice fee = 50$ DUE notice fee = leave empty PREDUE notice fee = leave empty Check that : 7. There is a new 50$ entry (ODUE notice fee) 8. This entry note is "notice fee" Test scenario 2 : Set up : "Default notice fee" syspref = 0 "NoticeFeeNote" syspref = Notice fee ODUE notice fee = 50$ DUE notice fee = 20$ PREDUE notice fee = leave empty Check that : 7. There are two new entries, one is 50$ (ODUE notice fee), the other 20$ (DUE notice fee) 8. Both entries have "Notice fee" in their notes. Test scenario 3 : Set up : "Default notice fee" syspref = 50$ "NoticeFeeNote" syspref = Notice fee ODUE notice fee = leave empty DUE notice fee = leave empty PREDUE notice fee = leave empty Check that : 7. There are three 50$ entries (ODUE, DUE and PREDUE notice fees) 8. Each has a "Notice fee" note. Test scenario 4 : Set up : "Default notice fee" syspref = 50$ "NoticeFeeNote" syspref = Notice fee ODUE notice fee = 55$ DUE notice fee = 20$ PREDUE notice fee = leave empty Check that : 7. There are three entries : 55$ for the ODUE notice, 20$ for the DUE notice, 50$ for the PREDUE notice 8. Each has a "Notice fee" note. Test scenario 5 : Set up : "Default notice fee" syspref = 50$ "NoticeFeeNote" syspref = Notice fee ODUE notice fee = 55$ DUE notice fee = 20$ PREDUE notice fee = 0 Check that : 7. There are two entries : 55$ for the ODUE notice, 20$ for the DUE notice 8. Each has a "Notice fee" note. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 20:13:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 19:13:20 +0000 Subject: [Koha-bugs] [Bug 12769] Notice fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 20:16:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 19:16:23 +0000 Subject: [Koha-bugs] [Bug 12770] Notice template tool enhancement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12770 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12769 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 20:16:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 19:16:23 +0000 Subject: [Koha-bugs] [Bug 12769] Notice fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12770 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 20:32:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 19:32:51 +0000 Subject: [Koha-bugs] [Bug 12770] Notice template tool enhancement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12770 --- Comment #3 from simith.doliveira at inlibro.com --- Created attachment 34336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34336&action=edit Bug 12770 - Notice template tool enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 20:33:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 19:33:35 +0000 Subject: [Koha-bugs] [Bug 12770] Notice template tool enhancement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12770 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #4 from simith.doliveira at inlibro.com --- To test: This patch adds new tags for the notice template tool. They helps building invoices. The new tags are : and to display information from biblio, biblioitems, items and accountlines table. <> to display the notice fee (for future use. It's not usable before bug 12769 is pushed to master) <> to display the invoice total The invoice generated with these tags will take the patron item daily fees, either charged by the fines.pl script or by the librarian directly throught the fine tab. To test this : 1. Apply patch and update the database. 2. Add to the ODUE notice template (or any other late notice templates) this code (it's an example using html.)
TITLE AUTHOR BARCODE ITEMCALLNUMBER FINE
<> <> <> <> $
<><> + <>
Notice fee + <>
TOTAL = <>
3. Checkout items with a due dates in the past to get the ODUE notice and fines according to your set up 4. Run fines.pl 5. Run overdue_notices.pl 6. Run process_message_queue.pl Check that : 7. the overdue notice diplays the fines correctly. If you used the example, it should be a table with the title, author, barcode, itemcallnumber. For each late items with fines, you should have the fine descriptions, notes and amounts to cover. You also should see the total amount to pay. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 21:34:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 20:34:07 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #98 from Brendan Gallagher --- Everything works great. Questions for Colin or Martin - "EDIfact messages Manage EDIfact transmissions" That is found in the Tools section of koha. But I think you've moved that functionality into ACQ, so I think that can just be ignored and removed now. Answer that question for me and I'll sign-off. I think that a QA follow-up of just removing that from the Koha Tools and we are golden. Great Job. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 21:51:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 20:51:49 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 --- Comment #8 from Robin Sheat --- How about a default name space based on the uid and the database name if one isn't defined in koha-conf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 21:57:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 20:57:16 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 --- Comment #9 from Tom?s Cohen Arazi --- How about completely removing FastMmap as a cache backend? I guess for most of the cases mysql does a better job caching query results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 22:40:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 21:40:56 +0000 Subject: [Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 22:41:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 21:41:09 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 22:42:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 21:42:31 +0000 Subject: [Koha-bugs] [Bug 12971] Regression: Patron print summary doesn't show checkouts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12971 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #15 from Liz Rea --- Will we be pulling this fix back to 3.16? Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 22:47:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 21:47:43 +0000 Subject: [Koha-bugs] [Bug 13237] Regression: List of previous checkouts should be ordered by due date ascending In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13237 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 11 22:52:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Dec 2014 21:52:35 +0000 Subject: [Koha-bugs] [Bug 13103] No checkouts count on member details page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13103 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #5 from Liz Rea --- Hi, Will this be brought back into 3.16 as well? Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 01:09:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 00:09:14 +0000 Subject: [Koha-bugs] [Bug 13124] Record titles with parentheses causing label weirdness In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32566|0 |1 is obsolete| | --- Comment #13 from Nick Clemens --- Created attachment 34337 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34337&action=edit [SIGNED OFF] Bug 13124 - Record titles with parentheses causing label weirdness Test Plan ( using sample data included with Koha ) 1) Catalog a record and item with the title "Oh no! or, (How my science project destroyed the world) /" 2) Edit the DEFAULT template a) Set layout type to Biblio b) Set data fields to "title, author, isbn, issn, itemtype, barcode, itemcallnumber" c) Set font size to 10 3) Create a batch with just the one item you created 4) Export the PDF with the Avery template and the DEFAULT layout 5) Note the weirdness 6) Apply this patch 7) Re-export the PDF, note it's no longer weird ; ) Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 01:09:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 00:09:12 +0000 Subject: [Koha-bugs] [Bug 13124] Record titles with parentheses causing label weirdness In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 08:21:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 07:21:15 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 --- Comment #10 from Marc V?ron --- (In reply to Tom?s Cohen Arazi from comment #9) > How about completely removing FastMmap as a cache backend? I guess for most > of the cases mysql does a better job caching query results. +1 for less complexity -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 09:12:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 08:12:27 +0000 Subject: [Koha-bugs] [Bug 12451] circulation rule cant be edited if itemtype contains a space character In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12451 --- Comment #6 from Fridolin SOMERS --- Pushed to 3.14.x, will be in 3.14.12. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 09:50:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 08:50:56 +0000 Subject: [Koha-bugs] [Bug 12405] Search links on callnumber fails on intranet results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12405 --- Comment #9 from Fridolin SOMERS --- Pushed to 3.14.x, will be in 3.14.12. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 11:07:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 10:07:00 +0000 Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #26 from Martin Renvoize --- That last followup still needs a signoff.. not sure how I missed it when testing first time around. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 11:08:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 10:08:40 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 --- Comment #11 from Jacek Ablewicz --- (In reply to Tom?s Cohen Arazi from comment #9) > I guess for most of the cases mysql does a better job caching query results. It looks that way - fastmmap turns out to be not all that fast after all ;). I did some simple tests (fetching BKS framework with GetMarcStructure() 1000 times in the row): - not using Koha::Cache, mysql query cache enabled: 27 seconds - not using Koha::Cache, mysql query cache disabled: 39s - fastmmap_cache: 35s (!) - memory_cache: 10s However, such test case is pretty artificial - things may be different for syspref caching, authorized values caching, how would it behave on heavily loaded servers, what kind of impact from connection latencies we may expect if persistent caching is not in use and mysql is on the different machine (I guess quite a big impact regarding sysprefs and AVs fetching?) etc. On the other hand, I wonder how many people in the wild may be actually using CACHING_SYSTEM=fastmmap_cache (or are even aware of such possibility)? Interesting thing about fastmmap_cache is that it is currently never used by default nor as a fallback mechanism (at least not since Bug 12041). But it still gets loaded and initialized each and every time, causing possible "Permision denied ..." issues even on such setups which do not use fastmmap cache at all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 11:11:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 10:11:08 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 --- Comment #12 from Katrin Fischer --- I think that's one of hte main problems about this - even if you haven't enabled caching or don't intend to use it, it's still being used. And it relies on a parameter that seems unrelated to the itself MEMCACHED_NAMESPACE. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 11:12:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 10:12:35 +0000 Subject: [Koha-bugs] [Bug 13445] New: Scheduled Report, Type=URL fails Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13445 Bug ID: 13445 Summary: Scheduled Report, Type=URL fails Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org It seems when you select 'URL' as type when scheduling a report from the staff client, that the resulting email is blank. To test, 1) Navigate to: Home ? Reports ? Guided reports wizard ? Saved reports 2) Select for any saved report: Actions ? Schedule 3) Scheduled a report to run 'soon' 4) Select 'URL' as the 'Output format' 5) Enter your email address and wait for the resulting email The resulting email will be 'bodyless', i.e. empty -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 11:14:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 10:14:02 +0000 Subject: [Koha-bugs] [Bug 13445] Scheduled Report, Type=URL fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13445 --- Comment #1 from Martin Renvoize --- Looking at the runreports.pl script that this instantiates, it looks like the URL type handling was commented out some time ago. I'm not sure if this feature is ever used/likely to be used. Perhaps the solution is to just tidy up a bit.. remove the commented code in runreport.pl and drop the URL option in the staff client... thoughts? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 11:16:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 10:16:52 +0000 Subject: [Koha-bugs] [Bug 13446] New: Scheduled Reports lacks format options Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13446 Bug ID: 13446 Summary: Scheduled Reports lacks format options Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org The reprt scheduling tool in the staff client currently only allow formats of 'text' or 'URL'. Other formats are available from the command line, including HTML, CSV, TSV.. these should also be exposed in the scheduling tool from the staff client. To test, 1) Navigate to: Home ? Reports ? Guided reports wizard ? Saved reports 2) Select for any saved report: Actions ? Schedule 3) Open 'Output format' dropdown, only 'text' and 'URL' are available -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 11:20:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 10:20:57 +0000 Subject: [Koha-bugs] [Bug 13447] New: runreport.pl html email fails Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13447 Bug ID: 13447 Summary: runreport.pl html email fails Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org When running runreport.pl from the command line with the following valid options the resulting email contains an empty body. perl /usr/share/koha/bin/cronjobs/runreport.pl --format=html --to='me at myemail.com' 58 The above command is taken from a test on a package based install and run under koha-shell for the instance. However, I have also tested with a dev type install and obtained the same result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 12:09:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 11:09:22 +0000 Subject: [Koha-bugs] [Bug 9768] Problem with grace period calculation and fine intervals >1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9768 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 12:39:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 11:39:51 +0000 Subject: [Koha-bugs] [Bug 13447] runreport.pl html email fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13447 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 12:39:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 11:39:58 +0000 Subject: [Koha-bugs] [Bug 13446] Scheduled Reports lacks format options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13446 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 12:41:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 11:41:34 +0000 Subject: [Koha-bugs] [Bug 3935] Schedule tasks periodically In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3935 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #1 from Martin Renvoize --- This is still true right? I certainly can't see any way to schedule recurring tasks via the staff client yet... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 13:23:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 12:23:03 +0000 Subject: [Koha-bugs] [Bug 13447] runreport.pl html email fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13447 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 13:23:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 12:23:05 +0000 Subject: [Koha-bugs] [Bug 13447] runreport.pl html email fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13447 --- Comment #1 from Martin Renvoize --- Created attachment 34338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34338&action=edit BUG 13447: Fixed HTML Email Reports A tiny typo made in runreport.pl when updating it for bug 9530 lead to no body being attached to html emails. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 13:25:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 12:25:28 +0000 Subject: [Koha-bugs] [Bug 13447] runreport.pl html email fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13447 --- Comment #2 from Martin Renvoize --- I feel bad, as I missed this when QAing Bug 9530 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 13:54:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 12:54:36 +0000 Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #2 from Paul Poulain --- Jonathan: can you add a "Sponsored-by: Mines Paristech" in the patch ? thus, MPT will appear in the credits -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 13:56:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 12:56:52 +0000 Subject: [Koha-bugs] [Bug 13428] Fix facet deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13428 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 13:56:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 12:56:54 +0000 Subject: [Koha-bugs] [Bug 13428] Fix facet deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13428 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34313|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 34339 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34339&action=edit [PASSED QA] Bug 13428: Fix regression on deleting facets Test plan: Search for something click on a facet with diacritic click on another facet remove the facet with diacritic Signed-off-by: Mason James Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 13:57:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 12:57:49 +0000 Subject: [Koha-bugs] [Bug 13422] SCO: "Would you like to print a receipt" not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13422 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 13:57:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 12:57:51 +0000 Subject: [Koha-bugs] [Bug 13422] SCO: "Would you like to print a receipt" not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13422 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34277|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 34340 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34340&action=edit [PASSED QA] Bug 13422 - SCO: "Would you like to rpint a receipt" not translatable To test: Set syspref SelfCheckReceiptPrompt to "Show" Select non English language Go to Self Checkout and check out an item Hit "Finish" Make sure that confirm dialog "Would you like to print a receipt" still appears Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 14:04:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 13:04:34 +0000 Subject: [Koha-bugs] [Bug 13415] Prevent librarians from scanning multiple items into a single barcode field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13415 --- Comment #6 from Kyle M Hall --- I agree, I think I was a bit too aggressive. There is really no need to prevent a barcode from being scanned before the page loads completely. I'll also change the bind to on, as you are correct about that as well. (In reply to Owen Leonard from comment #5) > - [% IF NEEDSCONFIRMATION %] > > - [% ELSE %] > - size="14" /> > - [% END %] > > This change means that all circulation transactions must wait until > document.ready() fires. Is this what we want? > > + $('#mainform').bind('submit',function() { > + $('#barcode').on('keypress',function(event) { > > Is there a reason to use bind() on #mainform instead of on()? "As of jQuery > 1.7, the .on() method is the preferred method for attaching event handlers > to a document." https://api.jquery.com/bind/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 14:07:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 13:07:03 +0000 Subject: [Koha-bugs] [Bug 13415] Prevent librarians from scanning multiple items into a single barcode field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13415 --- Comment #7 from Kyle M Hall --- Created attachment 34341 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34341&action=edit Bug 13415 [QA Followup] - Change bind to on, revert barcode disable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 14:07:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 13:07:13 +0000 Subject: [Koha-bugs] [Bug 13448] New: runreport.pl html email striping Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13448 Bug ID: 13448 Summary: runreport.pl html email striping Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: fridolyn.somers at biblibre.com, gmcharlt at gmail.com, kyle at bywatersolutions.com, liz at catalyst.net.nz, m.de.rooy at rijksmuseum.nl, martin.renvoize at ptfs-europe.com, vanoudt at gmail.com Depends on: 10777 As of Bug 10777 Galen added css to zebra stripe html emailed reports; unfortunately this was implemented in a way incompatible with both gmail and hotmail on-line email clients This is reasonably easily solved by in-lining the styles as opposed to adding them to the page head. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 14:07:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 13:07:13 +0000 Subject: [Koha-bugs] [Bug 10777] runreport.pl allows for sending html reports via email, but mimetype is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10777 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13448 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 14:12:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 13:12:49 +0000 Subject: [Koha-bugs] [Bug 13448] runreport.pl html email striping In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13448 --- Comment #1 from Martin Renvoize --- Created attachment 34342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34342&action=edit Bug 13448: Make Striping gmail/hotmail compatible This patch inlines the css to stripe a html output report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 14:13:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 13:13:45 +0000 Subject: [Koha-bugs] [Bug 13448] runreport.pl html email striping In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13448 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|10777 |13447 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 14:13:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 13:13:45 +0000 Subject: [Koha-bugs] [Bug 10777] runreport.pl allows for sending html reports via email, but mimetype is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10777 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13448 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 14:13:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 13:13:45 +0000 Subject: [Koha-bugs] [Bug 13447] runreport.pl html email fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13447 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13448 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 14:13:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 13:13:58 +0000 Subject: [Koha-bugs] [Bug 13448] runreport.pl html email striping In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13448 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 15:02:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 14:02:19 +0000 Subject: [Koha-bugs] [Bug 13410] Untranslatable "Change messaging preferences to default for this category?" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13410 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 15:02:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 14:02:21 +0000 Subject: [Koha-bugs] [Bug 13410] Untranslatable "Change messaging preferences to default for this category?" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13410 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34276|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 34343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34343&action=edit [PASSED QA] Bug 13410 - Untranslatable "Change messaging preferences to default for this category?" To test: In staff client, go to Home > Patrons Click button "New patron" and choose a category Change Patron messaging preferences Now change Category Make sure that following message box still appears: "Change messaging preferences to default for this category?" Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 15:02:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 14:02:34 +0000 Subject: [Koha-bugs] [Bug 13410] Untranslatable "Change messaging preferences to default for this category?" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13410 --- Comment #4 from Kyle M Hall --- Created attachment 34344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34344&action=edit Bug 13410 [QA Followup] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 15:09:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 14:09:02 +0000 Subject: [Koha-bugs] [Bug 13401] sort branches alphabetically in admin/authorised_values.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13401 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 15:09:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 14:09:04 +0000 Subject: [Koha-bugs] [Bug 13401] sort branches alphabetically in admin/authorised_values.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13401 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34164|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 34345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34345&action=edit [PASSED QA] Bug 13401 - sort branches alphabetically in admin/authorised_values.pl This patch adds a sort of branches alphabetically by name in authorised values administration, like in many other pages. Also replaces var $branch (too ambigus) by $branchcode. Test plan : - Create 2 branches : code=AAA,name=Zbranch and code=ZZZ,name=Abranch - Create a new authorized value : admin/authorised_values.pl - Look at "Libraries limitation" : => Without patch branches are sorted by code : Zbranch then Abranch => Without patch branches are sorted by name : Abranch then Zbranch - Select a branch and save - Re-edit => Check the same branch is selected Followed test plan. Patch behaves as expected. Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 15:11:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 14:11:38 +0000 Subject: [Koha-bugs] [Bug 13400] Untranslatable "Are you sure you want to delete this authority?" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13400 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 15:11:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 14:11:40 +0000 Subject: [Koha-bugs] [Bug 13400] Untranslatable "Are you sure you want to delete this authority?" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13400 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34278|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 34346 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34346&action=edit [PASSED QA] Bug 13400 - Untranslatable "Are you sure you want to delete this authority?" This patch makes the string "Are you sure you want to delete this authority?" translatable using the function _(...) To test, apply patch and check that deleting authorities still works. Signed-off-by: Owen Leonard Tested successfully with the following procedure: 1. Applied the patch. 2. Ran perl translate update de-DE 3. Edited de-DE-i-staff-t-prog-v-3006000.po to add a "translation" 4. Removed "#, fuzzy" marker from po entry. 5. perl translate -v install de-DE 6. Testing deleting an authority from the authority search results page and from the detail page. My translated string appeared correctly. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 15:13:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 14:13:29 +0000 Subject: [Koha-bugs] [Bug 13400] Untranslatable "Are you sure you want to delete this authority?" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13400 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34346|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 34347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34347&action=edit [PASSED QA] Bug 13400 - Untranslatable "Are you sure you want to delete this authority?" This patch makes the string "Are you sure you want to delete this authority?" translatable using the function _(...) To test, apply patch and check that deleting authorities still works. Signed-off-by: Owen Leonard Tested successfully with the following procedure: 1. Applied the patch. 2. Ran perl translate update de-DE 3. Edited de-DE-i-staff-t-prog-v-3006000.po to add a "translation" 4. Removed "#, fuzzy" marker from po entry. 5. perl translate -v install de-DE 6. Testing deleting an authority from the authority search results page and from the detail page. My translated string appeared correctly. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 15:13:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 14:13:35 +0000 Subject: [Koha-bugs] [Bug 13400] Untranslatable "Are you sure you want to delete this authority?" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13400 --- Comment #7 from Kyle M Hall --- Created attachment 34348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34348&action=edit [PASSED QA] Bug 13400 [QA Followup] - Fix tabs and quotes Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 15:22:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 14:22:04 +0000 Subject: [Koha-bugs] [Bug 13349] Allow library code to display against users pending changes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13349 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 15:22:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 14:22:06 +0000 Subject: [Koha-bugs] [Bug 13349] Allow library code to display against users pending changes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13349 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34162|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 34349 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34349&action=edit [PASSED QA] Bug 13349 - Allow library code to display against users pending changes -update screen http://bugs.koha-community.org/show_bug.cgi?id=13349 To test: Ensure OPACPatronDetails is set to enabled Apply the patch Log into the OPAC and update your patron details (address, phone number etc) Log into the staff client and view pending patron changes. The branchcode of the library to which the patron belongs should display next to the user's name. Followed test plan, works as expected Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 15:22:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 14:22:14 +0000 Subject: [Koha-bugs] [Bug 13349] Allow library code to display against users pending changes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13349 --- Comment #9 from Kyle M Hall --- Created attachment 34350 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34350&action=edit [PASSED QA] Bug 13349 [QA Followup] I don't think we need the library label. Also switched to displaying the library name, rather than just the branchcode. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 15:31:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 14:31:21 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #10 from Marc V?ron --- Created attachment 34351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34351&action=edit Rebased on current master for testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 15:36:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 14:36:15 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31320|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 15:40:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 14:40:55 +0000 Subject: [Koha-bugs] [Bug 13372] Items lost report improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13372 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall --- Small problem. When you choose the order by field, it's not used in the datatable. The data is sorted correctly ( via perl/sql ), but it should be sorted by the datatable instead. Because of this, the table sort arrow is not set correctly and the first resort takes two clicks instead of one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 15:46:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 14:46:13 +0000 Subject: [Koha-bugs] [Bug 12973] Allow passing code to XSLT_Handler instead of filename In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12973 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 15:46:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 14:46:15 +0000 Subject: [Koha-bugs] [Bug 12973] Allow passing code to XSLT_Handler instead of filename In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12973 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33553|0 |1 is obsolete| | Attachment #33554|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 34352 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34352&action=edit [PASSED QA] Bug 12973: Allow passing code to XSLT_Handler instead of filename This patch adds the option to pass a code string to the XSLT handler object instead of passing a filename. This is achieved by a change to parameter hashref. The old style parameters are also allowed. Note that this patch should not change behavior but will be used in future development: see bug 12758 or bug 12754. Test plan: Verify that behavior did not change in the following steps. [1] Edit OPACXSLTResultsDisplay in order to use XSLT. [2] Check search results page in OPAC. [3] Edit OPACXSLTDetailsDisplay in order to use XSLT. [4] Check detail page in OPAC. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 15:46:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 14:46:40 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #11 from Marc V?ron --- Main contact select box displays as expected in borrower modification and the value is written to database. However I found following issue: Edit syspref BorrowerUnwantedField and hide e.g. phonepro (= Secondary phone) Result: Secondary phone can still be selected as Main contact. Expected Result: Secondary phone (or other unwanted fields) should be hidden in select box as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 15:51:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 14:51:58 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #52 from Kyle M Hall --- I agree with Jonathan. This has been discussed in great detail. This *has* been a team effort with much input from Jonathan and Martin. This is also the third iteration of this idea that I've proposed. It would be great if we could get input from every single person, but there will always be opposing opinions on how things should be done. At this point, I ( and probably others ) just want something, anything, we can get and use. This does not by any means prevent us from making improvements in the future! But we need to start somewhere. (In reply to David Cook from comment #51) > (In reply to Jonathan Druart from comment #50) > > I personally don't want to discuss this implementation for the following > > reasons: > > 1/ We already have discussed (or at least tried) for years. > > 2/ We already have different proposals (At least from Kyle, Yohann and me). > > 3/ This code is functional and we will able to improve it according to our > > further needs. > > 4/ Everybody knows that putting a bug report to the 'in discussion' status > > without any other actions (mail on mailing list, discussion on #koha, etc) > > don't permit to move it forward. > > > > I strongly believe that the next step is to get the RM point of view. > > > > You can provide a patch on another report to improve the code and show us > > what could be better, that would be great :) > > Fair enough. Maybe the next step is to get the RM point of view. > > While I do have ideas for what I think would be better code and a better > proposal, I think it would need to be a more concerted team effort > (admittedly, that has historically been extraordinarily difficult to > achieve). As for individual work, I'm not willing to dedicate the time in my > personal life at the moment, and I don't have the time to do it > professionally, so I suppose it's not fair for me to be too critical if I > can't provide any work myself. > > Feel free to switch it back to Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 15:53:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 14:53:26 +0000 Subject: [Koha-bugs] [Bug 12973] Allow passing code to XSLT_Handler instead of filename In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12973 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34352|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 34353 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34353&action=edit [PASSED QA] Bug 12973: Allow passing code to XSLT_Handler instead of filename This patch adds the option to pass a code string to the XSLT handler object instead of passing a filename. This is achieved by a change to parameter hashref. The old style parameters are also allowed. Note that this patch should not change behavior but will be used in future development: see bug 12758 or bug 12754. Test plan: Verify that behavior did not change in the following steps. [1] Edit OPACXSLTResultsDisplay in order to use XSLT. [2] Check search results page in OPAC. [3] Edit OPACXSLTDetailsDisplay in order to use XSLT. [4] Check detail page in OPAC. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 15:53:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 14:53:33 +0000 Subject: [Koha-bugs] [Bug 12973] Allow passing code to XSLT_Handler instead of filename In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12973 --- Comment #8 from Kyle M Hall --- Created attachment 34354 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34354&action=edit [PASSED QA] Bug 12973: Additional unit tests for XSLT_Handler.t The additional way of parameter passing is tested in three additional tests. Test plan: Verify if XSLT_Handler.t passes. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 15:54:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 14:54:44 +0000 Subject: [Koha-bugs] [Bug 12895] Dropbox mode doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12895 --- Comment #8 from Koha Team Lyon 3 --- NEW TEST PLAN again (hope that will be the good one) : 1)Check in the calendar (Tools/Calendar), that the previous days you are about to use as date due are realy entered as opening day (never know). 2) Add a suspension in the suspension days parameter of the circulation rules (Administration/Circulation and fine rules) to the MOST specific category of borrower and MOST specific type of document among the existing rules of the LOGGED IN Site(cf explications in the circ-rules page). 3) Choose a borrower using the search by category and an item through the advanced search using the limit by type. 4) Checkout the item selecting the previous opening date in the Specify-due-date box. 5) Click on Circulation in the upper menu, then on Checkin and check the Book drop mode. The Book drop date showed should be the previous opening date. 6) Check in the item : you can see that the patron is restricted 7) apply the patch 8) Redo 1 to 5 : Now, you can see that the patron is not restricted. 9) If you redo the test with two day late, you will see that the patron is not restricted : that's ok because his restriction of one day is already finished. 10) If you redo the test with more than two day late, you see that the patron restriction is, as expected, one day shorter than it were if the item had been returned without dropbox mode. Olivier Crouzet -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 16:06:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 15:06:43 +0000 Subject: [Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31719|0 |1 is obsolete| | --- Comment #42 from M. Tompsett --- Created attachment 34355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34355&action=edit Bug 10900 - Incorrect calling conventions accessing C4::Context There were multiple calling conventions for C4::Context's set_userenv routine. So the following commands were used to find discrepancies: grep "::set_userenv" `find .` grep "\->set_userenv" `find .` The first grep demonstrated that the smaller change is from :: to -> as only C4/Auth.pm, installer/InstallAuth.pm, and t/db_dependent/Circulation.t would need to be modified. This patch corrects C4::Context's set_userenv routine to be object call based (use ->) by using a shift to ignore the first parameter, and modify the three files found with :: calls. As the result of trying to roll a distribution, t/Circulation_barcodedecode.t was discovered to be faulty. The cause being incorrect parameters! This was hidden when there was no shift in the set_userenv routine. However, with its correction, the test broke. This led me to read the POD documentation for the function set_userenv in C4::Context and realize it was outdated as well. It has been revised to match the current version of the function. Then intentionally bad parameters passed to the set_userenv routine in C4::Context were hunted down. The biggest problems were missing surnames or branch names. Rebase required because of shibboleth change in C4/Context.pm Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 16:06:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 15:06:50 +0000 Subject: [Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31720|0 |1 is obsolete| | --- Comment #43 from M. Tompsett --- Created attachment 34356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34356&action=edit Bug 10900 - Follow up, since more has been added to master Booksellers.t and Koha_template_plugin_Branches.t both had function calls to ::set_userenv added to them. This patch handles those additions. TEST PLAN --------- 1) Branch a new git branch 2) prove -v t/db_dependent/Bookseller.t -- It should work. 3) prove -v t/db_dependent/Koha_template_plugin_Branches.t -- It should work. 4) Apply only the first patch. 5) Repeat steps 2 and 3. -- They should both FAIL! 6) Apply the second patch as well. 7) Repeat steps 2 and 3. -- The should both work. Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 16:06:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 15:06:57 +0000 Subject: [Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31721|0 |1 is obsolete| | --- Comment #44 from M. Tompsett --- Created attachment 34357 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34357&action=edit Bug 10900: 2 occurrences more Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 16:09:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 15:09:23 +0000 Subject: [Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 --- Comment #45 from M. Tompsett --- Because of the new shibboleth parameter to set_userenv in C4::Context, a rebase was required. There should be no other visible changes between the last two versions of " Bug 10900 - Incorrect calling conventions accessing C4::Context". Leaving as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 16:15:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 15:15:57 +0000 Subject: [Koha-bugs] [Bug 13449] New: Syndetics TOC will not display in some cases Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13449 Bug ID: 13449 Summary: Syndetics TOC will not display in some cases Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org For reasons unknown, the table of contents data from Syndetics will not display if there is no p element, even though within that if for the p element there's a second one for the p element! This is neither good nor necessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 16:17:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 15:17:06 +0000 Subject: [Koha-bugs] [Bug 13449] Syndetics TOC will not display in some cases In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13449 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 16:17:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 15:17:09 +0000 Subject: [Koha-bugs] [Bug 13449] Syndetics TOC will not display in some cases In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13449 --- Comment #1 from Kyle M Hall --- Created attachment 34358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34358&action=edit Bug 13449 - Syndetics TOC will not display in some cases For reasons unknown, the table of contents data from Syndetics will not display if there is no p element, even though within that if for the p element there's a second one for the p element! This is neither good nor necessary. Test Plan: 1) Enable Syndetics 2) Find a record that should have a Syndetics TOC but doesn't 3) Apply this patch 4) Reload the page 5) Note the Syndetics TOC data now displays -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 16:17:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 15:17:18 +0000 Subject: [Koha-bugs] [Bug 13449] Syndetics TOC will not display in some cases In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13449 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |kyle at bywatersolutions.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 16:19:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 15:19:16 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #7 from Koha Team Lyon 3 --- I try to test theses patchs on biblibre sandbox n? 17 (wich has been frozen with these patchs, among others). I've done several tests with 4 vendors (with discount): 1. configured with List prices don't include tax / Invoice prices don't include tax (0 - 0) 2. configured with List prices don't include tax / Invoice prices include tax (0 - 1) 3. configured with List prices include tax / Invoice prices don't include tax (1 - 0) 4. configured with List prices include tax / Invoice prices include tax (1 - 1) For each vendor, I try receipt without any change, partial receipt, receipt with change of price, receipt with change of GST, receipt after a transfer from another vendor, with price needing some round calculation. In all the case (calculation in the basket, print of the basket group, export CSV of the basket group, receipt and invoice), the fair prices are calculated, consistently with the setting of the tax in the vendor page. Except in one case : the CSV export of a basket group after a transfer of an order from a vendor where list prices don't include tax forward a vendor where List prices include tax. Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 16:53:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 15:53:37 +0000 Subject: [Koha-bugs] [Bug 13450] New: Title and breadcrumb of Patron form can look weird in translations Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Bug ID: 13450 Summary: Title and breadcrumb of Patron form can look weird in translations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Example: English: Modify Kind patron Hansli Meier Modify Erwachsener patron Henry Acevedo German: ?ndern Kind Benutzer Hansli Meier ?ndern Erwachsener Benutzer Henry Acevedo It should be something like English: Modify patron Hansli Meier (Kind) Modify patron Henry Acevedo (Erwachsener) ?ndern Benutzer Hansli Meier (Kind) ?ndern Benutzer Henry Acevedo (Erwachsener) Note: (Kind) and (Erwachsener) are set as Category name in Patron category administration. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 17:30:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 16:30:15 +0000 Subject: [Koha-bugs] [Bug 13451] New: Holidays.t assumes default data Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13451 Bug ID: 13451 Summary: Holidays.t assumes default data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: mtompset at hotmail.com QA Contact: gmcharlt at gmail.com With rollback and non-commit capabilities, we should be able to have prove t/db_dependent/Holidays.t pass without having loaded default data! This will fix that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 17:30:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 16:30:32 +0000 Subject: [Koha-bugs] [Bug 13451] Holidays.t assumes default data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13451 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 17:30:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 16:30:41 +0000 Subject: [Koha-bugs] [Bug 13451] Holidays.t assumes default data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13451 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 17:40:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 16:40:51 +0000 Subject: [Koha-bugs] [Bug 13452] New: Average checkout report always uses biblioitems.itemtype Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 Bug ID: 13452 Summary: Average checkout report always uses biblioitems.itemtype Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org The average checkout report reports/issues_avg_stats.pl always uses biblioitems.itemtype, regardless to item-level_itypes system preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 17:56:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 16:56:20 +0000 Subject: [Koha-bugs] [Bug 13451] Holidays.t assumes default data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13451 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 17:56:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 16:56:22 +0000 Subject: [Koha-bugs] [Bug 13451] Holidays.t assumes default data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13451 --- Comment #1 from M. Tompsett --- Created attachment 34359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34359&action=edit Bug 13451: Holidays.t assumes default data This patch removes that assumption by expressly setting data to be default. TEST PLAN --------- 1) Ensure that branch code is NOT 'MPL' in the repeatable_holidays table in your database. 2) Ensure that branch codes 'MPL' and 'CPL' do not exist in the branches table in your database. 3) prove t/db_dependent/Holidays.t -- this should bomb horribly. 4) Apply patch 5) prove t/db_dependent/Holidays.t -- all tests should succeed. 6) run koha qa tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 18:20:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 17:20:10 +0000 Subject: [Koha-bugs] [Bug 13453] New: Koha.t daily quote tests assume sample data Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13453 Bug ID: 13453 Summary: Koha.t daily quote tests assume sample data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: mtompset at hotmail.com QA Contact: gmcharlt at gmail.com This assumes that id 3 will be Abraham Lincoln. If you haven't loaded the sample data prove t/db_dependent/Koha.t failed on the daily quote tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 18:21:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 17:21:12 +0000 Subject: [Koha-bugs] [Bug 13453] Koha.t daily quote tests assume sample data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13453 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |mtompset at hotmail.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 18:31:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 17:31:10 +0000 Subject: [Koha-bugs] [Bug 13453] Koha.t daily quote tests assume sample data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13453 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 18:31:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 17:31:12 +0000 Subject: [Koha-bugs] [Bug 13453] Koha.t daily quote tests assume sample data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13453 --- Comment #1 from M. Tompsett --- Created attachment 34360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34360&action=edit Bug 13453: Koha.t daily quote tests assume sample data By adding quotes 3 and 25 from the sample data, this test can pass without having the sample quote data loaded. TEST PLAN --------- 1) Ensure there is no quote id=3 or that it is NOT Abraham Lincoln. 2) prove t/db_dependent/Koha.t -- this should fail the daily quote test. 3) apply patch 4) prove t/db_dependent/Koha.t -- this should fail the daily quote test. 5) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 18:55:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 17:55:21 +0000 Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33501|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 34361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34361&action=edit Bug 13023 - Nonpublic note for items should be mapped to a database column like itemnotes An item's public notes are mapped to a db column, but the librarian only notes are not. We need to map these so in the future we may display them in places other than the editor. Test Plan: 1) Create an item with a non-public note 2) Apply this patch 3) Run updatedatabase 4) Update your frameworks to map your nonpublic item note to items.itemnotes_nonpublic 5) Run misc/batchRebuildItemsTables.pl 6) Inspect the database, note that your non-public note is now in items.itemnotes_nonpublic Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 19:12:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 18:12:40 +0000 Subject: [Koha-bugs] [Bug 13449] Syndetics TOC will not display in some cases In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13449 Julius changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |julius.fleschner at briarcliff | |.edu --- Comment #2 from Julius --- This patch has been applied and tested on our instance of Koha. Marked as signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 20:10:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 19:10:40 +0000 Subject: [Koha-bugs] [Bug 13307] Create a link to the last advanced search in search result page (OPAC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 --- Comment #10 from simith.doliveira at inlibro.com --- Created attachment 34362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34362&action=edit Fix jquery.deseriable.min.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 20:10:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 19:10:54 +0000 Subject: [Koha-bugs] [Bug 13307] Create a link to the last advanced search in search result page (OPAC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34362|0 |1 is obsolete| | --- Comment #11 from simith.doliveira at inlibro.com --- Created attachment 34363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34363&action=edit Fix jquery.deseriable.min.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 20:13:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 19:13:42 +0000 Subject: [Koha-bugs] [Bug 12905] Deleting parent fund will orphan child funds, leaving them un-editable. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12905 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34133|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 34364 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34364&action=edit [PASSED QA] Bug 12905: funds with children could not be deleted The interface should prevent to delete funds with children. Otherwise the relationship is broken and problems occur: 1/ You don't see the orphan fund in the fund list 2/ You cannot edit the orphan fund amount ('Fund amount exceeds parent allocation'). This patch: - adds a JS check, template side - adds a check in the perl script (should never be true) - adds an updatedatabase check, in order to alert users with inconsistent data. Test plan: Verify you are not allow to delete a fund with children. Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 20:13:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 19:13:40 +0000 Subject: [Koha-bugs] [Bug 12905] Deleting parent fund will orphan child funds, leaving them un-editable. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12905 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 20:14:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 19:14:48 +0000 Subject: [Koha-bugs] [Bug 13449] Syndetics TOC will not display in some cases In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13449 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34358|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 34365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34365&action=edit Bug 13449 - Syndetics TOC will not display in some cases For reasons unknown, the table of contents data from Syndetics will not display if there is no p element, even though within that if for the p element there's a second one for the p element! This is neither good nor necessary. Test Plan: 1) Enable Syndetics 2) Find a record that should have a Syndetics TOC but doesn't 3) Apply this patch 4) Reload the page 5) Note the Syndetics TOC data now displays Signed-off-by: Julius Fleschner -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 20:19:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 19:19:56 +0000 Subject: [Koha-bugs] [Bug 13307] Create a link to the last advanced search in search result page (OPAC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 --- Comment #12 from simith.doliveira at inlibro.com --- Error comment 9 fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 20:22:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 19:22:38 +0000 Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 --- Comment #35 from Chris Nighswonger --- For all interested parties, the fix for this has been applied in Library::Callnumber::LC. Hopefully the new release will be showing up on CPAN in the little bit and in a deb repo near you soon. Upgrading to version 0.23 should fix the symptoms noted in this bug. Many thanks to Dan Wells for rolling up a new release with this fix in it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 20:56:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 19:56:28 +0000 Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 20:56:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 19:56:30 +0000 Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34361|0 |1 is obsolete| | --- Comment #15 from Brendan Gallagher --- Created attachment 34366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34366&action=edit Bug 13023 - Nonpublic note for items should be mapped to a database column like itemnotes An item's public notes are mapped to a db column, but the librarian only notes are not. We need to map these so in the future we may display them in places other than the editor. Test Plan: 1) Create an item with a non-public note 2) Apply this patch 3) Run updatedatabase 4) Update your frameworks to map your nonpublic item note to items.itemnotes_nonpublic 5) Run misc/batchRebuildItemsTables.pl 6) Inspect the database, note that your non-public note is now in items.itemnotes_nonpublic Signed-off-by: Paola Rossi Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 20:58:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 19:58:01 +0000 Subject: [Koha-bugs] [Bug 13378] There is no way to search suggestions not linked to a fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13378 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 20:58:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 19:58:03 +0000 Subject: [Koha-bugs] [Bug 13378] There is no way to search suggestions not linked to a fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13378 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34169|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 34367 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34367&action=edit [PASSED QA] Bug 13378: Add a filter to search suggestions not linked to a fund This patch adds a "None" option for the fund filter. Test plan: 1/ Go on the suggestion search page 2/ Search suggestions not linked to a fund using the "None" option. 3/ Search all suggestions (linked or not to a fund) using the "Any" option. Works as expected. Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 21:00:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 20:00:20 +0000 Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #16 from Katrin Fischer --- I think we still need the framework changes here - or the problem will not be fully solved - we should fix the new installations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 21:01:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 20:01:31 +0000 Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m --- Comment #17 from Brendan Gallagher --- So this one has been sitting there for 1 months time. I've done some full out testing and I am passing this. Since this was done by Kyle I would encourage another QA to look at this too, if you have the time. Release manager if you feel that this must have another QA, let me know and I'll see who I can bug. This is pretty solid though and I think it would be ok to push. I leave that up to you all - and will acceptable whatever is decided. (My Goal is to just get a little more attention to this) Thanks, Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 21:02:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 20:02:56 +0000 Subject: [Koha-bugs] [Bug 12732] Sort late orders by basket creation or closing date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12732 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #15 from simith.doliveira at inlibro.com --- Kyle, This enhancement is sponsored by CCSR and that is the way they use. If the code is not suitable, so it must be followed up by someone else. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 21:19:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 20:19:47 +0000 Subject: [Koha-bugs] [Bug 9566] Only run analytics code if analytics are enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9566 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 21:35:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 20:35:49 +0000 Subject: [Koha-bugs] [Bug 13454] New: 7xx before 1xx in results Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13454 Bug ID: 13454 Summary: 7xx before 1xx in results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 34368 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34368&action=edit results When there?s a 110 and a 700, Koha is putting the 700 before the 110 in the results list view. It seems to be assuming a X00 is more important than a X10, whereas it should assume that a 1XX is more important than a 7XX: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 21:36:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 20:36:23 +0000 Subject: [Koha-bugs] [Bug 13454] 7xx before 1xx in results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13454 --- Comment #1 from Nicole C. Engard --- Created attachment 34369 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34369&action=edit full record In the full record display, it puts the creators in the correct order, with the 110 first, the 700 next, and then the 710s. Presumably when all the 700s are there they?ll be in the right place -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 21:40:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 20:40:06 +0000 Subject: [Koha-bugs] [Bug 13455] New: Members/AddEnrolmentFeeIfNeeded.t requires sample data Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13455 Bug ID: 13455 Summary: Members/AddEnrolmentFeeIfNeeded.t requires sample data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: mtompset at hotmail.com QA Contact: gmcharlt at gmail.com While trying to debug, I found prove t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t failed if sample data wasn't in the database. This should be fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 21:40:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 20:40:21 +0000 Subject: [Koha-bugs] [Bug 13455] Members/AddEnrolmentFeeIfNeeded.t requires sample data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13455 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |mtompset at hotmail.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 21:49:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 20:49:55 +0000 Subject: [Koha-bugs] [Bug 13455] Members/AddEnrolmentFeeIfNeeded.t requires sample data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13455 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 21:49:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 20:49:57 +0000 Subject: [Koha-bugs] [Bug 13455] Members/AddEnrolmentFeeIfNeeded.t requires sample data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13455 --- Comment #1 from M. Tompsett --- Created attachment 34370 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34370&action=edit Bug 13455: Members/AddEnrolmentFeeIfNeeded.t requires sample data TEST PLAN --------- 1) Make sure there are no 'J', 'K', nor 'YA' patron category codes. 2) Make sure there are no 'CPL' nor 'MPL' branch codes. 3) prove t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t -- dies horribly 4) apply patch 5) prove t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t -- passes 6) Run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 22:31:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 21:31:19 +0000 Subject: [Koha-bugs] [Bug 13456] New: Serials/Claims.t expects no subscriptions Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13456 Bug ID: 13456 Summary: Serials/Claims.t expects no subscriptions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: mtompset at hotmail.com QA Contact: gmcharlt at gmail.com Running prove t/db_dependent/Serials/Claims.t on any system with late subscriptions is going to trigger a failure. Temporary delete the subscriptions for testing purposes, and then rollback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 22:31:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 21:31:28 +0000 Subject: [Koha-bugs] [Bug 13456] Serials/Claims.t expects no subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13456 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 22:35:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 21:35:52 +0000 Subject: [Koha-bugs] [Bug 13456] Serials/Claims.t expects no subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13456 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 22:35:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 21:35:54 +0000 Subject: [Koha-bugs] [Bug 13456] Serials/Claims.t expects no subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13456 --- Comment #1 from M. Tompsett --- Created attachment 34371 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34371&action=edit Bug 13456: Serials/Claims.t expects no subscriptions However, this is an unreasonable assumption for a system which is in use (either lots of testing or production). TEST PLAN --------- 1) Have a supplier with a late subscription. 2) prove t/db_dependent/Serials/Claims.t -- will fail 3) apply patch 4) prove t/db_dependent/Serials/Claims.t -- success 5) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 23:02:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 22:02:41 +0000 Subject: [Koha-bugs] [Bug 13457] New: Suggestions.t expects sample itemtypes Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13457 Bug ID: 13457 Summary: Suggestions.t expects sample itemtypes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: mtompset at hotmail.com QA Contact: gmcharlt at gmail.com If you have more than the 8 default itemtypes, prove t/db_dependent/Suggestions.t fails. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 23:02:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 22:02:51 +0000 Subject: [Koha-bugs] [Bug 13457] Suggestions.t expects sample itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13457 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |mtompset at hotmail.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 23:06:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 22:06:04 +0000 Subject: [Koha-bugs] [Bug 13457] Suggestions.t expects sample itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13457 --- Comment #1 from M. Tompsett --- Created attachment 34372 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34372&action=edit Bug 13457: Suggestions.t expects sample itemtypes TEST PLAN --------- 1) Make sure you have more than 8 item types, and preferably something with a non-sample default code for itemtypes. 2) prove t/db_dependent/Suggestions.t -- this will fail 3) Apply patch 4) prove t/db_dependent/Suggestions.t -- this will succeed 5) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 23:06:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 22:06:02 +0000 Subject: [Koha-bugs] [Bug 13457] Suggestions.t expects sample itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13457 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 12 23:46:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Dec 2014 22:46:06 +0000 Subject: [Koha-bugs] [Bug 9768] Problem with grace period calculation and fine intervals >1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9768 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |katrin.fischer at bsz-bw.de Resolution|WONTFIX |--- --- Comment #4 from Katrin Fischer --- We are still very interested in seeing this fixed - until a new report is filed, I'd like to remove the WONTFIX. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 13 04:53:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Dec 2014 03:53:52 +0000 Subject: [Koha-bugs] [Bug 13263] Printing Callnumber in Koha 3.16.04.000. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13263 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- Comment on attachment 33610 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33610 Wrong Callnumber Format I believe the font in question requires upper case. But I would have expected better line breaks: FIC. P48A 1998 FIC. D64A 1997 FIC. H56DA 2000 FIL. RC862 D53 1990 FIL. RC862 D53 1990 Though, I'm not sure about the last two. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 13 09:19:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Dec 2014 08:19:29 +0000 Subject: [Koha-bugs] [Bug 11927] Add greek support to CHR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927 --- Comment #14 from Zeno Tajoli --- Do you have try to costumize etc/zebradb/etc/words-icu.xml doing tests with yaz-icu (http://www.indexdata.com/yaz/doc/yaz-icu.html) ? I think that the first test is to setup Bye -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 13 09:33:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Dec 2014 08:33:02 +0000 Subject: [Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 --- Comment #1 from Marc V?ron --- Created attachment 34373 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34373&action=edit Bug 13450 - Title and breadcrumb of Patron form can look weird in translations This patch moves the patron category name at the end of title and breadcrumb for better translatability. Note: It does not change anything in functionallity, it only changes display of strings. To test: Apply patch Search a patron and edit it in all possible ways Copy a patron Create a new patron Make sure that title and breadcrumb appear in a meaningful way with pattern similar to the following: Modify Child patron Hansli Meier (Juvenile) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 13 09:36:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Dec 2014 08:36:41 +0000 Subject: [Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 13 09:47:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Dec 2014 08:47:14 +0000 Subject: [Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 13 10:03:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Dec 2014 09:03:02 +0000 Subject: [Koha-bugs] [Bug 13307] Create a link to the last advanced search in search result page (OPAC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 --- Comment #13 from Marc V?ron --- Created attachment 34374 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34374&action=edit [Signed-off] Create a link to the last advanced search in search result page (OPAC) http://bugs.koha-community.org/show_bug.cgi?id=13307 Followed test plan, works as expected (together with other patches) Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 13 10:05:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Dec 2014 09:05:13 +0000 Subject: [Koha-bugs] [Bug 13307] Create a link to the last advanced search in search result page (OPAC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 --- Comment #14 from Marc V?ron --- Created attachment 34375 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34375&action=edit [Signed-off] Fix Patch- Search boxes disappear when returning to advanced search http://bugs.koha-community.org/show_bug.cgi?id=13307 Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 13 10:06:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Dec 2014 09:06:50 +0000 Subject: [Koha-bugs] [Bug 13307] Create a link to the last advanced search in search result page (OPAC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 --- Comment #15 from Marc V?ron --- Created attachment 34376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34376&action=edit [Signed-off] Fix jquery.deseriable.min.js http://bugs.koha-community.org/show_bug.cgi?id=13307 Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 13 10:07:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Dec 2014 09:07:14 +0000 Subject: [Koha-bugs] [Bug 13307] Create a link to the last advanced search in search result page (OPAC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33801|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 13 10:07:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Dec 2014 09:07:29 +0000 Subject: [Koha-bugs] [Bug 13307] Create a link to the last advanced search in search result page (OPAC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34095|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 13 10:07:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Dec 2014 09:07:41 +0000 Subject: [Koha-bugs] [Bug 13307] Create a link to the last advanced search in search result page (OPAC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34363|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 13 18:08:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Dec 2014 17:08:41 +0000 Subject: [Koha-bugs] [Bug 13451] Holidays.t assumes default data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13451 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 13 18:08:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Dec 2014 17:08:43 +0000 Subject: [Koha-bugs] [Bug 13451] Holidays.t assumes default data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13451 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34359|0 |1 is obsolete| | --- Comment #2 from Nick Clemens --- Created attachment 34377 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34377&action=edit [SIGNED OFF] Bug 13451: Holidays.t assumes default data This patch removes that assumption by expressly setting data to be default. TEST PLAN --------- 1) Ensure that branch code is NOT 'MPL' in the repeatable_holidays table in your database. 2) Ensure that branch codes 'MPL' and 'CPL' do not exist in the branches table in your database. 3) prove t/db_dependent/Holidays.t -- this should bomb horribly. 4) Apply patch 5) prove t/db_dependent/Holidays.t -- all tests should succeed. 6) run koha qa tests Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 13 18:22:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Dec 2014 17:22:05 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 13 19:22:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Dec 2014 18:22:41 +0000 Subject: [Koha-bugs] [Bug 7003] canned report to show patrons and permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7003 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org --- Comment #3 from Nick Clemens --- Just throwing this in, Chris and I rewrote the report to make it easier to read: SELECT surname,firstname,cardnumber, categorycode, branchcode, IF(flags MOD 2,'Set','') AS SuperLib, IF(MOD(flags DIV 2,2),'All parameters',GROUP_CONCAT(IF(u_p.module_bit=1,p.code,'') SEPARATOR ' ' ) ) AS "CircPermissions", IF(MOD(flags DIV 4,2),'Set','') AS 'View staff interface', IF(MOD(flags DIV 8,2),"All parameters" ,GROUP_CONCAT(IF(u_p.module_bit=3,p.code,'') SEPARATOR ' ' ) ) AS ManParams, IF(MOD(flags DIV 16,2),'Set','') AS 'Add/modify patrons', IF(MOD(flags DIV 32,2),'Set','') AS 'Modify permissions', IF(MOD(flags DIV 64,2),"All parameters" ,GROUP_CONCAT(IF(u_p.module_bit=6,p.code,'') SEPARATOR ' ' ) ) AS ReservePermissions, IF(MOD(flags DIV 128,2),'Set','') AS BorrowBooks, IF(MOD(flags DIV 512,2),"All parameters" ,GROUP_CONCAT(IF(u_p.module_bit=9,p.code,'') SEPARATOR ' ' ) ) AS EditCatalogue, IF(MOD(flags DIV 1024,2),"All parameters" ,GROUP_CONCAT(IF(u_p.module_bit=10,p.code,'') SEPARATOR ' ' ) ) AS UpdateCharges, IF(MOD(flags DIV 2048,2),"All parameters" ,GROUP_CONCAT(IF(u_p.module_bit=11,p.code,'') SEPARATOR ' ' ) ) AS Acquisition, IF(MOD(flags DIV 4096,2),'Set','') AS Management, IF(MOD(flags DIV 8192,2),"All parameters" ,GROUP_CONCAT(IF(u_p.module_bit=13,p.code,'') SEPARATOR ' ' ) ) AS Tools, IF(MOD(flags DIV 16384,2),'Set','') AS EditAuthories, IF(MOD(flags DIV 32768,2),"All parameters" ,GROUP_CONCAT(IF(u_p.module_bit=15,p.code,'') SEPARATOR ' ' ) ) AS Series, IF(MOD(flags DIV 65536,2),"All parameters" ,GROUP_CONCAT(IF(u_p.module_bit=16,p.code,'') SEPARATOR ' ' ) ) AS Reports, IF(MOD(flags DIV 131072,2),'Set','') AS StaffAccess, IF(MOD(flags DIV 262144,2),"All parameters" ,GROUP_CONCAT(IF(u_p.module_bit=18,p.code,'') SEPARATOR ' ' ) ) AS CourseReserves, IF(MOD(flags DIV 524288,2),"All parameters" ,GROUP_CONCAT(IF(u_p.module_bit=19,p.code,'') SEPARATOR ' ' ) ) AS Plugins FROM borrowers b LEFT JOIN user_permissions u_p ON b.borrowernumber=u_p.borrowernumber LEFT JOIN permissions p ON u_p.code=p.code WHERE flags>0 OR u_p.module_bit>0 GROUP BY b.borrowernumber ORDER BY categorycode,branchcode,surname,firstname ASC -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 13 20:49:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Dec 2014 19:49:31 +0000 Subject: [Koha-bugs] [Bug 13458] New: Add new patron shows default / hardcoded patron categories after search Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Bug ID: 13458 Summary: Add new patron shows default / hardcoded patron categories after search Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: david.roberts at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com After performing a patron search resulting in a list of patrons, clicking on New Patron shows a default list of patron categories, not the ones configured on the system. This happens in 3.18 and on Master. To reproduce: 1) Carry out a patron search for Smith (or other similar common name). This will bring up cgi-bin/koha/members/member.pl and a list of patrons. 2) Click on New Patron. 3) The list of categories will contain: Adult Patron, Child Patron, Professional Patron, Organisation, Staff Patron, Statistical Patron. These will display regardless of which patron categories are configured. This is the only page on which this happens - adding a patron on cgi-bin/koha/members/members-home.pl shows the correct list of configured patron categories. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 13 20:50:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Dec 2014 19:50:54 +0000 Subject: [Koha-bugs] [Bug 13458] Add new patron shows default / hardcoded patron categories after search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.roberts at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 14 03:31:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Dec 2014 02:31:10 +0000 Subject: [Koha-bugs] [Bug 13307] Create a link to the last advanced search in search result page (OPAC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 14 18:43:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Dec 2014 17:43:32 +0000 Subject: [Koha-bugs] [Bug 13396] koha-rebuild-zebra: Couldn't open collection.abs error after 3.18 package update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13396 --- Comment #2 from Stephen Warren --- Oops. I cut/paste the wrong filename in the bug description re: the Koha config file template. The correct two files I diff'd were: cd /etc/koha diff -u sites/library/koha-conf.xml koha-conf-site.xml.in Anyway, adding those 4 lines to koha-conf.xml does solve this issue. There are lots of other diffs between the config template and my config file. Should I rebuild the whole config file somehow, or manually apply all the changes? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 14 20:55:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Dec 2014 19:55:27 +0000 Subject: [Koha-bugs] [Bug 13296] error when using z3950 with UNIMARC authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13296 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Changes look logical, but I can't get the error to appear on my UNIMARC installation. I tried some UNIMARC targets I found, but none seems to work. Bit stuck on this - could you share a connection that works for you? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 14 21:10:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Dec 2014 20:10:05 +0000 Subject: [Koha-bugs] [Bug 13362] translate script creates dirs on update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13362 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 14 21:10:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Dec 2014 20:10:08 +0000 Subject: [Koha-bugs] [Bug 13362] translate script creates dirs on update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13362 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34020|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 34378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34378&action=edit [PASSED QA] Bug 13362: translate script creates dirs on update A dir creation was uncommented (by me), the effect is create a lang dir on 'update', which is no needed. To test: 1) Update translation files for a uninstalled language (cd misc/translator; ./translate update xx-YY) 2) Check new dirs koha-tmpl/opac-tmpl/bootstrap/xx-YY/ koha-tmpl/intranet-tmpl/prog/xx-YY/ koha-tmpl/intranet-tmpl/prog/en/modules/help/xx-YY/ 3) Clean all git clean -f -d 4) Apply the patch 5) Repeat 1) (i.e. update) 6) Check no new dirs this time Signed-off-by: Frederic Demians Signed-off-by: Katrin Fischer Tested according to test plan, works as described. Passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 14 21:15:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Dec 2014 20:15:48 +0000 Subject: [Koha-bugs] [Bug 13451] Holidays.t assumes default data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13451 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34377|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 34379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34379&action=edit [PASSED QA] Bug 13451: Holidays.t assumes default data This patch removes that assumption by expressly setting data to be default. TEST PLAN --------- 1) Ensure that branch code is NOT 'MPL' in the repeatable_holidays table in your database. 2) Ensure that branch codes 'MPL' and 'CPL' do not exist in the branches table in your database. 3) prove t/db_dependent/Holidays.t -- this should bomb horribly. 4) Apply patch 5) prove t/db_dependent/Holidays.t -- all tests should succeed. 6) run koha qa tests Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Tests pass without holidays in the calendar. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 14 21:15:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Dec 2014 20:15:45 +0000 Subject: [Koha-bugs] [Bug 13451] Holidays.t assumes default data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13451 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 14 21:23:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Dec 2014 20:23:49 +0000 Subject: [Koha-bugs] [Bug 13415] Prevent librarians from scanning multiple items into a single barcode field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13415 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34235|0 |1 is obsolete| | Attachment #34341|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 34380 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34380&action=edit [PASSED QA] Bug 13415 - Prevent librarians from scanning multiple items into a single barcode field It appears that some librarians will attempt to scan items as fast as they can without checking to make sure the checkout was submitted and the page reloaded properly. This can cause multiple barcodes to be scanned into the barcode field if the person is fast enough. This causes the checkout of both ( or more! ) items to fail. Test Plan: 1) Apply this patch 2) Attempt to scan two or more items into the barcode field You can emulate this with a keybaord by hitting a few keys, then enter, then a few more keys, then enter again. The barcodes don't need to be valid for this test. 3) Note the dialog stating the barcode has been submitted and to please wait. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 14 21:23:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Dec 2014 20:23:45 +0000 Subject: [Koha-bugs] [Bug 13415] Prevent librarians from scanning multiple items into a single barcode field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13415 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 14 21:26:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Dec 2014 20:26:23 +0000 Subject: [Koha-bugs] [Bug 13415] Prevent librarians from scanning multiple items into a single barcode field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13415 --- Comment #9 from Katrin Fischer --- Created attachment 34381 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34381&action=edit [PASSED QA] Bug 13415 [QA Followup] - Change bind to on, revert barcode disable Signed-off-by: Katrin Fischer Tested according to test plan, passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 14 21:29:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Dec 2014 20:29:08 +0000 Subject: [Koha-bugs] [Bug 13307] Create a link to the last advanced search in search result page (OPAC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|trivial |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 14 21:35:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Dec 2014 20:35:31 +0000 Subject: [Koha-bugs] [Bug 13459] New: Datatables paging slightly broken Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13459 Bug ID: 13459 Summary: Datatables paging slightly broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Created attachment 34382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34382&action=edit Screenshot of administration-itemtypes Paging in datatables table is slightly broken - see screenshot from dministration > itemtypes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 14 22:21:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Dec 2014 21:21:13 +0000 Subject: [Koha-bugs] [Bug 13460] New: Use price template toolkit plugin across all of intranet Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13460 Bug ID: 13460 Summary: Use price template toolkit plugin across all of intranet Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: robin at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com not all price displays in the intranet use the price template toolkit plugin, and they should. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 14 22:25:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Dec 2014 21:25:49 +0000 Subject: [Koha-bugs] [Bug 13461] New: Circ always asking for confirmation if RentalFeesCheckoutConfirmation is used Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13461 Bug ID: 13461 Summary: Circ always asking for confirmation if RentalFeesCheckoutConfirmation is used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If RentalFeesCheckoutConfirmation system preference is activated, Koha will ask for confirmation for every checkout, even if there is no rental fine defined for the itemtype. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 14 22:32:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Dec 2014 21:32:50 +0000 Subject: [Koha-bugs] [Bug 13461] Circ always asking for confirmation if RentalFeesCheckoutConfirmation is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13461 --- Comment #1 from Katrin Fischer --- Created attachment 34383 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34383&action=edit Bug 13461 - Circ always asking for confirmation if RentalFeesCheckoutConfirmation is used To test: - Check RentalFeesCheckoutConfirmation is activated - Try to check out an item without rental fine - Verify confirmation message without explanation is shown - Apply patch - Verify confirmation message is no longer shown - Configure itemtype to have rental fee - Veirfy now the confirmation message appears as it should -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 14 22:33:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Dec 2014 21:33:13 +0000 Subject: [Koha-bugs] [Bug 13461] Circ always asking for confirmation if RentalFeesCheckoutConfirmation is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13461 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 14 22:35:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Dec 2014 21:35:38 +0000 Subject: [Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 14 22:35:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Dec 2014 21:35:41 +0000 Subject: [Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34253|0 |1 is obsolete| | Attachment #34254|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 34384 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34384&action=edit [PASSED QA] Bug 13315 - Add feedback for last item checked out to circulation.pl It seems that many librarians find it disconcerting to have no feedback with the new checkouts table. It seems that many of them wait for it to fully load, check to verify the item was checked out, and only then check out the next item. To help alleviate this issue, we can have the checkouts page give feedback about the item that was just checked out. Test Plan: 1) Apply this patch 2) Check an item out 3) Note the message "$title ($barcode) due on $date_due" Signed-off-by: Owen Leonard This works well and fixes a very problematic issue with the new AJAX circ. I will be submitting a follow-up which I think is an improvement to the display. Signed-off-by: Jason Burds Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 14 22:35:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Dec 2014 21:35:58 +0000 Subject: [Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315 --- Comment #16 from Katrin Fischer --- Created attachment 34385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34385&action=edit [PASSED QA] Bug 13315 [Follow-up] Add feedback for last item checked out to circulation.pl This patch changes the position and styling of the information about the last checkout so that it is grouped with the checkout form itself, placing the message in a more visible position, especially for patrons with a lot of information in the right-hand messages column which might push the checkouts table down offscreen. To test, apply the patch and clear your browser cache in order to refresh the main CSS file. Check out an item and confirm that a message is prominently displayed. Signed-off-by: Jason Burds Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 14 22:50:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Dec 2014 21:50:06 +0000 Subject: [Koha-bugs] [Bug 13449] Syndetics TOC will not display in some cases In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13449 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 14 22:50:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Dec 2014 21:50:09 +0000 Subject: [Koha-bugs] [Bug 13449] Syndetics TOC will not display in some cases In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13449 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34365|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 34386 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34386&action=edit [PASSED QA] Bug 13449 - Syndetics TOC will not display in some cases For reasons unknown, the table of contents data from Syndetics will not display if there is no p element, even though within that if for the p element there's a second one for the p element! This is neither good nor necessary. Test Plan: 1) Enable Syndetics 2) Find a record that should have a Syndetics TOC but doesn't 3) Apply this patch 4) Reload the page 5) Note the Syndetics TOC data now displays Signed-off-by: Julius Fleschner Signed-off-by: Katrin Fischer I couldn't test but from reading the code this should not have any negative consequences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 14 23:09:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Dec 2014 22:09:43 +0000 Subject: [Koha-bugs] [Bug 13460] Use price template toolkit plugin across all of intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13460 Alexander Cheeseman changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thisisnodirection at hotmail.c | |om --- Comment #1 from Alexander Cheeseman --- Created attachment 34387 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34387&action=edit suggested patch - adds price plugin to suggestion.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 14 23:09:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Dec 2014 22:09:57 +0000 Subject: [Koha-bugs] [Bug 13462] New: I18N system preferences language/opaclanguages descriptions need an update Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13462 Bug ID: 13462 Summary: I18N system preferences language/opaclanguages descriptions need an update Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Documentation Assignee: nengard at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org http://manual.koha-community.org/3.18/en/administration.html#l18nprefs 1.8.4. language Default: English Asks: Enable the following languages on the staff interface Values: English To install additional languages you need to run misc/translation/install-code.pl. For example, to install French you would run the following command install-code.pl fr-FR to make the templates, once they exist and are in the right place then they will show up as an option in this preference. ---- misc/translation/install-code.pl is no longer used. To install a language we can refer to http://wiki.koha-community.org/wiki/Installation_of_additional_languages_for_OPAC_and_INTRANET_staff_client The way to install additional languages is different for packages and other installations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 14 23:10:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Dec 2014 22:10:13 +0000 Subject: [Koha-bugs] [Bug 13460] Use price template toolkit plugin across all of intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13460 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 14 23:48:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Dec 2014 22:48:47 +0000 Subject: [Koha-bugs] [Bug 13383] RDA: 100/110/111 changes to XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13383 --- Comment #2 from Nicole C. Engard --- What separator would you use instead? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 14 23:50:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Dec 2014 22:50:32 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #7 from Nicole C. Engard --- What separator would be best if not | ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 00:07:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Dec 2014 23:07:16 +0000 Subject: [Koha-bugs] [Bug 13460] Use price template toolkit plugin across all of intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13460 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 00:07:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Dec 2014 23:07:19 +0000 Subject: [Koha-bugs] [Bug 13460] Use price template toolkit plugin across all of intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13460 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34387|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 34388 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34388&action=edit bug 13460: suggestion.tt now uses Price plugin To test: 1/ Add a new suggestion, put some values for the price 2/ View the suggestion in the staff interface 2/ Switch the currency format 3/ Notice the format of the price does not change 4/ Apply patch 5/ Notice now the syspref is respected Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 02:41:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 01:41:01 +0000 Subject: [Koha-bugs] [Bug 13398] Perl files for rotating collections are missing in installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13398 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Perl files for rotating |Perl files for rotating |collections are missing in |collections are missing in |debian package |installations -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 06:50:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 05:50:16 +0000 Subject: [Koha-bugs] [Bug 13463] New: Allow passing default parameters to SQL reports in the URL Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13463 Bug ID: 13463 Summary: Allow passing default parameters to SQL reports in the URL Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org If an SQL report asks user for a parameter, it should be possible to pass the default value for that parameter in the URL. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 07:08:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 06:08:37 +0000 Subject: [Koha-bugs] [Bug 13460] Use price template toolkit plugin across all of intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13460 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 07:08:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 06:08:40 +0000 Subject: [Koha-bugs] [Bug 13460] Use price template toolkit plugin across all of intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13460 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34388|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 34390 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34390&action=edit [PASSED QA] bug 13460: suggestion.tt now uses Price plugin To test: 1/ Add a new suggestion, put some values for the price 2/ View the suggestion in the staff interface 2/ Switch the currency format 3/ Notice the format of the price does not change 4/ Apply patch 5/ Notice now the syspref is respected Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Works as described, thx! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 07:11:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 06:11:52 +0000 Subject: [Koha-bugs] [Bug 13398] Perl files for rotating collections are missing in installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13398 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 07:11:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 06:11:55 +0000 Subject: [Koha-bugs] [Bug 13398] Perl files for rotating collections are missing in installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13398 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34327|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 34391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34391&action=edit [SIGNED OFF] Bug 13398: rotating collections scripts are skipped on install This patch makes the Makefile.PL script pick the rotating_collections/ directory for install. To test: - Run: $ perl Makefile.PL - Install using either 'standard' or 'single' method. => FAIL: Verify that there is no 'rotating_collections' directory on the intranet CGI direcory. - Apply the patch - Run: $ perl Makefile.PL - Install using either 'standard' or 'single' method. => SUCCESS: Verify that there is a 'rotating_collections' directory on the intranet CGI direcory. - Sign off :-D Regards Tomas PS1: Note that it should be enough to check for the rotating_collections files on the generated Makefile after 'perl Makefile.PL'. PS2: The packages use the 'standard' install method to generate the file tree. So this patch should fix the packages too. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 09:45:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 08:45:03 +0000 Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34013|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 34392 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34392&action=edit Bug 13345: Allow patrons to choose format on sending basket/list by email -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 09:45:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 08:45:25 +0000 Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13343 | Depends on| |13343 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 09:45:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 08:45:25 +0000 Subject: [Koha-bugs] [Bug 13343] Items are not embedded when sending a basket/shelf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13343 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13345 See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13345 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 10:31:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 09:31:59 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33145|0 |1 is obsolete| | --- Comment #75 from Jonathan Druart --- Created attachment 34393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34393&action=edit Bug 11395: Add a batch record modification This patch offers a new tool to modify records in a batch. This feature adds: - a new pl/tt files tools/batch_record_modification - a new permission: tools > records_batchmod Test plan for biblios: 0/ Create a new marc modification template with some actions. 1/ Generate a list of biblionumbers you want to modify. There are two ways to generate a list of biblionumbers: - using the basket: do a search, add some biblio to your basket, open the basket and click on the "Action" button > "Modify" - generating a list from a report 2/ On the "Batch record modification" tool verify: - information is correct. - the preview link show you the needed record. 3/ After clicking on the "Modify selected recors" button, verify the records have been modified as you wanted. Test plan for authority: 0/ Create a new marc modification template with some actions. 1/ Generate a list of authid using a report: 2/ On the "Batch record modification" tool verify: - authorities are display with the summary. - the preview link show you the needed record. 3/ After clicking on the "Modify selected recors" button, verify the records have been modified as you wanted. Catch of errors: if an error occurs during the modification process, the tool displays an error message. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 10:32:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 09:32:05 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33146|0 |1 is obsolete| | --- Comment #76 from Jonathan Druart --- Created attachment 34394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34394&action=edit Bug 11395: Add links to the new tool page This patch adds links in the tool module to the new batch tool and in the basket. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 10:32:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 09:32:11 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33148|0 |1 is obsolete| | --- Comment #77 from Jonathan Druart --- Created attachment 34395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34395&action=edit Bug 11395: New service to preview a record. The main patch adds the ability to preview a record. This is done using an AJAX way. The preview record is processed on the server side. Note: I don't think an authentification check is necessary here. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 10:32:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 09:32:19 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33149|0 |1 is obsolete| | --- Comment #78 from Jonathan Druart --- Created attachment 34396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34396&action=edit Bug 11395: The modification template should be changed on the list view This patch fixes the following issue: If the user comes from a basket, the list view is displayed but there is no way to select the modification template. Now the template can be chosen on the list view. This way, the user is able to change the modifications to apply and see the previewed records. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 10:32:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 09:32:29 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33150|0 |1 is obsolete| | --- Comment #79 from Jonathan Druart --- Created attachment 34397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34397&action=edit Bug 11395: DB: Add permission tools_records_batchmod Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 10:32:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 09:32:34 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33152|0 |1 is obsolete| | --- Comment #80 from Jonathan Druart --- Created attachment 34398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34398&action=edit Bug 11395: Fix path for the checkboxes jQuery plugin This patch fixes a bad resolution conflict (bug 12107). Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 10:32:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 09:32:39 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33153|0 |1 is obsolete| | --- Comment #81 from Jonathan Druart --- Created attachment 34399 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34399&action=edit Bug 11395: prevent processing no record If no record is selected, the modification should not be launched. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 10:32:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 09:32:44 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33154|0 |1 is obsolete| | --- Comment #82 from Jonathan Druart --- Created attachment 34400 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34400&action=edit Bug 11395: Raise an alert if control field is used If a control field is used with a copy or move action, the interface should block the user in some cases: - If a control field is used with a regular field - The subfield should be empty Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 10:32:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 09:32:50 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33155|0 |1 is obsolete| | --- Comment #83 from Jonathan Druart --- Created attachment 34401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34401&action=edit Bug 11395: exit should be done after displaying the output Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 10:33:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 09:33:16 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #84 from Jonathan Druart --- Patches rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 10:33:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 09:33:31 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #85 from Jonathan Druart --- Created attachment 34402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34402&action=edit Bug 11395: A control field is a field with tag < 10 This patch fixes the existing test about control fields. A control field is < 10, not <=10! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 11:10:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 10:10:16 +0000 Subject: [Koha-bugs] [Bug 13029] Allow to pass additional parameters to SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 11:10:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 10:10:19 +0000 Subject: [Koha-bugs] [Bug 13029] Allow to pass additional parameters to SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32013|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 34403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34403&action=edit Bug 13029: Allow to pass additional parameters to SMS::Send drivers C4::SMS::send_sms now reads a YAML file and pass all parameters in the file to SMS::Send::new. The config file is read in /etc/sms/driver/.yaml. For instance, if the driver used is SMS::Send::UK::Kapow, the config file has to be in /etc/sms/driver/UK/Kapow.yaml A underscore character is prepended to all parameter names so they are treated as driver-specific options (leading underscore must not appear in config file). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 11:10:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 10:10:33 +0000 Subject: [Koha-bugs] [Bug 13029] Allow to pass additional parameters to SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #5 from Jonathan Druart --- Patch rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 11:18:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 10:18:38 +0000 Subject: [Koha-bugs] [Bug 13372] Items lost report improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13372 --- Comment #5 from Jonathan Druart --- Created attachment 34404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34404&action=edit Bug 13372: Sort is done by DataTables This patch removes the order by filter on the items lost report. The sort can now be done by DataTables. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 11:19:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 10:19:30 +0000 Subject: [Koha-bugs] [Bug 13372] Items lost report improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13372 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Jonathan Druart --- The last patch let DataTables sort the table. It makes more sense to me. Let me know if you disagree. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 11:53:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 10:53:00 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33170|0 |1 is obsolete| | --- Comment #44 from Jonathan Druart --- Created attachment 34405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34405&action=edit Bug 12404: Add UT for marcrecord2csv Verify that these unit tests pass before any changes and after applying all patches. Signed-off-by: Courret -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 11:53:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 10:53:04 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33171|0 |1 is obsolete| | --- Comment #45 from Jonathan Druart --- Created attachment 34406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34406&action=edit Bug 12404: Add new unit tests These unit tests reflect the changes done in next patches. Signed-off-by: Courret -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 11:53:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 10:53:09 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33172|0 |1 is obsolete| | --- Comment #46 from Jonathan Druart --- Created attachment 34407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34407&action=edit Bug 12404: Allow TT tags for csv profiles This patch is the main patch. It contains the changes in C4::Record::marcrecord2csv. The goal of this development is to provide a better flexibility on creating a CSV profile. Currently it is not possible to: - Concatenate specific subfields into a csv column - Display a field/subfield using a condition - Extract a substring of a subfield value and a lot of other actions. This patch allows to write Template Toolkit code and to extract only data you want. See the help page for more information (in next patch). Test plan: Create some CSV profiles (MARC, not SQL) using some TT methods. Use the basket export and the export tool and verify the CSV file generated is what you expected. Signed-off-by: Courret -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 11:53:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 10:53:13 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34300|0 |1 is obsolete| | --- Comment #47 from Jonathan Druart --- Created attachment 34408 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34408&action=edit Bug 12404: tools/export.pl allows CSV export Signed-off-by: Courret -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 11:53:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 10:53:20 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34302|0 |1 is obsolete| | --- Comment #49 from Jonathan Druart --- Created attachment 34410 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34410&action=edit Bug 12404: Allow equal sign '=' in the TT directive Signed-off-by: Courret -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 11:53:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 10:53:16 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34301|0 |1 is obsolete| | --- Comment #48 from Jonathan Druart --- Created attachment 34409 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34409&action=edit Bug 12404: Add some documentation in the help page. Signed-off-by: Courret -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 11:53:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 10:53:26 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34303|0 |1 is obsolete| | --- Comment #50 from Jonathan Druart --- Created attachment 34411 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34411&action=edit Bug 12404: FIX documentation to join subfield To display all subfields, the join TT method must be used. Signed-off-by: Courret -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 11:56:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 10:56:44 +0000 Subject: [Koha-bugs] [Bug 11927] Add greek support to CHR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com --- Comment #15 from Colin Campbell --- In a straightforward ICU install no transliteration is done. Non latin alphabets can be searched using their own characters. It uses a unicode defined sequence, so a catalogue containing more than one alphabet should be able to be searched in that alphabet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 12:04:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 11:04:05 +0000 Subject: [Koha-bugs] [Bug 10753] Creating suggestions for 'Any library' uses _ANY as branchcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10753 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |paola.rossi at cineca.it --- Comment #4 from Paola Rossi --- I've applied the patch against master 3.19.00.000 There are some [and case?] errors in the patch: Web installer ? Step 3 Updating database structure Update errors : [Mon Dec 15 11:56:05 2014] updatedatabase.pl: Global symbol "$dbversion" requires explicit package name at /var/root-koha/..../installer/data/mysql/updatedatabase.pl line 9588. [Mon Dec 15 11:56:05 2014] updatedatabase.pl: Global symbol "$dbversion" requires explicit package name at /var/root-koha/..../installer/data/mysql/updatedatabase.pl line 9589. [Mon Dec 15 11:56:05 2014] updatedatabase.pl: Global symbol "$dbversion" requires explicit package name at /var/root-koha/.../installer/data/mysql/updatedatabase.pl line 9593. [Mon Dec 15 11:56:05 2014] updatedatabase.pl: Global symbol "$dbversion" requires explicit package name at /var/root-koha/..../installer/data/mysql/updatedatabase.pl line 9594. [Mon Dec 15 11:56:05 2014] updatedatabase.pl: Execution of /var/root-koha/..../installer/data/mysql/updatedatabase.pl aborted due to compilation errors. I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 12:18:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 11:18:29 +0000 Subject: [Koha-bugs] [Bug 10753] Creating suggestions for 'Any library' uses _ANY as branchcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10753 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 12:18:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 11:18:32 +0000 Subject: [Koha-bugs] [Bug 10753] Creating suggestions for 'Any library' uses _ANY as branchcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10753 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34307|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 34412 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34412&action=edit Bug 10753: Any library is represented by an empty string And not with "__ANY__" Test plan: 0/ Don't apply this patch 1/ Create a suggestion for "any library" 2/ Verify suggestions.branchcode contain "__ANY__" 3/ Apply this patch and execute the updatedb entry 4/ Create a suggestion for "any library" 5/ Verify suggestions.branchcode contain "" (for both suggestions). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 12:19:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 11:19:04 +0000 Subject: [Koha-bugs] [Bug 10753] Creating suggestions for 'Any library' uses _ANY as branchcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10753 --- Comment #6 from Jonathan Druart --- (In reply to Paola Rossi from comment #4) > I've applied the patch against master 3.19.00.000 > > There are some [and case?] errors in the patch: > > Web installer ? Step 3 > Updating database structure > > Update errors : Sorry about that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 12:39:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 11:39:16 +0000 Subject: [Koha-bugs] [Bug 10753] Creating suggestions for 'Any library' uses _ANY as branchcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10753 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 12:39:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 11:39:57 +0000 Subject: [Koha-bugs] [Bug 10753] Creating suggestions for 'Any library' uses _ANY as branchcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10753 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34412|0 |1 is obsolete| | --- Comment #7 from Paola Rossi --- Created attachment 34413 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34413&action=edit Bug 10753: Any library is represented by an empty string Thanks, Jonathan. I've applied the patch against 3.19.00.000 Everything is OK as required. So I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 13:00:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 12:00:36 +0000 Subject: [Koha-bugs] [Bug 13464] New: Standardize the pagination class Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13464 Bug ID: 13464 Summary: Standardize the pagination class Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org Most templates use class "pages" for pagination controls, but few use class "paginationBar" and one uses id "pagination-bar" The "pages" class already has css styles, so all pagination controls should use the same class. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 13:34:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 12:34:51 +0000 Subject: [Koha-bugs] [Bug 13465] New: Fields controlled by authorized values cannot be unset Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13465 Bug ID: 13465 Summary: Fields controlled by authorized values cannot be unset Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In item cataloguing, if you set a field controlled by an authorized value, changing it back to '' does not work. The field cannot be reset. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 13:36:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 12:36:43 +0000 Subject: [Koha-bugs] [Bug 13167] Stage MARC for Import hangs for biblio containing valid 979* ISBN-13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33130|0 |1 is obsolete| | CC| |colin.campbell at ptfs-europe. | |com --- Comment #9 from Colin Campbell --- Created attachment 34414 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34414&action=edit Signed Off patch This is not Unimarc specific I reproduced this using marc-21. its a simple logic error in the NormalizeISBN routine while all valid 10 character isbns can be encoded as 13 character isbns the reverse is not true. Any process using NormalizeISBN is liable to error if it encounters this case not just Import (although thats where I encountered it independently ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 13:40:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 12:40:01 +0000 Subject: [Koha-bugs] [Bug 13461] Circ always asking for confirmation if RentalFeesCheckoutConfirmation is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13461 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paola.rossi at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 13:41:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 12:41:01 +0000 Subject: [Koha-bugs] [Bug 13461] Circ always asking for confirmation if RentalFeesCheckoutConfirmation is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13461 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34383|0 |1 is obsolete| | --- Comment #2 from Paola Rossi --- Created attachment 34415 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34415&action=edit Bug 13461 - Circ always asking for confirmation if RentalFeesCheckoutConfirmation is used I've applied the patch against 3.19.00.000 Everything is OK as required. So I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 13:46:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 12:46:15 +0000 Subject: [Koha-bugs] [Bug 13465] Fields controlled by authorized values cannot be unset In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13465 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|normal |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 13:47:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 12:47:00 +0000 Subject: [Koha-bugs] [Bug 13465] Fields controlled by authorized values cannot be unset In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13465 --- Comment #1 from Katrin Fischer --- I confirmed the bug in our 3.18.1 database - you can't unset not for loan, damaged or smilar values once you have set them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 13:55:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 12:55:47 +0000 Subject: [Koha-bugs] [Bug 13466] New: Changing language does not work Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13466 Bug ID: 13466 Summary: Changing language does not work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Changing language in the staff client results in a redirection error that firefox relates to blocked cookies (which is not the case). This has been a problem before, but I could not find the bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 14:01:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 13:01:01 +0000 Subject: [Koha-bugs] [Bug 13466] Changing language does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13466 --- Comment #1 from Mirko Tietgen --- The description is somewhat inaccurate as the language does get changed, but you have to hit the back button from the error page or reload. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 14:16:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 13:16:51 +0000 Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34366|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall --- Created attachment 34416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34416&action=edit Bug 13023 - Nonpublic note for items should be mapped to a database column like itemnotes An item's public notes are mapped to a db column, but the librarian only notes are not. We need to map these so in the future we may display them in places other than the editor. Test Plan: 1) Create an item with a non-public note 2) Apply this patch 3) Run updatedatabase 4) Update your frameworks to map your nonpublic item note to items.itemnotes_nonpublic 5) Run misc/batchRebuildItemsTables.pl 6) Inspect the database, note that your non-public note is now in items.itemnotes_nonpublic Signed-off-by: Paola Rossi Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 14:16:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 13:16:49 +0000 Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 14:17:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 13:17:35 +0000 Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 --- Comment #19 from Kyle M Hall --- Created attachment 34417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34417&action=edit Bug 13023 [QA Followup] - Add db mapping to default marc21 frameworks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 14:19:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 13:19:16 +0000 Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34417|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall --- Created attachment 34418 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34418&action=edit Bug 13023 [QA Followup] - Add db mapping to default marc21 frameworks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 14:26:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 13:26:41 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31896|0 |1 is obsolete| | --- Comment #41 from simith.doliveira at inlibro.com --- Created attachment 34419 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34419&action=edit Bug 10947 - Grouped ItemTypes - Patch should apply properly on latest master. Other patches are now obsolete, this is a squashed patch. Merge conflicts were resolved. Sponsored-by: Vanier college -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 14:29:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 13:29:24 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 14:40:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 13:40:07 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 --- Comment #12 from simith.doliveira at inlibro.com --- Created attachment 34420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34420&action=edit camelot 778 lbo_RM5001_Bordereau / BZ11882 fix -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 14:45:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 13:45:44 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34420|0 |1 is obsolete| | --- Comment #13 from simith.doliveira at inlibro.com --- Comment on attachment 34420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34420 camelot 778 lbo_RM5001_Bordereau / BZ11882 fix >From d95afe65f1b4939d22ea27af9c531faff3e7ccd3 Mon Sep 17 00:00:00 2001 >From: simith >Date: Mon, 3 Nov 2014 09:06:40 -0500 >Subject: [PATCH] camelot 778 lbo_RM5001_Bordereau / BZ11882 fix > >--- > circ/circulation.pl | 18 +++++++----------- > 1 file changed, 7 insertions(+), 11 deletions(-) > >diff --git a/circ/circulation.pl b/circ/circulation.pl >index dc41405..88a0ccc 100755 >--- a/circ/circulation.pl >+++ b/circ/circulation.pl >@@ -380,6 +380,13 @@ if ($barcode) { > > my ( $od, $issue, $fines ) = GetMemberIssuesAndFines($borrowernumber); > $template->param( issuecount => $issue ); >+ >+ if ($question->{RESERVE_WAITING} or $question->{RESERVED}){ >+ $template->param( >+ reserveborrowernumber => $question->{'resborrowernumber'}, >+ itembiblionumber => $getmessageiteminfo->{'biblionumber'} >+ ); >+ } > } > > # reload the borrower info for the sake of reseting the flags..... >@@ -554,17 +561,6 @@ my $relatives_issues_count = > Koha::Database->new()->schema()->resultset('Issue') > ->count( { borrowernumber => \@relatives } ); > >-(my $returned, my $messages) = AddReturn( $barcode, $branch); >-if ( $messages->{'ResFound'}) { >- my $reserve = $messages->{'ResFound'}; >- # get biblio description >- my $biblio = GetBiblioFromItemNumber($reserve->{'itemnumber'}); >- $template->param( >- reserveborrowernumber => $reserve->{'borrowernumber'}, >- itembiblionumber => $biblio->{'biblionumber'} >- ); >-} >- > $template->param( > lib_messages_loop => $lib_messages_loop, > bor_messages_loop => $bor_messages_loop, >-- >1.9.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 14:48:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 13:48:39 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31400|0 |1 is obsolete| | --- Comment #14 from simith.doliveira at inlibro.com --- Created attachment 34421 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34421&action=edit Bug 11882 - Add a new button to the checkout confirmation dialog when checking out a reserved item This patch adds a "Don't Check Out and Print Slip" button to the dialog that appears when trying to checkout a reserved item. Test case : * Put a hold on an item for User A. * Try to check out it item with User B. * The "Please confirm checkout" box should appear. The "Don't Check Out and Print Slip" button should appear in this box. * Click on the "Don't Check Out and Print Slip" button. * A print popup will appear -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 14:51:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 13:51:05 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 14:55:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 13:55:08 +0000 Subject: [Koha-bugs] [Bug 9743] Allow customization for making hold notes required In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Hold notes are required if |Allow customization for |there is one item referring |making hold notes required |to more parts/volumes | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 14:56:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 13:56:09 +0000 Subject: [Koha-bugs] [Bug 9743] Allow customization for making hold notes required In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 14:56:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 13:56:11 +0000 Subject: [Koha-bugs] [Bug 9743] Allow customization for making hold notes required In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743 --- Comment #29 from M. de Rooy --- Created attachment 34422 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34422&action=edit Bug 9743: Allow customization for making hold notes required This patch removes some unused code in the reserves template for mandatory hold notes reasons. It adds a simpler approach: if you define a custom routine for required hold notes, the textarea in the template may turn into a required field, otherwise it will not. Test plan: [1] Without adding a routine in opac-reserve: Place a hold on one and on more biblio numbers. Verify that hold notes are not required in any case. [2] Add the following simple routine to opac-reserve: sub _reqholdnotes { 1; } Verify that hold notes are always required now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 14:58:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 13:58:11 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34299|0 |1 is obsolete| | Attachment #34306|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart --- Created attachment 34423 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34423&action=edit Bug 13371: List suppliers even if they don't have basket. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 14:58:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 13:58:17 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #28 from Jonathan Druart --- Created attachment 34424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34424&action=edit Bug 13371: Fix filtering on numbers This patch fixes a weird bug on some instances. Since the sort is disabled on this table, we don't care on the type of the data. It should allow to filter on all columns of the table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 14:58:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 13:58:23 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #29 from Jonathan Druart --- Created attachment 34425 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34425&action=edit Bug 13371: Move firstname and surname closer On this way, they can be searched together ("my_firstname my_surname"). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 15:00:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 14:00:12 +0000 Subject: [Koha-bugs] [Bug 13467] New: acq tab still says ordered even if completed Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13467 Bug ID: 13467 Summary: acq tab still says ordered even if completed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 34426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34426&action=edit ordered instead of completed When an order is completed it's still saying that it's ORDERED in the acq details tab in the staff client. In the attached image you can see the received date and when I look at the invoice everything is received and done. It should say completed but does not. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 15:00:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 14:00:16 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #30 from Jonathan Druart --- (In reply to Paola Rossi from comment #26) > 1) 'Item count' and 'Biblio count' didn't yet work: > "No matching records found" (even if some records matched my search). > It happened using: > FF 34.0.5, IE 11, GCh Version 39.0.2171.95 m I finally reproduced the problem on a sandbox (so same browser and same code, only data have changed). Fix submitted (Bug 13371: Fix filtering on numbers). > 2) > [...] the "created by" column should contain firstname + surname. > So I've filtered by "firstname surname" values: ERROR: > No matching records found Fixed too (Bug 13371: Move firstname and surname closer). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 15:00:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 14:00:47 +0000 Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34418|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall --- Created attachment 34427 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34427&action=edit Bug 13023 [QA Followup] - Add db mapping to frameworks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 15:01:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 14:01:52 +0000 Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34427|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall --- Created attachment 34428 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34428&action=edit Bug 13023 [QA Followup] - Add db mapping to frameworks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 15:04:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 14:04:04 +0000 Subject: [Koha-bugs] [Bug 9743] Allow customization for making hold notes required In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743 --- Comment #30 from M. de Rooy --- Please enable pref OpacHoldNotes to have meaningful test results :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 15:05:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 14:05:18 +0000 Subject: [Koha-bugs] [Bug 13457] Suggestions.t expects sample itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13457 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paola.rossi at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 15:06:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 14:06:33 +0000 Subject: [Koha-bugs] [Bug 13457] Suggestions.t expects sample itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13457 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34372|0 |1 is obsolete| | --- Comment #2 from Paola Rossi --- Created attachment 34429 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34429&action=edit Bug 13457: Suggestions.t expects sample itemtypes I've applied the patch against 3.19.00.000 Everything is OK as required. In detail of step 5) I saw: koha-qa.pl -v 2 -c 1 testing 1 commit(s) (applied to 5bdf460 'Bug 13425 - XSS in opac facets - Patc') Processing files before patches |========================>| 1 / 1 (100.00%) Processing files after patches |========================>| 1 / 1 (100.00%) OK t/db_dependent/Suggestions.t OK critic OK forbidden patterns OK pod OK valid So I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 15:34:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 14:34:27 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 15:35:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 14:35:40 +0000 Subject: [Koha-bugs] [Bug 11921] memcached configuration should be moved back to koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 15:45:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 14:45:08 +0000 Subject: [Koha-bugs] [Bug 13430] Serial enumeration not visible when handling Serial Items. Show enumerations for Serial Items in the circ- and member-modules. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13430 --- Comment #2 from Olli-Antti Kivilahti --- Created attachment 34430 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34430&action=edit Bug 13430 - Simple version - Serial enumeration not visible when handling Serial Items. Circ- and member-modules. Adding enumchron (Vol info) to circ/circulation.pl and members/moremember.pl "Checkouts"-, "Relatives checkouts"- and "Holds"-views. TEST PREPARATIONS: -1. Find a Borrower/parent with a child/guarantee. -0. Make a Subscription (creating Items when receiving serial numbers) to a Biblio and receive atleast 4 numbers. TEST PLAN (HOLDS ENUMERATED): 1. Make a reservation of two of the Serial Items for the Borrower and the Child, totaling 4 reservations. 2. Check-in the reserved books to make sure an Item-level hold is in place and real Items match the reservations. 3. Both the Borrower and Child have an enumchron (enumeration or chronology) after the title component of the Item's title-column in their "Holds"-tab in circ/circulation.pl and members/moremember.pl TEST PLAN (CHECKOUTS ENUMERATED): 4. Make two arbitrary check-outs for the Parent and the Child. 5. In the "Checkouts"-tab, observe the two Items having an enumchron and two items without. 6. In the "Relatives' checkouts"-tab observe that the Child of the Parent and the Parent of the Child can see the enumchrons on their relatives' loans. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 15:46:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 14:46:45 +0000 Subject: [Koha-bugs] [Bug 13430] Serial enumeration not visible when handling Serial Items. Show enumerations for Serial Items in the circ- and member-modules. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13430 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #3 from Olli-Antti Kivilahti --- Added an alternative "Simple version" where no extra column is added like in the opac it is, but simply the enumchron is appended after the title. Use only the other version. not both! This is because the initial commit is not compatible with 3.16.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 16:17:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 15:17:13 +0000 Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 Winona Salesky changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wsalesky at gmail.com --- Comment #2 from Winona Salesky --- Hi, I am working on the XSLT and would like to know how users feel about displaying subfield h separated from the title. Perhaps next to the Medium label, rather then suppressing it. Example below: Concerto for orchestra ; Music for strings, percussion & celesta [sound recording] / B?la Bart?k. Author(s): Bart?k, B?la. Additional author(s): Bernstein, Leonard; Bart?k, B?la; New York Philharmonic [prf]. Would become: Concerto for orchestra ; Music for strings, percussion & celesta / B?la Bart?k. Author(s): Bart?k, B?la. Additional author(s): Bernstein, Leonard; Bart?k, B?la; New York Philharmonic [prf]. Format: sound recording Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 16:23:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 15:23:41 +0000 Subject: [Koha-bugs] [Bug 12074] Filter duplicates when adding a full batch from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12074 --- Comment #11 from Olli-Antti Kivilahti --- Regarding Bug 13181 you should focus on the community effort of using MARC Modification Templates. My hack is obsoleted and will be replaced by the community tool. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 16:24:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 15:24:35 +0000 Subject: [Koha-bugs] [Bug 12074] Filter duplicates when adding a full batch from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12074 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|olli-antti.kivilahti at jns.fi |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 16:26:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 15:26:09 +0000 Subject: [Koha-bugs] [Bug 13181] Using Matchers to overlay existing biblios with incoming records. Make MARC transformations on need. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13181 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 16:26:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 15:26:18 +0000 Subject: [Koha-bugs] [Bug 13181] Using Matchers to overlay existing biblios with incoming records. Make MARC transformations on need. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13181 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |olli-antti.kivilahti at jns.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 16:29:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 15:29:52 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Winona Salesky changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wsalesky at gmail.com --- Comment #8 from Winona Salesky --- Any thoughts on where in the record display you would like to see the additional 700 information (Related works for 700$i and Contained works 700 at ind2=2). Perhaps following the "Other Title" display? Another question about the contained work display: How should s field be treated with a indicator 2 = 2 and a subfield i? Output twice? Once as Related Work, once as Contained Work? Just once as Contained Work? Television adaptation of (work): Kerman, Piper. Orange is the new black. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 16:31:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 15:31:35 +0000 Subject: [Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32547|0 |1 is obsolete| | --- Comment #12 from Olli-Antti Kivilahti --- Created attachment 34431 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34431&action=edit Bug 11677 - Limit to Only items currently available for loan or reference not working! This row: $availability_limit .= "( ( allrecords,AlwaysMatches='' not onloan,AlwaysMatches='') and (lost,st-numeric=0) )"; Causes all records in Zebra to be selected and removes records with even one item onloan (even if items would be available)! This is obviously wrong, but because Zebra (and not many other text indexers) cannot deal with (If undef)-search terms, a fix might be to set 952$q (onloan) datetime to 0000-00-00 instead of NULL in the DB. Then we could find Records with items where onloan is 0000-00-00. Comments out that Zebra availability search and deals with availability on Koha-side. Gets the branch or holdingbranch limit from opac-search.pl or search.pl and uses that to skip Zebra results which are onloan or notforloan. Updates the result set size when results are removed. Fixed a bug where pagination broke, due to the $results_hash->{'RECORDS'} -array getting populated always starting from 0, where it should have started from the given $offset. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 16:32:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 15:32:19 +0000 Subject: [Koha-bugs] [Bug 12074] Filter duplicates when adding a full batch from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12074 --- Comment #12 from Koha Team Lyon 3 --- In fact , the bug 13182 is most interesting for us. We want to keep the possibility to see the duplicates and to choose to order it when adding a full batch in a order. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 16:33:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 15:33:29 +0000 Subject: [Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #13 from Olli-Antti Kivilahti --- Hi there! We have this in production now for ~2-3 months. Works fine and doesn't cause too much of a slowdown. I recommend XSLT-magic to properly solve this issue. Back then I didn't know XSLT yet to make logic expressions with it but it would definetely be the best alternative. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 16:49:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 15:49:34 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 --- Comment #8 from Jonathan Druart --- Created attachment 34432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34432&action=edit Bug 13321: Csv export - Display rrp and ecost with and without taxes If a basketgroup is exported as a CSV file, both prices should be displayed to avoid confusion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 16:59:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 15:59:31 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 17:01:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 16:01:04 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34295|0 |1 is obsolete| | --- Comment #31 from Paola Rossi --- Created attachment 34433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34433&action=edit Bug 13371: Add filters on the supplier list view Today I've applied the patches [13369,13370,13371 7] against master 3.19.00.000 Thanks, Jonathan: everything is ok! So I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 17:01:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 16:01:34 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34296|0 |1 is obsolete| | --- Comment #32 from Paola Rossi --- Created attachment 34434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34434&action=edit Bug 13371: Reintroduce the action buttons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 17:02:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 16:02:45 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34297|0 |1 is obsolete| | --- Comment #33 from Paola Rossi --- Created attachment 34435 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34435&action=edit Bug 13371: Add a filter for opened baskets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 17:03:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 16:03:13 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34298|0 |1 is obsolete| | --- Comment #34 from Paola Rossi --- Created attachment 34436 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34436&action=edit Bug 13371: change the filters wording -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 17:03:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 16:03:46 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34423|0 |1 is obsolete| | --- Comment #35 from Paola Rossi --- Created attachment 34437 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34437&action=edit Bug 13371: List suppliers even if they don't have basket. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 17:04:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 16:04:24 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34424|0 |1 is obsolete| | --- Comment #36 from Paola Rossi --- Created attachment 34438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34438&action=edit Bug 13371: Fix filtering on numbers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 17:04:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 16:04:59 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34425|0 |1 is obsolete| | --- Comment #37 from Paola Rossi --- Created attachment 34439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34439&action=edit Bug 13371: Move firstname and surname closer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 17:09:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 16:09:21 +0000 Subject: [Koha-bugs] [Bug 12922] Do not DIE the advance_notices.pl -cronjob if "no letter of * type" is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12922 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31614|0 |1 is obsolete| | --- Comment #3 from Olli-Antti Kivilahti --- Created attachment 34440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34440&action=edit Bug 12922 - Do not DIE the advance_notices.pl -cronjob if no letter of type is found!! We failed to deliver advance_notices because a template for sms's is undefined, because we don't support sending sms' as advance_notice. This crashed the cronjob because digests are set to die instead of the warn used in non-digest. And we get angry customers asking for compensation! This patch replaces the die with warn. TEST PREPARATION: 0. Edit the ODUEDGST letter, find an undefined letter for any trasport type. TEST PLAN: 1. Find a borrower and from the messaging preferences set the "Advance notice" transport type to the undefined digest. Set the "Days in Advance" to 1. 2. Check-out something for that borrower and set the due date for tomorrow. 3. Run "misc/cronjobs/advance_notices.pl -c -n -v" from the terminal. 4. BEFORE THIS PATCH: You get an error "No circulation PREDUEDGST letter transported by sms at /home/koha/kohaclone/C4/Letters.pm line 609." and the script dies. 4. AFTER THIS PATCH: You get an error "No circulation PREDUEDGST letter transported by sms at /home/koha/kohaclone/C4/Letters.pm line 609." but the script keep on going! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 17:10:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 16:10:20 +0000 Subject: [Koha-bugs] [Bug 12922] Do not DIE the advance_notices.pl -cronjob if "no letter of * type" is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12922 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 17:16:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 16:16:41 +0000 Subject: [Koha-bugs] [Bug 12923] Improve error logging for advance_notices.pl; Show borrowernumber when no letter of type is found and force utf8 output. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12923 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31615|0 |1 is obsolete| | --- Comment #3 from Olli-Antti Kivilahti --- Created attachment 34441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34441&action=edit Bug 12923 - Improve error logging for advance_notices.pl; Show borrowernumber when no letter of type is found and force utf8 output. when running advance_notices.pl with -n flag, diacritics run awol in the console output! Also when debugging which borrower requests undefined letter templates, it is very handy to log the borrowernumber so we catch and fix bad borrower message transport settings. This patch fixes those issues. TEST PREPARATION: 0. Edit the ODUEDGST letter, find an undefined letter for any trasport type. ::TESTS ARE (ALMOST) THE SAME AS IN bugg 12922:: TEST PLAN: 1. Find a borrower and from the messaging preferences set the "Advance notice" transport type to the undefined digest. Set the "Days in Advance" to 1. 2. Check-out something for that borrower and set the due date for tomorrow. 3. Run "misc/cronjobs/advance_notices.pl -c -n -v" from the terminal. 4. BEFORE THIS PATCH: You get an error "no letter of type 'PREDUEDGST' found. Please see sample_notices.sql at ./advance_notices.pl line 366." 4. AFTER THIS PATCH: You get an error "no letter of type 'PREDUEDGST' found for borrowernumber 1104659. Please see sample_notices.sql at ./advance_notices.pl line 368." Makes life more worth living for! Also diacritics printed on screen are displayed properly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 17:17:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 16:17:39 +0000 Subject: [Koha-bugs] [Bug 12923] Improve error logging for advance_notices.pl; Show borrowernumber when no letter of type is found and force utf8 output. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12923 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #4 from Olli-Antti Kivilahti --- Having this in production for 3+ months already. Let me know of any bugs ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 17:18:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 16:18:03 +0000 Subject: [Koha-bugs] [Bug 12922] Do not DIE the advance_notices.pl -cronjob if "no letter of * type" is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12922 --- Comment #4 from Olli-Antti Kivilahti --- Having this in production for 3+ months already. Let me know of any bugs ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 17:22:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 16:22:54 +0000 Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 --- Comment #3 from Winona Salesky --- That label should be: Medium: sound recording -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 17:25:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 16:25:29 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #99 from Colin Campbell --- (In reply to Brendan Gallagher from comment #98) > Everything works great. > > Questions for Colin or Martin - "EDIfact messages Manage EDIfact > transmissions" That is found in the Tools section of koha. But I think > you've moved that functionality into ACQ, so I think that can just be > ignored and removed now. Answer that question for me and I'll sign-off. I > think that a QA follow-up of just removing that from the Koha Tools and we > are golden. > > Great Job. Thanks Yes edifact message handling should all be under ACQ now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 17:35:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 16:35:04 +0000 Subject: [Koha-bugs] [Bug 12086] Hold priorities incorrect, when waiting status was reversed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12086 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers at biblibre.co | |m --- Comment #26 from Fridolin SOMERS --- Pushed to 3.14.x, will be in 3.14.12. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 17:37:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 16:37:06 +0000 Subject: [Koha-bugs] [Bug 12396] MTT FIX: Due notices (DUEDGST) are multiplicated and everybodys all ODUEDGST are sent to everyone who should receive them. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12396 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |fridolyn.somers at biblibre.co | |m Resolution|--- |FIXED --- Comment #8 from Fridolin SOMERS --- Depends on Bug 10833, not in 3.14, so I set has resolved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 17:45:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 16:45:43 +0000 Subject: [Koha-bugs] [Bug 11014] Slip Print Problem in Chrome In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11014 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #13 from Fridolin SOMERS --- Pushed to 3.14.x, will be in 3.14.12. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 17:49:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 16:49:37 +0000 Subject: [Koha-bugs] [Bug 12025] Inventory tool fails with "Could not reads headers", or sometimes a timeout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12025 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #16 from Fridolin SOMERS --- Pushed to 3.14.x, will be in 3.14.12. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 17:55:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 16:55:27 +0000 Subject: [Koha-bugs] [Bug 5927] Show series information in OPAC search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5927 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #1 from Nicole C. Engard --- I have libraries that would also like to see the series info displayed in both the staff and OPAC results/details. Nicole -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 19:29:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 18:29:50 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 --- Comment #13 from Jacek Ablewicz --- Not sure how proceed with this one.. I have to admit removing fastmmap caching completely is kinda tempting, but OTOH it's not too hard to imagine some setups where such caching system would be quite beneficial performace-wise. What if we: 1) do not load nor intialize the Cache::FastMmap module, unless such caching system is explicitly requested by the user (CACHING_SYSTEM=fastmmap_cache) 2) also do not load it when $ENV{GATEWAY_INTERFACE} is not defined 3) include _both_ the UID and the database name in the /tmp sharemap file name That way it: - would still be a trival patch, - this feature will remain available for the people who really want/need it - and (unless I'm very much mistaken) it should cover almost 100% of the problematic cases (?). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 20:38:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 19:38:07 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED CC| |chris at bigballofwax.co.nz --- Comment #14 from Chris Cormack --- (In reply to Jacek Ablewicz from comment #13) > Not sure how proceed with this one.. I have to admit removing fastmmap > caching completely is kinda tempting, but OTOH it's not too hard to imagine > some setups where such caching system would be quite beneficial > performace-wise. What if we: > > 1) do not load nor intialize the Cache::FastMmap module, unless such caching > system is explicitly requested by the user (CACHING_SYSTEM=fastmmap_cache) > 2) also do not load it when $ENV{GATEWAY_INTERFACE} is not defined > 3) include _both_ the UID and the database name in the /tmp sharemap file > name > > That way it: > - would still be a trival patch, > - this feature will remain available for the people who really want/need it > - and (unless I'm very much mistaken) it should cover almost 100% of the > problematic cases (?). That is a good start, and couple it with the moving the cache conf back to koha-conf.xml and out of env variables (bug 11921) and we would have a less error prone and less confusing set up. But doing a patch like you suggest, will fix this bug, and then 11921 can follow on -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 20:39:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 19:39:10 +0000 Subject: [Koha-bugs] [Bug 13436] Add more options to UsageStatsLibraryType In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13436 Elaine Bradtke changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eb at efdss.org --- Comment #3 from Elaine Bradtke --- Other types: At the least you should add something like 'Special' (this would cover a lot of territory) Others that might be useful Research Private Society or Association Corporate Government Religious organization (or something similar?) Subscription -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 20:42:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 19:42:07 +0000 Subject: [Koha-bugs] [Bug 13436] Add more options to UsageStatsLibraryType In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13436 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |aleishaamohia at hotmail.com, | |chris at bigballofwax.co.nz --- Comment #4 from Chris Cormack --- Aleisha is going to do some work on this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 21:48:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 20:48:56 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #596 from Martin Renvoize --- Is this re-write meant to deprecate the 'accountlines' table? If so, there are still a few references to it that I can see... and the table is still present after the updatedb run: 1) C4/Reports/Guided.pm 2) C4/Overdues.pm 3) offline_circ/download.pl And a few tests ;) 1) /db_dependent/Circulation_Branch.t 2) /db_dependent/Members.t 3) /db_dependent/Circulation_issue.t -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 22:03:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 21:03:10 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #4 from Barton Chittenden --- I tried to run the test plan, on step 4, I got a 404: http:// ... /cgi-bin/koha/members/print_overdues.pl?borrowernumber=220 The file print_overdues.pl does not exist. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 22:13:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 21:13:30 +0000 Subject: [Koha-bugs] [Bug 13468] New: overdue notice lists all checked out books Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13468 Bug ID: 13468 Summary: overdue notice lists all checked out books Change sponsored?: --- Product: Koha Version: 3.18 Hardware: PC OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: yhager at yhager.com QA Contact: testopia at bugs.koha-community.org I noticed this after upgrading to 3.18.1 (from 3.16). If a patron has overdue items, they receive the overdue notice, but the list of overdue items includes all the books they have checked out, not only the overdue ones. I also get this error on the cron run, not sure if it's related: Use of uninitialized value $borrowernumber in string eq at /usr/share/koha/bin/cronjobs/overdue_notices.pl line 544. Installed on Debian from the koha repositories. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 22:52:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 21:52:46 +0000 Subject: [Koha-bugs] [Bug 2505] enable Perl warnings in all modules and scripts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 Andrew Maguire changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ajm1170 at gmail.com --- Comment #23 from Andrew Maguire --- Created attachment 34442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34442&action=edit Update to C4::Ris.pm Have applied the strict and warning pragmas to C4::Ris.pm Slight side-effect that the AU output may now be normalised as whitespace is removed - I used book ISBN 0340201126 as test case. During testing, discovered the charconv() function is a no-op, so I wondered what should happen if database is in MARC8 (non-UTF) format. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 23:55:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 22:55:52 +0000 Subject: [Koha-bugs] [Bug 13436] Add more options to UsageStatsLibraryType In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13436 --- Comment #5 from Aleisha Amohia --- Created attachment 34443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34443&action=edit Bug 13436: Adding more options to UsageStatsLibraryType syspref Added options: - research - private - society or association - corporate - government - religious organization - subscription Also changed 'university' to 'academic' To test: 1) Go on to Global System Preferences and find UsageStatsLibraryType under Administration 2) Click drop-down menu and see all new options described above, as well as 'academic' instead of 'university' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 15 23:56:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Dec 2014 22:56:42 +0000 Subject: [Koha-bugs] [Bug 13436] Add more options to UsageStatsLibraryType In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13436 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 01:57:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 00:57:39 +0000 Subject: [Koha-bugs] [Bug 4373] Placing and Processing Items Simultaneously causes multiple issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4373 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #2 from Chris Cormack --- Yes still a problem -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 02:45:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 01:45:38 +0000 Subject: [Koha-bugs] [Bug 13469] New: Unapi path to XSLTs is wrong in OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13469 Bug ID: 13469 Summary: Unapi path to XSLTs is wrong in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Currently, Unapi points to C4::Context->config('intranetdir')."/koha-tmpl/intranet-tmpl/prog/en/xslt/". However, it should point to C4::Context->config('intrahtdocs')."/prog/en/xslt/". The first path is set up just to work with a Git install, while the latter will work on every install. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 02:45:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 01:45:59 +0000 Subject: [Koha-bugs] [Bug 13469] Unapi path to XSLTs is wrong in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13469 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 03:04:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 02:04:20 +0000 Subject: [Koha-bugs] [Bug 13469] Unapi path to XSLTs is wrong in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13469 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 03:04:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 02:04:23 +0000 Subject: [Koha-bugs] [Bug 13469] Unapi path to XSLTs is wrong in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13469 --- Comment #1 from David Cook --- Created attachment 34444 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34444&action=edit Bug 13469 - Unapi path to XSLTs is wrong in OPAC The Unapi path to XSLTs is wrong in the OPAC. Unfortunately, it's coded to work just for Git installs, which makes it tough to test. _TEST PLAN_ Before applying: 1) Go to http://GIT-INSTALL/cgi-bin/koha/unapi?id=koha:biblionumber:1&format=oai_dc 2) If the biblionumber exists, it should show you the record in OAI_DC format. 3) Go to http://REGULAR-INSTALL/cgi-bin/koha/unapi?id=koha:biblionumber:1&format=oai_dc 4) You should get a software error Apply the patch. After applying: 1) Refresh the page for http://yourgitinstall/cgi-bin/koha/unapi?id=koha:biblionumber:1&format=oai_dc 2) It should work exactly the same as before. Thorough testers: 1) Push the code to that regular test install 2) Try the link again. It will properly show the converted record now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 07:14:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 06:14:46 +0000 Subject: [Koha-bugs] [Bug 9958] RoutingSerials desription misleading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9958 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 07:14:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 06:14:48 +0000 Subject: [Koha-bugs] [Bug 9958] RoutingSerials desription misleading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9958 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34023|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 34445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34445&action=edit Bug 9958: Improve RoutingSerials sys pref description The RoutingSerials preference controls if the routing list related functionality is visible in the serials module. To test: - Go to the system preference editor - RoutingSerials - Check the current description - Apply patch - Check the new description - Verify functionality matches description NOTE: The preference change is merely cosmetic. The value is still YesNo. A few git reset --hard origin/master and page refreshes confirmed expected values. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 07:23:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 06:23:02 +0000 Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 --- Comment #23 from David Cook --- (In reply to Brendan Gallagher from comment #17) > So this one has been sitting there for 1 months time. I've done some full > out testing and I am passing this. Since this was done by Kyle I would > encourage another QA to look at this too, if you have the time. Release > manager if you feel that this must have another QA, let me know and I'll see > who I can bug. This is pretty solid though and I think it would be ok to > push. I leave that up to you all - and will acceptable whatever is decided. > (My Goal is to just get a little more attention to this) > > Thanks, > Brendan Gallagher Thanks for posting this Brendan! I'll be so glad when this finally gets through. Martin recently suggested that I should join the QA team. When he suggested it, I didn't think I had the time, but that would've come in handy about now. Hope this gets the attention it deserves! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 07:32:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 06:32:11 +0000 Subject: [Koha-bugs] [Bug 13416] Typo in marc21_leader.pl position 5 (record status) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 --- Comment #2 from M. Tompsett --- Created attachment 34446 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34446&action=edit Bug 13416: Follow-up fix whitespace issues First patch failed koha qa tests due to white space issues. This patch corrects it. TEST PLAN --------- 1) Apply first patch 2) run koha qa test tools -- fails line 19 and 21 3) apply this patch 4) run koha qa test tools -- passes I'll leave this as needing sign off, just so that Marcel can confirm this patch is good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 07:32:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 06:32:43 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #597 from Martin Renvoize --- Comment on attachment 34204 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34204 Bug 6427 - Update database Review of attachment 34204: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6427&attachment=34204) ----------------------------------------------------------------- ::: installer/data/mysql/updatedatabase.pl @@ +9709,5 @@ > + 'W' => Koha::Accounts::CreditTypes::WriteOff, > + 'C' => Koha::Accounts::CreditTypes::Credit, > + 'CR' => Koha::Accounts::CreditTypes::Credit, > + }; > + Should there be any additional handling for existing authorised values for types here... ? @@ +9767,5 @@ > + } > + ); > + } > + } > + Should there also be a 'DROP TABLE accountlines' somewhere in here...? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 07:34:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 06:34:34 +0000 Subject: [Koha-bugs] [Bug 13416] Typo in marc21_leader.pl position 5 (record status) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34217|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 34447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34447&action=edit [SIGNED OFF] Bug 13416: Typo in marc21_leader.pl position 5 (record status) Instead of a space in the leader on this position, it should be an a. Test plan: 1) Log in to staff client 2) Find a record in the catalog 3) Edit the record 4) Click the on builder popup icon. 5) View the page source -- the option is " " for the 'a- Increase in encoding level' entry. It really should be 'a'. 6) Apply patch. 7) Repeat steps 1-5 -- the option should be 'a' this time. 8) Run koha qa test tools. -- Discovered it failed. Provided a patch to fix this. It does, however, solve the major problem of ' ' vs. 'a'. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 07:35:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 06:35:13 +0000 Subject: [Koha-bugs] [Bug 13416] Typo in marc21_leader.pl position 5 (record status) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34446|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 34448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34448&action=edit Bug 13416: Follow-up fix whitespace issues First patch failed koha qa tests due to white space issues. This patch corrects it. TEST PLAN --------- 1) Apply first patch 2) run koha qa test tools -- fails line 19 and 21 3) apply this patch 4) run koha qa test tools -- passes I'll leave this as needing sign off, just so that Marcel can confirm this patch is good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 07:48:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 06:48:13 +0000 Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7981 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 07:48:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 06:48:13 +0000 Subject: [Koha-bugs] [Bug 7981] Remove HomeOrHoldingBranchReturn syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED CC| |mtompset at hotmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8836 --- Comment #25 from M. Tompsett --- I'm moving this back to assigned, because I noticed some rotating collections variable was lost. This might not reflect that changes made in bug 8836. Please check, and either change to needs sign off if the changes are reflected OR fix and then change to needs sign off. This was just a quick eyeball. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 07:54:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 06:54:24 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #4 from M. Tompsett --- Comment on attachment 33918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33918 Bug 1985 - Email notification of new OPAC comments Review of attachment 33918: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=1985&attachment=33918) ----------------------------------------------------------------- ::: C4/Review.pm @@ +81,4 @@ > (?,?,?,0,now())"; > my $sth = $dbh->prepare($query); > $sth->execute( $borrowernumber, $biblionumber, $review); > + I hope this isn't white space. Please consider: git config --global core.whitespace trailing-space,space-before-tab git config --global apply.whitespace fix @@ +203,5 @@ > + my $borrowernumber = shift; > + > + my $moderatorEmail = C4::Context->preference('CommentModeratorsEmail'); > + if (not($moderatorEmail)) { > + return undef; I think this will fail the koha qa tests. No need to be explicit with the undef; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 07:55:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 06:55:05 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset at hotmail.com --- Comment #5 from M. Tompsett --- See my comments in comment 4 as to why I changed this to Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 09:05:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 08:05:01 +0000 Subject: [Koha-bugs] [Bug 13436] Add more options to UsageStatsLibraryType In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13436 --- Comment #6 from Katrin Fischer --- Hi Aleisha - thx for the patch! Reading the list this morning I think school might be another good addition. Can someone explain what subscription is in this context? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 09:20:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 08:20:48 +0000 Subject: [Koha-bugs] [Bug 13468] overdue notice lists all checked out books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13468 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I Yuval, can you tell us a bit about your setup? How is the overdues script run in your installation? The script has several options that can be used, so knowing what happens on your system might help to get this fixed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 09:54:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 08:54:28 +0000 Subject: [Koha-bugs] [Bug 13398] Perl files for rotating collections are missing in installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13398 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34391|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 34449 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34449&action=edit [PASSED QA] Bug 13398: rotating collections scripts are skipped on install This patch makes the Makefile.PL script pick the rotating_collections/ directory for install. To test: - Run: $ perl Makefile.PL - Install using either 'standard' or 'single' method. => FAIL: Verify that there is no 'rotating_collections' directory on the intranet CGI direcory. - Apply the patch - Run: $ perl Makefile.PL - Install using either 'standard' or 'single' method. => SUCCESS: Verify that there is a 'rotating_collections' directory on the intranet CGI direcory. - Sign off :-D Regards Tomas PS1: Note that it should be enough to check for the rotating_collections files on the generated Makefile after 'perl Makefile.PL'. PS2: The packages use the 'standard' install method to generate the file tree. So this patch should fix the packages too. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 09:54:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 08:54:26 +0000 Subject: [Koha-bugs] [Bug 13398] Perl files for rotating collections are missing in installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13398 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 09:57:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 08:57:08 +0000 Subject: [Koha-bugs] [Bug 13398] Perl files for rotating collections are missing in installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13398 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- Works as expected.. even built a package with it for the belt and braces approach. As a side note, this just highlights the need for better packages testing.. there been a few of these with this release.. Sorry Tomas, I'll try harder as one of the few package testers in the future. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 10:02:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 09:02:30 +0000 Subject: [Koha-bugs] [Bug 13461] Circ always asking for confirmation if RentalFeesCheckoutConfirmation is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13461 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34415|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 34450 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34450&action=edit [PASSED QA] Bug 13461 - Circ always asking for confirmation if RentalFeesCheckoutConfirmation is used To test: - Check RentalFeesCheckoutConfirmation is activated - Try to check out an item without rental fine - Verify confirmation message without explanation is shown - Apply patch - Verify confirmation message is no longer shown - Configure itemtype to have rental fee - Veirfy now the confirmation message appears as it should Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 10:02:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 09:02:27 +0000 Subject: [Koha-bugs] [Bug 13461] Circ always asking for confirmation if RentalFeesCheckoutConfirmation is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13461 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 10:03:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 09:03:40 +0000 Subject: [Koha-bugs] [Bug 13461] Circ always asking for confirmation if RentalFeesCheckoutConfirmation is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13461 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- Works as expected, super trivial but super needed patch.. Passing QA Thanks Katrin :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 10:26:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 09:26:07 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #598 from Martin Renvoize --- The installer wizard currently gives the below error with these patches: ERROR 1064 (42000) at line 3466: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'account_credits ( credit_id int(11) NOT NULL AUTO_INCREMENT, borrow' at line 1 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 12:03:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 11:03:41 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #15 from Paola Rossi --- I've tried to apply the 2 attached patches against master 3.19.00.000 At the first patch : Applying: camelot 778 lbo_RM5001_Bordereau / BZ11882 fix fatal: sha1 information is lacking or useless (circ/circulation.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 camelot 778 lbo_RM5001_Bordereau / BZ11882 fix So I pass the patch to "Patch doesn't apply" status. [I'm in doubt: perhaps should I have applied only the second attached patch to master?] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 12:40:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 11:40:19 +0000 Subject: [Koha-bugs] [Bug 13470] New: pay fines with extended borrower attributes result in application error Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13470 Bug ID: 13470 Summary: pay fines with extended borrower attributes result in application error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: dpavlin at rot13.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Can't call method "param" on an undefined value at /srv/koha_ffzg/members/paycollect.pl line 182. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 12:40:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 11:40:47 +0000 Subject: [Koha-bugs] [Bug 13470] pay fines with extended borrower attributes result in application error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13470 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |dpavlin at rot13.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 12:52:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 11:52:43 +0000 Subject: [Koha-bugs] [Bug 13470] pay fines with extended borrower attributes result in application error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13470 --- Comment #1 from Dobrica Pavlinusic --- Created attachment 34451 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34451&action=edit Bug 13470 - pay fines with extended borrower attributes result in application error Test scenario: 1. ensure that extended patron attributes are turned on in system preferences 2. find borrower which has fine to pay, and click on pay button 3. verify application error 4. apply patch and verify that application error is gone -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 12:52:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 11:52:40 +0000 Subject: [Koha-bugs] [Bug 13470] pay fines with extended borrower attributes result in application error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13470 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 12:59:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 11:59:33 +0000 Subject: [Koha-bugs] [Bug 13416] Typo in marc21_leader.pl position 5 (record status) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34447|0 |1 is obsolete| | Attachment #34448|0 |1 is obsolete| | --- Comment #5 from M. de Rooy --- Created attachment 34452 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34452&action=edit Bug 13416: Typo in marc21_leader.pl position 5 (record status) Instead of a space in the leader on this position, it should be an a. Test plan: 1) Log in to staff client 2) Find a record in the catalog 3) Edit the record 4) Click the on builder popup icon. 5) View the page source -- the option is " " for the 'a- Increase in encoding level' entry. It really should be 'a'. 6) Apply patch. 7) Repeat steps 1-5 -- the option should be 'a' this time. 8) Run koha qa test tools. -- Discovered it failed. Provided a patch to fix this. It does, however, solve the major problem of ' ' vs. 'a'. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 12:59:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 11:59:31 +0000 Subject: [Koha-bugs] [Bug 13416] Typo in marc21_leader.pl position 5 (record status) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 13:00:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 12:00:49 +0000 Subject: [Koha-bugs] [Bug 13416] Typo in marc21_leader.pl position 5 (record status) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 --- Comment #6 from M. de Rooy --- Thanks, Mark. Caused by a tab. When I apply it again, it gets converted into spaces, and the second patch is no longer needed (and not working anymore). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 13:30:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 12:30:02 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34323|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 13:37:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 12:37:56 +0000 Subject: [Koha-bugs] [Bug 13469] Unapi path to XSLTs is wrong in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13469 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 13:39:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 12:39:57 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 --- Comment #15 from Jacek Ablewicz --- Created attachment 34453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34453&action=edit Bug 13431 - Shared FastMmap file causes issues Koha::Cache package does not take into account that, when using fastmmap caching variant, mmaped cache file created in /tmp (typically: /tmp/sharefile-koha-koha), would only be further accessible to the one given OS user - the one which created it. In many Koha setups, in the circumstances when various system scripts are executed by 2+ users with diffrent UIDs (like multi-tenant servers, for example) this may cause many kinds of issues. Observable symptom is usually the appearance of the below error when searching, or looking at MARC Framework pages and a few other places: Open of share file /tmp/sharefile-koha-koha failed: Permission denied at /usr/lib/perl5/Cache/FastMmap.pm line 640. This patch: - disables initialisation of fastmmap caching subsystem unless it is explicitly requested by the user (CACHING_SYSTEM=fastmmap) - disables fastmmap cache usage for command line scripts (i.e. when GATEWAY_INTERFACE environment variable is not defined) - adds the database name, host name and an ID of the OS user to the mmaped file name created in /tmp, to prevent various kinds of unintentional conflicts and/or permission problems from happening To test: 1) remove the /tmp/sharefile-koha-* file[s] (if any) 2) do something which would lead to its re-creation (e.g., performing any search in OPAC should be sufficient to cause that) 3) observe that /tmp/sharefile-koha-koha got created 4) remove it 5) apply patch 6) redo step 2) 7) observe that aforementioned file is no longer created in /tmp 8) set CACHING_SYSTEM environment variable to 'fastmmap' 9) redo step 2), observe that /tmp/sharefile-koha-* file got created and that it's name now contains hostname, database name and UID 10) ensure that everything still works like it should and that there are no regressions of any kinds anywhere in the system ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 13:40:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 12:40:27 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 14:00:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 13:00:10 +0000 Subject: [Koha-bugs] [Bug 13471] New: When editing a subscription, the "subscription length type" disregards the stored value, also make SLT translateable. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13471 Bug ID: 13471 Summary: When editing a subscription, the "subscription length type" disregards the stored value, also make SLT translateable. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com This issue causes loss of data when the subscription length type (SLT) is other than issues. TO REPLICATE: We make an subscription with SLT of months = 12. Later make an arbitrary edit to the subscription, and miss out the fact that the SLT selection is set to issues. Save the changes. Serial subscription end date is set to 12 issues since the start date, instead of 12 months which it used to be. This causes a myriad of issues :=) AFTER THIS PATCH: SLT defaults to the value initially saved instead of always being issues. Now the selection can be translated! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 14:04:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 13:04:51 +0000 Subject: [Koha-bugs] [Bug 13471] When editing a subscription, the "subscription length type" disregards the stored value, also make SLT translateable. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13471 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 34454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34454&action=edit Bug 13471 - When editing a subscription, the "subscription length type" disregards the stored value, also make SLT translateable. This issue causes loss of data when the subscription length type (SLT) is other than issues. TO REPLICATE: We make an subscription with SLT of months = 12. Later make an arbitrary edit to the subscription, and miss out the fact that the SLT selection is set to issues. Save the changes. Serial subscription end date is set to 12 issues since the start date, instead of 12 months which it used to be. This causes a myriad of issues :=) AFTER THIS PATCH: SLT defaults to the value initially saved instead of always being issues. Now the selection can be translated! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 14:05:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 13:05:28 +0000 Subject: [Koha-bugs] [Bug 13471] When editing a subscription, the "subscription length type" disregards the stored value, also make SLT translateable. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13471 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |olli-antti.kivilahti at jns.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 14:19:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 13:19:55 +0000 Subject: [Koha-bugs] [Bug 13471] When editing a subscription, the "subscription length type" disregards the stored value, also make SLT translateable. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13471 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34454|0 |1 is obsolete| | --- Comment #2 from Olli-Antti Kivilahti --- Created attachment 34455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34455&action=edit Bug 13471 - When editing a subscription, the "subscription length type" disregards the stored value, also make SLT translateable. This issue causes loss of data when the subscription length type (SLT) is other than issues. TO REPLICATE: We make an subscription with SLT of months = 12. Later make an arbitrary edit to the subscription, and miss out the fact that the SLT selection is set to issues. Save the changes. Serial subscription end date is set to 12 issues since the start date, instead of 12 months which it used to be. This causes a myriad of issues :=) AFTER THIS PATCH: SLT defaults to the value initially saved instead of always being issues. Now the selection can be translated! HOTFIX 1: Added elements to showSubscriptionLengthType.inc so the translation tool can catch them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 14:29:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 13:29:53 +0000 Subject: [Koha-bugs] [Bug 11642] Batch patron deletion/anonymization should not allow permanent destruction of patron data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11642 --- Comment #5 from Kyle M Hall --- I've seen serious data loss because of bugs/misuse in the batch patron tools. I think it would be much better for all interactive Koha patron deletes to move them to deleted, and then have cleanup_database.pl delete them permanently. That way we have the most flexibility and safety possible. (In reply to Chris Cormack from comment #2) > Records and items aren't interesting to the FBI in the same way patron data > is. > I can see that as a valid reason for deleting them completely. > > Perhaps a better response is to do a "Are you sure you want to delete > permanently .. there is no way to get them back?" > > Confirmation prompt is a better way than disabling this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 15:28:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 14:28:07 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #38 from Paola Rossi --- I've applied the patches against master 3.19.00.000 About : >Test plan: >1/ Execute the updatedb entry and verify you have a new notification template in your table (tools/letter.pl). >code: ACQ_NOTIF_ON_RECEIV, module: acquisition I saw that the module is acquisition, OK >2/ You can edit it if you want I saw that the "Koha module" is "Catalog" ERROR, while "Acquisition" is not an available option in the drop down list. On MASTER, in effect, the available modules are 8, and none of them is "Acquisition". So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 15:46:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 14:46:27 +0000 Subject: [Koha-bugs] [Bug 9743] Allow customization for making hold notes required In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #31 from M. de Rooy --- This still needs a follow-up for a deselected biblio with notes in case of multiple holds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 15:46:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 14:46:58 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31638|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 34456 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34456&action=edit Bug 12933 - Add ability to print overdue slip from staff intranet Some librarians would like to be able to print an overdues slip from the staff intranet. This slip would be defined as the print transport version of the ODUE slip. Test Plan: 1) Apply this patch 2) Locate a patron with overdues 3) Define a print version of the OVERDUES_SLIP slip 4) Try Print > Print overdues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 15:47:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 14:47:03 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #6 from Kyle M Hall --- Created attachment 34457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34457&action=edit Bug 12933 - Add new OVERDUES_SLIP letter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 15:49:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 14:49:48 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27900|0 |1 is obsolete| | Attachment #27901|0 |1 is obsolete| | Attachment #27902|0 |1 is obsolete| | Attachment #27993|0 |1 is obsolete| | Attachment #27995|0 |1 is obsolete| | --- Comment #56 from Kyle M Hall --- Created attachment 34458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34458&action=edit Bug 11559 - Supporting changes for Rancor * Extends login screen to pass along #hash * Adds JSONP support to C4::Service * Extends humanmsg to allow per-message classes * Adds proper charset to results of svc/bib -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 15:49:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 14:49:44 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 15:50:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 14:50:09 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34458|0 |1 is obsolete| | --- Comment #57 from Kyle M Hall --- Created attachment 34459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34459&action=edit Bug 11559 - Supporting changes for Rancor * Extends login screen to pass along #hash * Adds JSONP support to C4::Service * Extends humanmsg to allow per-message classes * Adds proper charset to results of svc/bib -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 15:50:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 14:50:18 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #58 from Kyle M Hall --- Created attachment 34460 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34460&action=edit Bug 11559 - New libraries for Rancor Adds the following JS libraries: * CodeMirror - extensible text editor * FileSaver - shim for saving files * pz2 - library for connecting to pazpar2 * require - dependency resolver and module loader -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 15:50:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 14:50:23 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #59 from Kyle M Hall --- Created attachment 34461 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34461&action=edit Bug 11559 - Rancor: professional cataloging interface Test plan: 1. Apply patches for bug 10486 and this bug. 2. Reinstall patches for pazpar2. 3. Switch back and forth between basic and advanced editor, and verify that preference is saved (by workstation, not user. 4. Enter in a record (with all required fields). 5. Save to ISO2709, MARCXML and catalog, verify that all three match. 6. Import a MARCXML and ISO2709 record, and verify that the record is correct after import. 7. Run keyword and advanced searches with a variety of Z39.50 servers to check that searching is correct, and try to both import records as new records and substitute them for the contents of existing records. 8. Create, edit and delete macros, verifying that they are autosaved. 9. Try running macros (example follows). 10. Try enabling and disabling fixed-field widgets and customizing fonts, and test the editor afterwards. Example macro: goto field 003 copy field data insert new field 040 data= goto subfield end insert new subfield a data= goto subfield a paste -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 15:50:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 14:50:26 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #60 from Kyle M Hall --- Created attachment 34462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34462&action=edit Bug 11559 followup - Allow insertion of dollar sign, remove fixFloat The dollar sign now shows up as {dollar} inside subfield contents. This is converted on load and save. Also, remove fixFloat, as it has moved and is no longer needed anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 15:50:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 14:50:35 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #61 from Kyle M Hall --- Created attachment 34463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34463&action=edit Bug 11559 followup - Remove pazpar2 search functionality for now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 16:40:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 15:40:54 +0000 Subject: [Koha-bugs] [Bug 13472] New: Chapter 14.1 Plugin System : Setup instructions are wrong Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13472 Bug ID: 13472 Summary: Chapter 14.1 Plugin System : Setup instructions are wrong Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: nengard at gmail.com Reporter: bob-ewart at bobsown.com QA Contact: testopia at bugs.koha-community.org The setup instructions should say: Change 0 to 1 in your koha-conf.xml file Once set up is complete you will need to alter your UseKohaPlugins system preference. On the Tools page you will see the Tools Plugins and on the Reports page you will see the Reports Plugins. The rest of the instructions have already been done by the installation. There is no "Plugins" option in the More menu. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 16:42:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 15:42:22 +0000 Subject: [Koha-bugs] [Bug 13470] pay fines with extended borrower attributes result in application error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13470 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |paola.rossi at cineca.it --- Comment #2 from Paola Rossi --- I've tried to create the error case on master 3.19.00.000, but I could not get the error. I had no error neither using "Pay", nor using "Pay amount" nor using "Pay selected" buttons. For now I pass the patch to the "In Discussion" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 16:57:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 15:57:05 +0000 Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 --- Comment #4 from Winona Salesky --- Created attachment 34464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34464&action=edit Bug 13381 [ENH] 245 field enhancements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 17:18:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 16:18:18 +0000 Subject: [Koha-bugs] [Bug 13468] overdue notice lists all checked out books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13468 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #2 from Martin Renvoize --- We're seeing this too now... /usr/share/koha/bin/cronjobs/overdue_notices.pl -t A quick look t the code, -t is 'triggered', and the last bug to touch that was Bug 12529. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 17:22:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 16:22:05 +0000 Subject: [Koha-bugs] [Bug 13473] New: Plugins fail in 3.18 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13473 Bug ID: 13473 Summary: Plugins fail in 3.18 Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: bob-ewart at bobsown.com QA Contact: testopia at bugs.koha-community.org Created attachment 34465 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34465&action=edit koha error log This was working in 3.16. I was able to enable plugins and upload the Kitchen-Sink plugin (see bug 13472 for the correct way to enable plugins.) When trying to execute or configure the plugin on 3.18 I got: Template process failed: file error - doc-head-open.inc: not found at /usr/share/koha/lib/C4/Templates.pm line 129. The koha error log is attached. It fails in 3.18 whether installed via command line (openSUSE 13.1) or apt-get (Debian 7). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 17:22:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 16:22:19 +0000 Subject: [Koha-bugs] [Bug 13473] Plugins fail in 3.18 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13473 Bob Ewart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob-ewart at bobsown.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 17:23:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 16:23:10 +0000 Subject: [Koha-bugs] [Bug 13472] Chapter 14.1 Plugin System : Setup instructions are wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13472 Bob Ewart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob-ewart at bobsown.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 17:29:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 16:29:46 +0000 Subject: [Koha-bugs] [Bug 13468] overdue notice lists all checked out books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13468 --- Comment #3 from Martin Renvoize --- (In reply to Martin Renvoize from comment #2) Our setting for 'OverduenoticeCalendar' was set to ignore if that helps -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 17:57:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 16:57:36 +0000 Subject: [Koha-bugs] [Bug 13468] overdue notice lists all checked out books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13468 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #4 from Chris Cormack --- (In reply to Martin Renvoize from comment #3) > (In reply to Martin Renvoize from comment #2) > Our setting for 'OverduenoticeCalendar' was set to ignore if that helps Can you bisect it until you find the commit for sure. Otherwise it'll have to wait for a while until I have any time to look at it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 18:21:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 17:21:03 +0000 Subject: [Koha-bugs] [Bug 13468] overdue notice lists all checked out books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13468 --- Comment #5 from Martin Renvoize --- Created attachment 34466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34466&action=edit BUG 13468: Overdue notice lists all checked out books This patch should fix the issue when running under 'triggered' mode To test: 1) Run overdue_notices.pl -t -n [to output notices to command line] 2) Note that the notices output, list ALL checked out items 3) Apply Patch 4) Run again 5) Note the difference -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 18:23:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 17:23:22 +0000 Subject: [Koha-bugs] [Bug 13468] overdue notice lists all checked out books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13468 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #6 from Martin Renvoize --- Sorry Chris, you beat me to this one. I believe this patch does the business... My fault for missing it during QA of your patch.. I'm pretty sure it's that Holidays patch that exposed the problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 18:25:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 17:25:05 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34456|0 |1 is obsolete| | Attachment #34457|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 34467 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34467&action=edit Bug 12933 - Add ability to print overdue slip from staff intranet Some librarians would like to be able to print an overdues slip from the staff intranet. This slip would be defined as the print transport version of the ODUE slip. Test Plan: 1) Apply this patch 2) Locate a patron with overdues 3) Define a print version of the OVERDUES_SLIP slip 4) Try Print > Print overdues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 18:25:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 17:25:12 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #8 from Kyle M Hall --- Created attachment 34468 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34468&action=edit Bug 12933 - Add new OVERDUES_SLIP letter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 18:45:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 17:45:46 +0000 Subject: [Koha-bugs] [Bug 13468] overdue notice lists all checked out books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13468 --- Comment #7 from Yuval Hager --- (In reply to Katrin Fischer from comment #1) > I Yuval, > > can you tell us a bit about your setup? How is the overdues script run in > your installation? The script has several options that can be used, so > knowing what happens on your system might help to get this fixed. This has probably been resolved, but I don't want to leave your question unanswered. I use the standard debian cron runs: koha-foreach --enabled --email /usr/share/koha/bin/cronjobs/overdue_notices.pl -t Thanks for the quick resolution! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 19:06:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 18:06:54 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34467|0 |1 is obsolete| | Attachment #34468|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 34469 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34469&action=edit Bug 12933 - Add ability to print overdue slip from staff intranet Some librarians would like to be able to print an overdues slip from the staff intranet. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 2) Locate a patron with overdues 4) Try Print > Print overdues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 19:08:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 18:08:27 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34469|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 34470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34470&action=edit Bug 12933 - Add ability to print overdue slip from staff intranet Some librarians would like to be able to print an overdues slip from the staff intranet. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 2) Locate a patron with overdues 4) Try Print > Print overdues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 19:08:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 18:08:33 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #11 from Kyle M Hall --- Created attachment 34471 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34471&action=edit Bug 12933 - Add new OVERDUES_SLIP letter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 19:20:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 18:20:14 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #12 from Barton Chittenden --- Test Plan: 1) Apply this patch 2) Run ./installer/data/mysql/updatedatabase.pl 3) Locate a patron with overdues 4) Try Print > Print overdues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 19:28:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 18:28:39 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #70 from simith.doliveira at inlibro.com --- Created attachment 34472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34472&action=edit SQL code in the .pl files removed. New .pm and .t files created. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 19:29:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 18:29:20 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 19:48:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 18:48:48 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #16 from simith.doliveira at inlibro.com --- Don't use this patch : camelot 778 lbo_RM5001_Bordereau / BZ11882 fix this is a obsolete patch. Have just applyed (last koha version) and worked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 20:59:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 19:59:56 +0000 Subject: [Koha-bugs] [Bug 13468] overdue notice lists all checked out books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13468 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 20:59:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 19:59:58 +0000 Subject: [Koha-bugs] [Bug 13468] overdue notice lists all checked out books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13468 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34466|0 |1 is obsolete| | --- Comment #8 from Chris Cormack --- Created attachment 34473 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34473&action=edit BUG 13468: Overdue notice lists all checked out books This patch should fix the issue when running under 'triggered' mode To test: 1) Run overdue_notices.pl -t -n [to output notices to command line] 2) Note that the notices output, list ALL checked out items 3) Apply Patch 4) Run again 5) Note the difference Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 21:07:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 20:07:21 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34470|0 |1 is obsolete| | --- Comment #13 from Barton Chittenden --- Created attachment 34474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34474&action=edit Bug 12933 - Add ability to print overdue slip from staff intranet Some librarians would like to be able to print an overdues slip from the staff intranet. This slip would be defined as the print transport version of the ODUE slip. Test Plan: 1) Apply this patch 2) Locate a patron with overdues 3) Define a print version of the OVERDUES_SLIP slip 4) Try Print > Print overdues Signed-off-by: Amy Purvis Signed-off-by: Laurie McKee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 21:07:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 20:07:36 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34471|0 |1 is obsolete| | --- Comment #14 from Barton Chittenden --- Created attachment 34475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34475&action=edit Bug 12933 - Add new OVERDUES_SLIP letter Signed-off-by: Amy Purvis Signed-off-by: Laurie McKee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 21:09:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 20:09:38 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 21:14:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 20:14:08 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #11 from simith.doliveira at inlibro.com --- Created attachment 34476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34476&action=edit sub plugin_javascript adjust -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 21:15:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 20:15:04 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #12 from simith.doliveira at inlibro.com --- function function Clic$function_name(i) changed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 22:32:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 21:32:19 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 --- Comment #16 from Chris Cormack --- Comment on attachment 34453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34453 Bug 13431 - Shared FastMmap file causes issues Review of attachment 34453: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13431&attachment=34453) ----------------------------------------------------------------- ::: Koha/Cache.pm @@ +40,4 @@ > use Carp; > use Module::Load::Conditional qw(can_load); > use Koha::Cache::Object; > +use C4::Context; We can't do this. We just added a big circular dependency if we do. Because C4::Context uses Koha::Cache @@ +92,5 @@ > } > > + if ( $self->{'default_type'} eq 'fastmmap' > + && defined( $ENV{GATEWAY_INTERFACE} ) > + && can_load( modules => { 'Cache::FastMmap' => undef } ) ) { This change seems good. @@ +162,5 @@ > sub _initialize_fastmmap { > my ($self) = @_; > + my $share_file = join( '-', > + "/tmp/sharefile-koha", $self->{'namespace'}, > + C4::Context->config('hostname'), C4::Context->config('database'), A better way to do this is is to change the places that call Koha::Cache->new() To set the namespace. EG my $cache = Koha::Cache-new({cache_type => 'memcached_cache', namespace => C4::Context->config('hostname') . '-' .C4::Context->config('database')}); I reread the code, and there isn't a bug in Koha::Cache, there is a bug in how we are calling it. $self->{'namespace'} ||= $ENV{MEMCACHED_NAMESPACE} || 'koha'; Is what is in the module, we just are never setting namespace, so it defaults to what is in the ENV, or just koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 22:32:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 21:32:27 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 22:48:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 21:48:22 +0000 Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Hi Winona, thx for working on this :) My impression is that with RDA a lot more persons/authors can be added to a record, so I'd prefer the medium to be a bit more prominent - especially in the result list. I am not sure how to achieve that best. Not a lot of people are following the bug list or are added cc here - maybe try emailing the Koha main list to lead more people here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 23:24:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 22:24:29 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- I have run the QA script on it and there is indeed: "return" statement with explicit "undef" at line 207, column 9. See page 199 of PBP. (Severity: 5) There are also some other things that need to be fixed - Olli, can you provide a follow-up please fixing those? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 23:40:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 22:40:01 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 --- Comment #17 from Robin Sheat --- (In reply to Jacek Ablewicz from comment #11) > However, such test case is pretty artificial - things may be different for > syspref caching, authorized values caching, how would it behave on heavily Latency too, i.e. if you are using a separate MySQL server (which is a recommended configuration, imo) then having things local may be an improvement. > On the other hand, I wonder how many people in the wild may be actually > using CACHING_SYSTEM=fastmmap_cache (or are even aware of such possibility)? > Interesting thing about fastmmap_cache is that it is currently never used by > default nor as a fallback mechanism (at least not since Bug 12041). But it Yeah, it's not recommended to use fastmmap_cache unless you have good cause to due to it not supporting expiry. I'd be quite OK with disabling the init of it and starting the functions with a 'confess "not implemented due to bug 13431"' if an attempt to use it is made. We can always fix it up later should we discover a need. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 16 23:49:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 22:49:06 +0000 Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #6 from David Cook --- This is certainly an interesting one. As LOC notes, the AACR2 GMD is replaced by the 336, 337, and 338 in RDA. As a result, I'm not sure about putting the 245$h into its own "Medium" field, as the 337 already represents "Media type". However, I don't think it would be a good idea to put the GMD into the "Media type" field if a 337 isn't available. If a record has a GMD, I think librarians would expect to see it in the title. I suppose a patron might expect to see it in a Medium field... but I think having Medium/Media would be confusing, especially if a record accidentally has a 245$h and a 337... I don't know. The "funny" thing about MARC is that we could also be determining medium from the 007 or the leader or a combination... In a way, there are too many options and none of them are consistently helpful to end users :S. I don't like the idea of cluttering a screen with all the different format options, but re-using labels can also be confusing. Of course, at the end of the day, we use custom XSLTs for everyone, so I don't have too much of a vested interest in this one, except apart from not wanting to overly customize our own versions. -- As a side note, why do we want to add the statement of responsibility back into the top of the record? Is that a RDA requirement? It looks awful... while it might be something librarians like, I imagine patrons wouldn't like it too much. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 00:10:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 23:10:12 +0000 Subject: [Koha-bugs] [Bug 11937] opac link doesn't open in new window In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11937 Tim Hannah changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |timdhannah at gmail.com --- Comment #8 from Tim Hannah --- Can reproduce in 3.16 and 3.18 in chrome and ie9 where staff detail page includes browse controls / url includes a searchid parameter. OPAC opens in new window, as expected, if staff side search finds and displays a single biblio (no browse controls, no searchid parameter). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 00:12:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 23:12:35 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #9 from David Cook --- (In reply to Nicole C. Engard from comment #0) > The following change should be made to the MARC21 details in the staff and > OPAC: > > Display 700, 710 and 711?s as Contributor(s) (full display) > > Display corresponding subfields a, b, c, d, e, f, g, h, i, k, l, m, n, o, p, > r, s, t, u, x > > Display corresponding subfield e with term(s) in brackets; if there is more > than one subfield e, list all terms within the brackets > > Use vertical bar to separate multiple listings > Out of curiosity, where do these recommendations come from? I agree with Katrin that the vertical bar doesn't appear very attractive or common, but don't necessarily have a better option. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 00:23:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 23:23:18 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #10 from Nick Clemens --- >Any thoughts on where in the record display you would like to see the >additional 700 information (Related works for 700$i and Contained works >700 at ind2=2). Perhaps following the "Other Title" display? I would support that, getting it out of the 'Additional authors' section is really what I would like to see >How should s field be treated with a indicator 2 = 2 and a subfield i? I would say the presence of an $i would trump the second indicator >I agree with Katrin that the vertical bar doesn't appear very attractive or >common, but don't necessarily have a better option. What about the use of a double hyphen -- ? This is what is used in the 505 field to separate contents and seems to work visually -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 00:48:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Dec 2014 23:48:20 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #31 from David Cook --- I absolutely agree with Fridolin on this one. If you look at every other example of "UpdateStats()" in C4::Circulation, you'll see that it uses $item->{itype} (the two bad examples being $biblio->{itemtype} and $item->{itemtype}). While it might be an idea to correct the behaviour to take into account "item-level_itypes", I think that's really outside the scope of this bug. This bug is just to create consistency in the usage of UpdateStats() within C4::Circulation. As for updating existing statistics... I think that's a very difficult idea: 1) If we update existing statistics without telling librarians, we're going to cause huge headaches as their old statistics will be invalidated and their new statistics will likely be very different than expected (even though they're more accurate). 2) If we don't update the statistics, we cause huge headaches as the statistics will be inconsistent. While fixing this in December seems to get around this a bit, you never know when someone is going to apply a fix or switch to a fixed version, so that cannot be banked on. So... I don't know what the right thing to do here is. I think we probably need to update existing statistics... but we need to be very explicit about that. As Fridolin mentioned, libraries rely heavily on statistics, so if we're meddling with their data, we need to make sure that they _know_ that we're doing it. Of course, I don't know the best way to do that either, as it might be easy to miscommunicate about this. Maybe... maybe we should update the statistics with this patch, and the release manager and release maintainers should put a very noticeable message in the release notes. In that way, the onus of passing information on to librarian is - quite understandably - on the sysadmin. Fridolin, if you add some SQL to update the statistics, I'd be happy to sign off on this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 03:28:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 02:28:49 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 --- Comment #32 from David Cook --- I just tried out the following: UPDATE statistics SET itemtype = (select u.itype from (select itype,itemnumber from items UNION ALL select itype,itemnumber from deleteditems ) u where statistics.itemnumber = u.itemnumber ) WHERE type IN ('localuse', 'return') This will re-write the "itemtype" for all 'localuse' and 'return' existing statistical entries. I checked its accuracy with the following: SELECT statistics.*, u.itype from statistics JOIN ( select * from items UNION ALL select * from deleteditems ) u ON u.itemnumber = statistics.itemnumber WHERE type IN ('localuse', 'return') order by datetime ; Looks all right to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 07:29:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 06:29:13 +0000 Subject: [Koha-bugs] [Bug 13468] overdue notice lists all checked out books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13468 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 07:38:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 06:38:35 +0000 Subject: [Koha-bugs] [Bug 13465] Fields controlled by authorized values cannot be unset (Lost, damaged, not for loan status, ...) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13465 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fields controlled by |Fields controlled by |authorized values cannot be |authorized values cannot be |unset |unset (Lost, damaged, not | |for loan status, ...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 09:06:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 08:06:18 +0000 Subject: [Koha-bugs] [Bug 10591] Why do we allow holds on restricted items (952$5=Use restrictions)? Place a hold for reference? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10591 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #1 from Martin Renvoize --- Did this ever get asked on the list... is it still the case... how can we progress this? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 09:13:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 08:13:40 +0000 Subject: [Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #14 from Martin Renvoize --- Can we get this one moving again... I'm trying ot get some of the older 'In Discussion' bugs on the road again. David, do you think it's viable to add this granularity to the display of the alert? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 09:31:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 08:31:14 +0000 Subject: [Koha-bugs] [Bug 13465] Fields controlled by authorized values cannot be unset (Lost, damaged, not for loan status, ...) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13465 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- Could you please give more detail, I don't reproduce (but not sure to understand how to reproduce). Does the problem still exist on master? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 09:36:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 08:36:32 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 09:36:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 08:36:34 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #39 from Jonathan Druart --- Created attachment 34477 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34477&action=edit Bug 12648: Add the new 'Acquisition' entry in the letter module list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 09:37:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 08:37:18 +0000 Subject: [Koha-bugs] [Bug 13465] Fields controlled by authorized values cannot be unset (Lost, damaged, not for loan status, ...) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13465 --- Comment #3 from Katrin Fischer --- To test: - edit an item, set a status that is controlled by an authorized value examples tested: damaged, not for loan - check the status saved correctly - edit the item again, try to reset the status to empty - verify the item is saved, but the status remains -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 09:37:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 08:37:27 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 --- Comment #40 from Jonathan Druart --- (In reply to Paola Rossi from comment #38) > >2/ You can edit it if you want > > I saw that the "Koha module" is "Catalog" ERROR, while "Acquisition" is not > an available option in the drop down list. > > On MASTER, in effect, the available modules are 8, and none of them is > "Acquisition". > > So I pass the patch to "Failed QA" status. Sorry about that. It should be fixed now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 09:38:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 08:38:28 +0000 Subject: [Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed by Module Maintainer --- Comment #23 from Martin Renvoize --- Pushed to Module Maintainers Branch - https://github.com/mrenvoize/Koha/tree/authentication -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 09:41:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 08:41:16 +0000 Subject: [Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 09:59:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 08:59:45 +0000 Subject: [Koha-bugs] [Bug 12874] On editing an item, some fields can be set to NULL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12874 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13465 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 09:59:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 08:59:45 +0000 Subject: [Koha-bugs] [Bug 13465] Fields controlled by authorized values cannot be unset (Lost, damaged, not for loan status, ...) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13465 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |12874 Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- Thanks. Related to bug 12874. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 10:06:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 09:06:47 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #19 from Martin Renvoize --- Interesting work.. could we have this rebased for testing Nicholas? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 10:20:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 09:20:10 +0000 Subject: [Koha-bugs] [Bug 13474] New: Untranslatable log actions Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13474 Bug ID: 13474 Summary: Untranslatable log actions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Log actions "RENEW", "CHANGE PASS", "ADDCIRCMESSAGE" and "DELCIRCMESSAGE" are untranslatable, need to be added to translate_log_action block in viewlog.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 10:50:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 09:50:57 +0000 Subject: [Koha-bugs] [Bug 13465] Fields controlled by authorized values cannot be unset (Lost, damaged, not for loan status, ...) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13465 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 10:51:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 09:51:00 +0000 Subject: [Koha-bugs] [Bug 13465] Fields controlled by authorized values cannot be unset (Lost, damaged, not for loan status, ...) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13465 --- Comment #5 from Jonathan Druart --- Created attachment 34478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34478&action=edit Bug 13465: Fix silly regex on generating default values hash This is introduced by Bug 12874. Without this patch, it's not possible to clear (set to an empty string) an item field. This appended for field linked to an AV list but even if it's not. The regex tried to prefix 'my_field' with 'items.' to have 'items.my_field'. It wanted to take care of the case where the prefix already exists (Actually only 1: 'items.cn_source'). The regex is changed to: "add the prefix only if the string does not contain a dot". Test plan: - edit an item, set a status that is controlled by an authorized value examples tested: damaged, not for loan - check the status saved correctly - edit the item again, reset the status to empty - check the status saved correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 10:51:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 09:51:18 +0000 Subject: [Koha-bugs] [Bug 13465] Fields controlled by authorized values cannot be unset (Lost, damaged, not for loan status, ...) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13465 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 11:08:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 10:08:51 +0000 Subject: [Koha-bugs] [Bug 13468] overdue notice lists all checked out books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13468 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 11:08:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 10:08:53 +0000 Subject: [Koha-bugs] [Bug 13468] overdue notice lists all checked out books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13468 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34473|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 34479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34479&action=edit BUG 13468: Overdue notice lists all checked out books This patch should fix the issue when running under 'triggered' mode To test: 1) Run overdue_notices.pl -t -n [to output notices to command line] 2) Note that the notices output, list ALL checked out items 3) Apply Patch 4) Run again 5) Note the difference Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Amended patch: remove space changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 11:09:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 10:09:22 +0000 Subject: [Koha-bugs] [Bug 13468] overdue notice lists all checked out books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13468 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Version|3.18 |master QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 11:10:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 10:10:46 +0000 Subject: [Koha-bugs] [Bug 12529] Overdue notices do not respect holidays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13468 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 11:10:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 10:10:46 +0000 Subject: [Koha-bugs] [Bug 13468] overdue notice lists all checked out books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13468 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12529 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 12:00:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 11:00:29 +0000 Subject: [Koha-bugs] [Bug 11808] When searching for a cardnumber in the intranet, also try to search for it on the LDAP server if one is configured. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11808 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- Interesting patch... could we have this re-based so I may test it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 12:15:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 11:15:44 +0000 Subject: [Koha-bugs] [Bug 13456] Serials/Claims.t expects no subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13456 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paola.rossi at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 12:18:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 11:18:00 +0000 Subject: [Koha-bugs] [Bug 13456] Serials/Claims.t expects no subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13456 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34371|0 |1 is obsolete| | --- Comment #2 from Paola Rossi --- Created attachment 34480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34480&action=edit Bug 13456: Serials/Claims.t expects no subscriptions I've applied the patch against master 3.19.00.000 Everything is ok. So I pass the patch to "Signed Off" status. At my tests a "late subscription" is an open subscription with 1 (whichever) issue in LATE/3 state. About step 5/: koha-qa.pl -v 2 -c 1 testing 1 commit(s) (applied to 5bdf460 'Bug 13425 - XSS in opac facets - Patc') Processing files before patches |========================>| 1 / 1 (100.00%) Processing files after patches |========================>| 1 / 1 (100.00%) OK t/db_dependent/Serials/Claims.t OK critic OK forbidden patterns OK pod OK valid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 13:46:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 12:46:31 +0000 Subject: [Koha-bugs] [Bug 12774] Enabling phone notices ( talking tech ) without having DUEDGST and PREDUEDGST breaks advance notices! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12774 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 13:46:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 12:46:33 +0000 Subject: [Koha-bugs] [Bug 12774] Enabling phone notices ( talking tech ) without having DUEDGST and PREDUEDGST breaks advance notices! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12774 --- Comment #3 from Kyle M Hall --- Created attachment 34481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34481&action=edit Bug 12774 - Enabling phone notices ( talking tech ) without having DUEDGST and PREDUEDGST breaks advance notices! If talking tech is enabled, and a patron has selected phone notices for predue and/or due notices, advance_notices will die when coming upon a patron with phone notices selected. The TT script for advance notices does not use a letter and thus no letter exists for it by default. When advance_notices comes upone this, it sees the phone transport, tries to get the notices for the phone transport, and dies. Test Plan: 1) Enable TalkingTech 2) Set one or more patrons to recieve advance notices via phone 3) Set one or more patrons so they should recieve an advance notice today 4) Run advance_notices.pl, note that it dies 5) Apply this patch 6) Run advance_notices.pl, note that it now warns instead of dying -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 13:47:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 12:47:43 +0000 Subject: [Koha-bugs] [Bug 12730] Pre-due Notices not being sent. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12730 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall --- (In reply to Katrin Fischer from comment #3) > Hi Jesse, is it possible what you see is related to bug 12774? Katrin, I believe this bug is unrelated to bug 12774. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 13:56:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 12:56:38 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 --- Comment #9 from Jonathan Druart --- (In reply to Koha Team Lyon 3 from comment #7) Thanks for testing Sonia! > For each vendor, I try receipt without any change, partial receipt, receipt > with change of price, receipt with change of GST, receipt after a transfer > from another vendor, with price needing some round calculation. Good to know (almost) everything is fine :) > In all the case (calculation in the basket, print of the basket group, > export CSV of the basket group, receipt and invoice), the fair prices are > calculated, consistently with the setting of the tax in the vendor page. > Except in one case : the CSV export of a basket group after a transfer of an > order from a vendor where list prices don't include tax forward a vendor > where List prices include tax. Good catch, I submitted a new patch (applied on the sandbox). With this patch, both prices (including and excluding tax) is displayed in the csv file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 15:17:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 14:17:48 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #12 from simith.doliveira at inlibro.com --- Created attachment 34482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34482&action=edit Fix syspref BorrowerUnwantedField -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 15:19:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 14:19:51 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #13 from simith.doliveira at inlibro.com --- Syspref BorrowerUnwantedField problem was fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 15:22:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 14:22:20 +0000 Subject: [Koha-bugs] [Bug 13470] pay fines with extended borrower attributes result in application error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13470 --- Comment #3 from Dobrica Pavlinusic --- I should clarify that this error exists only when running under plack, which makes $template go out of scope since it's not declared with our. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 15:36:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 14:36:55 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #14 from M. de Rooy --- (In reply to Jonathan Druart from comment #13) > (In reply to M. de Rooy from comment #11) > > Saw a Bug XXXXX: Add permission for shelves > > Maybe bug 9833? No the print message in your own patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 15:45:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 14:45:06 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #15 from Jonathan Druart --- Created attachment 34483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34483&action=edit Bug 13417: Allow staff members to manage public lists Currently a public list can only be deleted by its owner. This means lists can exist infinitely. This will introduce a new permission for list. With this permission, a staff member will be allow to delete any public lists. Test plan: 1/ Add the manage_shelves permission to a patron. 2/ Login with this patron 3/ Go on the public list view 4/ You should be able to edit all public lists Followed test plan. Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 15:46:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 14:46:01 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #16 from M. de Rooy --- (In reply to Jonathan Druart from comment #12) > But we don't want to remove public lists. > So I could submit a patch to remove private lists only, do you agree with > that? > I don't think it will introduce side-effects. The change is quite trivial. To mention one: you allow now a superlibrarian to delete entries from the list of someone else. The manage permission is not on entry level, but on list level. You can moderate a list name, delete the entire list (for a good reason, i hope), change ownership or so. But why allowing librarians to interfere with the list contents? We respect the user here by not allowing that if he defined it likewise. Easy fix: move your change to the elsif(action eq manage)-part. > > [2] You allow deletion of public lists now, but what if you want to manage a > > private or shared list from another user? Would it not be better to show a > > third tab in staff for Other lists (or even another form?) that allows you > > to search lists, delete, edit, change ownership, etc.? > I propose a quick and easy solution to answer a big and real problem for > librarians. Even if it is not perfect. > I would not like to add a new tab here, I already have submitted a big > change for this page (see bug 13419). Would a new tab really be so much work? And a new form would not interfere with other changes at all. I would prefer a more complete solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 15:49:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 14:49:28 +0000 Subject: [Koha-bugs] [Bug 13470] pay fines with extended borrower attributes result in application error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13470 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #4 from Paola Rossi --- (In reply to Dobrica Pavlinusic from comment #3) > I should clarify that this error exists only when running under plack, which > makes $template go out of scope since it's not declared with our. Thanks, Dobrica, for your kind explaination. I'm passing this bug back to "Needs Signoff" status. But I'm not going to test this bug, because I'd prefer not to install plack. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 15:49:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 14:49:44 +0000 Subject: [Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279 --- Comment #29 from M. de Rooy --- (In reply to Jonathan Druart from comment #28) > (In reply to M. de Rooy from comment #26) > > At this point, I would go for refactoring instead of spending more time on > > the current code. So I obsolete both patches. > > It's a major bug and still exists on master. > I would like to see this bug fixed quickly. > And the quicker way is to push these patches, don't you think? See comment 25 for a reason not to. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 16:19:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 15:19:34 +0000 Subject: [Koha-bugs] [Bug 13469] Unapi path to XSLTs is wrong in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13469 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34444|0 |1 is obsolete| | --- Comment #2 from M. de Rooy --- Created attachment 34484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34484&action=edit Bug 13469 - Unapi path to XSLTs is wrong in OPAC The Unapi path to XSLTs is wrong in the OPAC. Unfortunately, it's coded to work just for Git installs, which makes it tough to test. _TEST PLAN_ Before applying: 1) Go to http://GIT-INSTALL/cgi-bin/koha/unapi?id=koha:biblionumber:1&format=oai_dc 2) If the biblionumber exists, it should show you the record in OAI_DC format. 3) Go to http://REGULAR-INSTALL/cgi-bin/koha/unapi?id=koha:biblionumber:1&format=oai_dc 4) You should get a software error Apply the patch. After applying: 1) Refresh the page for http://yourgitinstall/cgi-bin/koha/unapi?id=koha:biblionumber:1&format=oai_dc 2) It should work exactly the same as before. Thorough testers: 1) Push the code to that regular test install 2) Try the link again. It will properly show the converted record now. Signed-off-by: Marcel de Rooy Verified that single install intrahtdocs==/usr/share/koha/clone1712/intranet/htdocs/intranet-tmpl plus "/prog/en/xslt/" is the location for the required xslt files. Script unapi in git install is still fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 16:19:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 15:19:32 +0000 Subject: [Koha-bugs] [Bug 13469] Unapi path to XSLTs is wrong in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13469 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 16:28:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 15:28:42 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #17 from Jonathan Druart --- Created attachment 34485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34485&action=edit Bug 13417: Limit the permission to delete It's preferable to limit the permission to delete shelves. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 16:28:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 15:28:56 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34249|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 16:31:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 15:31:59 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #18 from Jonathan Druart --- (In reply to M. de Rooy from comment #16) > (In reply to Jonathan Druart from comment #12) > > But we don't want to remove public lists. > > So I could submit a patch to remove private lists only, do you agree with > > that? > > > I don't think it will introduce side-effects. The change is quite trivial. > To mention one: you allow now a superlibrarian to delete entries from the > list of someone else. The manage permission is not on entry level, but on > list level. You can moderate a list name, delete the entire list (for a good > reason, i hope), change ownership or so. But why allowing librarians to > interfere with the list contents? We respect the user here by not allowing > that if he defined it likewise. Easy fix: move your change to the > elsif(action eq manage)-part. The initial need was to delete shelves. I have just submitted a patch to limit the permission to the shelves deletion. I hope it matches your requirements. > > > [2] You allow deletion of public lists now, but what if you want to manage a > > > private or shared list from another user? Would it not be better to show a > > > third tab in staff for Other lists (or even another form?) that allows you > > > to search lists, delete, edit, change ownership, etc.? > > I propose a quick and easy solution to answer a big and real problem for > > librarians. Even if it is not perfect. > > I would not like to add a new tab here, I already have submitted a big > > change for this page (see bug 13419). > Would a new tab really be so much work? And a new form would not interfere > with other changes at all. I would prefer a more complete solution. I don't think it's inside the scope of this patch. Switch back to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 16:32:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 15:32:29 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #19 from Jonathan Druart --- Test plan updated: 4/ You should be able to edit all public lists is 4/ You should be able to delete all public lists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 16:49:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 15:49:31 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 --- Comment #47 from M. de Rooy --- I am having various encoding related problems with applying this patch set. Looks like it is related to latin accented chars in the commit messages and my version of git/git bz. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 16:55:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 15:55:14 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 --- Comment #48 from Jonathan Druart --- (In reply to M. de Rooy from comment #47) > I am having various encoding related problems with applying this patch set. > Looks like it is related to latin accented chars in the commit messages and > my version of git/git bz. Try without the -e option. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 17:19:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 16:19:49 +0000 Subject: [Koha-bugs] [Bug 13475] New: OAI does not return items Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13475 Bug ID: 13475 Summary: OAI does not return items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org Since bug 5579, items are not stored in DB. The oai script does not have been changed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 17:20:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 16:20:18 +0000 Subject: [Koha-bugs] [Bug 13475] OAI does not return items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13475 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |5579 Assignee|oleonard at myacpl.org |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 17:20:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 16:20:18 +0000 Subject: [Koha-bugs] [Bug 5579] Remove items from biblioitems.marcxml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5579 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13475 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 17:23:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 16:23:00 +0000 Subject: [Koha-bugs] [Bug 13475] OAI does not return items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13475 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 17:23:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 16:23:02 +0000 Subject: [Koha-bugs] [Bug 13475] OAI does not return items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13475 --- Comment #1 from Jonathan Druart --- Created attachment 34486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34486&action=edit Bug 13475: OAI should return items Since bug 5579, items are not stored in DB. The oai script does not have been changed. Test plan: go on 1/ Enable the pref OAI-PMH 2/ Set OAI-PMH:archiveID = KOHA-OAI-TEST (or what you want) 3/ Go on oai.pl?verb=GetRecord&metadataPrefix=marcxml&identifier=KOHA-OAI-TEST:[BIBLIONUMBER] with [BIBLIONUMBER] a record's biblionumber containing items. The marcxml should be returned with items. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 17:23:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 16:23:31 +0000 Subject: [Koha-bugs] [Bug 13436] Add more options to UsageStatsLibraryType In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13436 --- Comment #7 from Elaine Bradtke --- Subscription libraries used to be much more common. The members pay an annual fee for the use of the facility and its material. The London Library is probably the most famous of these: www.londonlibrary.co.uk/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 17:47:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 16:47:42 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 17:49:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 16:49:07 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34224|0 |1 is obsolete| | --- Comment #41 from Paola Rossi --- Created attachment 34487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34487&action=edit Bug 12648: Link patrons to an order - DB changes Thanks, Jonathan. I've applied the patches against master 3.19.00.000 IMO everything is OK as required. So I pass the patch to "Signed Off" status. Only [certain] staff patrons could be linked to a basket, whilest patrons of all categories could be linked to an order. When the pop-up to "Add users" was opened, no user was shown [OK] as required. And then, if I submitted with no search value, all the [allowed] users were listed [OK]. Newing [or modifying] an order, in "Patrons" tag, next to "To notify on reveiving:", I saw firstname + surname of the added users [OK]. In the message_queue records, in "content" field, I see "Dear firstname + surname ..." [OK]. In the patrons' list, I see "surname, firstname" datas in "Name" column [OK]. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 17:49:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 16:49:35 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34225|0 |1 is obsolete| | --- Comment #42 from Paola Rossi --- Created attachment 34488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34488&action=edit Bug 12648: Refactoring to prepare user search for reuse -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 17:50:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 16:50:04 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34226|0 |1 is obsolete| | --- Comment #43 from Paola Rossi --- Created attachment 34489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34489&action=edit Bug 12648: Link patrons to an order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 17:50:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 16:50:32 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34227|0 |1 is obsolete| | --- Comment #44 from Paola Rossi --- Created attachment 34490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34490&action=edit Bug 12648: Add unit tests for C4::Acquisition::*OrderUsers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 17:51:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 16:51:05 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34228|0 |1 is obsolete| | --- Comment #45 from Paola Rossi --- Created attachment 34491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34491&action=edit Bug 12648: The users added to basket should have a permission -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 17:51:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 16:51:32 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34229|0 |1 is obsolete| | --- Comment #46 from Paola Rossi --- Created attachment 34492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34492&action=edit Bug 12648: Fix conflict with bug 12833 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 17:51:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 16:51:59 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34230|0 |1 is obsolete| | --- Comment #47 from Paola Rossi --- Created attachment 34493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34493&action=edit Bug 12648: Hide the result search on load -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 17:52:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 16:52:33 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34231|0 |1 is obsolete| | --- Comment #48 from Paola Rossi --- Created attachment 34494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34494&action=edit Bug 12648: The patron's name should be the same as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 17:53:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 16:53:03 +0000 Subject: [Koha-bugs] [Bug 12648] Link patrons to an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34477|0 |1 is obsolete| | --- Comment #49 from Paola Rossi --- Created attachment 34495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34495&action=edit Bug 12648: Add the new 'Acquisition' entry in the letter module list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 18:40:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 17:40:07 +0000 Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 --- Comment #7 from Nicole C. Engard --- (In reply to David Cook from comment #6) > This is certainly an interesting one. As LOC notes, the AACR2 GMD is > replaced by the 336, 337, and 338 in RDA. > > As a result, I'm not sure about putting the 245$h into its own "Medium" > field, as the 337 already represents "Media type". However, I don't think it > would be a good idea to put the GMD into the "Media type" field if a 337 > isn't available. > > If a record has a GMD, I think librarians would expect to see it in the > title. I suppose a patron might expect to see it in a Medium field... but I > think having Medium/Media would be confusing, especially if a record > accidentally has a 245$h and a 337... My thought here is that no library can afford to re catalog their collection so their old records will still have the GMD and we should show that. So I'm thinking an IF statement. Show the 337 next to Media type if it's there but if it's not then show the GMD. > > As a side note, why do we want to add the statement of responsibility back > into the top of the record? Is that a RDA requirement? It looks awful... > while it might be something librarians like, I imagine patrons wouldn't like > it too much. I agree - the author should be where it was - no reason to move it up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 19:35:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 18:35:24 +0000 Subject: [Koha-bugs] [Bug 13475] OAI does not return items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13475 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 21:17:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 20:17:02 +0000 Subject: [Koha-bugs] [Bug 13465] Fields controlled by authorized values cannot be unset (Lost, damaged, not for loan status, ...) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13465 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Mirko Tietgen --- With this patch applied, situation is worse. I can't save most fields. ?damaged? does stay when set, other fields forget/ delete the value on save. But deleting a value that has been set before applying the patch works ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 21:49:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 20:49:50 +0000 Subject: [Koha-bugs] [Bug 13436] Add more options to UsageStatsLibraryType In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13436 --- Comment #8 from Katrin Fischer --- Thx for explaining, Elaine! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 21:53:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 20:53:54 +0000 Subject: [Koha-bugs] [Bug 13475] OAI does not return items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13475 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi Jonathan, I think this is duplicate to 12252 - can you check the other implementation? It's waiting for QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 23:21:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 22:21:10 +0000 Subject: [Koha-bugs] [Bug 13398] Perl files for rotating collections are missing in installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13398 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Version|3.18 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 23:31:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 22:31:35 +0000 Subject: [Koha-bugs] [Bug 13428] Fix facet deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13428 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 23:32:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 22:32:41 +0000 Subject: [Koha-bugs] [Bug 13428] Fix facet deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13428 --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 23:33:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 22:33:04 +0000 Subject: [Koha-bugs] [Bug 13398] Perl files for rotating collections are missing in installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13398 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 23:33:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 22:33:36 +0000 Subject: [Koha-bugs] [Bug 13451] Holidays.t assumes default data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13451 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 23:34:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 22:34:24 +0000 Subject: [Koha-bugs] [Bug 13468] overdue notice lists all checked out books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13468 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Martin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 23:40:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 22:40:15 +0000 Subject: [Koha-bugs] [Bug 13375] Syspref search highlight styling broken in Chrome In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13375 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 23:40:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 22:40:50 +0000 Subject: [Koha-bugs] [Bug 13362] translate script creates dirs on update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13362 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Good catch Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 23:41:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 22:41:07 +0000 Subject: [Koha-bugs] [Bug 13375] Syspref search highlight styling broken in Chrome In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13375 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 23:41:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 22:41:38 +0000 Subject: [Koha-bugs] [Bug 13362] translate script creates dirs on update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13362 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |3.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 23:42:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 22:42:06 +0000 Subject: [Koha-bugs] [Bug 13468] overdue notice lists all checked out books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13468 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 23:42:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 22:42:16 +0000 Subject: [Koha-bugs] [Bug 13398] Perl files for rotating collections are missing in installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13398 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.18 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 17 23:42:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 22:42:32 +0000 Subject: [Koha-bugs] [Bug 13428] Fix facet deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13428 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 00:07:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 23:07:58 +0000 Subject: [Koha-bugs] [Bug 11706] Typo "efault" in updatedatabase.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11706 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 00:08:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 23:08:28 +0000 Subject: [Koha-bugs] [Bug 10051] surname and first name should have comma in overdues report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10051 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 00:08:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 23:08:56 +0000 Subject: [Koha-bugs] [Bug 13355] System preferences tab value wrong in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13355 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 00:10:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 23:10:14 +0000 Subject: [Koha-bugs] [Bug 13331] Subfield does not show in cataloging editor - if subfield is disabled in OPAC/enabled in Staff, via frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13331 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #13 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Mason! PS. try to tidy your commit messages a bit next time :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 00:10:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 23:10:41 +0000 Subject: [Koha-bugs] [Bug 13410] Untranslatable "Change messaging preferences to default for this category?" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13410 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 00:11:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 23:11:23 +0000 Subject: [Koha-bugs] [Bug 13368] Checking out an item not on loan, but with a hold, busts the holds priority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13368 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Chris! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 00:23:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 23:23:05 +0000 Subject: [Koha-bugs] [Bug 13460] Use price template toolkit plugin across all of intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13460 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Alexander! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 00:23:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 23:23:40 +0000 Subject: [Koha-bugs] [Bug 12059] Publisher code always empty on invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12059 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Katrina and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 00:24:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 23:24:52 +0000 Subject: [Koha-bugs] [Bug 12084] Published date for serial items not formatted according to dateformat system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12084 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 00:26:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 23:26:26 +0000 Subject: [Koha-bugs] [Bug 13400] Untranslatable "Are you sure you want to delete this authority?" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13400 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 00:27:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Dec 2014 23:27:12 +0000 Subject: [Koha-bugs] [Bug 13449] Syndetics TOC will not display in some cases In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13449 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 01:03:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 00:03:47 +0000 Subject: [Koha-bugs] [Bug 13428] Fix facet deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13428 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #8 from Chris Cormack --- Pushed to 3.18.x (no string changes) will be in 3.18.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 01:05:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 00:05:03 +0000 Subject: [Koha-bugs] [Bug 4148] Advanced Search not sorting by author In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4148 Danielle Elder changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danielle at bywatersolutions.c | |om --- Comment #3 from Danielle Elder --- I think the sort should look at other than 100a field for a sort on author. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 01:06:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 00:06:16 +0000 Subject: [Koha-bugs] [Bug 13398] Perl files for rotating collections are missing in installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13398 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #7 from Chris Cormack --- No string changes, pushed to 3.18.x will be in 3.18.2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 01:10:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 00:10:58 +0000 Subject: [Koha-bugs] [Bug 13451] Holidays.t assumes default data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13451 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- No string changes, pushed to 3.18.x will be in 3.18.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 01:16:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 00:16:26 +0000 Subject: [Koha-bugs] [Bug 13218] usability enhancement for z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13218 --- Comment #23 from Tom?s Cohen Arazi --- Created attachment 34497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34497&action=edit Bug 13218: (RM followup) only scroll on actually variable stuff Most of the page contents have fixed size. The only exception is the targets list. If the target list grows, then the whole page needs to be scrolled in order to reach the buttons. We should make the z3950 targets area scrollable, and remove scrolbars from all over the place. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 01:17:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 00:17:44 +0000 Subject: [Koha-bugs] [Bug 13218] usability enhancement for z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13218 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #24 from Tom?s Cohen Arazi --- Created attachment 34498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34498&action=edit Current view with lots of targets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 01:18:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 00:18:09 +0000 Subject: [Koha-bugs] [Bug 13218] usability enhancement for z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13218 --- Comment #25 from Tom?s Cohen Arazi --- Created attachment 34499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34499&action=edit Proposed view with lots of targets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 01:19:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 00:19:53 +0000 Subject: [Koha-bugs] [Bug 13218] usability enhancement for z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13218 --- Comment #26 from Tom?s Cohen Arazi --- I was about to push this one, along with my followup. But then I realized there's no rush to push this one, so: do you agree with the followup? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 01:24:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 00:24:34 +0000 Subject: [Koha-bugs] [Bug 13436] Add more options to UsageStatsLibraryType In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13436 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34443|0 |1 is obsolete| | --- Comment #9 from Aleisha Amohia --- Created attachment 34500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34500&action=edit Bug 13436: Adding more options to UsageStatsLibraryType syspref Added options: - research - private - society or association - corporate - government - religious organization - subscription - school Also changed 'university' to 'academic' To test: 1) Go on to Global System Preferences and find UsageStatsLibraryType under Administration 2) Click drop-down menu and see all new options described above, as well as 'academic' instead of 'university' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 01:28:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 00:28:21 +0000 Subject: [Koha-bugs] [Bug 13218] usability enhancement for z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13218 --- Comment #27 from Liz Rea --- I agree with your followup, please go ahead and push it :) Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 01:45:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 00:45:11 +0000 Subject: [Koha-bugs] [Bug 13468] overdue notice lists all checked out books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13468 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Chris Cormack --- No string changes, pushed to 3.18.x will be in 3.18.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 01:56:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 00:56:49 +0000 Subject: [Koha-bugs] [Bug 13362] translate script creates dirs on update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13362 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 02:00:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 01:00:55 +0000 Subject: [Koha-bugs] [Bug 11706] Typo "efault" in updatedatabase.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11706 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 02:08:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 01:08:06 +0000 Subject: [Koha-bugs] [Bug 10051] surname and first name should have comma in overdues report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10051 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #9 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 02:13:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 01:13:05 +0000 Subject: [Koha-bugs] [Bug 13355] System preferences tab value wrong in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13355 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Pushed to 3.18.x will be 3.18.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 02:14:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 01:14:45 +0000 Subject: [Koha-bugs] [Bug 13331] Subfield does not show in cataloging editor - if subfield is disabled in OPAC/enabled in Staff, via frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13331 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #14 from Chris Cormack --- Pushed to 3.18.x, will be in 3.18.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 02:15:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 01:15:45 +0000 Subject: [Koha-bugs] [Bug 13470] pay fines with extended borrower attributes result in application error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13470 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34451|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia --- Created attachment 34501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34501&action=edit Bug 13470 - pay fines with extended borrower attributes result in application error Test scenario: 1. ensure that extended patron attributes are turned on in system preferences 2. find borrower which has fine to pay, and click on pay button 3. verify application error 4. apply patch and verify that application error is gone Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 02:16:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 01:16:03 +0000 Subject: [Koha-bugs] [Bug 13470] pay fines with extended borrower attributes result in application error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13470 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |aleishaamohia at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 02:18:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 01:18:23 +0000 Subject: [Koha-bugs] [Bug 13410] Untranslatable "Change messaging preferences to default for this category?" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13410 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Contains string changes, holding for 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 02:22:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 01:22:13 +0000 Subject: [Koha-bugs] [Bug 13368] Checking out an item not on loan, but with a hold, busts the holds priority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13368 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 02:26:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 01:26:38 +0000 Subject: [Koha-bugs] [Bug 13460] Use price template toolkit plugin across all of intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13460 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 02:44:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 01:44:41 +0000 Subject: [Koha-bugs] [Bug 13476] New: Item Search feature gets datatables error and doesn't complete search Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13476 Bug ID: 13476 Summary: Item Search feature gets datatables error and doesn't complete search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Attempting to do a search from the new staff client item search screen gives the following error: DataTables warning: table id=results - Invalid JSON response. For more information about this error, please see http://datatables.net/tn/1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 05:15:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 04:15:00 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #14 from Marc V?ron --- Created attachment 34502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34502&action=edit [Signed-off] Bug 11879 - Add a new borrower field : main contact method. (Was: Rebased on current master for testing) http://bugs.koha-community.org/show_bug.cgi?id=11879 To test this patch: Update database Edit a borrower's informations. The "Main Contact Method" selectbox appears in the form and its value is correctly. Works as expected. For handling of syspref BorrowerUnwantedField use second patch- Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 05:17:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 04:17:55 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #15 from Marc V?ron --- Created attachment 34503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34503&action=edit [Signed-off] Fix syspref BorrowerUnwantedField How I tested: Apply 1st patch Apply this patch Edit syspref BorrowerUnwantedField to exclude fields Edit patron's contact information Make sure that fields do not longer appear in drop down for Main contact Wors as expected http://bugs.koha-community.org/show_bug.cgi?id=11879 Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 05:18:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 04:18:18 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34351|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 05:18:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 04:18:33 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34482|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 05:18:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 04:18:43 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 05:42:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 04:42:08 +0000 Subject: [Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #4 from Marc V?ron --- The filter behaves as follows: Edit / change 'List name' Result: List is filtered: OK Edit /change 'Author': Result: List is filtered: OK Change selection in drop box 'Sort by' Result: No change in list. You have to change 'List name' or 'Author' to trigger filtering. - This is confusing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 05:44:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 04:44:59 +0000 Subject: [Koha-bugs] [Bug 12059] Publisher code always empty on invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12059 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #7 from Chris Cormack --- Template changes, holding for 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 05:47:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 04:47:33 +0000 Subject: [Koha-bugs] [Bug 12084] Published date for serial items not formatted according to dateformat system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12084 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 05:48:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 04:48:39 +0000 Subject: [Koha-bugs] [Bug 13400] Untranslatable "Are you sure you want to delete this authority?" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13400 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #9 from Chris Cormack --- Holding for 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 05:52:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 04:52:50 +0000 Subject: [Koha-bugs] [Bug 13449] Syndetics TOC will not display in some cases In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13449 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 06:09:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 05:09:45 +0000 Subject: [Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #5 from Marc V?ron --- Created attachment 34504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34504&action=edit [Signed-off] Bug 13421: Add the creation time for virtual shelves Test plan: 1/ Execute the updatedb entry 2/ Create a list 3/ Go on the shelve list and confirm that the creation and last modification time are now displayed. 4/ Confirm that you are able to sort the list by creation/modification time. Applied on top of 13419 (rebased updatedatabase.pl) Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 06:11:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 05:11:16 +0000 Subject: [Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34504|0 |1 is obsolete| | --- Comment #6 from Marc V?ron --- Comment on attachment 34504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34504 [Signed-off] Bug 13421: Add the creation time for virtual shelves Sorry, attached to wrong bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 06:12:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 05:12:46 +0000 Subject: [Koha-bugs] [Bug 13421] Add the creation time for virtual shelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13421 --- Comment #4 from Marc V?ron --- Created attachment 34505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34505&action=edit [Signed-off] Bug 13421: Add the creation time for virtual shelves Test plan: 1/ Execute the updatedb entry 2/ Create a list 3/ Go on the shelve list and confirm that the creation and last modification time are now displayed. 4/ Confirm that you are able to sort the list by creation/modification time. Applied on top of 13419 (rebased updatedatabase.pl) Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 06:13:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 05:13:08 +0000 Subject: [Koha-bugs] [Bug 13421] Add the creation time for virtual shelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13421 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34244|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 06:13:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 05:13:31 +0000 Subject: [Koha-bugs] [Bug 13421] Add the creation time for virtual shelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13421 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 07:32:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 06:32:25 +0000 Subject: [Koha-bugs] [Bug 13471] When editing a subscription, the "subscription length type" disregards the stored value, also make SLT translateable. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13471 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34455|0 |1 is obsolete| | --- Comment #3 from Olli-Antti Kivilahti --- Created attachment 34506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34506&action=edit Bug 13471 - When editing a subscription, the "subscription length type" disregards the stored value, also make SLT translateable. This issue causes loss of data when the subscription length type (SLT) is other than issues. TO REPLICATE: We make an subscription with SLT of months = 12. Later make an arbitrary edit to the subscription, and miss out the fact that the SLT selection is set to issues. Save the changes. Serial subscription end date is set to 12 issues since the start date, instead of 12 months which it used to be. This causes a myriad of issues :=) AFTER THIS PATCH: SLT defaults to the value initially saved instead of always being issues. Now the selection can be translated! HOTFIX 1: Added elements to showSubscriptionLengthType.inc so the translation tool can catch them. HOTFIX 2: Fixed serials/showpredictionpattern.pl to use the db columns instead of issues,weeks,months. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 09:45:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 08:45:02 +0000 Subject: [Koha-bugs] [Bug 13465] Fields controlled by authorized values cannot be unset (Lost, damaged, not for loan status, ...) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13465 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 09:45:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 08:45:04 +0000 Subject: [Koha-bugs] [Bug 13465] Fields controlled by authorized values cannot be unset (Lost, damaged, not for loan status, ...) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13465 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34478|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 34508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34508&action=edit Bug 13465: Correct the field prefix ambiguity This is introduced by Bug 12874. Without this patch, it's not possible to clear (set to an empty string) an item field. This appended for field linked to an AV list but even if it's not. The regex tried to prefix 'my_field' with 'items.' to have 'items.my_field'. It wanted to take care of the case where the prefix already exists (Actually only 1: 'items.cn_source'). The regex is changed to: "add the prefix only if the string does not contain a dot". Moreover an ambiguity existed on the prefix: in marc_subfield_structure, the kohafield is prefixed, but not in the key of the hash sent to ModItemFromMarc. Test plan: - edit an item, set a status that is controlled by an authorized value examples tested: damaged, not for loan - check the status saved correctly - edit the item again, reset the status to empty - check the status saved correctly - edit the item again, reset fields, edit fields - check the fields saved correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 09:51:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 08:51:44 +0000 Subject: [Koha-bugs] [Bug 13465] Fields controlled by authorized values cannot be unset (Lost, damaged, not for loan status, ...) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13465 --- Comment #8 from Jonathan Druart --- (In reply to Mirko Tietgen from comment #6) > With this patch applied, situation is worse. I can't save most fields. > ?damaged? does stay when set, other fields forget/ delete the value on save. > > But deleting a value that has been set before applying the patch works ;) Sorry, Mirko, it's was a quick fix and I did not test it deeply. This one should be better. Thanks for testing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 10:15:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 09:15:28 +0000 Subject: [Koha-bugs] [Bug 4283] Merge bibliographic records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4283 --- Comment #4 from Olli-Antti Kivilahti --- Created attachment 34509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34509&action=edit Bug 4283 - Merge bibliographic records. Followup. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 10:33:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 09:33:59 +0000 Subject: [Koha-bugs] [Bug 13428] Fix facet deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13428 --- Comment #9 from Jonathan Druart --- This should not have been pushed before bug 13425, because now the facets deletion is broken :) It should be pushed to 3.16.x, the patch applies cleanly. ping Mason :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 11:12:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 10:12:58 +0000 Subject: [Koha-bugs] [Bug 13436] Add more options to UsageStatsLibraryType In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13436 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34500|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 34510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34510&action=edit Bug 13436: Adding more options to UsageStatsLibraryType syspref Added options: - research - private - society or association - corporate - government - religious organization - subscription - school Also changed 'university' to 'academic' To test: 1) Go on to Global System Preferences and find UsageStatsLibraryType under Administration 2) Click drop-down menu and see all new options described above, as well as 'academic' instead of 'university' Signed-off-by: Jonathan Druart Amended patch: replace tab with spaces -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 11:12:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 10:12:55 +0000 Subject: [Koha-bugs] [Bug 13436] Add more options to UsageStatsLibraryType In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13436 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 11:22:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 10:22:22 +0000 Subject: [Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #7 from Jonathan Druart --- (In reply to Marc V?ron from comment #4) > Change selection in drop box 'Sort by' > Result: No change in list. You have to change 'List name' or 'Author' to > trigger filtering. - This is confusing. Looks good here. Did you see the "processing" message? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 11:34:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 10:34:19 +0000 Subject: [Koha-bugs] [Bug 13475] OAI does not return items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13475 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Jonathan Druart --- (In reply to Katrin Fischer from comment #2) > Hi Jonathan, I think this is duplicate to 12252 - can you check the other > implementation? It's waiting for QA :) Yes it is, thanks. *** This bug has been marked as a duplicate of bug 12252 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 11:34:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 10:34:19 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #20 from Jonathan Druart --- *** Bug 13475 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 11:45:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 10:45:56 +0000 Subject: [Koha-bugs] [Bug 13465] Fields controlled by authorized values cannot be unset (Lost, damaged, not for loan status, ...) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13465 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34508|0 |1 is obsolete| | --- Comment #9 from Mirko Tietgen --- Created attachment 34511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34511&action=edit Bug 13465: Correct the field prefix ambiguity This is introduced by Bug 12874. Without this patch, it's not possible to clear (set to an empty string) an item field. This appended for field linked to an AV list but even if it's not. The regex tried to prefix 'my_field' with 'items.' to have 'items.my_field'. It wanted to take care of the case where the prefix already exists (Actually only 1: 'items.cn_source'). The regex is changed to: "add the prefix only if the string does not contain a dot". Moreover an ambiguity existed on the prefix: in marc_subfield_structure, the kohafield is prefixed, but not in the key of the hash sent to ModItemFromMarc. Test plan: - edit an item, set a status that is controlled by an authorized value examples tested: damaged, not for loan - check the status saved correctly - edit the item again, reset the status to empty - check the status saved correctly - edit the item again, reset fields, edit fields - check the fields saved correctly Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 11:46:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 10:46:27 +0000 Subject: [Koha-bugs] [Bug 13465] Fields controlled by authorized values cannot be unset (Lost, damaged, not for loan status, ...) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13465 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 11:46:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 10:46:27 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #21 from Jonathan Druart --- Comment on attachment 33121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33121 Bug 12252 - OAI-PMH items respect OpacHiddenItems Review of attachment 33121: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12252&attachment=33121) ----------------------------------------------------------------- ::: C4/Biblio.pm @@ +1263,5 @@ > +=item C<$embeditems> > + > +set to true to include item information. > + > +=item C<$opac> This new parameter will be used in all opac scripts where we want to embed items. @@ +2928,5 @@ > my @item_fields; > my ( $itemtag, $itemsubfield ) = GetMarcFromKohaField( "items.itemnumber", $frameworkcode ); > + my @items; > + my $opachiddenitems = $opac > + && ( C4::Context->preference('OpacHiddenItems') !~ /^\s*$/ ); It would have been better to use /\S/ to match the existing test. ::: opac/oai.pl @@ +280,4 @@ > > # We fetch it using this method, rather than the database directly, > # so it'll include the item data > + my $record = GetMarcBiblio($biblionumber, 1, 1); We really want to avoid this kind of calls, it's not readable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 11:49:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 10:49:29 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |m.de.rooy at rijksmuseum.nl --- Comment #22 from Jonathan Druart --- I would like to get other QA point of view here. The changes in GetMarcBiblio does not provided any tests. But none of GetMarcBiblio and EmbedItemsInMarcBiblio have tests! It would be very good nice to see these 2 subroutines tested, but should we block this patch set for this reason? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 11:53:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 10:53:14 +0000 Subject: [Koha-bugs] [Bug 13477] New: On order detail not showing Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13477 Bug ID: 13477 Summary: On order detail not showing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: imingchan at yahoo.com.au QA Contact: testopia at bugs.koha-community.org In 3.18.01, on order detail no longer showing on "Holdings" tab. This detail was showing in 3.18. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 11:58:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 10:58:04 +0000 Subject: [Koha-bugs] [Bug 13478] New: Force item holds only for specific biblios Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478 Bug ID: 13478 Summary: Force item holds only for specific biblios Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 11:58:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 10:58:20 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13478 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 11:58:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 10:58:20 +0000 Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7825 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 11:58:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 10:58:42 +0000 Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 11:58:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 10:58:59 +0000 Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 12:04:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 11:04:42 +0000 Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 12:48:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 11:48:44 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #23 from M. de Rooy --- (In reply to Jonathan Druart from comment #22) > I would like to get other QA point of view here. > > The changes in GetMarcBiblio does not provided any tests. But none of > GetMarcBiblio and EmbedItemsInMarcBiblio have tests! > It would be very good nice to see these 2 subroutines tested, but should we > block this patch set for this reason? >From a glance, it looks like adding some tests for at least EmbedItems would not be a bad thing here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 13:04:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 12:04:40 +0000 Subject: [Koha-bugs] [Bug 13428] Fix facet deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13428 --- Comment #10 from Chris Cormack --- (In reply to Jonathan Druart from comment #9) > This should not have been pushed before bug 13425, because now the facets > deletion is broken :) Yep 13425 opac changes are pushed to master, 3.18.x and 3.16.x and this only changes the opac, so needed to be pushed. > > It should be pushed to 3.16.x, the patch applies cleanly. > > ping Mason :) So yep just to 3.16.x now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 13:35:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 12:35:26 +0000 Subject: [Koha-bugs] [Bug 13407] Remove methods which are included in the 0.36 release of PDF::Reuse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 13:35:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 12:35:28 +0000 Subject: [Koha-bugs] [Bug 13407] Remove methods which are included in the 0.36 release of PDF::Reuse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34173|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 34512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34512&action=edit Bug 13407: Removing depricated code included in PDF::Reuse http://bugs.koha-community.org/show_bug.cgi?id=13407 See test plan in comment #3. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 13:37:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 12:37:11 +0000 Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 13:37:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 12:37:14 +0000 Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478 --- Comment #1 from M. de Rooy --- Created attachment 34513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34513&action=edit Bug 13478: Force item holds only for specific biblios This patch adds the option to selectively force item holds for specific biblionumbers. These numbers are saved in a separate table. The patch adds routine C4::Reserves::CheckBiblioForceItemHolds. It is tested in Reserves.t. The preference OPACItemHolds gets a new choice: selectiveforce. The description of the pref is adjusted. Please note that this option is specifically targeted for the OPAC. Staff users still have both possibilities. A follow-up patch adds the possibility for staff users to add or remove a biblio from the list of books with forced item holds. TEST PLAN: [ 1] Run the database revision. [ 2] Run the unit test t/db_dependent/Reserves.t. [ 3] Set OPACItemHolds to force. [ 4] Add a hold in the OPAC; verify that you cannot place a next/av hold. [ 5] Set OPACItemHolds to Allow. [ 6] Add a hold in the OPAC; verify that you can place both hold types. [ 7] Set OPACItemHolds to Do not allow. [ 8] Add a hold in the OPAC; verify that you can only place next/av holds. [ 9] Add two biblio numbers into table biblio_force_item_holds. [10] Set OPACItemHolds to Selectively force. [11] Add a hold on three biblionumbers at once (including these two). Verify that you have two hold types for the single biblio and that you have only item holds for the two other biblios. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 13:38:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 12:38:21 +0000 Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478 --- Comment #2 from M. de Rooy --- I will open a new report to add the option of adding to the list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 13:40:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 12:40:52 +0000 Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 13:41:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 12:41:52 +0000 Subject: [Koha-bugs] [Bug 13263] Printing Callnumber in Koha 3.16.04.000. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13263 Jerwyn changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 13:42:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 12:42:57 +0000 Subject: [Koha-bugs] [Bug 13407] Remove methods which are included in the 0.36 release of PDF::Reuse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #6 from M. Tompsett --- It should be noted, I actually attempted to find the individual tests that triggered it. t/Label* t/Patron* t/Creator* if I recall correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 14:12:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 13:12:44 +0000 Subject: [Koha-bugs] [Bug 13479] New: Add option to add/remove biblios from list of books with forced item holds Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13479 Bug ID: 13479 Summary: Add option to add/remove biblios from list of books with forced item holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com This report is a follow-up for bug 13478. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 14:15:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 13:15:36 +0000 Subject: [Koha-bugs] [Bug 13479] Add option to add/remove biblios from list of books with forced item holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13479 --- Comment #1 from M. de Rooy --- Some ideas to start with: Option for specific biblio can be set/unset on staff catalog detail page. Might be interesting to add the option for item types too. For some item types you may want to force item holds. Add a script that allows you to incidentally add or remove books from the list under specified conditions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 14:17:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 13:17:30 +0000 Subject: [Koha-bugs] [Bug 13479] Add option to add/remove biblios from list of books with forced item holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13479 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13478 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 14:17:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 13:17:30 +0000 Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13479 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 14:37:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 13:37:38 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #9 from Koha Team Lyon 3 --- I'm interrested by this feature, if you need someone to test, I'm volunteer. Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 14:44:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 13:44:38 +0000 Subject: [Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #8 from Marc V?ron --- Created attachment 34514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34514&action=edit [Signed-off] Bug 13419: Add server-side processing for lists This patch adds DataTables using a server-side processing to display lists (virtual shelves). Test plan: 1/ Go on virtualshelves/shelves.p 2/ Play with the table functions (sort, filter, pagination, etc.) 3/ Go with the Public lists tab and verify the table is correctly filtered. Tested together with patch #2, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 14:46:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 13:46:25 +0000 Subject: [Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34242|0 |1 is obsolete| | --- Comment #9 from Marc V?ron --- Created attachment 34515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34515&action=edit Bug 13419: Add filters on the list table Tested together with patch #1, works as expected Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 14:51:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 13:51:54 +0000 Subject: [Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34241|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 14:52:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 13:52:42 +0000 Subject: [Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34515|Bug 13419: Add filters on |[Signed-off] Bug 13419: Add description|the list table |filters on the list table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 15:01:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 14:01:50 +0000 Subject: [Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #10 from Marc V?ron --- For patch #3 "Add tests" I get errors # Failed test 'There should be 12 public shelves in total' # at t/db_dependent/Utils/Datatables_Virtualshelves.t line 199. # got: '15' # expected: '12' # Failed test 'There should be 12 private shelves' # at t/db_dependent/Utils/Datatables_Virtualshelves.t line 202. # got: '15' # expected: '12' # Failed test 'There should be 12 public shelves in total' # at t/db_dependent/Utils/Datatables_Virtualshelves.t line 214. # got: '15' # expected: '12' # Failed test 'There should be 12 public shelves in total' # at t/db_dependent/Utils/Datatables_Virtualshelves.t line 230. # got: '15' # expected: '12' # Looks like you failed 4 tests of 13. However if I remove all public lists, it passes OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 15:02:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 14:02:50 +0000 Subject: [Koha-bugs] [Bug 13480] New: Add ActionLog for changes to System Preferences Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13480 Bug ID: 13480 Summary: Add ActionLog for changes to System Preferences Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Transaction logs Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org For support purposes, it would be helpful to be able to track which user made changes to system preferences. I have a systems librarian who is trying to track down who made changes to their sysprefs, and I don't have any answers to who did it or when. This would involve adding a 'SysprefLog' system preference, as well as code that would log the actions of changing system preferences. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 15:11:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 14:11:40 +0000 Subject: [Koha-bugs] [Bug 13480] Add ActionLog for changes to System Preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13480 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Barton Chittenden --- It turns out this is already logged. Never mind. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 15:28:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 14:28:59 +0000 Subject: [Koha-bugs] [Bug 8096] Card number twice on patron search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8096 --- Comment #8 from Marc V?ron --- Patch still applies with current master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 15:41:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 14:41:22 +0000 Subject: [Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #11 from Jonathan Druart --- Created attachment 34516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34516&action=edit Bug 13419: (follow-up) Add tests - remove existing shelves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 15:42:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 14:42:01 +0000 Subject: [Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #12 from Jonathan Druart --- (In reply to Marc V?ron from comment #10) > For patch #3 "Add tests" I get errors Good catch Marc, thanks for testing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 15:57:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 14:57:38 +0000 Subject: [Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34243|0 |1 is obsolete| | --- Comment #13 from Marc V?ron --- Created attachment 34517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34517&action=edit Bug 13419: Add tests Test plan: prove t/db_dependent/Utils/Datatables_Virtualshelves.t should return green Tested together with follow-up, works as expected Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 15:59:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 14:59:10 +0000 Subject: [Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34517|Bug 13419: Add tests |[Signed-off] Bug 13419: Add description| |tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 16:00:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 15:00:27 +0000 Subject: [Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #14 from Marc V?ron --- Created attachment 34518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34518&action=edit [Signed-off] Bug 13419: (follow-up) Add tests - remove existing shelves Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 16:00:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 15:00:55 +0000 Subject: [Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 16:57:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 15:57:08 +0000 Subject: [Koha-bugs] [Bug 4148] Advanced Search not sorting by author In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4148 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 20:16:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 19:16:29 +0000 Subject: [Koha-bugs] [Bug 13481] New: if single library don't have libraries option on circ & fine rules Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13481 Bug ID: 13481 Summary: if single library don't have libraries option on circ & fine rules Change sponsored?: --- Product: Koha Version: master Hardware: All URL: cgi-bin/koha/admin/smart-rules.pl?branch=* OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If the system has only 1 library I don't think we should have Library pull down at the top of the circ & fine rules page. It just confuses things because single libraries don't realize that there are 2 places where they might have rules. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 20:44:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 19:44:16 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 --- Comment #18 from Jacek Ablewicz --- (In reply to Chris Cormack from comment #16) > > +use C4::Context; > > We can't do this. We just added a big circular dependency if we do. > > Because C4::Context uses Koha::Cache Not in the current master (?), but it indeed will be used after bug 11998 (I was under the impression that bug got already pushed). But it looks like this line is not even necessary: in all places where Koha::Cache is used so far, C4::Context is already loaded. Making such assumption is probably not very good practice, but this code part (which includes database name etc. in the sharefile name) is intended only as temporary (= until namespace configuration issue gets dealt with properly) solution for severely misconfigured multi-instance setups. So maybe we can live with that ;) if some extra precautions will be taken (like putting that code part in the eval {} block + some warn "Unable to determine database name due to .." maybe ?). > @@ +162,5 @@ > > sub _initialize_fastmmap { > > my ($self) = @_; > > + my $share_file = join( '-', > > + "/tmp/sharefile-koha", $self->{'namespace'}, > > + C4::Context->config('hostname'), C4::Context->config('database'), > > A better way to do this is is to change the places that call > Koha::Cache->new() > To set the namespace. > > EG my $cache = Koha::Cache-new({cache_type => 'memcached_cache', namespace > => C4::Context->config('hostname') . '-' .C4::Context->config('database')}); That would make Koha::Cache usage a bit inconvenient IMO, especially as Koha::Cache->new() is currently never called outside of Koha::Cache itself, Koha::Cache->get_instance() is always used instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 21:33:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 20:33:53 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 --- Comment #19 from Jacek Ablewicz --- (In reply to Robin Sheat from comment #17) > Yeah, it's not recommended to use fastmmap_cache unless you have good cause > to due to it not supporting expiry. That comment in Koha/Cache.pm "fastmmap .. doesn't support expiry in a useful way" is quite puzzling; I'm unable to find anything specific anywhere regarding what exactly is wrong with it's expiry mechanism - ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 22:05:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 21:05:58 +0000 Subject: [Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 23:16:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 22:16:20 +0000 Subject: [Koha-bugs] [Bug 13296] error when using z3950 with UNIMARC authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13296 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer --- This doesn't work for me on current master, I retested, but I only get an empty datatable showing lots of pages. There is lots of noise in the logs, not sure what's wrong. Can you please retest your patch on current master? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 23:19:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 22:19:42 +0000 Subject: [Koha-bugs] [Bug 13476] Item Search feature gets datatables error and doesn't complete search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13476 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Depends on| |11425 --- Comment #1 from Katrin Fischer --- I can confirm the bug on 3.18.1, the search is currently not working. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 23:19:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 22:19:42 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13476 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 23:19:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 22:19:48 +0000 Subject: [Koha-bugs] [Bug 13476] Item Search feature gets datatables error and doesn't complete search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13476 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 23:23:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 22:23:06 +0000 Subject: [Koha-bugs] [Bug 13476] Item Search feature gets datatables error and doesn't complete search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13476 --- Comment #2 from Katrin Fischer --- Also confirmed on current master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 23:30:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 22:30:06 +0000 Subject: [Koha-bugs] [Bug 13465] Fields controlled by authorized values cannot be unset (Lost, damaged, not for loan status, ...) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13465 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 23:30:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 22:30:09 +0000 Subject: [Koha-bugs] [Bug 13465] Fields controlled by authorized values cannot be unset (Lost, damaged, not for loan status, ...) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13465 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34511|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 34519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34519&action=edit [PASSED QA] Bug 13465: Correct the field prefix ambiguity This is introduced by Bug 12874. Without this patch, it's not possible to clear (set to an empty string) an item field. This appended for field linked to an AV list but even if it's not. The regex tried to prefix 'my_field' with 'items.' to have 'items.my_field'. It wanted to take care of the case where the prefix already exists (Actually only 1: 'items.cn_source'). The regex is changed to: "add the prefix only if the string does not contain a dot". Moreover an ambiguity existed on the prefix: in marc_subfield_structure, the kohafield is prefixed, but not in the key of the hash sent to ModItemFromMarc. Test plan: - edit an item, set a status that is controlled by an authorized value examples tested: damaged, not for loan - check the status saved correctly - edit the item again, reset the status to empty - check the status saved correctly - edit the item again, reset fields, edit fields - check the fields saved correctly Signed-off-by: Mirko Tietgen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 23:36:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 22:36:53 +0000 Subject: [Koha-bugs] [Bug 13416] Typo in marc21_leader.pl position 5 (record status) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 18 23:36:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Dec 2014 22:36:57 +0000 Subject: [Koha-bugs] [Bug 13416] Typo in marc21_leader.pl position 5 (record status) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34452|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 34520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34520&action=edit [PASSED QA] Bug 13416: Typo in marc21_leader.pl position 5 (record status) Instead of a space in the leader on this position, it should be an a. Test plan: 1) Log in to staff client 2) Find a record in the catalog 3) Edit the record 4) Click the on builder popup icon. 5) View the page source -- the option is " " for the 'a- Increase in encoding level' entry. It really should be 'a'. 6) Apply patch. 7) Repeat steps 1-5 -- the option should be 'a' this time. 8) Run koha qa test tools. -- Discovered it failed. Provided a patch to fix this. It does, however, solve the major problem of ' ' vs. 'a'. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 01:09:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 00:09:33 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21954|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 02:47:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 01:47:55 +0000 Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 --- Comment #8 from Winona Salesky --- Okay. I think a reasonable approach would be to leave off subfield c, and add a test if a record accidentally has a 245$h and a 337 and only show one. -Winona -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 02:52:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 01:52:25 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 --- Comment #20 from Robin Sheat --- (In reply to Jacek Ablewicz from comment #19) > That comment in Koha/Cache.pm "fastmmap .. doesn't support expiry in a > useful way" is quite puzzling; I'm unable to find anything specific anywhere > regarding what exactly is wrong with it's expiry mechanism - ? I can't remember now, there is/was something it doesn't do that we needed for consistency, but I'm unsure of the details. Looking at Cache::FastMmap now, it might be that you can't set the expiry timeout on individual writes, you can only set it globally. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 03:10:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 02:10:58 +0000 Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 --- Comment #9 from Winona Salesky --- Just for clarification, there is currently no "Media type" in the record. We want to add a test to check for 337, if no 337, show 245$h? Thank you. -Winona -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 04:46:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 03:46:42 +0000 Subject: [Koha-bugs] [Bug 13443] DBD::mysql::db do failed: Table 'koha_library.roadtype' doesn't exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13443 vimal kumar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #1 from vimal kumar --- I have solved the problem. Please follow the steps, Open a terminal sudo su leafpad /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl Search > Jump To > 7985 Find the line $dbh->{RaiseError} = 0; Change the value 1 to 0. Save file. Go back to koha and refresh the page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 04:47:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 03:47:23 +0000 Subject: [Koha-bugs] [Bug 5377] Database fields too small for multiple ISBN and ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377 vimal kumar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vimal0212 at gmail.com Version|master |3.16 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 05:16:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 04:16:39 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #10 from David Cook --- (In reply to Koha Team Lyon 3 from comment #9) > I'm interrested by this feature, if you need someone to test, I'm volunteer. > > Sonia BOUIS Great! Thanks, Sonia :). I think that I have the main engine working, but I got distracted by DBIx::Class::Schema and some local work projects, so I haven't finished the UI, the documentation, or the unit tests yet. At the moment, I have another project taking priority over this one, but the OAI-PMH harvester is #2 on my list of projects. Hopefully, I'll be able to look at this soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 06:44:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 05:44:45 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 --- Comment #21 from Jacek Ablewicz --- (In reply to Robin Sheat from comment #20) > Looking at Cache::FastMmap now, it might be that you can't set the expiry > timeout on individual writes, you can only set it globally. There seems to be a lot of confusing reports on the net regarding this subject, but setting expiry timeout separately for individual cache entries is supported since version 1.23 or so (although this particular feature is still apparently not documented in any meaningful way). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 07:21:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 06:21:41 +0000 Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 --- Comment #10 from David Cook --- (In reply to Winona Salesky from comment #9) > Just for clarification, there is currently no "Media type" in the record. We > want to add a test to check for 337, if no 337, show 245$h? > > Thank you. > -Winona I'm not sure I understand. Do you mean that the XSLT doesn't currently show the 337? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 07:56:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 06:56:40 +0000 Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 --- Comment #11 from Katrin Fischer --- (In reply to Winona Salesky from comment #9) > Just for clarification, there is currently no "Media type" in the record. We > want to add a test to check for 337, if no 337, show 245$h? > > Thank you. > -Winona The logic sounds right to me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 09:46:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 08:46:12 +0000 Subject: [Koha-bugs] [Bug 13296] error when using z3950 with UNIMARC authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13296 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #8 from Jonathan Druart --- (In reply to Katrin Fischer from comment #7) > This doesn't work for me on current master, I retested, but I only get an > empty datatable showing lots of pages. There is lots of noise in the logs, > not sure what's wrong. Can you please retest your patch on current master? Retested right now, the table is correctly filled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 10:32:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 09:32:09 +0000 Subject: [Koha-bugs] [Bug 13476] Item Search feature gets datatables error and doesn't complete search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13476 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 10:32:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 09:32:11 +0000 Subject: [Koha-bugs] [Bug 13476] Item Search feature gets datatables error and doesn't complete search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13476 --- Comment #3 from Jonathan Druart --- Created attachment 34521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34521&action=edit Bug 13476: Fix DataTables for the search items form This items form is broken since the upgrade to DataTables 1.10.2 (commit 954c2874d0d9ebfa2e910dcd4445010115fac329). The fnServerParams does not work anymore. Test plan: Go on catalogue/itemsearch.pl, launch a search and verify the data are correctly displayed in the table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 10:32:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 09:32:29 +0000 Subject: [Koha-bugs] [Bug 13476] Item Search feature gets datatables error and doesn't complete search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13476 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 10:55:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 09:55:02 +0000 Subject: [Koha-bugs] [Bug 12085] Allow staff to place multiple reserves for the same patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12085 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 34522 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34522&action=edit Bug 12085 - Allow staff to place multiple reserves for the same patron This requires rather large changes to C4/Reserves.pm, because it didn't use the reserve_id to distinguish the reserves. -Remove all vestiges of reserveconstraints -table from the code. -Make Reserves use ID numbers as much as possible, instead of matching with patron number, bibnum, and date. -Allow the same patron reserve the same item multiple times, but only via staff client. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 10:55:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 09:55:24 +0000 Subject: [Koha-bugs] [Bug 12085] Allow staff to place multiple reserves for the same patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12085 --- Comment #2 from Olli-Antti Kivilahti --- Created attachment 34523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34523&action=edit Bug 12085 - Allow staff to place multiple reserves for the same patron. Fix wrong branch from hold-transfer-slip.pl 1. Place lots of reservations for one borrower to be picked up from multiple branches. 2. Start checking the books in and catching the resevations. 3. Observe that the hold-transfer-slip is always for the first unsatisfied hold for the biblionumber, regardless of which hold is received. This only appears when checking-in multiple same biblios. This patch fixes that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 10:56:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 09:56:05 +0000 Subject: [Koha-bugs] [Bug 12085] Allow staff to place multiple reserves for the same patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12085 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27121|0 |1 is obsolete| | CC| |olli-antti.kivilahti at jns.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 10:58:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 09:58:00 +0000 Subject: [Koha-bugs] [Bug 12085] Allow staff to place multiple reserves for the same patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12085 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Component|Staff Client |Hold requests Version|master |3.16 --- Comment #3 from Olli-Antti Kivilahti --- Rebased for 3.16.4. Will rebase to master some day with unit tests. Feel free to rip this code to whatever evil purposes. As long as they are sufficiently evil to get this feature to master :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 11:07:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 10:07:30 +0000 Subject: [Koha-bugs] [Bug 13470] pay fines with extended borrower attributes result in application error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13470 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34501|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 34524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34524&action=edit Bug 13470 - pay fines with extended borrower attributes result in application error Test scenario: 1. ensure that extended patron attributes are turned on in system preferences 2. find borrower which has fine to pay, and click on pay button 3. verify application error 4. apply patch and verify that application error is gone Signed-off-by: Aleisha Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 11:07:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 10:07:27 +0000 Subject: [Koha-bugs] [Bug 13470] pay fines with extended borrower attributes result in application error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13470 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 11:09:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 10:09:38 +0000 Subject: [Koha-bugs] [Bug 13470] pay fines with extended borrower attributes result in application error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13470 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Depends on| |12542 --- Comment #7 from Jonathan Druart --- Bug reproduced, I confirm this patch fixes the issue. No regression found. Bug introduced by bug 12542. Note that the pref value is not used by paycollect.tt (which uses circ-menu.tt, not circ-menu.inc). We could remove it, but to be consistent it is better to keep it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 11:09:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 10:09:38 +0000 Subject: [Koha-bugs] [Bug 12542] Tabs inconsistency in different circ-menu.inc uses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12542 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13470 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 11:11:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 10:11:59 +0000 Subject: [Koha-bugs] [Bug 13456] Serials/Claims.t expects no subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13456 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 11:12:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 10:12:01 +0000 Subject: [Koha-bugs] [Bug 13456] Serials/Claims.t expects no subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13456 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34480|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 34525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34525&action=edit Bug 13456: Serials/Claims.t expects no subscriptions However, this is an unreasonable assumption for a system which is in use (either lots of testing or production). TEST PLAN --------- 1) Have a supplier with a late subscription. 2) prove t/db_dependent/Serials/Claims.t -- will fail 3) apply patch 4) prove t/db_dependent/Serials/Claims.t -- success 5) run koha qa test tools Signed-off-by: Paola Rossi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 11:12:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 10:12:14 +0000 Subject: [Koha-bugs] [Bug 13456] Serials/Claims.t expects no subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13456 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m QA Contact|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 11:12:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 10:12:22 +0000 Subject: [Koha-bugs] [Bug 13456] Serials/Claims.t expects no subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13456 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 11:27:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 10:27:31 +0000 Subject: [Koha-bugs] [Bug 9743] Allow customization for making hold notes required In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 11:27:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 10:27:34 +0000 Subject: [Koha-bugs] [Bug 9743] Allow customization for making hold notes required In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34422|0 |1 is obsolete| | --- Comment #32 from M. de Rooy --- Created attachment 34526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34526&action=edit Bug 9743: Allow customization for making hold notes required This patch removes some unused code in the reserves template for mandatory hold notes reasons. It adds a simpler approach: if you define a custom routine for required hold notes, the textarea is required under the conditions you specified. Test plan: [1] Without adding a routine in opac-reserve: Place a hold on one and on more biblio numbers. Verify that hold notes are not required in any case. [2] Add the following simple routine to opac-reserve: sub _reqholdnotes { 1; } Verify that hold notes are always required now. [3] Place a multiple hold request and check the following: If you hide the hold notes (and leave them blank), the additional options (incl. hold notes) should expand again for the first biblio with required hold notes when submitting the form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 11:40:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 10:40:12 +0000 Subject: [Koha-bugs] [Bug 12085] Allow staff to place multiple reserves for the same patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12085 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #4 from M. de Rooy --- (In reply to Olli-Antti Kivilahti from comment #3) > Rebased for 3.16.4. > Will rebase to master some day with unit tests. > > Feel free to rip this code to whatever evil purposes. > As long as they are sufficiently evil to get this feature to master :) It will certainly have my attention if you rebase it on master :) And the opac side (there is already a report in FQA or DNA for that..) ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 11:42:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 10:42:27 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #22 from Jonathan Druart --- I don't know if it is relevant, but maybe should we provide a quick fix like: if ( can_load( modules => { 'Cache::FastMmap' => undef } ) ) { - _initialize_fastmmap($self); - if ( $self->{'default_type'} eq 'fastmmap' - && defined( $self->{'fastmmap_cache'} ) ) - { - $self->{'cache'} = $self->{'fastmmap_cache'}; + eval { + _initialize_fastmmap($self); + if ( $self->{'default_type'} eq 'fastmmap' + && defined( $self->{'fastmmap_cache'} ) ) + { + $self->{'cache'} = $self->{'fastmmap_cache'}; + } + }; + if ( $@ ) { + warn "Cannot initialize FastMmap: $@"; } } In any case the application should crash if the cache is not correctly initialized. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 11:45:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 10:45:37 +0000 Subject: [Koha-bugs] [Bug 13457] Suggestions.t expects sample itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13457 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- The tests don't pass if you don't use the sample data. To me, this patch is not relevant: we should not create all data before launching tests. For instance the same test file (Suggestions.t) won't pass if you don't have the CPL branchcode and S categorycode. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 11:47:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 10:47:29 +0000 Subject: [Koha-bugs] [Bug 9958] RoutingSerials desription misleading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9958 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m, | |kyle at bywatersolutions.com --- Comment #5 from Jonathan Druart --- Native English speaker needed :) Kyle maybe? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 11:52:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 10:52:26 +0000 Subject: [Koha-bugs] [Bug 13407] Remove methods which are included in the 0.36 release of PDF::Reuse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #7 from Jonathan Druart --- Chris, shouldn't we change the minimum version of PDF::Reuse in the dependencies file? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 11:53:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 10:53:19 +0000 Subject: [Koha-bugs] [Bug 13296] error when using z3950 with UNIMARC authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13296 --- Comment #9 from Katrin Fischer --- Hi Jonathan, I am stuck then with no idea what the problem is :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 12:03:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 11:03:10 +0000 Subject: [Koha-bugs] [Bug 13335] Holds and priority display via OPACShowHoldQueueDetails confusing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13335 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 12:03:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 11:03:13 +0000 Subject: [Koha-bugs] [Bug 13335] Holds and priority display via OPACShowHoldQueueDetails confusing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13335 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33961|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 34527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34527&action=edit Bug 13335 - Holds and priority display via OPACShowHoldQueueDetails confusing No matter what the selection of OPACShowHoldQueueDetails is, if it is enabled it displays a line "Holds and priority:" even if you've opted to hide one of those! Test Plan: 1) Apply this patch 2) Test each setting of OPACShowHoldQueueDetails 3) Ensure each setting displays the correct fields ( or lack thereof ) Signed-off-by: Christopher Brannon Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 12:09:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 11:09:40 +0000 Subject: [Koha-bugs] [Bug 13482] New: A race condition prevents item info from being available for ReserveSlip (hold notice) printing. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 Bug ID: 13482 Summary: A race condition prevents item info from being available for ReserveSlip (hold notice) printing. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Occasionally the ReserveSlip doesn't have any values from the koha.items-table. There is no apparent reason why. The issue seems to be more prevalent when fulfilling holds (checkin-in) to be transferred to another branch. Traced the issues to a race condition between printing a just-fulfilled hold and writing the itemnumber to the reserves-table. Can be reproduced by entering the following to a javascript console. Dopop('hold-transfer-slip.pl?transfer=1&borrowernumber=10904891&biblionumber=469263&op=slip'); After this patch, one can confirm that it works by using this command: Dopop('hold-transfer-slip.pl?transfer=1&borrowernumber=10904891&biblionumber=469263&itemnumber=10563811&op=slip'); MAKE SURE TO REPLACE PARAMETERS WITH CORRECT VALUES. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 12:09:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 11:09:52 +0000 Subject: [Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |olli-antti.kivilahti at jns.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 12:15:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 11:15:10 +0000 Subject: [Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 34528 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34528&action=edit Bug 13482 - A race condition prevents item info from being available for ReserveSlip (hold notice) printing. Occasionally the ReserveSlip doesn't have any values from the koha.items-table. There is no apparent reason why. The issue seems to be more prevalent when fulfilling holds (checkin-in) to be transferred to another branch. Traced the issues to a race condition between printing a just-fulfilled hold and writing the itemnumber to the reserves-table. TEST PLAN: 1. Find a borrower, make a hold for him, and check-in the book to trigger the "Hold found:"-prompt. Do not Confirm it! 2. Reproduce the print error by entering the following to a javascript console at the same page. Dopop('hold-transfer-slip.pl?transfer=1&borrowernumber=10904891&biblionumber=469263&op=slip'); 3. Notice the missing item fields. After this patch, one can confirm that it works by using this command: Dopop('hold-transfer-slip.pl?transfer=1&borrowernumber=10904891&biblionumber=469263&itemnumber=10563811&op=slip'); MAKE SURE TO REPLACE PARAMETERS WITH CORRECT VALUES. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 12:15:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 11:15:20 +0000 Subject: [Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 12:22:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 11:22:08 +0000 Subject: [Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34528|0 |1 is obsolete| | --- Comment #2 from Olli-Antti Kivilahti --- Created attachment 34529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34529&action=edit Bug 13482 - A race condition prevents item info from being available for ReserveSlip (hold notice) printing. Occasionally the ReserveSlip doesn't have any values from the koha.items-table. There is no apparent reason why. The issue seems to be more prevalent when fulfilling holds (checkin-in) to be transferred to another branch. Traced the issues to a race condition between printing a just-fulfilled hold and writing the itemnumber to the reserves-table. TEST PLAN: 1. Find a borrower, make a hold for him, and check-in the book to trigger the "Hold found:"-prompt. Do not Confirm it! 2. Reproduce the print error by entering the following to a javascript console at the same page. Dopop('hold-transfer-slip.pl?transfer=1&borrowernumber=10904891&biblionumber=469263&op=slip'); 3. Notice the missing item fields. After this patch, one can confirm that it works by using this command: Dopop('hold-transfer-slip.pl?transfer=1&borrowernumber=10904891&biblionumber=469263&itemnumber=10563811&op=slip'); MAKE SURE TO REPLACE PARAMETERS WITH CORRECT VALUES. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 12:28:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 11:28:44 +0000 Subject: [Koha-bugs] [Bug 13483] New: If unconfigured nullmailer, huge log size and make host run out of space Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13483 Bug ID: 13483 Summary: If unconfigured nullmailer, huge log size and make host run out of space Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: pablo.bianchi at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com On a Koha fresh install Koha install and ask for setup info for nullmailer package. As this sometimes doesn't look mandatory is usually left unconfigured: bad mistake: This make mail.log increase in gigabytes steps until runing out of space (as Marco Moreno says on bug #12364/c1): $ ls -lahS /var/log/mail.* -rw-r----- 1 syslog adm 39G Dec 14 06:46 /var/log/mail.log.1 -rw-r----- 1 syslog adm 15G Dec 19 08:20 /var/log/mail.log -rw-r----- 1 syslog adm 11G Dec 14 06:46 /var/log/mail.err.1 -rw-r----- 1 syslog adm 4.0G Dec 19 08:20 /var/log/mail.err .err white lines like: nullmailer[938]: Sending failed: Host not found -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 13:12:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 12:12:34 +0000 Subject: [Koha-bugs] [Bug 13296] error when using z3950 with UNIMARC authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13296 --- Comment #10 from Katrin Fischer --- Jonathan and I figured the problem out - the syntax in the configuration shoudl have been USMARC, while I had chosen UNIMARC. With USMARC it works alright. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 13:13:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 12:13:49 +0000 Subject: [Koha-bugs] [Bug 13469] Unapi path to XSLTs is wrong in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13469 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34484|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 34530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34530&action=edit [PASSED QA] Bug 13469 - Unapi path to XSLTs is wrong in OPAC The Unapi path to XSLTs is wrong in the OPAC. Unfortunately, it's coded to work just for Git installs, which makes it tough to test. _TEST PLAN_ Before applying: 1) Go to http://GIT-INSTALL/cgi-bin/koha/unapi?id=koha:biblionumber:1&format=oai_dc 2) If the biblionumber exists, it should show you the record in OAI_DC format. 3) Go to http://REGULAR-INSTALL/cgi-bin/koha/unapi?id=koha:biblionumber:1&format=oai_dc 4) You should get a software error Apply the patch. After applying: 1) Refresh the page for http://yourgitinstall/cgi-bin/koha/unapi?id=koha:biblionumber:1&format=oai_dc 2) It should work exactly the same as before. Thorough testers: 1) Push the code to that regular test install 2) Try the link again. It will properly show the converted record now. Signed-off-by: Marcel de Rooy Verified that single install intrahtdocs==/usr/share/koha/clone1712/intranet/htdocs/intranet-tmpl plus "/prog/en/xslt/" is the location for the required xslt files. Script unapi in git install is still fine. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 13:13:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 12:13:45 +0000 Subject: [Koha-bugs] [Bug 13469] Unapi path to XSLTs is wrong in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13469 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 13:19:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 12:19:39 +0000 Subject: [Koha-bugs] [Bug 13296] error when using z3950 with UNIMARC authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13296 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34281|0 |1 is obsolete| | Attachment #34283|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 34531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34531&action=edit [PASSED QA] Bug 13296 - error when using z3950 with UNIMARC authorities When using a z3950 connexion with UNIMARC authorities, you get an error : Unsupported UNIMARC character encoding [ ] for XML output for UNIMARCAUTH; 100$a -> 20141119 I've seen thant Bug 2060 when adds authorities import adds a special behavior for UNIMARC : marc flavor must be UNIMARCAUTH instead of just UNIMARC. This patch adds the same behavior when using z3950 connexion and import. Test plan : - Use a UNIMARC install - Define a z3950 connexion for UNIMARC authorities - Go to Authorities module - Click on "New from Z39.50" - Perform a search => Without patch : you get the error => With patch : you get results - Import one result => You get the authoritie creation form with all datas You may check same plan with MARC21 install Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer NOTE: depending on the target, the syntax in the configuration might not be UNIMARC, but MARC21/USMARC instead! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 13:19:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 12:19:36 +0000 Subject: [Koha-bugs] [Bug 13296] error when using z3950 with UNIMARC authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13296 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 13:19:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 12:19:53 +0000 Subject: [Koha-bugs] [Bug 13296] error when using z3950 with UNIMARC authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13296 --- Comment #12 from Katrin Fischer --- Created attachment 34532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34532&action=edit [PASSED QA] Bug 13296: (follow-up) permit grep on AUTHUNIMARC I would prefer not to hide this "stuff". Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 13:48:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 12:48:47 +0000 Subject: [Koha-bugs] [Bug 13407] Remove methods which are included in the 0.36 release of PDF::Reuse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #8 from Chris Nighswonger --- (In reply to Jonathan Druart from comment #7) > Chris, shouldn't we change the minimum version of PDF::Reuse in the > dependencies file? Good catch. Patch attached. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 13:49:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 12:49:24 +0000 Subject: [Koha-bugs] [Bug 13407] Remove methods which are included in the 0.36 release of PDF::Reuse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407 --- Comment #9 from Chris Nighswonger --- Created attachment 34533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34533&action=edit Bump PDF::Reuse version requirements to the latest release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 13:55:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 12:55:36 +0000 Subject: [Koha-bugs] [Bug 10773] Replace item-level codes with names/descriptions for Label Printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 14:08:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 13:08:13 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 14:08:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 13:08:16 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34080|0 |1 is obsolete| | --- Comment #81 from Kyle M Hall --- Created attachment 34534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34534&action=edit [PASSED QA] Bug 5786 - Move AllowOnShelfHolds system preference to the Circulation Matrix C4::Reserves: * Added OnShelfHoldsAllowed() to check issuingrules * Added OPACItemHoldsAllowed() to check issuingrules * IsAvailableForItemLevelRequest() changed interface, now takes $item_record,$borrower_record; calls OnShelfHoldsAllowed() opac/opac-reserve.pl and opac/opac-search.pl: * rewrote hold allowed rule to use OPACItemHoldsAllowed() * also use OnShelfHoldsAllowed() through * IsAvailableForItemLevelRequest() templates: * Removed AllowOnShelfHolds and OPACItemHolds global flags, they now only have meaning per item type Signed-off-by: Nicole C. Engard I have tested this patch left, right and upside down for the last several months. All tests have passed. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 14:08:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 13:08:27 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 --- Comment #82 from Kyle M Hall --- Created attachment 34535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34535&action=edit [PASSED QA] Bug 5786 [QA Followup] Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 14:15:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 13:15:03 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34535|0 |1 is obsolete| | --- Comment #83 from Kyle M Hall --- Created attachment 34536 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34536&action=edit [PASSED QA] Bug 5786 [QA Followup] Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 14:26:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 13:26:34 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #84 from Katrin Fischer --- I am really keen on seeing this in Koha and I know this has been stuck for quite a while, but for the possible implications of it and because it's rather huge, I'd like to get a second sign-off and/or QA opinion. Not sure which status to set - to avoid confusion I will set "Signed off". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 14:28:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 13:28:25 +0000 Subject: [Koha-bugs] [Bug 9828] Zebra indexes useless subfields in UNIMARC 6XX In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9828 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 14:28:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 13:28:29 +0000 Subject: [Koha-bugs] [Bug 9828] Zebra indexes useless subfields in UNIMARC 6XX In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9828 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32882|0 |1 is obsolete| | --- Comment #58 from Jonathan Druart --- Created attachment 34537 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34537&action=edit Bug 9828 - Delete a duplicate line in queryparser.yaml the line "authority-number:" was wrongly duplicated This change should make t/Queryparser.t happy Signed-off-by: Jonathan Druart t/Queryparser.t and t/Search.t pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 14:34:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 13:34:21 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #74 from Kyle M Hall --- If I choose only this item for OverduesBlockRenewing, all my items are blocked from renewal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 14:35:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 13:35:58 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #34 from Jonathan Druart --- This is blocked by bug 11211. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 14:37:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 13:37:36 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #85 from Kyle M Hall --- I agree, that sounds like a good idea. I think a one more signoff should be sufficient. For that reason I'll set the status to needs signoff. That way everyone knows it's open for testing. (In reply to Katrin Fischer from comment #84) > I am really keen on seeing this in Koha and I know this has been stuck for > quite a while, but for the possible implications of it and because it's > rather huge, I'd like to get a second sign-off and/or QA opinion. > > Not sure which status to set - to avoid confusion I will set "Signed off". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 14:38:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 13:38:04 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix [Needs one more signoff] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move AllowOnShelfHolds |Move AllowOnShelfHolds |system preference to the |system preference to the |Circulation Matrix |Circulation Matrix [Needs | |one more signoff] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 14:47:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 13:47:39 +0000 Subject: [Koha-bugs] [Bug 13484] New: Suggestions should have a foreign key constraint for branchcode Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13484 Bug ID: 13484 Summary: Suggestions should have a foreign key constraint for branchcode Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The table suggestions should have a key constraint to eliminate the possibility of bad branchcodes being added to the table. Any "any library" suggestions should have a branchcode of NULL. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 14:48:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 13:48:00 +0000 Subject: [Koha-bugs] [Bug 10753] Creating suggestions for 'Any library' uses _ANY as branchcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10753 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Blocks| |13484 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 14:48:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 13:48:00 +0000 Subject: [Koha-bugs] [Bug 13484] Suggestions should have a foreign key constraint for branchcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13484 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10753 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 14:50:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 13:50:29 +0000 Subject: [Koha-bugs] [Bug 10753] Creating suggestions for 'Any library' uses _ANY as branchcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10753 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 14:50:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 13:50:31 +0000 Subject: [Koha-bugs] [Bug 10753] Creating suggestions for 'Any library' uses _ANY as branchcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10753 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34413|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 34538 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34538&action=edit [PASSED QA] Bug 10753: Any library is represented by an empty string And not with "__ANY__" Test plan: 0/ Don't apply this patch 1/ Create a suggestion for "any library" 2/ Verify suggestions.branchcode contain "__ANY__" 3/ Apply this patch and execute the updatedb entry 4/ Create a suggestion for "any library" 5/ Verify suggestions.branchcode contain "" (for both suggestions). Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 14:53:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 13:53:04 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 14:55:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 13:55:37 +0000 Subject: [Koha-bugs] [Bug 10773] Replace item-level codes with names/descriptions for Label Printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 --- Comment #6 from Dobrica Pavlinusic --- Created attachment 34539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34539&action=edit Bug 10773 - Add item-level descriptions for Label Printing This patch adds new fields ccode_description, homebranch_description, holdingbranch_description, location_description and permanent_location_description which can be used in the Label Creator to display names/descriptions instead of codes Test Plan: 1) Edit a layout in the Label Creator so that it includes any of these fields. I suggest including "homebranch_description" and perhaps "ccode_description" if you have them in your item data. 2) Add items to a batch in the Label Creator. 3) Export the batch using the layout, and view as PDF 4) Verify that you see descriptions for fields which you added -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 14:57:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 13:57:02 +0000 Subject: [Koha-bugs] [Bug 10773] Replace item-level codes with names/descriptions for Label Printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #7 from Dobrica Pavlinusic --- Adding all new fields as *_description wasn't that hard after all, and since we also need holdingbranch_description for one of our libraries I decided to throw my hat into ring and write patch with implements it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 15:04:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 14:04:20 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34041|0 |1 is obsolete| | --- Comment #13 from Paola Rossi --- Created attachment 34540 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34540&action=edit Bug 13364 - Add a call number browser in item edition page I've applied the patches against 3.19.00.000 head 13449 Everything is OK. I pass the patch to "Signed Off" status. NB: It has not been explicitly expressed by the usual sorting icons (2 vertical arrows), that the table was sortable selecting its 3 columns' titles: "Call Number", "Title", "Branch". So the user could miss that the resulting table was sortable. Anyway, if the user selected one of the 3 titles: - if the input value had been found (table with a red row with the shown value), the resulting sorted table was OK - otherwise, the green row lost its right position in the resulting sorted table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 15:05:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 14:05:19 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34108|0 |1 is obsolete| | --- Comment #14 from Paola Rossi --- Created attachment 34541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34541&action=edit Bug 13364 - fix patch - search call number does not work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 15:06:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 14:06:10 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34109|0 |1 is obsolete| | --- Comment #15 from Paola Rossi --- Created attachment 34542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34542&action=edit Bug 13364 - fix patch - searching call number < MIN or > MAX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 15:06:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 14:06:52 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34476|0 |1 is obsolete| | --- Comment #16 from Paola Rossi --- Created attachment 34543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34543&action=edit Bug 13364 - sub plugin_javascript adjust -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 15:15:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 14:15:30 +0000 Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/required fields on the suggestion form in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 15:15:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 14:15:33 +0000 Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/required fields on the suggestion form in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34324|0 |1 is obsolete| | Attachment #34325|0 |1 is obsolete| | Attachment #34326|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall --- Created attachment 34544 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34544&action=edit [PASSED QA] Bug 10848 - Allow configuration of mandatory/required fields on the suggestion form in OPAC #1/2 (part #1: changes in opac-suggestions.* script + bootstrap template) This patch: - adds a configuration option which allows to define which fields (apart from the title) should be mandatory for a patron purchase suggestion form in OPAC - impoves the method how required form fields are enforced, by utilising new HTML5 "required" attribute (old method would still be operational in old/legacy browsers which do not support "required" attribute properly). Allowed fields that are configurable as mandatory/not mandatory for suggestions made via OPAC are: author|copyrightdate|collectiontitle| isbn|publishercode|place|note|itemtype|patronreason. Note: this patch only applies to OPAC bootstrap theme. To test: 1/ Apply patch. 2/ Without 'OPACSuggestionMandatoryFields' option set, OPAC suggestion form should only require the title field. 3/ Set 'OPACSuggestionMandatoryFields' syspref to (e.g.) 'author|isbn|itemtype' 4/ Note that suggestion form in OPAC now requires 3 more fields to be entered and/or choosen (they should be labeled in red), and the user instruction changes slightly ("Form fields labeled in red are mandatory" ..). 5/ Try to submit some suggestions: for each field which is configured as mandatory, browser should enforce this field to be filled (in modern, HTML5 compilant browsers), or (as a fallback mechanism for legacy browsers) there should be an alert message displayed stating that some mandatory fields are missing. 6/ In both modern and legacy browsers, unless all mandatory fields are filled with something, form submission should not be possible. 7/ Repeat test 3-6 for all supported field names configurable as mandatory. If possible, "legacy" browser tests should ideally involve IE9 and (some older version of) Safari, which are rumored to have somehow questionable reputation regarding "required" HTML attribute support. Signed-off-by: Valerie Bertrand Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 15:15:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 14:15:42 +0000 Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/required fields on the suggestion form in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 --- Comment #22 from Kyle M Hall --- Created attachment 34545 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34545&action=edit [PASSED QA] Bug 10848 - Allow configuration of mandatory/required fields on the suggestion form in OPAC #2/2 (part #2: new syspref 'OPACSuggestionMandatoryFields' + DB updates) Signed-off-by: Nick Clemens Signed-off-by: Valerie Bertrand Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 15:15:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 14:15:45 +0000 Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/required fields on the suggestion form in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 --- Comment #23 from Kyle M Hall --- Created attachment 34546 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34546&action=edit [PASSED QA] Bug 10848 [QA Followup] - Allow configuration of mandatory/required fields on the suggestion form in OPAC #2/2 QA follow-up for part #2: fixed OPACSuggestionMandatoryFields system preference description. Signed-off-by: Valerie Bertrand Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 15:15:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 14:15:47 +0000 Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/required fields on the suggestion form in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 --- Comment #24 from Kyle M Hall --- Created attachment 34547 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34547&action=edit Bug 10848 [QA Followup] - Title should behave the same as other required fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 15:20:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 14:20:28 +0000 Subject: [Koha-bugs] [Bug 9958] RoutingSerials desription misleading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9958 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 15:20:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 14:20:30 +0000 Subject: [Koha-bugs] [Bug 9958] RoutingSerials desription misleading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9958 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34445|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 34548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34548&action=edit [PASSED QA] Bug 9958: Improve RoutingSerials sys pref description The RoutingSerials preference controls if the routing list related functionality is visible in the serials module. To test: - Go to the system preference editor - RoutingSerials - Check the current description - Apply patch - Check the new description - Verify functionality matches description NOTE: The preference change is merely cosmetic. The value is still YesNo. A few git reset --hard origin/master and page refreshes confirmed expected values. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 15:27:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 14:27:05 +0000 Subject: [Koha-bugs] [Bug 13119] Use XSLT to display tagged titles in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13119 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33118|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 34549 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34549&action=edit Bug 13119 - Use XSLT to display tagged titles in the OPAC This patch updates the display of a logged-in user's tagged titles to use the same XSLT stylesheet used by search results and Lists. This would make for a more consistent display of information. Unrelated change: Corrected "My tags" header to read "Your tags," consistent with sidebar navigation. To test you should have multiple titles in your catalog which you have tagged in the OPAC. - Set the OPACXSLTResultsDisplay system preference to 'default' - Log in to the OPAC and view the "your tags" page. - Confirm that title information is displayed correctly. Compare to search results. - Empty the OPACXSLTResultsDisplay system preference and reload the "your tags" page. The display should revert to the old view, showing title, subtitle (if any) and author (if any). - Set the OPACXSLTResultsDisplay to a custom path pointing to a custom XSL file and confirm that the list of your tagged titles changes accordingly. Note: A follow-up will add "action" links ("place hold," "add to cart," etc) consistent with other pages. Signed-off-by: Frederic Demians Works as described. opac-tag.pl page displays tagged titles the same way as result & list pages. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 15:27:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 14:27:03 +0000 Subject: [Koha-bugs] [Bug 13119] Use XSLT to display tagged titles in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13119 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 15:40:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 14:40:38 +0000 Subject: [Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #3 from Marc V?ron --- I could replicate the issue: Login to Opac with wrong credentials - username only - password only - wrong username and/or password See page witn message "You entered an incorrect username or password." Hit Button "Login" Result: Software error: Can't use an undefined value as an ARRAY reference at /usr/lib/perl5/DBI.pm line 2054. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 15:40:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 14:40:38 +0000 Subject: [Koha-bugs] [Bug 11814] Serial statuses should be stored in constants In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11814 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle at bywatersolutions.com --- Comment #19 from Kyle M Hall --- Seems to be causing Serials.t to fail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 15:49:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 14:49:30 +0000 Subject: [Koha-bugs] [Bug 11814] Serial statuses should be stored in constants In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11814 --- Comment #20 from Jonathan Druart --- Created attachment 34550 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34550&action=edit Bug 11814: Fix existing tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 15:49:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 14:49:28 +0000 Subject: [Koha-bugs] [Bug 11814] Serial statuses should be stored in constants In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11814 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 15:50:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 14:50:57 +0000 Subject: [Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #4 from Marc V?ron --- With patch the error can no longer be replicated. Switch to "Needs Signoff" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 15:56:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 14:56:45 +0000 Subject: [Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31698|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Created attachment 34551 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34551&action=edit Bug 12954 - Questionable logic regarding session handling in C4::Auth::checkauth() Note: This is probably not quite proper patch for this bug (and for sure not the best possible approach for fixing it); uploaded only as reference/proof of concept etc. While it does seem to fix the problem described in Bug 12954 comment #0, it most likely does have some side effects regarding anonymous search history storage and handling. I could replicate the issue without patch. The issue is no longer replicatable with patch. I sign off because the patch removes a "Software error" on Opac. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 15:59:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 14:59:10 +0000 Subject: [Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:00:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:00:08 +0000 Subject: [Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27584|0 |1 is obsolete| | CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:00:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:00:39 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:00:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:00:42 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34393|0 |1 is obsolete| | Attachment #34394|0 |1 is obsolete| | Attachment #34395|0 |1 is obsolete| | Attachment #34396|0 |1 is obsolete| | Attachment #34397|0 |1 is obsolete| | Attachment #34398|0 |1 is obsolete| | Attachment #34399|0 |1 is obsolete| | Attachment #34400|0 |1 is obsolete| | Attachment #34401|0 |1 is obsolete| | Attachment #34402|0 |1 is obsolete| | --- Comment #86 from Kyle M Hall --- Created attachment 34552 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34552&action=edit [PASSED QA] Bug 11395: Add a batch record modification This patch offers a new tool to modify records in a batch. This feature adds: - a new pl/tt files tools/batch_record_modification - a new permission: tools > records_batchmod Test plan for biblios: 0/ Create a new marc modification template with some actions. 1/ Generate a list of biblionumbers you want to modify. There are two ways to generate a list of biblionumbers: - using the basket: do a search, add some biblio to your basket, open the basket and click on the "Action" button > "Modify" - generating a list from a report 2/ On the "Batch record modification" tool verify: - information is correct. - the preview link show you the needed record. 3/ After clicking on the "Modify selected recors" button, verify the records have been modified as you wanted. Test plan for authority: 0/ Create a new marc modification template with some actions. 1/ Generate a list of authid using a report: 2/ On the "Batch record modification" tool verify: - authorities are display with the summary. - the preview link show you the needed record. 3/ After clicking on the "Modify selected recors" button, verify the records have been modified as you wanted. Catch of errors: if an error occurs during the modification process, the tool displays an error message. Signed-off-by: Brendan Gallagher Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:01:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:01:05 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34552|0 |1 is obsolete| | --- Comment #87 from Kyle M Hall --- Created attachment 34553 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34553&action=edit [PASSED QA] Bug 11395: Add a batch record modification This patch offers a new tool to modify records in a batch. This feature adds: - a new pl/tt files tools/batch_record_modification - a new permission: tools > records_batchmod Test plan for biblios: 0/ Create a new marc modification template with some actions. 1/ Generate a list of biblionumbers you want to modify. There are two ways to generate a list of biblionumbers: - using the basket: do a search, add some biblio to your basket, open the basket and click on the "Action" button > "Modify" - generating a list from a report 2/ On the "Batch record modification" tool verify: - information is correct. - the preview link show you the needed record. 3/ After clicking on the "Modify selected recors" button, verify the records have been modified as you wanted. Test plan for authority: 0/ Create a new marc modification template with some actions. 1/ Generate a list of authid using a report: 2/ On the "Batch record modification" tool verify: - authorities are display with the summary. - the preview link show you the needed record. 3/ After clicking on the "Modify selected recors" button, verify the records have been modified as you wanted. Catch of errors: if an error occurs during the modification process, the tool displays an error message. Signed-off-by: Brendan Gallagher Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:01:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:01:13 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #88 from Kyle M Hall --- Created attachment 34554 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34554&action=edit [PASSED QA] Bug 11395: Add links to the new tool page This patch adds links in the tool module to the new batch tool and in the basket. Signed-off-by: Brendan Gallagher Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:01:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:01:17 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #89 from Kyle M Hall --- Created attachment 34555 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34555&action=edit [PASSED QA] Bug 11395: New service to preview a record. The main patch adds the ability to preview a record. This is done using an AJAX way. The preview record is processed on the server side. Note: I don't think an authentification check is necessary here. Signed-off-by: Brendan Gallagher Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:01:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:01:23 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #90 from Kyle M Hall --- Created attachment 34556 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34556&action=edit [PASSED QA] Bug 11395: The modification template should be changed on the list view This patch fixes the following issue: If the user comes from a basket, the list view is displayed but there is no way to select the modification template. Now the template can be chosen on the list view. This way, the user is able to change the modifications to apply and see the previewed records. Signed-off-by: Brendan Gallagher Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:01:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:01:35 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #92 from Kyle M Hall --- Created attachment 34558 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34558&action=edit [PASSED QA] Bug 11395: Fix path for the checkboxes jQuery plugin This patch fixes a bad resolution conflict (bug 12107). Signed-off-by: Brendan Gallagher Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:01:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:01:31 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #91 from Kyle M Hall --- Created attachment 34557 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34557&action=edit [PASSED QA] Bug 11395: DB: Add permission tools_records_batchmod Signed-off-by: Brendan Gallagher Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:01:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:01:40 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #93 from Kyle M Hall --- Created attachment 34559 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34559&action=edit [PASSED QA] Bug 11395: prevent processing no record If no record is selected, the modification should not be launched. Signed-off-by: Brendan Gallagher Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:01:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:01:49 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #94 from Kyle M Hall --- Created attachment 34560 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34560&action=edit [PASSED QA] Bug 11395: Raise an alert if control field is used If a control field is used with a copy or move action, the interface should block the user in some cases: - If a control field is used with a regular field - The subfield should be empty Signed-off-by: Brendan Gallagher Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:01:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:01:47 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23507|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:01:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:01:53 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #95 from Kyle M Hall --- Created attachment 34561 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34561&action=edit [PASSED QA] Bug 11395: exit should be done after displaying the output Signed-off-by: Brendan Gallagher Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:01:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:01:55 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23508|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:01:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:01:57 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #96 from Kyle M Hall --- Created attachment 34562 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34562&action=edit [PASSED QA] Bug 11395: A control field is a field with tag < 10 This patch fixes the existing test about control fields. A control field is < 10, not <=10! Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:02:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:02:00 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32181|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:02:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:02:06 +0000 Subject: [Koha-bugs] [Bug 11395] Batch modifications for records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32182|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:03:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:03:47 +0000 Subject: [Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Jonathan Druart --- On master, you can set a firstname+surname as guarantor. You are not forced to choose an existing patron. With you patch, pref enabled, it's not possible to do that. Worse, if you try to edit a patron without guarantorid, you are not allowed to save any changes. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:06:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:06:22 +0000 Subject: [Koha-bugs] [Bug 7561] cannot fast catalog with fast cataloging permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7561 --- Comment #4 from Nicole C. Engard --- Is anyone else seeing this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:18:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:18:00 +0000 Subject: [Koha-bugs] [Bug 13430] Serial enumeration not visible when handling Serial Items. Show enumerations for Serial Items in the circ- and member-modules. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13430 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |paola.rossi at cineca.it --- Comment #4 from Paola Rossi --- I've applied the first patch against master 3.19.00.000 About this step: >TEST PLAN (HOLDS ENUMERATED): >1. Make a reservation of two of the Serial Items for the Borrower and the Child, totaling 4 reservations. I tried to place the second hold/reservation on a serial for the same "Borrower", but koha immediately warned me so: Cannot place hold Borrower already has a hold on this item and, after selecting the "Place hold" button, koha prevented me from placing the hold by the message: - This patron had already placed a hold on this item Please cancel the previous hold first I could not place 2 holds/reservations for a Borrower on the items of 1 serial ERROR, as required. So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:23:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:23:49 +0000 Subject: [Koha-bugs] [Bug 11814] Serial statuses should be stored in constants In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11814 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:23:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:23:52 +0000 Subject: [Koha-bugs] [Bug 11814] Serial statuses should be stored in constants In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11814 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33990|0 |1 is obsolete| | Attachment #33991|0 |1 is obsolete| | Attachment #33992|0 |1 is obsolete| | Attachment #34550|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall --- Created attachment 34563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34563&action=edit Bug 11814 - Use constants to describe statuses Make the code a bit more understandable by using constants to define the status values and reference those. Adds self-documentation. Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:24:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:24:02 +0000 Subject: [Koha-bugs] [Bug 11814] Serial statuses should be stored in constants In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11814 --- Comment #22 from Kyle M Hall --- Created attachment 34564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34564&action=edit Bug 11814 - (follow-up) Use constants to describe statuses This patch deals with all hard-coded status codes in the C4::Serials module. Test plan: Test a complete workflow in the serial module (create, order, receive, generate next) trying to use all statuses. Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:24:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:24:05 +0000 Subject: [Koha-bugs] [Bug 11814] Serial statuses should be stored in constants In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11814 --- Comment #23 from Kyle M Hall --- Created attachment 34565 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34565&action=edit Bug 11814: Fix sql parameters order Oops, bad paramaters passed on executing the sql query produced unexpected behaviors. Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:24:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:24:07 +0000 Subject: [Koha-bugs] [Bug 11814] Serial statuses should be stored in constants In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11814 --- Comment #24 from Kyle M Hall --- Created attachment 34566 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34566&action=edit Bug 11814: Fix existing tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:24:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:24:39 +0000 Subject: [Koha-bugs] [Bug 11814] Serial statuses should be stored in constants In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11814 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34563|0 |1 is obsolete| | Attachment #34564|0 |1 is obsolete| | Attachment #34565|0 |1 is obsolete| | Attachment #34566|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall --- Created attachment 34567 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34567&action=edit [PASSED QA] Bug 11814 - Use constants to describe statuses Make the code a bit more understandable by using constants to define the status values and reference those. Adds self-documentation. Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:24:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:24:46 +0000 Subject: [Koha-bugs] [Bug 11814] Serial statuses should be stored in constants In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11814 --- Comment #26 from Kyle M Hall --- Created attachment 34568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34568&action=edit [PASSED QA] Bug 11814 - (follow-up) Use constants to describe statuses This patch deals with all hard-coded status codes in the C4::Serials module. Test plan: Test a complete workflow in the serial module (create, order, receive, generate next) trying to use all statuses. Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:24:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:24:49 +0000 Subject: [Koha-bugs] [Bug 11814] Serial statuses should be stored in constants In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11814 --- Comment #27 from Kyle M Hall --- Created attachment 34569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34569&action=edit [PASSED QA] Bug 11814: Fix sql parameters order Oops, bad paramaters passed on executing the sql query produced unexpected behaviors. Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:24:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:24:52 +0000 Subject: [Koha-bugs] [Bug 11814] Serial statuses should be stored in constants In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11814 --- Comment #28 from Kyle M Hall --- Created attachment 34570 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34570&action=edit [PASSED QA] Bug 11814: Fix existing tests Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:30:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:30:58 +0000 Subject: [Koha-bugs] [Bug 7561] cannot fast catalog with fast cataloging permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7561 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #5 from Marc V?ron --- I can replicate this with following permissions: 'circulate' 'catalogue' 'fast_cataloging' If I add permission 'edit_items', I'm taken to the item record as expected. (However, I can edit other items as well - should editing itmes be restricted to the fast added biblio?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:34:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:34:59 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34502|0 |1 is obsolete| | Attachment #34503|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall --- Created attachment 34571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34571&action=edit [PASSED QA] Bug 11879 - Add a new borrower field : main contact method. (Was: Rebased on current master for testing) http://bugs.koha-community.org/show_bug.cgi?id=11879 To test this patch: Update database Edit a borrower's informations. The "Main Contact Method" selectbox appears in the form and its value is correctly. Works as expected. For handling of syspref BorrowerUnwantedField use second patch- Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:34:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:34:56 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:35:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:35:23 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34571|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 34572 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34572&action=edit [PASSED QA] Bug 11879 - Add a new borrower field : main contact method. (Was: Rebased on current master for testing) http://bugs.koha-community.org/show_bug.cgi?id=11879 To test this patch: Update database Edit a borrower's informations. The "Main Contact Method" selectbox appears in the form and its value is correctly. Works as expected. For handling of syspref BorrowerUnwantedField use second patch- Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:36:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:36:05 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #18 from Kyle M Hall --- Created attachment 34573 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34573&action=edit [PASSED QA] Bug 11879 - Fix syspref BorrowerUnwantedField How I tested: Apply 1st patch Apply this patch Edit syspref BorrowerUnwantedField to exclude fields Edit patron's contact information Make sure that fields do not longer appear in drop down for Main contact Wors as expected http://bugs.koha-community.org/show_bug.cgi?id=11879 Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:36:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:36:42 +0000 Subject: [Koha-bugs] [Bug 12364] Useless use of '\'; doesn't escape metacharacter '(' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12364 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:37:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:37:00 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #19 from Kyle M Hall --- The only issue I have is with the language. I think 'preferred' or 'primary' would probably serve better than 'main', but that is only my opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:44:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:44:34 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #57 from Jonathan Druart --- Comment on attachment 33201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33201 Bug 9580 Cover images from Coce, a remote image URL cache Review of attachment 33201: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9580&attachment=33201) ----------------------------------------------------------------- Fr?d?ric, Mark, Lazily I tried with your host (coce.tamil.fr:8080), but it does not work. It seems that the browser blocks the request to other servers, which seems logical. Could you confirm or infirm that this worked for you? ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/svc/shelfbrowser.tt @@ +1,1 @@ > +[% USE Koha %] Why do you added this line in this file (and not in shelfbrowser.inc)? ::: koha-tmpl/opac-tmpl/bootstrap/js/coce.js @@ +31,5 @@ > + var url = urlPerID[id]; > + $("[id^=coce-thumbnail]."+id).each(function() { > + var img = document.createElement("img"); > + img.src = url; > + img.title = url; //FIXME: to delete Should be removed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 16:53:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 15:53:34 +0000 Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 --- Comment #12 from Nicole C. Engard --- Comment received via email: --------- Can the suppression of the 245h be an optional choice? Even though it is not being used in RDA records, some people like to see it if is there. In AACR2 records, without the 336, 337, 338 fields it may be harder for patrons to tell what format the item is if the h subfield is suppressed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 17:01:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 16:01:09 +0000 Subject: [Koha-bugs] [Bug 12842] Add classification to MARC21 XSLT detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12842 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 17:01:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 16:01:11 +0000 Subject: [Koha-bugs] [Bug 12842] Add classification to MARC21 XSLT detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12842 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33119|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 34574 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34574&action=edit [PASSED QA] Bug 12842: Add DDC classification numbers to MARC21 XSLT detail page Patch will add DDC classifications, divided with | below the subjects in the OPAC and staff detail pages. To test: - catalogue a record with one or mulitple 082$a subfields - verify the classifications are displayed in OPAC and staff detail page - Add following CSS to OpacUserCSS or IntranetUserCSS: .results_summary.ddc { display:none; } - Verify the DDC classifications are now no longer displayed Signed-off-by: Frederic Demians Test plan ok. Repetions of $a subfield are separated by a space, which seems correct. I'm not sure whether other subfield than $a should be displayed on intranet. Whatever, this could be added later. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 17:05:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 16:05:23 +0000 Subject: [Koha-bugs] [Bug 12965] can create an item type that already exists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12965 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- Confirmed for current master 3.19.00.000 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 17:06:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 16:06:37 +0000 Subject: [Koha-bugs] [Bug 13457] Suggestions.t expects sample itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13457 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall --- Not sure if I understand what you mean. Wouldn't it be best if we made the UT independent of what's in the database? I think this patch is useful, as I often test with the default data, but may add new branches to it. So while it would be best to have complete data independence, this is at least a small step in the right direction. (In reply to Jonathan Druart from comment #3) > The tests don't pass if you don't use the sample data. > To me, this patch is not relevant: we should not create all data before > launching tests. > > For instance the same test file (Suggestions.t) won't pass if you don't have > the CPL branchcode and S categorycode. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 17:07:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 16:07:57 +0000 Subject: [Koha-bugs] [Bug 13457] Suggestions.t expects sample itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13457 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 17:07:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 16:07:59 +0000 Subject: [Koha-bugs] [Bug 13457] Suggestions.t expects sample itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13457 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34429|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 34575 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34575&action=edit [PASSED QA] Bug 13457: Suggestions.t expects sample itemtypes TEST PLAN --------- 1) Make sure you have more than 8 item types, and preferably something with a non-sample default code for itemtypes. 2) prove t/db_dependent/Suggestions.t -- this will fail 3) Apply patch 4) prove t/db_dependent/Suggestions.t -- this will succeed 5) run koha qa test tools Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 17:09:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 16:09:22 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33156|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 17:10:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 16:10:33 +0000 Subject: [Koha-bugs] [Bug 13436] Add more options to UsageStatsLibraryType In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13436 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34510|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 34576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34576&action=edit [PASSED QA] Bug 13436: Adding more options to UsageStatsLibraryType syspref Added options: - research - private - society or association - corporate - government - religious organization - subscription - school Also changed 'university' to 'academic' To test: 1) Go on to Global System Preferences and find UsageStatsLibraryType under Administration 2) Click drop-down menu and see all new options described above, as well as 'academic' instead of 'university' Signed-off-by: Jonathan Druart Amended patch: replace tab with spaces Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 17:10:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 16:10:46 +0000 Subject: [Koha-bugs] [Bug 13436] Add more options to UsageStatsLibraryType In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13436 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 17:14:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 16:14:18 +0000 Subject: [Koha-bugs] [Bug 10169] Software error if one of multiple titles selected for hold in the OPAC has no items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10169 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- I can not reproduce on current master 3.19.00.000 How I tested: - Log in to Opac - Do a search that has biblios with an dwihtout items as result - Select one with items and two without items and place hold. Result (OK): -------------- Confirm holds for: xxxxx (x) Faust ? Part 1 , by Goethe, Johann Wolfgang von, 1749-1832 No available items. Place a hold on The German Classics of the Nineteenth and Twentieth Centuries, Volume 01 Masterpieces of German Literature Translated into English. Holds and priority: 1 Pick up location: Show more options West-?stlicher Divan , by Goethe, Johann Wolfgang von, 1749-1832 No available items. --------------- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 17:18:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 16:18:02 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 --- Comment #17 from Paola Rossi --- (In reply to simith.doliveira from comment #16) > Don't use this patch : camelot 778 lbo_RM5001_Bordereau / BZ11882 fix this > is a obsolete patch. Have just applyed (last koha version) and worked. (In reply to simith.doliveira from comment #16) > Don't use this patch : camelot 778 lbo_RM5001_Bordereau / BZ11882 fix this > is a obsolete patch. So I've made that patch obsolete: logged to bugzilla, I selected the "Details" of that patch, and then I "Edit details" at top-right. Then I checked the left-bottom "obsolete" checkbox, and "submit". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 17:21:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 16:21:58 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #58 from Fr?d?ric Demians --- Merci Jonathan pour les tests. > Lazily I tried with your host (coce.tamil.fr:8080), but it does not work. > It seems that the browser blocks the request to other servers, which seems > logical. > Could you confirm or infirm that this worked for you? Could you try rather with: http://coce.tamil.fr:8080 > ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/svc/shelfbrowser.tt > @@ +1,1 @@ > > +[% USE Koha %] > Why do you added this line in this file (and not in shelfbrowser.inc)? You're correct correct. It could be suppressed. > ::: koha-tmpl/opac-tmpl/bootstrap/js/coce.js > @@ +31,5 @@ > > + var url = urlPerID[id]; > > + $("[id^=coce-thumbnail]."+id).each(function() { > > + var img = document.createElement("img"); > > + img.src = url; > > + img.title = url; //FIXME: to delete > > Should be removed? Well, good question. With that last line, it's possible to see immediately where the image comes from by flying over it. In my opinion, this should be kept now, and deleted later, or replaced by: img.title = id; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 17:23:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 16:23:36 +0000 Subject: [Koha-bugs] [Bug 13025] Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13025 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 17:26:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 16:26:21 +0000 Subject: [Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 17:26:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 16:26:23 +0000 Subject: [Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34514|0 |1 is obsolete| | Attachment #34515|0 |1 is obsolete| | Attachment #34516|0 |1 is obsolete| | Attachment #34517|0 |1 is obsolete| | Attachment #34518|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall --- Created attachment 34577 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34577&action=edit [PASSED QA] Bug 13419: Add server-side processing for lists This patch adds DataTables using a server-side processing to display lists (virtual shelves). Test plan: 1/ Go on virtualshelves/shelves.p 2/ Play with the table functions (sort, filter, pagination, etc.) 3/ Go with the Public lists tab and verify the table is correctly filtered. Tested together with patch #2, works as expected. Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 17:27:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 16:27:00 +0000 Subject: [Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #16 from Kyle M Hall --- Created attachment 34578 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34578&action=edit [PASSED QA] Bug 13419: Add filters on the list table Tested together with patch #1, works as expected Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 17:27:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 16:27:03 +0000 Subject: [Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #17 from Kyle M Hall --- Created attachment 34579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34579&action=edit [PASSED QA] Bug 13419: Add tests Test plan: prove t/db_dependent/Utils/Datatables_Virtualshelves.t should return green Tested together with follow-up, works as expected Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 17:27:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 16:27:05 +0000 Subject: [Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #18 from Kyle M Hall --- Created attachment 34580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34580&action=edit [PASSED QA] Bug 13419: (follow-up) Add tests - remove existing shelves Works as expected. Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 17:27:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 16:27:26 +0000 Subject: [Koha-bugs] [Bug 13457] Suggestions.t expects sample itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13457 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #6 from M. Tompsett --- Just tested by deleting CPL and S. Comment #3 requires another patch. Working on it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 17:31:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 16:31:25 +0000 Subject: [Koha-bugs] [Bug 12721] Wrong fieldnames or trailing | in system preference StatisticsFields lead to crash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 --- Comment #1 from Marc V?ron --- Still valid in current master 3.19.00.000 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 17:38:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 16:38:56 +0000 Subject: [Koha-bugs] [Bug 13421] Add the creation time for virtual shelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13421 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 17:38:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 16:38:58 +0000 Subject: [Koha-bugs] [Bug 13421] Add the creation time for virtual shelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13421 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34505|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 34581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34581&action=edit [PASSED QA] Bug 13421: Add the creation time for virtual shelves Test plan: 1/ Execute the updatedb entry 2/ Create a list 3/ Go on the shelve list and confirm that the creation and last modification time are now displayed. 4/ Confirm that you are able to sort the list by creation/modification time. Applied on top of 13419 (rebased updatedatabase.pl) Works as expected. Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 17:39:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 16:39:07 +0000 Subject: [Koha-bugs] [Bug 13241] Notice for account details ( ACCTDETAILS ) will only send in plain text even if HTML is selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13241 --- Comment #4 from Kyle M Hall --- Created attachment 34582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34582&action=edit Bug 13241 - Change creation_time to created_on -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 17:40:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 16:40:03 +0000 Subject: [Koha-bugs] [Bug 13421] Add the creation time for virtual shelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13421 --- Comment #6 from Kyle M Hall --- Created attachment 34583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34583&action=edit Bug 13421 - Change creation_time to created_on -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 17:40:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 16:40:28 +0000 Subject: [Koha-bugs] [Bug 13241] Notice for account details ( ACCTDETAILS ) will only send in plain text even if HTML is selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13241 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34582|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 17:42:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 16:42:07 +0000 Subject: [Koha-bugs] [Bug 13476] Item Search feature gets datatables error and doesn't complete search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13476 --- Comment #4 from Marc V?ron --- Created attachment 34584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34584&action=edit [Signed-off] Bug 13476: Fix DataTables for the search items form This items form is broken since the upgrade to DataTables 1.10.2 (commit 954c2874d0d9ebfa2e910dcd4445010115fac329). The fnServerParams does not work anymore. Test plan: Go on catalogue/itemsearch.pl, launch a search and verify the data are correctly displayed in the table. Followed test plan. Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 17:42:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 16:42:07 +0000 Subject: [Koha-bugs] [Bug 13421] Add the creation time for virtual shelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13421 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #7 from Kyle M Hall --- I think we need to standardize our timestamp columns in Koha. I think this would be as good a place to start as any. I would suggest we use created_on for creation timestamps, and updated_on for last updated timestamps, if you have no objections. This is the naming convention I used for the accounts rewrite. I will also bring the issue up at the next channel meeting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 17:42:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 16:42:25 +0000 Subject: [Koha-bugs] [Bug 13476] Item Search feature gets datatables error and doesn't complete search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13476 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34521|0 |1 is obsolete| | CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 17:42:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 16:42:47 +0000 Subject: [Koha-bugs] [Bug 13476] Item Search feature gets datatables error and doesn't complete search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13476 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 18:06:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 17:06:36 +0000 Subject: [Koha-bugs] [Bug 13218] usability enhancement for z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13218 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34497|0 |1 is obsolete| | --- Comment #28 from Tom?s Cohen Arazi --- Created attachment 34585 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34585&action=edit Bug 13218: (RM followup) only scroll on actually variable stuff Most of the page contents have fixed size. The only exception is the targets list. If the target list grows, then the whole page needs to be scrolled in order to reach the buttons. We should make the z3950 targets area scrollable, and remove scrolbars from all over the place. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 18:06:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 17:06:43 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 18:06:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 17:06:46 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34540|0 |1 is obsolete| | Attachment #34541|0 |1 is obsolete| | Attachment #34542|0 |1 is obsolete| | Attachment #34543|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 34586 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34586&action=edit [PASSED QA] Create a link to the last advanced search in search result page (OPAC) http://bugs.koha-community.org/show_bug.cgi?id=13307 Followed test plan, works as expected (together with other patches) Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 18:06:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 17:06:54 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #18 from Kyle M Hall --- Created attachment 34587 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34587&action=edit [PASSED QA] Fix Patch- Search boxes disappear when returning to advanced search http://bugs.koha-community.org/show_bug.cgi?id=13307 Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 18:06:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 17:06:57 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #19 from Kyle M Hall --- Created attachment 34588 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34588&action=edit [PASSED QA] Fix jquery.deseriable.min.js http://bugs.koha-community.org/show_bug.cgi?id=13307 Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 18:07:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 17:07:00 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #20 from Kyle M Hall --- Created attachment 34589 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34589&action=edit [PASSED QA] Bug 13307 [QA Followup] Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 18:13:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 17:13:25 +0000 Subject: [Koha-bugs] [Bug 13307] Create a link to the last advanced search in search result page (OPAC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 18:13:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 17:13:27 +0000 Subject: [Koha-bugs] [Bug 13307] Create a link to the last advanced search in search result page (OPAC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34374|0 |1 is obsolete| | Attachment #34375|0 |1 is obsolete| | Attachment #34376|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall --- Created attachment 34590 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34590&action=edit [PASSED QA] Create a link to the last advanced search in search result page (OPAC) http://bugs.koha-community.org/show_bug.cgi?id=13307 Followed test plan, works as expected (together with other patches) Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall http://bugs.koha-community.org/show_bug.cgi?id=13364 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 18:13:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 17:13:36 +0000 Subject: [Koha-bugs] [Bug 13307] Create a link to the last advanced search in search result page (OPAC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 --- Comment #17 from Kyle M Hall --- Created attachment 34591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34591&action=edit [PASSED QA] Fix Patch- Search boxes disappear when returning to advanced search http://bugs.koha-community.org/show_bug.cgi?id=13307 Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall http://bugs.koha-community.org/show_bug.cgi?id=13364 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 18:13:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 17:13:39 +0000 Subject: [Koha-bugs] [Bug 13307] Create a link to the last advanced search in search result page (OPAC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 --- Comment #18 from Kyle M Hall --- Created attachment 34592 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34592&action=edit [PASSED QA] Fix jquery.deseriable.min.js http://bugs.koha-community.org/show_bug.cgi?id=13307 Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall http://bugs.koha-community.org/show_bug.cgi?id=13364 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 18:13:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 17:13:42 +0000 Subject: [Koha-bugs] [Bug 13307] Create a link to the last advanced search in search result page (OPAC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 --- Comment #19 from Kyle M Hall --- Created attachment 34593 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34593&action=edit [PASSED QA] Bug 13307 [QA Followup] Signed-off-by: Kyle M Hall http://bugs.koha-community.org/show_bug.cgi?id=13364 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 18:17:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 17:17:19 +0000 Subject: [Koha-bugs] [Bug 13442] Facet links broken when collection code limit is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 --- Comment #2 from Marc V?ron --- Created attachment 34594 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34594&action=edit [Signed-off] Bug 13442 - Facet links broken when collection code limit is used Any search limits including a ccode will break the search facts. Test Plan: 1) Run an advanced search using a ccode limit 2) Try using any of the facet links of the left 3) Note they are broken 4) Apply this patch 5) Refresh the results 6) Note the facet links are no longer broken Note: I have not been able to reproduce this issue on my own test system, but have noted the problem on at least a dozen Koha servers. I could not reproduce the bug either, but I saw it on the Bywater Demo (comment #1). Applied patch and tested facets, no problems found, signing off Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 18:18:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 17:18:15 +0000 Subject: [Koha-bugs] [Bug 13442] Facet links broken when collection code limit is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34331|0 |1 is obsolete| | CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 18:18:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 17:18:40 +0000 Subject: [Koha-bugs] [Bug 13442] Facet links broken when collection code limit is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 18:26:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 17:26:57 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34540|1 |0 is obsolete| | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 18:27:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 17:27:06 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34541|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 18:27:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 17:27:13 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34542|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 18:27:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 17:27:19 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34543|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 18:27:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 17:27:32 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34586|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 18:27:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 17:27:40 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34587|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 18:27:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 17:27:47 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34588|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 18:27:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 17:27:54 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34589|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 18:28:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 17:28:31 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 18:33:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 17:33:25 +0000 Subject: [Koha-bugs] [Bug 13457] Suggestions.t expects sample itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13457 --- Comment #7 from M. Tompsett --- Created attachment 34595 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34595&action=edit Bug 13457 - Followup for CPL and S codes Based on comment #3, this corrects CPL and S issues if they do not exist in the DB. TEST PLAN --------- 0) Backup your DB. 1) Clear CPL and S from your DB. - delete from borrowers where categorycode='S'; - delete from categories where categorycode='S'; - delete from borrowers where branchcode='CPL'; - delete from branch where branchcode='CPL'; 2) prove t/db_dependent/Suggestions.t -- This should fail. 3) Apply patch 4) prove t/db_dependent/Suggestions.t -- This should work. 5) Intentionally add categorycode 'S' and branchcode 'CPL' back into the database. 6) prove t/db_dependent/Suggestions.t -- This should work. 7) run koha qa test tools. 8) Restore your DB :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 18:33:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 17:33:58 +0000 Subject: [Koha-bugs] [Bug 13457] Suggestions.t expects sample itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13457 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 18:56:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 17:56:46 +0000 Subject: [Koha-bugs] [Bug 13476] Item Search feature gets datatables error and doesn't complete search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13476 --- Comment #5 from Mirko Tietgen --- Created attachment 34596 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34596&action=edit Bug 13476: Fix DataTables for the search items form This items form is broken since the upgrade to DataTables 1.10.2 (commit 954c2874d0d9ebfa2e910dcd4445010115fac329). The fnServerParams does not work anymore. Test plan: Go on catalogue/itemsearch.pl, launch a search and verify the data are correctly displayed in the table. Followed test plan. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 19:06:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 18:06:15 +0000 Subject: [Koha-bugs] [Bug 13218] usability enhancement for z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13218 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #29 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Liz! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 19:06:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 18:06:46 +0000 Subject: [Koha-bugs] [Bug 13465] Fields controlled by authorized values cannot be unset (Lost, damaged, not for loan status, ...) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13465 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #11 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 19:07:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 18:07:19 +0000 Subject: [Koha-bugs] [Bug 13296] error when using z3950 with UNIMARC authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13296 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #13 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Frido! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 19:07:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 18:07:47 +0000 Subject: [Koha-bugs] [Bug 13470] pay fines with extended borrower attributes result in application error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13470 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Dobrica! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 19:08:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 18:08:18 +0000 Subject: [Koha-bugs] [Bug 13416] Typo in marc21_leader.pl position 5 (record status) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 19:08:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 18:08:46 +0000 Subject: [Koha-bugs] [Bug 13422] SCO: "Would you like to print a receipt" not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13422 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 19:16:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 18:16:54 +0000 Subject: [Koha-bugs] [Bug 7741] Clear search terms in Z3950 search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7741 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen at gmail.com --- Comment #15 from Tom?s Cohen Arazi --- My followup for bug 13218 broke this one. Could you please rebase? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 19:21:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 18:21:33 +0000 Subject: [Koha-bugs] [Bug 13124] Record titles with parentheses causing label weirdness In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger at foundations.ed |kyle at bywatersolutions.com |u | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 19:22:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 18:22:08 +0000 Subject: [Koha-bugs] [Bug 13124] Record titles with parentheses causing label weirdness In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle at bywatersolutions.com |cnighswonger at foundations.ed | |u -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 19:42:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 18:42:55 +0000 Subject: [Koha-bugs] [Bug 13485] New: Add a proxy page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13485 Bug ID: 13485 Summary: Add a proxy page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: simith.doliveira at inlibro.com QA Contact: testopia at bugs.koha-community.org This patch adds a proxy page that allows users to access external resources when connected or from specific IP ranges. If the user is not connected or is not from the specified IP, the connection page will be displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 19:43:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 18:43:05 +0000 Subject: [Koha-bugs] [Bug 13485] Add a proxy page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13485 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |simith.doliveira at inlibro.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 19:48:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 18:48:02 +0000 Subject: [Koha-bugs] [Bug 13485] Add a proxy page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13485 --- Comment #1 from simith.doliveira at inlibro.com --- Created attachment 34597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34597&action=edit Bug 13485 - Add a proxy page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 20:45:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 19:45:35 +0000 Subject: [Koha-bugs] [Bug 13485] Add a proxy page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13485 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34597|0 |1 is obsolete| | --- Comment #2 from simith.doliveira at inlibro.com --- Created attachment 34598 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34598&action=edit Bug 13485 - Add a proxy page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 20:47:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 19:47:09 +0000 Subject: [Koha-bugs] [Bug 13485] Add a proxy page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13485 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored --- Comment #3 from simith.doliveira at inlibro.com --- Sponsored-by: Chelsea biblio ( http://biblio.chelsea.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 20:47:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 19:47:34 +0000 Subject: [Koha-bugs] [Bug 13485] Add a proxy page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13485 --- Comment #4 from simith.doliveira at inlibro.com --- To test: I) Apply the patch II) Run updatedatabase.pl scenario I) 1) Add some content in ProxyPageContent and ProxyPageTitle sysprefs. 2) Add your machine ip (ex. 127.0.0) 3) Validate cgi-bin/koha/opac-proxypage.pl shows a page with ProxyPageContent and ProxyPageTitle contents. scenario II) 1) Logout opac page 2) Add some content in ProxyPageContent and ProxyPageTitle sysprefs. 3) Add other ip that your machine ip. 4) Validate: cgi-bin/koha/opac-proxypage.pl shows a login page. 5) Validate: cgi-bin/koha/opac-proxypage.pl shows a page with ProxyPageContent and ProxyPageTitle contents after login. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 20:48:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 19:48:50 +0000 Subject: [Koha-bugs] [Bug 13436] Add more options to UsageStatsLibraryType In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13436 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 20:48:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 19:48:54 +0000 Subject: [Koha-bugs] [Bug 13436] Add more options to UsageStatsLibraryType In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13436 --- Comment #12 from Tom?s Cohen Arazi --- Created attachment 34599 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34599&action=edit Bug 13436: (RM followup) university -> academic DB update Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 20:49:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 19:49:02 +0000 Subject: [Koha-bugs] [Bug 13485] Add a proxy page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13485 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |eric.begin at inLibro.com, | |philippe.blouin at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 21:11:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 20:11:08 +0000 Subject: [Koha-bugs] [Bug 12565] Acq: Link to basket in breadcrumbs broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12565 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Gracias Katrina! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 21:11:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 20:11:38 +0000 Subject: [Koha-bugs] [Bug 13469] Unapi path to XSLTs is wrong in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13469 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 21:12:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 20:12:14 +0000 Subject: [Koha-bugs] [Bug 13436] Add more options to UsageStatsLibraryType In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13436 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #13 from Tom?s Cohen Arazi --- Patch pushed to master. Nice improvement Aleisha! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 21:12:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 20:12:43 +0000 Subject: [Koha-bugs] [Bug 13461] Circ always asking for confirmation if RentalFeesCheckoutConfirmation is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13461 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- P?tch pushed to master. Gracias Katrina! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 21:17:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 20:17:54 +0000 Subject: [Koha-bugs] [Bug 13476] Item Search feature gets datatables error and doesn't complete search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13476 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34584|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 21:19:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 20:19:20 +0000 Subject: [Koha-bugs] [Bug 13476] Item Search feature gets datatables error and doesn't complete search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13476 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34596|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 34600 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34600&action=edit Bug 13476: Fix DataTables for the search items form This items form is broken since the upgrade to DataTables 1.10.2 (commit 954c2874d0d9ebfa2e910dcd4445010115fac329). The fnServerParams does not work anymore. Test plan: Go on catalogue/itemsearch.pl, launch a search and verify the data are correctly displayed in the table. Followed test plan. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Mirko Tietgen Signed-off-by: Katrin Fischer The paging seems still a bit buggy, but this makes the feature usable again! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 21:19:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 20:19:42 +0000 Subject: [Koha-bugs] [Bug 13476] Item Search feature gets datatables error and doesn't complete search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13476 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 21:20:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 20:20:31 +0000 Subject: [Koha-bugs] [Bug 13476] Item Search feature gets datatables error and doesn't complete search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13476 --- Comment #7 from Katrin Fischer --- Created attachment 34601 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34601&action=edit paging problem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 21:31:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 20:31:37 +0000 Subject: [Koha-bugs] [Bug 10753] Creating suggestions for 'Any library' uses _ANY as branchcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10753 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 21:34:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 20:34:51 +0000 Subject: [Koha-bugs] [Bug 13442] Facet links broken when collection code limit is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 --- Comment #3 from Katrin Fischer --- Created attachment 34602 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34602&action=edit [PASSED QA] Bug 13442 - Facet links broken when collection code limit is used Any search limits including a ccode will break the search facts. Test Plan: 1) Run an advanced search using a ccode limit 2) Try using any of the facet links of the left 3) Note they are broken 4) Apply this patch 5) Refresh the results 6) Note the facet links are no longer broken Note: I have not been able to reproduce this issue on my own test system, but have noted the problem on at least a dozen Koha servers. I could not reproduce the bug either, but I saw it on the Bywater Demo (comment #1). Applied patch and tested facets, no problems found, signing off Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Can not reproduce the problem, but I can also not find a regression. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 21:36:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 20:36:55 +0000 Subject: [Koha-bugs] [Bug 13442] Facet links broken when collection code limit is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 21:36:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 20:36:57 +0000 Subject: [Koha-bugs] [Bug 13442] Facet links broken when collection code limit is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34594|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 21:41:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 20:41:42 +0000 Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 --- Comment #13 from Katrin Fischer --- Maybe it would work to wrap $h in a with a class? easy to hide then if you don't want to see it in the title :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 21:59:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 20:59:44 +0000 Subject: [Koha-bugs] [Bug 13476] Item Search feature gets datatables error and doesn't complete search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13476 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 22:00:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 21:00:28 +0000 Subject: [Koha-bugs] [Bug 10753] Creating suggestions for 'Any library' uses _ANY as branchcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10753 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 22:01:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 21:01:15 +0000 Subject: [Koha-bugs] [Bug 13456] Serials/Claims.t expects no subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13456 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 22:01:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 21:01:58 +0000 Subject: [Koha-bugs] [Bug 13415] Prevent librarians from scanning multiple items into a single barcode field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13415 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 22:04:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 21:04:09 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 22:04:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 21:04:10 +0000 Subject: [Koha-bugs] [Bug 13476] Item Search feature gets datatables error and doesn't complete search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13476 Bug 13476 depends on bug 11425, which changed state. Bug 11425 Summary: Search form for items http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 19 22:33:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 21:33:55 +0000 Subject: [Koha-bugs] [Bug 13456] Serials/Claims.t expects no subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13456 --- Comment #5 from M. Tompsett --- (In reply to Paola Rossi from comment #2) [SNIP] > Processing files before patches > |========================>| 1 / 1 (100.00%) > Processing files after patches > |========================>| 1 / 1 (100.00%) [SNIP] Thanks to Paola Possi for making me check if there were updates to the QA test tool! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 20 00:25:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 23:25:51 +0000 Subject: [Koha-bugs] [Bug 13218] usability enhancement for z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13218 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #30 from Chris Cormack --- String changes, held for 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 20 00:30:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 23:30:18 +0000 Subject: [Koha-bugs] [Bug 13465] Fields controlled by authorized values cannot be unset (Lost, damaged, not for loan status, ...) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13465 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #12 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 20 00:33:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 23:33:39 +0000 Subject: [Koha-bugs] [Bug 13296] error when using z3950 with UNIMARC authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13296 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #14 from Chris Cormack --- Pushed to 3.18.x, will be in 3.18.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 20 00:36:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 23:36:58 +0000 Subject: [Koha-bugs] [Bug 13470] pay fines with extended borrower attributes result in application error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13470 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #9 from Chris Cormack --- Pushed to 3.18.x, will be in 3.18.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 20 00:38:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 23:38:37 +0000 Subject: [Koha-bugs] [Bug 13416] Typo in marc21_leader.pl position 5 (record status) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #9 from Chris Cormack --- String changes, held for 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 20 00:39:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 23:39:53 +0000 Subject: [Koha-bugs] [Bug 13422] SCO: "Would you like to print a receipt" not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13422 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- String changes, held for 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 20 00:42:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 23:42:02 +0000 Subject: [Koha-bugs] [Bug 12565] Acq: Link to basket in breadcrumbs broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12565 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Template changes, held for 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 20 00:43:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 23:43:40 +0000 Subject: [Koha-bugs] [Bug 13469] Unapi path to XSLTs is wrong in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13469 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.18.x, will be in 3.18.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 20 00:45:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 23:45:36 +0000 Subject: [Koha-bugs] [Bug 13436] Add more options to UsageStatsLibraryType In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13436 --- Comment #14 from Chris Cormack --- String changes, held for 3.18.3 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 20 00:48:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 23:48:40 +0000 Subject: [Koha-bugs] [Bug 13461] Circ always asking for confirmation if RentalFeesCheckoutConfirmation is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13461 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Pushed to 3.18.x, will be in 3.18.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 20 00:51:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 23:51:11 +0000 Subject: [Koha-bugs] [Bug 13476] Item Search feature gets datatables error and doesn't complete search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13476 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #9 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 20 00:54:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 23:54:27 +0000 Subject: [Koha-bugs] [Bug 10753] Creating suggestions for 'Any library' uses _ANY as branchcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10753 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #10 from Chris Cormack --- Template changes, held for 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 20 00:55:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 23:55:44 +0000 Subject: [Koha-bugs] [Bug 13456] Serials/Claims.t expects no subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13456 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Pushed to 3.18.x, will be in 3.18.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 20 00:56:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Dec 2014 23:56:52 +0000 Subject: [Koha-bugs] [Bug 13415] Prevent librarians from scanning multiple items into a single barcode field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13415 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #11 from Chris Cormack --- Template changes held for 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 20 10:12:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Dec 2014 09:12:12 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 20 11:57:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Dec 2014 10:57:51 +0000 Subject: [Koha-bugs] [Bug 13477] On order detail not showing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13477 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Iming, can you please add more information on this report? I checked the 'on order' status, but it seems to display ok everywhere. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 20 12:00:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Dec 2014 11:00:32 +0000 Subject: [Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7255, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12514 --- Comment #3 from Katrin Fischer --- Could this be a duplicate to bug 12514 and bug 7255? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 20 12:00:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Dec 2014 11:00:32 +0000 Subject: [Koha-bugs] [Bug 7255] Information on Holds Transfer Slips is Inconsistent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7255 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13482 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 20 12:00:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Dec 2014 11:00:32 +0000 Subject: [Koha-bugs] [Bug 12514] Pressing 'print and confirm hold' on check in triggers race condition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12514 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13482 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 20 17:11:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Dec 2014 16:11:40 +0000 Subject: [Koha-bugs] [Bug 13485] Add a proxy page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13485 --- Comment #5 from Marc V?ron --- Created attachment 34604 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34604&action=edit [Signed-off] Bug 13485 - Add a proxy page To test: I) Apply the patch II) Run updatedatabase.pl scenario I) 1) Add some content in ProxyPageContent and ProxyPageTitle sysprefs. 2) Add your machine ip (ex. 127.0.0) 3) Validate cgi-bin/koha/opac-proxypage.pl shows a page with ProxyPageContent and ProxyPageTitle contents. scenario II) 1) Logout opac page 2) Add some content in ProxyPageContent and ProxyPageTitle sysprefs. 3) Add other ip that your machine ip. 4) Validate: cgi-bin/koha/opac-proxypage.pl shows a login page. 5) Validate: cgi-bin/koha/opac-proxypage.pl shows a page with ProxyPageContent and ProxyPageTitle contents after login. Followed both scenarios, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 20 17:12:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Dec 2014 16:12:56 +0000 Subject: [Koha-bugs] [Bug 13485] Add a proxy page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13485 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 20 17:49:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Dec 2014 16:49:43 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 --- Comment #18 from Marc V?ron --- Created attachment 34605 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34605&action=edit [Signed-off] Bug 11882 - Add a new button to the checkout confirmation dialog when checking out a reserved item This patch adds a "Don't Check Out and Print Slip" button to the dialog that appears when trying to checkout a reserved item. Test case : * Put a hold on an item for User A. * Try to check out it item with User B. * The "Please confirm checkout" box should appear. The "Don't Check Out and Print Slip" button should appear in this box. * Click on the "Don't Check Out and Print Slip" button. * A print popup will appear Followed test plan. Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 20 17:50:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Dec 2014 16:50:51 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34421|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 20 17:51:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Dec 2014 16:51:02 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 20 19:02:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Dec 2014 18:02:32 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 20 19:17:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Dec 2014 18:17:44 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #42 from Marc V?ron --- Sorry, merge conflicts (again) with current master (3.19.00.002): Applying: Bug 10947 - Grouped ItemTypes - Patch should apply properly on latest master. Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging opac/opac-search.pl CONFLICT (content): Merge conflict in opac/opac-search.pl Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Failed to merge in the changes. Oh, the patch title reads: Bug 10947 - Grouped ItemTypes - Patch should apply properly on latest master. ...but we are on Bug 10937? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 20 19:22:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Dec 2014 18:22:16 +0000 Subject: [Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 --- Comment #2 from Marc V?ron --- Still applies (Version 3.19.00.002) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 20 19:43:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Dec 2014 18:43:10 +0000 Subject: [Koha-bugs] [Bug 13453] Koha.t daily quote tests assume sample data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13453 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34360|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 34606 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34606&action=edit Bug 13453: Koha.t daily quote tests assume sample data By adding quotes 3 and 25 from the sample data, this test can pass without having the sample quote data loaded. TEST PLAN --------- 1) Ensure there is no quote id=3 or that it is NOT Abraham Lincoln. 2) prove t/db_dependent/Koha.t -- this should fail the daily quote test. 3) apply patch 4) prove t/db_dependent/Koha.t -- this should *NOT* fail the daily quote test. 5) run koha qa test tools Followed test plan 1)-4). Without patch, daily quote test failed. With patch, test passed OK. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 20 19:44:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Dec 2014 18:44:16 +0000 Subject: [Koha-bugs] [Bug 13453] Koha.t daily quote tests assume sample data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13453 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 20 20:04:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Dec 2014 19:04:51 +0000 Subject: [Koha-bugs] [Bug 13341] Hard-coded "Preview" text in OPAC openlibrary.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 --- Comment #2 from Marc V?ron --- Created attachment 34607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34607&action=edit [Signed-off] Bug 13341 - Hard-coded "Preview" text in OPAC openlibrary.js The OpenLibrary JavaScript includes an untranslated string, "Preview." This patch move the string to the template so that it can be translated. To test, apply the patch and test that the translator picks up the string: 1. From misc/translator run 'perl translate update [lang]' (e.g. de-DE) 2. Edit misc/translator/po/[lang]-opac-bootstrap.po and add a translation for the updated "Preview" string 3. Remove the "#, fuzzy" marker from that entry 4. From misc/translator run 'perl translate install [lang]' 5. Enable the [lang] translation for the OPAC in system preferences 6. Enable the OpenLibraryCovers system preference. 7. In the OPAC switch to the [lang] translation. 7. View the detail page for a title for which there is an OpenLibrary cover image. Below it you should see a preview link with the translated string you added in step 2. Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 20 20:05:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Dec 2014 19:05:13 +0000 Subject: [Koha-bugs] [Bug 13341] Hard-coded "Preview" text in OPAC openlibrary.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34279|0 |1 is obsolete| | CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 20 20:05:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Dec 2014 19:05:21 +0000 Subject: [Koha-bugs] [Bug 13341] Hard-coded "Preview" text in OPAC openlibrary.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 21 09:35:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Dec 2014 08:35:46 +0000 Subject: [Koha-bugs] [Bug 8096] Card number twice on patron search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8096 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 21 09:36:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Dec 2014 08:36:09 +0000 Subject: [Koha-bugs] [Bug 8096] Card number twice on patron search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8096 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33626|0 |1 is obsolete| | --- Comment #9 from Chris Cormack --- Created attachment 34608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34608&action=edit Bug 8096 - card number twice on patron search This patch removes double patron card numbers from patron search results. To test: Search patrons See card number 12345 in first column and in second column like Testman, John (12345) Apply patch Patron card number no longer dispays in second colum Further testing: Search for other places in intranet where patron-title.inc is used (git grep 'patron-title.inc') The card number still should display at the other places. Signed-off-by: Chris -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 21 09:44:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Dec 2014 08:44:50 +0000 Subject: [Koha-bugs] [Bug 13407] Remove methods which are included in the 0.36 release of PDF::Reuse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 21 09:44:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Dec 2014 08:44:54 +0000 Subject: [Koha-bugs] [Bug 13407] Remove methods which are included in the 0.36 release of PDF::Reuse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34512|0 |1 is obsolete| | --- Comment #10 from Chris Cormack --- Created attachment 34609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34609&action=edit Bug 13406: Removing depricated code included in PDF::Reuse 1. Upgrade PDF::Reuse to 0.35_04. [1] 2. Run Koha's non-DB dependent test suite. You should notice some non-fatal warnings about the redefinition of one or two subs in PDF::Reuse. This should not affect the functionality of the tools for the end user. 3. Verify the functionality of the related tools. 4. Apply the attached patch. 5. Re-run Koha's non-DB dependent test suite. You should note no warnings related to PDF::Reuse. 6. Re-verify the functionality of the related tools. [1] http://search.cpan.org/CPAN/authors/id/C/CN/CNIGHS/PDF-Reuse-0.35_04.tar.gz Signed-off-by: Mark Tompsett Signed-off-by: Chris -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 21 09:45:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Dec 2014 08:45:20 +0000 Subject: [Koha-bugs] [Bug 13407] Remove methods which are included in the 0.36 release of PDF::Reuse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34533|0 |1 is obsolete| | --- Comment #11 from Chris Cormack --- Created attachment 34610 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34610&action=edit Bug 13407 Bumping required version of PDF::Reuse Signed-off-by: Chris -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 21 09:53:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Dec 2014 08:53:51 +0000 Subject: [Koha-bugs] [Bug 13447] runreport.pl html email fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13447 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 21 09:53:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Dec 2014 08:53:56 +0000 Subject: [Koha-bugs] [Bug 13447] runreport.pl html email fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13447 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34338|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 34611 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34611&action=edit BUG 13447: Fixed HTML Email Reports A tiny typo made in runreport.pl when updating it for bug 9530 lead to no body being attached to html emails. Signed-off-by: Chris -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 21 10:45:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Dec 2014 09:45:17 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 21 10:45:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Dec 2014 09:45:22 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34065|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 34612 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34612&action=edit Bug 13373 - Update Polish web installer sample data files. Part 1/2 - mandatory files. Changes: - Translated user permission and user flags. - Changed untranslated different files from en version - Deleted unnecessary files To test: - Aplly patch - Run webinstaller on empty database (drop database if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 21 10:45:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Dec 2014 09:45:49 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34066|0 |1 is obsolete| | --- Comment #5 from Chris Cormack --- Created attachment 34613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34613&action=edit Bug 13373 - Update Polish web installer sample data files. Part 2/2 - optional files. Changes: - Deleted unnecessary files - Translated description files and some values in sql files To test: - Aplly patch - Run webinstaller on empty database (drop database and create new if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 21 10:46:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Dec 2014 09:46:29 +0000 Subject: [Koha-bugs] [Bug 13477] On order detail not showing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13477 --- Comment #2 from Iming Chan --- Created attachment 34614 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34614&action=edit (Staff client) Bib. record with a current item order. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 21 10:47:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Dec 2014 09:47:25 +0000 Subject: [Koha-bugs] [Bug 13477] On order detail not showing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13477 --- Comment #3 from Iming Chan --- Created attachment 34615 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34615&action=edit (OPAC) Same bib. record not showing item order status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 21 10:52:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Dec 2014 09:52:03 +0000 Subject: [Koha-bugs] [Bug 13477] On order detail not showing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13477 --- Comment #4 from Iming Chan --- (In reply to Katrin Fischer from comment #1) > Hi Iming, can you please add more information on this report? > I checked the 'on order' status, but it seems to display ok everywhere. Hi Katrin, I have attached a couple screen displays and hopefully this will be useful. No system settings have been changed during the upgrade to 3.18.01. So technically, such detail should display like before. As a consequence of this issue, we have changed the setting of "AcqCreateItem" (found in System Preferences > Acquisitions) to Create an item when placing an order instead of receiving an order. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 21 20:07:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Dec 2014 19:07:15 +0000 Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 21 20:07:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Dec 2014 19:07:19 +0000 Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34320|0 |1 is obsolete| | --- Comment #27 from Chris Cormack --- Created attachment 34616 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34616&action=edit Bug - 5511 [Followup]: Missed Instance There was an instance of the pragma missed which meant the the original patch set didn't actually solve the problem in a large number of cases This patch adds in the relevant statement. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 00:54:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Dec 2014 23:54:33 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 00:54:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Dec 2014 23:54:38 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #199 from Chris Cormack --- Created attachment 34620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34620&action=edit Bug 7143 : Adding missing developer to the about page Signed-off-by: Chris Cormack Typed by Kahurangi, supervised by me -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 02:10:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 01:10:06 +0000 Subject: [Koha-bugs] [Bug 11369] Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12295 --- Comment #27 from David Cook --- Adding reference to http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12295 for anyone adding patches manually... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 02:10:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 01:10:06 +0000 Subject: [Koha-bugs] [Bug 12295] Javascript error when merging authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12295 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11369 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 02:47:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 01:47:54 +0000 Subject: [Koha-bugs] [Bug 13485] Add a proxy page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13485 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #6 from David Cook --- Hi Simith: Could you elaborate about the purpose of this proxy page? Is it a place to put links that only logged in users should see? I've been thinking about adding some proxy functionality where the user would click on an opac link (e.g. opac-proxy.pl?id=ebsco) and get redirected to an Ebsco page using credentials stored on the server. It sounds like we might have similar goals? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 03:05:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 02:05:56 +0000 Subject: [Koha-bugs] [Bug 807] Koha About page not displaying apache version in some distributions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=807 Jerry Weng changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chenyi.weng at techyi.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 03:23:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 02:23:47 +0000 Subject: [Koha-bugs] [Bug 13486] New: About page Apache version is empty if Apache version is 2.4 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13486 Bug ID: 13486 Summary: About page Apache version is empty if Apache version is 2.4 Change sponsored?: --- Product: Koha Version: 3.18 Hardware: PC OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: About Assignee: nengard at gmail.com Reporter: chenyi.weng at techyi.com QA Contact: testopia at bugs.koha-community.org Overview: Ubuntu 14.04.1, Apache version 2.4.7-1ubuntu4.1, Koha 3.18.01 About Koha Page -> Server information -> Apache version is empty Errors in directly running /usr/sbin/apache2 -V and similar entries in /var/log/koha/library/intranet-error.log [Mon Dec 22 10:18:42.479349 2014] [core:warn] [pid 2225] AH00111: Config variable ${APACHE_PID_FILE} is not defined [Mon Dec 22 10:18:42.480141 2014] [core:warn] [pid 2225] AH00111: Config variable ${APACHE_RUN_USER} is not defined [Mon Dec 22 10:18:42.480616 2014] [core:warn] [pid 2225] AH00111: Config variable ${APACHE_RUN_GROUP} is not defined [Mon Dec 22 10:18:42.481116 2014] [core:warn] [pid 2225] AH00111: Config variable ${APACHE_LOG_DIR} is not defined [Mon Dec 22 10:18:42.728000 2014] [core:warn] [pid 2225] AH00111: Config variable ${APACHE_RUN_DIR} is not defined [Mon Dec 22 10:18:42.776297 2014] [core:warn] [pid 2225] AH00111: Config variable ${APACHE_LOG_DIR} is not defined AH00543: apache2: bad user name ${APACHE_RUN_USER} -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 03:24:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 02:24:58 +0000 Subject: [Koha-bugs] [Bug 13486] About page Apache version is empty if Apache version is 2.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13486 Jerry Weng changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nengard at gmail.com |chenyi.weng at techyi.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 03:30:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 02:30:00 +0000 Subject: [Koha-bugs] [Bug 13486] About page Apache version is empty if Apache version is 2.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13486 Jerry Weng changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #1 from Jerry Weng --- (In reply to Jerry Weng from comment #0) > Overview: > > Ubuntu 14.04.1, Apache version 2.4.7-1ubuntu4.1, Koha 3.18.01 > About Koha Page -> Server information -> Apache version is empty > > Errors in directly running /usr/sbin/apache2 -V and similar entries in > /var/log/koha/library/intranet-error.log > [Mon Dec 22 10:18:42.479349 2014] [core:warn] [pid 2225] AH00111: Config > variable ${APACHE_PID_FILE} is not defined > [Mon Dec 22 10:18:42.480141 2014] [core:warn] [pid 2225] AH00111: Config > variable ${APACHE_RUN_USER} is not defined > [Mon Dec 22 10:18:42.480616 2014] [core:warn] [pid 2225] AH00111: Config > variable ${APACHE_RUN_GROUP} is not defined > [Mon Dec 22 10:18:42.481116 2014] [core:warn] [pid 2225] AH00111: Config > variable ${APACHE_LOG_DIR} is not defined > [Mon Dec 22 10:18:42.728000 2014] [core:warn] [pid 2225] AH00111: Config > variable ${APACHE_RUN_DIR} is not defined > [Mon Dec 22 10:18:42.776297 2014] [core:warn] [pid 2225] AH00111: Config > variable ${APACHE_LOG_DIR} is not defined > AH00543: apache2: bad user name ${APACHE_RUN_USER} Worked after fixing the following line, also tested on Apache/2.2.22 (Ubuntu), seems backward compatible. /usr/share/koha/intranet/cgi-bin/about.pl my $mysqlVersion = `mysql -V`; my $apacheVersion = `httpd -v 2> /dev/null`; $apacheVersion = `httpd2 -v 2> /dev/null` unless $apacheVersion; +$apacheVersion = (`/usr/sbin/apache2ctl -V 2> /dev/null`)[0] unless $apacheVersion; -$apacheVersion = (`/usr/sbin/apache2 -V`)[0] unless $apacheVersion; my $zebraVersion = `zebraidx -V`; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 04:33:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 03:33:56 +0000 Subject: [Koha-bugs] [Bug 13486] About page Apache version is empty if Apache version is 2.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13486 Jerry Weng changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chenyi.weng at techyi.com --- Comment #2 from Jerry Weng --- Created attachment 34621 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34621&action=edit about.pl patch for getting version info on the apache 2.4/2.2 about.pl patch for getting version info on the apache 2.4/2.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 06:06:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 05:06:25 +0000 Subject: [Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #1 from David Cook --- *** Bug 7142 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 06:06:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 05:06:25 +0000 Subject: [Koha-bugs] [Bug 7142] non public note on item edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7142 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |dcook at prosentient.com.au Resolution|--- |DUPLICATE --- Comment #2 from David Cook --- I'm marking this as a duplicate, as this issue is fairly old, and I think Kyle is doing more work on this currently... *** This bug has been marked as a duplicate of bug 13024 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 07:56:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 06:56:02 +0000 Subject: [Koha-bugs] [Bug 13285] updatedatabase throws an error if opacthemes is not set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13285 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 07:56:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 06:56:05 +0000 Subject: [Koha-bugs] [Bug 13285] updatedatabase throws an error if opacthemes is not set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13285 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33652|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 34622 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34622&action=edit Bug 13285 Do the right thing if opacthemes is not set If opacthemes is not defined updatedatabase reports the subsequent warnings as an error. Take account of the case where it is not set and default that to bootstrap. This is probably a rare occurence, but should be handled Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 08:02:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 07:02:36 +0000 Subject: [Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #8 from Martin Renvoize --- Another bug stuck in 'In Discussion'... any further thoughts/developments people? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 08:21:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 07:21:21 +0000 Subject: [Koha-bugs] [Bug 13343] Items are not embedded when sending a basket/shelf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13343 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 08:21:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 07:21:24 +0000 Subject: [Koha-bugs] [Bug 13343] Items are not embedded when sending a basket/shelf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13343 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33952|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 34623 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34623&action=edit Bug 13343: Embed items when send a basket/shelf When a basket/shelf is downloaded, items are embedded, but not when sending it by email. We would expect to get the same file. Test plan: On Opac and intranet: 1/ Add records with items to your basket and send it by email. Verify the file contains items. 2/ Add records with items to a list and send it by email. Verify the file contains items. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 09:40:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 08:40:15 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 09:40:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 08:40:19 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34620|0 |1 is obsolete| | --- Comment #200 from Katrin Fischer --- Created attachment 34624 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34624&action=edit [SIGNED OFF] Bug 7143 : Adding missing developer to the about page Signed-off-by: Chris Cormack Typed by Kahurangi, supervised by me Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 09:44:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 08:44:12 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #59 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #58) > Merci Jonathan pour les tests. > > > Lazily I tried with your host (coce.tamil.fr:8080), but it does not work. > > It seems that the browser blocks the request to other servers, which seems > > logical. > > Could you confirm or infirm that this worked for you? > > Could you try rather with: http://coce.tamil.fr:8080 I confirm that it works with the http:// -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 09:44:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 08:44:28 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |unspecified -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 10:05:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 09:05:37 +0000 Subject: [Koha-bugs] [Bug 13457] Suggestions.t expects sample itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13457 --- Comment #8 from Jonathan Druart --- (In reply to Kyle M Hall from comment #4) > Not sure if I understand what you mean. Wouldn't it be best if we made the > UT independent of what's in the database? Yes, of course. > I think this patch is useful, as I > often test with the default data, but may add new branches to it. So while > it would be best to have complete data independence, this is at least a > small step in the right direction. I am not sure adding >20 lines per test file is a good idea. Especially because we will c/p the same lines. If we consider we need to create all data before writing one test, the tests will be more difficult to read than now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 10:23:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 09:23:07 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #144 from Mason James --- Created attachment 34625 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34625&action=edit 3.16.x test push -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 10:26:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 09:26:01 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34625|0 |1 is obsolete| | CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 10:32:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 09:32:16 +0000 Subject: [Koha-bugs] [Bug 12823] Add some hints for Host, Database and SRU search fields mappings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_18_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 10:50:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 09:50:20 +0000 Subject: [Koha-bugs] [Bug 13487] New: DataTables pagination needs some fixes Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Bug ID: 13487 Summary: DataTables pagination needs some fixes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org On acqui/basketgroup.pl and catalogue/itemsearch.pl, the sPaginationType DT parameter is not explicitly defined. This broken the pagination display. Moreover, since the DT upgrade (bug 12986), the full_numbers pagination adds a span (containing '...'). It is not managed by the css file and is put at the end of the page numbers ( "1 2 3 4 5 20 NEXT LAST ...", we expect "1 2 3 4 5 ... 20 NEXT LAST"). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 10:51:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 09:51:14 +0000 Subject: [Koha-bugs] [Bug 13487] DataTables pagination needs some fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |11425, 12986 Assignee|oleonard at myacpl.org |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 10:51:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 09:51:14 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13487 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 10:51:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 09:51:14 +0000 Subject: [Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13487 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 10:58:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 09:58:23 +0000 Subject: [Koha-bugs] [Bug 13487] DataTables pagination needs some fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 10:58:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 09:58:26 +0000 Subject: [Koha-bugs] [Bug 13487] DataTables pagination needs some fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 --- Comment #1 from Jonathan Druart --- Created attachment 34626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34626&action=edit Bug 13487: DT pagination contains '...' for the full_numbers form Since the DT upgrade (bug 12986), the full_numbers pagination adds a span (containing '...'). It is not managed by the css file and is put at the end of the page numbers ( "1 2 3 4 5 20 NEXT LAST ...", we expect "1 2 3 4 5 ... 20 NEXT LAST"). Test plan: 1/ Go on the member search and launch a search which will return more than 7 pages 2/ Without this patch, the '...' span is put at the end of the pagination bar. 3/ With the patch it should be better placed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 10:58:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 09:58:29 +0000 Subject: [Koha-bugs] [Bug 13487] DataTables pagination needs some fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 --- Comment #2 from Jonathan Druart --- Created attachment 34627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34627&action=edit Bug 13487: Fix pagination for basketgroup Test plan: Go on the acqui/basketgroup.pl page and verify that the pagination button (First, Prev, Next, Last) is now correctly styled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 10:58:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 09:58:33 +0000 Subject: [Koha-bugs] [Bug 13487] DataTables pagination needs some fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 --- Comment #3 from Jonathan Druart --- Created attachment 34628 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34628&action=edit Bug 13487: Fix pagination for the item search Test plan: Go on the catalogue/itemsearch.pl page and verify that the pagination button (First, Prev, PAGES, Next, Last) is now correctly styled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 10:59:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 09:59:24 +0000 Subject: [Koha-bugs] [Bug 13487] DataTables pagination needs some fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 --- Comment #4 from Jonathan Druart --- (In reply to Jonathan Druart from comment #1) > Created attachment 34626 [details] [review] > Bug 13487: DT pagination contains '...' for the full_numbers form This is certainly not the best way to fix that. Feel free to suggest something else. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 11:00:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 10:00:09 +0000 Subject: [Koha-bugs] [Bug 13487] DataTables pagination needs some fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 --- Comment #5 from Jonathan Druart --- Let me know if you found other pagination problems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 11:02:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 10:02:29 +0000 Subject: [Koha-bugs] [Bug 13476] Item Search feature gets datatables error and doesn't complete search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13476 --- Comment #10 from Jonathan Druart --- (In reply to Katrin Fischer from comment #7) > Created attachment 34601 [details] > paging problem Fixed by bug 13487. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 13:50:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 12:50:35 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32053|0 |1 is obsolete| | Attachment #32054|0 |1 is obsolete| | Attachment #32055|0 |1 is obsolete| | Attachment #33049|0 |1 is obsolete| | --- Comment #158 from Kyle M Hall --- Created attachment 34629 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34629&action=edit Bug 9303 [1] - relative's checkouts in the opac - Database Updates Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 13:50:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 12:50:31 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 13:50:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 12:50:45 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #159 from Kyle M Hall --- Created attachment 34630 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34630&action=edit Bug 9303 [2] - relative's checkouts in the opac - Schema Updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 13:50:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 12:50:49 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #160 from Kyle M Hall --- Created attachment 34631 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34631&action=edit Bug 9303 [3] - relative's checkouts in the opac Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 13:50:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 12:50:53 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #161 from Kyle M Hall --- Created attachment 34632 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34632&action=edit Bug 9303 [QA Followup] - Don't drop non-existant keys -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 13:50:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 12:50:57 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #162 from Kyle M Hall --- Created attachment 34633 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34633&action=edit Bug 9303 [QA Followup 2] - Fix db update, move 'show' field to guarantor area -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 13:57:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 12:57:42 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #163 from Kyle M Hall --- > Changing the allowance from the 'personal details' page is not being > saved. I tried using the update button and also make a full change > request, nothing worked. > > Firefox shows a network error: > NetworkError: 404 Not Found - > http://localhost/cgi-bin/koha/svc/patron/show_checkouts_to_relatives > > If Javscript is needed to make this work, please also consider a > non-Javascript fallback. I would be happy to add a non-js fallback after this is passed qa. For now, I'm reticent to further modify the patch set that much, considering the length of time this has been in process! > * Problem (normal): I think old_issues PK should not be AUTO_INCREMENT > (see old_reserves) Fixed! > * Problem (trivial): Please add 'AFTER privacy' to updatedatabase to > ensure the correct sequence for new and updated installations Fixed! > 5) Testing 'Show checkouts to guarantor' (staff) > * Details: The information now always shows on the patron record, > if yes or no > independent from the system preference settings > independent from the patron being guarantor/guarantee > Question: Can we think of a better way here? > Maybe only show the information when (either pref is ON and the > patron is a guarantee) OR (setting is set to yes)? > Really not sure what is best here, sounds too complicated. This is outside the scope of this bug report. > * Edit form: Settings shows next to privacy > Question: Maybe it would make sense to group it with the > guarantor information? Done! > * Terminology: The setting is "...to guarantor" but the tab is labelled > "Relative's checkouts" > Question: Should we make them match? Both words are used throughout Koha. I think this is also outside the scope of this bug and would be better resolved in a separate report. I think it's tough because relative is easier for patrons to understand, but guarantor is more accurate. > 6)* Testing options and visibility in OPAC > * AllowPatronToSetCheckoutsVisibilityForGuarantor is ON > OpacPrivacy is OFF > Problem (blocker) changes to the display made from the personal > details tab won't save. Can't reproduce. When you submit new data, the changes must still be approved by a librarian. Perhaps that's the part you missed? > Notes: > - Should we not generally display information about an existing > guarantor in the patron's details in OPAC? Not sure what you mean by this, but it sounds like another further enhancement. > - If both settings are OFF the user has no information in the OPAC, > but we still show it on staff - not sure how to make this better. > It feels a bit like this is not 'round' yet. Also outside the scope of this bug, but could easily be set to be controlled by the patron level setting. This of course wouldn't prevent a librarian from looking it up separately, but would provide a bit of a 'wall' between them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 14:12:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 13:12:43 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #17 from Kyle M Hall --- I cannot reproduce this error. Are you using Koha's sample data? I'm not sure these unit tests are reliable with any other data. (In reply to Katrin Fischer from comment #16) > I am sorry, but t/db_dependent/HoldsQueue.t is failing in my installation: > > t/db_dependent/HoldsQueue.t ................. 2/23 > # Failed test 'Holds not filled with items from closed libraries' > # at t/db_dependent/HoldsQueue.t line 310. > # got: '2' > # expected: '1' > > # Failed test 'Holds not filled with items from closed libraries' > # at t/db_dependent/HoldsQueue.t line 327. > # got: '3' > # expected: '2' > # Looks like you failed 2 tests of 23. > t/db_dependent/HoldsQueue.t ................. Dubious, test returned 2 > (wstat 512, 0x200) > Failed 2/23 subtests > > Could this conflict with the calendar changes for hourly? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 14:14:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 13:14:53 +0000 Subject: [Koha-bugs] [Bug 13488] New: FastMmap can not be disable Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13488 Bug ID: 13488 Summary: FastMmap can not be disable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: stephane.delaune at biblibre.com QA Contact: testopia at bugs.koha-community.org in Koha/Cache.pm , FastMmap is automatically enable if koha-perldeps are installed, and can't be disable. This feature have to be optionnal because it generate bugs : Open of share file /tmp/sharefile-koha-koha failed: Permission denied at /usr/lib/perl5/Cache/FastMmap.pm line 640. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 14:44:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 13:44:07 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #164 from Katrin Fischer --- Hi Kyle, have you been able to reproduce/fix the first issue with the javascript error in the OPAC? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 14:44:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 13:44:36 +0000 Subject: [Koha-bugs] [Bug 13485] Add a proxy page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13485 --- Comment #7 from Eric B?gin --- David, You are correct. The proxy page is used for ressources that are restricted to connected users. The main usage is to allow patrons to access resources available by providers using a HTTP Referer mechanism. Note : This implementation doesn't include any password mechanism. Adding it would be possible. Borrowers attributes could be use to manage the username / passwords. For exemple, user accessing proxypage.pl?id=ebsco could look at ebscoUsername and ebscoPassword attributes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 15:01:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 14:01:48 +0000 Subject: [Koha-bugs] [Bug 13488] FastMmap can not be disable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13488 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13431 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 15:01:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 14:01:48 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13488 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 15:02:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 14:02:52 +0000 Subject: [Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Replace item-level codes |Add item-level descriptions |with names/descriptions for |for Label Printing |Label Printing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 15:09:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 14:09:12 +0000 Subject: [Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21285|0 |1 is obsolete| | --- Comment #8 from Dobrica Pavlinusic --- Created attachment 34634 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34634&action=edit Bug 10773 - add help for *_description fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 15:12:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 14:12:44 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34419|0 |1 is obsolete| | --- Comment #43 from simith.doliveira at inlibro.com --- Created attachment 34635 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34635&action=edit Bug 10937 - Grouped ItemTypes - Patch should apply properly on latest master. Other patches are now obsolete, this is a squashed patch. Merge conflicts were resolved. Sponsored-by: Vanier college -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 15:21:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 14:21:20 +0000 Subject: [Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 16:25:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 15:25:28 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #19 from Paola Rossi --- When I tried to select "Yes, check out (Y)", the page remained "Loading..." and no checkout was created for the patron. No item could be checked out, even if not reserved. On the contrary items can be checked out on master (3.19.00.002). I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 17:18:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 16:18:19 +0000 Subject: [Koha-bugs] [Bug 13171] Check box for email is missing for hold notifications in patron messaging preferences. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13171 --- Comment #2 from Barton Chittenden --- I am seeing the same thing happen at a different library; this time on PREDUEDGST. Note that this occurred significantly after the upgrade to 3.16, so I don't think that we're looking at an issue with update_database.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 17:49:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 16:49:33 +0000 Subject: [Koha-bugs] [Bug 7372] RoadTypes should be folded into Authorised Values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7372 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #16 from Mason James --- (In reply to Jonathan Druart from comment #11) > ping 3.16 and master RM. Followups pushed to 3.16.x, will be in 3.16.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 18:12:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 17:12:37 +0000 Subject: [Koha-bugs] [Bug 12550] Add ability to delay loading of patron's checkouts in circulation and patron details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_5_candidate | CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 18:22:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 17:22:44 +0000 Subject: [Koha-bugs] [Bug 12550] Add ability to delay loading of patron's checkouts in circulation and patron details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550 --- Comment #15 from Mason James --- skipping ENH bug for inclusion in 3.16.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 19:23:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 18:23:55 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 --- Comment #20 from Marc V?ron --- Sorry, I missed check-out failing while testing for Sing-off. Reason for failing: The patch calls AddReturn( $barcode, $branch) in circ/circulation.pl (line 557) AddReturn() immediately returns the item (and adds an entry about returning it to the Circulation history) Maybe CheckReserves would be a better way, something like $tmpitem = GetBiblioItemFromItemNumber(undef, $barcode) then test return value, call CheckReserves with $tmpitem->{'itemnumber'} and fill the template params as necessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 19:50:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 18:50:37 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 19:50:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 18:50:39 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31145|0 |1 is obsolete| | Attachment #31146|0 |1 is obsolete| | Attachment #31147|0 |1 is obsolete| | Attachment #31148|0 |1 is obsolete| | Attachment #31149|0 |1 is obsolete| | Attachment #31150|0 |1 is obsolete| | --- Comment #35 from Kyle M Hall --- Created attachment 34637 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34637&action=edit Bug 11431 [1] - Replace existing system with no change in functionality This patch set adds the ability to select which sounds are used for Koha's audio alerts, and which elements trigger those audio alerts. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Enable the AudioAlerts system preference 4) Test existing sounds 5) Set the various OverrideAudioAlert preferences to different sounds 6) Retest, verify new sounds play 7) Add/remove selectors from the AudioAlertSelector system preferences 8) Observe the difference in audio alert behavior based on your selections Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 19:50:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 18:50:49 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #36 from Kyle M Hall --- Created attachment 34638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34638&action=edit Bug 11431 [2] - Rename soundon to AudioAlerts, move to it's own preference section Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 19:50:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 18:50:51 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #37 from Kyle M Hall --- Created attachment 34639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34639&action=edit Bug 11431 [3] - Add ability to customize the warning, action, and success sounds Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 19:50:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 18:50:54 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #38 from Kyle M Hall --- Created attachment 34640 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34640&action=edit Bug 11431 [4] - Add the ability to choose the elements that trigger an audio alert Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 19:50:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 18:50:57 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #39 from Kyle M Hall --- Created attachment 34641 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34641&action=edit Bug 11431 [5] - Update sysprefs.sql Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 19:51:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 18:51:00 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #40 from Kyle M Hall --- Created attachment 34642 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34642&action=edit Bug 11431 [6] - Add the ability to specify arbitrary audio alerts This patch further enhances our control over Koha audio alerts by allowing a library to specify custom audio events. A new system preference is added the combines the functions of the Selector and Override systems preferences in a list of selector:sound combinations. These definitions override the default sounds and thus gives the library a way to completely redefine what events trigger and audio alert, and what sounds are played! Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Edit the new AudioAlertsCustom system preference and enter the following: "body:contains('Check in message')": "IM_notification.ogg" 4) Browse to the checkins page, you should hear the default sound 5) Attempt to return an invalid barcode, you should hear your custom sound! Signed-off-by: Nick Clemens All sounds seemed to work with different .ogg .mp3 .wav sound types in firefox and chrome. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 19:51:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 18:51:03 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #41 from Kyle M Hall --- Created attachment 34643 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34643&action=edit Bug 11431 [7] - Add new table for audio alerts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 19:51:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 18:51:06 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #42 from Kyle M Hall --- Created attachment 34644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34644&action=edit Bug 11431 [8] - Add audio alerts editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 19:51:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 18:51:09 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #43 from Kyle M Hall --- Created attachment 34645 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34645&action=edit Bug 11431 [9] - Remove new system preferences that are no longer needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 20:01:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 19:01:19 +0000 Subject: [Koha-bugs] [Bug 13296] error when using z3950 with UNIMARC authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13296 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #15 from Mason James --- (In reply to Chris Cormack from comment #14) > Pushed to 3.18.x, will be in 3.18.2 Pushed to 3.16.x, will be in 3.16.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 20:07:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 19:07:56 +0000 Subject: [Koha-bugs] [Bug 13465] Fields controlled by authorized values cannot be unset (Lost, damaged, not for loan status, ...) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13465 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #13 from Mason James --- (In reply to Chris Cormack from comment #12) > Pushed to 3.18.x will be in 3.18.2 skipping patch for 3.16.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 20:12:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 19:12:26 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34637|0 |1 is obsolete| | Attachment #34638|0 |1 is obsolete| | Attachment #34639|0 |1 is obsolete| | Attachment #34640|0 |1 is obsolete| | Attachment #34641|0 |1 is obsolete| | Attachment #34642|0 |1 is obsolete| | Attachment #34643|0 |1 is obsolete| | Attachment #34644|0 |1 is obsolete| | Attachment #34645|0 |1 is obsolete| | --- Comment #44 from Kyle M Hall --- Created attachment 34646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34646&action=edit Bug 11431 - Update database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 20:12:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 19:12:36 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #45 from Kyle M Hall --- Created attachment 34647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34647&action=edit Add audio alerts to installer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 20:12:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 19:12:39 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #46 from Kyle M Hall --- Created attachment 34648 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34648&action=edit Bug 11431 - Update schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 20:12:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 19:12:42 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #47 from Kyle M Hall --- Created attachment 34649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34649&action=edit Bug 11431 - Add additional sound options This patch set replaces and extends Koha's current sound options. This is implemented be removing the existing sound system, and re-engineering using a table of selector/sound combinations such that the highest precedence selector that is found in the DOM will trigger and audio alert. The existing audio behaviors are implemented as a set of default audio alerts. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Enable the AudioAlerts system preference 4) Test existing sounds 5) Enter the new alerts editor in the admin section 6) Add a new audo alert with the following selector: "body:contains('Check in message')", choose any sound alert you wish, make sure it's not one of the 3 sounds already used! Make this selector precedence 1 4) Browse to the checkins page, you should hear the default sound 5) Attempt to return an invalid barcode, you should hear your custom sound! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 20:13:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 19:13:51 +0000 Subject: [Koha-bugs] [Bug 13461] Circ always asking for confirmation if RentalFeesCheckoutConfirmation is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13461 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- (In reply to Chris Cormack from comment #6) > Pushed to 3.18.x, will be in 3.18.2 skipping patch for 3.16.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 20:14:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 19:14:19 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34646|0 |1 is obsolete| | Attachment #34647|0 |1 is obsolete| | Attachment #34648|0 |1 is obsolete| | Attachment #34649|0 |1 is obsolete| | --- Comment #48 from Kyle M Hall --- Created attachment 34650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34650&action=edit Bug 11431 [1] - Update database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 20:14:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 19:14:29 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #49 from Kyle M Hall --- Created attachment 34651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34651&action=edit Bug 11431 [2] - Add audio alerts to installer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 20:14:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 19:14:32 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #50 from Kyle M Hall --- Created attachment 34652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34652&action=edit Bug 11431 [3] - Update schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 20:14:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 19:14:35 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #51 from Kyle M Hall --- Created attachment 34653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34653&action=edit Bug 11431 [4] - Add additional sound options This patch set replaces and extends Koha's current sound options. This is implemented be removing the existing sound system, and re-engineering using a table of selector/sound combinations such that the highest precedence selector that is found in the DOM will trigger and audio alert. The existing audio behaviors are implemented as a set of default audio alerts. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Enable the AudioAlerts system preference 4) Test existing sounds 5) Enter the new alerts editor in the admin section 6) Add a new audo alert with the following selector: "body:contains('Check in message')", choose any sound alert you wish, make sure it's not one of the 3 sounds already used! Make this selector precedence 1 4) Browse to the checkins page, you should hear the default sound 5) Attempt to return an invalid barcode, you should hear your custom sound! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 20:15:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 19:15:53 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13019 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 20:15:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 19:15:53 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11431 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 20:25:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 19:25:55 +0000 Subject: [Koha-bugs] [Bug 13468] overdue notice lists all checked out books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13468 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #12 from Mason James --- (In reply to Chris Cormack from comment #11) > No string changes, pushed to 3.18.x will be in 3.18.2 skipping patch for 3.16.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 20:28:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 19:28:03 +0000 Subject: [Koha-bugs] [Bug 13398] Perl files for rotating collections are missing in installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13398 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #8 from Mason James --- (In reply to Chris Cormack from comment #7) > No string changes, pushed to 3.18.x will be in 3.18.2 skipping patch for 3.16.x -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 20:33:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 19:33:53 +0000 Subject: [Koha-bugs] [Bug 13470] pay fines with extended borrower attributes result in application error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13470 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #10 from Mason James --- (In reply to Jonathan Druart from comment #7) > Bug reproduced, I confirm this patch fixes the issue. > No regression found. > Bug introduced by bug 12542. skipping patch for 3.16.x - as bug 12542 is not in 3.16.x branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 20:54:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 19:54:52 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 20:54:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 19:54:59 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34624|0 |1 is obsolete| | --- Comment #201 from Tom?s Cohen Arazi --- Created attachment 34654 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34654&action=edit [PASSED QA] Bug 7143 : Adding missing developer to the about page Signed-off-by: Chris Cormack Typed by Kahurangi, supervised by me Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 21:00:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 20:00:00 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #202 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kahurangi! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 21:00:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 20:00:07 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34654|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 21:01:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 20:01:09 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 22 21:01:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 20:01:32 +0000 Subject: [Koha-bugs] [Bug 13370] Inputs overflow in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13370 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 00:04:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 23:04:37 +0000 Subject: [Koha-bugs] [Bug 13489] New: Notices variable for library hours Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13489 Bug ID: 13489 Summary: Notices variable for library hours Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: p.thrasher at dover.nh.gov QA Contact: testopia at bugs.koha-community.org We change our library hours at least twice a year (three times this year!). If there were a variable for notices that could contain the hours then we would only have to change them in one place and have all the notices change automatically. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 00:06:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 23:06:28 +0000 Subject: [Koha-bugs] [Bug 13489] Notices variable for library hours In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13489 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Peggy, it's not perfect, but I know some libraries are using the note field in the branch configuration for this information. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 00:18:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 23:18:51 +0000 Subject: [Koha-bugs] [Bug 13489] Notices variable for library hours In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13489 --- Comment #2 from Peggy Thrasher --- That's a good idea. Thanks, Katrin! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 00:19:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 23:19:40 +0000 Subject: [Koha-bugs] [Bug 13485] Add a proxy page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13485 --- Comment #8 from David Cook --- (In reply to Eric B?gin from comment #7) > David, > > You are correct. The proxy page is used for ressources that are restricted > to connected users. > > The main usage is to allow patrons to access resources available by > providers using a HTTP Referer mechanism. > > Note : This implementation doesn't include any password mechanism. Adding it > would be possible. Borrowers attributes could be use to manage the username > / passwords. For exemple, user accessing proxypage.pl?id=ebsco could look at > ebscoUsername and ebscoPassword attributes. Thanks for confirming, Eric :). I might take a look at adding that later down the track, depending if we have anyone needing it. We have a client or two who are looking at something along these lines, but nothing has been 100% decided yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 00:47:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 23:47:14 +0000 Subject: [Koha-bugs] [Bug 13428] Fix facet deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13428 --- Comment #11 from Mason James --- (In reply to Jonathan Druart from comment #9) > This should not have been pushed before bug 13425, because now the facets > deletion is broken :) > > It should be pushed to 3.16.x, the patch applies cleanly. > > ping Mason :) Pushed to 3.16.x, patch will be in 3.16.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 00:50:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Dec 2014 23:50:50 +0000 Subject: [Koha-bugs] [Bug 13476] Item Search feature gets datatables error and doesn't complete search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13476 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #11 from Mason James --- (In reply to Chris Cormack from comment #9) > Pushed to 3.18.x will be in 3.18.2 skipping patch for 3.16.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 01:44:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 00:44:31 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 01:54:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 00:54:37 +0000 Subject: [Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 --- Comment #53 from David Cook --- (In reply to Kyle M Hall from comment #52) > I agree with Jonathan. This has been discussed in great detail. This *has* > been a team effort with much input from Jonathan and Martin. This is also > the third iteration of this idea that I've proposed. It would be great if we > could get input from every single person, but there will always be opposing > opinions on how things should be done. At this point, I ( and probably > others ) just want something, anything, we can get and use. This does not by > any means prevent us from making improvements in the future! But we need to > start somewhere. > With deference to Jonathan and Martin, I was referring to the overarching community when I wrote "team". I know there has been some discussion here and on the lists, but I don't think there was ever any sort of consensus on the best way to move forward. That said, I know you have proposed a lot of different ideas, and kudos for that. I also know that the perfect is the enemy of the good. While I would like to avoid technical debt, I suppose it can't hurt to try out multiple ideas. Since the majority of code also comes from yourself and Jonathan, it probably makes sense to use a system that you both find useful. So long as Koha is working well for librarians and patrons, I can't really complain. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 02:35:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 01:35:26 +0000 Subject: [Koha-bugs] [Bug 13476] Item Search feature gets datatables error and doesn't complete search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13476 --- Comment #12 from Liz Rea --- Thanks everybody. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 03:28:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 02:28:18 +0000 Subject: [Koha-bugs] [Bug 12739] SendAlerts function does not take care of "html" format in letter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | --- Comment #1 from David Cook --- A library client brought this to my attention yesterday. I'll have a patch up in just a few minutes :). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 03:36:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 02:36:41 +0000 Subject: [Koha-bugs] [Bug 13490] New: Utf-8 charset content type wrong for notices sent via SendAlerts Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13490 Bug ID: 13490 Summary: Utf-8 charset content type wrong for notices sent via SendAlerts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Notices sent via SendAlerts are sent with a charset of "utf8" but this should actually be "utf-8". The former will cause the display of UTF-8 characters to bust, while the latter will cause UTF-8 characters to display correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 03:37:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 02:37:57 +0000 Subject: [Koha-bugs] [Bug 13490] Utf-8 charset content type wrong for notices sent via SendAlerts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13490 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |MOVED --- Comment #1 from David Cook --- Actually, I'm just going to lump this into http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739 for the sake of simplicity... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 03:38:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 02:38:15 +0000 Subject: [Koha-bugs] [Bug 12739] SendAlerts function does not take care of "html" format or UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|SendAlerts function does |SendAlerts function does |not take care of "html" |not take care of "html" |format in letter |format or UTF-8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 04:17:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 03:17:36 +0000 Subject: [Koha-bugs] [Bug 12739] SendAlerts function does not take care of "html" format or UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739 --- Comment #2 from David Cook --- Created attachment 34655 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34655&action=edit Bug 12739 - SendAlerts function does not take care of "html" format or UTF-8 Pt 1 The UTF-8 charset in the content type is written as "utf8" instead of "utf-8" in SendAlerts(), which causes UTF-8 characters to display incorrectly. _TEST PLAN_ Before Applying: 1) Edit ACCTDETAILS 2) Add some UTF-8 characters I recommend using the following website http://www.ltg.ed.ac.uk/~richard/unicode-sample.html In my tests, I added the samples from Hebrew, Arabic, Basic Latin, Latin-1 Supplement, Latin Extended-A, and Latin Extended-B. 3) Set the system preference "AutoEmailOpacUser" to "Send" 4) Create a new user account with your email address 5) Note that the email in your inbox doesn't display the Unicode characters correctly Apply the patch 6) Create a new user account with your email address 7) Note that the email in your inbox _does_ display the Unicode characters correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 04:17:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 03:17:34 +0000 Subject: [Koha-bugs] [Bug 12739] SendAlerts function does not take care of "html" format or UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 04:18:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 03:18:15 +0000 Subject: [Koha-bugs] [Bug 12739] SendAlerts function does not take care of "html" format or UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34655|0 |1 is obsolete| | --- Comment #3 from David Cook --- Created attachment 34656 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34656&action=edit Bug 12739 - SendAlerts function does not take care of "html" format or UTF-8 Pt 1 The UTF-8 charset in the content type is written as "utf8" instead of "utf-8" in SendAlerts(), which causes UTF-8 characters to display incorrectly. _TEST PLAN_ Before Applying: 1) Edit ACCTDETAILS 2) Add some UTF-8 characters I recommend using the following website http://www.ltg.ed.ac.uk/~richard/unicode-sample.html In my tests, I added the samples from Hebrew, Arabic, Basic Latin, Latin-1 Supplement, Latin Extended-A, and Latin Extended-B. 3) Set the system preference "AutoEmailOpacUser" to "Send" 4) Create a new user account with your email address 5) Note that the email in your inbox doesn't display the Unicode characters correctly Apply the patch 6) Create a new user account with your email address 7) Note that the email in your inbox _does_ display the Unicode characters correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 04:18:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 03:18:20 +0000 Subject: [Koha-bugs] [Bug 12739] SendAlerts function does not take care of "html" format or UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739 --- Comment #4 from David Cook --- Created attachment 34657 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34657&action=edit Bug 12739 - SendAlerts function does not take care of "html" format or UTF-8 Pt. 2 The emails sent via SendAlerts don't take into account HTML format. _TEST PLAN_ Before applying: 1) Change system preference "AutoEmailOpacUser" to "Send" 2) Change "ACCTDETAILS" notice to HTML and add HTML to it 3) Create a new user with your email address 4) Note how the email displays the HTML tags as plain text Apply patch 5) Create a new user with your email address 6) Note how the email displays the email as an HTML email For thoroughness: 7) Change "ACCTDETAILS" notice to non-HTML 8) Create a new user with your email address 9) Note how the email displays the HTML as plain text -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 04:19:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 03:19:16 +0000 Subject: [Koha-bugs] [Bug 12739] SendAlerts function does not take care of "html" format or UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739 --- Comment #5 from David Cook --- Note to testers: These patches can be tested one by one or all at once, since Pt. 2 carries forward the change from Pt. 1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 08:14:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 07:14:29 +0000 Subject: [Koha-bugs] [Bug 13410] Untranslatable "Change messaging preferences to default for this category?" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13410 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 08:15:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 07:15:59 +0000 Subject: [Koha-bugs] [Bug 12059] Publisher code always empty on invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12059 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 08:19:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 07:19:31 +0000 Subject: [Koha-bugs] [Bug 13400] Untranslatable "Are you sure you want to delete this authority?" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13400 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #10 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 08:22:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 07:22:41 +0000 Subject: [Koha-bugs] [Bug 13218] usability enhancement for z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13218 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #31 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 08:24:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 07:24:16 +0000 Subject: [Koha-bugs] [Bug 13416] Typo in marc21_leader.pl position 5 (record status) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #10 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 08:26:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 07:26:47 +0000 Subject: [Koha-bugs] [Bug 13422] SCO: "Would you like to print a receipt" not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13422 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 08:56:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 07:56:44 +0000 Subject: [Koha-bugs] [Bug 12671] Guess next serial date when there are several issues per unit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12671 --- Comment #3 from Olli-Antti Kivilahti --- Created attachment 34658 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34658&action=edit Bug 12671: Guess next serial date when there are several issues per unit. Added support for real month and year lenghts. When getting the next frequency number, use the real number of days for each month and each year. Unit tests updated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 08:57:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 07:57:51 +0000 Subject: [Koha-bugs] [Bug 12671] Guess next serial date when there are several issues per unit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12671 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi --- Comment #4 from Olli-Antti Kivilahti --- Thanks for the awesome patch! I am pushing this to production and getting feedback from our Serials people. We are just inserting our subscriptions using the Koha's serials-module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 10:12:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 09:12:15 +0000 Subject: [Koha-bugs] [Bug 12671] Guess next serial date when there are several issues per unit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12671 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30291|0 |1 is obsolete| | --- Comment #5 from Olli-Antti Kivilahti --- Created attachment 34659 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34659&action=edit Bug 12671: Refactor GetNextDate A much needed refactoring. Thanks for seeing the effort through. Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 10:18:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 09:18:32 +0000 Subject: [Koha-bugs] [Bug 12671] Guess next serial date when there are several issues per unit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12671 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30292|0 |1 is obsolete| | --- Comment #6 from Olli-Antti Kivilahti --- Created attachment 34660 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34660&action=edit Bug 12671: Guess next serial date when there are several issues per unit This guess uses the following algorithm 1/ Get the number of days remaining from first issue of this unit of time until the end of the unit of time (using 7 days for week, 28 for month and 365 for year) 2/ Divide it by the number of issues per unit 3/ Take the integer part of the result, this is the number of days to add to previous serial published date This patch also try to guess the date of the first issue of a unit of time. Before that, it was: - for week: monday of week - for month: 1st day of month - for year: 1st day of year Now it uses firstacquidate. Example: firstacquidate = 1970-01-07 (wednesday) unit = week issuesperunit = 2 (2 issues per week) From wednesday to sunday, there are 4 days so we add 2 days to get the next date. The next dates should be: - 1970-01-09 (+ 2 days) - 1970-01-14 (wednesday of next week) - 1970-01-16 (+ 2 days) - ... and so on Test plan: 1/ Go to numbering pattern creation page (Serials -> Manager numbering patterns -> New numbering pattern) 2/ In "Test prediction pattern" fieldset, set subscription length to 50 issues (this avoid to compute the next 1000 dates, which can take time) 3/ Fill first issue publication date 4/ Choose the frequency you want to test 5/ click on "Test pattern" button 6/ Check that the dates are correct 7/ Repeat steps 3-7 until you think you have tested enough cases Interesting frequencies to test: - 1/day - 1/week - 2/week - 6/week (firstacquidate should be monday or tuesday, or the generated dates will be the same for all the week) - 1/month - 2/month - 3/month - 1/year - 2/year - 3/year ---------------- Sign off report: ---------------- -Followed the test plan. Unit tests work. Also trying some more strange frequencies with our librarians: 5/year, 43/year, 10/year. -Received all serials for a subscription and found no errors. -Received some serials with frequency 2/month pre-patch, getting publication date as 1st of every month for each magazine. Having applied the patch, publication dates started working mid-subscription for new magazines. -Works well and fine! Signed-off-by: Olli-Antti Kivilahti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 10:30:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 09:30:17 +0000 Subject: [Koha-bugs] [Bug 13471] When editing a subscription, the "subscription length type" disregards the stored value, also make SLT translateable. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13471 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34506|0 |1 is obsolete| | --- Comment #4 from Olli-Antti Kivilahti --- Created attachment 34661 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34661&action=edit Bug 13471 - When editing a subscription, the "subscription length type" disregards the stored value, also make SLT translateable. This issue causes loss of data when the subscription length type (SLT) is other than issues. TO REPLICATE: We make an subscription with SLT of months = 12. Later make an arbitrary edit to the subscription, and miss out the fact that the SLT selection is set to issues. Save the changes. Serial subscription end date is set to 12 issues since the start date, instead of 12 months which it used to be. This causes a myriad of issues :=) AFTER THIS PATCH: SLT defaults to the value initially saved instead of always being issues. Now the selection can be translated! HOTFIX 1: Added elements to showSubscriptionLengthType.inc so the translation tool can catch them. HOTFIX 2: Fixed serials/showpredictionpattern.pl to use the db columns instead of issues,weeks,months. HOTFIX 3: Fixed serials/subscription-numberpatterns.pl to use the db columns instead of issues,weeks,months. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 12:19:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 11:19:43 +0000 Subject: [Koha-bugs] [Bug 12814] KOHA Cataloging (Authorities) Problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12814 Jonathan Smith changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan_smith at mail.com Version|3.16 |master Severity|normal |major --- Comment #1 from Jonathan Smith --- Hello, This is a serious problem, when CatalogModuleRelink is on when entering a new record gets a incorrectly auhtid for a text in different terms of authority. I also noticed in link_bibs_to_authorities.pl that regardless of the setting CatalogModuleRelink also have this problem. Cheers, Jonathan Librarian ULS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 14:47:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 13:47:45 +0000 Subject: [Koha-bugs] [Bug 13491] New: make Selfcheck follow the CircAutoPrintQuickSlip Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13491 Bug ID: 13491 Summary: make Selfcheck follow the CircAutoPrintQuickSlip Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Selfcheck should follow the CircAutoPrintQuickSlip system preference - or maybe we need another sys pref to control which slip prints via self check. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 15:48:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 14:48:49 +0000 Subject: [Koha-bugs] [Bug 13492] New: Add location to the checkouts tables Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13492 Bug ID: 13492 Summary: Add location to the checkouts tables Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The patch set will add the location column to the checkouts tables (circ/circulation.pl and members/moremember.pl). On the way, it will also add the column settings for these tables. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 15:49:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 14:49:03 +0000 Subject: [Koha-bugs] [Bug 13492] Add location to the checkouts tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13492 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |10212 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 15:49:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 14:49:03 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13492 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 15:58:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 14:58:13 +0000 Subject: [Koha-bugs] [Bug 13492] Add location to the checkouts tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13492 --- Comment #1 from Jonathan Druart --- Created attachment 34662 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34662&action=edit Bug 13492: Add the column configuration for the checkouts table - circulation.pl Test plan: 1/ Verify that you can show/hide columns on the checkouts table (circulation.pl). 2/ Play with the column configuration admin page (admin/columns_settings.pl), and confirm the behavior is correct (depends on what you have selected). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 15:58:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 14:58:11 +0000 Subject: [Koha-bugs] [Bug 13492] Add location to the checkouts tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13492 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 15:58:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 14:58:17 +0000 Subject: [Koha-bugs] [Bug 13492] Add location to the checkouts tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13492 --- Comment #2 from Jonathan Druart --- Created attachment 34663 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34663&action=edit Bug 13492: Add the column configuration for the checkouts table - morember.pl Test plan: 1/ Verify that you can show/hide columns on the checkouts table (moremember.pl). 2/ Play with the column configuration admin page (admin/columns_settings.pl), and confirm the behavior is correct (depends on what you have selected). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 15:58:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 14:58:20 +0000 Subject: [Koha-bugs] [Bug 13492] Add location to the checkouts tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13492 --- Comment #3 from Jonathan Druart --- Created attachment 34664 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34664&action=edit Bug 13492: Add the location column to the checkouts tables Test plan: 1/ Verify that the location column is correctly displayed on the checkouts tables (circ/circulation.pl and members/moremember.pl). 2/ Verify that you can hide/show this column (using the admin page and/or the ColVis DT plugin). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 16:16:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 15:16:15 +0000 Subject: [Koha-bugs] [Bug 13442] Facet links broken when collection code limit is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- Does this work if the facet contain a simple quote? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 16:31:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 15:31:59 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #44 from Paola Rossi --- I've applied the patches against master 3.19.00.002 The first patch requires: prove t/db_dependent/Serials_2.t t/db_dependent/Serials_2.t .. Global symbol "$subscriptionid" requires explicit package name at t/db_dependent/Serials_2.t line 208. Global symbol "$subscriptionid" requires explicit package name at t/db_dependent/Serials_2.t line 209. Global symbol "$subscriptionid" requires explicit package name at t/db_dependent/Serials_2.t line 210. Global symbol "$subscriptionid" requires explicit package name at t/db_dependent/Serials_2.t line 212. Global symbol "$subscriptionid" requires explicit package name at t/db_dependent/Serials_2.t line 213. Global symbol "$subscriptionid" requires explicit package name at t/db_dependent/Serials_2.t line 214. Global symbol "$subscriptionid" requires explicit package name at t/db_dependent/Serials_2.t line 215. Execution of t/db_dependent/Serials_2.t aborted due to compilation errors. # Looks like your test exited with 255 before it could output anything. t/db_dependent/Serials_2.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 36/36 subtests Test Summary Report ------------------- t/db_dependent/Serials_2.t (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 36 tests but ran 0. Files=1, Tests=0, 1 wallclock secs ( 0.00 usr 0.01 sys + 0.72 cusr 0.05 csys = 0.78 CPU) Result: FAIL I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 16:41:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 15:41:38 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #60 from Jonathan Druart --- I tried to host the webservice, and it worked until I got this error: % node webservice.js /home/koha/tools/coce/node_modules/aws-lib/lib/aws.js:78 if (err) throw err; ^ Error: metadata API response undefined at ClientRequest. (/home/koha/tools/coce/node_modules/aws-lib/lib/aws.js:37:49) at ClientRequest.g (events.js:180:16) at ClientRequest.emit (events.js:92:17) at Socket.emitTimeout (http.js:1797:10) at Socket.g (events.js:180:16) at Socket.emit (events.js:92:17) at Socket._onTimeout (net.js:326:8) at Timer.unrefTimeout [as ontimeout] (timers.js:418:13) Did you already get it? Could you please provide a followup for the [% USE Koha %]? I think you need to move it, not to remove it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 16:49:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 15:49:49 +0000 Subject: [Koha-bugs] [Bug 13040] Improve exporter to allow multiple branch selections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply --- Comment #6 from Paola Rossi --- I've tried to apply the patch against master 3.19.00.002 Applying: Bug 13040 - multiple branch selections in exporter Using index info to reconstruct a base tree... :28: new blank line at EOF. + warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging tools/export.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/export.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css Failed to merge in the changes. Patch failed at 0001 Bug 13040 - multiple branch selections in exporter I pass the patch to "Patch doesn't apply" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 16:52:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 15:52:30 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 16:52:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 15:52:34 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 --- Comment #45 from Jonathan Druart --- Created attachment 34665 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34665&action=edit Bug 7677: Fix tests They don't pass since bug 12098 has been pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 17:14:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 16:14:09 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply --- Comment #93 from Paola Rossi --- I've tried to apply the patch against master 3.19.00.002 Applying: Bug 8367 - How long is a hold waiting for pickup at a more granular level Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Holds.t Auto-merging svc/holds Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/js/holds.js Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/kohastructure.sql Auto-merging circ/waitingreserves.pl Auto-merging C4/Reserves.pm Auto-merging C4/Letters.pm Failed to merge in the changes. Patch failed at 0001 Bug 8367 - How long is a hold waiting for pickup at a more granular level So I pass the patch to "Patch doesn't apply" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 23 22:05:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Dec 2014 21:05:23 +0000 Subject: [Koha-bugs] [Bug 13458] Add new patron shows default / hardcoded patron categories after search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- We can confirm this bug still appears in 3.18.2. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 24 09:32:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Dec 2014 08:32:02 +0000 Subject: [Koha-bugs] [Bug 13357] Untranslatable strings on itemsearch.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13357 --- Comment #4 from Marc V?ron --- Created attachment 34666 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34666&action=edit [Signed-off] Bug 13357: Untranslatable strings on itemsearch.tt This patch enable translation of labels on itemsearch.tt To test: 1) Translate for a fairly complete language (es-ES de-DE) 2) On staff, go to Search > Item search 3) Check there are many untranslated strings e.g. Text before pulldowns on first and second box All options on third box 4) Apply the patch 5) Repeat 1 & 2 6) Check there are now some strings translated 7) Update translation file, check there are some new strings to translate (may be they are fuzzy) e.g. "All statuses", "All collection codes" Patch works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 24 09:32:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Dec 2014 08:32:50 +0000 Subject: [Koha-bugs] [Bug 13357] Untranslatable strings on itemsearch.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13357 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34015|0 |1 is obsolete| | CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 24 09:33:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Dec 2014 08:33:14 +0000 Subject: [Koha-bugs] [Bug 13357] Untranslatable strings on itemsearch.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13357 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 24 10:30:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Dec 2014 09:30:10 +0000 Subject: [Koha-bugs] [Bug 2505] enable Perl warnings in all modules and scripts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 --- Comment #24 from Paul Poulain --- (In reply to Andrew Maguire from comment #23) > During testing, discovered the charconv() function is a no-op, so I wondered > what > should happen if database is in MARC8 (non-UTF) format. Hi Andrew, Can this happen ? unless I misunderstand something, Koha transform MARC8 into UTF when importing, so in the database, you should have only UTF records. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 24 11:10:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Dec 2014 10:10:05 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 --- Comment #44 from Marc V?ron --- Created attachment 34667 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34667&action=edit [Signed-off] Bug 10947 - Grouped ItemTypes - Patch should apply properly on latest master. Other patches are now obsolete, this is a squashed patch. Merge conflicts were resolved. Sponsored-by: Vanier college http://bugs.koha-community.org/show_bug.cgi?id=10937 Followed test plan (comment #34), works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 24 11:10:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Dec 2014 10:10:31 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34635|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 24 11:11:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Dec 2014 10:11:10 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 24 12:05:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Dec 2014 11:05:58 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34034|0 |1 is obsolete| | --- Comment #66 from Jonathan Druart --- Created attachment 34668 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34668&action=edit Bug 8007: Discharge - DB changes This patch adds: - syspref useDischarge - the new table discharges - the discharge notice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 24 12:06:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Dec 2014 11:06:18 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34035|0 |1 is obsolete| | --- Comment #67 from Jonathan Druart --- Created attachment 34669 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34669&action=edit Bug 8007: Discharge - DBIx changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 24 12:06:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Dec 2014 11:06:40 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34036|0 |1 is obsolete| | --- Comment #68 from Jonathan Druart --- Created attachment 34670 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34670&action=edit Bug 8007: Discharge - Glue This patch adds: - links to the new pages. - syspref description - links on the main page (intranet) - the DISCHARGE type for debarment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 24 12:06:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Dec 2014 11:06:57 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34037|0 |1 is obsolete| | --- Comment #69 from Jonathan Druart --- Created attachment 34671 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34671&action=edit Bug 8007: Discharge management This patch is the main patch. It adds new package and files for the new pages (opac-discharge, members/discharge and members/discharges). At the intranet, it is now possible to generate a discharge for a patron. At the opac, a patron can request a discharge and a discharge if it has been validated by a librarian. Requirements: The perl module PDF::FromHTML New sysprefs: - useDischarge: Allows librarians to discharge borrowers and borrowers to request a discharge New letter with a letter_code DISCHARGE. Test plan: - Switch on the syspref useDischarge. - Verify a new tab appears in the patron page (intranet and opac). - Verify the discharge cannot be generated if the patron has issues. - Verify the patron can request a discharge from it's opac area. - The request appears on the main page (intranet). - Generate the discharge from the intranet. - Try to download it (from the opac and the intranet). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 24 12:07:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Dec 2014 11:07:15 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34038|0 |1 is obsolete| | --- Comment #70 from Jonathan Druart --- Created attachment 34672 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34672&action=edit Bug 8007: Discharge - Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 24 12:07:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Dec 2014 11:07:26 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34039|0 |1 is obsolete| | --- Comment #71 from Jonathan Druart --- Created attachment 34673 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34673&action=edit Bug 8007 : Discharge - Adding Perl dependencie HTML::HTMLDoc is required in order to generate the discharges in PDF format. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 24 12:07:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Dec 2014 11:07:31 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #72 from Jonathan Druart --- Created attachment 34674 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34674&action=edit Bug 8007: Replace HTML::HTMLDoc with PDF::FromHTML -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 24 12:07:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Dec 2014 11:07:35 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #73 from Jonathan Druart --- Created attachment 34675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34675&action=edit Bug 8007: Compatibility with bug 11944 This patch should be applied to work with bug 11944. If you don't have 11944 yet, just don't apply this patch. Note that the line binmode(STDOUT); in pl files is mandatory. It comes from bug 11944 that adds the line binmode( STDOUT, ":utf8" ); in C4::Templates::gettemplate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 24 12:09:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Dec 2014 11:09:54 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #74 from Jonathan Druart --- (In reply to Bernardo Gonzalez Kriegel from comment #65) > Would it be possible to use PDF::fromHTML? > (http://search.cpan.org/~autrijus/PDF-FromHTML-0.12/lib/PDF/FromHTML.pm) Now the discharge use this module. (In reply to Bernardo Gonzalez Kriegel from comment #64) > We need 11944... I submitted an optional patch ( 8007: Compatibility with bug 11944 ). You can test this patch with or without bug 11944. Both solutions should work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 24 12:18:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Dec 2014 11:18:01 +0000 Subject: [Koha-bugs] [Bug 9848] SIP tests : fix in 10renew_all.t (additionnal checkin) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 24 12:18:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Dec 2014 11:18:04 +0000 Subject: [Koha-bugs] [Bug 9848] SIP tests : fix in 10renew_all.t (additionnal checkin) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16517|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 34676 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34676&action=edit Bug 9848: SIP tests, fix in 10renew_all.t (additionnal checkin) Adds a checkin operation at the beginning of the test. Otherwise, a former test leaves the test item checked out and this generates an error. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 24 12:18:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Dec 2014 11:18:31 +0000 Subject: [Koha-bugs] [Bug 9848] SIP tests : fix in 10renew_all.t (additionnal checkin) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #5 from Jonathan Druart --- (In reply to Mason James from comment #3) > Adrien, can you please perltidy this file, so qa-tool will pass it? > http://wiki.koha-community.org/wiki/Coding_Guidelines#PERL1:_Perltidy The changes have been perltidied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 24 13:13:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Dec 2014 12:13:47 +0000 Subject: [Koha-bugs] [Bug 11607] items.content does not contain any formatting when HTML message is selected. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11607 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 24 13:13:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Dec 2014 12:13:50 +0000 Subject: [Koha-bugs] [Bug 11607] items.content does not contain any formatting when HTML message is selected. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11607 --- Comment #2 from Jonathan Druart --- Created attachment 34677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34677&action=edit Bug 11607: Don't display all items in a single line If the *DGST notices are sent in HTML, the items are displayed in a single line. To reproduce: 1/ Define a *DGST notice using the <> pattern. 2/ Checkout at least 2 items to a patron and set the due date as today. 3/ Launch the advance_notices.pl and process_message_queue.pl cronjobs. 4/ Verify the email you will receive separates the items with a line break. Verify you don't find a regression for non-html letters. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 24 13:14:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Dec 2014 12:14:02 +0000 Subject: [Koha-bugs] [Bug 11607] items.content does not contain any formatting when HTML message is selected. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11607 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 24 14:22:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Dec 2014 13:22:16 +0000 Subject: [Koha-bugs] [Bug 12053] Borrower attributes not visible anymore at OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12053 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- Fridolin, On the patron attributes types form (admin/patron-attr-types.pl), you can check the "Display in OPAC" checkbox to see the attribute displayed on opac-memberentry.pl page. Does not it what you are searching for? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 24 18:07:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Dec 2014 17:07:28 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33201|0 |1 is obsolete| | --- Comment #61 from Fr?d?ric Demians --- Created attachment 34678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34678&action=edit Bug 9580 Cover images from Coce, a remote image URL cache Add to Koha support for displaying Book cover requested to Coce, a remote image URL cache: https://github.com/fredericd/coce With this enhancement, cover images are not fetched directly from Amazon, Google, and so on. Their URL are requested via a web service to Coce which manages a cache of URLs. Three cover image providers are now available: Google Books (gb), Amazon (aws), and Open Library (ol). Two system preferences enable this service: - CoceHost - URL of Coce server - CoceProviders - Ordered list of requested providers. For example gb,aws,ol, will return the first available URL from those providers. Several advantages to this architecture: - If a book cover is not available from a provider, but is available from another one, Koha will be able to display a book cover, which isn't the case now - Since URLs are cached, it isn't necessary for each book cover to request, again and again, the provider, and several of them if necessary. - Amazon book covers are retrieved with Amazon Product Advertising API, which means that more covers are retrieved (ISBN13). Test plan: - Apply this patch, and test with 'Bootstrap' themes - You can verify that nothing has changed on OPAC result and detail page, since new syspref haven't been filled - Install Code: https://github.com/fredericd/coce Or ask me directly for the URL of a Coce server - In sysprefs, tab Enhanced content, modify: CoceHost -- enter the URL of your Coce server CoceProviders -- fill with: gb,aws,ol - Do a search. On result page, and detail page, you will see cover images originating from the 3 providers: fly over the image to see its URL. Try to compare with a Koha with just GoogleJacket or Amazon cover to confirm that you have more images. Verify that it's quick, and even quicker for cached images URLs. - Check that Browse Shelf functionnality works properly. - The ID sent to Coce is EAN or ISBN. Try with various type of biblios. DVD have often EAN, but no ISBN. - You can try with those sysprefs: CoceProviders: aws,gb CoceHost: http://coce.tamil.fr:8080 and this EAN (or ISBN): 3333297517744 => OPACAmazonCoverImages enabled doesn't display a cover because, it's a DVD => Coce find and display the DVD cover. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 24 18:19:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Dec 2014 17:19:13 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #62 from Fr?d?ric Demians --- (In reply to Jonathan Druart from comment #60) > I tried to host the webservice, and it worked until I got this error: > > % node webservice.js > > /home/koha/tools/coce/node_modules/aws-lib/lib/aws.js:78 > if (err) throw err; > ^ > Error: metadata API response undefined > at ClientRequest. > (/home/koha/tools/coce/node_modules/aws-lib/lib/aws.js:37:49) > at ClientRequest.g (events.js:180:16) > at ClientRequest.emit (events.js:92:17) > at Socket.emitTimeout (http.js:1797:10) > at Socket.g (events.js:180:16) > at Socket.emit (events.js:92:17) > at Socket._onTimeout (net.js:326:8) > at Timer.unrefTimeout [as ontimeout] (timers.js:418:13) > > Did you already get it? No. To track down this bug, it is required to have the ISBN/EAN which is sent to AWS. A tool like Phusion Passenger can help avoiding crashing the whole service when such an error occurs. > Could you please provide a followup for the [% USE Koha %]? > I think you need to move it, not to remove it. Done. Suppring the directive seems to be ok: covers are displayed in 3 locations: resultat page, detail page, and browse by location. I've resubmitted the whole as one patch, keeping Mark sign-off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 24 18:48:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Dec 2014 17:48:27 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #45 from M. Tompsett --- Sorry, but modifying the table structure requires a patch to Schema files. http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567#c58 That was my first experience with them. Hope this helps. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 25 19:56:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Dec 2014 18:56:00 +0000 Subject: [Koha-bugs] [Bug 12565] Acq: Link to basket in breadcrumbs broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12565 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 25 20:02:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Dec 2014 19:02:04 +0000 Subject: [Koha-bugs] [Bug 13436] Add more options to UsageStatsLibraryType In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13436 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #15 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 25 20:08:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Dec 2014 19:08:06 +0000 Subject: [Koha-bugs] [Bug 10753] Creating suggestions for 'Any library' uses _ANY as branchcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10753 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 25 20:22:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Dec 2014 19:22:20 +0000 Subject: [Koha-bugs] [Bug 13415] Prevent librarians from scanning multiple items into a single barcode field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13415 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #12 from Chris Cormack --- Pushed to 3.18.x is 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 25 20:24:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Dec 2014 19:24:53 +0000 Subject: [Koha-bugs] [Bug 13370] Inputs overflow in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13370 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #9 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 09:39:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 08:39:37 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 09:39:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 08:39:44 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34678|0 |1 is obsolete| | --- Comment #63 from Jonathan Druart --- Created attachment 34679 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34679&action=edit Bug 9580 Cover images from Coce, a remote image URL cache Add to Koha support for displaying Book cover requested to Coce, a remote image URL cache: https://github.com/fredericd/coce With this enhancement, cover images are not fetched directly from Amazon, Google, and so on. Their URL are requested via a web service to Coce which manages a cache of URLs. Three cover image providers are now available: Google Books (gb), Amazon (aws), and Open Library (ol). Two system preferences enable this service: - CoceHost - URL of Coce server - CoceProviders - Ordered list of requested providers. For example gb,aws,ol, will return the first available URL from those providers. Several advantages to this architecture: - If a book cover is not available from a provider, but is available from another one, Koha will be able to display a book cover, which isn't the case now - Since URLs are cached, it isn't necessary for each book cover to request, again and again, the provider, and several of them if necessary. - Amazon book covers are retrieved with Amazon Product Advertising API, which means that more covers are retrieved (ISBN13). Test plan: - Apply this patch, and test with 'Bootstrap' themes - You can verify that nothing has changed on OPAC result and detail page, since new syspref haven't been filled - Install Code: https://github.com/fredericd/coce Or ask me directly for the URL of a Coce server - In sysprefs, tab Enhanced content, modify: CoceHost -- enter the URL of your Coce server CoceProviders -- fill with: gb,aws,ol - Do a search. On result page, and detail page, you will see cover images originating from the 3 providers: fly over the image to see its URL. Try to compare with a Koha with just GoogleJacket or Amazon cover to confirm that you have more images. Verify that it's quick, and even quicker for cached images URLs. - Check that Browse Shelf functionnality works properly. - The ID sent to Coce is EAN or ISBN. Try with various type of biblios. DVD have often EAN, but no ISBN. - You can try with those sysprefs: CoceProviders: aws,gb CoceHost: http://coce.tamil.fr:8080 and this EAN (or ISBN): 3333297517744 => OPACAmazonCoverImages enabled doesn't display a cover because, it's a DVD => Coce find and display the DVD cover. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Amended patch: replaced 1 tab with spaces in C4/Shelfbrowser.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 09:43:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 08:43:20 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #64 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #62) > (In reply to Jonathan Druart from comment #60) > > I tried to host the webservice, and it worked until I got this error: > > > > % node webservice.js > > > > /home/koha/tools/coce/node_modules/aws-lib/lib/aws.js:78 > > if (err) throw err; > > ^ > > Error: metadata API response undefined > > at ClientRequest. > > (/home/koha/tools/coce/node_modules/aws-lib/lib/aws.js:37:49) > > at ClientRequest.g (events.js:180:16) > > at ClientRequest.emit (events.js:92:17) > > at Socket.emitTimeout (http.js:1797:10) > > at Socket.g (events.js:180:16) > > at Socket.emit (events.js:92:17) > > at Socket._onTimeout (net.js:326:8) > > at Timer.unrefTimeout [as ontimeout] (timers.js:418:13) > > > > Did you already get it? > > No. To track down this bug, it is required to have the ISBN/EAN which is > sent to AWS. I got it again, but it's completely random (I have got it with the same url I use). I don't know where it can come from. However, it's the only problem I got, the code is clean and all works great. Nice feature! Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 09:43:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 08:43:38 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 10:01:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 09:01:08 +0000 Subject: [Koha-bugs] [Bug 12053] Borrower attributes not visible anymore at OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12053 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Jonathan Druart --- Frido confirmed me that it's not a bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 10:13:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 09:13:57 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 --- Comment #46 from Katrin Fischer --- I am not sure if the change to the schema files is mandatory yet, but if you do it, please put it in a separate patch to avoid conflicts. http://wiki.koha-community.org/wiki/Database_updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 10:14:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 09:14:17 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 10:15:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 09:15:34 +0000 Subject: [Koha-bugs] [Bug 13408] Tell librarians they may continue scanning while checkouts table is loading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13408 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle at bywatersolutions.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 10:36:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 09:36:58 +0000 Subject: [Koha-bugs] [Bug 13458] Add new patron shows default / hardcoded patron categories after search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 10:37:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 09:37:02 +0000 Subject: [Koha-bugs] [Bug 13458] Add new patron shows default / hardcoded patron categories after search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 --- Comment #2 from Jonathan Druart --- Created attachment 34680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34680&action=edit Bug 13458: Display the correct patron categories Bug 9811 removes useful code. Actually the AddPatronLists pref is not sent to the template from members/member.pl. To fix this issue, we can use the existing not clean way, or compare the syspref value directly in the template. This second solution is implemented in this patch. Test plan: 1/ Set the AddPatronLists pref to 'specific' 2/ On the patron home page (members/members-home/pl), the patron search result page (members/member.pl after launching a search) and on the checkouts page/patron search result (circ/circulation.pl after searching a patron using the check out), verify that the patron category list is the specific ones. 3/ Test there are no regression with the AddPatronLists pref set to 'general'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 10:37:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 09:37:31 +0000 Subject: [Koha-bugs] [Bug 13458] Add new patron shows default / hardcoded patron categories after search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Version|3.18 |master Depends on| |9811 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 10:37:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 09:37:31 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13458 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 11:09:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 10:09:12 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #15 from Jonathan Druart --- QA comment: I am quite confuse by this patch. IMO there are some inconsistencies: 1/ I don't understand the usefulness to pass by the template plugin to know if a borrower has overdues or not. 2/ Why did you move parse_letter to the pm file? A subroutine with the same name exists in advance_notices.pl cronjob script (which uses C4::Overdues too, so introduces a redefinion of it)? 3/ Same for C4::Members::GetOverdues, we already have a GetOverdues subroutine in C4::Overdues. 4/ Tests are missing for changes in packages. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 11:20:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 10:20:26 +0000 Subject: [Koha-bugs] [Bug 13357] Untranslatable strings on itemsearch.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13357 --- Comment #5 from Jonathan Druart --- Created attachment 34681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34681&action=edit Bug 13357: Untranslatable strings on itemsearch.tt This patch enable translation of labels on itemsearch.tt To test: 1) Translate for a fairly complete language (es-ES de-DE) 2) On staff, go to Search > Item search 3) Check there are many untranslated strings e.g. Text before pulldowns on first and second box All options on third box 4) Apply the patch 5) Repeat 1 & 2 6) Check there are now some strings translated 7) Update translation file, check there are some new strings to translate (may be they are fuzzy) e.g. "All statuses", "All collection codes" Patch works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 11:20:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 10:20:42 +0000 Subject: [Koha-bugs] [Bug 13357] Untranslatable strings on itemsearch.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13357 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34666|0 |1 is obsolete| | CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 11:21:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 10:21:29 +0000 Subject: [Koha-bugs] [Bug 13357] Untranslatable strings on itemsearch.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13357 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Jonathan Druart --- Great improvement! All looks good. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 11:36:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 10:36:40 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #47 from Jonathan Druart --- This patch needs a little bit more work to be readable by QAers. There is not decent commit message, please read http://wiki.koha-community.org/wiki/Commit_messages Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 11:43:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 10:43:18 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 --- Comment #48 from Jonathan Druart --- Comment on attachment 34667 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34667 [Signed-off] Bug 10947 - Grouped ItemTypes - Patch should apply properly on latest master. Review of attachment 34667: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10937&attachment=34667) ----------------------------------------------------------------- Quick code review. ::: C4/Koha.pm @@ +283,5 @@ > +The categories must be part of Authorized Values (DOCTYPECAT) > + > +=cut > + > +sub GetItemTypesCategorized { Why don't you use C4::ItemType? @@ +287,5 @@ > +sub GetItemTypesCategorized { > + my $dbh = C4::Context->dbh; > + # Order is important, so that partially hidden (some items are not visible in OPAC) search > + # categories will be visible. hideinopac=0 must be last. > + my $query = qq| There are no string interpolation here, limit to q|| @@ +312,5 @@ > + > + my %itemtypes; > + while ( my $IT = $sth->fetchrow_hashref ) { > + $itemtypes{ $IT->{'itemtype'} } = $IT; > + } useless while, have a look at selectall_hashref. @@ +324,5 @@ > +Returns the itemtype code of all itemtypes included in a searchcategory. > + > +=cut > + > +sub GetItemTypesByCategory { Why don't you use C4::ItemType? @@ +334,5 @@ > + $sth->execute($category); > + > + while ( my $data = $sth->fetchrow ) { > + push ( @results, $data ); > + } useless while, have a look at selectall_arrayref ::: installer/data/mysql/kohastructure.sql @@ +1276,4 @@ > checkinmsg VARCHAR(255), -- message that is displayed when an item with the given item type is checked in > checkinmsgtype CHAR(16) DEFAULT 'message' NOT NULL, -- type (CSS class) for the checkinmsg, can be "alert" or "message" > sip_media_type VARCHAR(3) DEFAULT NULL, -- SIP2 protocol media type for this itemtype > + hideinopac tinyint(1) NOT NULL DEFAULT 0, -- Hide the item type from the search options in OPAC There are occurrences of hideatopac in the code, maybe it's better than hideinopac. Need to be confirmed by English native speaker. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 14:14:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 13:14:30 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 --- Comment #49 from M. Tompsett --- (In reply to Jonathan Druart from comment #48) > There are occurrences of hideatopac in the code, maybe it's better than > hideinopac. Need to be confirmed by English native speaker. I can see how both might be used. The idea being that something is hidden at display time by OPAC vs. OPAC is being used an something is hidden in the output. Personally, hide in OPAC is clearer to Canadian, Anglophone me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 15:19:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 14:19:26 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #256 from Tom?s Cohen Arazi --- Guys, can u please take a look at the tests from 13264? It seems that the latest refactoring of the tests yield a situation where the tests don't pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 15:34:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 14:34:01 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #55 from Jonathan Druart --- Marcel, all looks good to me but I have few questions: 1/ Could you please detail when the RESET mode should be used? 2/ ExecDBRev takes 5 parameters, but you use only 3, the idea is to call this routine for each db rev in updatedatabase.pl? 3/ What means the $rv flag? 4/ Don't you think we should move the 2 files to skip into another directory (and use this one exclusively for this use)? 5/ 9691 $rv = 1 if !$! && !$@; #apparently, the file does not end with 1; I tested with a file without 1; and I don't get any error. 6/ From http://perldoc.perl.org/functions/do.html, it seems that 9690 print "ERROR: $!\n" if $!; should be 9690 print "ERROR: $!\n" if $! and not $@; 7/ In TRACK mode, given the following file: 1 use Modern::Perl; 2 use C4::Context; 3 my $dbh = C4::Context->dbh; 4 $dbh->do("delete from foo"); I executed perl installer/data/mysql/updatedatabase.pl and I got DBD::mysql::db do failed: Table 'koha.foo' doesn't exist at /home/koha/src/installer/data/mysql/atomicupdate/test3.pl line 4. Dev upgrade test3.pl done The filename is appended to _localatomicupdates, it seems it should not, could you confirm? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 15:57:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 14:57:41 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #43 from Jonathan Druart --- Zeno, could you confirm/infirm that my new tests pass for you? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 20:27:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 19:27:44 +0000 Subject: [Koha-bugs] [Bug 13458] Add new patron shows default / hardcoded patron categories after search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 20:27:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 19:27:47 +0000 Subject: [Koha-bugs] [Bug 13458] Add new patron shows default / hardcoded patron categories after search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34680|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 34682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34682&action=edit Bug 13458: Display the correct patron categories Bug 9811 removes useful code. Actually the AddPatronLists pref is not sent to the template from members/member.pl. To fix this issue, we can use the existing not clean way, or compare the syspref value directly in the template. This second solution is implemented in this patch. Test plan: 1/ Set the AddPatronLists pref to 'specific' 2/ On the patron home page (members/members-home/pl), the patron search result page (members/member.pl after launching a search) and on the checkouts page/patron search result (circ/circulation.pl after searching a patron using the check out), verify that the patron category list is the specific ones. 3/ Test there are no regression with the AddPatronLists pref set to 'general'. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 20:46:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 19:46:18 +0000 Subject: [Koha-bugs] [Bug 13487] DataTables pagination needs some fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34626|0 |1 is obsolete| | --- Comment #6 from Chris Cormack --- Created attachment 34683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34683&action=edit Bug 13487: DT pagination contains '...' for the full_numbers form Since the DT upgrade (bug 12986), the full_numbers pagination adds a span (containing '...'). It is not managed by the css file and is put at the end of the page numbers ( "1 2 3 4 5 20 NEXT LAST ...", we expect "1 2 3 4 5 ... 20 NEXT LAST"). Test plan: 1/ Go on the member search and launch a search which will return more than 7 pages 2/ Without this patch, the '...' span is put at the end of the pagination bar. 3/ With the patch it should be better placed. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 20:46:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 19:46:33 +0000 Subject: [Koha-bugs] [Bug 13487] DataTables pagination needs some fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34627|0 |1 is obsolete| | --- Comment #7 from Chris Cormack --- Created attachment 34684 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34684&action=edit Bug 13487: Fix pagination for basketgroup Test plan: Go on the acqui/basketgroup.pl page and verify that the pagination button (First, Prev, Next, Last) is now correctly styled. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 20:46:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 19:46:51 +0000 Subject: [Koha-bugs] [Bug 13487] DataTables pagination needs some fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 20:46:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 19:46:55 +0000 Subject: [Koha-bugs] [Bug 13487] DataTables pagination needs some fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34628|0 |1 is obsolete| | --- Comment #8 from Chris Cormack --- Created attachment 34685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34685&action=edit Bug 13487: Fix pagination for the item search Test plan: Go on the catalogue/itemsearch.pl page and verify that the pagination button (First, Prev, PAGES, Next, Last) is now correctly styled. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 21:08:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 20:08:10 +0000 Subject: [Koha-bugs] [Bug 13319] On inserting an order, the parent_ordernumber attribute is not set to the object In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13319 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33775|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 34686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34686&action=edit Bug 13319: Fix Koha::Acq::Order should set parent_ordernumber The tests highligh the problem: if the parent_ordernumber attribute is not set on inserting an order, the object returned by the method does not contain the value (undef). Test plan: Verify the tests are consistent and prove t/db_dependent/Acquisition/CancelReceipt.t should return green. You can also verify that receive partially an order and cancel the receipt work as expected. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 21:08:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 20:08:08 +0000 Subject: [Koha-bugs] [Bug 13319] On inserting an order, the parent_ordernumber attribute is not set to the object In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13319 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 21:16:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 20:16:28 +0000 Subject: [Koha-bugs] [Bug 13270] On receiving, "vendor note" label should not be displayed if nothing to display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13270 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 21:16:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 20:16:31 +0000 Subject: [Koha-bugs] [Bug 13270] On receiving, "vendor note" label should not be displayed if nothing to display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13270 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33618|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 34687 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34687&action=edit Bug 13270: Don't display "vendor note" label if nothing to display Bug 12111 removes the vendor note edition on receiving. The label should not be displayed when it's empty. Test plan: 1/ Receive an order without a vendor note and verify that the label is not displayed. 2/ Receive an order with a vendor note and verify that the note is displayed. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 21:47:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 20:47:05 +0000 Subject: [Koha-bugs] [Bug 11607] items.content does not contain any formatting when HTML message is selected. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11607 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 21:47:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 20:47:08 +0000 Subject: [Koha-bugs] [Bug 11607] items.content does not contain any formatting when HTML message is selected. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11607 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34677|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 34688 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34688&action=edit Bug 11607: Don't display all items in a single line If the *DGST notices are sent in HTML, the items are displayed in a single line. To reproduce: 1/ Define a *DGST notice using the <> pattern. 2/ Checkout at least 2 items to a patron and set the due date as today. 3/ Launch the advance_notices.pl and process_message_queue.pl cronjobs. 4/ Verify the email you will receive separates the items with a line break. Verify you don't find a regression for non-html letters. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 22:18:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 21:18:03 +0000 Subject: [Koha-bugs] [Bug 13493] New: More enduser-friendly Koha version on About Koha page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13493 Bug ID: 13493 Summary: More enduser-friendly Koha version on About Koha page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: About Assignee: nengard at gmail.com Reporter: bibliwho at gmail.com QA Contact: testopia at bugs.koha-community.org As of Dec 26, 2014, the About Koha page for the ByWater Solutions demo returns 3.17.00.008 for the Koha version. I assume this is 3.18.2, but I'm not sure. I would suggest either a parenthetical reference to the more commonly referenced release number, or an additional line with the same information. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 22:20:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 21:20:56 +0000 Subject: [Koha-bugs] [Bug 13493] More enduser-friendly Koha version on About Koha page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13493 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi, actually 3.17.00.008 is a development version and not a 3.18.2. The about page will show 3.18.02.... once the demo has been updated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 22:27:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 21:27:37 +0000 Subject: [Koha-bugs] [Bug 8909] MARC21 240$a (Uniform title) is not a URL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8909 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 22:27:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 21:27:41 +0000 Subject: [Koha-bugs] [Bug 8909] MARC21 240$a (Uniform title) is not a URL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8909 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34025|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 34689 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34689&action=edit [SIGNED OFF]Bug 8909: MARC21 240$a (Uniform title) is not a URL Patch removes the 'isUrl' attribute from all 240$a fields in the various frameworks. The change removes the broken link from the staff detail MARC tab view. Changes are a little easier to spot with: git diff --color-words HEAD^ To test: - Load some or all of the frameworks - Verify that 240$a is no longer marked as being an URL Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 22:55:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 21:55:45 +0000 Subject: [Koha-bugs] [Bug 12823] Add some hints for Host, Database and SRU search fields mappings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33981|0 |1 is obsolete| | --- Comment #14 from Nick Clemens --- Created attachment 34690 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34690&action=edit [SIGNED OFF] Bug 12823: Add some hints for Host and Database When adding or editing a SRU server, this patch adds a hint, positioned under the Hostname field. It also moves similar information for SRU options and XSLT into hints. Test plan: Add/Edit SRU server. Look at Hostname, SRU options and XSLT. Add/Edit Z39.50 server. No hints for Hostname and SRU options. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 22:55:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 21:55:43 +0000 Subject: [Koha-bugs] [Bug 12823] Add some hints for Host, Database and SRU search fields mappings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 22:55:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 21:55:54 +0000 Subject: [Koha-bugs] [Bug 12823] Add some hints for Host, Database and SRU search fields mappings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33982|0 |1 is obsolete| | --- Comment #15 from Nick Clemens --- Created attachment 34691 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34691&action=edit [SIGNED OFF] Bug 12823: Alert about defining the SRU search field mappings This is a follow-up for report 6536 (SRU search targets). It will alert a user that saves a SRU server without field mappings. Test plan: Add a Z39.50 server. No confirm message. Add a SRU server without field mappings. Cancel the confirm. Add one field mapping. No confirm message. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 23:01:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 22:01:34 +0000 Subject: [Koha-bugs] [Bug 13167] Stage MARC for Import hangs for biblio containing valid 979* ISBN-13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |nick at quecheelibrary.org --- Comment #10 from Nick Clemens --- Marking as signed off, it looks like that was Colin's intention -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 23:14:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 22:14:20 +0000 Subject: [Koha-bugs] [Bug 12428] "OPAC info" is not displayed in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 23:14:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 22:14:22 +0000 Subject: [Koha-bugs] [Bug 12428] "OPAC info" is not displayed in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34094|0 |1 is obsolete| | --- Comment #14 from Nick Clemens --- Created attachment 34692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34692&action=edit [SIGNED OFF]Bug 12428 [3.16.x] "OPAC info" is not displayed in the OPAC This patch changes the footer include, adding an alias for the jQueryUI tooltip function to prevent conflict with Bootstrap's function of the same name. To test, you must have at least two libraries configured with "OPAC info" for display in the OPAC. Modify the holdings of a title so that there is at least one item which has different holding and home branches matching your library configured above. View the detail page for that record. Hovering your cursor over the library name in the "Location" column should display the branch information you configured for that library in a tooltip. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 23:27:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 22:27:07 +0000 Subject: [Koha-bugs] [Bug 12895] Dropbox mode doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12895 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 23:27:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 22:27:09 +0000 Subject: [Koha-bugs] [Bug 12895] Dropbox mode doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12895 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34137|0 |1 is obsolete| | --- Comment #9 from Nick Clemens --- Created attachment 34693 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34693&action=edit [SIGNED OFF]Bug 12895 repair dropbox mode One day late patrons were restricted even with dropbox mode activated Signed-off-by: Nick Clemens -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 23:43:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 22:43:21 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #52 from Nick Clemens --- Applying: Bug 11431 [4] - Add additional sound options fatal: sha1 information is lacking or useless (Koha/Object.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 11431 [4] - Add additional sound options When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-11431-4---Add-additional-sound-options-7v_z2F.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 23:45:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 22:45:25 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #53 from Nick Clemens --- forgot the depends -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 26 23:57:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 22:57:05 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #54 from Nick Clemens --- Still can't test, after applying 13019 and 11431 OPAC functions but I cannot access any pages in staff client, I only get the error below: Software error: Template process failed: undef error - hash- or arrayref expected (not a simple scalar, use allow_nonref to allow this) at /home/nick/kohaclone/Koha/Template/Plugin/Koha.pm line 52. For help, please send mail to the webmaster ([no address given]), giving this error message and the time and date of the error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 00:54:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Dec 2014 23:54:02 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #44 from Tom?s Cohen Arazi --- Created attachment 34694 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34694&action=edit Bug 13264: (QA followup) prevent double-encoding on the tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 03:34:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 02:34:34 +0000 Subject: [Koha-bugs] [Bug 13493] More enduser-friendly Koha version on About Koha page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13493 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |chris at bigballofwax.co.nz Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 04:25:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 03:25:15 +0000 Subject: [Koha-bugs] [Bug 13425] There is an xss vulnerability in 3.16, 3.18 and master in the opac and intranet facets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13425 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Group|Koha security | Component|Koha |Searching Version|unspecified |3.18 Product|Koha security |Koha QA Contact| |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 11:08:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 10:08:04 +0000 Subject: [Koha-bugs] [Bug 12823] Add some hints for Host, Database and SRU search fields mappings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 11:08:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 10:08:07 +0000 Subject: [Koha-bugs] [Bug 12823] Add some hints for Host, Database and SRU search fields mappings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34690|0 |1 is obsolete| | Attachment #34691|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 34695 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34695&action=edit [PASSED QA] Bug 12823: Add some hints for Host and Database When adding or editing a SRU server, this patch adds a hint, positioned under the Hostname field. It also moves similar information for SRU options and XSLT into hints. Test plan: Add/Edit SRU server. Look at Hostname, SRU options and XSLT. Add/Edit Z39.50 server. No hints for Hostname and SRU options. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 11:09:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 10:09:09 +0000 Subject: [Koha-bugs] [Bug 12823] Add some hints for Host, Database and SRU search fields mappings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 --- Comment #17 from Katrin Fischer --- Created attachment 34696 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34696&action=edit [PASSED QA] Bug 12823: Alert about defining the SRU search field mappings This is a follow-up for report 6536 (SRU search targets). It will alert a user that saves a SRU server without field mappings. Test plan: Add a Z39.50 server. No confirm message. Add a SRU server without field mappings. Cancel the confirm. Add one field mapping. No confirm message. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 11:11:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 10:11:43 +0000 Subject: [Koha-bugs] [Bug 9848] SIP tests : fix in 10renew_all.t (additionnal checkin) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Jonathan, can you add some hints on how to run the tests? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 11:15:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 10:15:13 +0000 Subject: [Koha-bugs] [Bug 13285] updatedatabase throws an error if opacthemes is not set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13285 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Bit worried, if opacthemes is not defined, should we point this out as a possible problem? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 11:16:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 10:16:37 +0000 Subject: [Koha-bugs] [Bug 13285] updatedatabase throws an error if opacthemes is not set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13285 --- Comment #4 from Katrin Fischer --- I misread - the value will be set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 11:18:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 10:18:14 +0000 Subject: [Koha-bugs] [Bug 13285] updatedatabase throws an error if opacthemes is not set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13285 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 11:18:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 10:18:16 +0000 Subject: [Koha-bugs] [Bug 13285] updatedatabase throws an error if opacthemes is not set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13285 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34622|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 34697 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34697&action=edit [PASSED QA] Bug 13285 Do the right thing if opacthemes is not set If opacthemes is not defined updatedatabase reports the subsequent warnings as an error. Take account of the case where it is not set and default that to bootstrap. This is probably a rare occurence, but should be handled Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 11:21:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 10:21:36 +0000 Subject: [Koha-bugs] [Bug 13453] Koha.t daily quote tests assume sample data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13453 --- Comment #3 from Katrin Fischer --- Created attachment 34698 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34698&action=edit [PASSED QA] Bug 13453: Koha.t daily quote tests assume sample data By adding quotes 3 and 25 from the sample data, this test can pass without having the sample quote data loaded. TEST PLAN --------- 1) Ensure there is no quote id=3 or that it is NOT Abraham Lincoln. 2) prove t/db_dependent/Koha.t -- this should fail the daily quote test. 3) apply patch 4) prove t/db_dependent/Koha.t -- this should *NOT* fail the daily quote test. 5) run koha qa test tools Followed test plan 1)-4). Without patch, daily quote test failed. With patch, test passed OK. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Works as described, leaves actual data unchanged. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 11:22:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 10:22:00 +0000 Subject: [Koha-bugs] [Bug 13453] Koha.t daily quote tests assume sample data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13453 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer at bsz-bw.de Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 11:22:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 10:22:01 +0000 Subject: [Koha-bugs] [Bug 13453] Koha.t daily quote tests assume sample data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13453 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34606|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 11:38:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 10:38:13 +0000 Subject: [Koha-bugs] [Bug 13167] Stage MARC for Import hangs for biblio containing valid 979* ISBN-13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 11:38:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 10:38:15 +0000 Subject: [Koha-bugs] [Bug 13167] Stage MARC for Import hangs for biblio containing valid 979* ISBN-13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34414|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 34699 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34699&action=edit [PASSED QA] Bug 13167 Stage MARC for Import hangs for biblio containing invalid ISBN-13 If the ISBN of a UNIMARC record begins with 979 then the 'Stage MARC for import' hangs. If I use the same UNIMARC record and change 979 to 978 in the ISBN, 'Stage MARC for import' works perfectly. The patch deals with the fact that converting an ISBN-13 to ISBN-10 with Business::ISBN as_isbn10() method fails if the ISBN doesn't begin with 978. TEST PLAN: (1) Download, and decompress the ZIP file attached to BZ. (2) On a UNIMARC Koha instance, go in Tools > Stage MARC for import. (3) Choose the MARC file containing the record with an ISBN begining with 979. Click on Upload file, then Stage to import. (4) The Job progress bar stay at 0%. (5) Apply the patch. Repeat steps 2-3. The upload works. Signed-off-by: Colin Campbell Signed-off-by: Katrin Fischer Tested in a UNIMARC installation, confirmed that the patch fixes the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 12:20:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 11:20:40 +0000 Subject: [Koha-bugs] [Bug 11607] items.content does not contain any formatting when HTML message is selected. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11607 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 12:20:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 11:20:43 +0000 Subject: [Koha-bugs] [Bug 11607] items.content does not contain any formatting when HTML message is selected. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11607 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34688|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 34700 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34700&action=edit [PASSED QA] Bug 11607: Don't display all items in a single line If the *DGST notices are sent in HTML, the items are displayed in a single line. To reproduce: 1/ Define a *DGST notice using the <> pattern. 2/ Checkout at least 2 items to a patron and set the due date as today. 3/ Launch the advance_notices.pl and process_message_queue.pl cronjobs. 4/ Verify the email you will receive separates the items with a line break. Verify you don't find a regression for non-html letters. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Note: the display in the notices tab is misleading here, needs to be verified checking the sent emails or database entries in message_queue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 12:24:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 11:24:02 +0000 Subject: [Koha-bugs] [Bug 13270] On receiving, "vendor note" label should not be displayed if nothing to display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13270 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 12:24:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 11:24:04 +0000 Subject: [Koha-bugs] [Bug 13270] On receiving, "vendor note" label should not be displayed if nothing to display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13270 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34687|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 34701 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34701&action=edit [PASSED QA] Bug 13270: Don't display "vendor note" label if nothing to display Bug 12111 removes the vendor note edition on receiving. The label should not be displayed when it's empty. Test plan: 1/ Receive an order without a vendor note and verify that the label is not displayed. 2/ Receive an order with a vendor note and verify that the note is displayed. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Works as described, small template change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 12:40:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 11:40:27 +0000 Subject: [Koha-bugs] [Bug 13319] On inserting an order, the parent_ordernumber attribute is not set to the object In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13319 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 12:40:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 11:40:30 +0000 Subject: [Koha-bugs] [Bug 13319] On inserting an order, the parent_ordernumber attribute is not set to the object In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13319 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34686|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 34702 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34702&action=edit [PASSED QA] Bug 13319: Fix Koha::Acq::Order should set parent_ordernumber The tests highligh the problem: if the parent_ordernumber attribute is not set on inserting an order, the object returned by the method does not contain the value (undef). Test plan: Verify the tests are consistent and prove t/db_dependent/Acquisition/CancelReceipt.t should return green. You can also verify that receive partially an order and cancel the receipt work as expected. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 12:41:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 11:41:49 +0000 Subject: [Koha-bugs] [Bug 13319] On inserting an order, the parent_ordernumber attribute is not set to the object In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13319 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Tested partial receives and 'undoing' the receipt. Tests didn't run on my normal database with acq data, but passed on a database without. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 12:54:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 11:54:07 +0000 Subject: [Koha-bugs] [Bug 13487] DataTables pagination needs some fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13459 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 12:54:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 11:54:07 +0000 Subject: [Koha-bugs] [Bug 13459] Datatables paging slightly broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13459 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13487 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 12:55:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 11:55:06 +0000 Subject: [Koha-bugs] [Bug 13487] DataTables pagination needs some fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 --- Comment #9 from Katrin Fischer --- Created attachment 34703 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34703&action=edit [PASSED QA] Bug 13487: DT pagination contains '...' for the full_numbers form Since the DT upgrade (bug 12986), the full_numbers pagination adds a span (containing '...'). It is not managed by the css file and is put at the end of the page numbers ( "1 2 3 4 5 20 NEXT LAST ...", we expect "1 2 3 4 5 ... 20 NEXT LAST"). Test plan: 1/ Go on the member search and launch a search which will return more than 7 pages 2/ Without this patch, the '...' span is put at the end of the pagination bar. 3/ With the patch it should be better placed. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 12:55:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 11:55:08 +0000 Subject: [Koha-bugs] [Bug 13487] DataTables pagination needs some fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 --- Comment #10 from Katrin Fischer --- Created attachment 34704 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34704&action=edit [PASSED QA] Bug 13487: Fix pagination for basketgroup Test plan: Go on the acqui/basketgroup.pl page and verify that the pagination button (First, Prev, Next, Last) is now correctly styled. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 12:55:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 11:55:11 +0000 Subject: [Koha-bugs] [Bug 13487] DataTables pagination needs some fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 --- Comment #11 from Katrin Fischer --- Created attachment 34705 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34705&action=edit [PASSED QA] Bug 13487: Fix pagination for the item search Test plan: Go on the catalogue/itemsearch.pl page and verify that the pagination button (First, Prev, PAGES, Next, Last) is now correctly styled. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 12:55:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 11:55:36 +0000 Subject: [Koha-bugs] [Bug 13487] DataTables pagination needs some fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 12:55:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 11:55:38 +0000 Subject: [Koha-bugs] [Bug 13487] DataTables pagination needs some fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34683|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 12:55:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 11:55:39 +0000 Subject: [Koha-bugs] [Bug 13487] DataTables pagination needs some fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34684|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 12:55:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 11:55:41 +0000 Subject: [Koha-bugs] [Bug 13487] DataTables pagination needs some fixes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34685|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 13:00:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 12:00:04 +0000 Subject: [Koha-bugs] [Bug 13459] Datatables paging slightly broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13459 --- Comment #1 from Katrin Fischer --- Created attachment 34706 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34706&action=edit Bug 13459: Fix datatables paging for admin > itemtypes To test: - Go to administration > itemtypes - Verify the display of the paging options is broken - Apply patch - Verify the display is now correct and works nicely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 13:00:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 12:00:27 +0000 Subject: [Koha-bugs] [Bug 13459] Datatables paging slightly broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13459 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |jonathan.druart at biblibre.co | |m Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 13:00:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 12:00:46 +0000 Subject: [Koha-bugs] [Bug 13459] Datatables paging slightly broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13459 --- Comment #2 from Katrin Fischer --- Copied the fix from bug 13487. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 13:07:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 12:07:58 +0000 Subject: [Koha-bugs] [Bug 13458] Add new patron shows default / hardcoded patron categories after search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 13:08:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 12:08:01 +0000 Subject: [Koha-bugs] [Bug 13458] Add new patron shows default / hardcoded patron categories after search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34682|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 34707 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34707&action=edit [PASSED QA] Bug 13458: Display the correct patron categories Bug 9811 removes useful code. Actually the AddPatronLists pref is not sent to the template from members/member.pl. To fix this issue, we can use the existing not clean way, or compare the syspref value directly in the template. This second solution is implemented in this patch. Test plan: 1/ Set the AddPatronLists pref to 'specific' 2/ On the patron home page (members/members-home/pl), the patron search result page (members/member.pl after launching a search) and on the checkouts page/patron search result (circ/circulation.pl after searching a patron using the check out), verify that the patron category list is the specific ones. 3/ Test there are no regression with the AddPatronLists pref set to 'general'. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Works as described and fixes the problem. Note: I am not sure if AddPatronLists makes sense - if you set it to general patron types, it still preselects the wrong category type (tried organization, a child patron category was selected). Also the name is confusiong nowadays with the Patron list feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 13:30:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 12:30:32 +0000 Subject: [Koha-bugs] [Bug 13343] Items are not embedded when sending a basket/shelf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13343 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 13:30:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 12:30:35 +0000 Subject: [Koha-bugs] [Bug 13343] Items are not embedded when sending a basket/shelf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13343 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34623|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 34708 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34708&action=edit [PASSED QA] Bug 13343: Embed items when send a basket/shelf When a basket/shelf is downloaded, items are embedded, but not when sending it by email. We would expect to get the same file. Test plan: On Opac and intranet: 1/ Add records with items to your basket and send it by email. Verify the file contains items. 2/ Add records with items to a list and send it by email. Verify the file contains items. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 14:15:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 13:15:15 +0000 Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 --- Comment #28 from Katrin Fischer --- Created attachment 34709 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34709&action=edit [PASSED QA] Bug - 5511: Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. To Test: 1) Enable the system preference SessionRestrictionByIP 2) Change your system IP. It will not checkout your system IP or signout. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 14:15:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 13:15:19 +0000 Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 --- Comment #29 from Katrin Fischer --- Created attachment 34710 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34710&action=edit [PASSED QA] Bug -5511- Added new system preference: SessionRestrictionByIP Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 14:15:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 13:15:24 +0000 Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 --- Comment #30 from Katrin Fischer --- Created attachment 34711 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34711&action=edit [PASSED QA] Bug - 5511 [Followup]: Switched defults Agree with Chris that the defualt should maintain the higher security and not reduce it. Signed-off-by: Martin Renvoize Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 14:15:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 13:15:28 +0000 Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 --- Comment #31 from Katrin Fischer --- Created attachment 34712 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34712&action=edit [PASSED QA] Bug - 5511 [Followup]: Missed Instance There was an instance of the pragma missed which meant the the original patch set didn't actually solve the problem in a large number of cases This patch adds in the relevant statement. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 14:15:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 13:15:32 +0000 Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 --- Comment #32 from Katrin Fischer --- Created attachment 34713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34713&action=edit Bug 5511: QA follow up - several fixes - Move database update entry to correct spot - Fix version number in database update - Fix capitalization in sys pref description - Fix sequence in sysprefs.sql -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 14:15:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 13:15:56 +0000 Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 14:15:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 13:15:58 +0000 Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34216|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 14:16:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 13:16:00 +0000 Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34616|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 14:16:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 13:16:03 +0000 Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34218|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 14:16:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 13:16:05 +0000 Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34252|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 14:16:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 13:16:52 +0000 Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 --- Comment #33 from Katrin Fischer --- Maybe we could phrase the system preference description a bit stronger. I added a follow up with some fixes. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 14:24:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 13:24:39 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 --- Comment #6 from Katrin Fischer --- Comment on attachment 34612 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34612 Bug 13373 - Update Polish web installer sample data files. Review of attachment 34612: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13373&attachment=34612) ----------------------------------------------------------------- ::: installer/data/mysql/pl-PL/mandatory/system_preferences.sql @@ -16,5 @@ > --- with Koha; if not, write to the Free Software Foundation, Inc., > --- 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > - > -UPDATE systempreferences SET value = 'father|mother' where variable = 'borrowerRelationship'; > -UPDATE systempreferences SET value = 'Mr|Mrs|Miss|Ms' where variable = 'BorrowersTitles'; Hi Rafal, thx for updating the Polish web installer! The system_preferences.sql can be used to set some language specific defaults - you could translate father|mother and the titles using those files in the future and maybe also set some other prefs, like DateFormat. Just a hint for the future :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 14:24:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 13:24:48 +0000 Subject: [Koha-bugs] [Bug 13493] More enduser-friendly Koha version on About Koha page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13493 --- Comment #2 from Cab Vinton --- D'oh. I remember being unclear in the past about versioning. Glad that it's just me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 14:31:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 13:31:54 +0000 Subject: [Koha-bugs] [Bug 13373] Update Polish web installer sample data files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- Hi Rafal, running the Polish (pl-PL) web installer with all sample data selected I see some SQL errors: marc21_simple_bib_frameworks.sql ERROR 1062 (23000) at line 4090: Duplicate entry 'CF-952-i' for key 'PRIMARY' parameters.sql patron_categories.sql sample_budgets.sql ERROR 1146 (42S02) at line 1: Table 'koha.aqbudget' doesn't exist sample_holidays.sql sample_itemtypes.sql sample_labels.sql ERROR 1146 (42S02) at line 2: Table 'koha.labels_templates' doesn't exist sample_notices.sql ERROR 1452 (23000) at line 1: Cannot add or update a child row: a foreign key constraint fails (`koha`.`letter`, CONSTRAINT `message_transport_type_fk` FOREIGN KEY (`message_transport_type`) REFERENCES `message_transport_types` (`message_transport_type`) ON DELETE CASCADE ON UPDATE CASCA) sample_notices_message_attributes.sql sample_notices_message_transports.sql ERROR 1452 (23000) at line 1: Cannot add or update a child row: a foreign key constraint fails (`koha`.`message_transports`, CONSTRAINT `message_transports_ibfk_3` FOREIGN KEY (`letter_module`, `letter_code`, `branchcode`) REFERENCES `letter` (`module`, `code`, `branchcode`) ON DELETE CA) sample_numberpatterns.sql stopwords.sql system_preferences.sql userflags.sql userpermissions.sql ERROR 1062 (23000) at line 1: Duplicate entry '16-execute_reports' for key 'PRIMARY' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 14:34:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 13:34:56 +0000 Subject: [Koha-bugs] [Bug 13341] Hard-coded "Preview" text in OPAC openlibrary.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 --- Comment #3 from Katrin Fischer --- Created attachment 34714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34714&action=edit [PASSED QA] [PASSED QA] Bug 13341 - Hard-coded "Preview" text in OPAC openlibrary.js The OpenLibrary JavaScript includes an untranslated string, "Preview." This patch move the string to the template so that it can be translated. To test, apply the patch and test that the translator picks up the string: 1. From misc/translator run 'perl translate update [lang]' (e.g. de-DE) 2. Edit misc/translator/po/[lang]-opac-bootstrap.po and add a translation for the updated "Preview" string 3. Remove the "#, fuzzy" marker from that entry 4. From misc/translator run 'perl translate install [lang]' 5. Enable the [lang] translation for the OPAC in system preferences 6. Enable the OpenLibraryCovers system preference. 7. In the OPAC switch to the [lang] translation. 7. View the detail page for a title for which there is an OpenLibrary cover image. Below it you should see a preview link with the translated string you added in step 2. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 14:35:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 13:35:25 +0000 Subject: [Koha-bugs] [Bug 13341] Hard-coded "Preview" text in OPAC openlibrary.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 14:35:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 13:35:26 +0000 Subject: [Koha-bugs] [Bug 13341] Hard-coded "Preview" text in OPAC openlibrary.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34607|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 14:44:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 13:44:16 +0000 Subject: [Koha-bugs] [Bug 13447] runreport.pl html email fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13447 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 14:44:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 13:44:19 +0000 Subject: [Koha-bugs] [Bug 13447] runreport.pl html email fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13447 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34611|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 34715 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34715&action=edit [PASSED QA] BUG 13447: Fixed HTML Email Reports A tiny typo made in runreport.pl when updating it for bug 9530 lead to no body being attached to html emails. Signed-off-by: Chris Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 15:00:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 14:00:42 +0000 Subject: [Koha-bugs] [Bug 13494] New: t/db_dependent/Circulation/Returns.t fails Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13494 Bug ID: 13494 Summary: t/db_dependent/Circulation/Returns.t fails Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: katrin.fischer at bsz-bw.de QA Contact: gmcharlt at gmail.com CC: kyle at bywatersolutions.com This test was added quite recently and is failing for me now: $ perl t/db_dependent/Circulation/Returns.t 1..2 Subroutine C4::Context::userenv redefined at t/db_dependent/Circulation/Returns.t line 12. ok 1 - InProcessingToShelvingCart functions as intended not ok 2 - InProcessingToShelvingCart functions as intended # Failed test 'InProcessingToShelvingCart functions as intended' # at t/db_dependent/Circulation/Returns.t line 45. # got: 'CART' # expected: 'TEST' # Looks like you failed 1 test of 2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 15:15:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 14:15:03 +0000 Subject: [Koha-bugs] [Bug 12895] Dropbox mode doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12895 --- Comment #10 from Katrin Fischer --- I understand this is a bad bug for libraries using fine days, so I am going to pass QA. But I also feel we need more unit tests for AddReturns - it would be great to see a regression test for this added on a separate bug report. I tried t/db_dependent/Circulation/Returns.t, but it currently fails on master for me. t/db_dependent/Circulation_issue.t (see bug 13494) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 15:21:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 14:21:31 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #55 from Nick Clemens --- Was an issue with updatedatabase, cleared and tested on two different machines and worked in both Chrome and firefox with ogg, wav and mp3. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 15:22:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 14:22:05 +0000 Subject: [Koha-bugs] [Bug 12895] Dropbox mode doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12895 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 15:22:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 14:22:07 +0000 Subject: [Koha-bugs] [Bug 12895] Dropbox mode doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12895 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34693|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 34716 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34716&action=edit [PASSED QA] Bug 12895 repair dropbox mode One day late patrons were restricted even with dropbox mode activated 1) Check in the calendar (Tools/Calendar), that the previous days you are about to use as date due are really entered as opening day (never know). 2) Add a suspension in the suspension days parameter of the circulation rules (Administration/Circulation and fine rules) to the MOST specific category of borrower and MOST specific type of document among the existing rules of the LOGGED IN Site(cf explications in the circ-rules page). 3) Choose a borrower using the search by category and an item through the advanced search using the limit by type. 4) Checkout the item selecting the previous opening date in the Specify-due-date box. 5) Click on Circulation in the upper menu, then on Checkin and check the Book drop mode. The Book drop date showed should be the previous opening date. 6) Check in the item : you can see that the patron is restricted 7) apply the patch 8) Redo 1 to 5 : Now, you can see that the patron is not restricted. 9) If you redo the test with two day late, you will see that the patron is not restricted : that's ok because his restriction of one day is already finished. 10) If you redo the test with more than two day late, you see that the patron restriction is, as expected, one day shorter than it were if the item had been returned without dropbox mode. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 15:22:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 14:22:29 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 15:22:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 14:22:32 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34650|0 |1 is obsolete| | --- Comment #56 from Nick Clemens --- Created attachment 34717 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34717&action=edit [SIGNED OFF]Bug 11431 [1] - Update database Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 15:22:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 14:22:41 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34651|0 |1 is obsolete| | --- Comment #57 from Nick Clemens --- Created attachment 34718 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34718&action=edit [SIGNED OFF]Bug 11431 [2] - Add audio alerts to installer http://bugs.koha-community.org/show_bug.cgi?id=11431 Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 15:22:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 14:22:51 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34652|0 |1 is obsolete| | --- Comment #58 from Nick Clemens --- Created attachment 34719 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34719&action=edit [SIGNED OFF]Bug 11431 [3] - Update schema Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 15:23:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 14:23:02 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34653|0 |1 is obsolete| | --- Comment #59 from Nick Clemens --- Created attachment 34720 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34720&action=edit [SIGNED OFF]Bug 11431 [4] - Add additional sound options This patch set replaces and extends Koha's current sound options. This is implemented be removing the existing sound system, and re-engineering using a table of selector/sound combinations such that the highest precedence selector that is found in the DOM will trigger and audio alert. The existing audio behaviors are implemented as a set of default audio alerts. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Enable the AudioAlerts system preference 4) Test existing sounds 5) Enter the new alerts editor in the admin section 6) Add a new audo alert with the following selector: "body:contains('Check in message')", choose any sound alert you wish, make sure it's not one of the 3 sounds already used! Make this selector precedence 1 4) Browse to the checkins page, you should hear the default sound 5) Attempt to return an invalid barcode, you should hear your custom sound! Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 15:23:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 14:23:13 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser in item edition page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 16:05:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 15:05:46 +0000 Subject: [Koha-bugs] [Bug 8096] Card number twice on patron search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8096 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 16:05:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 15:05:48 +0000 Subject: [Koha-bugs] [Bug 8096] Card number twice on patron search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8096 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34608|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 34721 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34721&action=edit [PASSED QA] Bug 8096 - card number twice on patron search This patch removes double patron card numbers from patron search results. To test: Search patrons See card number 12345 in first column and in second column like Testman, John (12345) Apply patch Patron card number no longer dispays in second colum Further testing: Search for other places in intranet where patron-title.inc is used (git grep 'patron-title.inc') The card number still should display at the other places. Signed-off-by: Chris http://bugs.koha-community.org/show_bug.cgi?id=8096 Signed-off-by: Chris Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 16:09:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 15:09:23 +0000 Subject: [Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |martin.renvoize at ptfs-europe | |.com Component|Architecture, internals, |Browser compatibility |and plumbing | Assignee|gmcharlt at gmail.com |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 16:21:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 15:21:09 +0000 Subject: [Koha-bugs] [Bug 12428] "OPAC info" is not displayed in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 16:21:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 15:21:12 +0000 Subject: [Koha-bugs] [Bug 12428] "OPAC info" is not displayed in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34692|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 34722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34722&action=edit [PASSED QA] Bug 12428 [3.16.x] "OPAC info" is not displayed in the OPAC This patch changes the footer include, adding an alias for the jQueryUI tooltip function to prevent conflict with Bootstrap's function of the same name. To test, you must have at least two libraries configured with "OPAC info" for display in the OPAC. Modify the holdings of a title so that there is at least one item which has different holding and home branches matching your library configured above. View the detail page for that record. Hovering your cursor over the library name in the "Location" column should display the branch information you configured for that library in a tooltip. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 16:24:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 15:24:31 +0000 Subject: [Koha-bugs] [Bug 13407] Remove methods which are included in the 0.36 release of PDF::Reuse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 16:35:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 15:35:20 +0000 Subject: [Koha-bugs] [Bug 13407] Remove methods which are included in the 0.36 release of PDF::Reuse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 16:35:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 15:35:23 +0000 Subject: [Koha-bugs] [Bug 13407] Remove methods which are included in the 0.36 release of PDF::Reuse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34609|0 |1 is obsolete| | Attachment #34610|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 34723 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34723&action=edit [PASSED QA] Bug 13406: Removing depricated code included in PDF::Reuse 1. Upgrade PDF::Reuse to 0.35_04. [1] 2. Run Koha's non-DB dependent test suite. You should notice some non-fatal warnings about the redefinition of one or two subs in PDF::Reuse. This should not affect the functionality of the tools for the end user. 3. Verify the functionality of the related tools. 4. Apply the attached patch. 5. Re-run Koha's non-DB dependent test suite. You should note no warnings related to PDF::Reuse. 6. Re-verify the functionality of the related tools. [1] http://search.cpan.org/CPAN/authors/id/C/CN/CNIGHS/PDF-Reuse-0.35_04.tar.gz Signed-off-by: Mark Tompsett Signed-off-by: Chris http://bugs.koha-community.org/show_bug.cgi?id=13407 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 16:37:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 15:37:19 +0000 Subject: [Koha-bugs] [Bug 13407] Remove methods which are included in the 0.36 release of PDF::Reuse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407 --- Comment #13 from Katrin Fischer --- Created attachment 34724 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34724&action=edit [PASSED QA] Bug 13407 Bumping required version of PDF::Reuse Signed-off-by: Chris Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 16:59:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 15:59:25 +0000 Subject: [Koha-bugs] [Bug 13124] Record titles with parentheses causing label weirdness In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 16:59:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 15:59:28 +0000 Subject: [Koha-bugs] [Bug 13124] Record titles with parentheses causing label weirdness In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34337|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 34725 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34725&action=edit [PASSED QA] Bug 13124 - Record titles with parentheses causing label weirdness Test Plan ( using sample data included with Koha ) 1) Catalog a record and item with the title "Oh no! or, (How my science project destroyed the world) /" 2) Edit the DEFAULT template a) Set layout type to Biblio b) Set data fields to "title, author, isbn, issn, itemtype, barcode, itemcallnumber" c) Set font size to 10 3) Create a batch with just the one item you created 4) Export the PDF with the Avery template and the DEFAULT layout 5) Note the weirdness 6) Apply this patch 7) Re-export the PDF, note it's no longer weird ; ) Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 17:01:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 16:01:21 +0000 Subject: [Koha-bugs] [Bug 8909] MARC21 240$a (Uniform title) is not a URL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8909 --- Comment #4 from Katrin Fischer --- I can't QA this for obvious reasons :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 17:01:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 16:01:46 +0000 Subject: [Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 --- Comment #6 from Katrin Fischer --- Martin, could you take a look at this please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 17:07:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 16:07:51 +0000 Subject: [Koha-bugs] [Bug 12637] [DEPENDS ON 11944] UTF-8 problems when creating a patron list from the patron search results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 --- Comment #10 from Katrin Fischer --- I think this will have to wait for 11944 to make it in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 17:20:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 16:20:36 +0000 Subject: [Koha-bugs] [Bug 13252] SIP2 server should accept IPv6 connections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13252 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 17:20:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 16:20:38 +0000 Subject: [Koha-bugs] [Bug 13252] SIP2 server should accept IPv6 connections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13252 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33611|0 |1 is obsolete| | Attachment #34001|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 34726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34726&action=edit [PASSED QA] Bug 13252 - SIP2 server should accept IPv6 connections This small patch adds a check on the SIP2 socket connection if it is IPv6 and resolves socket address accordingly. Any newer Debian distro would probably default to IPv6 so it would eventually affect all SIP servers. Tests against running SIP server on an IPv6 box: http://wiki.koha-community.org/wiki/Koha_SIP2_server_setup#Testing_with_Telnet before patch: disconnects immediately. Log output: Bad arg length for Socket::unpack_sockaddr_in, length is 28, should be 16 after patch: operates normally Signed-off-by: Colin Campbell Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 17:21:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 16:21:40 +0000 Subject: [Koha-bugs] [Bug 13252] SIP2 server should accept IPv6 connections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13252 --- Comment #13 from Katrin Fischer --- This time around I could get this to work. With both ipv 6 and 4 the login succeeded. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 18:11:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 17:11:48 +0000 Subject: [Koha-bugs] [Bug 13252] SIP2 server should accept IPv6 connections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13252 --- Comment #14 from Katrin Fischer --- Created attachment 34727 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34727&action=edit [PASSED QA] Bug 13252 Allow for IPv6 formatted addresses in Port definition The SIP config has allowed you to specify an interface ip as part of the listeners/service/port attributei e. g. as port="127.0.0.1:6001/tcp" with IPv6 the equivalent would normally be as port="[::1]:5001/tcp" However in this case incoming connections will get rejected because Configuration constructs a string without the brackets This patch makes tests both formats on incoming connections so that they are accepted as they were previously In future the best course is not to include a port identifier in the port definition then if the server has ipv6 it will bind to all interfaces and accept both IPv4 and IPv6 traffic Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 18:13:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 17:13:10 +0000 Subject: [Koha-bugs] [Bug 13290] Add better feedback for returns to the checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13290 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34130|0 |1 is obsolete| | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 18:36:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 17:36:12 +0000 Subject: [Koha-bugs] [Bug 13290] Add better feedback for returns to the checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13290 --- Comment #14 from Katrin Fischer --- While Owen is right about the convention to use the term "Checked in", we already display "Returned" at the end of the table. I think we should fix this, but separate from this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 18:36:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 17:36:52 +0000 Subject: [Koha-bugs] [Bug 13290] Add better feedback for returns to the checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13290 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 18:36:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 17:36:55 +0000 Subject: [Koha-bugs] [Bug 13290] Add better feedback for returns to the checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13290 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34184|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 34728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34728&action=edit [PASSED QA] Bug 13290 - Add better feedback for returns to the checkouts table The feedback given when returning an item is only to update the "Check in" column. It would be nice if the entire column was highlighted in some way so librarians have an easier time spotting which items were checked in and which ones failed to be checked in. Test Plan: 1) Apply this patch 2) Browse to a patron with checkouts 3) Return an item using the checkouts table 4) Note if the return was successful, the row is highlighted in yellow, if the return was not allowed, the row is highlighted in red. Signed-off-by: Christopher Brannon Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 18:38:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 17:38:40 +0000 Subject: [Koha-bugs] [Bug 13495] New: Use "Checked in" instead of "Returned" in circulation Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13495 Bug ID: 13495 Summary: Use "Checked in" instead of "Returned" in circulation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: katrin.fischer at bsz-bw.de Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org We have agreed to use 'checkin' or 'checked in' instead of 'returned'. The ajax circulation table uses 'Returned' - this should be fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 18:41:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 17:41:43 +0000 Subject: [Koha-bugs] [Bug 13286] Checkouts table due date not updated when an item is renewed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13286 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13495 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 18:41:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 17:41:43 +0000 Subject: [Koha-bugs] [Bug 13495] Use "Checked in" instead of "Returned" in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13495 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13286 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 18:42:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 17:42:57 +0000 Subject: [Koha-bugs] [Bug 13495] Use "Checked in" instead of "Returned" in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13495 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|13286 |13290 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 18:42:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 17:42:57 +0000 Subject: [Koha-bugs] [Bug 13286] Checkouts table due date not updated when an item is renewed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13286 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13495 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 18:42:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 17:42:57 +0000 Subject: [Koha-bugs] [Bug 13290] Add better feedback for returns to the checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13290 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13495 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 18:50:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 17:50:21 +0000 Subject: [Koha-bugs] [Bug 13495] Use "Checked in" instead of "Returned" in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13495 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 18:50:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 17:50:23 +0000 Subject: [Koha-bugs] [Bug 13495] Use "Checked in" instead of "Returned" in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13495 --- Comment #1 from Katrin Fischer --- Created attachment 34729 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34729&action=edit Bug 13495: Use "checked in" instead of "returned" in circulation To test: - check out one or many items on a patron account - return the items from the checkout table - notice that a message "Checked in" is now shown in the first and last column, instead of "Returned" as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 19:12:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 18:12:52 +0000 Subject: [Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |katrin.fischer at bsz-bw.de --- Comment #22 from Katrin Fischer --- I have a few concerns about this feature: I think we have several features here on one bug report, so it's a bit hard to work through. I really like the idea of the arbitrary fields, but I am concerned about using the record level itemtype. This seems to assume that different itemtypes are used for different type of media. I am not sure this is how all libraries use itemtypes in Koha, some differentiate by loan types. But this is just a note, my main concern is about the missing flexibility for existing installations. If you are a long term user of Koha you would probably have to change all your itemtype codes in order to be able to make good use of the new feature. This feels quite problematic to me. I am not sure what's the best way to resolve this, some thoughts I had while reading through it: Instead of using a separate system preference, maybe allowing overwriting existing fields would be an option? Then you could use *ExportAdditionalFields with 942$c for the itemtype feature or even use another arbitrary field the library thinks is best suited. Or a little easier: allow defining the MARC subfield to use for the record type instead of hardcoding it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 19:39:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 18:39:30 +0000 Subject: [Koha-bugs] [Bug 10877] Add "Order Record" processing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #33 from Katrin Fischer --- I feel like I don't understand this feature well - at least not the differences to the existing staged MARC records workflow. Marcel noted some concerns in comment #26 and earlier Jonathan worked some on this - comment #17. Can we try to restart the discussion together? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 19:56:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 18:56:35 +0000 Subject: [Koha-bugs] [Bug 12944] There is no way to search orders by creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 --- Comment #18 from Katrin Fischer --- Comment on attachment 33197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33197 Bug 12944: Refactor the patron autocomplete Review of attachment 33197: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12944&attachment=33197) ----------------------------------------------------------------- Hi Jonathan, overall this looks good :) ::: koha-tmpl/intranet-tmpl/js/autocomplete/patrons.js @@ +32,5 @@ > + }); > +} > + > +function AddPatron( patron_name, value, container, input_name ) { > + div = "
" + patron_name + " ( " + _("Remove") + " )
"; But by moving the Javascript into a separate js file, the "Remove" will no longer be translatable. Could you please fix? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 19:56:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 18:56:46 +0000 Subject: [Koha-bugs] [Bug 12944] There is no way to search orders by creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 20:11:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 19:11:32 +0000 Subject: [Koha-bugs] [Bug 12969] VAT and price calculation should be done in a subroutine In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12969 --- Comment #18 from Katrin Fischer --- Maybe some more comments later could improve readability, but no reason to fail :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 20:13:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 19:13:05 +0000 Subject: [Koha-bugs] [Bug 12896] Move the bookseller-related code into its own module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12896 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33855|0 |1 is obsolete| | Attachment #33856|0 |1 is obsolete| | --- Comment #33 from Katrin Fischer --- Created attachment 34730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34730&action=edit [PASSED QA] Bug 12969: Add a subroutine to calculate VAT and prices This patch adds a new subroutine populate_order_with_prices in the C4::Acquisition module. Its goal is to refactore the VAT and prices calculation into Koha. All scripts will use this subroutine. Test plan: Verify that the prices in t/Prices.t are consistent with the values listed in the file "Prices and VAT calculation - before" submit on bug 12964. Verify that prove t/Prices.t returns green Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 20:14:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 19:14:00 +0000 Subject: [Koha-bugs] [Bug 12969] VAT and price calculation should be done in a subroutine In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12969 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 20:14:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 19:14:04 +0000 Subject: [Koha-bugs] [Bug 12969] VAT and price calculation should be done in a subroutine In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12969 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31920|0 |1 is obsolete| | Attachment #31921|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer --- Created attachment 34731 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34731&action=edit [PASSED QA] Bug 12969: Add a subroutine to calculate VAT and prices This patch adds a new subroutine populate_order_with_prices in the C4::Acquisition module. Its goal is to refactore the VAT and prices calculation into Koha. All scripts will use this subroutine. Test plan: Verify that the prices in t/Prices.t are consistent with the values listed in the file "Prices and VAT calculation - before" submit on bug 12964. Verify that prove t/Prices.t returns green Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer http://bugs.koha-community.org/show_bug.cgi?id=12896 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 20:14:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 19:14:30 +0000 Subject: [Koha-bugs] [Bug 12896] Move the bookseller-related code into its own module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12896 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34730|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 20:14:43 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 19:14:43 +0000 Subject: [Koha-bugs] [Bug 12896] Move the bookseller-related code into its own module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12896 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33855|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 20:14:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 19:14:56 +0000 Subject: [Koha-bugs] [Bug 12896] Move the bookseller-related code into its own module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12896 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33856|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 20:15:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 19:15:52 +0000 Subject: [Koha-bugs] [Bug 12969] VAT and price calculation should be done in a subroutine In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12969 --- Comment #20 from Katrin Fischer --- Created attachment 34732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34732&action=edit [PASSED QA] Bug 12969: Fix typo rrpgsti should be rrpgste Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 20:33:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 19:33:16 +0000 Subject: [Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 --- Comment #8 from Katrin Fischer --- Comment on attachment 31981 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31981 Bug 12975: Use the centralize VAT and prices calculation - basketgroup.pl Review of attachment 31981: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12975&attachment=31981) ----------------------------------------------------------------- ::: acqui/basketgroup.pl @@ -212,5 @@ > } > } > > - my $ba_order = { > - isbn => ($ord->{isbn} ? $ord->{isbn} : undef), Hi Jonathan, bit irritated by this line - was removing it intentional? I see that that PDF should be printing the ISBN, but have a bit of trouble making it work in my installation currently. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 20:33:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 19:33:48 +0000 Subject: [Koha-bugs] [Bug 12743] Allow default values from the ACQ framework to be used when creating a record in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12743 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33196|0 |1 is obsolete| | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 20:34:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 19:34:26 +0000 Subject: [Koha-bugs] [Bug 12743] Allow default values from the ACQ framework to be used when creating a record in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12743 --- Comment #10 from Katrin Fischer --- Hi Gaetan, please remember to obsolete the old patch when you sign of - thx! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 20:44:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 19:44:05 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #65 from Katrin Fischer --- Fixed the first conflict on the tools home page, but then got stuck with a harder conflict: Apply? [(y)es, (n)o, (i)nteractive] i Applying: Bug 11023: Add the ability to specify fields from biblioitems table. Applying: Bug 11023: Add UT for C4::Items::ToggleNewStatus Applying: Bug 11023: FIX - condition on biblioitems table does not work Applying: Bug 11023: Use DBIx-Class to retrieve column names fatal: sha1 information is lacking or useless (C4/Items.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 11023: Use DBIx-Class to retrieve column names The copy of the patch that failed is found in: /home/katrin/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-11023-Use-DBIx-Class-to-retrieve-column-names-J9vKlx.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 20:46:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 19:46:31 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer at bsz-bw.de --- Comment #13 from Katrin Fischer --- Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 13014: Notify budget owner on new suggestion - UT Using index info to reconstruct a base tree... M C4/Suggestions.pm M t/db_dependent/Suggestions.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Suggestions.t CONFLICT (content): Merge conflict in t/db_dependent/Suggestions.t Auto-merging C4/Suggestions.pm Failed to merge in the changes. Patch failed at 0001 Bug 13014: Notify budget owner on new suggestion - UT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 20:56:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 19:56:34 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #16 from Katrin Fischer --- Note for later: Add bug number to datebase update message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 20:57:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 19:57:32 +0000 Subject: [Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer --- Changing to 'failed qa' for now, waiting for Jonathan to take a look at the last comment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 21:04:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 20:04:03 +0000 Subject: [Koha-bugs] [Bug 13477] On order detail not showing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13477 --- Comment #5 from Katrin Fischer --- Displaying acquisition information in the OPAC was only added to 3.18. Die you see the change updating from 3.18 to 3.18.1? Are you referring to the OPACAcquisitionDetails system preference? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 21:09:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 20:09:10 +0000 Subject: [Koha-bugs] [Bug 13477] On order detail not showing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13477 --- Comment #6 from Katrin Fischer --- Created attachment 34733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34733&action=edit OPAC: acq information display with AcqCreateItem != on order I retested on master and the information displays. Note: the quantity must be >1 and AcqCreateItem not set to 'on order'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 27 21:16:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Dec 2014 20:16:05 +0000 Subject: [Koha-bugs] [Bug 13459] Datatables paging slightly broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13459 --- Comment #3 from Katrin Fischer --- Created attachment 34734 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34734&action=edit Bug 13459: Fix datatables paging for patron lists The display of the datatables paging options for the patron list feature is broken. To test: - Go to tools > patron lists - The paging for the 'list of lists' is broken - Select a patron list 'Add more patrons' - Notice the paging on this page is also broken - Apply patch - Verify both pages now display the paging correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 01:45:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 00:45:40 +0000 Subject: [Koha-bugs] [Bug 13459] Datatables paging slightly broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13459 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34706|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 34735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34735&action=edit Bug 13459: Fix datatables paging for admin > itemtypes To test: - Go to administration > itemtypes - Verify the display of the paging options is broken - Apply patch - Verify the display is now correct and works nicely Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 01:45:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 00:45:52 +0000 Subject: [Koha-bugs] [Bug 13459] Datatables paging slightly broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13459 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 01:45:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 00:45:55 +0000 Subject: [Koha-bugs] [Bug 13459] Datatables paging slightly broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13459 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34734|0 |1 is obsolete| | --- Comment #5 from Chris Cormack --- Created attachment 34736 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34736&action=edit Bug 13459: Fix datatables paging for patron lists The display of the datatables paging options for the patron list feature is broken. To test: - Go to tools > patron lists - The paging for the 'list of lists' is broken - Select a patron list 'Add more patrons' - Notice the paging on this page is also broken - Apply patch - Verify both pages now display the paging correctly Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 01:51:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 00:51:05 +0000 Subject: [Koha-bugs] [Bug 9124] 942e tied to undefined CN_EDITION in default MARC21 framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9124 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 01:51:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 00:51:09 +0000 Subject: [Koha-bugs] [Bug 9124] 942e tied to undefined CN_EDITION in default MARC21 framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9124 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34024|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 34737 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34737&action=edit Bug 9124: Remove non-existing field mapping and auth value for 942$e 942$e is mapped to biblioitems.cn_edition, which doesn't exist and to an authorized value CN_EDITION, which doesn't exist either. Patch removes the wrong mapping and non-existing auth value from the frameworks. To test: - git diff --color-words HEAD^ is helpful - Check all mappings are changed and SQL is still valid Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 01:55:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 00:55:20 +0000 Subject: [Koha-bugs] [Bug 13495] Use "Checked in" instead of "Returned" in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13495 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34729|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 34738 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34738&action=edit Bug 13495: Use "checked in" instead of "returned" in circulation To test: - check out one or many items on a patron account - return the items from the checkout table - notice that a message "Checked in" is now shown in the first and last column, instead of "Returned" as before Signed-off-by: Chris Cormack I feel dirty signing this off, but I guess we have to be consistent in our language -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 01:55:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 00:55:18 +0000 Subject: [Koha-bugs] [Bug 13495] Use "Checked in" instead of "Returned" in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13495 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 02:00:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 01:00:44 +0000 Subject: [Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 02:00:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 01:00:47 +0000 Subject: [Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34373|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 34739 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34739&action=edit Bug 13450 - Title and breadcrumb of Patron form can look weird in translations This patch moves the patron category name at the end of title and breadcrumb for better translatability. Note: It does not change anything in functionallity, it only changes display of strings. To test: Apply patch Search a patron and edit it in all possible ways Copy a patron Create a new patron Make sure that title and breadcrumb appear in a meaningful way with pattern similar to the following: Modify Child patron Hansli Meier (Juvenile) Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 05:47:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 04:47:35 +0000 Subject: [Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 05:47:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 04:47:38 +0000 Subject: [Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34286|0 |1 is obsolete| | --- Comment #9 from Chris Cormack --- Created attachment 34740 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34740&action=edit Bug 13268 - biblioitems.size value not correctly displayed (more) Bug partially corrected by Bug 11357. The size column in biblioitems is a bit problematic when used in TT, because instead of the size value from the biblio column it will give you the size of the variable or current loop. It's currently used in the templates like opac-topissues.tt : [% IF results_loo.size %][% results_loo.size %][% END %] This patch corrects by using item() TT method. See http://stackoverflow.com/questions/2311303/how-can-i-handle-hash-keys-containing-illegal-identifier-characters-in-template. Test plan : - Be sure there is a mapping between a MARC field and biblioitems.size - Create a record A with biblioitems.size defined : like "10x12" - Create a record B with no value in biblioitems.size - Check each modified page : => Without this patch : you see a number (loop size) for both records => With this patch : you only see the correct value for A and nothing for B Signed-off-by: Jonathan Druart Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 05:47:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 04:47:51 +0000 Subject: [Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34287|0 |1 is obsolete| | --- Comment #10 from Chris Cormack --- Created attachment 34741 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34741&action=edit Bug 13268: the size should not be emptied in pl script It duplicates what the first patch does. Signed-off-by: Jonathan Druart Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 05:52:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 04:52:48 +0000 Subject: [Koha-bugs] [Bug 9551] OPACMobileUserCSS being overriden by OPACUserCSS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9551 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED CC| |chris at bigballofwax.co.nz Resolution|--- |INVALID --- Comment #16 from Chris Cormack --- I think that since the theme has been deprecated since 3.16.x and been deleted since 3.18.x that there is very little point in working on this. Im going to set to resolved invalid. If people want to patch their old system instead of upgrading, the code will still be here. But there's no point having it in the queue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 05:57:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 04:57:08 +0000 Subject: [Koha-bugs] [Bug 13360] C4::Ris considers that hashes are ordered In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13360 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 05:57:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 04:57:11 +0000 Subject: [Koha-bugs] [Bug 13360] C4::Ris considers that hashes are ordered In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13360 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34012|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 34742 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34742&action=edit Bug 13360: C4::Ris assumes that hash keys are ordered - KW This patch only fixes the KW order. Test plan: 1/ Choose/create a record with several 6XX (for KW), see the code source to know which fields you can use 2/ Export this record in RIS format 3/ Verify that the KW lines are ordered following the marc record fields order. Signed-off-by: Chris Cormack We really should refactor this whole thing into Koha::RIS sometime, it's a horrible module at the moment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 06:15:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 05:15:04 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34483|0 |1 is obsolete| | --- Comment #20 from Chris Cormack --- Created attachment 34743 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34743&action=edit Bug 13417: Allow staff members to manage public lists Currently a public list can only be deleted by its owner. This means lists can exist infinitely. This will introduce a new permission for list. With this permission, a staff member will be allow to delete any public lists. Test plan: 1/ Add the manage_shelves permission to a patron. 2/ Login with this patron 3/ Go on the public list view 4/ You should be able to edit all public lists Followed test plan. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 06:16:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 05:16:02 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 06:16:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 05:16:05 +0000 Subject: [Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34485|0 |1 is obsolete| | --- Comment #21 from Chris Cormack --- Created attachment 34744 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34744&action=edit Bug 13417: Limit the permission to delete It's preferable to limit the permission to delete shelves. Apply both patches before testing, then follow this test plan Currently a public list can only be deleted by its owner. This means lists can exist infinitely. This will introduce a new permission for list. With this permission, a staff member will be allow to delete any public lists. Test plan: 1/ Add the manage_shelves permission to a patron. 2/ Login with this patron 3/ Go on the public list view 4/ You should be able to delete all public lists Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 06:35:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 05:35:23 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_13404=5D__More_=C2=BBSystem_informat?= =?utf-8?q?ion=C2=AB_about_GRS1_vs_DOM_settings?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 --- Comment #5 from Chris Cormack --- Created attachment 34745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34745&action=edit Bug 13404 - More ?System information? about GRS1 vs DOM settings System information indicates missing and entries in koha-conf.xml. This patch - adds warnings about a possible mismatch between these settings and the actual setup - adds info about the actual setup/what values to use for and if they are not set. The assumption is that a path including 'zebra-*-dom.cfg' in the respective section indicates a DOM setup. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 06:35:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 05:35:51 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_13404=5D__More_=C2=BBSystem_informat?= =?utf-8?q?ion=C2=AB_about_GRS1_vs_DOM_settings?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34166|0 |1 is obsolete| | CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 06:36:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 05:36:53 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_13404=5D__More_=C2=BBSystem_informat?= =?utf-8?q?ion=C2=AB_about_GRS1_vs_DOM_settings?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 07:11:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 06:11:30 +0000 Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Severity|enhancement |normal --- Comment #9 from Chris Cormack --- (In reply to Katrin Fischer from comment #8) > I think the question is if this is going to be in 3.18.x or as a new > enhancement in 3.20. And by then... libraries will have used it. I think > currently as a input field it invites for longer unstructured comments. > > What I meant is that I would not transform the existing reasons into an > authorized value for existing installations but leave things as they are and > have the auth_value as a non-enforced option. That would also avoid the > truncation problem. > > Maybe we should ask for opinions on the list? Some good feedback there > recently. I'm happy to classify this as a bugfix and push it for 3.18.3 there shouldn't have been too much usage of it by then. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 07:17:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 06:17:59 +0000 Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34091|0 |1 is obsolete| | --- Comment #10 from Chris Cormack --- Created attachment 34746 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34746&action=edit Bug 13380: Add the AV in the install files (This will completely done when the patch will be QAed) Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 07:17:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 06:17:56 +0000 Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 07:18:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 06:18:17 +0000 Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34140|0 |1 is obsolete| | --- Comment #11 from Chris Cormack --- Created attachment 34747 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34747&action=edit Bug 13380: Fill order cancellation reasons from AV Since bug 7162, it's possible to give a cancellation reason on deleting an order. This would be better to fill an authorised values category with the different possible values. Like that we will avoid to have duplicate or similar reasons. Also, it will be easier to filter or create reports. Test plan: 0/ Don't apply the patch 1/ Cancel some orders and give a cancelletion reason 2/ Apply the patch and execute the updatedb entry 3/ Cancel an order and verify the you have a list with the reason you previously filled + 3 new ones ('No reason', 'Sold out' and 'Restocking'); 4/ Choose one and verify the value is correctly displayed on the basket page 5/ You can also try to add other values from the admin module. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 07:38:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 06:38:17 +0000 Subject: [Koha-bugs] [Bug 13346] The type of the OpacExportOptions pref should be multiple In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13346 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 07:38:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 06:38:20 +0000 Subject: [Koha-bugs] [Bug 13346] The type of the OpacExportOptions pref should be multiple In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13346 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33955|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 34748 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34748&action=edit Bug 13346: OpacExportOptions becomes multiple The list of options is limited, the interface could be more ergonomic. Test plan: - verify that you are still allowed to change (add/remove) options for the OpacExportOptions pref. - At the OPAC, verify the selected options appear correctly (check the 3 pages opac-ISBDdetail.pl, opac-MARCdetail.pl and opac-detail.pl). Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 08:06:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 07:06:04 +0000 Subject: [Koha-bugs] [Bug 12368] Rebuild Zebra improvement: allow to specify a DB table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12368 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28672|0 |1 is obsolete| | --- Comment #5 from Chris Cormack --- Created attachment 34749 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34749&action=edit Bug 12368: Rebuild Zebra improvement: allow to specify a DB table Currently the --where parameter only allow to specify a condition on fields in the biblioitems table. For some needs it would be great to specify a condition on the field in the items table. The use case is the following: you want to reindex biblios with items modified since a specific timestamp. Test plan: 1/ Pick an item randomly in your catalogue 2/ Edit it and save 3/ Note that the items.timestamp has been set to today but not the biblioitems.timestamp 4/ launch rebuild_zebra without the new parameter perl misc/migration_tools/rebuild_zebra.pl -b -v --where "timestamp >= XXX" where XXX is the today date (e.g. "2014-06-05 00:00:00"). Note that the biblio has not been indexed. 5/ launch rebuild_zebra using the new parameter: perl misc/migration_tools/rebuild_zebra.pl -b -v -t items --where "timestamp >= XXX" Note the biblio has been indexed. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 08:06:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 07:06:25 +0000 Subject: [Koha-bugs] [Bug 12368] Rebuild Zebra improvement: allow to specify a DB table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12368 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 08:06:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 07:06:28 +0000 Subject: [Koha-bugs] [Bug 12368] Rebuild Zebra improvement: allow to specify a DB table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12368 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28793|0 |1 is obsolete| | --- Comment #6 from Chris Cormack --- Created attachment 34750 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34750&action=edit Bug 12368: Die if the --table value is not allowed. If the table given in parameter is not in the white list, the script should die rathen than correct to a default value. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 08:14:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 07:14:52 +0000 Subject: [Koha-bugs] [Bug 11927] Add greek support to CHR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34120|0 |1 is obsolete| | --- Comment #16 from Chris Cormack --- Created attachment 34751 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34751&action=edit Bug 11927 - Add gr install option Add greek as lang definition in installer. Developed in collaboration with Giannis Kourmoulis Test plan : - Install using "gr" in "Primary language for Zebra indexing" - check gr is used in etc/zebradb/zebra-*.cfg Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 08:15:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 07:15:08 +0000 Subject: [Koha-bugs] [Bug 11927] Add greek support to CHR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34121|0 |1 is obsolete| | --- Comment #17 from Chris Cormack --- Created attachment 34752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34752&action=edit Bug 11927 - Add greek chr lang_def file Add the sort-string-utf.chr for sorting Greek catalog (it can also contain latin records). Developped in collaboration with Giannis Kourmoulis Test plan : - Install using "gr" in "Primary language for Zebra indexing" - Index a greek catalog - Sort by title and check sorting is correct Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 08:15:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 07:15:20 +0000 Subject: [Koha-bugs] [Bug 11927] Add greek support to CHR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34122|0 |1 is obsolete| | --- Comment #18 from Chris Cormack --- Created attachment 34753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34753&action=edit Bug 11927 - Add greek to word-phrase-utf.chr Add greek support in word-phrase-utf.chr for searching in a Greek catalog (it can also contain latin records). Developped in collaboration with Giannis Kourmoulis Test plan : - Install using CHR zebra indexing - Index a greek catalog - Look for results with mixed uppercase, lowercase and diacritics in title Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 08:15:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 07:15:48 +0000 Subject: [Koha-bugs] [Bug 11927] Add greek support to CHR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34123|0 |1 is obsolete| | --- Comment #19 from Chris Cormack --- Created attachment 34754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34754&action=edit Bug 11927 - Small corrections on word-phrase-utf.chr Small fixes : more space characters : ?? uppercase AE missing in equivalent some trailling spaces Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 08:16:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 07:16:04 +0000 Subject: [Koha-bugs] [Bug 11927] Add greek support to CHR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 08:26:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 07:26:15 +0000 Subject: [Koha-bugs] [Bug 7939] Separate po files for different MARC dialects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7939 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |chris at bigballofwax.co.nz --- Comment #9 from Chris Cormack --- Hi Bernardo, this needs a rework as prog has been removed from the OPAC now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 08:52:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 07:52:20 +0000 Subject: [Koha-bugs] [Bug 9551] OPACMobileUserCSS being overriden by OPACUserCSS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9551 --- Comment #17 from M. Tompsett --- Well, I did change it to be for 3.16 and not master. I was thinking RESOLVED WONTFIX might be better, since it won't be changed in master. However, I'll leave it unchanged. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 08:54:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 07:54:02 +0000 Subject: [Koha-bugs] [Bug 13320] Some prices calculation are done in template side In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13320 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33776|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 34755 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34755&action=edit Bug 13320: Move price calculation from tt to pl In parcel.tt, total are calculated for subtotal. This could be done in the pl script for more consistency. Test plan: Go on a parcel page with several already received orders. Orders must be linked to different funds. If possible ecost and unitprice (price on ordering and on receiving) should changed (different values will be displayed in the table). The values displayed before and after the patch must be the same. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 08:54:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 07:54:14 +0000 Subject: [Koha-bugs] [Bug 13320] Some prices calculation are done in template side In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13320 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 08:54:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 07:54:16 +0000 Subject: [Koha-bugs] [Bug 13320] Some prices calculation are done in template side In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13320 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34033|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 34756 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34756&action=edit Bug 13320: Fix "Tax inc." vs "Tax exc." The parcel page always displayes "Tax exc." even when values don't include taxes. Test plan: On the parcel page, verify that the string "Tax *" is correct. This appears in the already received order table. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 10:11:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 09:11:04 +0000 Subject: [Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 10:11:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 09:11:07 +0000 Subject: [Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34740|0 |1 is obsolete| | Attachment #34741|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 34757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34757&action=edit [PASSED QA] Bug 13268 - biblioitems.size value not correctly displayed (more) Bug partially corrected by Bug 11357. The size column in biblioitems is a bit problematic when used in TT, because instead of the size value from the biblio column it will give you the size of the variable or current loop. It's currently used in the templates like opac-topissues.tt : [% IF results_loo.size %][% results_loo.size %][% END %] This patch corrects by using item() TT method. See http://stackoverflow.com/questions/2311303/how-can-i-handle-hash-keys-containing-illegal-identifier-characters-in-template. Test plan : - Be sure there is a mapping between a MARC field and biblioitems.size - Create a record A with biblioitems.size defined : like "10x12" - Create a record B with no value in biblioitems.size - Check each modified page : => Without this patch : you see a number (loop size) for both records => With this patch : you only see the correct value for A and nothing for B Signed-off-by: Jonathan Druart Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 10:11:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 09:11:31 +0000 Subject: [Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 --- Comment #12 from Katrin Fischer --- Created attachment 34758 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34758&action=edit [PASSED QA] Bug 13268: the size should not be emptied in pl script It duplicates what the first patch does. Signed-off-by: Jonathan Druart Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 10:31:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 09:31:11 +0000 Subject: [Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Hm, bit confused - the description says it moves the category to the end, but that doesn't match what I see in the templates: When I edit an existing patron: Title: Modify Child patron Breadcrumb: Home ? Patrons ? ? Modify Child patron Modify Adult patron Nicole Schneider Home ? Patrons ? Nicole Schneider ? Modify Adult patron Double checked patch is applied and looking at the English templates. The categoryname at the end doesn't show up for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 10:48:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 09:48:40 +0000 Subject: [Koha-bugs] [Bug 13320] Some prices calculation are done in template side In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13320 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Created attachment 34759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34759&action=edit invoice - master Hi Jonathan, I hope I applied all the dependencies correctly: 12896 12969 13001 13320 I see a difference in the total, the actual cost seems not to be used for the total amount, I am attaching 2 screenshots - one for master and one with the patches applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 10:49:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 09:49:49 +0000 Subject: [Koha-bugs] [Bug 13320] Some prices calculation are done in template side In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13320 --- Comment #6 from Katrin Fischer --- Created attachment 34760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34760&action=edit parcel - patch applied Both screenshots show the parcel page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 10:49:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 09:49:56 +0000 Subject: [Koha-bugs] [Bug 13320] Some prices calculation are done in template side In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13320 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 10:56:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 09:56:12 +0000 Subject: [Koha-bugs] [Bug 13360] C4::Ris considers that hashes are ordered In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13360 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 10:56:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 09:56:15 +0000 Subject: [Koha-bugs] [Bug 13360] C4::Ris considers that hashes are ordered In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13360 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34742|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 34761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34761&action=edit [PASSED QA] Bug 13360: C4::Ris assumes that hash keys are ordered - KW This patch only fixes the KW order. Test plan: 1/ Choose/create a record with several 6XX (for KW), see the code source to know which fields you can use 2/ Export this record in RIS format 3/ Verify that the KW lines are ordered following the marc record fields order. Signed-off-by: Chris Cormack We really should refactor this whole thing into Koha::RIS sometime, it's a horrible module at the moment. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 10:58:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 09:58:22 +0000 Subject: [Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 11:39:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 10:39:45 +0000 Subject: [Koha-bugs] [Bug 13477] On order detail not showing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13477 --- Comment #7 from Iming Chan --- (In reply to Katrin Fischer from comment #5) > Displaying acquisition information in the OPAC was only added to 3.18. > > Die you see the change updating from 3.18 to 3.18.1? > Are you referring to the OPACAcquisitionDetails system preference? Yes, I saw change made in 3.18. I'm unsure what you're referring to "... change updating from 3.18 to 3.18.1"? As for "OPACAcquisitionDetails" in System Preference, it shows "Display ...". See screen image attached. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 11:41:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 10:41:36 +0000 Subject: [Koha-bugs] [Bug 13477] On order detail not showing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13477 --- Comment #8 from Iming Chan --- Created attachment 34762 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34762&action=edit "OPACAcquisitionDetails" setting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 11:45:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 10:45:46 +0000 Subject: [Koha-bugs] [Bug 13477] On order detail not showing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13477 --- Comment #9 from Iming Chan --- (In reply to Katrin Fischer from comment #6) > Created attachment 34733 [details] > OPAC: acq information display with AcqCreateItem != on order > > I retested on master and the information displays. Note: the quantity must > be >1 and AcqCreateItem not set to 'on order'. Problem solved! After I changed AcqCreateItem from "on order" to "receive order", order information now displayed in OPAC. Therefore, I have marked this issued resolved. Thanks for your help Katrin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 11:46:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 10:46:20 +0000 Subject: [Koha-bugs] [Bug 13477] On order detail not showing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13477 Iming Chan changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 11:47:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 10:47:39 +0000 Subject: [Koha-bugs] [Bug 13477] On order detail not showing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13477 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |INVALID --- Comment #10 from Katrin Fischer --- Thx for the feedback Iming, glad it could be resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 14:41:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 13:41:39 +0000 Subject: [Koha-bugs] [Bug 13346] The type of the OpacExportOptions pref should be multiple In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13346 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- The new list is much nicer, but it adds a small regression - you can no longer change the sequence the options are displayed in. I think if someone really wanted to, they can do so via SQL, so probably not worth holding this up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 15:21:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 14:21:56 +0000 Subject: [Koha-bugs] [Bug 13017] Login page image replacement technique fails when browser width exceeds 2000 pixels In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13017 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 17:02:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 16:02:23 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #45 from Zeno Tajoli --- Hi, in fact for there are problems with new format in search_utf8.t, not in auth_values_input_www.t. The problems: /t/db_dependent/www$ prove search_utf8.t search_utf8.t .. 19/32 # Failed test 'Base is like "(?^u:search.pl\?idx=kw&q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1)"' # at search_utf8.t line 218. # got: "http://192.168.216.128:8080/cgi-bin/koha/catalogue"... # length: 75 # doesn't match '(?^u:search.pl\?idx=kw&q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1)' search_utf8.t .. 26/32 # Failed test 'Base is like "(?^u:opac-search.pl\?idx=&q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1)"' # at search_utf8.t line 241. # got: "http://192.168.216.128/cgi-bin/koha/opac-detail.pl"... # length: 65 # doesn't match '(?^u:opac-search.pl\?idx=&q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1)' search_utf8.t .. 32/32 # Looks like you failed 2 tests of 32. search_utf8.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/32 subtests Motivation: I use a MySQL db completly clear, so when I start test at test 19 I have only 1 record into db and zebra (zebra records are coming fromm db). So the search finds 1 result and it display a FULL RECORD display, not a MANY RESULTS display. The full record display has a url base DIFFERENT from a many result display. The test 19 wants a base as a MANY RESULTS display. In fact if test 2-3 times WITHOUT purge (because you stop the debug) you have two o more time the same test record uploaded in to db and so the search gives you a MANY RESULTS display. So the first question is: WHERE we want to testt the display of utf-8 chars ? In the FULL RECORD display or in the MANY RESULTS display ? My original code was on testing uft-8 chars into FULL RECORD display but we can change anch test on MANY RESULTS display. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 18:09:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 17:09:37 +0000 Subject: [Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 --- Comment #5 from Marc V?ron --- Hi Katrin, Did you test with the "Edit" links on the page, e.g. below "Date of birth" or "Library use"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 18:59:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 17:59:26 +0000 Subject: [Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 --- Comment #6 from Katrin Fischer --- I checked the 'edit' in the toolbar and 'duplicate' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 20:13:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 19:13:12 +0000 Subject: [Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 --- Comment #7 from Marc V?ron --- Created attachment 34763 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34763&action=edit How it works now: Different Edit buttons show different titels / bradcrumbs for same patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 20:15:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 19:15:42 +0000 Subject: [Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 --- Comment #8 from Marc V?ron --- Created attachment 34764 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34764&action=edit How it looks after patch (use "Edit" below Date of birth) and proposition how it should be for all kinds of editing (from toolbar or from links on page) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 20:22:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 19:22:33 +0000 Subject: [Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 --- Comment #9 from Katrin Fischer --- That's not what I saw - I will have to go back and retest, but right now not sure where I went wrong :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 20:29:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 19:29:58 +0000 Subject: [Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 --- Comment #10 from Marc V?ron --- No problem,I think the whole code is rather complicated. Please have a look at the proposition in my 2nd screenshot: The idea is to have both Category TYPE and category NAME, something like Modify patron Hansli Testmann (Child:Juvenile) ([TYPE]:[NAME]) If you think this would be OK I will provide a new patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 23:04:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 22:04:00 +0000 Subject: [Koha-bugs] [Bug 13471] When editing a subscription, the "subscription length type" disregards the stored value, also make SLT translateable. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13471 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 23:04:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 22:04:03 +0000 Subject: [Koha-bugs] [Bug 13471] When editing a subscription, the "subscription length type" disregards the stored value, also make SLT translateable. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13471 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34661|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia --- Created attachment 34765 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34765&action=edit Bug 13471 - When editing a subscription, the "subscription length type" disregards the stored value, also make SLT translateable. This issue causes loss of data when the subscription length type (SLT) is other than issues. TO REPLICATE: We make an subscription with SLT of months = 12. Later make an arbitrary edit to the subscription, and miss out the fact that the SLT selection is set to issues. Save the changes. Serial subscription end date is set to 12 issues since the start date, instead of 12 months which it used to be. This causes a myriad of issues :=) AFTER THIS PATCH: SLT defaults to the value initially saved instead of always being issues. Now the selection can be translated! HOTFIX 1: Added elements to showSubscriptionLengthType.inc so the translation tool can catch them. HOTFIX 2: Fixed serials/showpredictionpattern.pl to use the db columns instead of issues,weeks,months. HOTFIX 3: Fixed serials/subscription-numberpatterns.pl to use the db columns instead of issues,weeks,months. Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 23:23:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 22:23:13 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34110|0 |1 is obsolete| | --- Comment #46 from Zeno Tajoli --- Created attachment 34766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34766&action=edit UNIMARC and MARC21 records to test UTF-8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 23:24:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 22:24:38 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34111|0 |1 is obsolete| | --- Comment #47 from Zeno Tajoli --- Created attachment 34767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34767&action=edit Test for utf-8 on Opac search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 23:25:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 22:25:19 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34112|0 |1 is obsolete| | --- Comment #48 from Zeno Tajoli --- Created attachment 34768 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34768&action=edit Test for utf-8 on authorised values input/display/delete -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 23:26:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 22:26:04 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34113|0 |1 is obsolete| | --- Comment #49 from Zeno Tajoli --- Created attachment 34769 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34769&action=edit no need to test for MySQL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 23:27:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 22:27:07 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34114|0 |1 is obsolete| | --- Comment #50 from Zeno Tajoli --- Created attachment 34770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34770&action=edit Make opac_utf8.t launch its own helper processes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 23:27:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 22:27:56 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34115|0 |1 is obsolete| | --- Comment #51 from Zeno Tajoli --- Created attachment 34771 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34771&action=edit Follow up: in opac_utf8.t insert also delete of biblio -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 23:29:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 22:29:03 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34116|0 |1 is obsolete| | --- Comment #52 from Zeno Tajoli --- Created attachment 34772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34772&action=edit Additional test for search in intranet calatogue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 23:29:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 22:29:42 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34117|0 |1 is obsolete| | --- Comment #53 from Zeno Tajoli --- Created attachment 34773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34773&action=edit Refactor search utf8 tests and add some more -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 23:30:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 22:30:40 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34694|0 |1 is obsolete| | --- Comment #54 from Zeno Tajoli --- Created attachment 34774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34774&action=edit QA followup - prevent double-encoding on the tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 23:32:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 22:32:41 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #55 from Zeno Tajoli --- Created attachment 34775 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34775&action=edit Duplicate record in marc21 and unimarc files to show more than one result -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 23:34:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 22:34:59 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #56 from Zeno Tajoli --- Created attachment 34776 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34776&action=edit Add a test for Auth values to check chars that could be utf-8 or latin-1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 23:35:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 22:35:15 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 28 23:44:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 22:44:37 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #57 from Zeno Tajoli --- To correct the problem of comment #45 I duplicate the records in the files data/mar21utf8record.mrc data/unimarcutf8reco.mrc So the server shows always the 'Many records' display. In auth_values_input_www.t I added also test for chars utf-8/latin-1 like 't?mas'. To test: prove search_utf8.t prove auth_values_input_www.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 00:00:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 23:00:26 +0000 Subject: [Koha-bugs] [Bug 11982] Show local cover images in the biblio details page in the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen at gmail.com --- Comment #20 from Tom?s Cohen Arazi --- Hi, it seems some rebasing is needed. Will be watghing this one to push it ASAP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 00:02:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 23:02:56 +0000 Subject: [Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed by Module Maintainer |Pushed to Master CC| |tomascohen at gmail.com --- Comment #24 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 00:03:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 23:03:27 +0000 Subject: [Koha-bugs] [Bug 13453] Koha.t daily quote tests assume sample data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13453 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 00:03:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 23:03:56 +0000 Subject: [Koha-bugs] [Bug 13360] C4::Ris considers that hashes are ordered In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13360 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 00:04:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 23:04:36 +0000 Subject: [Koha-bugs] [Bug 13357] Untranslatable strings on itemsearch.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13357 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 00:05:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 23:05:09 +0000 Subject: [Koha-bugs] [Bug 13124] Record titles with parentheses causing label weirdness In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #15 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 00:36:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 23:36:53 +0000 Subject: [Koha-bugs] [Bug 9958] RoutingSerials description misleading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9958 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Summary|RoutingSerials desription |RoutingSerials description |misleading |misleading -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 00:42:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 23:42:03 +0000 Subject: [Koha-bugs] [Bug 13407] Remove methods which are included in the 0.36 release of PDF::Reuse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz, | |tomascohen at gmail.com --- Comment #14 from Tom?s Cohen Arazi --- I expect to have the .deb file on the squeeze-dev pocket for pushing, otherwise we should feed the jenkins nodes by hand using CPAN. Robin? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 00:47:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 23:47:19 +0000 Subject: [Koha-bugs] [Bug 13252] SIP2 server should accept IPv6 connections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13252 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Severity|minor |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 00:49:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 23:49:38 +0000 Subject: [Koha-bugs] [Bug 13285] updatedatabase throws an error if opacthemes is not set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13285 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Good catch Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 00:50:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 23:50:09 +0000 Subject: [Koha-bugs] [Bug 9958] RoutingSerials description misleading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9958 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 00:50:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 23:50:35 +0000 Subject: [Koha-bugs] [Bug 13458] Add new patron shows default / hardcoded patron categories after search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 00:51:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 23:51:41 +0000 Subject: [Koha-bugs] [Bug 12895] Dropbox mode doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12895 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #12 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Koha Team Lyon 3! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 00:52:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 23:52:30 +0000 Subject: [Koha-bugs] [Bug 13447] runreport.pl html email fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13447 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Martin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 00:53:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 23:53:01 +0000 Subject: [Koha-bugs] [Bug 13341] Hard-coded "Preview" text in OPAC openlibrary.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 00:55:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 23:55:24 +0000 Subject: [Koha-bugs] [Bug 13252] SIP2 server should accept IPv6 connections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13252 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Benjamin, and congratulations for your first patch pushed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 00:58:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Dec 2014 23:58:05 +0000 Subject: [Koha-bugs] [Bug 8848] 'make test' fails on Barcodes_ValueBuilder.t (upgrading from 3.08.04) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8848 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |tomascohen at gmail.com Resolution|--- |WORKSFORME --- Comment #1 from Tom?s Cohen Arazi --- Missing dependency. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 01:02:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 00:02:55 +0000 Subject: [Koha-bugs] [Bug 13496] New: Wrong Koha version on installer title Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13496 Bug ID: 13496 Summary: Wrong Koha version on installer title Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Steps to reproduce: - Launch the webinstaller (I deleted my DB to do it) - The login screen shows => FAIL: "Koha 3.0 Installer" is hidden inside the code. It seems to be intended for screen readers to tell it (I cannot test that feature) but I think it is showing the wrong version, and it shouldn't. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 01:32:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 00:32:02 +0000 Subject: [Koha-bugs] [Bug 13496] Wrong Koha version on installer title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13496 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 34777 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34777&action=edit Bug 13496: add a method for the templates to print Koha version as desired This patch introduces a simple template plugin function that returns the Koha version number in different suitable formats. It introduces unit tests for the new function. They are run with To test: - Apply the patch - Run $ prove t/Koha_Template_Plugin_Koha.t => SUCCESS: the tests pass. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 01:33:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 00:33:38 +0000 Subject: [Koha-bugs] [Bug 13496] Wrong Koha version on installer title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13496 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 01:33:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 00:33:41 +0000 Subject: [Koha-bugs] [Bug 13496] Wrong Koha version on installer title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13496 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 34778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34778&action=edit Bug 13496: make auth.tt use a template plugin to get the Koha version This patch makes the installer login template use the new Koha.Version template plugin to get the correct Koha version. This way we don't need to maintain the auth.tt file on each version change, and are sure screen readers tell the correct version. To test: - Create a situation where the login screen from the installer shows - Navigate the HTML code (Ctrl+u) => FAIL: "Koha 3.0 Installer" shows on the HTML code - Apply the patch - Reload the page => SUCCESS: The correct version number is shown. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 01:33:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 00:33:58 +0000 Subject: [Koha-bugs] [Bug 13496] Wrong Koha version on installer title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13496 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 01:39:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 00:39:58 +0000 Subject: [Koha-bugs] [Bug 13407] Remove methods which are included in the 0.36 release of PDF::Reuse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407 --- Comment #15 from Robin Sheat --- Not yet, it'll happen very soon. Hopefully today. I'm lining it up for inclusion in Debian at the same time, and so it takes a little longer to make sure I get it right. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 05:50:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 04:50:55 +0000 Subject: [Koha-bugs] [Bug 13407] Remove methods which are included in the 0.36 release of PDF::Reuse In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407 --- Comment #16 from Robin Sheat --- (In reply to Robin Sheat from comment #15) > Not yet, it'll happen very soon. Hopefully today. I'm lining it up for > inclusion in Debian at the same time, and so it takes a little longer to > make sure I get it right. And, done. Hopefully it'll be accepted for debian with no more changes too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 09:48:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 08:48:54 +0000 Subject: [Koha-bugs] [Bug 12053] Borrower attributes not visible anymore at OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12053 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|INVALID |DUPLICATE --- Comment #3 from Fridolin SOMERS --- I found the correction in Bug 12718 *** This bug has been marked as a duplicate of bug 12718 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 09:48:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 08:48:54 +0000 Subject: [Koha-bugs] [Bug 12718] Show extended patron attributes in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12718 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #8 from Fridolin SOMERS --- *** Bug 12053 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 09:51:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 08:51:18 +0000 Subject: [Koha-bugs] [Bug 12718] Show extended patron attributes in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12718 --- Comment #9 from Fridolin SOMERS --- (In reply to Nicole C. Engard from comment #7) > Will this be backported to 3.16.x ? I'd like this too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:01:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:01:31 +0000 Subject: [Koha-bugs] [Bug 13459] Datatables paging slightly broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13459 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:01:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:01:33 +0000 Subject: [Koha-bugs] [Bug 13459] Datatables paging slightly broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13459 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34735|0 |1 is obsolete| | Attachment #34736|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 34779 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34779&action=edit Bug 13459: Fix datatables paging for admin > itemtypes To test: - Go to administration > itemtypes - Verify the display of the paging options is broken - Apply patch - Verify the display is now correct and works nicely Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:01:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:01:37 +0000 Subject: [Koha-bugs] [Bug 13459] Datatables paging slightly broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13459 --- Comment #7 from Jonathan Druart --- Created attachment 34780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34780&action=edit Bug 13459: Fix datatables paging for patron lists The display of the datatables paging options for the patron list feature is broken. To test: - Go to tools > patron lists - The paging for the 'list of lists' is broken - Select a patron list 'Add more patrons' - Notice the paging on this page is also broken - Apply patch - Verify both pages now display the paging correctly Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:15:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:15:53 +0000 Subject: [Koha-bugs] [Bug 12944] There is no way to search orders by creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:15:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:15:56 +0000 Subject: [Koha-bugs] [Bug 12944] There is no way to search orders by creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 --- Comment #19 from Jonathan Druart --- Created attachment 34781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34781&action=edit Bug 12944: Fix regression on translating This patch fixes the translation for the "Remove" button. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:22:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:22:12 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33226|0 |1 is obsolete| | --- Comment #66 from Jonathan Druart --- Created attachment 34782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34782&action=edit Bug 11023: Toggle "new" status This patch adds: - a new DB field items.new. - a new page to configure this new status (tools/toggle_new_status.pl). - a new cronjob script (misc/cronjob/toggle_new_status.pl). Why this status is useful for some libraries ? The use cases are: - to know easily what are the new items (with a simple sql query). - to display an icon in the search results. - issuing rules can be adapt for new items. Automatically (using the cronjob script), the status change (depending the configuration) and the item can be issued, for example. - a RSS/Atom feeds can be created on these new items. Test plan: - log in with a librarian having the tools > items_batchmod permission. - navigate to Home > Tools > Toggle new status - click on the edit button - there are 3 "blocks": * duration: the duration during an item is considered as new. * conditions: the status will change only if the conditions are meet. * substitutions: if there is no substitution, no action will be done. You can add some change to apply to the matching items. E.g. ccode=3 new='' If the value is an empty string (in other words, the input does not contain anything), the field will be deleted. You can create as many rules as you want. - test the interface : add/remove rule, conditions, substitutions, submit the form, edit, etc. (There is a looot of JS everywhere, so certainly a looot of bugs...). - when you have your rules defined, you can now launch the cronjob script without any parameter. A report will be displayed with the matching itemnumber and the substitutions to apply. Verify results are consistent. - launch the script with the -c argument and verify values have been modified depending the substitution rules. Signed-off-by: juliette et r?my -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:22:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:22:16 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33227|0 |1 is obsolete| | --- Comment #67 from Jonathan Druart --- Created attachment 34783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34783&action=edit Bug 11023: Add the ability to specify fields from biblioitems table. Test plan: Same as before but try with fields from the biblioitems table. Signed-off-by: juliette et r?my -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:22:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:22:20 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33228|0 |1 is obsolete| | --- Comment #68 from Jonathan Druart --- Created attachment 34784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34784&action=edit Bug 11023: Add UT for C4::Items::ToggleNewStatus Test plan: prove t/db_dependent/Items/ToggleNewStatus.t Signed-off-by: juliette et r?my -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:22:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:22:25 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33229|0 |1 is obsolete| | --- Comment #69 from Jonathan Druart --- Created attachment 34785 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34785&action=edit Bug 11023: FIX - condition on biblioitems table does not work If a rule contains a condition on the biblioitems table, the match won't work. This patch fixes this issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:22:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:22:28 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33230|0 |1 is obsolete| | --- Comment #70 from Jonathan Druart --- Created attachment 34786 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34786&action=edit Bug 11023: Use DBIx-Class to retrieve column names -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:22:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:22:32 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33231|0 |1 is obsolete| | --- Comment #71 from Jonathan Druart --- Created attachment 34787 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34787&action=edit Bug 11023: Don't use the biblioitems fields for the subtitution It's dangerous to allow a change on the biblioitems fields with this feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:22:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:22:36 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33232|0 |1 is obsolete| | --- Comment #72 from Jonathan Druart --- Created attachment 34788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34788&action=edit Bug 11023: DB changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:22:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:22:40 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33233|0 |1 is obsolete| | --- Comment #73 from Jonathan Druart --- Created attachment 34789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34789&action=edit Bug 11023: Rename the duration parameter with 'age' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:22:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:22:44 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33234|0 |1 is obsolete| | --- Comment #74 from Jonathan Druart --- Created attachment 34790 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34790&action=edit Bug 11023: The age parameter should be a number The template should check if the age parameter is correctly filled (should be a number). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:22:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:22:48 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33235|0 |1 is obsolete| | --- Comment #75 from Jonathan Druart --- Created attachment 34791 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34791&action=edit Bug 11023: Change the name of the feature Originaly this feature only permits to update the "new" field. Now all item fields can be updated. The name of the feature is now "Automatic item modifications by age". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:23:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:23:10 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #76 from Jonathan Druart --- Patches rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:32:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:32:16 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33265|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 34792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34792&action=edit Bug 13014: Notify budget owner on new suggestion - UT When a suggestion is created and linked to a fund, a mail will be generated, using a cronjob, to notify the budget owner. A suggestion is considered as "can be treated" if its status is "ASKED". Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:32:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:32:19 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33266|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 34793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34793&action=edit Bug 13014: Notify budget owner on new suggestion - sample notices This patch add the new notice suggestion > TO_PROCESS Others will be added when the patch will be signed off. Signed-off-by: Frederic Demians Followup expected :-) It would be nice also to have an updatabase.pl entry to insert the new TO_PROCESS notification. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:32:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:32:22 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33267|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart --- Created attachment 34794 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34794&action=edit Bug 13014: Notify budget owner on new suggestion - cronjob Test plan: 0/ Create a new notice suggestions > TO_PROCESS You can use the one defined in the other patch. 1/ Create a suggestion and link it to a fund 2/ Add a owner to this fund and make sure this patron has an email address (the email address used should be the one defined in the AutoEmailPrimaryAddress syspref). 3/ Execute the cronjob script with the -v and without the -c argument 4/ The output should tell you that an email will be sent 5/ Execute the cronjob script with the -v and with the -c argument 6/ Verify the notice is generated in the message_queue table and it is correctly formatted. Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:32:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:32:25 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33293|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart --- Created attachment 34795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34795&action=edit Bug 13014: (follow-up) Notify budget owner on new suggestion - sample notices This patch adds the new notice for all other languages. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:32:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:32:29 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33294|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart --- Created attachment 34796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34796&action=edit Bug 13014: (follow-up 2) Notify budget owner on new suggestion - sample notices This patch updates the 2 optional sample_notices.sql files for ru-RU and uk-UA. Not sure if it is relevant but I don't understand why they are not up-to-date. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:32:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:32:48 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #19 from Jonathan Druart --- Patches rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:34:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:34:42 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 --- Comment #17 from Jonathan Druart --- Created attachment 34797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34797&action=edit Bug 12993: Add a default tax rate on item types - DB changes This patch adds a new DB field: itemtypes.gstrate Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:34:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:34:59 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33306|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:35:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:35:11 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 --- Comment #18 from Jonathan Druart --- (In reply to Katrin Fischer from comment #16) > Note for later: Add bug number to datebase update message Done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:47:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:47:55 +0000 Subject: [Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 --- Comment #10 from Jonathan Druart --- (In reply to Katrin Fischer from comment #8) > Comment on attachment 31981 [details] [review] > Bug 12975: Use the centralize VAT and prices calculation - basketgroup.pl > > Review of attachment 31981 [details] [review]: > ----------------------------------------------------------------- > > ::: acqui/basketgroup.pl > @@ -212,5 @@ > > } > > } > > > > - my $ba_order = { > > - isbn => ($ord->{isbn} ? $ord->{isbn} : undef), > > Hi Jonathan, bit irritated by this line - was removing it intentional? I see > that that PDF should be printing the ISBN, but have a bit of trouble making > it work in my installation currently. Hi Katrin, Yes it is intentional. Actually before the patch, the $ba_order was pushed to @ba_orders. Now, the order $ord is pushed. We could add: $ord->{isbn} = $ord->{isbn} ? $order->{isbn} : undef; But it does not make sense, except if we need to manage the empty string or 0, but it would not be a valid ISBN. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:49:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:49:58 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34766|0 |1 is obsolete| | --- Comment #58 from Zeno Tajoli --- Created attachment 34798 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34798&action=edit UNIMARC and MARC21 records to test UTF-8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:50:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:50:56 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34767|0 |1 is obsolete| | --- Comment #59 from Zeno Tajoli --- Created attachment 34799 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34799&action=edit Test for utf-8 on Opac search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:51:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:51:57 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34768|0 |1 is obsolete| | --- Comment #60 from Zeno Tajoli --- Created attachment 34800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34800&action=edit Test for utf-8 on authorised values input/display/delete -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:52:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:52:24 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34769|0 |1 is obsolete| | --- Comment #61 from Zeno Tajoli --- Created attachment 34801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34801&action=edit no need to test for MySQL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:52:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:52:55 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34770|0 |1 is obsolete| | --- Comment #62 from Zeno Tajoli --- Created attachment 34802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34802&action=edit Make opac_utf8.t launch its own helper processes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:53:24 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:53:24 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34771|0 |1 is obsolete| | --- Comment #63 from Zeno Tajoli --- Created attachment 34803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34803&action=edit Follow up: in opac_utf8.t insert also delete of biblio -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:54:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:54:03 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34772|0 |1 is obsolete| | --- Comment #64 from Zeno Tajoli --- Created attachment 34804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34804&action=edit Additional test for search in intranet calatogue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:54:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:54:36 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34773|0 |1 is obsolete| | --- Comment #65 from Zeno Tajoli --- Created attachment 34805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34805&action=edit Refactor search utf8 tests and add some more -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:55:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:55:02 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34774|0 |1 is obsolete| | --- Comment #66 from Zeno Tajoli --- Created attachment 34806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34806&action=edit QA followup - prevent double-encoding on the tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:55:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:55:41 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34775|0 |1 is obsolete| | --- Comment #67 from Zeno Tajoli --- Created attachment 34807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34807&action=edit Duplicate record in marc21 and unimarc files to show more than one result -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:56:29 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:56:29 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #68 from Zeno Tajoli --- Created attachment 34808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34808&action=edit Add a test for Auth values to check chars that could be utf-8 or latin-1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:58:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:58:31 +0000 Subject: [Koha-bugs] [Bug 13346] The type of the OpacExportOptions pref should be multiple In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13346 --- Comment #4 from Jonathan Druart --- (In reply to Katrin Fischer from comment #3) > The new list is much nicer, but it adds a small regression - you can no > longer change the sequence the options are displayed in. I think if someone > really wanted to, they can do so via SQL, so probably not worth holding this > up. To be fair, I did not think about that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:58:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:58:42 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34776|0 |1 is obsolete| | --- Comment #69 from Zeno Tajoli --- Created attachment 34809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34809&action=edit Add two new file .mrc for marc21 and unimarc to test chars utf8/latin1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 11:59:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 10:59:39 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #70 from Zeno Tajoli --- Created attachment 34810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34810&action=edit Update of unimarc and marc21 new test files to seach publisher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 12:00:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 11:00:51 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #71 from Zeno Tajoli --- Created attachment 34811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34811&action=edit New test in search_utf8.t to manage chars in utf8/latin1 ambiguity -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 12:01:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 11:01:22 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 12:06:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 11:06:15 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #72 from Zeno Tajoli --- Now I have complete tests also for the chars that could be utf-8 and latin-1 i the same time. There are new test .mrc files in www/data: unimarclatin1utf8rec.mrc marc21latin1utf8rec.mrc In search_utf8.t now the test on search is a routine, so it is more easy to add new records and new test cases. I insert 'Needs Signoff' because there are many new situations. To test: prove search_utf8.t prove auth_values_input_www.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 12:39:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 11:39:34 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #73 from Jonathan Druart --- Quick notes: 1/ I had to add a 'b7' branches to remove the following error in koha logs: manage-marc-import.pl: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_ut`.`items`, CONSTRAINT `items_ibfk_2` FOREIGN KEY (`homebranch`) REFERENCES `branches` (`branchcode`) ON UPDATE CASCADE) at /home/koha/src/C4/Items.pm line 2171. 2/ With the last patches, the tests don't pass: t/db_dependent/www/search_utf8.t .. 18/64 Error GETing http://pro.koha-qa.vm/cgi-bin/koha/catalogue/search.pl?idx=kw&q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1&idx=kw&idx=kw&sort_by=relevance: Internal Server Error at t/db_dependent/www/search_utf8.t line 245. # Looks like you planned 64 tests but ran 18. # Looks like your test exited with 255 just after 18. To make them pass, I need to (manually) revert the Tomas's patch: diff --git a/t/db_dependent/www/search_utf8.t b/t/db_dependent/www/search_utf8.t index be5ac96..12dbc41 100644 --- a/t/db_dependent/www/search_utf8.t +++ b/t/db_dependent/www/search_utf8.t @@ -233,7 +233,7 @@ sub test_search{ $agent->get_ok( "$intranet/cgi-bin/koha/catalogue/search.pl" , "got search on intranet"); $agent->form_number(1); $agent->field('idx', 'kw'); - $agent->field('q', $search_key); + $agent->field('q', Encode::encode('UTF-8', $search_key)); $agent->click(); my $intra_text = $agent->text() ; like( $intra_text, qr|Publisher: $publisher|, ); @@ -241,12 +241,12 @@ sub test_search{ $agent->get_ok( "$intranet/cgi-bin/koha/catalogue/search.pl" , "got search on intranet"); $agent->form_number(1); $agent->field('idx', 'kw'); - $agent->field('q', $publisher); + $agent->field('q', Encode::encode('UTF-8', $publisher)); $agent->click(); $intra_text = $agent->text(); like( $intra_text, qr|Publisher: $publisher|, ); - my $expected_base = q|search.pl\?idx=kw&q=| . uri_escape_utf8( $publisher ); + my $expected_base = q|search.pl\?idx=kw&q=| . uri_escape_utf8( Encode::encode('UTF-8', $publisher )); $agent->base_like(qr|$expected_base|, ); ok ( ( length(Encode::encode('UTF-8', $intra_text)) != length($intra_text) ) , 'UTF-8 are multi-byte. Goog') ; @@ -269,7 +269,7 @@ sub test_search{ $opac_text = $agent->text(); like( $opac_text, qr|Publisher: $publisher|, ); - $expected_base = q|opac-search.pl\?idx=&q=| . uri_escape_utf8( $publisher ); + $expected_base = q|opac-search.pl\?q=| . uri_escape_utf8( $publisher ); $agent->base_like(qr|$expected_base|, ); ok ( ( length(Encode::encode('UTF-8', $opac_text)) != length($opac_text) ) , 'UTF-8 are multi-byte. Goog') ; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 12:52:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 11:52:57 +0000 Subject: [Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 --- Comment #11 from Katrin Fischer --- Hi Jonathan, I think you lost me there, but I believe you :) It looks like the printed PDF should include the ISBN, which also seems crucial for an order to a vendor. Does it print for you? It didn't for me, so maybe that's a separate bug to file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 14:12:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 13:12:54 +0000 Subject: [Koha-bugs] [Bug 13320] Some prices calculation are done in template side In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13320 --- Comment #7 from Jonathan Druart --- Created attachment 34812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34812&action=edit on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 14:17:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 13:17:06 +0000 Subject: [Koha-bugs] [Bug 13320] Some prices calculation are done in template side In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13320 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34812|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Comment on attachment 34812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34812 on master forget that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 14:33:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 13:33:22 +0000 Subject: [Koha-bugs] [Bug 11982] Show local cover images in the biblio details page in the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 --- Comment #21 from simith.doliveira at inlibro.com --- Created attachment 34813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34813&action=edit Bug 11982 - Images now display properly in the details section. If the a cover image exists, it will be displayed on the details page. Nothing is displayed of there is no cover available. modified: koha-tmpl/intranet-tmpl/prog/en/js/localcovers.js modified: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Works as described, passes tests and QA script. Checked Amazon covers and local covers display correctly in staff on results and detail pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 14:34:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 13:34:44 +0000 Subject: [Koha-bugs] [Bug 13320] Some prices calculation are done in template side In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13320 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #9 from Jonathan Druart --- (In reply to Katrin Fischer from comment #5) > Created attachment 34759 [details] > invoice - master > > Hi Jonathan, > > I hope I applied all the dependencies correctly: > 12896 > 12969 > 13001 > 13320 Bug 13001 depends on bug 12976, which is missing. The issue is fixed when the patches from bug 12976 are applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 14:38:26 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 13:38:26 +0000 Subject: [Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 --- Comment #12 from Jonathan Druart --- (In reply to Katrin Fischer from comment #11) > Hi Jonathan, I think you lost me there, but I believe you :) > > It looks like the printed PDF should include the ISBN, which also seems > crucial for an order to a vendor. Does it print for you? It didn't for me, > so maybe that's a separate bug to file. Yes, I see it with English 3-pages with and without the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 14:39:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 13:39:51 +0000 Subject: [Koha-bugs] [Bug 11982] Show local cover images in the biblio details page in the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34813|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 14:43:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 13:43:42 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #74 from Zeno Tajoli --- Created attachment 34814 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34814&action=edit Follow up on record files: deleted fields with item info (952/995) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 14:47:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 13:47:19 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #75 from Zeno Tajoli --- (In reply to Jonathan Druart from comment #73) > 1/ I had to add a 'b7' branches to remove the following error in koha logs: > manage-marc-import.pl: DBD::mysql::st execute failed: Cannot add or update a > child row: a foreign key constraint fails (`koha_ut`.`items`, CONSTRAINT > `items_ibfk_2` FOREIGN KEY (`homebranch`) REFERENCES `branches` > (`branchcode`) ON UPDATE CASCADE) at /home/koha/src/C4/Items.pm line 2171. The last commit [ Follow up on record files: deleted fields with item info (952/995)] fixes this problem. In fact item's info are not useful for this test so I delete the fields with item's info inside. The fields deleted are: 952 (MARC21) and 995 (UNIMARC) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 14:55:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 13:55:38 +0000 Subject: [Koha-bugs] [Bug 11982] Show local cover images in the biblio details page in the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 --- Comment #22 from simith.doliveira at inlibro.com --- Created attachment 34815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34815&action=edit Bug 11982 - Show local cover image in the intranet biblio details page Also, fix useless "No cover image" block when using Amazon and local cover images at the same time. http://bugs.koha-community.org/show_bug.cgi?id=11982 Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 14:56:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 13:56:46 +0000 Subject: [Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 --- Comment #7 from Martin Renvoize --- Comment on attachment 34551 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34551 Bug 12954 - Questionable logic regarding session handling in C4::Auth::checkauth() Review of attachment 34551: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12954&attachment=34551) ----------------------------------------------------------------- First comments, but nothing really important so far.. Still working my way through the logic for the second part ::: C4/Auth.pm @@ +780,4 @@ > } > elsif ( !$lasttime || ($lasttime < time() - $timeout) ) { > # timed logout > + $info{'timed_out'} = 1 if $lasttime; This feels unrelated to me, as such I'de rather see it in it's own bug rather than confusing the issue here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 14:56:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 13:56:51 +0000 Subject: [Koha-bugs] [Bug 11982] Show local cover images in the biblio details page in the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34815|0 |1 is obsolete| | --- Comment #23 from simith.doliveira at inlibro.com --- Created attachment 34816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34816&action=edit Bug 11982 - Show local cover image in the intranet biblio details page - conflit fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 15:00:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 14:00:32 +0000 Subject: [Koha-bugs] [Bug 11982] Show local cover images in the biblio details page in the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32746|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 15:00:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 14:00:52 +0000 Subject: [Koha-bugs] [Bug 11982] Show local cover images in the biblio details page in the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32747|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 15:01:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 14:01:08 +0000 Subject: [Koha-bugs] [Bug 11982] Show local cover images in the biblio details page in the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32748|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 15:01:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 14:01:53 +0000 Subject: [Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 --- Comment #8 from Martin Renvoize --- I think I would prefer to see this done 'properly', i.e. setting the session to anon and ensuring it's tested for to prevent the loop we're finding here. I'll have a play around and see if I can achieve this, unless you want to refine your attempt Jacek -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 15:02:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 14:02:36 +0000 Subject: [Koha-bugs] [Bug 11982] Show local cover images in the biblio details page in the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 simith.doliveira at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 15:16:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 14:16:15 +0000 Subject: [Koha-bugs] [Bug 13497] New: The pref AddPatronLists should be removed Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 Bug ID: 13497 Summary: The pref AddPatronLists should be removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org The pref AddPatronLists does not work as expected if 'generic' is selected. Indeed a patron should be linked to a valid patron category (see the constraint borrowers_ibfk_1 in the DB structure). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 15:16:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 14:16:49 +0000 Subject: [Koha-bugs] [Bug 13458] Add new patron shows default / hardcoded patron categories after search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13497 --- Comment #6 from Jonathan Druart --- (In reply to Katrin Fischer from comment #4) > Note: I am not sure if AddPatronLists makes sense - > if you set it to general patron types, it still preselects the > wrong category type (tried organization, a child patron category > was selected). Also the name is confusiong nowadays with the > Patron list feature. Agreed, cf bug 13497. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 15:16:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 14:16:49 +0000 Subject: [Koha-bugs] [Bug 13497] The pref AddPatronLists should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13458 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 15:18:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 14:18:51 +0000 Subject: [Koha-bugs] [Bug 13497] The pref AddPatronLists should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 15:22:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 14:22:27 +0000 Subject: [Koha-bugs] [Bug 13497] The pref AddPatronLists should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 15:22:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 14:22:30 +0000 Subject: [Koha-bugs] [Bug 13497] The pref AddPatronLists should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 --- Comment #1 from Jonathan Druart --- Created attachment 34817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34817&action=edit Bug 13497: Remove the pref AddPatronsLists The pref AddPatronLists does not work as expected if 'generic' is selected. Indeed a patron should be linked to a valid patron category (see the constraint borrowers_ibfk_1 in the DB structure). Test plan: 0/ Confirm that the AddPatronLists does not work as expected if you choose the generic patron types. 1/ Delete all you patron categories and check that the interface invites you to create one. 2/ Confirm that you are able to create a patron and to link it to a patron category you have created. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 16:12:40 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 15:12:40 +0000 Subject: [Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 16:17:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 15:17:30 +0000 Subject: [Koha-bugs] [Bug 13498] New: ISSUESLIP, ISSUEQSLIP use 'email' template for print. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13498 Bug ID: 13498 Summary: ISSUESLIP, ISSUEQSLIP use 'email' template for print. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org I set up print slips for ISSUESLIP and ISSUEQSLIP using the 'print' template. When I print from circ/circulation.pl using either "Print Slip" or "Print Quick Slip", I get the text from the the email template. To reproduce: Edit the 'email' and 'print' templates for ISSUEQSLIP and ISSUESLIP. Make sure that the email and print templates contain different text. /cgi-bin/koha/tools/letter.pl?op=add_form&branchcode=&module=circulation&code=ISSUEQSLIP /cgi-bin/koha/tools/letter.pl?op=add_form&branchcode=&module=circulation&code=ISSUESLIP Check out items to a test patron. On the check-out page, select Print->Print Slip. Print the slip. Do the same for 'Print quick slip'. Note that the text from the 'email' template is used. When resolving this bug, a bit of thought is going to be required, because 'Print' is the primary use of this slip, so it should come first in the list, but we don't want to create a slap-dash one-off of the print slip template page just to accommodate that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 16:22:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 15:22:05 +0000 Subject: [Koha-bugs] [Bug 13498] ISSUESLIP, ISSUEQSLIP use 'email' template for print. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13498 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I think the slips are different to the other notices, as they can only be printed and are not made to be used with other transport options. Maybe it would be worth hiding the other options in this case and only offer print? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 17:05:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 16:05:55 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #46 from Paola Rossi --- I've applied the patches against master 3.19.00.003 [it needed a trivial rebase] I set "makePreviousSerialAvailable" syspref to "Make" as required. I kept the "item-level_itypes" syspref to "specific item". I created a subscription, which didn't create an item record when it received the serial. When I received ("Arrived") issues, no item was created: so this bug is not about this case. So I created another subscription, which created an item record when receiving the serial, and I set its 2 new fields ["Item type" and "Previous item type"] to "Continuing Resources". Then I "Edited" the subscription: the "Item type" and "Previous item type" fields were not set to "Continuing Resources" anymore! (ERROR) Anyway I went on: Was the previously received serial's itemtype set as defined in the subscription? When I received ("Arrived") an issue [in DB: table serial] of the subscription (the first issue), I saw that the default value of the: "y - Koha item type" field of the new item was set to nothing (why?). I didn't change it to "Continuing Resources" [because koha should do it for me, shouldn't it?]; then I filled the other fields (barcode, aso), and I saved the new item. Then I looked at the biblio: In the biblio's Holdings tag, the item was "Available" and its item type is CR as required (RIGHT). I received another issue [the 2-nd] for the same subscription. Now, in the biblio's Holdings, the new (2-nd) item was "Available" and CR, as required. But the previous (1-st) item [still "Available"] lost its type: it had no type anymore! (ERROR) But I could have been wrong: as Katrin wrote in comment 38: >It would be good to add a test plan and description. I think >the feature evolved a bit over time, as this is one of the older bug reports. Anyway: prove t/db_dependent/Serials_2.t t/db_dependent/Serials_2.t .. 3/40 # Failed test 'With IndependentBranches, superserials can edit a subscription from his branch' # at t/db_dependent/Serials_2.t line 106. # got: '0' # expected: '1' # Failed test 'With IndependentBranches, superserials can edit a subscription from another branch' # at t/db_dependent/Serials_2.t line 109. # got: '0' # expected: '1' # Failed test 'With IndependentBranches, superserials can show a subscription from his branch' # at t/db_dependent/Serials_2.t line 112. # got: '0' # expected: '1' # Failed test 'With IndependentBranches, superserials can show a subscription from another branch' # at t/db_dependent/Serials_2.t line 115. # got: '0' # expected: '1' # Failed test 'With IndependentBranches, edit_subscription can edit a subscription from his branch' # at t/db_dependent/Serials_2.t line 121. # got: '0' # expected: '1' # Failed test 'With IndependentBranches, show_subscription can show a subscription from his branch' # at t/db_dependent/Serials_2.t line 127. # got: '0' # expected: '1' # Failed test 'With IndependentBranches, renew_subscription can show a subscription from his branch' # at t/db_dependent/Serials_2.t line 141. # got: '0' # expected: '1' # Failed test 'Without IndependentBranches, superserials can edit a subscription from his branch' # at t/db_dependent/Serials_2.t line 166. # got: '0' # expected: '1' # Failed test 'Without IndependentBranches, superserials can edit a subscription from another branch' # at t/db_dependent/Serials_2.t line 169. # got: '0' # expected: '1' # Failed test 'Without IndependentBranches, superserials can show a subscription from his branch' # at t/db_dependent/Serials_2.t line 172. # got: '0' # expected: '1' # Failed test 'Without IndependentBranches, superserials can show a subscription from another branch' # at t/db_dependent/Serials_2.t line 175. # got: '0' # expected: '1' # Failed test 'Without IndependentBranches, edit_subscription can edit a subscription from his branch' # at t/db_dependent/Serials_2.t line 180. # got: '0' # expected: '1' # Failed test 'Without IndependentBranches, edit_subscription can edit a subscription from another branch' # at t/db_dependent/Serials_2.t line 183. # got: '0' # expected: '1' # Failed test 'Without IndependentBranches, show_subscription can show a subscription from his branch' # at t/db_dependent/Serials_2.t line 186. # got: '0' # expected: '1' # Failed test 'Without IndependentBranches, show_subscription can show a subscription from another branch' # at t/db_dependent/Serials_2.t line 189. # got: '0' # expected: '1' # Failed test 'Without IndependentBranches, renew_subscription cannot show a subscription from his branch' # at t/db_dependent/Serials_2.t line 200. # got: '0' # expected: '1' # Failed test 'Without IndependentBranches, renew_subscription cannot show a subscription from another branch' # at t/db_dependent/Serials_2.t line 203. # got: '0' # expected: '1' # Looks like you failed 17 tests of 40. t/db_dependent/Serials_2.t .. Dubious, test returned 17 (wstat 4352, 0x1100) Failed 17/40 subtests Test Summary Report ------------------- t/db_dependent/Serials_2.t (Wstat: 4352 Tests: 40 Failed: 17) Failed tests: 9-13, 15, 19, 25-32, 35-36 Non-zero exit status: 17 Files=1, Tests=40, 8 wallclock secs ( 0.01 usr 0.04 sys + 0.29 cusr 2.21 csys = 2.55 CPU) Result: FAIL ------------------------------------------------------------------------------ So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 17:36:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 16:36:37 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23692|0 |1 is obsolete| | --- Comment #33 from Fridolin SOMERS --- Created attachment 34818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34818&action=edit Bug 9351 - item type not recorded correctly in statistics for returns and some local use When returning a loan, or when returning an item for local use, the corresponding entry in the statistics table takes the item type from the bib level. This is incorrect when item-level item types is enabled. This patch corrects this problem by getting itemtype from $item->{'itype'} which comes from item or biblio level in GetItem(). Test plan : - On a catalogue with itemtype on item level, perform a return an look at statistics table - Idem for a catalogue with itemtype on biblio level -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 17:36:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 16:36:53 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 --- Comment #34 from Fridolin SOMERS --- Created attachment 34819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34819&action=edit Bug 9351 - sql update on existing statistics -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 17:37:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 16:37:20 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|11463 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 17:37:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 16:37:20 +0000 Subject: [Koha-bugs] [Bug 11463] GetItem must use item-level_itypes syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11463 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|9351 | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 17:41:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 16:41:03 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #35 from Fridolin SOMERS --- (In reply to David Cook from comment #31) > Fridolin, if you add some SQL to update the statistics, I'd be happy to sign > off on this one. Here it is. I've added a "LIMIT 1" to the query in the unlikely case the same itemnumber exists in items and deleteditems. I've also rebased first patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 18:14:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 17:14:16 +0000 Subject: [Koha-bugs] [Bug 13488] FastMmap can not be disable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13488 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 18:35:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 17:35:57 +0000 Subject: [Koha-bugs] [Bug 12849] Sending a list has malformed links In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12849 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS --- Pushed to 3.14.x, will be in 3.14.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 18:45:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 17:45:57 +0000 Subject: [Koha-bugs] [Bug 13296] error when using z3950 with UNIMARC authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13296 --- Comment #16 from Fridolin SOMERS --- Pushed to 3.14.x, will be in 3.14.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 18:51:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 17:51:18 +0000 Subject: [Koha-bugs] [Bug 12315] MTT FIX: Advanced notices are duplicated and not sent to the right patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12315 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |fridolyn.somers at biblibre.co | |m Resolution|--- |FIXED --- Comment #7 from Fridolin SOMERS --- Bug 10833 is only since 3.16 so this patch is not needed for 3.14 and below. I set as fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 19:01:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 18:01:37 +0000 Subject: [Koha-bugs] [Bug 12596] Backdating returns with SpecifiyReturnDate causes fines for items not overdue! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12596 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #12 from Fridolin SOMERS --- Pushed to 3.14.x, will be in 3.14.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 20:17:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 19:17:52 +0000 Subject: [Koha-bugs] [Bug 13017] Login page image replacement technique fails when browser width exceeds 2000 pixels In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13017 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #7 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 20:21:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 19:21:06 +0000 Subject: [Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #25 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 22:08:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 21:08:00 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Peggy Thrasher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |p.thrasher at dover.nh.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 22:33:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 21:33:21 +0000 Subject: [Koha-bugs] [Bug 13453] Koha.t daily quote tests assume sample data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13453 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 29 22:37:57 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Dec 2014 21:37:57 +0000 Subject: [Koha-bugs] [Bug 13360] C4::Ris considers that hashes are ordered In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13360 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 03:14:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 02:14:14 +0000 Subject: [Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 03:33:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 02:33:52 +0000 Subject: [Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 --- Comment #26 from Chris Cormack --- There is massive issue with this Specifically the Fix Check_Userid sub Check_Userid { - my ($uid,$member) = @_; - my $dbh = C4::Context->dbh; - my $sth = - $dbh->prepare( - "SELECT * FROM borrowers WHERE userid=? AND borrowernumber != ?"); - $sth->execute( $uid, $member ); - if ( (( $uid ne '' ) && ( my $row = $sth->fetchrow_hashref )) or - (( $uid ne '' ) && ( $uid eq C4::Context->config('user') )) ) { - return 0; - } - else { - return 1; - } + my ( $uid, $borrowernumber ) = @_; + + return 1 unless ($uid); + + return 0 if ( $uid eq C4::Context->config('user') ); + + my $rs = Koha::Database->new()->schema()->resultset('Borrower'); + + my $params; + $params->{userid} = $uid; + $params->{borrowernumber} = { '!=' => $borrowernumber } if ($borrowernumber); + + my $count = $rs->count( $params ); + + return $count ? 0 : 1; } So we return 1 if it's unique. Then we did this - $data{'userid'} = Generate_Userid($data{'borrowernumber'}, $data{'firstname'}, $data{'surname'}) if $data{'userid'} eq ''; + $data{'userid'} = Generate_Userid( $data{'borrowernumber'}, $data{'firstname'}, $data{'surname'} ) + if ( $data{'userid'} eq '' || Check_Userid( $data{'userid'} ) ); Which says essentially, if it is unique .. don't use it, if it isn't unique .. then use it. (and the db insert then fails). So we can insert borrowers who have a unique userid, but it will never use that userid it will generate one. Quite broken. Patch to follow -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 03:42:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 02:42:27 +0000 Subject: [Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 03:42:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 02:42:31 +0000 Subject: [Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 --- Comment #27 from Chris Cormack --- Created attachment 34820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34820&action=edit BUg 1861 : There is a problem introduced with an earlier patch, on this patchset - $data{'userid'} = Generate_Userid($data{'borrowernumber'}, $data{'firstname'}, $data{'surname'}) if $data{'userid'} eq ''; + $data{'userid'} = Generate_Userid( $data{'borrowernumber'}, $data{'firstname'}, $data{'surname'} ) + if ( $data{'userid'} eq '' || Check_Userid( $data{'userid'} ) ); Check_Userid returns 1 if it is unique. So this means unique userids will always be discarded and new ones created. This is why all the tests depending on a userid are now failing To test 1/ run perl t/db_dependent/Serials_2.t 2/ Notice lots of tests fail 3/ OR Add a borrower with a userid set, notice the userid is ignored and one is generated instead 4/ Apply patch 5/ Add a new borrower, notice the userid sticks (if it is unique) 6/ Run perl t/db_dependent/Serials_2.t notice tests pass 7/ Run perl t/db_dependent/Members.t notice tests still pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 08:59:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 07:59:33 +0000 Subject: [Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 --- Comment #28 from Martin Renvoize --- Pants, how did I miss this. Good catch Chris! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 09:04:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 08:04:50 +0000 Subject: [Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 09:04:56 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 08:04:56 +0000 Subject: [Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34820|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize --- Created attachment 34821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34821&action=edit Bug 1861 [SIGNED OFF]: There is a problem introduced with an earlier patch, on this patchset - $data{'userid'} = Generate_Userid($data{'borrowernumber'}, $data{'firstname'}, $data{'surname'}) if $data{'userid'} eq ''; + $data{'userid'} = Generate_Userid( $data{'borrowernumber'}, $data{'firstname'}, $data{'surname'} ) + if ( $data{'userid'} eq '' || Check_Userid( $data{'userid'} ) ); Check_Userid returns 1 if it is unique. So this means unique userids will always be discarded and new ones created. This is why all the tests depending on a userid are now failing To test 1/ run perl t/db_dependent/Serials_2.t 2/ Notice lots of tests fail 3/ OR Add a borrower with a userid set, notice the userid is ignored and one is generated instead 4/ Apply patch 5/ Add a new borrower, notice the userid sticks (if it is unique) 6/ Run perl t/db_dependent/Serials_2.t notice tests pass 7/ Run perl t/db_dependent/Members.t notice tests still pass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 09:30:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 08:30:49 +0000 Subject: [Koha-bugs] [Bug 10337] UT: The unit tests cannot be launched by everyone In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- I'm wondering if https://metacpan.org/pod/DBIx::Class::Fixtures may actaully be a nicer way to impliment this now? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 09:52:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 08:52:55 +0000 Subject: [Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 09:53:01 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 08:53:01 +0000 Subject: [Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34821|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart --- Created attachment 34822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34822&action=edit Bug 1861 [SIGNED OFF]: There is a problem introduced with an earlier patch, on this patchset - $data{'userid'} = Generate_Userid($data{'borrowernumber'}, $data{'firstname'}, $data{'surname'}) if $data{'userid'} eq ''; + $data{'userid'} = Generate_Userid( $data{'borrowernumber'}, $data{'firstname'}, $data{'surname'} ) + if ( $data{'userid'} eq '' || Check_Userid( $data{'userid'} ) ); Check_Userid returns 1 if it is unique. So this means unique userids will always be discarded and new ones created. This is why all the tests depending on a userid are now failing To test 1/ run perl t/db_dependent/Serials_2.t 2/ Notice lots of tests fail 3/ OR Add a borrower with a userid set, notice the userid is ignored and one is generated instead 4/ Apply patch 5/ Add a new borrower, notice the userid sticks (if it is unique) 6/ Run perl t/db_dependent/Serials_2.t notice tests pass 7/ Run perl t/db_dependent/Members.t notice tests still pass Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 09:53:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 08:53:17 +0000 Subject: [Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 --- Comment #31 from Jonathan Druart --- Created attachment 34823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34823&action=edit Bug 1861: Add 1 test to AddMember Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 10:18:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 09:18:48 +0000 Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34713|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize --- Created attachment 34824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34824&action=edit [PASSED QA] Bug - 5511: [Followup]: QA Fixes - Move database update entry to correct spot - Fix version number in database update - Fix capitalization in sys pref description - Fix sequence in sysprefs.sql Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 10:25:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 09:25:09 +0000 Subject: [Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed by Module Maintainer --- Comment #32 from Martin Renvoize --- Pushed followups to Module Maintainers Branch - https://github.com/mrenvoize/Koha/tree/authentication -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 10:25:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 09:25:27 +0000 Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed by Module Maintainer --- Comment #35 from Martin Renvoize --- Pushed to Module Maintainers Branch - https://github.com/mrenvoize/Koha/tree/authentication -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 10:30:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 09:30:19 +0000 Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Component|System Administration |Templates Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | --- Comment #2 from Katrin Fischer --- We just ran into this again, giving it a little nudge :) In Germany I think it would be: We don't use at the moment, I think often the part that would be street type is already part of the street name (-gasse, -stra?e). The state is not needed for addresses within Germany. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 10:40:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 09:40:41 +0000 Subject: [Koha-bugs] [Bug 13499] New: Auth.pm needs a tidy Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13499 Bug ID: 13499 Summary: Auth.pm needs a tidy Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org It's rather challenging to read and understand what's going on in Auth.pm, as a first stage to some clean up in there, I propose a non-destructive perltidy of the file. By non-destructive, I mean a perltidy with our normal rules minus any line break changes, thus allowing a 'git blame -w' to return the same results before and after the tidy, maintaining history. This should basically reset all indenting, making for an easier to read file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 10:45:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 09:45:45 +0000 Subject: [Koha-bugs] [Bug 7754] displaying the number of days a document is late In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7754 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|adrien.saurat at biblibre.com |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 10:45:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 09:45:54 +0000 Subject: [Koha-bugs] [Bug 7754] displaying the number of days a document is late In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7754 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 10:52:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 09:52:15 +0000 Subject: [Koha-bugs] [Bug 13499] Auth.pm needs a tidy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13499 --- Comment #1 from Martin Renvoize --- Created attachment 34825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34825&action=edit Bug 13499: Tidy of Auth.pm This tidy should only change whitespace and not line breaks, thus retaining history. There are no code changes, and thus there should be no regressions to test for koha wise. To test the non-destrcutive nature of the patch, run a 'git blame -w' on the file before and after the patch, they should read the same. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 11:04:38 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 10:04:38 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 --- Comment #23 from Jacek Ablewicz --- Created attachment 34826 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34826&action=edit Bug 13431 [QA Follow-up]: Shared FastMmap file causes issues 1) Removed 'use C4::Context;' because it can lead to introduction of circular reference in the near future 2) Put fastmmap initialization code into an eval {} block, to catch various kinds of errors which can still occur during it's init in some [less usual] Koha setups and/or more unusual circumstances 3) Do not include UID in the sharefile name (it will be constructed using namespace + database name + database host instead). Test plan addendum: s/and UID// -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 11:05:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 10:05:11 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 11:20:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 10:20:10 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #599 from Martin Renvoize --- Testing feedback spreadsheet available at: https://docs.google.com/a/ptfs-europe.com/spreadsheets/d/1EcBAPmPAF0L95uYxWtRcnV9n1sD78IAxTHW2N-9u2K0/edit#gid=0 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 14:13:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 13:13:21 +0000 Subject: [Koha-bugs] [Bug 13500] New: Batch item modification tool don't let you delete or set to 0 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13500 Bug ID: 13500 Summary: Batch item modification tool don't let you delete or set to 0 Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: pablo.bianchi at gmail.com QA Contact: testopia at bugs.koha-community.org Since the upgrade to Koha 3.18 our librarians can't use Batch item modification tool as always. They can change values from something different to "0" to something different to "0", but no change the value to zero or remove the subfield. How to test: 1) Go to Batch item modification tool (for eg http://demo-intra.mykoha.co.nz/cgi-bin/koha/tools/batchMod.pl ) 2) Paste a barcode (eg 528, ?The ringmaster's secret?, without hold/loan). 3) Change for example $7 (Not for loan) and/or $8 (Collection code) to a !=0 value, lets say Ordered and Non fiction. 4) Repeat same procedure but now delete subfields. 5) Subfield is not removed. Same thing if you have an authorized value "0" and try to change to that value. Changing from !=0 to !=0 works fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 14:14:42 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 13:14:42 +0000 Subject: [Koha-bugs] [Bug 13457] Suggestions.t expects sample itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13457 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 14:18:18 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 13:18:18 +0000 Subject: [Koha-bugs] [Bug 13457] Suggestions.t expects sample itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13457 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34575|0 |1 is obsolete| | --- Comment #9 from Paola Rossi --- Created attachment 34827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34827&action=edit [PASSED QA] Bug 13457: Suggestions.t expects sample itemtypes I've applied the patches against master 3.19.00.003 head 13252. Everything worked as required. I pass the patch to "Signed Off" status. ---------------------------------------------------------------------------- This was the error expected at step 2) (RIGHT, error as expected) prove t/db_dependent/Suggestions.t t/db_dependent/Suggestions.t .. 1/97 Can't call method "default_privacy" on an undefined value at [....]/C4/Members.pm line 874. # Looks like you planned 97 tests but ran 2. # Looks like your test exited with 255 just after 2. t/db_dependent/Suggestions.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 95/97 subtests Test Summary Report ------------------- t/db_dependent/Suggestions.t (Wstat: 65280 Tests: 2 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 97 tests but ran 2. Files=1, Tests=2, 1 wallclock secs ( 0.00 usr 0.03 sys + 0.40 cusr 0.71 csys = 1.14 CPU) Result: FAIL -------------------------------------------------------- This was the test required at the 4) and 6) steps (RIGHT): prove t/db_dependent/Suggestions.t t/db_dependent/Suggestions.t .. ok All tests successful. Files=1, Tests=97, 1 wallclock secs ( 0.00 usr 0.02 sys + 0.82 cusr 0.22 csys = 1.06 CPU) Result: PASS ---------------------------------------------------------------------------- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 14:18:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 13:18:53 +0000 Subject: [Koha-bugs] [Bug 13457] Suggestions.t expects sample itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13457 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34595|0 |1 is obsolete| | --- Comment #10 from Paola Rossi --- Created attachment 34828 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34828&action=edit Bug 13457 - Followup for CPL and S codes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 15:12:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 14:12:27 +0000 Subject: [Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 --- Comment #9 from Martin Renvoize --- Created attachment 34829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34829&action=edit Bug 12954: Failed login should retain anonymous session A failed login should not leave the user in a half logged authenticated state, but rather return them to an anonymouse session as per the pre-login attempt state. To replicate error: 1. Try to log in with some nonexisting user id or wrong password in the OPAC 2. Go directly to /opac-user.pl (e.g., enter it in the browser address bar, or just click on the "Log in" link) 3. Observe a DBI error displayed on the screen 4. You are now in the "deadloop" of sorts (opac/opac-user.pl refuses to display the login screen, no matter how many times you try to reload it); to break the deadloop, one needs to: - remove session cookie from the browser (or cause the session to expire in some other way - closing browser window would be probably enough for that) - remove offending session on the server (from mysql sessions table, ..) - log in with proper credentials using some other page (like opac/opac-main.pl right-side panel), which does not involve opac/opac-user.pl being called without "userid" CGI parameter. To test: 1. Test as above, the DBI error should no longer be present 2. Check that search history works across failed and sucessful login attempts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 15:12:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 14:12:52 +0000 Subject: [Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 15:15:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 14:15:19 +0000 Subject: [Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34829|Bug 12954: Failed login |[Alternate Patch] Bug description|should retain anonymous |12954: Failed login should |session |retain anonymous session --- Comment #10 from Martin Renvoize --- Comment on attachment 34829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34829 [Alternate Patch] Bug 12954: Failed login should retain anonymous session I've submitted an alternate patch, as the original broke cross login attempt anonymous search history. It took a while to get my head around the code, but actually it looks to be a more trivial patch than initially submitted. I've based my patch on the Tidied Auth.pm available in bug 13499 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 15:15:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 14:15:52 +0000 Subject: [Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13499 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 15:15:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 14:15:52 +0000 Subject: [Koha-bugs] [Bug 13499] Auth.pm needs a tidy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13499 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12954 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 15:19:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 14:19:53 +0000 Subject: [Koha-bugs] [Bug 13500] Batch item modification tool don't let you delete or set to 0 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13500 Pablo AB changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 15:49:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 14:49:31 +0000 Subject: [Koha-bugs] [Bug 13501] New: Allow autocompletion on drop-down lists Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Bug ID: 13501 Summary: Allow autocompletion on drop-down lists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Some users have very long lists of authorised values. It could be painful to pick a value in such lists with a simple drop-down list. Following patches will allow to type some text in order to filter these values and pick the good one easily. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 15:51:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 14:51:06 +0000 Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 --- Comment #1 from Julian Maurice --- Created attachment 34830 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34830&action=edit Bug 13501: Add jQuery UI plugin combobox It allows autocompletion on selects. Based on http://jqueryui.com/autocomplete/#combobox Note: This patch reset $.fn.button to the jQuery UI one (was overwritten by Bootstrap) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 15:51:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 14:51:09 +0000 Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 --- Comment #2 from Julian Maurice --- Created attachment 34831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34831&action=edit Bug 13501: Use combobox plugin on cataloguing and batch items edit pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 15:51:31 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 14:51:31 +0000 Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 18:25:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 17:25:06 +0000 Subject: [Koha-bugs] [Bug 13500] Batch item modification tool don't let you delete or set to 0 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13500 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Pablo, there has been a similar bug in item editing that was fixed in 3.18.2 - are you running the latest version? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 19:09:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 18:09:41 +0000 Subject: [Koha-bugs] [Bug 13500] Batch item modification tool don't let you delete or set to 0 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13500 --- Comment #2 from Pablo AB --- Hi Katrin! Exactly, I was using 3.18.1, now with 3.18.2 the problem is solved :) So this could be closed (closed fixed?). Happy new year! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 19:21:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 18:21:17 +0000 Subject: [Koha-bugs] [Bug 13500] Batch item modification tool don't let you delete or set to 0 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13500 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Katrin Fischer --- Cool, glad the update fixed it! Happy new year! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 19:33:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 18:33:08 +0000 Subject: [Koha-bugs] [Bug 6804] If IndependantBranches and AutoLocation enabled, OPAC login does not redirect properly outside IP range In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6804 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- Looks like this has completely fallen off the radar... do we know if it's still a bug in current master? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 19:35:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 18:35:06 +0000 Subject: [Koha-bugs] [Bug 6804] If IndependantBranches and AutoLocation enabled, OPAC login does not redirect properly outside IP range In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6804 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 19:44:41 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 18:44:41 +0000 Subject: [Koha-bugs] [Bug 8785] Basic authentication troubleshootings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8785 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #1 from Martin Renvoize --- Is anyone using http basic auth with koha in the wild I wonder? I'm trying to go through old auth bugs and work out if they're still relevant... Matthias, any comments regarding the current state of this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 19:46:30 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 18:46:30 +0000 Subject: [Koha-bugs] [Bug 8865] Re-logging in needs to pass POST & GET arguments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8865 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #1 from Martin Renvoize --- Is this still relevant at all Kyle.. or is this one a good condidate for tidy up? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 19:59:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 18:59:36 +0000 Subject: [Koha-bugs] [Bug 12548] Auth::checkauth() needs more in-line comments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12548 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org, | |martin.renvoize at ptfs-europe | |.com Component|Documentation |Authentication -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 20:01:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 19:01:11 +0000 Subject: [Koha-bugs] [Bug 12548] Auth::checkauth() needs more in-line comments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12548 --- Comment #1 from Martin Renvoize --- Switched to authentication module as I feel inline code documentaiton should come under the specific module and I wanted it to turn up in my Authentcation Module Maintainer search ;). I agree Auth.pm needs better inline documentation, and I intend to add it during this cycle given the time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 20:02:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 19:02:55 +0000 Subject: [Koha-bugs] [Bug 12548] Auth::checkauth() needs more in-line comments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12548 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13499 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 20:02:55 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 19:02:55 +0000 Subject: [Koha-bugs] [Bug 13499] Auth.pm needs a tidy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13499 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12548 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 21:57:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 20:57:22 +0000 Subject: [Koha-bugs] [Bug 13413] Koha::Log - an attempt to have sane logging in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13413 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8190 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 21:57:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 20:57:22 +0000 Subject: [Koha-bugs] [Bug 8190] Add a logging module to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13413 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 21:58:13 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 20:58:13 +0000 Subject: [Koha-bugs] [Bug 13502] New: A bug was introduced by 1861 - meaning borrowers sometimes cant be added Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13502 Bug ID: 13502 Summary: A bug was introduced by 1861 - meaning borrowers sometimes cant be added Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: chris at bigballofwax.co.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Bug 1861 introduces some changes, Which is breaking some tests, and might break functional code also. DBD::mysql::st execute failed: Duplicate entry '' for key 'userid' at /srv/jenkins/workspace/Koha_3.18.x_U14/C4/SQLHelper.pm line 184. etc. This is caused by my $borrowernumber1 = AddMember(categorycode => $categorycode, branchcode => $branchcode); And then in the AddMember sub we do $data{'userid'} = Generate_Userid( $data{'borrowernumber'}, $data{'firstname'}, $data{'surname'} ) if ( $data{'userid'} eq '' || !Check_Userid( $data{'userid'} ) ); The problem here is if $data{'userid'} is undef the if fails and we don't create a new userid. ANd since the changes in bug 1861 make this column unique everything ASPLODES! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 21:59:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 20:59:06 +0000 Subject: [Koha-bugs] [Bug 13502] A bug was introduced by 1861 - meaning borrowers sometimes cant be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13502 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |1861 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 21:59:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 20:59:06 +0000 Subject: [Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13502 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 22:10:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 21:10:03 +0000 Subject: [Koha-bugs] [Bug 13502] A bug was introduced by 1861 - meaning borrowers sometimes cant be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13502 --- Comment #1 from Chris Cormack --- This is because we do this sub Check_Userid { my ( $uid, $borrowernumber ) = @_; return 1 unless ($uid); And 1 means unique .. so we do Check_Userid ... it tells us, yes its unique .. This is wrong we should return 0 here. If it is empty, assume it is non unique. This is a change in behaviour introduced by 1861. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 22:24:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 21:24:22 +0000 Subject: [Koha-bugs] [Bug 13502] A bug was introduced by 1861 - meaning borrowers sometimes cant be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13502 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 22:24:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 21:24:25 +0000 Subject: [Koha-bugs] [Bug 13502] A bug was introduced by 1861 - meaning borrowers sometimes cant be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13502 --- Comment #2 from Chris Cormack --- Created attachment 34832 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34832&action=edit Bug 13502 : Code introcduced in 1861 wrongly assumes a null userid is unique To test 1/ Create a borrower with '' as their userid, you may have to edit a row in the db to do this 2/ Run perl t/db_dependent/Circulation/CheckIfIssuedToPatron.t 3/ Notice some tests fail and you see DBD::mysql::st execute failed: Duplicate entry '' for key 'userid' at /home/chrisc/git/catalyst-koha/C4/SQLHelper.pm line 184. 4/ Apply the patch 5/ Run the tests again, notice they now pass -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 22:25:37 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 21:25:37 +0000 Subject: [Koha-bugs] [Bug 13357] Untranslatable strings on itemsearch.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13357 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #8 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 22:26:19 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 21:26:19 +0000 Subject: [Koha-bugs] [Bug 13124] Record titles with parentheses causing label weirdness In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #16 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 22:27:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 21:27:32 +0000 Subject: [Koha-bugs] [Bug 13285] updatedatabase throws an error if opacthemes is not set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13285 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #7 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 22:28:53 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 21:28:53 +0000 Subject: [Koha-bugs] [Bug 9958] RoutingSerials description misleading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9958 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #8 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 22:30:05 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 21:30:05 +0000 Subject: [Koha-bugs] [Bug 13458] Add new patron shows default / hardcoded patron categories after search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #7 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 22:41:32 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 21:41:32 +0000 Subject: [Koha-bugs] [Bug 12895] Dropbox mode doesn't work correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12895 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #13 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 22:45:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 21:45:20 +0000 Subject: [Koha-bugs] [Bug 13447] runreport.pl html email fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13447 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 22:46:39 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 21:46:39 +0000 Subject: [Koha-bugs] [Bug 13341] Hard-coded "Preview" text in OPAC openlibrary.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 30 23:39:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Dec 2014 22:39:46 +0000 Subject: [Koha-bugs] [Bug 13413] Koha::Log - an attempt to have sane logging in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13413 --- Comment #5 from Martin Renvoize --- Agreed we need logging, and I'm fairly happy with the implimentation here.. However, I'd like some clear comparisons drawn to the work corried out in bug 8190 and how this patch may or may not solve the issues raised there. I don't want this bug to end up again in a long 'In Discussion' dead end, but it would be good to know why you feel this is a better aproach so we can sell it to the community as a whole :) Thanks for the work so far Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 06:14:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 05:14:58 +0000 Subject: [Koha-bugs] [Bug 13413] Koha::Log - an attempt to have sane logging in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13413 --- Comment #6 from Srdjan Jankovic --- * For some reason when I started this work, I did not see bug 8190 when I searched. Horrible omission, no excuses. * bug 8190 is a bit wider, and this replaces only one part of it (the logging module itself). If this is chosen, bug 8190 can easily be reworked to use this logger instead of its own implementation. Now comparison: * Log::LogLite seems to be limited to logging to a file only. To me it is a serious limitation, so if we wanted to extend it to support multiple sinks, we'd need to roll our sleeves. Nothing bad in that, but still. An example would be logging to the standard sink (a file or syslog) and sending error emails, eg "log me at info level, but email me errors". * What really attracted me to Log::Contextual was the use of code blocks to log, so complex debugging can be left in without any performance penalty (as stated in the pod). Although some may argue it is confusing. * There are some fancy stuff one could do (temp logger etc), but that should not be taken in account when making decision, basic stuff is more important. I suggest some people go over this implementation of Koha::Log, and bug 8190 implementation of Koha::Utils::Logger, and decide which one is a better fit. There are also other interesting points for discussion, but no point bringing those up before we decide if tis is a go or no go. In that respect this patch is intentionally minimal, and leaves hairy issues where/how to introduce it in the web app out. Having said that, it was implemented with intention to be able to fit both in central point (Context), the individual scripts and library modules at the same time - ie some best practices should be drawn, but nothing will break if you use it in anger. The starting point was that I needed a cron job logger, and I put some more effort in hope it may find wider use. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 07:53:35 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 06:53:35 +0000 Subject: [Koha-bugs] [Bug 9055] Mandumah.com's multiple branch search, multiple branch security mod In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9055 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #26 from Martin Renvoize --- At over a year since the last comment, is anyone still using/working on this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 07:59:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 06:59:48 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #1 from Martin Renvoize --- Verifying this is still an issue in current master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 08:02:25 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 07:02:25 +0000 Subject: [Koha-bugs] [Bug 5441] SSO CAS improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5441 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #2 from Martin Renvoize --- Is this still relevant Paul? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 08:07:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 07:07:04 +0000 Subject: [Koha-bugs] [Bug 3511] Integration with Moodle In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3511 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |INVALID --- Comment #2 from Martin Renvoize --- As suggested above, I believe on the authetncation front that we can interoperate nicely with Moodle now (With, both CAS and Shibboleth support). If we want more in depth Moodle integration, then I believe that should be opened as it's own bug with a clear definition of what people are wanting/aiming to achieve. Marking this bug RESOLVED INVALID -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 08:10:47 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 07:10:47 +0000 Subject: [Koha-bugs] [Bug 12227] remove demo user functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #1 from Martin Renvoize --- I spotted this code recently and can only agree that it's a nasty case, with agreement I'de be more than happy to strip it out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 08:16:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 07:16:51 +0000 Subject: [Koha-bugs] [Bug 12547] Create better API for handling external authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12547 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- I am slowly on the case here.. starting with a non-destructive tidy of the code found in bug 13499. The aim is to Tidy -> Document -> Write Tests -> Refactor -> Rewrite over a long period... even if I only get steps one and two done I'd be pretty happy that we're moving forward. Fancy verifying that my tidy actually improves things and maintain git blame history David? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 08:19:00 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 07:19:00 +0000 Subject: [Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #11 from M. Tompsett --- The test plan needs to include combinations: - username/password - cardnumber/password - bad username/password - username/bad password - cardnumber/bad password -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 08:20:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 07:20:12 +0000 Subject: [Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 --- Comment #12 from M. Tompsett --- (In reply to Martin Renvoize from comment #7) > > + $info{'timed_out'} = 1 if $lasttime; > > This feels unrelated to me, as such I'de rather see it in it's own bug > rather than confusing the issue here. I agree, please make another bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 08:26:51 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 07:26:51 +0000 Subject: [Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 --- Comment #13 from M. Tompsett --- Comment on attachment 34551 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34551 Bug 12954 - Questionable logic regarding session handling in C4::Auth::checkauth() Review of attachment 34551: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12954&attachment=34551) ----------------------------------------------------------------- ::: C4/Auth.pm @@ +1060,5 @@ > + if ($session) { > + $session->delete(); > + $session->flush; > + } > + C4::Context->_unset_userenv($sessionID) if $sessionID; I'm not sure moving this outside the if ($userid) check is right. I vaguely recall strangeness with all the 5 test cases that I recommended when I was testing a custom authentication for our organization in terms of setting of userid and return and sessionID. I haven't tried this, but this code change seems wrong to me. I'll possibly attempt later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 08:30:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 07:30:27 +0000 Subject: [Koha-bugs] [Bug 12548] Auth::checkauth() needs more in-line comments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12548 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13503 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 08:30:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 07:30:27 +0000 Subject: [Koha-bugs] [Bug 13499] Auth.pm needs a tidy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13499 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13503 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 08:30:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 07:30:27 +0000 Subject: [Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13503 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 08:30:27 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 07:30:27 +0000 Subject: [Koha-bugs] [Bug 13503] New: Auth.pm needs tests Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13503 Bug ID: 13503 Summary: Auth.pm needs tests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Depends on: 13499 Blocks: 12548, 12954 Auth.pm needs more thorough and extensive tests before any kind of re-factoring can be attempted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 08:31:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 07:31:16 +0000 Subject: [Koha-bugs] [Bug 13503] Auth.pm needs tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13503 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|12548, 12954 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 08:31:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 07:31:16 +0000 Subject: [Koha-bugs] [Bug 12548] Auth::checkauth() needs more in-line comments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12548 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|13503 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 08:31:16 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 07:31:16 +0000 Subject: [Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|13503 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 10:02:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 09:02:33 +0000 Subject: [Koha-bugs] [Bug 13413] Koha::Log - an attempt to have sane logging in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13413 --- Comment #7 from Martin Renvoize --- Thanks for your quick reply, and good explanation Srdjan. I think I agree that I prefer the logging capabilities given using Log::Contextual, and love the code blocks for efficiency. I'de love to see this as a starting point for moving towards the more expansive implementation as conceived in bug 8190.. I'm going to test a bit now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 11:20:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 10:20:07 +0000 Subject: [Koha-bugs] [Bug 13502] A bug was introduced by 1861 - meaning borrowers sometimes cant be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13502 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- Chris, With all patches from bug 1861, I don't get the error: mysql> select count(*) from borrowers where userid=""; +----------+ | count(*) | +----------+ | 1 | +----------+ 1 row in set (0.01 sec) $ prove t/db_dependent/Circulation/CheckIfIssuedToPatron.t t/db_dependent/Circulation/CheckIfIssuedToPatron.t .. ok All tests successful. Files=1, Tests=22, 2 wallclock secs ( 0.04 usr 0.00 sys + 1.34 cusr 0.04 csys = 1.42 CPU) Result: PASS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 11:21:46 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 10:21:46 +0000 Subject: [Koha-bugs] [Bug 13167] Stage MARC for Import hangs for biblio containing valid 979* ISBN-13 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 --- Comment #12 from Colin Campbell --- (In reply to Nick Clemens from comment #10) > Marking as signed off, it looks like that was Colin's intention It was indeed. Just adding that this is not UNIMARC specific ouurs im marc21 too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 11:25:33 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 10:25:33 +0000 Subject: [Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 --- Comment #14 from Martin Renvoize --- Any chance you could look at my alternative patch too Mark... I would fail qa on the first patch as it broke cross login attempt anonymous search history for me.. which is a regression, I left it there initially so people could see the difference between aproaches adn check whether I'de missed any fringe cases. Test plan: We need to test for the DBI error, and whether search history if maintained accross the login/failed login boundary. Before Patch: Good username / Good password = Login with history maintained Good cardnumber / Good password = Login with history maintained Good username / Bad password = DBI Error Good cardnumber / Bad password = DBI Error Bad username / Good password = DBI Error Bad cardnumber / Good password = DBI Error After Patch: Good username / Good password = Login with history maintained Good cardnumber / Good password = Login with history maintained Good username / Bad password = Bad password error, anon search history maintained Good cardnumber / Bad password = Bad password error, anon search history maintained Bad username / Good password = Bad password error, anon search history maintained Bad cardnumber / Good password = Bad password error, anon search history maintained -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 11:38:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 10:38:06 +0000 Subject: [Koha-bugs] [Bug 13413] Koha::Log - an attempt to have sane logging in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13413 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 11:49:10 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 10:49:10 +0000 Subject: [Koha-bugs] [Bug 13502] A bug was introduced by 1861 - meaning borrowers sometimes cant be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13502 --- Comment #4 from Chris Cormack --- Have you run the db updates? It won't manifest without it, if you check jenkins you can see it failing there too. Also the assumption that an undefined userid is unique is flawed. It's 12 mins until 2015 so happy new year. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 12:00:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 11:00:02 +0000 Subject: [Koha-bugs] [Bug 13502] A bug was introduced by 1861 - meaning borrowers sometimes cant be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13502 --- Comment #5 from Jonathan Druart --- (In reply to Chris Cormack from comment #4) > Have you run the db updates? It won't manifest without it, if you check > jenkins you can see it failing there too. Also the assumption that an > undefined userid is unique is flawed. > > It's 12 mins until 2015 so happy new year. Ha no, sorry about that! Happy new year Chris :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 12:00:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 11:00:12 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34332|0 |1 is obsolete| | --- Comment #100 from Colin Campbell --- Created attachment 34833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34833&action=edit rebased patch Patch rebased against master also fixes the omission of the shipping budget syspref from updatedatabase and incorporates small change to Koha::EDI so that single copies are added using the same codepath as multiple copies. Fixes a bug raised by Staffs University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 12:13:52 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 11:13:52 +0000 Subject: [Koha-bugs] [Bug 13502] A bug was introduced by 1861 - meaning borrowers sometimes cant be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13502 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 12:13:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 11:13:54 +0000 Subject: [Koha-bugs] [Bug 13502] A bug was introduced by 1861 - meaning borrowers sometimes cant be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13502 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34832|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 34834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34834&action=edit Bug 13502 : Code introcduced in 1861 wrongly assumes a null userid is unique To test 1/ Create a borrower with '' as their userid, you may have to edit a row in the db to do this 2/ Run perl t/db_dependent/Circulation/CheckIfIssuedToPatron.t 3/ Notice some tests fail and you see DBD::mysql::st execute failed: Duplicate entry '' for key 'userid' at /home/chrisc/git/catalyst-koha/C4/SQLHelper.pm line 184. 4/ Apply the patch 5/ Run the tests again, notice they now pass Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 12:13:59 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 11:13:59 +0000 Subject: [Koha-bugs] [Bug 13502] A bug was introduced by 1861 - meaning borrowers sometimes cant be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13502 --- Comment #7 from Jonathan Druart --- Created attachment 34835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34835&action=edit Bug 13502: Add tests to highlight the problem Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 12:15:07 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 11:15:07 +0000 Subject: [Koha-bugs] [Bug 13502] A bug was introduced by 1861 - meaning borrowers sometimes cant be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13502 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34835|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 34836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34836&action=edit Bug 13502: Add tests to highlight the problem Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 13:04:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 12:04:45 +0000 Subject: [Koha-bugs] [Bug 8190] Add a logging module to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18880|0 |1 is obsolete| | --- Comment #112 from Jonathan Druart --- Created attachment 34837 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34837&action=edit Bug 8190: Koha::Utils::Logger, Logging module Use the logger like: $logger= C4::Context->logger; $logger->debug("This is a debug message"); $logger->info("This is an information"); $logger->error("This is an error !"); The Logger constructor can take an hash reference with "file" and "level" to define a filepath or a log level. For a log level >= warning, a call stack is printed. Prerequisite: - set an environment variable KOHA_LOG in your virtual host: SetEnv KOHA_LOG /home/koha/var/log/opac.log - set a write flag for www-data on this file Please have a look at t/Logger.t for more details. Includes (apparently from squashed patches): Bug 8190: Followup Logger: FIX perlcritic Bug 8190 - Followup - Add cached logger, output messages to template * Add C4::Context->logger * Embed logged messages to a comment in the template html, controlled by the system preference LogToHtmlComments\ * Add both new system preferences to sysprefs.sql Bug 8190 follow-up moving updatedatabase part at the right place Signed-off-by: Mason James Signed-off-by: Kyle M Hall Signed-off-by: Paul Poulain Signed-off-by: Marcel de Rooy Amended the patch for a updatedatabase problem. Edited the commit message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 13:04:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 12:04:50 +0000 Subject: [Koha-bugs] [Bug 8190] Add a logging module to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18881|0 |1 is obsolete| | --- Comment #113 from Jonathan Druart --- Created attachment 34838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34838&action=edit Bug 8190: Follow Add some POD Add POD and prefix private methods with _ Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 13:04:54 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 12:04:54 +0000 Subject: [Koha-bugs] [Bug 8190] Add a logging module to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18882|0 |1 is obsolete| | --- Comment #114 from Jonathan Druart --- Created attachment 34839 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34839&action=edit Bug 8190: raise an error if the Log::LogLite module is not installed Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 13:04:58 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 12:04:58 +0000 Subject: [Koha-bugs] [Bug 8190] Add a logging module to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18883|0 |1 is obsolete| | --- Comment #115 from Jonathan Druart --- Created attachment 34840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34840&action=edit Bug 8190: FIX Unit test Set the KOHA_LOG environment variable in the test Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 13:05:03 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 12:05:03 +0000 Subject: [Koha-bugs] [Bug 8190] Add a logging module to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18884|0 |1 is obsolete| | --- Comment #116 from Jonathan Druart --- Created attachment 34841 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34841&action=edit Bug 8190: QA Followup - Remove the private variables - Remove the use of C4::Context in the UT - Remove the Exporter Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 13:05:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 12:05:08 +0000 Subject: [Koha-bugs] [Bug 8190] Add a logging module to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18886|0 |1 is obsolete| | --- Comment #117 from Jonathan Druart --- Created attachment 34842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34842&action=edit Bug 8190: Followup - Add html embedded logs to OPAC Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 13:05:12 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 12:05:12 +0000 Subject: [Koha-bugs] [Bug 8190] Add a logging module to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18887|0 |1 is obsolete| | --- Comment #118 from Jonathan Druart --- Created attachment 34843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34843&action=edit Bug 8190: Add the 'alert' level. Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 13:05:17 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 12:05:17 +0000 Subject: [Koha-bugs] [Bug 8190] Add a logging module to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18888|0 |1 is obsolete| | --- Comment #119 from Jonathan Druart --- Created attachment 34844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34844&action=edit Bug 8190: Followup for opac-search Script should not create a second logger object, but use the one that the Auth module already made. Works fine now. Only question is: Should we leave it here. This is somewhat of a debug statement. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 13:05:21 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 12:05:21 +0000 Subject: [Koha-bugs] [Bug 8190] Add a logging module to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18890|0 |1 is obsolete| | --- Comment #120 from Jonathan Druart --- Created attachment 34845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34845&action=edit Bug 8190: FIX description and values for the LogLevel pref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 13:06:08 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 12:06:08 +0000 Subject: [Koha-bugs] [Bug 8190] Add a logging module to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #121 from Jonathan Druart --- Patches rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 13:25:14 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 12:25:14 +0000 Subject: [Koha-bugs] [Bug 13504] New: The marker '----' is not removed for CHECKIN and CHECKOUT Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13504 Bug ID: 13504 Summary: The marker '----' is not removed for CHECKIN and CHECKOUT Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org If there is only 1 item, the marker is not removed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 13:27:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 12:27:48 +0000 Subject: [Koha-bugs] [Bug 13504] The marker '----' is not removed for CHECKIN and CHECKOUT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13504 --- Comment #1 from Jonathan Druart --- Created attachment 34846 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34846&action=edit Bug 13504: Remove the '----' marker for CHECKIN and CHECKOUT notices If only 1 item exist in the message, the marker is not removed. This marker is removed by render_metadata, but this method is only called on appending. Test plan: 1/ Enable the CHECKIN and/or CHECKOUT notices for a patron 2/ check and item in or out and verify that the marker is no longer displayed in the generated notices. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 13:27:45 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 12:27:45 +0000 Subject: [Koha-bugs] [Bug 13504] The marker '----' is not removed for CHECKIN and CHECKOUT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13504 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 16:10:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 15:10:02 +0000 Subject: [Koha-bugs] [Bug 13502] A bug was introduced by 1861 - meaning borrowers sometimes cant be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13502 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34834|0 |1 is obsolete| | --- Comment #9 from Tom?s Cohen Arazi --- Created attachment 34847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34847&action=edit Bug 13502: Code introcduced in 1861 wrongly assumes a null userid is unique To test 1/ Create a borrower with '' as their userid, you may have to edit a row in the db to do this 2/ Run perl t/db_dependent/Circulation/CheckIfIssuedToPatron.t 3/ Notice some tests fail and you see DBD::mysql::st execute failed: Duplicate entry '' for key 'userid' at /home/chrisc/git/catalyst-koha/C4/SQLHelper.pm line 184. 4/ Apply the patch 5/ Run the tests again, notice they now pass Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 16:10:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 15:10:11 +0000 Subject: [Koha-bugs] [Bug 13502] A bug was introduced by 1861 - meaning borrowers sometimes cant be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13502 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34836|0 |1 is obsolete| | --- Comment #10 from Tom?s Cohen Arazi --- Created attachment 34848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34848&action=edit Bug 13502: Add tests to highlight the problem Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 17:27:04 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 16:27:04 +0000 Subject: [Koha-bugs] [Bug 13502] A bug was introduced by 1861 - meaning borrowers sometimes cant be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13502 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- I am sorry, but something here is not quite right in my tests. I applied both patches, made sure the database is current: perl t/db_dependent/Members.t ok 67 - Borrower with duplicate userid has new userid generated not ok 68 - AddMember should insert the given userid # Failed test 'AddMember should insert the given userid' # at t/db_dependent/Members.t line 305. # got: 'tomasito.none2' # expected: 'a_user_id' I had to solve a conflict in Members.t. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 17:29:34 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 16:29:34 +0000 Subject: [Koha-bugs] [Bug 13502] A bug was introduced by 1861 - meaning borrowers sometimes cant be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13502 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 17:29:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 16:29:36 +0000 Subject: [Koha-bugs] [Bug 13502] A bug was introduced by 1861 - meaning borrowers sometimes cant be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13502 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34847|0 |1 is obsolete| | Attachment #34848|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 34849 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34849&action=edit [PASSED QA] Bug 13502: Code introcduced in 1861 wrongly assumes a null userid is unique To test 1/ Create a borrower with '' as their userid, you may have to edit a row in the db to do this 2/ Run perl t/db_dependent/Circulation/CheckIfIssuedToPatron.t 3/ Notice some tests fail and you see DBD::mysql::st execute failed: Duplicate entry '' for key 'userid' at /home/chrisc/git/catalyst-koha/C4/SQLHelper.pm line 184. 4/ Apply the patch 5/ Run the tests again, notice they now pass Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 17:30:48 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 16:30:48 +0000 Subject: [Koha-bugs] [Bug 13502] A bug was introduced by 1861 - meaning borrowers sometimes cant be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13502 --- Comment #13 from Katrin Fischer --- Passing Chris' original patch - I think the additional tests needs a little bit more work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 17:56:09 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 16:56:09 +0000 Subject: [Koha-bugs] [Bug 13502] A bug was introduced by 1861 - meaning borrowers sometimes cant be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13502 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #14 from Tom?s Cohen Arazi --- Katrin, It seems you didn't run the new tests on top of the latest 1861 followups. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 17:59:28 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 16:59:28 +0000 Subject: [Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33983|[PASSED QA] Bug 1861 - |[PUSHED] Bug 1861 - Unique description|Unique patrons logins not |patrons logins not |(totally) enforced |(totally) enforced -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 17:59:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 16:59:49 +0000 Subject: [Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33984|[PASSED QA] Bug 1861 [QA |[PUSHED] Bug 1861 [QA description|Followup] - Fix |Followup] - Fix |Check_Userid and unit tests |Check_Userid and unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 18:00:15 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 17:00:15 +0000 Subject: [Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33985|[PASSED QA] Bug 1861 [QA |[PUSHED] Bug 1861 [QA description|Followup] - Don't modify |Followup] - Don't modify |userids, warn if we can't |userids, warn if we can't |modify the index |modify the index |automatically |automatically -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 18:02:23 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 17:02:23 +0000 Subject: [Koha-bugs] [Bug 13502] A bug was introduced by 1861 - meaning borrowers sometimes cant be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13502 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34848|1 |0 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 18:03:20 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 17:03:20 +0000 Subject: [Koha-bugs] [Bug 13502] A bug was introduced by 1861 - meaning borrowers sometimes cant be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13502 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34848|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 34850 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34850&action=edit [PASSED QA] Bug 13502: Add tests to highlight the problem Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 18:04:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 17:04:02 +0000 Subject: [Koha-bugs] [Bug 13502] A bug was introduced by 1861 - meaning borrowers sometimes cant be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13502 --- Comment #16 from Katrin Fischer --- With the follow-up on 1861 applied, the tests pass! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 19:40:44 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 18:40:44 +0000 Subject: [Koha-bugs] [Bug 13502] A bug was introduced by 1861 - meaning borrowers sometimes cant be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13502 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #17 from Martin Renvoize --- Katrin, your plain too efficient.. you beat me to it ;) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 19:54:02 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 18:54:02 +0000 Subject: [Koha-bugs] [Bug 11807] Add categorycode conversions to LDAP authentication. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11807 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- Agreed, Fr?d?rick could you update the patch and submit a new bug (if you wish to do so) for the date piece. I'de love to get this one moving again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 20:54:11 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 19:54:11 +0000 Subject: [Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed by Module Maintainer |Pushed to Master --- Comment #33 from Tom?s Cohen Arazi --- Followups pushed to master. Thanks Chris and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 20:54:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 19:54:49 +0000 Subject: [Koha-bugs] [Bug 13502] A bug was introduced by 1861 - meaning borrowers sometimes cant be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13502 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Chris and Jonathan! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 20:55:22 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 19:55:22 +0000 Subject: [Koha-bugs] [Bug 12823] Add some hints for Host, Database and SRU search fields mappings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 20:55:50 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 19:55:50 +0000 Subject: [Koha-bugs] [Bug 12896] Move the bookseller-related code into its own module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12896 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #34 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 21:04:36 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 20:04:36 +0000 Subject: [Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #76 from Tom?s Cohen Arazi --- Jonathan and Zeno, it seems that the tests that run fine on Perl 5.18 are failing for 5.20, and vice-versa. So we need to make a decision. I think it is a sign of the need for this tests (in the sense that they are already catching something), but in order to push the UTF8 ASAP I'd like you to take a look at the situation. We can get rid of my patch, I don't care, but tests certaintly pass with it, and fail without it on 14.04. During the next days I'll install a Jesee box to try the behaviour Jonathan talks about. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 21:05:06 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 20:05:06 +0000 Subject: [Koha-bugs] [Bug 13301] Call number link in search results is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13301 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 31 21:25:49 2014 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Dec 2014 20:25:49 +0000 Subject: [Koha-bugs] [Bug 13301] Call number link in search results is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13301 --- Comment #4 from Barton Chittenden --- (In reply to Katrin Fischer from comment #3) > One difference could be the type of indexing (GRS1, DOM) or using/not using > QP. No, both sites are using DOM, and neither is using QP. -- You are receiving this mail because: You are watching all bug changes.