[Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211

--- Comment #46 from Magnus Enger <magnus at enger.priv.no> ---
I have provided a followup in attachment 34040 that should take care of most of
the problems I have found. This probably needs a signoff. If this followup
meets with approval, I think there is still one question that needs to be
addressed:

Jonatahan, comment 5: "Could you explain why you changed "holiday" with "event"
and you removed "Holiday exception" please?"

Me, comment 32: "4. With this patch applied you now get to choose if the
library is open or closed when you add an event. As far as I can tell, the
special_holidays.isexception field is used to record open/closed. But the
description for this field is "is this a holiday exception to a repeatable
holiday (1 for yes, 0 for no)". Is open/closed a sensible use/interpretation of
this field? I am not sure of the usage, so I am only raising this as a
question."

To rephrase: Does the repurposing of special_holidays.isexception to store
open/closed make sense, and does it mean we loose some functionality connected
to making exceptions from repeating holidays?

-- 
You are receiving this mail because:
You are watching all bug changes.