[Koha-bugs] [Bug 13364] Add a call number browser in item edition page

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #10 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Preliminary QA comment:

function Clic$function_name(i) {
    q = \$('[id^= \"tag_952_subfield_o\"]').val();
   
window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=cn_browser.pl&popup&q=\"+q,\"cnbrowser\",\"width=500,height=400,toolbar=false,scrollbars=yes\");

Please do not do it like that. Now you hardcoded the field while it is passed
to you in a parameter. Also normally we pass index and value to the plugin in
the URL. If you include your parameter i in the URL with something like index=i
you can do this:
    var q=\$('#'+i).val();
    window.open(... index="+i+"& ... )

And if you pass index via sub plugin to the template too, you can use it there
if needed also. (In a popup you would use it when putting back the value in the
field.)

Also I am not sure what you are doing with the 'popup' parameter. You put it in
the URL without a value. Later you are checking the value of popup. This is
actually useless?

-- 
You are receiving this mail because:
You are watching all bug changes.