[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10517|0                           |1
        is obsolete|                            |
  Attachment #10936|0                           |1
        is obsolete|                            |
  Attachment #10938|0                           |1
        is obsolete|                            |
  Attachment #10949|0                           |1
        is obsolete|                            |
  Attachment #10958|0                           |1
        is obsolete|                            |
  Attachment #10965|0                           |1
        is obsolete|                            |
  Attachment #10967|0                           |1
        is obsolete|                            |
  Attachment #10972|0                           |1
        is obsolete|                            |
  Attachment #12224|0                           |1
        is obsolete|                            |
  Attachment #12491|0                           |1
        is obsolete|                            |
  Attachment #12492|0                           |1
        is obsolete|                            |

--- Comment #201 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 34191
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34191&action=edit
Bug 6679 - [SIGNED-OFF] fix 11 perlcritic violations in C4/Dates.pm

- Subroutine prototypes used at line 82, column 1.  See page 194 of PBP. 
(Severity: 5)

- "return" statement with explicit "undef" at line 102, column 28.  See page
199 of PBP.  (Severity: 5)

- Expression form of "eval" at line 108, column 20.  See page 161 of PBP. 
(Severity: 5)

- Variable declared in conditional statement at line 126, column 5.  Declare
variables outside of the condition.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.